Re: [PATCH] Dynamic locking upcalls in mod_ssl

[Sander Temme]

On Aug 15, 2008, at 12:48 AM, Plüm, Rüdiger, VF-Group wrote:

1. Why creating a global pool for dynlockpool? Why can't this be a subpool

  of the pool passed to ssl_util_thread_setup?

Because that's the pconf pool and gets cleared across the lifetime of some of the mutexes that OpenSSL creates. I tried, and using pconf made the httpd parent hang on shutdown, in a tight loop trying to clear one of its pools...

2. I would prefer to name the apr_status_t variables rv instead of r.
  r is normally reserved for the request :-).

Absolutely.

S.

--
Sander Temme
[EMAIL PROTECTED]
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF

smime.p7s
Description: S/MIME cryptographic signature