> -----Ursprüngliche Nachricht----- > Von: Sander Temme > Gesendet: Freitag, 15. August 2008 07:04 > An: [email protected] > Betreff: [PATCH] Dynamic locking upcalls in mod_ssl > > Folks, > > The following patch against trunk adds dynamic locking callbacks to > mod_ssl. OpenSSL uses these in several places, including the CHIL > engine that interfaces with the nCipher products. I work at > nCipher, > and this patch makes the CHIL engine load into a stock, unpatched > openssl 0.9.8. > > I've tested this on Linux (Ubuntu 7.10 w/ OpensSSL > 0.9.8e-5ubuntu3.2) > and put some load on this on Solaris 10 x86_64 with OpenSSL 0.9.8h. > It's not a lot of code, and I don't think it gets in anyone's way. > Opinions appreciated, especially on whether I'm doing the > right thing > with that pool:
Two quick comments: 1. Why creating a global pool for dynlockpool? Why can't this be a subpool of the pool passed to ssl_util_thread_setup? 2. I would prefer to name the apr_status_t variables rv instead of r. r is normally reserved for the request :-). Regards Rüdiger
