Re: Make loglevel of File does not exist configurable
On 05.10.2011 02:38, William A. Rowe Jr. wrote: On 10/4/2011 1:00 PM, Stefan Fritsch wrote: I think this one has been controversial in the past, therefore I thought I'd ask for comments before making this change: I believe you are right, but I don't see a reason for the extra directive... The File does not exist log messages are logged at level error, while not providing additional information over the 404 access log line (at least in many setups). There have been requests to lower the loglevel for these messages (PR 35768), which have been denied in the past because of compatibility and it's an error. The per-module loglevels help not much, because most of the File does not exist messages come from core, and one usually does not want to set LogLevel core:crit. As you say, it *is* logged (404) and is *not* an administrator's error (either the web content has invalid links, someone ELSE'S web content has invalid links, or the user is simply trying arbitrary resource names. Ergo, this is not a [warn]. Never was. Because we are talking about *user input* which has no negative connotations except to the user. Proposed, we drop this to [info] or [debug] and be done with it already. I therefore intend to add a LogLevelFileNotFound config directive that allows to make it configurable and a int ap_loglevel_file_not_found(request_rec *) API that allows modules to query the setting. I think per-virtual server would be enough for the setting, but with this API that could be changed to per-dir later on. Sounds like a bikeshed. I suggest we simply tear it down and replace this with greenspace, nothing to be confused by, nothing to fill up loglevel warn logs. I agree that this log message does more harm than use. In most cases people ignore it but don't see any additional useful messages, because they are to lazy to grep the file not found away. So I also suggest to tone it down to info and if it makes sense and isn't to risky move the default_handler into the http module. I would not add a separate config option, because that opens a can of worms: everyone has a favourite annoying log message he or she wants to tone down. Level info for this message is the better default and whether there needs to be a separate apparatus to control some message levels is another discussion with much bigger impact. Regards, Rainer
Re: Make loglevel of File does not exist configurable
On Tue, 4 Oct 2011, Daniel Ruggeri wrote: On 10/4/2011 2:12 PM, Graham Leggett wrote: On 04 Oct 2011, at 8:00 PM, Stefan Fritsch wrote: I think this one has been controversial in the past, therefore I thought I'd ask for comments before making this change: The File does not exist log messages are logged at level error, while not providing additional information over the 404 access log line (at least in many setups). There have been requests to lower the loglevel for these messages (PR 35768), which have been denied in the past because of compatibility and it's an error. The per-module loglevels help not much, because most of the File does not exist messages come from core, and one usually does not want to set LogLevel core:crit. I therefore intend to add a LogLevelFileNotFound config directive that allows to make it configurable and a int ap_loglevel_file_not_found(request_rec *) API that allows modules to query the setting. I think per-virtual server would be enough for the setting, but with this API that could be changed to per-dir later on. Hmmm... it seems unclean to me and counterintuitive. Definitely unclean. From the comments in the PR I got the impression that changing the loglevel was not an option. But I would definitely prefer changing it rather than adding an additional directive. How about moving the default_handler() into the http module? Big +1 on achieving this objective. One question, though, about moving the handler into http... Does that also imply adjusting the logging level by using http:crit? Wouldn't we swallow several other important messages by changing logging levels there? Yes, IMO moving the default_handler around doesn't solve the problem (and similar messages are logged by mod_action and mod_asis at level error, too). Besides, default_handler() mostly deals with stuff from core_dir_config. It's not obvious that it would fit better in mod_http, IMHO.
Make loglevel of File does not exist configurable
Hi, I think this one has been controversial in the past, therefore I thought I'd ask for comments before making this change: The File does not exist log messages are logged at level error, while not providing additional information over the 404 access log line (at least in many setups). There have been requests to lower the loglevel for these messages (PR 35768), which have been denied in the past because of compatibility and it's an error. The per-module loglevels help not much, because most of the File does not exist messages come from core, and one usually does not want to set LogLevel core:crit. I therefore intend to add a LogLevelFileNotFound config directive that allows to make it configurable and a int ap_loglevel_file_not_found(request_rec *) API that allows modules to query the setting. I think per-virtual server would be enough for the setting, but with this API that could be changed to per-dir later on. Any objections? Cheers, Stefan
Re: Make loglevel of File does not exist configurable
On 04 Oct 2011, at 8:00 PM, Stefan Fritsch wrote: I think this one has been controversial in the past, therefore I thought I'd ask for comments before making this change: The File does not exist log messages are logged at level error, while not providing additional information over the 404 access log line (at least in many setups). There have been requests to lower the loglevel for these messages (PR 35768), which have been denied in the past because of compatibility and it's an error. The per- module loglevels help not much, because most of the File does not exist messages come from core, and one usually does not want to set LogLevel core:crit. I therefore intend to add a LogLevelFileNotFound config directive that allows to make it configurable and a int ap_loglevel_file_not_found(request_rec *) API that allows modules to query the setting. I think per-virtual server would be enough for the setting, but with this API that could be changed to per-dir later on. Hmmm... it seems unclean to me and counterintuitive. How about moving the default_handler() into the http module? Regards, Graham -- smime.p7s Description: S/MIME cryptographic signature
Re: Make loglevel of File does not exist configurable
On 10/4/2011 2:12 PM, Graham Leggett wrote: On 04 Oct 2011, at 8:00 PM, Stefan Fritsch wrote: I think this one has been controversial in the past, therefore I thought I'd ask for comments before making this change: The File does not exist log messages are logged at level error, while not providing additional information over the 404 access log line (at least in many setups). There have been requests to lower the loglevel for these messages (PR 35768), which have been denied in the past because of compatibility and it's an error. The per-module loglevels help not much, because most of the File does not exist messages come from core, and one usually does not want to set LogLevel core:crit. I therefore intend to add a LogLevelFileNotFound config directive that allows to make it configurable and a int ap_loglevel_file_not_found(request_rec *) API that allows modules to query the setting. I think per-virtual server would be enough for the setting, but with this API that could be changed to per-dir later on. Hmmm... it seems unclean to me and counterintuitive. How about moving the default_handler() into the http module? Regards, Graham -- Big +1 on achieving this objective. One question, though, about moving the handler into http... Does that also imply adjusting the logging level by using http:crit? Wouldn't we swallow several other important messages by changing logging levels there? -- Daniel Ruggeri
Re: Make loglevel of File does not exist configurable
On 10/4/2011 1:00 PM, Stefan Fritsch wrote: I think this one has been controversial in the past, therefore I thought I'd ask for comments before making this change: I believe you are right, but I don't see a reason for the extra directive... The File does not exist log messages are logged at level error, while not providing additional information over the 404 access log line (at least in many setups). There have been requests to lower the loglevel for these messages (PR 35768), which have been denied in the past because of compatibility and it's an error. The per-module loglevels help not much, because most of the File does not exist messages come from core, and one usually does not want to set LogLevel core:crit. As you say, it *is* logged (404) and is *not* an administrator's error (either the web content has invalid links, someone ELSE'S web content has invalid links, or the user is simply trying arbitrary resource names. Ergo, this is not a [warn]. Never was. Because we are talking about *user input* which has no negative connotations except to the user. Proposed, we drop this to [info] or [debug] and be done with it already. I therefore intend to add a LogLevelFileNotFound config directive that allows to make it configurable and a int ap_loglevel_file_not_found(request_rec *) API that allows modules to query the setting. I think per-virtual server would be enough for the setting, but with this API that could be changed to per-dir later on. Sounds like a bikeshed. I suggest we simply tear it down and replace this with greenspace, nothing to be confused by, nothing to fill up loglevel warn logs.
