Re: Removal of ignite ml module (or moving it to extensions)
Ivan, > Actually, I haven't found any integration with tensorflow in AI code. Ok. You are right. Tensorflow is mentioned in docs: docs/_docs/setup.adoc. Adapters may require compilation time dependencies, but these dependencies shouldn't be part or release package, regardless whether the ML module is a part of Ignite or extensions. WDYT? On Thu, Aug 10, 2023 at 1:36 PM Ivan Daschinsky wrote: > Actually, I haven't found any integration with tensorflow in AI code. > Actually, all integrations are some adapters that allow to load pretrained > models (h2o, catboost etc.) > > чт, 10 авг. 2023 г. в 13:08, Ivan Daschinsky : > > > I am personally for moving to extensions. Alex has already mentioned all > > the reasons why it should be done and all of them are quite important. > > The module seems to be quite independent and there is no problem to move > > it to ignite-extensions. > > So I am +1 for moving to ignite-extensions. > > > > > > чт, 10 авг. 2023 г. в 12:45, Kseniya Romanova : > > > >> > > >> > do you know anyone who uses it? > >> > >> I know some teams, who do. At the last Ignite Summit we had a talk > >> featuring Ml module (from the Groovy community). > >> Anyway, We need here the module maintainer opinion > >> + Alex > >> > >> On Wed, Aug 9, 2023 at 3:38 PM Andrey Mashenkov < > >> andrey.mashen...@gmail.com> > >> wrote: > >> > >> > -1 for removal. > >> > 0 for relocation > >> > > >> > imho, TC resources and module size aren't good arguments for > >> > removal/moving. > >> > ML tests could be run nightly. > >> > ML module contains few integrations (with TensorFlow and other), these > >> > optional integrations are wighty and could be moved to extension, > >> > but core functionality still can be left untouched if it is highly > >> coupled > >> > with core Ignite and moving to extension is hard. > >> > > >> > > >> > On Wed, Aug 9, 2023 at 3:22 PM Anton Vinogradov > wrote: > >> > > >> > > +1 to relocation > >> > > > >> > > On Wed, Aug 9, 2023 at 3:09 PM Alex Plehanov < > plehanov.a...@gmail.com > >> > > >> > > wrote: > >> > > > >> > > > Pavel, do you know anyone who uses it? > >> > > > > >> > > > Looks like it isn't used at all (no questions on mail lists, no > >> > > > tickets), but we spend developers time to build module with every > >> > > > Ignite rebuild, we spend users traffic to download module (ML with > >> > > > dependencies takes about 1/4 of our binary release package size) > and > >> > > > we spend team-city resources to test module. > >> > > > > >> > > > +1 for removing or moving to extensions. > >> > > > > >> > > > ср, 9 авг. 2023 г. в 14:19, Pavel Tupitsyn >: > >> > > > > > >> > > > > Does it have any outstanding issues? A stable and useful module > >> > should > >> > > > not > >> > > > > be removed just because it does not evolve. > >> > > > > > >> > > > > On Wed, Aug 9, 2023 at 1:46 PM Ivan Daschinsky < > >> ivanda...@apache.org > >> > > > >> > > > wrote: > >> > > > > > >> > > > > > Igniters, seems that this module is completely abandoned for > >> more > >> > > than > >> > > > 2 > >> > > > > > years. But it is enormous and it seems that nobody wants to > take > >> > care > >> > > > of > >> > > > > > it. I suggest just removing it or moving it to extensions (as > >> > > option). > >> > > > > > WDYT? > >> > > > > > > >> > > > > >> > > > >> > > >> > > >> > -- > >> > Best regards, > >> > Andrey V. Mashenkov > >> > > >> > > > > > > -- > > Sincerely yours, Ivan Daschinskiy > > > > > -- > Sincerely yours, Ivan Daschinskiy > -- Best regards, Andrey V. Mashenkov
Re: Removal of ignite ml module (or moving it to extensions)
Actually, I haven't found any integration with tensorflow in AI code. Actually, all integrations are some adapters that allow to load pretrained models (h2o, catboost etc.) чт, 10 авг. 2023 г. в 13:08, Ivan Daschinsky : > I am personally for moving to extensions. Alex has already mentioned all > the reasons why it should be done and all of them are quite important. > The module seems to be quite independent and there is no problem to move > it to ignite-extensions. > So I am +1 for moving to ignite-extensions. > > > чт, 10 авг. 2023 г. в 12:45, Kseniya Romanova : > >> > >> > do you know anyone who uses it? >> >> I know some teams, who do. At the last Ignite Summit we had a talk >> featuring Ml module (from the Groovy community). >> Anyway, We need here the module maintainer opinion >> + Alex >> >> On Wed, Aug 9, 2023 at 3:38 PM Andrey Mashenkov < >> andrey.mashen...@gmail.com> >> wrote: >> >> > -1 for removal. >> > 0 for relocation >> > >> > imho, TC resources and module size aren't good arguments for >> > removal/moving. >> > ML tests could be run nightly. >> > ML module contains few integrations (with TensorFlow and other), these >> > optional integrations are wighty and could be moved to extension, >> > but core functionality still can be left untouched if it is highly >> coupled >> > with core Ignite and moving to extension is hard. >> > >> > >> > On Wed, Aug 9, 2023 at 3:22 PM Anton Vinogradov wrote: >> > >> > > +1 to relocation >> > > >> > > On Wed, Aug 9, 2023 at 3:09 PM Alex Plehanov > > >> > > wrote: >> > > >> > > > Pavel, do you know anyone who uses it? >> > > > >> > > > Looks like it isn't used at all (no questions on mail lists, no >> > > > tickets), but we spend developers time to build module with every >> > > > Ignite rebuild, we spend users traffic to download module (ML with >> > > > dependencies takes about 1/4 of our binary release package size) and >> > > > we spend team-city resources to test module. >> > > > >> > > > +1 for removing or moving to extensions. >> > > > >> > > > ср, 9 авг. 2023 г. в 14:19, Pavel Tupitsyn : >> > > > > >> > > > > Does it have any outstanding issues? A stable and useful module >> > should >> > > > not >> > > > > be removed just because it does not evolve. >> > > > > >> > > > > On Wed, Aug 9, 2023 at 1:46 PM Ivan Daschinsky < >> ivanda...@apache.org >> > > >> > > > wrote: >> > > > > >> > > > > > Igniters, seems that this module is completely abandoned for >> more >> > > than >> > > > 2 >> > > > > > years. But it is enormous and it seems that nobody wants to take >> > care >> > > > of >> > > > > > it. I suggest just removing it or moving it to extensions (as >> > > option). >> > > > > > WDYT? >> > > > > > >> > > > >> > > >> > >> > >> > -- >> > Best regards, >> > Andrey V. Mashenkov >> > >> > > > -- > Sincerely yours, Ivan Daschinskiy > -- Sincerely yours, Ivan Daschinskiy
Re: Removal of ignite ml module (or moving it to extensions)
I am personally for moving to extensions. Alex has already mentioned all the reasons why it should be done and all of them are quite important. The module seems to be quite independent and there is no problem to move it to ignite-extensions. So I am +1 for moving to ignite-extensions. чт, 10 авг. 2023 г. в 12:45, Kseniya Romanova : > > > > do you know anyone who uses it? > > I know some teams, who do. At the last Ignite Summit we had a talk > featuring Ml module (from the Groovy community). > Anyway, We need here the module maintainer opinion > + Alex > > On Wed, Aug 9, 2023 at 3:38 PM Andrey Mashenkov < > andrey.mashen...@gmail.com> > wrote: > > > -1 for removal. > > 0 for relocation > > > > imho, TC resources and module size aren't good arguments for > > removal/moving. > > ML tests could be run nightly. > > ML module contains few integrations (with TensorFlow and other), these > > optional integrations are wighty and could be moved to extension, > > but core functionality still can be left untouched if it is highly > coupled > > with core Ignite and moving to extension is hard. > > > > > > On Wed, Aug 9, 2023 at 3:22 PM Anton Vinogradov wrote: > > > > > +1 to relocation > > > > > > On Wed, Aug 9, 2023 at 3:09 PM Alex Plehanov > > > wrote: > > > > > > > Pavel, do you know anyone who uses it? > > > > > > > > Looks like it isn't used at all (no questions on mail lists, no > > > > tickets), but we spend developers time to build module with every > > > > Ignite rebuild, we spend users traffic to download module (ML with > > > > dependencies takes about 1/4 of our binary release package size) and > > > > we spend team-city resources to test module. > > > > > > > > +1 for removing or moving to extensions. > > > > > > > > ср, 9 авг. 2023 г. в 14:19, Pavel Tupitsyn : > > > > > > > > > > Does it have any outstanding issues? A stable and useful module > > should > > > > not > > > > > be removed just because it does not evolve. > > > > > > > > > > On Wed, Aug 9, 2023 at 1:46 PM Ivan Daschinsky < > ivanda...@apache.org > > > > > > > wrote: > > > > > > > > > > > Igniters, seems that this module is completely abandoned for more > > > than > > > > 2 > > > > > > years. But it is enormous and it seems that nobody wants to take > > care > > > > of > > > > > > it. I suggest just removing it or moving it to extensions (as > > > option). > > > > > > WDYT? > > > > > > > > > > > > > > > > > > > -- > > Best regards, > > Andrey V. Mashenkov > > > -- Sincerely yours, Ivan Daschinskiy
Re: Removal of ignite ml module (or moving it to extensions)
> > do you know anyone who uses it? I know some teams, who do. At the last Ignite Summit we had a talk featuring Ml module (from the Groovy community). Anyway, We need here the module maintainer opinion + Alex On Wed, Aug 9, 2023 at 3:38 PM Andrey Mashenkov wrote: > -1 for removal. > 0 for relocation > > imho, TC resources and module size aren't good arguments for > removal/moving. > ML tests could be run nightly. > ML module contains few integrations (with TensorFlow and other), these > optional integrations are wighty and could be moved to extension, > but core functionality still can be left untouched if it is highly coupled > with core Ignite and moving to extension is hard. > > > On Wed, Aug 9, 2023 at 3:22 PM Anton Vinogradov wrote: > > > +1 to relocation > > > > On Wed, Aug 9, 2023 at 3:09 PM Alex Plehanov > > wrote: > > > > > Pavel, do you know anyone who uses it? > > > > > > Looks like it isn't used at all (no questions on mail lists, no > > > tickets), but we spend developers time to build module with every > > > Ignite rebuild, we spend users traffic to download module (ML with > > > dependencies takes about 1/4 of our binary release package size) and > > > we spend team-city resources to test module. > > > > > > +1 for removing or moving to extensions. > > > > > > ср, 9 авг. 2023 г. в 14:19, Pavel Tupitsyn : > > > > > > > > Does it have any outstanding issues? A stable and useful module > should > > > not > > > > be removed just because it does not evolve. > > > > > > > > On Wed, Aug 9, 2023 at 1:46 PM Ivan Daschinsky > > > > wrote: > > > > > > > > > Igniters, seems that this module is completely abandoned for more > > than > > > 2 > > > > > years. But it is enormous and it seems that nobody wants to take > care > > > of > > > > > it. I suggest just removing it or moving it to extensions (as > > option). > > > > > WDYT? > > > > > > > > > > > > > -- > Best regards, > Andrey V. Mashenkov >
