Re: [disccuss] Apache IoTDB 0.9.0 incubating RC1 release
Hi Justin, > I’m not sure that is the right solution. Was this file developed at the ASF or elsewhere? My understanding is that it come from a 3rd party and thus should not have an ASF header but a 3rd party one. Be sure to mention what license it is under in the LICENSE file as well. (I guess that) the file comes from [1], but I am not sure because Chris added it into the project. (Chris is also the maintainer of the file according to the records on Github of [1]). I added a declarison in License file from 0.8.1 version: ``` The following class is modified from Maven Wrapper ./.mvn/wrapper/MavenWrapperDownloader.java ``` And, in [1] originally has an ASF header. So maybe it is fine to add an ASF header in the file in our project. [1] https://github.com/takari/maven-wrapper/blob/master/.mvn/wrapper/MavenWrapperDownloader.java Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean 于2019年11月15日周五 上午10:20写道： > Hi, > > >> - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say > > > > I checked [1], it should be " Copyright 2001-2019 The Apache Software > > Foundation” > > Probably you just want "Copyright 2019” I think, as they are the only > years that IoTDB have made a release. > > >> - NOTICE is missing information from from the common NOTICE file [1][3] > > > > Hi, @Justin, are you meaning the following guidance? " Copyright > > notifications which have been relocated from source files (rather than > > removed) must be preserved in NOTICE. However, elements such as the > > copyright notifications embedded within BSD and MIT licenses need not be > > duplicated in NOTICE -- it suffices to leave those notices in their > > original locations.” > > No, it’s this: "If the dependency supplies a NOTICE file, its contents > must be analyzed and the relevant portions bubbled up into the top-level > NOTICE file." > > > Hi Justin, I have added the ASF header on release-0.8.1, but forgot to > > cherry-pick the modifications to the master… > > I’m not sure that is the right solution. Was this file developed at the > ASF or elsewhere? My understanding is that it come from a 3rd party and > thus should not have an ASF header but a 3rd party one. Be sure to mention > what license it is under in the LICENSE file as well. > > Thanks, > Justin
Re: [disccuss] Apache IoTDB 0.9.0 incubating RC1 release
Hi, >> - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say > > I checked [1], it should be " Copyright 2001-2019 The Apache Software > Foundation” Probably you just want "Copyright 2019” I think, as they are the only years that IoTDB have made a release. >> - NOTICE is missing information from from the common NOTICE file [1][3] > > Hi, @Justin, are you meaning the following guidance? " Copyright > notifications which have been relocated from source files (rather than > removed) must be preserved in NOTICE. However, elements such as the > copyright notifications embedded within BSD and MIT licenses need not be > duplicated in NOTICE -- it suffices to leave those notices in their > original locations.” No, it’s this: "If the dependency supplies a NOTICE file, its contents must be analyzed and the relevant portions bubbled up into the top-level NOTICE file." > Hi Justin, I have added the ASF header on release-0.8.1, but forgot to > cherry-pick the modifications to the master… I’m not sure that is the right solution. Was this file developed at the ASF or elsewhere? My understanding is that it come from a 3rd party and thus should not have an ASF header but a 3rd party one. Be sure to mention what license it is under in the LICENSE file as well. Thanks, Justin
[disccuss] Apache IoTDB 0.9.0 incubating RC1 release
Hi, > - LICENSE need to mention license of Maven Wrapper As Lei Rui and Justin pointed out some issues, I find it is my fault that some changes are not cherry-picked from rel/0.8 to master and rel/0.9. So, we need to scan the commitlogs between release-0.8.0 to release-0.8.1 and cherry-pick needed commitlogs to rel/0.9 and the master branch. @Jialin > - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say I checked [1], it should be " Copyright 2001-2019 The Apache Software Foundation" > - NOTICE is missing information from from the common NOTICE file [1][3] Hi, @Justin, are you meaning the following guidance? " Copyright notifications which have been relocated from source files (rather than removed) must be preserved in NOTICE. However, elements such as the copyright notifications embedded within BSD and MIT licenses need not be duplicated in NOTICE -- it suffices to leave those notices in their original locations." > large number of files have the incorrect ASF header. There should be no "Copyright © 2019 Apache IoTDB(incubating) If you are using IDEA to generate the ASF header on a new file, please fix them to avoid the same error in the future... > It is still unclear where the "Maven Wrapper” code comes from and the file is missing a license header. Hi Justin, I have added the ASF header on release-0.8.1, but forgot to cherry-pick the modifications to the master... > - There an unexpected binary file in the release [4] (maven-wrapper.jar) @Jialin, help me to add a step "rm .mvnw/wrapper/*.jar" on the Chinese Guidance on Apache Confluence. [1] https://github.com/apache/commons-collections/blob/master/NOTICE.txt [3] http://www.apache.org/dev/licensing-howto.html#alv2-dep Best, --- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC1 release
Hi, -`1 (binding) due to maven wrapper issue, LICENSE and NOTICE issues, header issues and compiled code in the release. Some of these have been brought up before and occurred before, what can be done to stop them happening again? As I also suggested before it’s best to use the work in progress DISCLAIMER [2] until you are sure that everything has been sorted. I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists - LICENSE need to mention license of Maven Wrapper - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say - NOTICE is missing information from from the common NOTICE file [1][3] - A large number of files have the incorrect ASF header. There should be no "Copyright © 2019 Apache IoTDB(incubating) (dev@iotdb.apache.org)” notice in the files. - There an unexpected binary file in the release [4] - Can compile from source (with and without the mavin wrapper) It is still unclear where the "Maven Wrapper” code comes from and the file is missing a license header. How is someone to know how this files is licensed or that the file is even under a compatible license? Thanks, Justin 1. https://github.com/apache/commons-collections/blob/master/NOTICE.txt 2. https://incubator.apache.org/policy/incubation.html#disclaimers 3. http://www.apache.org/dev/licensing-howto.html#alv2-dep 4 ./.mvn/wrapper/maven-wrapper.jar
[jira] [Created] (IOTDB-305) a sql to query a group of devices separately
Hi ,teacher qiao,
I think there's a little bit of ambiguity here , ‘root.ChangSha’ is a group,
but it was also involved in the naming of another device !
Or we don't allow TIMESERIES to be created directly under storage groups.
because, I think the introduction of "Table" ,the data will be confusing.
example：
+---++—+
Timedevice
speed
+---++—+
1970-01-01T08:00:00.001+08:00 | root.北京 | 1
+---++—+
1970-01-01T08:00:00.001+08:00 | root.北京.西城区 | 1
+---++—+
1970-01-01T08:00:00.001+08:00 | root.北京.西城区.老张的车 |1
+---++—+
> 在 2019年11月14日，下午5:28，Jialin Qiao 写道：
>
> Hi,
>
> The path from root to the last but one is device, which is like a table in
> relational databases.
>
>> CREATE TIMESERIES root.ChangSha.A.aa WITH DATATYPE=INT64, ENCODING=RLE;
>
> In this case, root.ChangSha.A is device.
>
>> CREATE TIMESERIES root.ChangSha.aa WITH DATATYPE=INT64, ENCODING=RLE;
>
> In this case, root.ChangSha is a device.
>
> Usually, we do not create a device under another device, which is weired.
>
> Thanks,
> --
> Jialin Qiao
> School of Software, Tsinghua University
>
> 乔嘉林
> 清华大学 软件学院
>
>> -原始邮件-
>> 发件人: "刘大伟" <13965...@qq.com>
>> 发送时间: 2019-11-14 14:18:42 (星期四)
>> 收件人: dev@iotdb.apache.org
>> 抄送:
>> 主题: [jira] [Created] (IOTDB-305) a sql to query a group of devices separately
>>
>> Hi,
>>
>> I have a question，
>>
>> SET STORAGE GROUP TO root.ChangSha;
>> CREATE TIMESERIES root.ChangSha.A.aa WITH DATATYPE=INT64, ENCODING=RLE;
>> CREATE TIMESERIES root.ChangSha.aa WITH DATATYPE=INT64, ENCODING=RLE;
>>
>>
>> insert into root.ChangSha.A(timestamp,aa) values(1,1);
>> insert into root.ChangSha(timestamp,aa) values(1,1);
>>
>>
>>
>> Select * from root.ChangSha where aa = 1
>>
>> Result will print :
>>
>> +---++--+
>> | Time |root.ChangSha.A.aa|
>> root.ChangSha.aa|
>> +---++--+
>> | 1970-01-01T08:00:00.001+08:00| 1 |
>> 1|
>> | 1970-01-01T08:00:00.002+08:00| null |
>> 1|
>> +---++—+
>>
>> Which field is device and how to group by ?
>>
>>
>>> 在 2019年11月14日，下午12:21，Jialin Qiao 写道：
>>>
>>> Hi,
>>>
"group by device" sql can't satisfy this demand. It is because the where
condition of "group by device" is shared by all devices.
>>>
>>> The "shared by all devices" is a little hard to comprehend. Many users are
>>> from relational databases.
>>> In relational databases, when querying a table, predicates are applied to
>>> each row.
>>> By default, IoTDB adopts table format: "time, series1, series2, ...,
>>> seriesN".
>>>
>>> For this scenario, what users really want is querying on a narrow table :
>>> "time, device, sensor1, sensor2, ..., sensor3".
>>> Maybe we need to introduce the concept of "Table", and enable users to
>>> choose which table that want to use by a "group by device" clause.
>>>
>>> Thanks,
>>> --
>>> Jialin Qiao
>>> School of Software, Tsinghua University
>>>
>>> 乔嘉林
>>> 清华大学 软件学院
>>>
-原始邮件-
发件人: "Lei Rui (Jira)"
发送时间: 2019-11-14 11:19:00 (星期四)
收件人: dev@iotdb.apache.org
抄送:
主题: [jira] [Created] (IOTDB-305) a sql to query a group of devices
separately
Lei Rui created IOTDB-305:
-
Summary: a sql to query a group of devices separately
Key: IOTDB-305
URL: https://issues.apache.org/jira/browse/IOTDB-305
Project: Apache IoTDB
Issue Type: New Feature
Reporter: Lei Rui
First of all, if Bob knows exactly what devices to query (root.sg.d1 and
root.sg.d2 in this case) , he can write sqls for every device:
{code:java}
sql1: select * from root.sg.d1 where s1=1
sql2: select * from root.sg.d2 where s1=1{code}
However, when there are many devices or devices are not specified in
advance, Bob wants to query like:
{code:java}
select * from root.sg.d1,root.sg.d2 where s1=1 (a demo
conception)
/ select * from root.sg.* where s1=1 (a demo conception)
{code}
to return the result same as the concatenation of the results of the
Re: [VOTE] Apache IoTDB 0.9.0 (incubating) RC1 release
Hi, my vote is -1(PPMC). The reason is that I ran "./mvn.sh install" and the build failed: ``` [ERROR] Errors: [ERROR] SeqTsFileRecoverTest.test:138 » NullPointer [ERROR] UnseqTsFileRecoverTest.test:147 » NullPointer ``` Sincerely Lei Rui On 11/14/2019 16:23，Jialin Qiao wrote： Hi all, Thanks to all of you for releasing. As a new release manager, I don't meet many troubles in the release process. Big thanks for Xiangdong's release document: (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130027555) Apache IoTDB (incubating) 0.9.0 is a major version with many exciting features. You can get the release notes in [5]. Apache IoTDB (Incubating) 0.9.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. If approved we will seek final release approval from the IPMC. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Release tag: release/0.9.0 Hash for the release tag: 4d5e3b3beb52a1e74422f95ddb652805bfef90a1 Per [3] "Before voting +1 PMC/PPMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheiotdb-1007 [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc1 [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release [5] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc1/RELEASE_NOTES.md Thanks, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院
[VOTE] Apache IoTDB 0.9.0 (incubating) RC1 release
Hi all, Thanks to all of you for releasing. As a new release manager, I don't meet many troubles in the release process. Big thanks for Xiangdong's release document: (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=130027555) Apache IoTDB (incubating) 0.9.0 is a major version with many exciting features. You can get the release notes in [5]. Apache IoTDB (Incubating) 0.9.0 has been staged under [2] and it’s time to vote on accepting it for release. All Maven artifacts are available under [1]. If approved we will seek final release approval from the IPMC. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Release tag: release/0.9.0 Hash for the release tag: 4d5e3b3beb52a1e74422f95ddb652805bfef90a1 Per [3] "Before voting +1 PMC/PPMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheiotdb-1007 [2] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc1 [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/IOTDB/Validating+a+staged+Release [5] https://dist.apache.org/repos/dist/dev/incubator/iotdb/0.9.0/rc1/RELEASE_NOTES.md Thanks, -- Jialin Qiao School of Software, Tsinghua University 乔嘉林 清华大学 软件学院
