Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1367161872
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -311,6 +313,10 @@ public void reindex() throws CommitFailedException,
IOException {
.build());
indexerSupport.postIndexWork(copyOnWriteStore);
+log.info("[TASK:FULL_INDEX_CREATION:START] Metrics {}",
MetricsFormatter.newBuilder()
Review Comment:
Yes, good catch. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
VladTheia commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1367159365
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -311,6 +313,10 @@ public void reindex() throws CommitFailedException,
IOException {
.build());
indexerSupport.postIndexWork(copyOnWriteStore);
+log.info("[TASK:FULL_INDEX_CREATION:START] Metrics {}",
MetricsFormatter.newBuilder()
Review Comment:
Here it should be `[TASK:FULL_INDEX_CREATION:END]`, right?
Besides this, the naming convention is fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on PR #1165: URL: https://github.com/apache/jackrabbit-oak/pull/1165#issuecomment-1772812649 > Please note that there could also be a case where the FFS has been built before hand and then the build FFS part here would simply read the system property and consume the built FFS from it's location - in which this total time could be misleading. If the FFS is provided as a system property, `IndexStoreSortStrategy.createSortedStoreFile()` will not be called. All the logging metrics for the Pipelined strategy is inside this method, so these phases will not be printed. https://github.com/apache/jackrabbit-oak/blob/abcfb39909afbaf58b436a9ad6e34998e864a833/oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java#L297-L319 But it's important for users to be aware that the metrics for download might not be printed if the FFS was already present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-9459: ConstraintViolationException in VersionManagerImplRestore w… [jackrabbit-oak]
reschke commented on code in PR #1146:
URL: https://github.com/apache/jackrabbit-oak/pull/1146#discussion_r1367012810
##
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/version/VersionableState.java:
##
@@ -285,43 +287,68 @@ private void restoreFrozen(@NotNull NodeBuilder frozen,
@NotNull NodeBuilder dest,
@NotNull VersionSelector selector)
throws RepositoryException, CommitFailedException {
-// 15.7.2 Restoring Type and Identifier
-restoreFrozenTypeAndUUID(frozen, dest);
-// 15.7.3 Restoring Properties
-for (PropertyState p : frozen.getProperties()) {
-if (BASIC_FROZEN_PROPERTIES.contains(p.getName())) {
-// ignore basic frozen properties we restored earlier
-continue;
-}
-int action = getOPV(dest, p);
-if (action == COPY || action == VERSION) {
-dest.setProperty(p);
-}
+//OAK-9459: if the NodeState is not empty, retrieve OPVs before
restoring types to avoid constraint violations
+boolean frozenTypeRestored = false;
+if (!dest.hasProperty(JCR_PRIMARYTYPE)) {
+// empty NodeState
+// 15.7.2 Restoring Type and Identifier
+restoreFrozenTypeAndUUID(frozen, dest);
+frozenTypeRestored = true;
}
+Map opvs = new HashMap<>();
for (PropertyState p : dest.getProperties()) {
String propName = p.getName();
-if (BASIC_PROPERTIES.contains(propName)) {
-continue;
-}
-if (frozen.hasProperty(propName)) {
-continue;
+if (!BASIC_PROPERTIES.contains(propName) &&
!frozen.hasProperty(propName)) {
+int action = getOPV(dest, p);
+switch (action) {
Review Comment:
can we just change that to
action != IGNORE
?
Or, actually, wouldn't it be clearer just to store all OPV states here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366999447
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-docker-junit-rule
+org.testcontainers
+testcontainers
+${testcontainers.version}
Review Comment:
I still don't get it.
If you believe that we have a general problem with how we maintain version
numbers of dependencies in oak-parent, please open a separate ticket and
explain the issue - for visibility and so that we can fix the problem
systematically.
Otherwise, please just stick with the project conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366990047
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-docker-junit-rule
+org.testcontainers
+testcontainers
+${testcontainers.version}
Review Comment:
Yes we do that, but to be sure that other modules inherit the same version
of dependency that is declared in parent module and does not transitively use
some other version of same dependency, it will always beneficial to define the
version in child modules to avoid dependency conflicts.
If test container dependency is transitively inherited from other
dependency, we can end up using some other version than the one defined in
parent pom
https://stackoverflow.com/questions/13074231/override-library-version-defined-in-parent-pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1366990047
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-docker-junit-rule
+org.testcontainers
+testcontainers
+${testcontainers.version}
Review Comment:
Yes we do that, but to be sure that other modules inherit the same version
of dependency that is declared in parent module and does not transitively use
some other version of same dependency, it will always beneficial to define the
version in child modules to avoid dependency conflicts.
https://stackoverflow.com/questions/13074231/override-library-version-defined-in-parent-pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366978776
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I have change the name used for the whole process to `FULL_INDEX_CREATION`.
I did not change the name of the upload phase because this is derived
automatically from existing code:
https://github.com/apache/jackrabbit-oak/blob/abcfb39909afbaf58b436a9ad6e34998e864a833/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/importer/IndexImporter.java#L131
Here is an example of how the metric messages look like currently for the
phases after building the FFS:
```
15:42:35.440 [main] INFO o.a.j.o.i.i.d.DocumentStoreIndexer -
[TASK:INDEXING:START] Starting indexing
16:22:26.236 [main] INFO o.a.j.o.i.i.d.DocumentStoreIndexer -
[TASK:INDEXING:END] Metrics: {"duration":"00:39:50","durationSeconds":2390}
16:22:26.236 [main] INFO o.a.j.o.i.i.d.DocumentStoreIndexer -
[TASK:MERGE_NODE_STORE:START] Starting merge node store
16:22:26.237 [main] INFO o.a.j.o.i.i.d.DocumentStoreIndexer -
[TASK:MERGE_NODE_STORE:END] Metrics: {"duration":"00:00:00","durationSeconds":0}
16:23:46.397 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:SWITCH_LANE:START]
16:23:46.451 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:SWITCH_LANE:END] Metrics: {"duration":"00:00:00","durationSeconds":0}
16:23:46.452 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:IMPORT_INDEX_DATA:START]
16:29:48.386 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:IMPORT_INDEX_DATA:END] Metrics:
{"duration":"00:06:01","durationSeconds":361}
16:29:48.387 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:BRING_INDEX_UPTODATE:START]
16:31:23.963 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:BRING_INDEX_UPTODATE:END] Metrics:
{"duration":"00:01:35","durationSeconds":95}
16:31:23.964 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:RELEASE_CHECKPOINT:START]
16:31:23.969 [main] INFO o.a.j.o.p.i.importer.IndexImporter -
[TASK:RELEASE_CHECKPOINT:END] Metrics:
{"duration":"00:00:00","durationSeconds":0}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (JCR-4680) ConstraintViolationException in VersionManagerImplRestore when target node has a property definition unknown by the frozen node
[ https://issues.apache.org/jira/browse/JCR-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303262#comment-17303262 ] Julian Reschke edited comment on JCR-4680 at 10/20/23 1:05 PM: --- Interesting problem. Did you check whether the specification has an opinion about this case? (We may also want to check what Oak does here...). IIUC, the idea is that the restore operation should also remove the added mixin type, and thus succeed? Would be good to have a test for that in the TCK (jackrabbit-jcr-tests), so that it would also be used for other implementations of the JCR API. was (Author: reschke): Interesting problem. Did you check whether the specification has an opinion about this case? (We may also want to check what Oak does here...). IIUC, the idea is that the restore operation should also remove the added mixin type, and thus succeed? Would be good to have a test for that in the TCK (jackrabbir-jcr-tests), so that it would also be used for other implementations of the JCR API. > ConstraintViolationException in VersionManagerImplRestore when target node > has a property definition unknown by the frozen node > --- > > Key: JCR-4680 > URL: https://issues.apache.org/jira/browse/JCR-4680 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: versioning >Affects Versions: 2.20.2 >Reporter: Eduardo Perez Garcia >Priority: Major > Fix For: 2.22, 2.21.6, 2.20.4, 2.16.9 > > Attachments: JCR-4680-test.diff, VersionManagerImplRestore.patch > > > If we attempt to restore a frozen node from the version history, but the > target node has new property definitions (mixins), we get a > ConstraintViolationException because the properties of the new node are > processed after replacing its mixins with the mixins from the frozen node. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] OAK-10464: Use Testcontainers instead of com.arakelian:docker-junit-rule [jackrabbit-oak]
t-rana commented on PR #1143: URL: https://github.com/apache/jackrabbit-oak/pull/1143#issuecomment-1772704828 @smiroslav , its working fine on my system, I ran the same command and it executed successfully. % mvn clean install -Dtest=AzureRepositoryLockTest [INFO] Scanning for projects... [INFO] [INFO] --< org.apache.jackrabbit:oak-segment-azure >--- [INFO] Building Oak Segment Azure 1.59-SNAPSHOT [INFO] ---[ bundle ]--- [INFO] [INFO] --- maven-clean-plugin:3.2.0:clean (default-clean) @ oak-segment-azure --- [INFO] Deleting /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/target [INFO] [INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-maven-version) @ oak-segment-azure --- [INFO] [INFO] --- maven-enforcer-plugin:3.1.0:enforce (enforce-java-version) @ oak-segment-azure --- [INFO] [INFO] --- jacoco-maven-plugin:0.8.8:prepare-agent (pre-unit-test) @ oak-segment-azure --- [INFO] Skipping JaCoCo execution because property jacoco.skip is set. [INFO] test.opts.coverage set to empty [INFO] [INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ oak-segment-azure --- [INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4 [INFO] Copying 3 resources from 1 bundle. [INFO] [INFO] --- maven-resources-plugin:3.3.0:resources (default-resources) @ oak-segment-azure --- [INFO] skip non existing resourceDirectory /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/main/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ oak-segment-azure --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 21 source files to /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/target/classes [INFO] /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java: /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java uses or overrides a deprecated API. [INFO] /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java: Recompile with -Xlint:deprecation for details. [INFO] [INFO] --- maven-bundle-plugin:5.1.8:manifest (scr-metadata) @ oak-segment-azure --- [INFO] No MANIFEST.MF file found, generating manifest. [WARNING] Manifest org.apache.jackrabbit:oak-segment-azure:bundle:1.59-SNAPSHOT : Export com.microsoft.azure.storage, has 4, private references [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table] [WARNING] Manifest org.apache.jackrabbit:oak-segment-azure:bundle:1.59-SNAPSHOT : Export com.microsoft.azure.storage.core, has 2, private references [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table] [WARNING] Manifest org.apache.jackrabbit:oak-segment-azure:bundle:1.59-SNAPSHOT : Export com.microsoft.azure.storage.blob, has 2, private references [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file] [INFO] Writing manifest: /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/target/classes/META-INF/MANIFEST.MF [INFO] [INFO] --- maven-resources-plugin:3.3.0:testResources (default-testResources) @ oak-segment-azure --- [INFO] Copying 2 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ oak-segment-azure --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 27 source files to /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/target/test-classes [INFO] /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/fixture/SegmentAzureFixture.java: /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/fixture/SegmentAzureFixture.java uses or overrides a deprecated API. [INFO] /Users/trana/Desktop/PROJECTS/jackrabbit-oak/oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/fixture/SegmentAzureFixture.java: Recompile with -Xlint:deprecation for details. [INFO] [INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ oak-segment-azure --- [INFO] [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.jackrabbit.oak.segment.azure.AzureRepositoryLockTest [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 74.816 s - in org.apache.jackrab
[jira] [Updated] (JCR-4946) Cleanup lock discovery and add test cases for the case sensitivity of lock tokens
[ https://issues.apache.org/jira/browse/JCR-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4946: Attachment: jcr-4946.patch > Cleanup lock discovery and add test cases for the case sensitivity of lock > tokens > - > > Key: JCR-4946 > URL: https://issues.apache.org/jira/browse/JCR-4946 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4946.patch > > > The method ActiveLock#isLockedByToken(String lockToken) is implemented at > several places, but only needs one implementation in AbstractActiveLock. > Also, the case sensitivity of the lock token comparison is not tested . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4946) Cleanup lock discovery and add test cases for the case sensitivity of lock tokens
[ https://issues.apache.org/jira/browse/JCR-4946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4946: Attachment: (was: jcr-4946.patch) > Cleanup lock discovery and add test cases for the case sensitivity of lock > tokens > - > > Key: JCR-4946 > URL: https://issues.apache.org/jira/browse/JCR-4946 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: jcr-4946.patch > > > The method ActiveLock#isLockedByToken(String lockToken) is implemented at > several places, but only needs one implementation in AbstractActiveLock. > Also, the case sensitivity of the lock token comparison is not tested . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4570) WebdavRequestImpl does not check ETags if there is no resource or no exclusive write lock
[ https://issues.apache.org/jira/browse/JCR-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4570: Labels: candidate_jackrabbit_2_20 (was: ) > WebdavRequestImpl does not check ETags if there is no resource or no > exclusive write lock > - > > Key: JCR-4570 > URL: https://issues.apache.org/jira/browse/JCR-4570 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_jackrabbit_2_20 > Fix For: 2.22, 2.21.21 > > Attachments: JCR-4570.patch, jcr-4570-2.patch > > > Also other lock types are completely ignored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4570) WebdavRequestImpl does not check ETags if there is no resource or no exclusive write lock
[ https://issues.apache.org/jira/browse/JCR-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4570: Resolution: Fixed Status: Resolved (was: Patch Available) > WebdavRequestImpl does not check ETags if there is no resource or no > exclusive write lock > - > > Key: JCR-4570 > URL: https://issues.apache.org/jira/browse/JCR-4570 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 2.22, 2.21.21 > > Attachments: JCR-4570.patch, jcr-4570-2.patch > > > Also other lock types are completely ignored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4570) WebdavRequestImpl does not check ETags if there is no resource or no exclusive write lock
[ https://issues.apache.org/jira/browse/JCR-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated JCR-4570: Fix Version/s: 2.22 2.21.21 > WebdavRequestImpl does not check ETags if there is no resource or no > exclusive write lock > - > > Key: JCR-4570 > URL: https://issues.apache.org/jira/browse/JCR-4570 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 2.22, 2.21.21 > > Attachments: JCR-4570.patch, jcr-4570-2.patch > > > Also other lock types are completely ignored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (JCR-4570) WebdavRequestImpl does not check ETags if there is no resource or no exclusive write lock
[ https://issues.apache.org/jira/browse/JCR-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1732#comment-1732 ] Manfred Baedke commented on JCR-4570: - trunk (2.21.21): [1913142|https://svn.apache.org/viewvc?view=revision&revision=1913142] > WebdavRequestImpl does not check ETags if there is no resource or no > exclusive write lock > - > > Key: JCR-4570 > URL: https://issues.apache.org/jira/browse/JCR-4570 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Attachments: JCR-4570.patch, jcr-4570-2.patch > > > Also other lock types are completely ignored. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4571) WebdavRequestImpl stores If-Header values using either absolute URIs or absolute paths, but both may be used for lookup
[ https://issues.apache.org/jira/browse/JCR-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4571: Labels: candidate_jackrabbit_2_20 (was: ) > WebdavRequestImpl stores If-Header values using either absolute URIs or > absolute paths, but both may be used for lookup > --- > > Key: JCR-4571 > URL: https://issues.apache.org/jira/browse/JCR-4571 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-webdav >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_jackrabbit_2_20 > Fix For: 2.22, 2.21.21 > > Attachments: jcr-4571.patch > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4956: Fix Version/s: 2.22 > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 2.22, 2.21.21 > > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (JCR-4956) Replace deprecated Surefire fork options
[ https://issues.apache.org/jira/browse/JCR-4956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-4956: Labels: candidate_jackrabbit_2_20 (was: ) > Replace deprecated Surefire fork options > > > Key: JCR-4956 > URL: https://issues.apache.org/jira/browse/JCR-4956 > Project: Jackrabbit Content Repository > Issue Type: Task >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Labels: candidate_jackrabbit_2_20 > Fix For: 2.22, 2.21.21 > > Attachments: jcr-4956.patch > > > Some subprojects use the the deprecated Surefire option"forkMode" (or even > the option "fork", which AFAIK never existed). -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] OAK-10437 - Deprecate all Mongo download strategies except for Pipelined. [jackrabbit-oak]
fabriziofortino merged PR #1169: URL: https://github.com/apache/jackrabbit-oak/pull/1169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10505 - Make PIPELINED the default indexing strategy. [jackrabbit-oak]
fabriziofortino merged PR #1168: URL: https://github.com/apache/jackrabbit-oak/pull/1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366858089
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I'm ok with this proposal @fabriziofortino ? And others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nit0906 commented on PR #1165: URL: https://github.com/apache/jackrabbit-oak/pull/1165#issuecomment-1772495727 Please note that there could also be a case where the FFS has been built before hand and then the build FFS part here would simply read the system property and consume the built FFS from it's location - in which this total time could be misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10516: oak-segment-azure/oak-blob-cloud-azure: update embedded Guava to 32.1.3 [jackrabbit-oak]
sonarcloud[bot] commented on PR #1178: URL: https://github.com/apache/jackrabbit-oak/pull/1178#issuecomment-1772472070 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=1178&metric=new_duplicated_lines_density&view=list)  The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
chibulcuteanu commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366763796
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I got confused by the method it was in: `reindex`. I think something more
generic should be used for the name (for the entire process) and not
`INDEXING_JOB`.
Some proposals:
- `Full Index Creation` - for the whole process
- `Indexing` - for the actual indexing process - we should also probably not
use `reindexing` anymore
- `Ingestion` - for the upload part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-6760: Convert oak-blob-cloud to OSGi R6 annotations [jackrabbit-oak]
reschke merged PR #1144: URL: https://github.com/apache/jackrabbit-oak/pull/1144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
chibulcuteanu commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366763796
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I got confused by the method it was in: `reindex`. I think something more
generic should be used for the name (for the entire process) and not
`INDEXING_JOB`.
Some proposals:
- `Full Index Creation` - for the whole process
- 'Indexing` - for the actual indexing process - we should also probably not
use `reindexing` anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366748885
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
The first idea that comes to my mind for `ingestion` is the upload phase.
And so far we have been using indexing to refer to the actual reindex
operation, so it would be a change of terminology. But I'm ok with changing the
name and introducing a new term, if no one has a better proposal.
The changes to replace the current INDEXING references by INGESTION are
small on the Oak side. But users of Oak that are already parsing the logs for
the term INGESTION would have to be modified, but that is probably not much
work. Since this is a recent feature, it should not be an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
fabriziofortino commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366740979
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
Here is a proposal: the entire process is named `Indexing`. We can rename
the current `indexing` phase with `ingestion`. Not sure if this would require
too many changes though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
fabriziofortino commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366740979
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
Here is a proposal: the entire process is named `Indexing`. We can replace
the current `indexing` phase with `ingestion`. Not sure if this would require
too many changes though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366731245
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I was unsure about the name. Here we want to denote the full time of the
job, so including building the FFS, indexing, upload files, catchup. But one of
the phases of the job is the actual indexing. So if we use REINDEX for the
total duration and INDEXING for duration of indexing phase, this is also
confusing. I though that INDEXING_JOB would be a better name to denote the
total time, but I'm open to other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
nfsantos commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366731245
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I was unsure about the name. Here we want to denote the full time of the
job, so including building the FFS, indexing, upload files, catchup. But one of
the phases of the job is the actual indexing. So if we call reindex for the
total duration and indexing for duration of indexing, this is also confusing. I
though that INDEXING_JOB would be a better name to denote the total time, but
I'm open to other suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OAK-10505 - Make PIPELINED the default indexing strategy. [jackrabbit-oak]
nfsantos commented on PR #1168: URL: https://github.com/apache/jackrabbit-oak/pull/1168#issuecomment-1772377890 > the formatting is off? Or is it just here in github? I run the IntelliJ auto-formatter on the file, which fixed some parts where the indentation was not following the IntelliJ standard. I can rollback the formatting changes if you prefer. It would be nice to have an enforced auto-format standard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10516: oak-segment-azure/oak-blob-cloud-azure: update embedded Guava to 32.1.3 [jackrabbit-oak]
reschke merged PR #1178: URL: https://github.com/apache/jackrabbit-oak/pull/1178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (JCR-4954) Problem with WebDav Client and Repository Server Deployment Model
[ https://issues.apache.org/jira/browse/JCR-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1640#comment-1640 ] Manfred Baedke commented on JCR-4954: - [~c_koell], Re config: I'm more interested in the setup of the infrastructure. There has to be an spi2dav Repo setup somewhere for the WebDAV Servlet to act upon, no? > Problem with WebDav Client and Repository Server Deployment Model > - > > Key: JCR-4954 > URL: https://issues.apache.org/jira/browse/JCR-4954 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-jcr-server, jackrabbit-webdav >Reporter: Claus Köll >Assignee: Manfred Baedke >Priority: Major > Fix For: 2.22 > > Attachments: Call-Hierarchy.txt, JcrRemotingServlet.txt, > JcrRemotingServlet_2.txt, SimpleWebDavServlet.txt, SimpleWebDavServlet_2.txt, > config.xml, jcr-4954-diagnose.patch > > > We have one WebApp where we have deployed the SimpleWebDavServlet > (WebDav-WebApp). From there we connect to a other WebApp where we have > exposed a Repository through DavEx > (org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet) > and also the RMI-Layer by the RMI Registry (Repository-WebApp) > Until now we connected over RMI but now we tried to switch to DavEx. The > Problem is, that we are now unable to unlock a opened WebDav Document. > The Lock Request in the Repository-WebApp adds a Reference (LockToken) to the > DavSession so a future Requests can obtain the same DavSession to perform the > unlock. > https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/DefaultItemCollection.java#L700 > The Reference (Locktoken) looks like > opaquelocktoken:dccce564-412e-11e1-b969-00059a3c7a00:0089610c-02e5-43cd-bfec-3a90361350f4-0 > It will be generated by the LockTokenMapper > https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/lock/LockTokenMapper.java#L53 > In the WebDav-WebApp the HeaderLockToken will be stored in this format > opaquelocktoken:dccce564-412e-11e1-b969-00059a3c7a00:opaquelocktoken%3a4403ef44-4124-11e1-b965-00059a3c7a00%3a0089610c-02e5-43cd-bfec-3a90361350f4 > As you can see it will be double wrapped. That's not really a Problem because > on unlock the WebDav-WebApp removes the prefix > opaquelocktoken:dccce564-412e-11e1-b969-00059a3c7a00: > Finally this locktoken will be send from the WebDav-App to the > Repository-WebApp > opaquelocktoken:4403ef44-4124-11e1-b965-00059a3c7a00:0089610c-02e5-43cd-bfec-3a90361350f4 > On the Repository-WebApp the JCRWebdavServer will look for a DavSession in > the Cache based on the lockToken > https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/jcr/JCRWebdavServer.java#L210 > So the problem is that the DavSession whitch have created the Lock, is stored > with a lockToken that do not match with the incoming lockToken > Cache-Key-Token: > opaquelocktoken:dccce564-412e-11e1-b969-00059a3c7a00:0089610c-02e5-43cd-bfec-3a90361350f4-0 > Incoming-Token: > opaquelocktoken:4403ef44-4124-11e1-b965-00059a3c7a00:0089610c-02e5-43cd-bfec-3a90361350f4 > The DavSession-Cache Key is taken from the LockInfo (LockTokenCheckDigit is > present) > https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/lock/LockInfo.java#L118 > Maybe someone which is familiar with the code of LockTokenMapper can explain > the two different Scopes (SESSIONSCOPED/OPENSCOPED) > One possible solution could be to change the code in the LockTokenMapper to > always return the Node Identifier with the same SCOPE-PREFIX? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] OAK-10516: oak-segment-azure/oak-blob-cloud-azure: update embedded Guava to 32.1.3 [jackrabbit-oak]
reschke opened a new pull request, #1178: URL: https://github.com/apache/jackrabbit-oak/pull/1178 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OAK-10504- Add log messages with start and end of the indexing job. [jackrabbit-oak]
chibulcuteanu commented on code in PR #1165:
URL: https://github.com/apache/jackrabbit-oak/pull/1165#discussion_r1366674454
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -257,6 +257,8 @@ public FlatFileStore buildFlatFileStore() throws
IOException, CommitFailedExcept
}
public void reindex() throws CommitFailedException, IOException {
+log.info("[TASK:INDEXING_JOB:START] Starting indexing job");
Review Comment:
I'm a bit confused here. Isn't this reindexing? Why are we calling it
INDEXING JOB here? also the variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: VOTE: Migrate from Subversion to Git
[X] +1, migrate Jackrabbit to Git Regards Julian On Thu, Oct 12, 2023 at 6:57 AM Julian Reschke wrote: > > On 12.10.2023 06:55, Julian Reschke wrote: > > On 11.10.2023 19:58, Konrad Windszus wrote: > >> ... > > > > [X] +1, migrate Jackrabbit to Git > > > > Best regards, Julian > > ...and when we get to it, please be consistent with Oak (in naming the > dev branch "trunk"). > > Best regards, Julian
