[jira] [Created] (JENA-2261) UI: add unit tests
Bruno P. Kinoshita created JENA-2261: Summary: UI: add unit tests Key: JENA-2261 URL: https://issues.apache.org/jira/browse/JENA-2261 Project: Apache Jena Issue Type: Improvement Components: Fuseki Affects Versions: Jena 4.3.2 Reporter: Bruno P. Kinoshita Assignee: Bruno P. Kinoshita Fix For: Jena 4.4.0 Unit tests in JS for the new UI. Not a blocker as the app is small and we can manually cover most of the code functions. So not a problem if its FixVersion is bumped to the next-next release. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (JENA-2260) UI: build is modifying yarn.lock
Bruno P. Kinoshita created JENA-2260: Summary: UI: build is modifying yarn.lock Key: JENA-2260 URL: https://issues.apache.org/jira/browse/JENA-2260 Project: Apache Jena Issue Type: Bug Affects Versions: Jena 4.3.2 Reporter: Bruno P. Kinoshita Assignee: Bruno P. Kinoshita Fix For: Jena 4.4.0 Context: [https://lists.apache.org/thread/7qnw60pjtkbrz4gws0hx1zs3wx1cn4yp] Fix is bumping Yarn used by the Maven plug-in from 0.16 to 1.22. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (JENA-2258) LiteralLabelImpl: forward Throwabl, not only the message
[ https://issues.apache.org/jira/browse/JENA-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne resolved JENA-2258. - Fix Version/s: Jena 4.4.0 Assignee: Adam Soroka Resolution: Fixed > LiteralLabelImpl: forward Throwabl, not only the message > > > Key: JENA-2258 > URL: https://issues.apache.org/jira/browse/JENA-2258 > Project: Apache Jena > Issue Type: Improvement > Components: Core, Datatypes >Affects Versions: Jena 4.3.2 >Reporter: Jan Martin Keil >Assignee: Adam Soroka >Priority: Major > Fix For: Jena 4.4.0 > > > LiteralLabelImpl: forward Throwable instead of only the message to preserve > causes. > Pull request on https://github.com/apache/jena/pull/1170. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: Release/build issues
On 24/01/2022 20:37, Bruno Kinoshita wrote: The range of our UI dependencies is probably allowing for updates. When running `yarn install` it is either finding new versions that match the range (since the last time someone run yarn install and updated the lock file), or a developer modified a dependency in NPM (harder to happen I think). Would "integrity" lines be from a later version or from a local setting? I think the best options are either modify the version ranges, use a different version of Yarn to see if the issue is gone, or specify some parameter in Yarn to prevent it from updating (frozen-lock/immutable are available in newer versions) There were only a few entries changed due to the Busy with $work right now, should have some spare time during lunch time, or later this afternoon (~10AM here). Take lunch! It's not blocking the release - the RM can checkin in a build-acceptable yarn.lock file works and the build is reproducible. We can incremental improve as learn all the corner case that can turn up. The javadoc issue can be worked around by using a mater java and compiling for source=11. As long as some CI job passes the codebase we know no Java runtime library code has sneaked in. Then check the class file version number which I do anyway. Andy Cheers Bruno On Tue, 25 Jan 2022 at 08:55, Andy Seaborne wrote: On 24/01/2022 18:46, Bruno Kinoshita wrote: Taking a look at it today. In another project I bumped the version of Yarn to v3 (we are using v1 I think, v2 is stable, v3 is the greatest and latest). Will see if that solves the changes in the lock file, and also look why the build is failing. Thanks - if I run the build twice, the yarn.lock file does not get changed by run 2 from what it was on run 1 - hope that means it isn't a hash table issue. Andy On Tue, 25 Jan 2022 at 06:38, Andy Seaborne wrote: On 24/01/2022 13:16, Andy Seaborne wrote: 1/ jena-fuseki-ui When I run maven, the yarn.lock file is being changed. Most changes are to do with "integrity" beginning deleted. "@babel/core@^7.11.0": version "7.16.7" resolved " https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf " - integrity sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== dependencies: "@babel/code-frame" "^7.16.7" "@babel/generator" "^7.16.7" Some are reordering in the file. I'm not sure what's going to happen in a release build - it may check in the changes because it does other commits, or it might get upset that changes are happening while running. Can the update of yarn.lock be turned off? The build is failing https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ jena-fuseki-ui --- [INFO] Running 'yarn run build' in /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui [INFO] yarn run v0.16.1 [INFO] $ vue-cli-service build [INFO] [INFO] - Building for production... [INFO] ERROR Failed to compile with 1 error5:18:32 PM [INFO] [INFO] Syntax Error: TypeError: Cannot read properties of undefined (reading 'parseComponent') [INFO] guessing but could it be a version of problem with some tooling? Andy
Re: Release/build issues
On 24/01/2022 19:33, Øyvind Gjesdal wrote: I was building locally yesterday and got the same error message on the ui module. However when I deleted node_modules before building it completed successfully. Is there any cache on the apache CI build server or is there something else at work? Good thought - maybe it is the jenkins workspace. GH actions seem to fire up a new environment every time so a clean starting point. In Jenkins, jobs have a filesystem workspace - it doesn't check out a fresh copy every time, just goes a git fetch. Workspace wiped, rerun job ... job runs. Andy This was on main(afcd0ae394483010603a41be6756202cd2e9c41c) using `mvn -B verify -Pdev --file pom.xml` I also built using the Jena Github Actions, to confirm/deny the error, on my fork on the same sha ( https://github.com/OyvindLGjesdal/jena/runs/4926913070?check_suite_focus=true), and that was also completed without the error showing up. Best regards, Øyvind man. 24. jan. 2022 kl. 19:46 skrev Bruno Kinoshita : Taking a look at it today. In another project I bumped the version of Yarn to v3 (we are using v1 I think, v2 is stable, v3 is the greatest and latest). Will see if that solves the changes in the lock file, and also look why the build is failing. On Tue, 25 Jan 2022 at 06:38, Andy Seaborne wrote: On 24/01/2022 13:16, Andy Seaborne wrote: 1/ jena-fuseki-ui When I run maven, the yarn.lock file is being changed. Most changes are to do with "integrity" beginning deleted. "@babel/core@^7.11.0": version "7.16.7" resolved " https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf " - integrity sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== dependencies: "@babel/code-frame" "^7.16.7" "@babel/generator" "^7.16.7" Some are reordering in the file. I'm not sure what's going to happen in a release build - it may check in the changes because it does other commits, or it might get upset that changes are happening while running. Can the update of yarn.lock be turned off? The build is failing https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ jena-fuseki-ui --- [INFO] Running 'yarn run build' in /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui [INFO] yarn run v0.16.1 [INFO] $ vue-cli-service build [INFO] [INFO] - Building for production... [INFO] ERROR Failed to compile with 1 error5:18:32 PM [INFO] [INFO] Syntax Error: TypeError: Cannot read properties of undefined (reading 'parseComponent') [INFO] guessing but could it be a version of problem with some tooling? Andy
Re: Release/build issues
The range of our UI dependencies is probably allowing for updates. When running `yarn install` it is either finding new versions that match the range (since the last time someone run yarn install and updated the lock file), or a developer modified a dependency in NPM (harder to happen I think). I think the best options are either modify the version ranges, use a different version of Yarn to see if the issue is gone, or specify some parameter in Yarn to prevent it from updating (frozen-lock/immutable are available in newer versions) Busy with $work right now, should have some spare time during lunch time, or later this afternoon (~10AM here). Cheers Bruno On Tue, 25 Jan 2022 at 08:55, Andy Seaborne wrote: > > > On 24/01/2022 18:46, Bruno Kinoshita wrote: > > Taking a look at it today. In another project I bumped the version of > Yarn > > to v3 (we are using v1 I think, v2 is stable, v3 is the greatest and > > latest). Will see if that solves the changes in the lock file, and also > > look why the build is failing. > > Thanks - if I run the build twice, the yarn.lock file does not get > changed by run 2 from what it was on run 1 - hope that means it isn't a > hash table issue. > > Andy > > > > > On Tue, 25 Jan 2022 at 06:38, Andy Seaborne wrote: > > > >> > >> > >> On 24/01/2022 13:16, Andy Seaborne wrote: > >>> 1/ jena-fuseki-ui > >>> > >>> When I run maven, the yarn.lock file is being changed. > >>> > >>> Most changes are to do with "integrity" beginning deleted. > >>> > >>>"@babel/core@^7.11.0": > >>> version "7.16.7" > >>> resolved > >>> " > >> > https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf > " > >> > >>> > >>> - integrity > >>> > >> > sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== > >> > >>> > >>> dependencies: > >>>"@babel/code-frame" "^7.16.7" > >>>"@babel/generator" "^7.16.7" > >>> > >>> Some are reordering in the file. > >>> > >>> I'm not sure what's going to happen in a release build - it may check > in > >>> the changes because it does other commits, or it might get upset that > >>> changes are happening while running. > >>> > >>> Can the update of yarn.lock be turned off? > >> > >> The build is failing > >> > >> > https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console > >> > >> [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ > >> jena-fuseki-ui --- > >> [INFO] Running 'yarn run build' in > >> > >> > /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui > >> > >> [INFO] yarn run v0.16.1 > >> [INFO] $ vue-cli-service build > >> [INFO] > >> [INFO] - Building for production... > >> [INFO] ERROR Failed to compile with 1 error5:18:32 PM > >> [INFO] > >> [INFO] Syntax Error: TypeError: Cannot read properties of undefined > >> (reading 'parseComponent') > >> [INFO] > >> > >> guessing but could it be a version of problem with some tooling? > >> > >> Andy > >> > > >
Re: Release/build issues
On 24/01/2022 18:46, Bruno Kinoshita wrote: Taking a look at it today. In another project I bumped the version of Yarn to v3 (we are using v1 I think, v2 is stable, v3 is the greatest and latest). Will see if that solves the changes in the lock file, and also look why the build is failing. Thanks - if I run the build twice, the yarn.lock file does not get changed by run 2 from what it was on run 1 - hope that means it isn't a hash table issue. Andy On Tue, 25 Jan 2022 at 06:38, Andy Seaborne wrote: On 24/01/2022 13:16, Andy Seaborne wrote: 1/ jena-fuseki-ui When I run maven, the yarn.lock file is being changed. Most changes are to do with "integrity" beginning deleted. "@babel/core@^7.11.0": version "7.16.7" resolved " https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf; - integrity sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== dependencies: "@babel/code-frame" "^7.16.7" "@babel/generator" "^7.16.7" Some are reordering in the file. I'm not sure what's going to happen in a release build - it may check in the changes because it does other commits, or it might get upset that changes are happening while running. Can the update of yarn.lock be turned off? The build is failing https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ jena-fuseki-ui --- [INFO] Running 'yarn run build' in /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui [INFO] yarn run v0.16.1 [INFO] $ vue-cli-service build [INFO] [INFO] - Building for production... [INFO] ERROR Failed to compile with 1 error5:18:32 PM [INFO] [INFO] Syntax Error: TypeError: Cannot read properties of undefined (reading 'parseComponent') [INFO] guessing but could it be a version of problem with some tooling? Andy
Re: Release/build issues
I was building locally yesterday and got the same error message on the ui module. However when I deleted node_modules before building it completed successfully. Is there any cache on the apache CI build server or is there something else at work? This was on main(afcd0ae394483010603a41be6756202cd2e9c41c) using `mvn -B verify -Pdev --file pom.xml` I also built using the Jena Github Actions, to confirm/deny the error, on my fork on the same sha ( https://github.com/OyvindLGjesdal/jena/runs/4926913070?check_suite_focus=true), and that was also completed without the error showing up. Best regards, Øyvind man. 24. jan. 2022 kl. 19:46 skrev Bruno Kinoshita : > Taking a look at it today. In another project I bumped the version of Yarn > to v3 (we are using v1 I think, v2 is stable, v3 is the greatest and > latest). Will see if that solves the changes in the lock file, and also > look why the build is failing. > > On Tue, 25 Jan 2022 at 06:38, Andy Seaborne wrote: > > > > > > > On 24/01/2022 13:16, Andy Seaborne wrote: > > > 1/ jena-fuseki-ui > > > > > > When I run maven, the yarn.lock file is being changed. > > > > > > Most changes are to do with "integrity" beginning deleted. > > > > > > "@babel/core@^7.11.0": > > > version "7.16.7" > > > resolved > > > " > > > https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf > " > > > > > > > > - integrity > > > > > > sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== > > > > > > > > dependencies: > > > "@babel/code-frame" "^7.16.7" > > > "@babel/generator" "^7.16.7" > > > > > > Some are reordering in the file. > > > > > > I'm not sure what's going to happen in a release build - it may check > in > > > the changes because it does other commits, or it might get upset that > > > changes are happening while running. > > > > > > Can the update of yarn.lock be turned off? > > > > The build is failing > > > > > https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console > > > > [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ > > jena-fuseki-ui --- > > [INFO] Running 'yarn run build' in > > > > > /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui > > > > [INFO] yarn run v0.16.1 > > [INFO] $ vue-cli-service build > > [INFO] > > [INFO] - Building for production... > > [INFO] ERROR Failed to compile with 1 error5:18:32 PM > > [INFO] > > [INFO] Syntax Error: TypeError: Cannot read properties of undefined > > (reading 'parseComponent') > > [INFO] > > > > guessing but could it be a version of problem with some tooling? > > > > Andy > > >
Re: Release/build issues
Taking a look at it today. In another project I bumped the version of Yarn to v3 (we are using v1 I think, v2 is stable, v3 is the greatest and latest). Will see if that solves the changes in the lock file, and also look why the build is failing. On Tue, 25 Jan 2022 at 06:38, Andy Seaborne wrote: > > > On 24/01/2022 13:16, Andy Seaborne wrote: > > 1/ jena-fuseki-ui > > > > When I run maven, the yarn.lock file is being changed. > > > > Most changes are to do with "integrity" beginning deleted. > > > > "@babel/core@^7.11.0": > > version "7.16.7" > > resolved > > " > https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf; > > > > > - integrity > > > sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== > > > > > dependencies: > > "@babel/code-frame" "^7.16.7" > > "@babel/generator" "^7.16.7" > > > > Some are reordering in the file. > > > > I'm not sure what's going to happen in a release build - it may check in > > the changes because it does other commits, or it might get upset that > > changes are happening while running. > > > > Can the update of yarn.lock be turned off? > > The build is failing > > https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console > > [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ > jena-fuseki-ui --- > [INFO] Running 'yarn run build' in > > /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui > > [INFO] yarn run v0.16.1 > [INFO] $ vue-cli-service build > [INFO] > [INFO] - Building for production... > [INFO] ERROR Failed to compile with 1 error5:18:32 PM > [INFO] > [INFO] Syntax Error: TypeError: Cannot read properties of undefined > (reading 'parseComponent') > [INFO] > > guessing but could it be a version of problem with some tooling? > > Andy >
[jira] [Commented] (JENA-2258) LiteralLabelImpl: forward Throwabl, not only the message
[ https://issues.apache.org/jira/browse/JENA-2258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481281#comment-17481281 ] ASF subversion and git services commented on JENA-2258: --- Commit f7af65771308c1b09540ba90622828c3fb7500ea in jena's branch refs/heads/main from Andy Seaborne [ https://gitbox.apache.org/repos/asf?p=jena.git;h=f7af657 ] Merge pull request #1170 from jmkeil/master JENA-2258 LiteralLabelImpl: forward Throwabl, not only the message > LiteralLabelImpl: forward Throwabl, not only the message > > > Key: JENA-2258 > URL: https://issues.apache.org/jira/browse/JENA-2258 > Project: Apache Jena > Issue Type: Improvement > Components: Core, Datatypes >Affects Versions: Jena 4.3.2 >Reporter: Jan Martin Keil >Priority: Major > > LiteralLabelImpl: forward Throwable instead of only the message to preserve > causes. > Pull request on https://github.com/apache/jena/pull/1170. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: Release/build issues
On 24/01/2022 13:16, Andy Seaborne wrote: 1/ jena-fuseki-ui When I run maven, the yarn.lock file is being changed. Most changes are to do with "integrity" beginning deleted. "@babel/core@^7.11.0": version "7.16.7" resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf; - integrity sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== dependencies: "@babel/code-frame" "^7.16.7" "@babel/generator" "^7.16.7" Some are reordering in the file. I'm not sure what's going to happen in a release build - it may check in the changes because it does other commits, or it might get upset that changes are happening while running. Can the update of yarn.lock be turned off? The build is failing https://ci-builds.apache.org/job/Jena/job/Jena_Development_Test/309/console [INFO] --- frontend-maven-plugin:1.10.4:yarn (yarn run build) @ jena-fuseki-ui --- [INFO] Running 'yarn run build' in /home/jenkins/jenkins-agent/workspace/Jena/Jena_Development_Test/jena-fuseki2/jena-fuseki-ui [INFO] yarn run v0.16.1 [INFO] $ vue-cli-service build [INFO] [INFO] - Building for production... [INFO] ERROR Failed to compile with 1 error5:18:32 PM [INFO] [INFO] Syntax Error: TypeError: Cannot read properties of undefined (reading 'parseComponent') [INFO] guessing but could it be a version of problem with some tooling? Andy
[jira] [Resolved] (JENA-2253) Add module-info.java
[
https://issues.apache.org/jira/browse/JENA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Seaborne resolved JENA-2253.
-
Fix Version/s: Jena 4.4.0
Assignee: Andy Seaborne
Resolution: Fixed
> Add module-info.java
>
>
> Key: JENA-2253
> URL: https://issues.apache.org/jira/browse/JENA-2253
> Project: Apache Jena
> Issue Type: Improvement
> Components: Jena
>Affects Versions: Jena 4.3.2
>Reporter: Svante Schubert
>Assignee: Andy Seaborne
>Priority: Trivial
> Fix For: Jena 4.4.0
>
>
> I am quite new to the Java 9 modularity, but my developers told me that it
> can be "enabled" by adding some basic module metadata in a
> {{module-info.java}} at the root of the java sources.
> Therefore, I suggest adding a module-info to your Jena project, so that users
> who are using a java module based project setup can benefit from this.
> We, the ODF Toolkit, are using Jena and we started such
> {{{}module-info.java{}}}:
> [https://github.com/tdf/odftoolkit/pull/149/files]
> But somehow as soon we got this metadata the Java classes of the
> jena-core-tests JAR can no longer be found.
> The tests are not in our package list as we use them just during build/test
> time.
> Perhaps I can make one of you curious enough to test to create such simple
> {{module-info.java}} files to the root of your Java sources similar as done
> in the PR from us: [https://github.com/tdf/odftoolkit/pull/149]
> (The other reason for this issue, is also that we face an anomaly of lacking
> to find your jena-core-tests classes after using this new module-info.java. I
> hope that this phenomenon goes away when you add your module-info.java as
> well. Currently, [accessing the jena-core-tests via pom.xml in the old
> way,https://github.com/tdf/odftoolkit/blob/master/odfdom/pom.xml#L72] but the
> [new way using apache-jena-libs in
> pom.xml|https://jena.apache.org/download/maven.html does not work either.).
> Thanks in advance,
> Svante
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2253) Add module-info.java
[
https://issues.apache.org/jira/browse/JENA-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481275#comment-17481275
]
Andy Seaborne commented on JENA-2253:
-
The test artifacts for jena-base, jena-core and jena-arq now have different
modules names to the main artifacts ".test" was added. No other artifacts have
usable test code for 3rd party systems.
That's all I can think of so in the absence of more information , marking this
resolved and closed at the Jena 4.4.0 release.
Feel free to reopen if new information is available.
> Add module-info.java
>
>
> Key: JENA-2253
> URL: https://issues.apache.org/jira/browse/JENA-2253
> Project: Apache Jena
> Issue Type: Improvement
> Components: Jena
>Affects Versions: Jena 4.3.2
>Reporter: Svante Schubert
>Priority: Trivial
>
> I am quite new to the Java 9 modularity, but my developers told me that it
> can be "enabled" by adding some basic module metadata in a
> {{module-info.java}} at the root of the java sources.
> Therefore, I suggest adding a module-info to your Jena project, so that users
> who are using a java module based project setup can benefit from this.
> We, the ODF Toolkit, are using Jena and we started such
> {{{}module-info.java{}}}:
> [https://github.com/tdf/odftoolkit/pull/149/files]
> But somehow as soon we got this metadata the Java classes of the
> jena-core-tests JAR can no longer be found.
> The tests are not in our package list as we use them just during build/test
> time.
> Perhaps I can make one of you curious enough to test to create such simple
> {{module-info.java}} files to the root of your Java sources similar as done
> in the PR from us: [https://github.com/tdf/odftoolkit/pull/149]
> (The other reason for this issue, is also that we face an anomaly of lacking
> to find your jena-core-tests classes after using this new module-info.java. I
> hope that this phenomenon goes away when you add your module-info.java as
> well. Currently, [accessing the jena-core-tests via pom.xml in the old
> way,https://github.com/tdf/odftoolkit/blob/master/odfdom/pom.xml#L72] but the
> [new way using apache-jena-libs in
> pom.xml|https://jena.apache.org/download/maven.html does not work either.).
> Thanks in advance,
> Svante
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2232) Javadoc broken when built with Java11
[
https://issues.apache.org/jira/browse/JENA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481236#comment-17481236
]
ASF subversion and git services commented on JENA-2232:
---
Commit 83c61917b3296e731c83b37cd29a8de5a56345ba in jena's branch
refs/heads/main from Andy Seaborne
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=83c6191 ]
JENA-2232: Undo the javadoc11 fixup for modules
> Javadoc broken when built with Java11
> -
>
> Key: JENA-2232
> URL: https://issues.apache.org/jira/browse/JENA-2232
> Project: Apache Jena
> Issue Type: Bug
> Components: Build
>Affects Versions: Jena 4.3.2
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Critical
> Fix For: Jena 4.4.0
>
>
> https://bugs.openjdk.java.net/browse/JDK-8215291
> For Java11, {{--no-module-directories}} is needed otherwise broken URLs are
> generated with "/undefined/" in them.
> There is an in-place fix: patch {{search.js}} as shown in
> http://hg.openjdk.java.net/jdk/jdk/rev/a92cd6585f60
> The flag {{--no-module-directories}} was removed in Java13.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2232) Javadoc broken when built with Java11
[
https://issues.apache.org/jira/browse/JENA-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481237#comment-17481237
]
ASF subversion and git services commented on JENA-2232:
---
Commit 4b7f215424b79908d0b4437054ca206ce3a5d7c3 in jena's branch
refs/heads/main from Andy Seaborne
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=4b7f215 ]
Merge pull request #1173 from afs/javadoc11
JENA-2232: Undo the javadoc11 fixup for modules
> Javadoc broken when built with Java11
> -
>
> Key: JENA-2232
> URL: https://issues.apache.org/jira/browse/JENA-2232
> Project: Apache Jena
> Issue Type: Bug
> Components: Build
>Affects Versions: Jena 4.3.2
>Reporter: Andy Seaborne
>Assignee: Andy Seaborne
>Priority: Critical
> Fix For: Jena 4.4.0
>
>
> https://bugs.openjdk.java.net/browse/JDK-8215291
> For Java11, {{--no-module-directories}} is needed otherwise broken URLs are
> generated with "/undefined/" in them.
> There is an in-place fix: patch {{search.js}} as shown in
> http://hg.openjdk.java.net/jdk/jdk/rev/a92cd6585f60
> The flag {{--no-module-directories}} was removed in Java13.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: Release/build issues
On 24/01/2022 13:16, Andy Seaborne wrote: 2/ Java11. That might have been an upstream fix. The offending search.js seems to be a different size. But this is fragile as to which tools generated the javadoc, For now 1: remove the breaking fix. 2: see what happens 3: if no better approach comes along, release and fixup the website javadoc directly. There's a fix for javadoc production so we need customization of the javadoc production for JDK11 only (the necessary setting has ben removed in later JDKs. How is that done? A profile would need to replicate the whole of the modules settings which is doable but extreme. Or activate by property "apache-release" which I think then means multiple profiles are active. (Never done it myself) We can hack it by producing duff javadoc and fixing it like the current javadoc is fixed. Nuisance for javadoc artifact. There is a script the website. https://github.com/apache/jena-site/tree/javadoc Andy
Release/build issues
1/ jena-fuseki-ui When I run maven, the yarn.lock file is being changed. Most changes are to do with "integrity" beginning deleted. "@babel/core@^7.11.0": version "7.16.7" resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.16.7.tgz#db990f931f6d40cb9b87a0dc7d2adc749f1dcbcf; - integrity sha512-aeLaqcqThRNZYmbMqtulsetOQZ/5gbR/dWruUCJcpas4Qoyy+QeagfDsPdMrqwsPRDNxJvBlRiZxxX7THO7qtA== dependencies: "@babel/code-frame" "^7.16.7" "@babel/generator" "^7.16.7" Some are reordering in the file. I'm not sure what's going to happen in a release build - it may check in the changes because it does other commits, or it might get upset that changes are happening while running. Can the update of yarn.lock be turned off? 2/ Java11. There's a fix for javadoc production so we need customization of the javadoc production for JDK11 only (the necessary setting has ben removed in later JDKs. How is that done? A profile would need to replicate the whole of the modules settings which is doable but extreme. Or activate by property "apache-release" which I think then means multiple profiles are active. (Never done it myself) We can hack it by producing duff javadoc and fixing it like the current javadoc is fixed. Nuisance for javadoc artifact. There is a script the website. https://github.com/apache/jena-site/tree/javadoc Andy
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481063#comment-17481063
]
Marco Neumann commented on JENA-2213:
-
Ok I see [~andy] not a big deal these current values now will not break the
build and satisfy SIS1.1 as well.
I have used a VM last night to diff the changes and subsequently have scrubbed
the node and code. But the new proposed values are now recorded here in the
ticket and not mandatory to successfully build the project with SIS1.1
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481005#comment-17481005
]
Andy Seaborne edited comment on JENA-2213 at 1/24/22, 10:59 AM:
No - I have not taken the values from your comment. The PR was made several
days earlier.
The project normally works with github pull requests. We accept patches/diffs
on tickets (some people do not wish to use github).
Please read back - I have explained how to attach a diff *as a file* to a JIRA
issue. Screen scraping diffs from text comments is time-consuming, fragile and
error-prone.
The diff needs recreating relative to current the Jena codebase now needs to
only touch the tests. The version setting in the POM update has been done.
Release are a busy time. I am now able to do the release as-and-when I have
time, and whether or not there are updated jena-geosparql tests.
was (Author: andy.seaborne):
No - I have not taken the values from your comment. The PR was made several
days earlier.
The project normally works with github pull requests. We accept patches/diffs
on tickets (some people do not wish to use github).
Please read back - I have explained how to attach a diff *as a file* to a JIRA
issue. Screen scraping diffs from text comments is time-consuming, fragile and
error-prone.
The diff needs recreating relative to current the Jena codebase and will need
to only touch the tests. The POM update has been done.
Release are a busy time. I am now able to do the release as-and-when I have
time, and whether or not there are updated jena-geosparql tests.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481005#comment-17481005
]
Andy Seaborne commented on JENA-2213:
-
No - I have not taken the values from your comment. The PR was made several
days earlier.
The project normally works with github pull requests. We accept patches/diffs
on tickets (some people do not wish to use github).
Please read back - I have explained how to attach a diff *as a file* to a JIRA
issue. Screen scraping diffs from text comments is time-consuming, fragile and
error-prone.
The diff needs recreating relative to current the Jena codebase and will need
to only touch the tests. The POM update has been done.
Release are a busy time. I am now able to do the release as-and-when I have
time, and whether or not there are updated jena-geosparql tests.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480983#comment-17480983
]
Marco Neumann commented on JENA-2213:
-
[~andy] if you have used the values from the diff as posted we should be all
set. The tests are now improved. I have used the Centre point Cwmystwyth for
the United Kingdom instead of the coordinates in Africa used in the previous
tests which are outside the scope of the British National Grid and hence have
produced significant differences in the updated version of the model projection
in SIS1.1
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480968#comment-17480968
]
Andy Seaborne commented on JENA-2213:
-
Reopened and marked "resolved" which is how we managed tickets for releases. It
will be closed as part of the release process itself. This makes finding
tickets easier e.g. https://s.apache.org/jena-4.4.0-jira
As I understand the current state, we're waiting for updated tests making the
tests more appropriate for OSGB.
PR #1169 did a basic upgrade and simply updated the results of the affected
tests without assessment for suitability.
We will be at SIS 1.1 for Jena 4.4.0.
[~neumarcx] - I will leave whether you want a separate ticket for the test
improvements, or use this one.
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Seaborne reopened JENA-2213:
-
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (JENA-2213) Jena GeoSPARQL Tests Fail With SIS 1.1
[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marco Neumann closed JENA-2213.
---
Fix Version/s: Jena 4.4.0
Resolution: Fixed
changes to values in tests have been made to suit the new SIS 1.1 reference
model for the "Transverse Mercator" projection, Whose formulas have been
modified in SIS 1.1 for better stability.
No external or an external SIS 1.1 setup is now required for the build process
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
>Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
>Reporter: Marco Neumann
>Priority: Minor
> Fix For: Jena 4.4.0
>
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected: 1272149.3463499574]> but was: -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
