[ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-04 Thread Ying Jiang
Hi all,

FYI, Google announced the mid-term evaluation result of GSoC 2015
project yesterday. The Jena project of "Extend CONSTRUCT to build
quads (JENA-491) passed the evaluation.

Hi Qihong,
Thanks a lot for your contribution last month! We expect your
excellent work in the coming weeks.
The status of the project is a little ahead of the schedule. But the
rest work is also challenging. You're supposed to integrate JENA-491
into Fuseki. In addition, the tests should be improved in accordance
with the original test framework of jena-arq.
Have fun!

Cheers,
Ying Jiang


Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-05 Thread Qihong Lin
Hi,

Please check my latest commits [1]. I just completed the function of
QueryEngineHTTP.execConstructQuads(). You can try out the example of
"query_construct_quad_01()" in TestQuery [2].

I'll improve the tests later on, with more questions in the other
thread. Thanks!

Regards,
Qihong


[1] 
https://github.com/confidencesun/jena/commit/07afdbf0fe635d41c302b25a9c51f43802ea903a
[2] 
https://github.com/confidencesun/jena/blob/JENA-491/jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java

On Sat, Jul 4, 2015 at 10:08 PM, Ying Jiang  wrote:
> Hi all,
>
> FYI, Google announced the mid-term evaluation result of GSoC 2015
> project yesterday. The Jena project of "Extend CONSTRUCT to build
> quads (JENA-491) passed the evaluation.
>
> Hi Qihong,
> Thanks a lot for your contribution last month! We expect your
> excellent work in the coming weeks.
> The status of the project is a little ahead of the schedule. But the
> rest work is also challenging. You're supposed to integrate JENA-491
> into Fuseki. In addition, the tests should be improved in accordance
> with the original test framework of jena-arq.
> Have fun!
>
> Cheers,
> Ying Jiang


Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-05 Thread Andy Seaborne

On 04/07/15 15:08, Ying Jiang wrote:

Hi all,

FYI, Google announced the mid-term evaluation result of GSoC 2015
project yesterday. The Jena project of "Extend CONSTRUCT to build
quads (JENA-491) passed the evaluation.

Hi Qihong,
Thanks a lot for your contribution last month! We expect your
excellent work in the coming weeks.
The status of the project is a little ahead of the schedule. But the
rest work is also challenging. You're supposed to integrate JENA-491
into Fuseki. In addition, the tests should be improved in accordance
with the original test framework of jena-arq.
Have fun!

Cheers,
Ying Jiang



Good news.

Ying - What's the plan for the "deliver" element of the tasks?  That's 
going to need mentor time and also to review a specific, focused set of 
changes.


Andy



Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-06 Thread Andy Seaborne

On 05/07/15 15:49, Qihong Lin wrote:

Hi,

Please check my latest commits [1].


Hi Qihong,

As in my other message, that has crossed over at the same time you sent
this, it is time to work out the process for delivering to the Jena 
codebase.


Let's start with changes to jena-arq.

You will need to work with your mentor for this.  Please can we have the
discussions regularly on this list.

It will make integrating the code into the code base much easier - at 
the moment, it's quite hard to see how that can be achieved.


The latest commit has 300+ changed files almost all from merging with 
Jena master not your changes.


I'm afraid that finding the relevant parts to review from such a large 
number of files is somewhat difficult. It breaks the github review tools 
for a start!


Andy


I just completed the function of
QueryEngineHTTP.execConstructQuads(). You can try out the example of
"query_construct_quad_01()" in TestQuery [2].

I'll improve the tests later on, with more questions in the other
thread. Thanks!

Regards,
Qihong


[1] 
https://github.com/confidencesun/jena/commit/07afdbf0fe635d41c302b25a9c51f43802ea903a
[2] 
https://github.com/confidencesun/jena/blob/JENA-491/jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java

On Sat, Jul 4, 2015 at 10:08 PM, Ying Jiang  wrote:

Hi all,

FYI, Google announced the mid-term evaluation result of GSoC 2015
project yesterday. The Jena project of "Extend CONSTRUCT to build
quads (JENA-491) passed the evaluation.

Hi Qihong,
Thanks a lot for your contribution last month! We expect your
excellent work in the coming weeks.
The status of the project is a little ahead of the schedule. But the
rest work is also challenging. You're supposed to integrate JENA-491
into Fuseki. In addition, the tests should be improved in accordance
with the original test framework of jena-arq.
Have fun!

Cheers,
Ying Jiang




Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-09 Thread Qihong Lin
Hi,

How to integrate my code into the code base? Which of the following
one is the desired approach:
1) confidencesun/jena:JENA-491 -> apache/jena:master
2) confidencesun/jena:JENA-491 -> confidencesun/jena:master ->
apache/jena:master
3) confidencesun/jena:JENA-491 -> apache/jena:JENA-491 -> apache/jena:master

regards,
Qihong

On Tue, Jul 7, 2015 at 1:48 AM, Andy Seaborne  wrote:
> On 05/07/15 15:49, Qihong Lin wrote:
>>
>> Hi,
>>
>> Please check my latest commits [1].
>
>
> Hi Qihong,
>
> As in my other message, that has crossed over at the same time you sent
> this, it is time to work out the process for delivering to the Jena
> codebase.
>
> Let's start with changes to jena-arq.
>
> You will need to work with your mentor for this.  Please can we have the
> discussions regularly on this list.
>
> It will make integrating the code into the code base much easier - at the
> moment, it's quite hard to see how that can be achieved.
>
> The latest commit has 300+ changed files almost all from merging with Jena
> master not your changes.
>
> I'm afraid that finding the relevant parts to review from such a large
> number of files is somewhat difficult. It breaks the github review tools for
> a start!
>
> Andy
>
>
>> I just completed the function of
>> QueryEngineHTTP.execConstructQuads(). You can try out the example of
>> "query_construct_quad_01()" in TestQuery [2].
>>
>> I'll improve the tests later on, with more questions in the other
>> thread. Thanks!
>>
>> Regards,
>> Qihong
>>
>>
>> [1]
>> https://github.com/confidencesun/jena/commit/07afdbf0fe635d41c302b25a9c51f43802ea903a
>> [2]
>> https://github.com/confidencesun/jena/blob/JENA-491/jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java
>>
>> On Sat, Jul 4, 2015 at 10:08 PM, Ying Jiang  wrote:
>>>
>>> Hi all,
>>>
>>> FYI, Google announced the mid-term evaluation result of GSoC 2015
>>> project yesterday. The Jena project of "Extend CONSTRUCT to build
>>> quads (JENA-491) passed the evaluation.
>>>
>>> Hi Qihong,
>>> Thanks a lot for your contribution last month! We expect your
>>> excellent work in the coming weeks.
>>> The status of the project is a little ahead of the schedule. But the
>>> rest work is also challenging. You're supposed to integrate JENA-491
>>> into Fuseki. In addition, the tests should be improved in accordance
>>> with the original test framework of jena-arq.
>>> Have fun!
>>>
>>> Cheers,
>>> Ying Jiang
>
>


Re: [ANN] GSoC 2015 Project Mid-term Evaluation (PASS)

2015-07-09 Thread Andy Seaborne

On 09/07/15 15:08, Qihong Lin wrote:

Hi,

How to integrate my code into the code base? Which of the following
one is the desired approach:
1) confidencesun/jena:JENA-491 -> apache/jena:master
2) confidencesun/jena:JENA-491 -> confidencesun/jena:master ->
apache/jena:master
3) confidencesun/jena:JENA-491 -> apache/jena:JENA-491 -> apache/jena:master

regards,
Qihong



I don't know the workflow you used with Marmotta last year.

Where I'd like to get to is a pull request (PR) from confidencesun/jena 
to apache/jena.


That PR should cover changes to jena-arq, so master.jj, the interface 
changes to QueryExecution, the implementation (local dataset) and tests 
to cover syntax and also to cover execution. Not QueryEngineHTTP for now 
(nothing to test it with at this point).


If you prefer, we can split this up in one PR for syntax - master.jj and 
syntax tests - and one PR for QueryExecution, implementation and tests.


The PR should just be changes you have made, so merging in 
apache/jena:master before making the pull request and resolving any 
conflicts should mean that the PR is just the new material from where 
ever the new work is currently should be done. [I'm a bit confused 
because the last commits you linked to previously with [1] are commits 
merged from jena master - there may be commits related to the title "add 
construct quads support to Fuseki" but I can't find them ... but then 
github isn't happy with 341 files changed so I don't know what might 
have been truncated.]


When the PR is done, we can use the github tools to check and review the 
code so as to prepare it for merging.


Does this all make sense?

Andy