Add to JMeter modification

2015-07-21 Thread Maxime Chassagneux
Hi,

Since many mounth I made some modifications on JMeter source to add some
features I need.
Now I would like to know how I could discuss with the community in order to
add it on the trunk source.

Many modifications I made are simple to report but I'm not a good
developper and I think a review is necessary.

How do I proceed to do this ? First I have to explain all modifications one
by one with the reason ?

Best reagrd.


[JMS] disabled cache when file name change

2015-07-21 Thread Maxime Chassagneux
I've post on bugzilla this modification : Bug 58160


Could you look at it ?

Best regard.


Optimization on the AsyncBtach sender

2015-07-21 Thread Maxime Chassagneux
See below a new modification I made on the AsyncBtach sender :

 Bug 58163 

Hope it could be usefull for everyone.

Best regard.


Check if file exist on ResultCollector listener before start the loadtest

2015-07-21 Thread Maxime Chassagneux
See below a new modification to check and inform the user if a file already
exist on all ResultCollector listener before lauching the loadtest.

*Bug 58164 *

Best regard


Replace variable in distributed test

2016-01-22 Thread Maxime Chassagneux
Hi,

Since I use a "Backend Listener" to create report via Grafana, I find a
problem in distributed test.
Parameters of my bakend listener like "graphiteHost" is in my case a
variable ( i.e ${graphiteHost} )
When I start my test localy, this parameter is correctly replace, but when
I start it on a remote host not.

I search away to fix it on my local JMeter source code but I simply fail to
understand

Could you explain me quickly when I have to look for in order to fix it ?

Thanks in advance for help.

Maxime.


Re: HttpClient 4.5.2 release preparations

2016-02-25 Thread Maxime Chassagneux
Hi,

Since I test JMeter with the latest snapshot of HC I experience issues with
HTTP Cookie Manager.
Now the defautl Implementation is HC4 with cookie Policy to default. When I
use it, most of scenario stop working with a problem of date :

2016/02/23 10:27:05 INFO  - jmeter.threads.JMeterThread: Thread finished:
P11 - Admin A/C SubTypes 10-1
2016/02/23 10:27:05 ERROR - jmeter.protocol.http.control.HC4CookieHandler:
Unable to add the cookie org.apache.http.cookie.MalformedCookieException:
Invalid 'expires' attribute: Thu, 27 Aug 2015 09:27:05 GMT
 at
org.apache.http.impl.cookie.BasicExpiresHandler.parse(BasicExpiresHandler.java:63)
 at
org.apache.http.impl.cookie.CookieSpecBase.parse(CookieSpecBase.java:112)
 at
org.apache.http.impl.cookie.DefaultCookieSpec.parse(DefaultCookieSpec.java:139)
 at
org.apache.jmeter.protocol.http.control.HC4CookieHandler.addCookieFromHeader(HC4CookieHandler.java:115)
 at
org.apache.jmeter.protocol.http.control.CookieManager.addCookieFromHeader(CookieManager.java:355)
 at
org.apache.jmeter.protocol.http.sampler.HTTPHC4Impl.saveConnectionCookies(HTTPHC4Impl.java:1371)
 at
org.apache.jmeter.protocol.http.sampler.HTTPHC4Impl.sample(HTTPHC4Impl.java:386)
 at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:74)
 at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.followRedirects(HTTPSamplerBase.java:1552)
 at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.resultProcessing(HTTPSamplerBase.java:1629)
 at
org.apache.jmeter.protocol.http.sampler.HTTPAbstractImpl.resultProcessing(HTTPAbstractImpl.java:463)
 at
org.apache.jmeter.protocol.http.sampler.HTTPHC4Impl.sample(HTTPHC4Impl.java:394)
 at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:74)
 at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1148)
 at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1137)
 at
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:455)
 at
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:400)
 at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:249)
 at java.lang.Thread.run(Unknown Source)

And some time, with other site I have this issue :

java.net.SocketException: Connection reset
at java.net.SocketInputStream.read(Unknown Source)
at java.net.SocketInputStream.read(Unknown Source)
at
org.apache.http.impl.io.AbstractSessionInputBuffer.fillBuffer(AbstractSessionInputBuffer.java:160)
at
org.apache.http.impl.io.SocketInputBuffer.fillBuffer(SocketInputBuffer.java:84)
at
org.apache.http.impl.io.AbstractSessionInputBuffer.readLine(AbstractSessionInputBuffer.java:273)
at
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:140)
at
org.apache.http.impl.conn.DefaultHttpResponseParser.parseHead(DefaultHttpResponseParser.java:57)
at
org.apache.http.impl.io.AbstractMessageParser.parse(AbstractMessageParser.java:261)
at
org.apache.http.impl.AbstractHttpClientConnection.receiveResponseHeader(AbstractHttpClientConnection.java:283)
at
org.apache.http.impl.conn.DefaultClientConnection.receiveResponseHeader(DefaultClientConnection.java:251)
at
org.apache.http.impl.conn.ManagedClientConnectionImpl.receiveResponseHeader(ManagedClientConnectionImpl.java:197)
at
org.apache.jmeter.protocol.http.sampler.MeasuringConnectionManager$MeasuredConnection.receiveResponseHeader(MeasuringConnectionManager.java:218)
at
org.apache.http.protocol.HttpRequestExecutor.doReceiveResponse(HttpRequestExecutor.java:272)
at
org.apache.http.protocol.HttpRequestExecutor.execute(HttpRequestExecutor.java:124)
at
org.apache.http.impl.client.DefaultRequestDirector.tryExecute(DefaultRequestDirector.java:685)
at
org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:487)
at
org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:882)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
at
org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:55)
at
org.apache.jmeter.protocol.http.sampler.HTTPHC4Impl.executeRequest(HTTPHC4Impl.java:555)
at
org.apache.jmeter.protocol.http.sampler.HTTPHC4Impl.sample(HTTPHC4Impl.java:314)
at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:74)
at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1148)
at
org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1137)
at
org.apache.jmeter.threads.JMeterThread.executeSamplePackage(JMeterThread.java:455)
at
org.apache.jmeter.threads.JMeterThread.processSampler(JMeterThread.java:400)
at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:249)
at java.lang.Thread.run(Unknown Source)

When I change the Cookie Policy to "Standard" all is working back. ( But
each time a Clear GUI this option is lost ...

Re: HttpClient 4.5.2 release preparations

2016-02-26 Thread Maxime Chassagneux
Hi,

Thanks for taking time to answer me.

I've made a synchro with the last version of JMeter ( from git ). The
problem with settings not saved on the cookie manager is gone.
Now, the default value is "standard" and all  my case test are all right.


See examples of the header Set-Cookie which was the problem before :


Entêtes de réponse :
HTTP/1.1 302 Found
Date: Fri, 26 Feb 2016 09:50:51 GMT
Server: Apache
Set-Cookie: targetPath_habile=habile-r12; path=/; domain=habileqal..fr
Cache-Control: no-store
Location:
https://habileqal..fr/habileWeb/AUTH/redirect.jsp?TARGET=https%3A%2F%2Fadream-qal..fr%2F
Content-Length: 290
Content-Type: text/html; charset=iso-8859-1
Set-Cookie: SMTRYNO=1; path=/; domain=..fr
Set-Cookie: SMTRYNO=; expires=Sun, 30 Aug 2015 09:50:51 GMT; path=/;
domain=..fr
Set-Cookie:
SMSESSION=BOOQf/huKkzktvXHC4KFX1WlKwihPPQLlzuPnQFXuIkDwuwSC3be+XVi8Ncvc8AD0uR7sxc32w84EsIC8FKak1dwFu1HugnzlvMu3nWBMuqjFFns3mkdL4564maK8MGGQW6iEHlx1+oUwvMjyafmMgErG1hcNBOvJREHqKcE79cx+fF+aLMLj+FRZ7AcEJhB4Sba1bshKWMikTffLhmkSaDWI/N7Gc/HeGJDo5oS4tMF1HP7qqOjIysyRSy61Sq2CB4F6CZJ6hKlJXOQ1XrjQ9L8rj7BY6DB7PPw7Jbs6jYX3iCYeIkaptCial1frTyYpMifz0HJ7IBrN6lbC+9/nzxPySdRsdVTO9DWOZO5znmblyM+KKhQJe4kepfEVfEE/IhRmXDNyXI1eJjb0HEpMyHvEyOOleAFyyCvs/+1fFAnWjmuJJA6Sxh/YHgM0hDpq5ycurN+haq2S4YqNbgKHYbOLFpKGEGn2TRZN0U+z9/vZ//CUj0mtAcD8Mne8W8CAb9BjbiD5qryI+bFe8HBrwHTe90qDNvESv5krpe3M0Up5oHwqY3V+lBfLjcmoznqRzMTjllmPfM/Rn4RCr5b5Kem7ri6s10KTNAAQGRoCGSekfsV9WqCUlJ1R8PDzfuZHBut2sQgc2/Q7sYXW+AmZfizbuWKcwadKc9QUmWHDPzs/fet9SQhniFu8eUB5fhjZhLeonUMyGiEGeuSIxGR31PpEYo7n5ZvfH4XdPPCMDV5PPdLDFg7Dr5vjp3Mq0pOrD1cyBFQDQJGQK0B2n/ubEEC6E/bZKcJTa5jKtJwF5DYMLhhRn3zYOu8Ig0/ml3uiIdUE6lpN/O7sS81wsEtdN7+UiM0+eOEpOEakcriJigCnV6tIpd/CYDWb3XrrPKJMnAC27iPotHwoU7PnKMXe5/AC7msl3UX+64JfkZlWshz5FyJFjBJSR+uzNeEQAbr5k5w/4WwzgLIqe3dirQR2egpm450FG3xOkZxlALTYi/KuPz5yiZzyp4Xcq5HsjKmpBMjiWMyHSY+FVS24oJpbDuC4079TMK2peSJvtd4ZmKBfUp07Ozc5lzXE+Hk9Itz;
path=/; domain=..fr
Keep-Alive: timeout=15
Connection: Keep-Alive


The second case :

GET http://b2cqal..fr/cgi-bin/FR/fr/common/home/x.do

Cookie Data:
$Version=1; af_last_tab="1"; $Path=""; $Domain="b2cqal..fr"$Version=1;
pageLanguage="fr"; $Path=""; $Domain="b2cqal..fr"$Version=1;
targetPath_b2c="b2c_a"; $Path=""; $Domain="b2cqal..fr"

Entêtes de requête :
Connection: keep-alive
Accept-Language: en-US,en;q=0.5
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101
Firefox/41.0
Referer: http://b2cqal..fr/qualif/b2cqal.chaine_a.html
Accept-Encoding: gzip, deflate
Host: b2cqal..fr






2016-02-26 1:13 GMT+01:00 Philippe Mouawad :

> Hi Maxime,
> Regarding https://bz.apache.org/bugzilla/show_bug.cgi?id=59071 , after
> further analysis I am not sure about the fix.
>
> So I would really need the value of the header Set-Cookie.
>
> It seems your cookie would follow RFC6265-Lax as per Expires format.
>
> Thanks
>
> On Thu, Feb 25, 2016 at 11:31 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> > Hello,
> > First thanks for your feedback on nightly build, it really helps us a
> lot.
> > Some of the issues you reported are now fixed in next nightly build that
> > you can download here:
> >
> >
> https://builds.apache.org/job/JMeter-trunk/lastSuccessfulBuild/artifact/trunk/dist/
> > It should be build 4​99​2 or higher.
> >
> >
> >
> > Please note that for now, last JMeter nightly build does not yet uses
> > HttpClient 4.5.2 (as it is not released, should happen in few hours I
> > think).
> > So there are still known bugs:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=58881
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=58583
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=58950
> >
> > Once HC4.5.2 is released, we will commit it and fix those 3 bugs.
> >
> > Find inline below my other answers.
> >
> > On Thu, Feb 25, 2016 at 3:32 PM, Maxime Chassagneux <
> > maxime.chassagn...@gmail.com> wrote:
> >
> >> Hi,
> >>
> >> Since I test JMeter with the latest snapshot of HC I experience issues
> >> with HTTP Cookie Manager.
> >> Now the defautl Implementation is HC4 with cookie Policy to default.
> When
> >> I use it, most of scenario stop working with a problem of date :
> >>
> >> 2016/02/23 10:27:05 INFO  - jmeter.threads.JMeterThread: Thread
> finished:
> >> P11 - Admin A/C SubTypes 10-1
> >> 2016/02/23 10:27:05 ERROR -
> >> jmeter.protocol.http.control.HC4CookieHandler: Unable to add the c

[Recording] Impossible to record a http website with HTTP4 implementation

2016-06-13 Thread Maxime Chassagneux
Hi,

I have one example of a website which I can't record with HTTP4
implementation (only work with JAVA implementation )
On JMeter 2.13, this problem existed, during the dev of the 3.00 this bug
was not present, and since the official 3.00 out, it come back.

The error display on firefox is just "Content Encoding Error".

How I could help to send you more information ? what kind of trace do you
need ?


Re: [Recording] Impossible to record a http website with HTTP4 implementation

2016-06-14 Thread Maxime Chassagneux
In the jmeter.log, none error is display, I have just :

2016/06/14 09:43:28 INFO  - jmeter.protocol.http.proxy.Proxy: [34052]
KeyStore for SSL loaded OK and put host 'xxx.xxx.fr' in map with key (
xxx.xxx.fr)

It's a private https authentification website.

The complete message on firefox is :

Content Encoding Error

The page you are trying to view cannot be shown because it uses an invalid
or unsupported form of compression.

And sorry, I can tell you which version worked in the 3.0-dev





2016-06-13 19:19 GMT+02:00 Felix Schumacher <
felix.schumac...@internetallee.de>:

> Am 13.06.2016 um 14:09 schrieb Maxime Chassagneux:
>
>> Hi,
>>
>> I have one example of a website which I can't record with HTTP4
>> implementation (only work with JAVA implementation )
>> On JMeter 2.13, this problem existed, during the dev of the 3.00 this bug
>> was not present, and since the official 3.00 out, it come back.
>>
>> The error display on firefox is just "Content Encoding Error".
>>
> Are there any errors logged inside jmeter or the jmeter.log?
>
>>
>> How I could help to send you more information ? what kind of trace do you
>> need ?
>>
> Do you know, which 3.0-dev version (day or svn number) worked?
> Is the website publicly available, so that we could test it? Is it a http
> or https site?
>
> Regards,
>  Felix
>
>>
>>
>


Re: [Recording] Impossible to record a http website with HTTP4 implementation

2016-06-22 Thread Maxime Chassagneux
See below information from chrome :

Request URL:
https://xxxqal..fr/siteminderagent/.fcc?TYPE=33554433&REALMOID=06-1e7ec1e2-8e7c-1000-8774-84ac1944&GUID=&SMAUTHREASON=0&METHOD=GET&SMAGENTNAME=agt_..fr_intranet&TARGET=-SM-http%3a%2f%--qal%2e%2efr%2f
Request Method:GET
Status Code:200 OK
Remote Address:10.70.248.137:443
Response Headers
view source
Cache-Control:no-store
Connection:Keep-Alive
Content-Encoding:deflate
Content-Length:3975
Content-Type:text/html; charset=iso-8859-1
Date:Wed, 22 Jun 2016 08:07:12 GMT
Keep-Alive:timeout=15
Server:Apache
Set-Cookie:targetPath_=-r12; path=/; domain=..fr
Vary:Accept-Encoding
Request Headers
view source
Accept:text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
Accept-Encoding:gzip, deflate, sdch, br
Accept-Language:fr-FR,fr;q=0.8,en-US;q=0.6,en;q=0.4
Connection:keep-alive
Host:..fr
Upgrade-Insecure-Requests:1
User-Agent:Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/51.0.2704.103 Safari/537.36
Query String Parameters
view source
view URL encoded
TYPE:33554433
REALMOID:06-1e7ec1e2-8e7c-1000-8774-84ac1944
GUID:
SMAUTHREASON:0
METHOD:GET
SMAGENTNAME:agt_..fr_intranet
TARGET:-SM-http://--qal..fr/




2016-06-19 22:32 GMT+02:00 Felix Schumacher <
felix.schumac...@internetallee.de>:

>
>
> Am 14. Juni 2016 10:11:17 MESZ, schrieb Maxime Chassagneux <
> maxime.chassagn...@gmail.com>:
> >In the jmeter.log, none error is display, I have just :
> >
> >2016/06/14 09:43:28 INFO  - jmeter.protocol.http.proxy.Proxy: [34052]
> >KeyStore for SSL loaded OK and put host 'xxx.xxx.fr' in map with key (
> >xxx.xxx.fr)
> >
> >It's a private https authentification website.
> >
> >The complete message on firefox is :
> >
> >Content Encoding Error
> >
> >The page you are trying to view cannot be shown because it uses an
> >invalid
> >or unsupported form of compression.
>
> Can you post the http headers from the page? Especially the compression
> related ones?
>
> Regards,
> Felix
>
> >
> >And sorry, I can tell you which version worked in the 3.0-dev
> >
> >
> >
> >
> >
> >2016-06-13 19:19 GMT+02:00 Felix Schumacher <
> >felix.schumac...@internetallee.de>:
> >
> >> Am 13.06.2016 um 14:09 schrieb Maxime Chassagneux:
> >>
> >>> Hi,
> >>>
> >>> I have one example of a website which I can't record with HTTP4
> >>> implementation (only work with JAVA implementation )
> >>> On JMeter 2.13, this problem existed, during the dev of the 3.00
> >this bug
> >>> was not present, and since the official 3.00 out, it come back.
> >>>
> >>> The error display on firefox is just "Content Encoding Error".
> >>>
> >> Are there any errors logged inside jmeter or the jmeter.log?
> >>
> >>>
> >>> How I could help to send you more information ? what kind of trace
> >do you
> >>> need ?
> >>>
> >> Do you know, which 3.0-dev version (day or svn number) worked?
> >> Is the website publicly available, so that we could test it? Is it a
> >http
> >> or https site?
> >>
> >> Regards,
> >>  Felix
> >>
> >>>
> >>>
> >>
>
>


Re: [Recording] Impossible to record a http website with HTTP4 implementation

2016-06-30 Thread Maxime Chassagneux
No problem on other website, only happen on this authentification website
acces, but all ur intranet pass by with site.
Same with firefox, IE and chrome.

Work with Java implementation only HTTP4 is affected.

2016-06-29 22:12 GMT+02:00 Felix Schumacher <
felix.schumac...@internetallee.de>:

> Am 22.06.2016 um 10:11 schrieb Maxime Chassagneux:
>
>> See below information from chrome :
>>
>> Request URL:
>>
>> https://xxxqal..fr/siteminderagent/.fcc?TYPE=33554433&REALMOID=06-1e7ec1e2-8e7c-1000-8774-84ac1944&GUID=&SMAUTHREASON=0&METHOD=GET&SMAGENTNAME=agt_..fr_intranet&TARGET=-SM-http%3a%2f%--qal%2e%2efr%2f
>> Request Method:GET
>> Status Code:200 OK
>> Remote Address:10.70.248.137:443
>> Response Headers
>> view source
>> Cache-Control:no-store
>> Connection:Keep-Alive
>> Content-Encoding:deflate
>> Content-Length:3975
>> Content-Type:text/html; charset=iso-8859-1
>> Date:Wed, 22 Jun 2016 08:07:12 GMT
>> Keep-Alive:timeout=15
>> Server:Apache
>> Set-Cookie:targetPath_=-r12; path=/; domain=..fr
>> Vary:Accept-Encoding
>> Request Headers
>> view source
>>
>> Accept:text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
>> Accept-Encoding:gzip, deflate, sdch, br
>> Accept-Language:fr-FR,fr;q=0.8,en-US;q=0.6,en;q=0.4
>> Connection:keep-alive
>> Host:..fr
>> Upgrade-Insecure-Requests:1
>> User-Agent:Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML,
>> like Gecko) Chrome/51.0.2704.103 Safari/537.36
>> Query String Parameters
>> view source
>> view URL encoded
>> TYPE:33554433
>> REALMOID:06-1e7ec1e2-8e7c-1000-8774-84ac1944
>> GUID:
>> SMAUTHREASON:0
>> METHOD:GET
>> SMAGENTNAME:agt_..fr_intranet
>> TARGET:-SM-http://--qal..fr/
>>
>> So, you have the problems with firefox and chrome? Could you try other
> (public) sites and see, if you can replicate the problem there?
>
> Regards,
>  Felix
>
>
>>
>> 2016-06-19 22:32 GMT+02:00 Felix Schumacher <
>> felix.schumac...@internetallee.de>:
>>
>>
>>> Am 14. Juni 2016 10:11:17 MESZ, schrieb Maxime Chassagneux <
>>> maxime.chassagn...@gmail.com>:
>>>
>>>> In the jmeter.log, none error is display, I have just :
>>>>
>>>> 2016/06/14 09:43:28 INFO  - jmeter.protocol.http.proxy.Proxy: [34052]
>>>> KeyStore for SSL loaded OK and put host 'xxx.xxx.fr' in map with key (
>>>> xxx.xxx.fr)
>>>>
>>>> It's a private https authentification website.
>>>>
>>>> The complete message on firefox is :
>>>>
>>>> Content Encoding Error
>>>>
>>>> The page you are trying to view cannot be shown because it uses an
>>>> invalid
>>>> or unsupported form of compression.
>>>>
>>> Can you post the http headers from the page? Especially the compression
>>> related ones?
>>>
>>> Regards,
>>> Felix
>>>
>>> And sorry, I can tell you which version worked in the 3.0-dev
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> 2016-06-13 19:19 GMT+02:00 Felix Schumacher <
>>>> felix.schumac...@internetallee.de>:
>>>>
>>>> Am 13.06.2016 um 14:09 schrieb Maxime Chassagneux:
>>>>>
>>>>> Hi,
>>>>>>
>>>>>> I have one example of a website which I can't record with HTTP4
>>>>>> implementation (only work with JAVA implementation )
>>>>>> On JMeter 2.13, this problem existed, during the dev of the 3.00
>>>>>>
>>>>> this bug
>>>>
>>>>> was not present, and since the official 3.00 out, it come back.
>>>>>>
>>>>>> The error display on firefox is just "Content Encoding Error".
>>>>>>
>>>>>> Are there any errors logged inside jmeter or the jmeter.log?
>>>>>
>>>>> How I could help to send you more information ? what kind of trace
>>>>>>
>>>>> do you
>>>>
>>>>> need ?
>>>>>>
>>>>>> Do you know, which 3.0-dev version (day or svn number) worked?
>>>>> Is the website publicly available, so that we could test it? Is it a
>>>>>
>>>> http
>>>>
>>>>> or https site?
>>>>>
>>>>> Regards,
>>>>>   Felix
>>>>>
>>>>>
>>>>>>
>>>
>


Re: Release JMeter 3.2 ?

2017-01-13 Thread Maxime Chassagneux
Hi,

Pls, could you consider to merge this PR too :

 - PR-241 : Support variable for all JMS messages (bytes, object, ...) and
sources (file, folder)
 - PR-240 : Improves JMS component robustness

Thanks .

2017-01-12 21:02 GMT+01:00 Philippe Mouawad :

> On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> felix.schumac...@internetallee.de> wrote:
>
> > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> >
> >> Hello,
> >> What do you think of releasing a 3.2 version ?
> >>
> > I think I said before, that I would like to release often :)
> >
> >>
> >> I see following reasons:
> >>
> >> - There is a regression (See bug 60575)
> >>
> > My fix for 60575 needs tests and review as it changes the contract of the
> > method getSendParameterValuesAsPostBody.
> >
> I reviewed it , it looks ok to me.
> I'll double check.
>
> >
> > It returned true if there were no parameters (and thus none with a name).
> > (Or if getPostBodyRaw() is true)
> >
> > After the change it returns only true when there are parameters and none
> > of those have a name. (Or if getPostBodyRaw() is true).
> >
>
>
>
> >
> > This method is used in POST and PUT as well, but I believe the change to
> > be correct in both places. too.
> >
> > - We have 9 enhancements and 12  Bug fixes
> >> - Some nice features (at least as a current user I find them
> >> interesting
> >> :-) ):
> >>- More space in UI and simpler look
> >>- Up to date Browser based on javafx
> >>
> > We might have to warn a bit more about the need for javafx (The default
> > java for SUSE Leap42.2 seems to have no javafx). Without javafx JMeter
> will
> > start, but the results tree view is missing.
> >
>
> I think in this case we should try to fail in a bit cleaner way
>
> >- Or in response assertion
> >>- Replace feature (partial)+ counting
> >>
> >> Maybe we can integrate before next release:
> >>
> >> - PR-247
> >> - PR-246
> >> - PR-245
> >> - PR-237
> >>
> >> And upgrade some dependencies:
> >>
> >> - jodd which has a lot of perf enhancements that we use in JMeter
> (for
> >> resources extractions)
> >> - httpcomponents
> >> - maybe more
> >>
> > I would like to link  the converted pdf tutorials and maybe do a bit of
> > minor tweaks to the look and feel of the web pages (less shadows).
> >
> > Should the sect-num number of the tutorials be continued from those in
> the
> > usermanual section?
> >
>
> I think so.
>
>
> >> Besides, we did a lot of code changes related to sonar, let's release
> it.
> >>
> >> A last good thing is that we start to release more often.
> >>
> > +1
> >
> > Felix
> >
> >>
> >>
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: [GitHub] jmeter issue #241: Support variable for all JMS messages (bytes, object, ......

2017-01-15 Thread Maxime Chassagneux
Hi,

I thought we have already did it. I will look at this tomorrow and share
result with you.



2017-01-15 15:00 GMT+01:00 pmouawad :

> Github user pmouawad commented on the issue:
>
> https://github.com/apache/jmeter/pull/241
>
> Hello,
> Before merging this one , I'd like to be sure it does not introduce
> performance degradation.
>
> Did you have time to make a micro benchmark ?
> Thank you
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>


Re: Release JMeter 3.2 ?

2017-01-16 Thread Maxime Chassagneux
Hi Philippe,

I will deploy your nightly build in our permit to operate service tomorrow.
It's the best way to test it :)
Let me some days and come back to you quickly.

Thanks.

2017-01-16 21:57 GMT+01:00 Philippe Mouawad :

> Hello Maxime,
> I merged some of your PR.
> Did you have the opportunity to make tests of nightly build ?
>
> Your feedback is welcome.
> Thanks
> Regards
>
> On Fri, Jan 13, 2017 at 10:35 AM, Maxime Chassagneux <
> maxime.chassagn...@gmail.com> wrote:
>
> > Hi,
> >
> > Pls, could you consider to merge this PR too :
> >
> >  - PR-241 : Support variable for all JMS messages (bytes, object, ...)
> and
> > sources (file, folder)
> >  - PR-240 : Improves JMS component robustness
> >
> > Thanks .
> >
> > 2017-01-12 21:02 GMT+01:00 Philippe Mouawad  >:
> >
> > > On Thu, Jan 12, 2017 at 8:55 PM, Felix Schumacher <
> > > felix.schumac...@internetallee.de> wrote:
> > >
> > > > Am 12.01.2017 um 20:39 schrieb Philippe Mouawad:
> > > >
> > > >> Hello,
> > > >> What do you think of releasing a 3.2 version ?
> > > >>
> > > > I think I said before, that I would like to release often :)
> > > >
> > > >>
> > > >> I see following reasons:
> > > >>
> > > >> - There is a regression (See bug 60575)
> > > >>
> > > > My fix for 60575 needs tests and review as it changes the contract of
> > the
> > > > method getSendParameterValuesAsPostBody.
> > > >
> > > I reviewed it , it looks ok to me.
> > > I'll double check.
> > >
> > > >
> > > > It returned true if there were no parameters (and thus none with a
> > name).
> > > > (Or if getPostBodyRaw() is true)
> > > >
> > > > After the change it returns only true when there are parameters and
> > none
> > > > of those have a name. (Or if getPostBodyRaw() is true).
> > > >
> > >
> > >
> > >
> > > >
> > > > This method is used in POST and PUT as well, but I believe the change
> > to
> > > > be correct in both places. too.
> > > >
> > > > - We have 9 enhancements and 12  Bug fixes
> > > >> - Some nice features (at least as a current user I find them
> > > >> interesting
> > > >> :-) ):
> > > >>- More space in UI and simpler look
> > > >>- Up to date Browser based on javafx
> > > >>
> > > > We might have to warn a bit more about the need for javafx (The
> default
> > > > java for SUSE Leap42.2 seems to have no javafx). Without javafx
> JMeter
> > > will
> > > > start, but the results tree view is missing.
> > > >
> > >
> > > I think in this case we should try to fail in a bit cleaner way
> > >
> > > >- Or in response assertion
> > > >>- Replace feature (partial)+ counting
> > > >>
> > > >> Maybe we can integrate before next release:
> > > >>
> > > >> - PR-247
> > > >> - PR-246
> > > >> - PR-245
> > > >> - PR-237
> > > >>
> > > >> And upgrade some dependencies:
> > > >>
> > > >> - jodd which has a lot of perf enhancements that we use in
> JMeter
> > > (for
> > > >> resources extractions)
> > > >> - httpcomponents
> > > >> - maybe more
> > > >>
> > > > I would like to link  the converted pdf tutorials and maybe do a bit
> of
> > > > minor tweaks to the look and feel of the web pages (less shadows).
> > > >
> > > > Should the sect-num number of the tutorials be continued from those
> in
> > > the
> > > > usermanual section?
> > > >
> > >
> > > I think so.
> > >
> > >
> > > >> Besides, we did a lot of code changes related to sonar, let's
> release
> > > it.
> > > >>
> > > >> A last good thing is that we start to release more often.
> > > >>
> > > > +1
> > > >
> > > > Felix
> > > >
> > > >>
> > > >>
> > > >
> > >
> > >
> > > --
> > > Cordialement.
> > > Philippe Mouawad.
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Drop rhino

2017-02-10 Thread Maxime Chassagneux
Hi,

As JMeter 3.2 now use Java 1.8 I would like to drop the Rhino Javscript
engine in favor of nashor ( which is already an option today ).

It's mostly easy but I have a question about the BSFJavaScriptEngine class.
Is-it still used ? I don't understand how it work and where it's use.


Re: Wiki Contributors Group

2017-02-11 Thread Maxime Chassagneux
Hello,

@sebb
So if it's possible, could you add me too on the Contributors Group ? (
Maxime Chassagneux )

Thanks in advance.

2017-02-11 22:40 GMT+01:00 sebb :

> The normal process is for the person themselves to ask for edit rights.
> They also need to provide their Wiki name.
>
> On 11 February 2017 at 21:37, Philippe Mouawad
>  wrote:
> > Thanks.
> > Maybe you can also add Maxime Chassagneux by the way ?
> > Thanks
> >
> > On Sat, Feb 11, 2017 at 10:36 PM, sebb  wrote:
> >
> >> Should be OK now
> >>
> >> On 11 February 2017 at 20:15, Graham Russell  wrote:
> >> > Sorry, I still don't seem to be able to edit the wiki.
> >> > Have I missed a big edit button somewhere or was I added to the wrong
> >> group?
> >> > It says on the front page I need to be part of:
> >> > https://wiki.apache.org/jmeter/ContributorsGroup
> >> >
> >> > Thanks
> >> >
> >> > Graham
> >> >
> >> > On 11 February 2017 at 20:11, Graham Russell 
> wrote:
> >> >> Thank you.
> >> >>
> >> >> On 11 February 2017 at 20:09, Antonio Gomes Rodrigues <
> ra0...@gmail.com>
> >> wrote:
> >> >>> Hi,
> >> >>>
> >> >>> Done
> >> >>>
> >> >>> Antonio
> >> >>>
> >> >>> 2017-02-11 20:59 GMT+01:00 Graham Russell :
> >> >>>
> >> >>>> Hi
> >> >>>>
> >> >>>> Could someone please add me (username: ham1) to the Contributors
> Group
> >> >>>> in the wiki? I'd initially like to remove some dead links from the
> >> >>>> home page.
> >> >>>>
> >> >>>> Many thanks
> >> >>>>
> >> >>>> Graham
> >> >>>>
> >>
> >
> >
> >
> > --
> > Cordialement.
> > Philippe Mouawad.
>


FileName in CSVDataSet

2017-02-15 Thread Maxime Chassagneux
Hi,

I have a scenarii which need to make variable the filename field of a
CSVDataSet element.
Actually, this field is computed during the preparation of the test and
only permit to use function or User Defined Variables and I actually need
to access to a thread variable.

As the file is only open during the "iterationStart" method we have access
to all JMeterVariable and I would like to know if it's a good change to
permit to make variable this field ?

Thank you for your feedback.


Preserve encoding file for JUnit test

2017-02-17 Thread Maxime Chassagneux
Hi,

Actualy the build fail because of my new JUnit for JMS.
I have a problem to preserve encoding file.
Someone can help me ?


Re: Preserve encoding file for JUnit test

2017-02-17 Thread Maxime Chassagneux
Hi Philippe,

Thanks for all your remarks, I have to be more careful.
Again sorry for this, I'm not used to SVN.

Regards

2017-02-17 13:56 GMT+01:00 Philippe Mouawad :

> Hello Maxime,
> I've fixed the problem.
>
> Regarding your first commits on project, few notes:
>
>- For any bug or enhancement, for now we should always create a
>bugzilla. PR only should in my opinion only be used for Technical
>improvements of code (Sonar fixes)  or translations for example => DONE
>- Once you have commited, ensure you put as comment the commit message
>in the bugzilla. This allows better understanding of fixes and better
>tracability
>- Code should have javadocs for all public methods and for classes, and
>avoid introducing new javadoc errors.  => TODO on last commit
>- When you add a new Java class, ensure you set SVN property: svn:eol =
>native and add a new line at end of file. For XML it's usually LF =>
> DONE
>
> Thanks
>
> Regards
>
> On Fri, Feb 17, 2017 at 9:41 AM, Maxime Chassagneux <
> maxime.chassagn...@gmail.com> wrote:
>
> > Hi,
> >
> > Actualy the build fail because of my new JUnit for JMS.
> > I have a problem to preserve encoding file.
> > Someone can help me ?
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: Jenkins link show 404

2017-02-22 Thread Maxime Chassagneux
Same for me on :

https://builds.apache.org/job/JMeter-trunk/lastSuccessfulBuild/artifact/trunk/dist/

=> HTTP 404

2017-02-22 23:36 GMT+01:00 Philippe Mouawad :

> Hello,
> Is Jenkins working fine or has JMeter job configuration changed ?
> I get a 404 when calling usual url in nightly build page.
>
> Thanks
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: Drop HTMLAssertion

2017-02-26 Thread Maxime Chassagneux
+1 too

2017-02-26 10:58 GMT+01:00 Antonio Gomes Rodrigues :

> +1 to me
>
> Le 26 févr. 2017 10:17, "Graham Russell"  a écrit :
>
> > +1
> >
> > Sounds good to me too; I only really use the "Response Assertion".
> > I think it's a good thing to remove rarely used features to save
> > effort reading/testing/maintaining/fixing/supporting these.
> >
> > Thanks
> >
> > Graham
> >
> > On 25 February 2017 at 22:17, Philippe Mouawad
> >  wrote:
> > > Hello,
> > > I propose to drop HTML Assertion element as it does not support HTML5
> and
> > > it seems not possible to support it easily :
> > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=60774
> > >
> > > Besides, I am not sure it is really a  useful element.
> > >
> > > Regards
> > > Philippe
> >
>


Re: Release a 3.2

2017-03-02 Thread Maxime Chassagneux
Hi,

I have to update some screen + documentation for the JMS change made by me.
I will do it ASAP.


2017-03-01 23:36 GMT+01:00 Antonio Gomes Rodrigues :

> 2017-03-01 23:03 GMT+01:00 Philippe Mouawad :
>
> > On Wed, Mar 1, 2017 at 10:59 PM, Antonio Gomes Rodrigues <
> ra0...@gmail.com
> > >
> > wrote:
> >
> > > Hi,
> > >
> > > 1.
> > > One question, in jmeter_tutorial.html file we talk about a screenshot
> > which
> > > exit in pdf file but not in html file: "From the screen capture, we see
> > the
> > > following directories. "
> > >
> > > I propose to remove this sentence instead of adding the screen
> > >
> >
> > +1
> >
>
> Done
>
> >
> > >
> > >
> > > Later we talk about:
> > >
> > > "monitortomcat 5 monitor components"
> > >
> > >
> > > "htmlparsera snapshot of HtmlParser, donated by HtmlParser project on
> > > sourceforge"
> > >
> > > These folders don't exist anymore, can I remove them?
> > >
> > +1
> >
>
> Done
>
> >
> > >
> > >
> > > If you are ok, I can make the modifications now
> > >
> > >
> > > 2.
> > >
> > > About jmeter_accesslog_sampler_step_by_step.html file
> > >
> > > My opinion is that this is a gadget and I have never seen someone make
> > > serious load test with access.log file (no correlation between url...)
> > >
> > > I think we need to remove it from homepage
> > >
> >
> > +0, I have seen some blogs about this feature.
> > It can suit some use cases where correlation is not needed.
> >
> In these conditions, I think we need to had more general cases where access
> logs might be inappropriate.
> I will work on it tomorrow
>
>
> >
> > >
> > >
> > > 3.
> > >
> > > About jmeter_proxy_step_by_step.html
> > >
> > > I think we need to write it again to talk to all the new features
> > > (template...)
> > >
> > > I can do it this week
> > >
> > +1
> >
> > >
> > >
> > >
> > > Antonio
> > >
> > >
> > > 2017-03-01 22:30 GMT+01:00 Antonio Gomes Rodrigues :
> > >
> > > > Hi,
> > > >
> > > > my fault, the PDF links have been removed
> > > >
> > > > I check the 5 files and give a feedback asap
> > > >
> > > > Antonio
> > > >
> > > >
> > > >
> > > > 2017-03-01 22:16 GMT+01:00 Philippe Mouawad <
> > philippe.moua...@gmail.com
> > > >:
> > > >
> > > >> Hi Antonio,
> > > >> I removed PDF links, are you sure you generated last docs ?
> > > >> Thanks
> > > >>
> > > >> On Wed, Mar 1, 2017 at 10:14 PM, Antonio Gomes Rodrigues <
> > > >> ra0...@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > Thanks,
> > > >> >
> > > >> > Is it normal that pdf file still exist and the link in the left
> > > >> (Tutorials
> > > >> > (PDF format)) are sill to pdf files?
> > > >> >
> > > >> > Antonio
> > > >> >
> > > >> > 2017-03-01 21:52 GMT+01:00 Felix Schumacher <
> > > >> > felix.schumac...@internetallee.de>:
> > > >> >
> > > >> > > Am 01.03.2017 um 21:07 schrieb Antonio Gomes Rodrigues:
> > > >> > >
> > > >> > >> Hi,
> > > >> > >>
> > > >> > >> About " Ensure the migrated docs (from PDF) do not contain old
> > > "Urban
> > > >> > >> legends"
> > > >> > >> :-) nor bad practices. Those are the 4 Tutorial links in
> left
> > > >> menu.
> > > >> > It
> > > >> > >> would be nice to review them. I've fixed some but not done
> > the
> > > >> full
> > > >> > >> work"
> > > >> > >>
> > > >> > >> Which files are?
> > > >> > >>
> > > >> > > Look for xml files in the xdocs folder, which are named as the
> > > >> tutorials
> > > >> > > on the jmeter homepage in the menu. They should be:
> > > >> > >
> > > >> > > xdocs/usermanual/jmeter_distributed_testing_step_by_step.xml
> > > >> > > xdocs/usermanual/jmeter_proxy_step_by_step.xml
> > > >> > > xdocs/usermanual/junitsampler_tutorial.xml
> > > >> > > xdocs/usermanual/jmeter_accesslog_sampler_step_by_step.xml
> > > >> > > xdocs/usermanual/jmeter_tutorial.xml
> > > >> > >
> > > >> > > Felix
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> > >> Thanks
> > > >> > >> Antonio
> > > >> > >>
> > > >> > >> 2017-03-01 10:44 GMT+01:00 Antonio Gomes Rodrigues <
> > > ra0...@gmail.com
> > > >> >:
> > > >> > >>
> > > >> > >> Hi,
> > > >> > >>>
> > > >> > >>> 2017-02-28 22:54 GMT+01:00 Philippe Mouawad <
> > > >> > philippe.moua...@gmail.com
> > > >> > >>> >:
> > > >> > >>>
> > > >> > >>> Hello,
> > > >> >  We're now at:
> > > >> > 
> > > >> >  - 48 Enhancements
> > > >> >  - 31 bug fixes
> > > >> > 
> > > >> >  Sebb has fixed Windows failures on Jenkins
> > > >> > 
> > > >> >  - Ensure the migrated docs (from PDF) do not contain old
> > > "Urban
> > > >> >  legends"
> > > >> >  :-) nor bad practices. Those are the 4 Tutorial links in
> > left
> > > >> > menu.
> > > >> >  It
> > > >> >  would be nice to review them. I've fixed some but not
> done
> > > the
> > > >> > full
> > > >> >  work
> > > >> > 
> > > >> >  TODO
> > > >> > 
> > > >> >  I will check them today
> > > >> > >>>
> > > >> > >>>
> > > >> > >>>
> > > >> > >>> - Fill in introduced properties in
> properties_reference.xml
> > > >> > 

Variable in BackendListener

2017-03-09 Thread Maxime Chassagneux
Hello,

I can't variabilize parameter of BackendListener when I start a run via
remote test.
None of the value is replace.

If I put something like this :

influxdbUrl => ${__P(influxdbUrl, http://xxx.fr/influxdb_query/write?db=
qualif}

It cause one error :

2017-03-09 08:46:36,232 ERROR o.a.j.s.RemoteListenerWrapper:
testStarted(host) on tlsqninjec10:7080
java.lang.IllegalStateException: Failed calling setupTest
Caused by: java.net.MalformedURLException: no protocol: ${__P(influxdbUrl,
http://xxx.fr/influxdb_query/write?db=qualif)}

Of course it work localy.

Is it normal ? Any tips ? Where I have to start looking for fix it ?


Re: JSR223 Test Element compilation feature

2017-03-09 Thread Maxime Chassagneux
Hello,

For me this option is really interesting as I use a lot of JSR233 script.

+1 for add it !

--
Max

2017-03-09 8:41 GMT+01:00 Philippe Mouawad :

> Hello,
> I have implemented a menu option (in Help that can be moved somewhere else)
> that allows compilation of JSR223 Test Elements.
>
> It visits the test plan tree and compiles any Test Element.
> If compilation fails it set the node in red and logs the compilation
> failure.
>
> This allows detecting some errors without running test plan but not all
> errors like invalid variable usage.
>
> Do you think it should be added to core (It changes JSR223TestElement
> (compile method) and add 1 class for menu) ?
> Thanks
> Regards
>


Re: Variable in BackendListener

2017-03-09 Thread Maxime Chassagneux
Hi,

Thanks for answer,

I try the -G option from controller , and it doesn't work :

I start jmeter like this :

jmeter.bat -GinfluxdbUrl=http://xxx.fr/influxdb_query/write?db=qualif
--addprop "%USERPROFILE%\jmeter\user.properties"

then via GUI mode start a distributed run and still this error :

Still : no protocol: ${__P(influxdbUrl,
http://xxx.fr/influxdb_query/write?db=qualif)

By the way, I don't rly want affect properties, but the default value 
but replace value aren't set for BackendListener.

Regards


2017-03-09 10:22 GMT+01:00 UBIK LOAD PACK Support 
:

> Hello,
>
> In distributed mode use:
> -G from controller
> or -J on jmeter-server
>
> Regards
>
> On Thu, Mar 9, 2017 at 9:52 AM, Maxime Chassagneux <
> maxime.chassagn...@gmail.com> wrote:
>
> > Hello,
> >
> > I can't variabilize parameter of BackendListener when I start a run via
> > remote test.
> > None of the value is replace.
> >
> > If I put something like this :
> >
> > influxdbUrl => ${__P(influxdbUrl, http://xxx.fr/influxdb_query/write?db=
> > qualif}
> >
> > It cause one error :
> >
> > 2017-03-09 08:46:36,232 ERROR o.a.j.s.RemoteListenerWrapper:
> > testStarted(host) on tlsqninjec10:7080
> > java.lang.IllegalStateException: Failed calling setupTest
> > Caused by: java.net.MalformedURLException: no protocol:
> ${__P(influxdbUrl,
> > http://xxx.fr/influxdb_query/write?db=qualif)}
> >
> > Of course it work localy.
> >
> > Is it normal ? Any tips ? Where I have to start looking for fix it ?
> >
>
>
>
> --
>
> Regards
> Ubik Load Pack <http://ubikloadpack.com> Team
> Follow us on Twitter <http://twitter.com/ubikloadpack>
>
>
> Cordialement
> L'équipe Ubik Load Pack <http://ubikloadpack.com>
> Suivez-nous sur Twitter <http://twitter.com/ubikloadpack>
>


Re: Variable in BackendListener

2017-03-09 Thread Maxime Chassagneux
2017-03-09 14:42 GMT+01:00 sebb :

> On 9 March 2017 at 08:52, Maxime Chassagneux
>  wrote:
> > Hello,
> >
> > I can't variabilize parameter of BackendListener when I start a run via
> > remote test.
> > None of the value is replace.
> >
> > If I put something like this :
> >
> > influxdbUrl => ${__P(influxdbUrl, http://xxx.fr/influxdb_query/write?db=
> > qualif}
>
> Where exactly did you use this?
>

Here : https://www.dropbox.com/s/s569388q4s9x2c4/2017-03-09_145548.png?dl=0


>
> > It cause one error :
> >
> > 2017-03-09 08:46:36,232 ERROR o.a.j.s.RemoteListenerWrapper:
> > testStarted(host) on tlsqninjec10:7080
> > java.lang.IllegalStateException: Failed calling setupTest
> > Caused by: java.net.MalformedURLException: no protocol:
> ${__P(influxdbUrl,
> > http://xxx.fr/influxdb_query/write?db=qualif)}
>
> That indicates that the string is not being parsed for variable references.
>
> > Of course it work localy.
> >
> > Is it normal ? Any tips ? Where I have to start looking for fix it ?
>
> The BackendListener code. Add some debug if necessary.
>

I will try :)


Re: Variable in BackendListener

2017-03-10 Thread Maxime Chassagneux
Hi,

Could you look at the #283 PR on github to review my patch.

Thanks.

2017-03-09 14:58 GMT+01:00 Maxime Chassagneux 
:

>
> 2017-03-09 14:42 GMT+01:00 sebb :
>
>> On 9 March 2017 at 08:52, Maxime Chassagneux
>>  wrote:
>> > Hello,
>> >
>> > I can't variabilize parameter of BackendListener when I start a run via
>> > remote test.
>> > None of the value is replace.
>> >
>> > If I put something like this :
>> >
>> > influxdbUrl => ${__P(influxdbUrl, http://xxx.fr/influxdb_query/w
>> rite?db=
>> > qualif}
>>
>> Where exactly did you use this?
>>
>
> Here : https://www.dropbox.com/s/s569388q4s9x2c4/2017-03-09_
> 145548.png?dl=0
>
>
>>
>> > It cause one error :
>> >
>> > 2017-03-09 08:46:36,232 ERROR o.a.j.s.RemoteListenerWrapper:
>> > testStarted(host) on tlsqninjec10:7080
>> > java.lang.IllegalStateException: Failed calling setupTest
>> > Caused by: java.net.MalformedURLException: no protocol:
>> ${__P(influxdbUrl,
>> > http://xxx.fr/influxdb_query/write?db=qualif)}
>>
>> That indicates that the string is not being parsed for variable
>> references.
>>
>> > Of course it work localy.
>> >
>> > Is it normal ? Any tips ? Where I have to start looking for fix it ?
>>
>> The BackendListener code. Add some debug if necessary.
>>
>
> I will try :)
>
>


Trim JTexfield

2017-03-10 Thread Maxime Chassagneux
Hello,

There is a reason why none JTexfield aren't trim by default ?
In most cases, end spaces aren't desire and are problematic.
By example, If you put one space after the Vuser number the run don't start
without any error ...
Yesterday I spent an hour to debug a problem on a JDBC connection
configuration because I have a blank after the 'JDBC Driver Class' field
due to a copy paste from internet...

I'm the only one worry about that ?

Regards


Re: Release a 3.2

2017-03-28 Thread Maxime Chassagneux
some
> > >> >>>> >> > > >>>> of them, but one is specifically breaking WebDriver
> > >> sampler.
> > >> >>>> We're
> > >> >>>> >> > > going
> > >> >>>> >> > > >>>> to file bugzilla on it.
> > >> >>>> >> > > >>>>
> > >> >>>> >> > > >>>> IMO it's not good to release without fixing this,
> since
> > >> it will
> > >> >>>> >> > break
> > >> >>>> >> > > >>>> everyone who uses WebDriver Sampler.
> > >> >>>> >> > > >>>>
> > >> >>>> >> > > >>>> Andrey Pokhilko
> > >> >>>> >> > > >>>>
> > >> >>>> >> > > >>>> On 16.03.2017 15:32, Philippe Mouawad wrote:
> > >> >>>> >> > > >>>>> Hello,
> > >> >>>> >> > > >>>>> Any feedback on patch ?
> > >> >>>> >> > > >>>>> Shall we proceed with release without fixing it ?
> > >> >>>> >> > > >>>>> Is there any other remaining work ?
> > >> >>>> >> > > >>>>>
> > >> >>>> >> > > >>>>> Thanks
> > >> >>>> >> > > >>>>> Regards
> > >> >>>> >> > > >>>>> Philippe
> > >> >>>> >> > > >>>>>
> > >> >>>> >> > > >>>>> On Sunday, March 12, 2017, Philippe Mouawad <
> > >> >>>> >> > > >> philippe.moua...@gmail.com >
> > >> >>>> >> > > >>>>> wrote:
> > >> >>>> >> > > >>>>>
> > >> >>>> >> > > >>>>>> Hello,
> > >> >>>> >> > > >>>>>> I've filled New and Noteworthy section, feel free
> to
> > >> improve.
> > >> >>>> >> > > >>>>>> I've also documented migration to new logging.
> > >> >>>> >> > > >>>>>>
> > >> >>>> >> > > >>>>>> I think we can now release the 3.2 except for this
> > bug
> > >> which
> > >> >>>> >> > exists
> > >> >>>> >> > > >>>> since
> > >> >>>> >> > > >>>>>> many versions, I've attached a patch for review:
> > >> >>>> >> > > >>>>>> - https://bz.apache.org/
> > bugzilla/show_bug.cgi?id=60830
> > >> >>>> >> > > >>>>>>
> > >> >>>> >> > > >>>>>> Regards
> > >> >>>> >> > > >>>>>>
> > >> >>>> >> > > >>>>>> On Mon, Mar 6, 2017 at 10:14 PM, Antonio Gomes
> > >> Rodrigues <
> > >> >>>> >> > > >>>> ra0...@gmail.com 
> > >> >>>> >> > > >>>>>>  > >> >>>> ');>> wrote:
> > >> >>>> >> > > >>>>>>
> > >> >>>> >> > > >>>>>>> Hi,
> > >> >>>> >> > > >>>>>>>
> > >> >>>> >> > > >>>>>>> Modifications in the PR done
> > >> >>>> >> > > >>>>>>>
> > >> >>>> >> > > >>>>>>> Antonio
> > >> >>>> >> > > >>>>>>>
> > >> >>>> >> > > >>>>>>> 2017-03-06 15:51 GMT+01:00 Antonio Gomes
> Rodrigues <
> > >> >>>> >> > > ra0...@gmail.com 
> > >> >>>> >> > > >>>>>>>  > >> >>>> ');>>:
> > >> >>>>

Re: svn commit: r1790839 - /jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java

2017-04-11 Thread Maxime Chassagneux
I revert it

2017-04-10 18:59 GMT+02:00 Philippe Mouawad :

> On Monday, April 10, 2017,  wrote:
>
> > Author: mchassagneux
> > Date: Mon Apr 10 14:43:56 2017
> > New Revision: 1790839
> >
> > URL: http://svn.apache.org/viewvc?rev=1790839&view=rev
> > Log:
> > Don't cumul intial delay + ramp-up delay for a new thread create in the
> > fly.
> > Bugzilla Id: 60530
> >
> > Modified:
> > jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java
> >
> > Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/
> ThreadGroup.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> > apache/jmeter/threads/ThreadGroup.java?rev=1790839&
> > r1=1790838&r2=1790839&view=diff
> > 
> > ==
> > --- jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java
> > (original)
> > +++ jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java Mon
> > Apr 10 14:43:56 2017
> > @@ -385,6 +385,8 @@ public class ThreadGroup extends Abstrac
> >  numThreads = getNumThreads();
> >  setNumThreads(numThreads + 1);
> >  }
> > +   // Don't cumul intialDelay + rampup delay
> > +   setDelay(0);
>
>
> -1
> The fix does not look good to me.
> Why touch the delay of thread group here ?
>
> such change requires non regression test.
> We're also in the middle of RC, commits are usually avoided except for
> tests.
>
>
> >  newJmThread = startNewThread(notifier, threadGroupTree, engine,
> > numThreads, context, now, delay);
> >  JMeterContextService.addTotalThreads( 1 );
> >  log.info("Started new thread in group {}", groupNumber);
> >
> >
> >
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: [VOTE] Release JMeter 3.2 RC3

2017-04-13 Thread Maxime Chassagneux
My vote : +1

2017-04-13 9:46 GMT+02:00 Milamber :

>
> @PMC
>
> We need at least 3 '+1' votes from PMC members to allow this release.
> Currently we have only 2 +1.
>
>
> On 09/04/2017 17:31, Milamber wrote:
>
>> Hello,
>>
>> The third release candidate for JMeter 3.2 (r1790748) has been prepared,
>> and your votes are solicited.
>>
>> This release brings new features and fixes bugs.
>>
>> Please, test this release candidate (with load tests and/or functional
>> tests) using Java 8 on Linux/Windows/Mac OS, especially on the changes. The
>> feedback are welcome.
>>
>> You can read the New and Noteworthy section with some screenshots to
>> illustrate improvements and full list of changes at:
>> http://home.apache.org/~milamber/jmeter-3.2RC3/docs/changes.html
>>
>> JMeter is a Java desktop application designed to load test functional
>> behavior and measure performance. The current version is targeted at Java
>> 8+.
>>
>> Download - Archives/hashes/sigs:
>>
>> https://dist.apache.org/repos/dist/dev/jmeter/v3.2_RC3/
>> (dist revision r19091)
>>
>> RAT report:
>>
>> http://home.apache.org/~milamber/jmeter-3.2RC3/dist/rat-
>> report-jmeter-3.2RC3.txt
>>
>> MD5 hashes of archives for this vote:
>>
>> 04a0119f3c66ec157d78725135f79863 *apache-jmeter-3.2.tgz
>> a670f1160621710d69136851d26c5b56 *apache-jmeter-3.2.zip
>> 28b99b6155f2ae5ac7d9440915f1e3a0 *apache-jmeter-3.2_src.tgz
>> d5936f4f471b6b84c0d7f8b5c75ea72d *apache-jmeter-3.2_src.zip
>>
>> Site Docs are here:
>> http://home.apache.org/~milamber/jmeter-3.2RC3/docs/
>>
>> Maven staging repository is accessible here:
>> https://repository.apache.org/content/repositories/orgapache
>> jmeter-1017/org/apache/jmeter/
>>
>> Tag:
>> https://svn.apache.org/repos/asf/jmeter/tags/v3_2_RC3/
>>
>> Keys are here:
>> https://www.apache.org/dist/jmeter/KEYS
>>
>> N.B.
>> To download the dependencies: "ant download_jars"
>>
>> To create the jars and test JMeter: "ant package test".
>>
>> JMeter 3.2 requires Java 8 or later to run.
>>
>> Some known issues and incompatible changes are listed on changes page.
>> http://home.apache.org/~milamber/jmeter-3.2RC3/docs/changes.
>> html#Known%20problems%20and%20workarounds
>>
>>
>> All feedback and vote are welcome.
>>
>> [  ] +1  I support this release
>> [  ] +0  I am OK with this release
>> [  ] -0   OK, but
>> [  ] -1   I do not support this release (please indicate why)
>>
>> The vote will remain open for at least 72 hours.
>>
>> The PMC members please indicate the mention "(binding)" with your vote.
>>
>>
>> Note: If the vote passes, the intention is to release the archive files
>> and rename the RC tag as the release tag.
>>
>> Thanks in advance!
>>
>> Milamber
>>
>>
>>
>>
>>
>>
>>
>>
>


Re: Use of https://github.com/HdrHistogram/HdrHistogram

2017-05-06 Thread Maxime Chassagneux
+1 : lgtm

2017-05-06 15:41 GMT+02:00 Philippe Mouawad :

> Hello,
> A user recently reported a bug on StatCalculator class:
>
>- https://bz.apache.org/bugzilla/show_bug.cgi?id=61071
>
> It appears issue is not restrained to Median but concerns  percentile
> computing.
>
> Besides, this class has many drawbacks:
>
>- It is not tested as much as it should be
>- It relies on an algorithm that consumes memory
>
> We use another class in Web/Dashboard report and BackendListener client
> implementations that relies on commons-math
> org.apache.commons.math3.stat.descriptive.DescriptiveStatistics.
>
> My proposal is the following:
>
>- First step : Introduce in StatCalculator, HdrHistogram
>- Second step : Replace DescriptiveStatistics by HdrHistogram
>
>
> Benefits:
>
>- Uniform computing accross JMeter
>- Better performances
>
> Are you ok with this approach ?
>
> Thanks
> --
> Regards.
> Philippe Mouawad.
> Ubik-Ingénierie
>


Re: Let's release a Minor version ?

2017-06-02 Thread Maxime Chassagneux
+1 to release more often release

Regards

2017-06-02 21:05 GMT+02:00 Philippe Mouawad :

> Hi Antonio,
> Feel free to answer my mail.
>
> I don't think there is any emergency on this matter anyway.
>
> Regards
>
> On Fri, Jun 2, 2017 at 2:27 PM, Antonio Gomes Rodrigues 
> wrote:
>
> > Hi,
> >
> > I think we need to have a solution about percentile before release a new
> > version
> >
> > But I am OK to release a new minor version after
> >
> > Antonio
> >
> > 2017-05-29 23:03 GMT+02:00 Philippe Mouawad  >:
> >
> > > Hello,
> > > I think we should release a new minor version of JMeter for the
> following
> > > reasons:
> > >
> > >- There a fixes that need to be released early (InfluxDB,
> > >Search/Replace,Port field, report...)
> > >- There is a nasty bug in Caffeine 2.5.0 which may affect CSS
> parsing
> > >- There are nice little features:
> > >   - Time shifting
> > >   - Brotli
> > >
> > > Depending on answer to my other mail "JMeter version numbering", we can
> > > name it 3.3 (my proposal) or 3.2.1.
> > >
> > > --
> > > Regards.
> > > Philippe
> > >
> >
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: svn commit: r1798048 - in /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend: ErrorMetric.java SamplerMetric.java influxdb/InfluxdbBackendListenerClient.java

2017-06-08 Thread Maxime Chassagneux
Hello Philippe,

I commit a grafana template ( json format ) in the extra folder of JMeter.
But I don't understand what you want with a test plan, as the Backend
Listener work only with a Influxdb server.

2017-06-08 13:59 GMT+02:00 Philippe Mouawad :

> Hello Maxime,
> To simplify testing would it be possible to provide a sample grafana and
> test plan ?
>
> Thanks
>
> On Thursday, June 8, 2017,  wrote:
>
> > Author: mchassagneux
> > Date: Thu Jun  8 11:53:42 2017
> > New Revision: 1798048
> >
> > URL: http://svn.apache.org/viewvc?rev=1798048&view=rev
> > Log:
> > InfluxdbBackendListener : add number of errors by response code and
> > message for each transaction
> > Bugzilla Id: 61167
> >
> > Added:
> > jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> > backend/ErrorMetric.java
> > Modified:
> > jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> > backend/SamplerMetric.java
> > jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> > backend/influxdb/InfluxdbBackendListenerClient.java
> >
> > Added: jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> > backend/ErrorMetric.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> > org/apache/jmeter/visualizers/backend/ErrorMetric.java?rev=
> > 1798048&view=auto
> > 
> > ==
> > --- jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> backend/ErrorMetric.java
> > (added)
> > +++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> backend/ErrorMetric.java
> > Thu Jun  8 11:53:42 2017
> > @@ -0,0 +1,82 @@
> > +/*
> > + * Licensed to the Apache Software Foundation (ASF) under one or more
> > + * contributor license agreements.  See the NOTICE file distributed with
> > + * this work for additional information regarding copyright ownership.
> > + * The ASF licenses this file to You under the Apache License, Version
> 2.0
> > + * (the "License"); you may not use this file except in compliance with
> > + * the License.  You may obtain a copy of the License at
> > + *
> > + *   http://www.apache.org/licenses/LICENSE-2.0
> > + *
> > + * Unless required by applicable law or agreed to in writing, software
> > + * distributed under the License is distributed on an "AS IS" BASIS,
> > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> > implied.
> > + * See the License for the specific language governing permissions and
> > + * limitations under the License.
> > + *
> > + */
> > +
> > +package org.apache.jmeter.visualizers.backend;
> > +
> > +import org.apache.jmeter.samplers.SampleResult;
> > +
> > +/**
> > + * Object representing an error by a response code and response message
> > + * @since 3.3
> > + */
> > +public class ErrorMetric {
> > +
> > +private String responseCode = "";
> > +private String responseMessage = "";
> > +
> > +public ErrorMetric() {
> > +}
> > +
> > +public ErrorMetric(SampleResult result) {
> > +responseCode = result.getResponseCode();
> > +responseMessage = result.getResponseMessage();
> > +}
> > +
> > +/**
> > + * @return the response code , '0' if he code is empty
> > + */
> > +public String getResponseCode() {
> > +if (responseCode.isEmpty()) {
> > +return "0";
> > +} else {
> > +return responseCode;
> > +}
> > +}
> > +
> > +/**
> > + * @return the response message , 'none' if he code is empty
> > + */
> > +public String getResponseMessage() {
> > +if (responseMessage.isEmpty()) {
> > +return "None";
> > +} else {
> > +return responseMessage;
> > +}
> > +}
> > +
> > +@Override
> > +public boolean equals(Object other) {
> > +if (!(other instanceof ErrorMetric)) {
> > +return false;
> > +}
> > +
> > +ErrorMetric otherError = (ErrorMetric) other;
> > +if (getResponseCode().equalsIgnoreCase(otherError.
> > getResponseCode())
> > +&& getResponseMessage().equalsIgnoreCase(otherError.
> getResponseMessage()))
> > {
> > +return true;
> > +} else {
> > +return false;
> > +}
> > +}
> > +
> > +@Override
> > +public int hashCode() {
> > +return getResponseCode().hashCode() +
> > getResponseMessage().hashCode();
> > +}
> > +
> > +}
> >
> > Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> > backend/SamplerMetric.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/
> > org/apache/jmeter/visualizers/backend/SamplerMetric.java?
> > rev=1798048&r1=1798047&r2=1798048&view=diff
> > 
> > ==
> > --- jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> backend/SamplerMetric.java
> > (original)
> > +++ jmeter/trunk/src/components/org/apache/jmeter/visualizers/
> bac

Re: svn commit: r1798048 - in /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend: ErrorMetric.java SamplerMetric.java influxdb/InfluxdbBackendListenerClient.java

2017-06-09 Thread Maxime Chassagneux
2017-06-08 21:40 GMT+02:00 Felix Schumacher <
felix.schumac...@internetallee.de>:

> Am 08.06.2017 um 13:53 schrieb mchassagn...@apache.org:
>
>> Author: mchassagneux
>> Date: Thu Jun  8 11:53:42 2017
>> New Revision: 1798048
>>
>> URL: http://svn.apache.org/viewvc?rev=1798048&view=rev
>> Log:
>> InfluxdbBackendListener : add number of errors by response code and
>> message for each transaction
>> Bugzilla Id: 61167
>>
>> Added:
>>  jmeter/trunk/src/components/org/apache/jmeter/visualizers/b
>> ackend/ErrorMetric.java
>> Modified:
>>  jmeter/trunk/src/components/org/apache/jmeter/visualizers/b
>> ackend/SamplerMetric.java
>>  jmeter/trunk/src/components/org/apache/jmeter/visualizers/b
>> ackend/influxdb/InfluxdbBackendListenerClient.java
>>
>> Added: jmeter/trunk/src/components/org/apache/jmeter/visualizers/ba
>> ckend/ErrorMetric.java
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org
>> /apache/jmeter/visualizers/backend/ErrorMetric.java?rev=1798048&view=auto
>> 
>> ==
>> --- 
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/ErrorMetric.java
>> (added)
>> +++ 
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/ErrorMetric.java
>> Thu Jun  8 11:53:42 2017
>> @@ -0,0 +1,82 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements.  See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, Version
>> 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License.  You may obtain a copy of the License at
>> + *
>> + *   http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
>> implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + *
>> + */
>> +
>> +package org.apache.jmeter.visualizers.backend;
>> +
>> +import org.apache.jmeter.samplers.SampleResult;
>> +
>> +/**
>> + * Object representing an error by a response code and response message
>> + * @since 3.3
>> + */
>> +public class ErrorMetric {
>> +
>> +private String responseCode = "";
>> +private String responseMessage = "";
>> +
>> +public ErrorMetric() {
>>
> Place a comment inside to specify, why this is empty.
> This and the other comments below are also reported by sonar :)


Done


>
> +}
>> +
>> +public ErrorMetric(SampleResult result) {
>> +responseCode = result.getResponseCode();
>> +responseMessage = result.getResponseMessage();
>> +}
>> +
>> +/**
>> + * @return the response code , '0' if he code is empty
>> + */
>> +public String getResponseCode() {
>> +if (responseCode.isEmpty()) {
>> +return "0";
>> +} else {
>> +return responseCode;
>> +}
>> +}
>> +
>> +/**
>> + * @return the response message , 'none' if he code is empty
>> + */
>> +public String getResponseMessage() {
>> +if (responseMessage.isEmpty()) {
>> +return "None";
>> +} else {
>> +return responseMessage;
>> +}
>> +}
>> +
>> +@Override
>> +public boolean equals(Object other) {
>> +if (!(other instanceof ErrorMetric)) {
>> +return false;
>> +}
>> +
>> +ErrorMetric otherError = (ErrorMetric) other;
>> +if (getResponseCode().equalsIgnoreCase(otherError.getResponseCo
>> de())
>> +&& getResponseMessage().equalsIgn
>> oreCase(otherError.getResponseMessage())) {
>> +return true;
>> +} else {
>> +return false;
>> +}
>>
>
> Return the value of the expression directly instead of if (expr) { return
> true; } else { return false; }


Done

>


> +}
>> +
>> +@Override
>> +public int hashCode() {
>> +return getResponseCode().hashCode() +
>> getResponseMessage().hashCode();
>> +}
>> +
>> +}
>>
>> Modified: jmeter/trunk/src/components/org/apache/jmeter/visualizers/ba
>> ckend/SamplerMetric.java
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org
>> /apache/jmeter/visualizers/backend/SamplerMetric.java?rev=
>> 1798048&r1=1798047&r2=1798048&view=diff
>> 
>> ==
>> --- 
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/SamplerMetric.java
>> (original)
>> +++ 
>> jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/SamplerMetric.java
>> Thu Jun  8 11:53:42 2017
>> @@ -21,6 +21,7 @@ package org.apache.jmeter.visualizers.ba
>>   import java.ut

Re: svn commit: r1797920 - in /jmeter/trunk: src/core/org/apache/jmeter/engine/PreCompiler.java src/core/org/apache/jmeter/threads/JMeterContext.java src/core/org/apache/jmeter/threads/JMeterContextSe

2017-06-09 Thread Maxime Chassagneux
Hello,

I use this patch from 2-3 months without bugs.
In fact it's impossible to access to the new shared JMeterVariables variables
in a executed nide of JMeter.
This field is null and only set for the client side instance.

May be it's possible to improve this patch, rather than revert it ?

2017-06-09 7:10 GMT+02:00 Philippe Mouawad :

> Hello Maxime,
> I am not sure this commit is a good idea.
> JMeterVariables are usually available per Thread and each VU (Thread)
> manipulates his own copy.
> Here you introduce a shared static JMeterVariables which is not thread
> safe.
> I think this will introduce bugs and I am not fond of the  new API.
>
> Regards
>
>
>
>
> On Wed, Jun 7, 2017 at 3:26 PM,  wrote:
>
> > Author: mchassagneux
> > Date: Wed Jun  7 13:26:36 2017
> > New Revision: 1797920
> >
> > URL: http://svn.apache.org/viewvc?rev=1797920&view=rev
> > Log:
> > Allow to use variables ( from User Defined Variables only ) in all
> > listeners in slave mode
> > Bugzilla Id: 57962
> >
> > Modified:
> > jmeter/trunk/src/core/org/apache/jmeter/engine/PreCompiler.java
> > jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
> > jmeter/trunk/src/core/org/apache/jmeter/threads/
> > JMeterContextService.java
> > jmeter/trunk/xdocs/changes.xml
> >
> > Modified: jmeter/trunk/src/core/org/apache/jmeter/engine/
> PreCompiler.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> > apache/jmeter/engine/PreCompiler.java?rev=1797920&
> > r1=1797919&r2=1797920&view=diff
> > 
> > ==
> > --- jmeter/trunk/src/core/org/apache/jmeter/engine/PreCompiler.java
> > (original)
> > +++ jmeter/trunk/src/core/org/apache/jmeter/engine/PreCompiler.java Wed
> > Jun  7 13:26:36 2017
> > @@ -28,6 +28,7 @@ import org.apache.jmeter.testelement.Tes
> >  import org.apache.jmeter.testelement.TestPlan;
> >  import org.apache.jmeter.threads.JMeterContextService;
> >  import org.apache.jmeter.threads.JMeterVariables;
> > +import org.apache.jmeter.visualizers.backend.Backend;
> >  import org.apache.jorphan.collections.HashTree;
> >  import org.apache.jorphan.collections.HashTreeTraverser;
> >  import org.slf4j.Logger;
> > @@ -61,7 +62,7 @@ public class PreCompiler implements Hash
> >  /** {@inheritDoc} */
> >  @Override
> >  public void addNode(Object node, HashTree subTree) {
> > -if(isRemote && node instanceof ResultCollector)
> > +if(isRemote && (node instanceof ResultCollector || node
> > instanceof Backend))
> >  {
> >  try {
> >  replacer.replaceValues((TestElement) node);
> > @@ -69,10 +70,8 @@ public class PreCompiler implements Hash
> >  log.error("invalid variables", e);
> >  }
> >  }
> > -if (isRemote) {
> > -return;
> > -}
> > -if(node instanceof TestElement)
> > +
> > +if(!isRemote && node instanceof TestElement)
> >  {
> >  try {
> >  replacer.replaceValues((TestElement) node);
> > @@ -86,14 +85,24 @@ public class PreCompiler implements Hash
> >  replacer.setUserDefinedVariables(args);
> >  JMeterVariables vars = new JMeterVariables();
> >  vars.putAll(args);
> > -JMeterContextService.getContext().setVariables(vars);
> > +// Don't store variable of test plan in the context for
> > client side
> > +if (isRemote) {
> > +JMeterContextService.setClientVariable(vars);
> > +} else {
> > +JMeterContextService.getContext().setVariables(vars);
> > +}
> >  }
> >
> >  if (node instanceof Arguments) {
> >  ((Arguments)node).setRunningVersion(true);
> >  Map args = ((Arguments)
> > node).getArgumentsAsMap();
> >  replacer.addVariables(args);
> > -JMeterContextService.getContext().getVariables().
> > putAll(args);
> > +// Don't store User Defined Variables in the context for
> > client side
> > +if (isRemote) {
> > +JMeterContextService.getClientVariable().putAll(args);
> > +} else {
> > +JMeterContextService.getContext().getVariables().
> > putAll(args);
> > +}
> >  }
> >  }
> >
> >
> > Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/
> > JMeterContext.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> > apache/jmeter/threads/JMeterContext.java?rev=
> > 1797920&r1=1797919&r2=1797920&view=diff
> > 
> > ==
> > --- jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
> > (original)
> > +++ jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java
> > Wed Jun  7 13:26:36 2017
> > @@ -79,7 +79,8 @@ public class JMeterContext {
> >   * @return 

Re: svn commit: r1798053 - /jmeter/trunk/extras/GrafanaJMeterTemplate.json

2017-06-26 Thread Maxime Chassagneux
Hi,

Yeah my bad, I modify it.

2017-06-26 16:05 GMT+02:00 sebb :

> On 8 June 2017 at 13:53,   wrote:
> > Author: mchassagneux
> > Date: Thu Jun  8 12:53:52 2017
> > New Revision: 1798053
> >
> > URL: http://svn.apache.org/viewvc?rev=1798053&view=rev
> > Log:
> > Add a Grafana Template
> > Bugzilla Id: 61167
> >
> > Added:
> > jmeter/trunk/extras/GrafanaJMeterTemplate.json   (with props)
> >
> > Added: jmeter/trunk/extras/GrafanaJMeterTemplate.json
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/extras/
> GrafanaJMeterTemplate.json?rev=1798053&view=auto
> > 
> ==
> > --- jmeter/trunk/extras/GrafanaJMeterTemplate.json (added)
> > +++ jmeter/trunk/extras/GrafanaJMeterTemplate.json Thu Jun  8 12:53:52
> 2017
> > @@ -0,0 +1,1459 @@
> > +{
>
> The characters before the '{' don't look right.
>
> Maybe a spurious UTF BOM?
>
> > +  "id": 97,
> > +  "title": "JMeter Metric Template",
> > +  "tags": [],
> > +  "style": "dark",
> > +  "timezone": "browser",
> > +  "editable": true,
> > +  "sharedCrosshair": true,
> > +  "hideControls": false,
> > +  "time": {
> > +"from": "2017-06-08T01:09:30.935Z",
> > +"to": "2017-06-08T02:55:58.972Z"
> > +  },
> > +  "timepicker": {
> > +"now": true,
> > +"refresh_intervals": [
> > +  "10s",
> > +  "30s",
> > +  "1m",
> > +  "5m",
> > +  "15m",
> > +  "30m",
> > +  "1h",
> > +  "2h",
> > +  "1d"
> > +],
> > +"time_options": [
> > +  "5m",
> > +  "15m",
> > +  "1h",
> > +  "6h",
> > +  "12h",
> > +  "24h",
> > +  "2d",
> > +  "7d",
> > +  "30d"
> > +]
> > +  },
> > +  "templating": {
> > +"list": [
> > +  {
> > +"allValue": ".*",
> > +"datasource": "jmeterdb",
> > +"hide": 0,
> > +"includeAll": false,
> > +"label": null,
> > +"multi": true,
> > +"name": "app",
> > +"options": [],
> > +"query": "SHOW TAG VALUES FROM \"process\" WITH KEY =
> \"application\"",
> > +"refresh": 2,
> > +"regex": "",
> > +"sort": 1,
> > +"tagValuesQuery": "",
> > +"tagsQuery": "SHOW TAG VALUES FROM \"events\" WITH KEY =
> \"tags\"",
> > +"type": "query"
> > +  },
> > +  {
> > +"allFormat": "regex wildcard",
> > +"auto": false,
> > +"auto_count": 10,
> > +"auto_min": "10s",
> > +"current": {
> > +  "text": "1m",
> > +  "value": "1m"
> > +},
> > +"datasource": "jmeterdb",
> > +"hide": 0,
> > +"includeAll": true,
> > +"label": "",
> > +"multi": false,
> > +"multiFormat": "glob",
> > +"name": "granularity",
> > +"options": [
> > +  {
> > +"text": "1m",
> > +"value": "1m",
> > +"selected": true
> > +  },
> > +  {
> > +"text": "5m",
> > +"value": "5m",
> > +"selected": false
> > +  },
> > +  {
> > +"text": "1h",
> > +"value": "1h",
> > +"selected": false
> > +  },
> > +  {
> > +"text": "5s",
> > +"value": "5s",
> > +"selected": false
> > +  },
> > +  {
> > +"text": "15s",
> > +"value": "15s",
> > +"selected": false
> > +  },
> > +  {
> > +"text": "30s",
> > +"value": "30s",
> > +"selected": false
> > +  }
> > +],
> > +"query": "1m,5m,1h,5s,15s,30s",
> > +"refresh": 2,
> > +"regex": "",
> > +"type": "interval"
> > +  },
> > +  {
> > +"allValue": null,
> > +"current": {
> > +  "text": "default",
> > +  "value": "default",
> > +  "tags": []
> > +},
> > +"datasource": "jmeterdb",
> > +"hide": 0,
> > +"includeAll": false,
> > +"label": null,
> > +"multi": false,
> > +"name": "retention",
> > +"options": [],
> > +"query": "SHOW RETENTION POLICIES ON \"jmeterdb\"",
> > +"refresh": 1,
> > +"regex": "",
> > +"sort": 0,
> > +"tagValuesQuery": null,
> > +"tagsQuery": null,
> > +"type": "query"
> > +  },
> > +  {
> > +"allValue": ".*",
> > +"current": {
> > +  "value": [
> > +"$__all"
> > +  ],
> > +  "text": "All"
> > +},
> > +"datasource": "jmeterdb",
> > +"hide": 0,
> > +"includeAll": true,
> > +"label": null,
> > +"multi": true,
> > +"name": "transaction",
> > +"options": [],
> > +"query": "SHOW TAG VALUES FROM \"jmeter\" WITH KEY IN
> (\"transaction\",\"application\") where application =~ /$app/ and
> transaction  !~ /all/",
> > +  

MongoDB driver

2017-07-19 Thread Maxime Chassagneux
Hi,

The JMeter bundle still include a mongoDB java driver ( version 2.11.3 )
which is really old and doesn't work with all authentication

By example :

javax.script.ScriptException: java.lang.IllegalArgumentException:
Unsupported authMechanism: SCRAM-SHA-1


As mongoDB is deprecated in JMeter, my question is : Should we keep this
librairie or update it to the lastest version ?

Thanks for ur feedback.


Re: svn commit: r1802896 - /jmeter/trunk/src/functions/org/apache/jmeter/functions/TimeShift.java

2017-07-25 Thread Maxime Chassagneux
Hi Philippe,

It's done :)

Regards

2017-07-25 10:09 GMT+02:00 Philippe Mouawad :

> Hi Maxime,
> Is it possible to add JUnits ?
>
> Thanks
>
> On Tue, Jul 25, 2017 at 9:59 AM,  wrote:
>
> > Author: mchassagneux
> > Date: Tue Jul 25 07:59:29 2017
> > New Revision: 1802896
> >
> > URL: http://svn.apache.org/viewvc?rev=1802896&view=rev
> > Log:
> > make date & period variable on each execution
> > Bugzilla Id: 61335
> >
> > Modified:
> > jmeter/trunk/src/functions/org/apache/jmeter/functions/
> TimeShift.java
> >
> > Modified: jmeter/trunk/src/functions/org/apache/jmeter/functions/
> > TimeShift.java
> > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/functions/
> > org/apache/jmeter/functions/TimeShift.java?rev=1802896&r1=
> > 1802895&r2=1802896&view=diff
> > 
> > ==
> > --- jmeter/trunk/src/functions/org/apache/jmeter/functions/
> TimeShift.java
> > (original)
> > +++ jmeter/trunk/src/functions/org/apache/jmeter/functions/
> TimeShift.java
> > Tue Jul 25 07:59:29 2017
> > @@ -71,8 +71,8 @@ public class TimeShift extends AbstractF
> >
> >  // Ensure that these are set, even if no paramters are provided
> >  private String format = ""; //$NON-NLS-1$
> > -private String dateToShift = ""; //$NON-NLS-1$
> > -private String amountToShift = ""; //$NON-NLS-1$
> > +private CompoundVariable dateToShiftCompound; //$NON-NLS-1$
> > +private CompoundVariable amountToShiftCompound; //$NON-NLS-1$
> >  private String variableName = ""; //$NON-NLS-1$
> >  private ZoneId systemDefaultZoneID = ZoneId.systemDefault();
> >
> > @@ -87,6 +87,8 @@ public class TimeShift extends AbstractF
> >  @Override
> >  public String execute(SampleResult previousResult, Sampler
> > currentSampler) throws InvalidVariableException {
> >  String dateString;
> > +String amountToShift = amountToShiftCompound.execute().trim();
> > +String dateToShift = dateToShiftCompound.execute().trim();
> >  LocalDateTime localDateTimeToShift = LocalDateTime.now(
> > systemDefaultZoneID);
> >  DateTimeFormatter formatter = null;
> >  if (!StringUtils.isEmpty(format)) {
> > @@ -161,8 +163,8 @@ public class TimeShift extends AbstractF
> >  Object[] values = parameters.toArray();
> >
> >  format = ((CompoundVariable) values[0]).execute().trim();
> > -dateToShift = ((CompoundVariable) values[1]).execute().trim();
> > -amountToShift = ((CompoundVariable) values[2]).execute().trim();
> > +dateToShiftCompound = (CompoundVariable) values[1];
> > +amountToShiftCompound = (CompoundVariable) values[2];
> >  variableName = ((CompoundVariable) values[3]).execute().trim();
> >
> >  // Create the cache
> >
> >
> >
>
>
> --
> Cordialement.
> Philippe Mouawad.
>


Re: [VOTE] Release JMeter 3.3 RC1 (with home.apache.org links)

2017-09-18 Thread Maxime Chassagneux
+1 for me too

2017-09-18 21:12 GMT+02:00 UBIK LOAD PACK Support 
:

> +1
>
> Thanks for the team's great work !
>
> On Mon, Sep 18, 2017 at 7:59 AM, Milamber  > wrote:
>
> > [Resend the vote thread with home.apache.org links since it's was
> repair.
> > See note below]
> >
> > Hello,
> >
> > The first release candidate for JMeter 3.3 (r1808647) has been prepared,
> > and your votes are solicited.
> >
> > This release brings new features and improvements, and also fixes bugs.
> >
> > Please, test this release candidate (with load tests and/or functional
> > tests) using Java 8 on Linux/Windows/Mac OS, especially on the changes.
> The
> > feedback are welcome.
> >
> > You can read the New and Noteworthy section with some screenshots to
> > illustrate improvements and full list of changes at:
> > http://home.apache.org/~milamber/jmeter-3.3RC1/docs/changes.html
> >
> > JMeter is a Java desktop application designed to load test functional
> > behavior and measure performance. The current version is targeted at Java
> > 8+.
> >
> > Download - Archives/hashes/sigs:
> >
> > https://dist.apache.org/repos/dist/dev/jmeter/v3.3_RC1/
> > (dist revision r21641)
> >
> > RAT report:
> >
> > http://home.apache.org/~milamber/jmeter-3.3RC1/dist/rat-repo
> > rt-jmeter-3.3RC1.txt
> >
> > MD5 hashes of archives for this vote:
> >
> > 16d2239aa3a8f496ac18e53b941d5350 *apache-jmeter-3.3.tgz
> > c5b5a950daeb6831ead9b6102707614b *apache-jmeter-3.3.zip
> > 68db1a0e0a0ce7f30a1e7e2d8ba02013 *apache-jmeter-3.3_src.tgz
> > e079303d76632d232d2059121e4d327a *apache-jmeter-3.3_src.zip
> >
> > Site Docs are here:
> > http://home.apache.org/~milamber/jmeter-3.3RC1/docs/
> >
> > Maven staging repository is accessible here:
> > https://repository.apache.org/content/repositories/orgapache
> > jmeter-1018/org/apache/jmeter/
> >
> > Tag:
> > https://svn.apache.org/repos/asf/jmeter/tags/v3_3_RC1/
> >
> > Keys are here:
> > https://www.apache.org/dist/jmeter/KEYS
> >
> > N.B.
> > To download the dependencies: "ant download_jars"
> >
> > To create the jars and test JMeter: "ant package test".
> >
> > JMeter 3.3 requires Java 8 or later to run.
> >
> > Some known issues and incompatible changes are listed on changes page.
> > http://home.apache.org/~milamber/jmeter-3.3RC1/docs/changes.
> > html#Known%20problems%20and%20workarounds
> >
> >
> > All feedback and vote are welcome.
> >
> > [  ] +1  I support this release
> > [  ] +0  I am OK with this release
> > [  ] -0   OK, but
> > [  ] -1   I do not support this release (please indicate why)
> >
> > The vote will remain open for at least 72 hours.
> >
> > The PMC members please indicate the mention "(binding)" with your vote.
> >
> >
> > Note: If the vote passes, the intention is to release the archive files
> > and rename the RC tag as the release tag.
> >
> > Thanks in advance!
> >
> > Milamber
> >
> >
> > Note: The unavailability of home.a.o has been fixed. But the server is
> > under maintenance, so revert to www.milamberspace.net if you need to
> > visit next JMeter website or RAT report.
> > https://issues.apache.org/jira/browse/INFRA-15101
> > http://status.apache.org/#maintenance
> >
> >
> >
> >
> >
> >
>
>
> --
>
> Regards
> Ubik Load Pack  Team
> Follow us on Twitter 
>
>
> Cordialement
> L'équipe Ubik Load Pack 
> Suivez-nous sur Twitter 
>
>
> --
>
> Regards
> Ubik Load Pack  Team
> Follow us on Twitter 
>
>
> Cordialement
> L'équipe Ubik Load Pack 
> Suivez-nous sur Twitter 
>


Re: Having a globalVariables shared accross threads

2017-10-24 Thread Maxime Chassagneux
Hi Philippe,

Nice idea, look good for me.

+1.



2017-10-24 9:36 GMT+02:00 Philippe Mouawad :

> Hello,
> There is frequently the need in Load Testing for sharing something accross
> threads which might have been initialized in a setup Thread Group or by
> some Thread.
>
> Currently JMeter has 2 ways to do it:
>
>- Properties but they are limited to String
>- Through Beanshell (which is deprecated) through bsh.shared
>
>
> A recent illustration of this (but I frequently in my work need it) is the
> Coverage Tests created for JMS, TCP and FTP.
> To do it I had to use Beanshell.
>
> So I propose to create such concept:
>
>- JMeterContext would be enhanced with getSharedVariables()
>- A new equivalent of JMeterVariables would be created. The Map would be
>ConcurrentHashMap
>- It would be initialized/cleared in StandardJMeterEngine#run or
>JMeterContextService.startTest();
>
> Thoughts ?
> --
> Regards.
> Philippe Mouawad.
> Ubik-Ingénierie
>


Re: Workbench : Let's drop it ?

2017-11-04 Thread Maxime Chassagneux
Hi,

I never use it, except for recording script, so +1 for me.

Regards

2017-11-04 13:07 GMT+01:00 Philippe Mouawad :

> Hello,
> Workbench element is confusing for beginners who don't understand
> clearly its use.
>
> Thinking more about it, I don't see today why we should still keep it.
>
> The only advantage of this element is Non Test Elements which would
> be made available from Test Plan directly.
> When running a test those element would not impact test plan.
>
> The only issue is backward compatibility, should we try to move elements in
>
> workbench under test plan or just mention a backward incompatibility.
>
> Users would manually move there elements to Test Plan.
>
> Regards
>


Re: Release a 4.0 ?

2017-11-20 Thread Maxime Chassagneux
Hi,

I just want to merge this PR tomorow :
https://github.com/apache/jmeter/pull/321

No problem for 4.0 for me.

Regards

--
Max

2017-11-20 22:06 GMT+01:00 Philippe Mouawad :

> Hello,
> We now have a version that contains:
> - 49 enhancements
> - 13 bug fixes
> - 6 PR
>
> Version looks mature to me currently and brings interesting new features
> and a nice new look.
>
> What do you think of releasing ?
>
> There are remaining PRs that could be merged but could introduce more delay
> :
>
>- https://github.com/apache/jmeter/pull/320 => Migration to last HC4
>APIs but it would need important tesint
>- https://github.com/apache/jmeter/pull/313 => I asked a question about
>it. I think we should adapt it to add a Metadata property instead of
> Comment
>
>
> Regards
> Philippe M.
>


Re: Release a 4.0 ?

2017-11-23 Thread Maxime Chassagneux
Hi,

First test of Darcula theme on windows for me, I find the rendering of
texteara ugly ( too black & white ! )  I'm the only one with this
effect ? :

https://www.dropbox.com/s/8h08xu0l3oj2ujt/%231.png?dl=0

https://www.dropbox.com/s/grlasbkbxuscliv/%232.png?dl=0







2017-11-21 21:50 GMT+01:00 Antonio Gomes Rodrigues :

> Work fine in my Linux
>
> Antonio
>
> 2017-11-21 20:28 GMT+01:00 Milamber :
>
> >
> >
> > On 21/11/2017 12:36, Philippe Mouawad wrote:
> >
> >> Hello,
> >> Thanks Antonio for your tests, I indeed was using laf name instead of
> >> class
> >> name.
> >> It is working now in my tests, but Milamber, Antonio or any subscriber,
> >> your tests are welcome.
> >>
> >
> > That's works for default LAF after remove theses lines into this file
> > ~/.java/.userPrefs/org/apache/jmeter/gui/action/prefs.xml
> >
> > (removed)
> > 
> > 
> >
> >
> > Thanks
> >
> > Jenkins build is in progress, a new nightly build should be available in
> >> few minutes.
> >> Regards
> >>
> >> On Tue, Nov 21, 2017 at 10:17 AM, Philippe Mouawad <
> >> philippe.moua...@gmail.com> wrote:
> >>
> >> Hi Antonio,
> >>> I fixed this bug on sunday.
> >>> Are you using last revision ?
> >>>
> >>> Thanks
> >>>
> >>> On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues <
> >>> ra0...@gmail.com> wrote:
> >>>
> >>> Hi Philippe,
> 
>  About Darcula, in Windows 10 (I will test it in Linux later but I
> think
>  it's the same) we have in the first launch
> 
>  2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand: Installing
>  Darcula LAF
>  2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using look
>  and
>  feel: Darcula []
>  2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
>  2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to:
> Darcula
>  java.lang.ClassNotFoundException: Darcula
>  at java.net.URLClassLoader.findClass(Unknown Source) ~[?:1.8.0_144]
>  at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
>  at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
>  at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
>  at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
>  at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
>  ~[?:1.8.0_144]
>  at javax.swing.UIManager.setLookAndFeel(Unknown Source)
> ~[?:1.8.0_144]
>  at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
>  [ApacheJMeter_core.jar:r1815865]
>  at org.apache.jmeter.JMeter.start(JMeter.java:520)
>  [ApacheJMeter_core.jar:r1815865]
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  ~[?:1.8.0_144]
>  at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>  ~[?:1.8.0_144]
>  at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>  ~[?:1.8.0_144]
>  at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.8.0_144]
>  at org.apache.jmeter.NewDriver.main(NewDriver.java:248)
>  [ApacheJMeter.jar:r1815865]
> 
> 
>  In the second launch, all is ok
> 
>  017-11-21 10:11:37,394 INFO o.a.j.g.a.LookAndFeelCommand: Installing
>  Darcula LAF
>  2017-11-21 10:11:37,409 INFO o.a.j.g.a.LookAndFeelCommand: Using look
>  and
>  feel: com.bulenkov.darcula.DarculaLaf [Darcula]
>  2017-11-21 10:11:37,409 INFO o.a.j.JMeter: Setting LAF to:
>  com.bulenkov.darcula.DarculaLaf
>  2017-11-21 10:11:37,455 INFO o.a.j.JMeter: Loaded icon properties from
>  org/apache/jmeter/images/icon.properties
> 
>  Antonio
> 
> 
>  2017-11-21 9:52 GMT+01:00 Philippe Mouawad <
> philippe.moua...@gmail.com
>  >:
> 
>  Hi Milamber,
> > One note below regarding LAF.
> >
> > Thanks
> >
> > On Tue, Nov 21, 2017 at 9:50 AM, Milamber 
> wrote:
> >
> >
> >> On 20/11/2017 21:06, Philippe Mouawad wrote:
> >>
> >> Hello,
> >>> We now have a version that contains:
> >>> - 49 enhancements
> >>> - 13 bug fixes
> >>> - 6 PR
> >>>
> >>> Version looks mature to me currently and brings interesting new
> >>>
> >> features
> 
> > and a nice new look.
> >>>
> >>> +1 for nice new look. (perhaps Dracula can be the default
> look&feel)
> >>
> >> It is already.
> > If it's not then it would be an issue, I intentionally changed the
> > preference name for the laf so that all users have a chance to see
> it.
> > Can you double check and confirm please ?
> >
> >
> >> What do you think of releasing ?
> >>>
> >>> Yes before end of the year that's will a good idea.
> >>
> >>
> >> There are remaining PRs that could be merged but could introduce
> more
> >>> delay
> >>> :
> >>>
> >>>  - https://github.com/apache/jmeter/pull/320 => Migration to
> >>> last
> >>>
> >> HC4
> >
> >>  APIs but it would need importan

Re: Release a 4.0 ?

2017-11-23 Thread Maxime Chassagneux
Hi,

I understand it, but for me it's a 'no go",  mostly if this theme is the
default one for 4.0.
But may be I'm the only one who find it strange.

Of course, if I can fix it , I will do.


2017-11-23 11:40 GMT+01:00 Philippe Mouawad :

> Hello Maxime,
> It's because RSyntaxtTextarea is not aware of the Darcula LAF.
> If you can contribute a fix,go ahead.
>
> Thanks
>
> On Thu, Nov 23, 2017 at 11:38 AM, Maxime Chassagneux <
> mchassagn...@apache.org> wrote:
>
> > Hi,
> >
> > First test of Darcula theme on windows for me, I find the rendering of
> > texteara ugly ( too black & white ! )  I'm the only one with this
> > effect ? :
> >
> > https://www.dropbox.com/s/8h08xu0l3oj2ujt/%231.png?dl=0
> >
> > https://www.dropbox.com/s/grlasbkbxuscliv/%232.png?dl=0
> >
> >
> >
> >
> >
> >
> >
> > 2017-11-21 21:50 GMT+01:00 Antonio Gomes Rodrigues :
> >
> > > Work fine in my Linux
> > >
> > > Antonio
> > >
> > > 2017-11-21 20:28 GMT+01:00 Milamber :
> > >
> > > >
> > > >
> > > > On 21/11/2017 12:36, Philippe Mouawad wrote:
> > > >
> > > >> Hello,
> > > >> Thanks Antonio for your tests, I indeed was using laf name instead
> of
> > > >> class
> > > >> name.
> > > >> It is working now in my tests, but Milamber, Antonio or any
> > subscriber,
> > > >> your tests are welcome.
> > > >>
> > > >
> > > > That's works for default LAF after remove theses lines into this file
> > > > ~/.java/.userPrefs/org/apache/jmeter/gui/action/prefs.xml
> > > >
> > > > (removed)
> > > > 
> > > > 
> > > >
> > > >
> > > > Thanks
> > > >
> > > > Jenkins build is in progress, a new nightly build should be available
> > in
> > > >> few minutes.
> > > >> Regards
> > > >>
> > > >> On Tue, Nov 21, 2017 at 10:17 AM, Philippe Mouawad <
> > > >> philippe.moua...@gmail.com> wrote:
> > > >>
> > > >> Hi Antonio,
> > > >>> I fixed this bug on sunday.
> > > >>> Are you using last revision ?
> > > >>>
> > > >>> Thanks
> > > >>>
> > > >>> On Tue, Nov 21, 2017 at 10:14 AM, Antonio Gomes Rodrigues <
> > > >>> ra0...@gmail.com> wrote:
> > > >>>
> > > >>> Hi Philippe,
> > > >>>>
> > > >>>> About Darcula, in Windows 10 (I will test it in Linux later but I
> > > think
> > > >>>> it's the same) we have in the first launch
> > > >>>>
> > > >>>> 2017-11-21 10:09:26,333 INFO o.a.j.g.a.LookAndFeelCommand:
> > Installing
> > > >>>> Darcula LAF
> > > >>>> 2017-11-21 10:09:26,363 INFO o.a.j.g.a.LookAndFeelCommand: Using
> > look
> > > >>>> and
> > > >>>> feel: Darcula []
> > > >>>> 2017-11-21 10:09:26,363 INFO o.a.j.JMeter: Setting LAF to: Darcula
> > > >>>> 2017-11-21 10:09:26,363 WARN o.a.j.JMeter: Could not set LAF to:
> > > Darcula
> > > >>>> java.lang.ClassNotFoundException: Darcula
> > > >>>> at java.net.URLClassLoader.findClass(Unknown Source)
> ~[?:1.8.0_144]
> > > >>>> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
> > > >>>> at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.8.0_144]
> > > >>>> at java.lang.Class.forName0(Native Method) ~[?:1.8.0_144]
> > > >>>> at java.lang.Class.forName(Unknown Source) ~[?:1.8.0_144]
> > > >>>> at javax.swing.SwingUtilities.loadSystemClass(Unknown Source)
> > > >>>> ~[?:1.8.0_144]
> > > >>>> at javax.swing.UIManager.setLookAndFeel(Unknown Source)
> > > ~[?:1.8.0_144]
> > > >>>> at org.apache.jmeter.JMeter.startGui(JMeter.java:359)
> > > >>>> [ApacheJMeter_core.jar:r1815865]
> > > >>>> at org.apache.jmeter.JMeter.start(JMeter.java:520)
> > > >>>> [ApacheJMeter_core.jar:r1815865]
> > > >>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > > >>>> ~[?:1.8.0_144]
> > > >

Re: Release a 4.0 ?

2017-11-23 Thread Maxime Chassagneux
Hi,

I don't want to be the only person who block just for a question of look.
It's just my feeling.
I find the theme inconsistency because of the white textearea in the middle
of all this black but taste and colours are not always the same

I also found not clear all fields are editable or not, but before it was
the same so...

=> https://www.dropbox.com/s/3b40bk2afmgxdw1/5.png?dl=0
=> https://www.dropbox.com/s/ukd9k8gljzv28cj/7.png?dl=0

Btw in a screen resolution of 1280x1024, the icon menu bar doesn't fit

=> https://www.dropbox.com/s/0zr8yqwn6yg6v60/3.png?dl=0

As long as people have the choice, in fact it's not really a problem.

Regards
Max


2017-11-23 12:52 GMT+01:00 Philippe Mouawad :

> Hi Andrei,
>
> AFAIU, this is pre-4.0 behaviour.
> Having seen the result on many platforms I don't share your opinion:
>
>- Windows LAF are just horrible, I had multiple times to use Windows for
>a long time, and I was just ashamed of JMeter
>- On Mac System LAF is nice, but still I find Darcula much more
>beautiful
>- On Linux, I don't know
>- Cross Platform makes it look very 90s
>
> Anyway, current status is that people don't like our GUI, I am fed up or
> reading tweets complaining about it and I think as Emilian Bold has
> mentionned it that this is a problem, the first thing people see in JMeter
> is not its backend features but the GUI. And unfortunately many stop here.
>
> I triggered a poll on our twitter, and it seems feedback on new LAF is
> rather positive:
>
>- https://twitter.com/ApacheJMeter/status/925358010825957377
>
> 79% find it better, 12% not better and only 10% don't like it.
>
> Besides, regarding HIDPI, Darcula LAF seems to provide solutions even for
> Swing. I have not investigated it deeper but Constantin Bulenkov intends to
> backport Intellij HiDPI fixes in it.
>
> Still if people are nostalgic or don't like the new theme,  they can easily
> switch.
>
> Regards
>
> Philippe
>
> https://twitter.com/ApacheJMeter/status/925358010825957377https://
> twitter.com/ApacheJMeter/status/925358010825957377
>
> On Thu, Nov 23, 2017 at 12:35 PM, Andrey Pokhilko  wrote:
>
> > My opinion is that default should be "System", as the safest decision is
> > to use system LAF.
> >
> > Andrey Pokhilko
> >
> > 23.11.2017 14:08, Philippe Mouawad пишет:
> > > Hi Maxime,
> > > It didn't look that ugly to me and the overall look was much better but
> > if
> > > it looks weird to you, it will be the same for others, then NO GO until
> > we
> > > fix it.
> > >
> > > Regards
> > >
> > > On Thu, Nov 23, 2017 at 12:05 PM, Maxime Chassagneux <
> > > mchassagn...@apache.org> wrote:
> > >
> > >> Hi,
> > >>
> > >> I understand it, but for me it's a 'no go",  mostly if this theme is
> the
> > >> default one for 4.0.
> > >> But may be I'm the only one who find it strange.
> > >>
> > >> Of course, if I can fix it , I will do.
> > >>
> > >>
> > >> 2017-11-23 11:40 GMT+01:00 Philippe Mouawad <
> philippe.moua...@gmail.com
> > >:
> > >>
> > >>> Hello Maxime,
> > >>> It's because RSyntaxtTextarea is not aware of the Darcula LAF.
> > >>> If you can contribute a fix,go ahead.
> > >>>
> > >>> Thanks
> > >>>
> > >>> On Thu, Nov 23, 2017 at 11:38 AM, Maxime Chassagneux <
> > >>> mchassagn...@apache.org> wrote:
> > >>>
> > >>>> Hi,
> > >>>>
> > >>>> First test of Darcula theme on windows for me, I find the rendering
> of
> > >>>> texteara ugly ( too black & white ! )  I'm the only one with
> this
> > >>>> effect ? :
> > >>>>
> > >>>> https://www.dropbox.com/s/8h08xu0l3oj2ujt/%231.png?dl=0
> > >>>>
> > >>>> https://www.dropbox.com/s/grlasbkbxuscliv/%232.png?dl=0
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>>
> > >>>> 2017-11-21 21:50 GMT+01:00 Antonio Gomes Rodrigues <
> ra0...@gmail.com
> > >:
> > >>>>
> > >>>>> Work fine in my Linux
> > >>>>>
> > >>>>> Antonio
> > >>>>>
> > >>>>> 2017-11-21 20

Re: Release a 4.0 ?

2017-11-23 Thread Maxime Chassagneux
Philippe,

Can you test my change color for the RSyntaxTheme ?
As I said before, taste and colours are not always the same, but I find it
more 'homogeneous'

--
Max

2017-11-23 15:08 GMT+01:00 Philippe Mouawad :

> Hello Maxime,
> Thanks for your feedback and tests.
>
> I have committed few minutes ago the integration of a Theme related to
> Darcula.
>
> I am not very good at styling or colors so the theme file needs to be
> adjusted a bit more.
> But at least it should be less shocking.
>
> To adapt the style, the file is :
> src/core/org/apache/jmeter/gui/util/theme/darcula_theme.xml
>
> Anybody willing to improve it is very welcome to commit directly if he can
> or propose a PR. I'll happily merge it.
>
>
> Regards
> Philippe
>
>
> On Thu, Nov 23, 2017 at 1:35 PM, Maxime Chassagneux <
> mchassagn...@apache.org
> > wrote:
>
> > Hi,
> >
> > I don't want to be the only person who block just for a question of look.
> > It's just my feeling.
> > I find the theme inconsistency because of the white textearea in the
> middle
> > of all this black but taste and colours are not always the same
> >
> > I also found not clear all fields are editable or not, but before it was
> > the same so...
> >
> > => https://www.dropbox.com/s/3b40bk2afmgxdw1/5.png?dl=0
> > => https://www.dropbox.com/s/ukd9k8gljzv28cj/7.png?dl=0
> >
> > Btw in a screen resolution of 1280x1024, the icon menu bar doesn't fit
> >
> > => https://www.dropbox.com/s/0zr8yqwn6yg6v60/3.png?dl=0
> >
> > As long as people have the choice, in fact it's not really a problem.
> >
> > Regards
> > Max
> >
> >
> > 2017-11-23 12:52 GMT+01:00 Philippe Mouawad  >:
> >
> > > Hi Andrei,
> > >
> > > AFAIU, this is pre-4.0 behaviour.
> > > Having seen the result on many platforms I don't share your opinion:
> > >
> > >- Windows LAF are just horrible, I had multiple times to use Windows
> > for
> > >a long time, and I was just ashamed of JMeter
> > >- On Mac System LAF is nice, but still I find Darcula much more
> > >beautiful
> > >- On Linux, I don't know
> > >- Cross Platform makes it look very 90s
> > >
> > > Anyway, current status is that people don't like our GUI, I am fed up
> or
> > > reading tweets complaining about it and I think as Emilian Bold has
> > > mentionned it that this is a problem, the first thing people see in
> > JMeter
> > > is not its backend features but the GUI. And unfortunately many stop
> > here.
> > >
> > > I triggered a poll on our twitter, and it seems feedback on new LAF is
> > > rather positive:
> > >
> > >- https://twitter.com/ApacheJMeter/status/925358010825957377
> > >
> > > 79% find it better, 12% not better and only 10% don't like it.
> > >
> > > Besides, regarding HIDPI, Darcula LAF seems to provide solutions even
> for
> > > Swing. I have not investigated it deeper but Constantin Bulenkov
> intends
> > to
> > > backport Intellij HiDPI fixes in it.
> > >
> > > Still if people are nostalgic or don't like the new theme,  they can
> > easily
> > > switch.
> > >
> > > Regards
> > >
> > > Philippe
> > >
> > > https://twitter.com/ApacheJMeter/status/925358010825957377https://
> > > twitter.com/ApacheJMeter/status/925358010825957377
> > >
> > > On Thu, Nov 23, 2017 at 12:35 PM, Andrey Pokhilko  wrote:
> > >
> > > > My opinion is that default should be "System", as the safest decision
> > is
> > > > to use system LAF.
> > > >
> > > > Andrey Pokhilko
> > > >
> > > > 23.11.2017 14:08, Philippe Mouawad пишет:
> > > > > Hi Maxime,
> > > > > It didn't look that ugly to me and the overall look was much better
> > but
> > > > if
> > > > > it looks weird to you, it will be the same for others, then NO GO
> > until
> > > > we
> > > > > fix it.
> > > > >
> > > > > Regards
> > > > >
> > > > > On Thu, Nov 23, 2017 at 12:05 PM, Maxime Chassagneux <
> > > > > mchassagn...@apache.org> wrote:
> > > > >
> > > > >> Hi,
> > > > >>
> > > > >> I understand it, but for me it's a &#

Re: Release a 4.0 ?

2017-11-28 Thread Maxime Chassagneux
Hi,

+1 for eclipse theme.





2017-11-28 22:21 GMT+01:00 Philippe Mouawad :

> Hello,
> Any thoughts on the proposed themes for JSyntaxTextArea ?
>
> My preference goes to my proposal (not because it's mine :-) ) as it is
> supposed to follow Darcula LAF colours except for 1 remaining difference.
>
>
> Regards
>
> On Thu, Nov 23, 2017 at 6:24 PM, Philippe Mouawad <
> philippe.moua...@gmail.com> wrote:
>
> > Thanks Maxime for your proposal.
> > I had on my side worked on trying to port using Eclipse Darcula Theme.
> >
> > I have attached  3 proposals on https://bz.apache.org/
> > bugzilla/show_bug.cgi?id=61697:
> >
> >- Yours
> >- Dark theme based on Notepad++'s Obsidian theme which is similar
> >- My proposal based on what I found  in
> http://www.eclipsecolorthemes.org/?view=theme&id=14105
> >(there are still some differences)
> ><http://www.eclipsecolorthemes.org/?view=theme&id=14105>
> >
> > @All, can you make a choice ?
> >
> > Thanks
> >
> > Regards
> >
> >
> >
> > On Thu, Nov 23, 2017 at 6:07 PM, Maxime Chassagneux <
> > mchassagn...@apache.org> wrote:
> >
> >> Philippe,
> >>
> >> Can you test my change color for the RSyntaxTheme ?
> >> As I said before, taste and colours are not always the same, but I find
> it
> >> more 'homogeneous'
> >>
> >> --
> >> Max
> >>
> >> 2017-11-23 15:08 GMT+01:00 Philippe Mouawad <
> >> p.moua...@ubik-ingenierie.com>:
> >>
> >> > Hello Maxime,
> >> > Thanks for your feedback and tests.
> >> >
> >> > I have committed few minutes ago the integration of a Theme related to
> >> > Darcula.
> >> >
> >> > I am not very good at styling or colors so the theme file needs to be
> >> > adjusted a bit more.
> >> > But at least it should be less shocking.
> >> >
> >> > To adapt the style, the file is :
> >> > src/core/org/apache/jmeter/gui/util/theme/darcula_theme.xml
> >> >
> >> > Anybody willing to improve it is very welcome to commit directly if he
> >> can
> >> > or propose a PR. I'll happily merge it.
> >> >
> >> >
> >> > Regards
> >> > Philippe
> >> >
> >> >
> >> > On Thu, Nov 23, 2017 at 1:35 PM, Maxime Chassagneux <
> >> > mchassagn...@apache.org
> >> > > wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > I don't want to be the only person who block just for a question of
> >> look.
> >> > > It's just my feeling.
> >> > > I find the theme inconsistency because of the white textearea in the
> >> > middle
> >> > > of all this black but taste and colours are not always the same
> >> > >
> >> > > I also found not clear all fields are editable or not, but before it
> >> was
> >> > > the same so...
> >> > >
> >> > > => https://www.dropbox.com/s/3b40bk2afmgxdw1/5.png?dl=0
> >> > > => https://www.dropbox.com/s/ukd9k8gljzv28cj/7.png?dl=0
> >> > >
> >> > > Btw in a screen resolution of 1280x1024, the icon menu bar doesn't
> fit
> >> > >
> >> > > => https://www.dropbox.com/s/0zr8yqwn6yg6v60/3.png?dl=0
> >> > >
> >> > > As long as people have the choice, in fact it's not really a
> problem.
> >> > >
> >> > > Regards
> >> > > Max
> >> > >
> >> > >
> >> > > 2017-11-23 12:52 GMT+01:00 Philippe Mouawad <
> >> philippe.moua...@gmail.com
> >> > >:
> >> > >
> >> > > > Hi Andrei,
> >> > > >
> >> > > > AFAIU, this is pre-4.0 behaviour.
> >> > > > Having seen the result on many platforms I don't share your
> opinion:
> >> > > >
> >> > > >- Windows LAF are just horrible, I had multiple times to use
> >> Windows
> >> > > for
> >> > > >a long time, and I was just ashamed of JMeter
> >> > > >- On Mac System LAF is nice, but still I find Darcula much more
> >> > > >beautiful
> >> > > >- On Linux, I don't know
> >> > > >- Cros

Re: Controversial topic: Remove internationalization

2018-01-05 Thread Maxime Chassagneux
Hi all,

I'm agree for default language to English but not to remove all i18n system.

--
Max


2018-01-05 16:22 GMT+01:00 sebb :

> On 5 January 2018 at 13:51, Felix Schumacher
>  wrote:
> > Am 04.01.2018 um 17:31 schrieb Philippe Mouawad:
> >>
> >> Hello,
> >>
> >> Currently we provide ability to translate JMeter GUI in many languages.
> >> In our tests we only ensure French translations are available because we
> >> have french team members.
> >>
> >> For other languages, we are in best effort and most probably the UI
> looks
> >> non professional for many users as there will be a mix of english and
> non
> >> english labels.
> >>
> >> I am aware that it's a controversial topic and many people probably rely
> >> on
> >> translated GUI BUT:
> >>
> >> - I dislike the fact that GUI looks non professional
> >> - Why don't we have more translation contributions if they are used
> ?
> >> - It's a certain piece of work to maintain and create those
> >> translations
> >>
> >> So unless there is a magical way to fully translate all labels and
> >> maintain
> >> them efficiently, I am  in favor of:
> >>
> >> - Having english forced in setup instead of relying on default
> locale.
> >> It seems this happened accidentally in 3.3 and nobody complained
> about
> >> it.
> >> - In a second step, and unless there is a big move to help on
> >> translation, I propose to drop all languages, even french one as
> it's
> >> an
> >> additional work and we have other and a lot of things to do
> >>
> >>
> >> Thoughts :-) ?
> >
> >
> > I am not against the default language 'en', as it is the one used in the
> > manual and therefore the best match.
>
> Agreed.
>
> > But I am against the removal of the option to switch languages, as there
> > were contributions in this area, which indicates, that this feature is
> > useful to some.
>
> Agreed.
>
> Also if a local user wants to fix the display for their language, they
> can do so just by updating/providing the appropriate property files.
> This ability would disappear if language support is dropped.
>
> A missing/incorrect translation does not prevent JMeter working, and
> if it bothers a user sufficiently hopefully they will provide a patch.
>
> I agree with Graham that the way forward is to make it really easy to
> provide translation updates.
>
> > Felix
> >
> >
>


Re: [VOTE] Release JMeter 4.0 RC6

2018-02-02 Thread Maxime Chassagneux
Hi all,

[+1] I support this release

I use it in production without problem.

Best regard


2018-02-02 16:30 GMT+01:00 Milamber :

> Hello,
>
> The fourth release candidate for JMeter 4.0 (r1822967) has been prepared,
> and your votes are solicited.
>
> This release brings a new default theme (Darcula), support for Java 9, 74
> enhancements (new features and improvements), and 26 bug fixes.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8 or 9 on Linux/Windows/Mac OS, especially on the
> changes. Feedback is very welcome within the next 72 hours.
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> http://home.apache.org/~milamber/jmeter-4.0RC6/docs/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8 / 9.
>
> Download - Archives/hashes/sigs:
>
> https://dist.apache.org/repos/dist/dev/jmeter/v4.0_RC6/
> (dist revision r24640)
>
> RAT report:
>
> http://home.apache.org/~milamber/jmeter-4.0RC6/dist/rat-
> report-jmeter-4.0RC6.txt
>
> MD5 hashes of archives for this vote:
>
> a497d140f1956ba65cf15930b0638333 *apache-jmeter-4.0.tgz
> 8b7015e303b3aac83d1a050cb3782860 *apache-jmeter-4.0.zip
> b3d9cce11b04be574a47b4108a3d2bc6 *apache-jmeter-4.0_src.tgz
> 04dbd79c242192cdcde574e10c7c43cd *apache-jmeter-4.0_src.zip
>
>
> Site Docs are here:
> http://home.apache.org/~milamber/jmeter-4.0RC6/docs/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapache
> jmeter-1027/org/apache/jmeter/
>
> Tag:
> https://svn.apache.org/repos/asf/jmeter/tags/v4_0_RC6/
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To download the dependencies: "ant download_jars"
>
> To create the jars and test JMeter: "ant package test".
>
> JMeter 4.0 requires Java 8 or later to run.
>
> Some known issues and incompatible changes are listed on changes page.
> http://home.apache.org/~milamber/jmeter-4.0RC6/docs/changes.
> html#Known%20problems%20and%20workarounds
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0   OK, but
> [  ] -1   I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> *Note:* the RC1, RC2 and RC3 were not submit for vote due an issue in
> release process when the maven artefacts are upload to nexus. For this RC6,
> the automatic maven upload inside build.xml was replaced by a
> semi-automatic upload with the maven-gpg-plugin.
>
> *Note2:* the RC5 were not submit for vote due an little commit by Philippe
> :-) during the release process.
>
>
>
>
>


Re: [VOTE] Release JMeter 4.0 RC7

2018-02-07 Thread Maxime Chassagneux
Hi all,

 +1  I support this release

Thanks for your work Milamber.


2018-02-07 8:53 GMT+01:00 Milamber :

> Hello,
>
> The seventh release candidate for JMeter 4.0 (r1823414) has been prepared,
> and your votes are solicited.
>
> This release brings a new default theme (Darcula), support for Java 9, 74
> enhancements (new features and improvements), and 26 bug fixes.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8 or 9 on Linux/Windows/Mac OS, especially on the
> changes. Feedback is very welcome within the next 72 hours.
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> http://home.apache.org/~milamber/jmeter-4.0RC7/docs/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8 / 9.
>
> Download - Archives/hashes/sigs:
>
> https://dist.apache.org/repos/dist/dev/jmeter/v4.0_RC7/
> (dist revision r24781)
>
> RAT report:
>
> http://home.apache.org/~milamber/jmeter-4.0RC7/dist/rat-
> report-jmeter-4.0RC7.txt
>
> MD5 hashes of archives for this vote:
>
> bfd202f5eb8a0ac322a145b97ef3fded *apache-jmeter-4.0.tgz
> 3a84491f10fb7b147101cf3926c4a855 *apache-jmeter-4.0.zip
> 7b3ed61896d704f3307d800616272393 *apache-jmeter-4.0_src.tgz
> 2f8d4260f125925eacce1069b295f53c *apache-jmeter-4.0_src.zip
>
> Site Docs are here:
> http://home.apache.org/~milamber/jmeter-4.0RC7/docs/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapache
> jmeter-1028/org/apache/jmeter/
>
> Tag:
> https://svn.apache.org/repos/asf/jmeter/tags/v4_0_RC7/
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To download the dependencies: "ant download_jars"
>
> To create the jars and test JMeter: "ant package test".
>
> JMeter 4.0 requires Java 8 or later to run.
>
> Some known issues and incompatible changes are listed on changes page.
> http://home.apache.org/~milamber/jmeter-4.0RC7/docs/changes.
> html#Known%20problems%20and%20workarounds
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0   OK, but
> [  ] -1   I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> *Note:* the RC1, RC2 and RC3 were not submit for vote due an issue in
> release process when the maven artefacts are upload to nexus. For this RC7,
> the automatic maven upload inside build.xml was replaced by a
> semi-automatic upload with the maven-gpg-plugin.
>
> *Note2:* the RC5 were not submit for vote due an little commit by Philippe
> :-) during the release process.
>
>
>
>
>
>


Re: TestAction: Change its name to make it more meaningful

2018-04-01 Thread Maxime Chassagneux
+1 too

2018-04-01 16:20 GMT+02:00 Antonio Gomes Rodrigues :

> +1
>
> Le dim. 1 avr. 2018 15:50, Andrey Pokhilko  a écrit :
>
> > "Flow Control Action"?
> >
> > Andrey Pokhilko
> >
> > 01.04.2018 16:49, Jmeter Tea пишет:
> > > Most samplers ends with Sampler and none with Action.
> > > And this Sampler *controls* the execution of the test.
> > > I know it's not a controller, but I suggest a name as "Control Sampler"
> > or
> > > " "Execution Control Sampler"
> > >
> > > On Sat, Mar 31, 2018 at 10:29 AM, Andrey Pokhilko  wrote:
> > >
> > >> Hi,
> > >>
> > >> "Test" sounds redundant to me. Everything we do in JMeter is a test.
> So
> > >> maybe just "Logical Action"?
> > >>
> > >> --
> > >>
> > >> Andrey Pokhilko
> > >>
> > >> 30.03.2018 18:15, UBIK LOAD PACK Support пишет:
> > >>> Hello,
> > >>>
> > >>> TestAction in JMeter is a very useful element but its name is
> > misleading
> > >> or
> > >>> not clear at all.
> > >>>
> > >>> Currently it allows:
> > >>>
> > >>>- Pausing
> > >>>- Stopping Test
> > >>>- Stopping Test immediately
> > >>>- Switching to next thread loop iteration
> > >>>- We'll soon propose a patch to add:
> > >>>   - Switch to next iteration of current loop : : It will be
> > >> equivalent
> > >>>   of "continue" in the the first parent loop that contains it
> > >>>   - Break current loop : It will break the first parent loop that
> > >>>   contains it, equivalent of "break" in algorithm
> > >>>
> > >>>
> > >>> When we provide training or discuss with JMeter beginners, TestAction
> > is
> > >>> usually understood as something to debug or "test", and nobody thinks
> > >> that
> > >>> is allows all this.
> > >>>
> > >>> Shouldn't it be renamed to something like:
> > >>>
> > >>>- Test Logic Action
> > >>>- Logical Action
> > >>>- Test Logical Action
> > >>>- Test Execution Modifier
> > >>>
> > >>>
> > >>>
> > >>> Regards
> > >>> UbikLoadPack Support Team
> > >>> 
> > >>>
> > >>
> >
> >
>


Re: [VOTE] Release JMeter 5.0 RC2

2018-09-18 Thread Maxime Chassagneux
+1

Le mar. 18 sept. 2018 à 11:33, Antonio Gomes Rodrigues  a
écrit :

> +1
>
> Antonio
>
> Le mar. 18 sept. 2018 à 10:19, Andrey Pokhilko  a écrit :
>
> > +1
> >
> > Andrey Pokhilko
> >
> > 14.09.2018 20:39, Milamber пишет:
> > > Hello,
> > >
> > > The second release candidate for JMeter 5.0 (r1840935) has been
> > > prepared, and your votes are solicited.
> > >
> > > This release brings a lot of new features and improvements, and also
> > > fixes bugs.
> > >
> > > Please, test this release candidate (with load tests and/or functional
> > > tests) using Java 8+ on Linux/Windows/Mac OS, especially on the
> > > changes. Feedback is very welcome within the next 72 hours.
> > >
> > > You can read the New and Noteworthy section with some screenshots to
> > > illustrate improvements and full list of changes at:
> > > http://home.apache.org/~milamber/jmeter-5.0RC2/docs/changes.html
> > >
> > > JMeter is a Java desktop application designed to load test functional
> > > behavior and measure performance. The current version targets Java 8+.
> > >
> > > Download - Archives/hashes/sigs:
> > >
> > > https://dist.apache.org/repos/dist/dev/jmeter/v5.0_RC2/
> > > (dist revision r29390)
> > >
> > > RAT report:
> > >
> > >
> >
> http://home.apache.org/~milamber/jmeter-5.0RC2/dist/rat-report-jmeter-5.0RC2.txt
> > >
> > >
> > > SHA512 hashes of archives for this vote: see footnote [1]
> > >
> > > Site Docs are here:
> > > http://home.apache.org/~milamber/jmeter-5.0RC2/docs/
> > >
> > > Maven staging repository is accessible here:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachejmeter-1033/org/apache/jmeter/
> > >
> > >
> > > Tag:
> > > https://svn.apache.org/repos/asf/jmeter/tags/v5_0_RC2/
> > >
> > > Keys are here:
> > > https://www.apache.org/dist/jmeter/KEYS
> > >
> > > N.B.
> > > To download the dependencies: "ant download_jars"
> > >
> > > To create the jars and test JMeter: "ant package test".
> > >
> > > JMeter 5.0 requires Java 8 or later to run.
> > >
> > > Some known issues and incompatible changes are listed on changes page.
> > >
> >
> http://home.apache.org/~milamber/jmeter-5.0RC2/docs/changes.html#Known%20problems%20and%20workarounds
> > >
> > >
> > >
> > > All feedback and vote are welcome.
> > >
> > > [  ] +1  I support this release
> > > [  ] +0  I am OK with this release
> > > [  ] -0   OK, but
> > > [  ] -1   I do not support this release (please indicate why)
> > >
> > > The vote will remain open for at least 72 hours.
> > >
> > > The PMC members please indicate the mention "(binding)" with your vote.
> > >
> > >
> > > Note: If the vote passes, the intention is to release the archive files
> > > and rename the RC tag as the release tag.
> > >
> > > Thanks in advance!
> > >
> > > Milamber
> > >
> > >
> > > ===
> > > [1] SHA512 hashes of archives for this vote:
> > >
> > >
> >
> a5a3bdd84ec8f78b67cee1b12bd9f2f578f3e9334ef2dc85cebd37878e0cf69ea3385a9c4f531dae094c0a4df93f262f43c2d9a9dfb10d38565d17eec3f907f1
> > > *apache-jmeter-5.0.tgz
> > >
> >
> 26d4cf65cce0ef008f8ef5955ef0d28e0bef310f2a75a36fe78fcc5f4ff9a6853071be0dd5140815834ca533e88224d766917b7ed2eb5168dc859b35eda5d2dc
> > > *apache-jmeter-5.0_src.tgz
> > >
> >
> c0b65879db8cbc7ed25de96b869ed3b703ceecad3acbf7fe726f101bd5d65f22443168eac4676c98d8cb55719de453efcb3bf699d02ca4ce4137ef0c594505fa
> > > *apache-jmeter-5.0.zip
> > >
> >
> f3a4400cea7431b6c1e59cf2498bf70c526eb06f5016dbdf5423d1530549b4555d3eedafe305c51c996adb0543c186d54c0c4979bbac9b8f5269630a1df1
> > > *apache-jmeter-5.0_src.zip
> > >
> > >
> > >
> > >
> >
> >
>


Re: [VOTE] Release JMeter 5.1 RC1

2019-02-13 Thread Maxime Chassagneux
[x] +1 I tested it in our production environnement today without any issue.

Le mer. 13 févr. 2019 à 22:43, Antonio Gomes Rodrigues  a
écrit :

> [x] +1  I support this release
>
> Le mer. 13 févr. 2019 à 22:20, Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> a écrit :
>
> > [x] +1  I support this release
> >
> > Many thanks!
> >
> > Vladimir
> >
>