Re: New Logger Panel

2012-01-23 Thread Philippe Mouawad
On Mon, Jan 23, 2012 at 5:18 PM, sebb seb...@gmail.com wrote:

 On 23 January 2012 15:34, Philippe Mouawad philippe.moua...@gmail.com
 wrote:
  Hello,
  My answers below.
 
  On Mon, Jan 23, 2012 at 3:51 PM, sebb seb...@gmail.com wrote:
 
  The Logger panel is useful, but I really don't like the way it is
  added to every single GUI pane. Is that really intentional?
 
 
  Can you explain what you mean ?.
  Today LoggerPanel is initialized at creation of MainFrame and not every
  time you open a Test Plan.

 Start JMeter (Gui mode)

 Select Test Plan, then Workbench.
 No logger panel showing in either.

 Check Options/Logviewer

 Now both Workbench and Test Plan have the logger panel.
 Same applies to any other Gui screens.

 Yes it's intentional, because when I test a plan  I want the console view
to be always here. It's like the console in Eclipse.
It is in MainFrame.
I still not see what you would like to have.


  Also at present, disabling the option does not appear to release the
  memory, because the same contents are redisplayed when re-enabled.
 
  Ok with this, I'll fix it this evening.
 
  It might make more sense to add it to the workbench GUI.
  This could then provide options to clear/refresh/reload/change size etc.
 
  These are already handled in current implementation ?

 No, they are not, at least not at run-time.


I am not sure to see what you are want, but if you are talking about menu
options to clear, refresh , change size, well I imagined the same behaviour
as Eclipse console, with some icons to clear.



 
 
  --
  Cordialement.
  Philippe Mouawad.




-- 
Cordialement.
Philippe Mouawad.


Re: New Logger Panel

2012-01-23 Thread sebb
On 23 January 2012 17:52, Philippe Mouawad philippe.moua...@gmail.com wrote:
 On Mon, Jan 23, 2012 at 5:18 PM, sebb seb...@gmail.com wrote:

 On 23 January 2012 15:34, Philippe Mouawad philippe.moua...@gmail.com
 wrote:
  Hello,
  My answers below.
 
  On Mon, Jan 23, 2012 at 3:51 PM, sebb seb...@gmail.com wrote:
 
  The Logger panel is useful, but I really don't like the way it is
  added to every single GUI pane. Is that really intentional?
 
 
  Can you explain what you mean ?.
  Today LoggerPanel is initialized at creation of MainFrame and not every
  time you open a Test Plan.

 Start JMeter (Gui mode)

 Select Test Plan, then Workbench.
 No logger panel showing in either.

 Check Options/Logviewer

 Now both Workbench and Test Plan have the logger panel.
 Same applies to any other Gui screens.

 Yes it's intentional, because when I test a plan  I want the console view
 to be always here. It's like the console in Eclipse.
 It is in MainFrame.
 I still not see what you would like to have.

I think it looks wrong for every GUI to have a console panel at the bottom.
Some GUIs are already very full, and adding the console view means the
rest of the Gui will need to be scrolled.

Either have a single panel, for example on the Workbench Gui - or even
a new Gui - or have a floating panel that can be visible independently
of the existing Guis.


  Also at present, disabling the option does not appear to release the
  memory, because the same contents are redisplayed when re-enabled.
 
  Ok with this, I'll fix it this evening.
 
  It might make more sense to add it to the workbench GUI.
  This could then provide options to clear/refresh/reload/change size etc.
 
  These are already handled in current implementation ?

 No, they are not, at least not at run-time.


 I am not sure to see what you are want, but if you are talking about menu
 options to clear, refresh , change size, well I imagined the same behaviour
 as Eclipse console, with some icons to clear.



 
 
  --
  Cordialement.
  Philippe Mouawad.




 --
 Cordialement.
 Philippe Mouawad.


Re: New Logger Panel

2012-01-23 Thread sebb
On 23 January 2012 19:56, Philippe Mouawad philippe.moua...@gmail.com wrote:
 On Mon, Jan 23, 2012 at 8:14 PM, sebb seb...@gmail.com wrote:

 On 23 January 2012 17:52, Philippe Mouawad philippe.moua...@gmail.com
 wrote:
  On Mon, Jan 23, 2012 at 5:18 PM, sebb seb...@gmail.com wrote:
 
  On 23 January 2012 15:34, Philippe Mouawad philippe.moua...@gmail.com
  wrote:
   Hello,
   My answers below.
  
   On Mon, Jan 23, 2012 at 3:51 PM, sebb seb...@gmail.com wrote:
  
   The Logger panel is useful, but I really don't like the way it is
   added to every single GUI pane. Is that really intentional?
  
  
   Can you explain what you mean ?.
   Today LoggerPanel is initialized at creation of MainFrame and not
 every
   time you open a Test Plan.
 
  Start JMeter (Gui mode)
 
  Select Test Plan, then Workbench.
  No logger panel showing in either.
 
  Check Options/Logviewer
 
  Now both Workbench and Test Plan have the logger panel.
  Same applies to any other Gui screens.
 
  Yes it's intentional, because when I test a plan  I want the console
 view
  to be always here. It's like the console in Eclipse.
  It is in MainFrame.
  I still not see what you would like to have.

 I think it looks wrong for every GUI to have a console panel at the bottom.
 Some GUIs are already very full, and adding the console view means the
 rest of the Gui will need to be scrolled.

 I don't have the same opinion, when you write a script, you usually have a
 TreeView result and you click on failed sampler then look at response and
 then look in the logs if there is an error.

In that case, having the console only on the Listener would be sufficient.

 As it is shown in Milamber screenshot.
 Regarding the place taken, you always have the option to click on divider
 at left to minimize window.

Yes, but changing the size affects *all* gui screens, so if you close
the console on one screen it won't be visible anywhere.

 Finally, LoggerPanel is independant of GUIs in term of implementation .

Not sure that's relevant here.


 Either have a single panel, for example on the Workbench Gui - or even
 a new Gui - or have a floating panel that can be visible independently
 of the existing Guis.

 I must still say I don't see what you would like, maybe a screenshot on
 the Bugzilla will help me understand.

I meant a floating panel like the Help viewer.



   Also at present, disabling the option does not appear to release the
   memory, because the same contents are redisplayed when re-enabled.
  
   Ok with this, I'll fix it this evening.
  
   It might make more sense to add it to the workbench GUI.
   This could then provide options to clear/refresh/reload/change size
 etc.
  
   These are already handled in current implementation ?
 
  No, they are not, at least not at run-time.
 
 
  I am not sure to see what you are want, but if you are talking about menu
  options to clear, refresh , change size, well I imagined the same
 behaviour
  as Eclipse console, with some icons to clear.
 
 
 
  
  
   --
   Cordialement.
   Philippe Mouawad.
 
 
 
 
  --
  Cordialement.
  Philippe Mouawad.




 --
 Cordialement.
 Philippe Mouawad.