[GitHub] incubator-joshua pull request #70: validate the original implementation of S...

[cocoxu]

GitHub user cocoxu opened a pull request:

https://github.com/apache/incubator-joshua/pull/70

validate the original implementation of SARI



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cocoxu/incubator-joshua master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70


commit 307d5f2c57e0367a6deb500aec79490b36b9090e
Author: Wei Coco Xu 
Date:   2016-09-30T15:11:53Z

validate the original implementation of SARI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: roadmap

[Tommaso Teofili]

very nice Matt, all sounds good to me, thanks!

Also looking forward to be able to play with additional language packs.

Regards,
Tommaso

Il giorno ven 30 set 2016 alle ore 15:09 Matt Post  ha
scritto:

> Hi folks,
>
> Just a status update, since I / we are a bit behind: I'm in the process of
> putting together the first language pack, along with a script that will
> bundle it with the jar, a README describing its use and assembly, a CREDITS
> file describing the data used to build the model, and a BENCHMARK file
> listing the performance on test sets. All of these are being more-or-less
> automatically assembled and I think it's important to include in the
> language packs.
>
> Once I have the version of that put together, I'll post it for your review
> and testing. I hope to do this first thing next week. We can then move to
> do our first release. There are a number of small things we need to do
> (updating the CHANGELOG, site documentation, etc), but I think we're mostly
> ready.
>
> A colleague here is also putting together a large number of language packs
> for lots of different languages. I'll have a list soon.
>
> matt
>
>

roadmap

[Matt Post]

Hi folks,

Just a status update, since I / we are a bit behind: I'm in the process of 
putting together the first language pack, along with a script that will bundle 
it with the jar, a README describing its use and assembly, a CREDITS file 
describing the data used to build the model, and a BENCHMARK file listing the 
performance on test sets. All of these are being more-or-less automatically 
assembled and I think it's important to include in the language packs.

Once I have the version of that put together, I'll post it for your review and 
testing. I hope to do this first thing next week. We can then move to do our 
first release. There are a number of small things we need to do (updating the 
CHANGELOG, site documentation, etc), but I think we're mostly ready.

A colleague here is also putting together a large number of language packs for 
lots of different languages. I'll have a list soon.

matt

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535817#comment-15535817
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user tteofili commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81326566
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

Sure, creating a separate module for OSGi sounds good to me. Note however 
that the annotation dependency is at compile time, that shouldn't be needed at 
runtime,


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua pull request #69: JOSHUA-290 - provide Joshua as a bundle

[tteofili]

Github user tteofili commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81326566
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

Sure, creating a separate module for OSGi sounds good to me. Note however 
that the annotation dependency is at compile time, that shouldn't be needed at 
runtime,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JOSHUA-290) Provide Joshua artifact as a bundle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535807#comment-15535807
 ] 

ASF GitHub Bot commented on JOSHUA-290:
---

Github user KellenSunderland commented on a diff in the pull request:

https://github.com/apache/incubator-joshua/pull/69#discussion_r81325749
  
--- Diff: src/main/java/org/apache/joshua/decoder/package-info.java ---
@@ -23,4 +23,7 @@
  * of any actual decoding algorithm. Rather, such code is in 
  * child packages of this package.
  */
-package org.apache.joshua.decoder;
\ No newline at end of file
+@Version("0.1.0")
+package org.apache.joshua.decoder;
+
+import org.osgi.annotation.versioning.Version;
--- End diff --

Would it be possible create a separate module for OSGI rather than adding 
it to Core?  If possible we'd like to keep as few dependancies as we can in the 
core library.  This will make it easier for organizations to pick up the Joshua 
core library and not add a bunch of dependancies that they might not make use 
of (but which then need to get deployed to their build and runtime 
environments).


> Provide Joshua artifact as a bundle
> ---
>
> Key: JOSHUA-290
> URL: https://issues.apache.org/jira/browse/JOSHUA-290
> Project: Joshua
>  Issue Type: Task
>  Components: build
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> I think it'd be good if we could make the Joshua artifact an OSGi _bundle_.
> This would have no impact on plain java applications but would give the 
> following benefits:
> - make it possible to install it in OSGi environments
> - optionally introduce semantic versioning (in addition with the baseline 
> plugin) that would help track e.g. if changes in APIs break backward 
> compatibility 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)