Re: [VOTE] Release Apache Log4Net 2.0.17
+1 Checked only formalities since I don't have an idea about .NET, but so far, looks good! On Sat, Mar 16, 2024, at 11:07, Volkan Yazıcı wrote: > +1 > > Checked sigs, hashes, `LICENSE` files, and release notes. > > > > On Fri, Mar 15, 2024 at 1:29 PM Davyd McColl wrote: >> >> Hi all, >> >> This is a vote to release the Apache Log4net 2.0.17. >> >> Website: >> https://logging.staged.apache.org/log4net/release/release-notes.html >> GitHub: https://github.com/apache/logging-log4net >> GitHub release (pre-release): >> https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 >> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net >> >> Please download, test, and cast your votes on this mailing list. >> >> [ ] +1, release the artifacts >> [ ] -1, don't release, because... >> >> This vote is open for 72 hours and will pass unless getting a >> net negative vote count. All votes are welcome and we encourage >> everyone to test the release, but only the Logging Services PMC >> votes are officially counted. >> >> >> Thanks to Jan for basically doing all of this (: >> >> -d >>
Re: [VOTE] Release Apache Log4Net 2.0.17
+1 Checked sigs, hashes, `LICENSE` files, and release notes. On Fri, Mar 15, 2024 at 1:29 PM Davyd McColl wrote: > > Hi all, > > This is a vote to release the Apache Log4net 2.0.17. > > Website: > https://logging.staged.apache.org/log4net/release/release-notes.html > GitHub: https://github.com/apache/logging-log4net > GitHub release (pre-release): > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 72 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. > > > Thanks to Jan for basically doing all of this (: > > -d >
Re: [VOTE] Release Apache Log4Net 2.0.17
Ah, ok, then I'll abstain from voting until we have a version I can build locally. TY for the heads up. Gary On Fri, Mar 15, 2024 at 2:24 PM Jan Friedrich wrote: > > Hello Gary, > > https://paste.apache.org/1ropz looks like you're building 2.0.16? > Building the current version is currently very difficult due to the many > target frameworks: > net20;net35;net40;net40-client;net45;netstandard1.3;netstandard2.0 > You need to have each SDK for them and especially the old ones are really > difficult to install. > > In the next version (3.0.0) we have stripped these down to two: > net462;netstandard2.0 > Then it will be easy to build them on your machine. > > Regards. > > Jan > > Friday, March 15, 2024, 5:47:22 PM, you wrote: > > > What about the failure? > > > Gary > > > On Fri, Mar 15, 2024, 11:35 AM Davyd McColl wrote: > > >> Hi > >> > >> Yes, everything should be done via npm scripts. So I should remove any > >> confusing .cmd files. > >> > >> As for the version, I should update that, but it's minor. That version > >> comes from package.json and will only show when running npm commands. But I > >> admit it's confusing. > >> > >> -d > >> > >> On 15 March 2024 16:28:47 "Gary D. Gregory" wrote: > >> > >>> We might need better build instructions... for me at least ;-) > >>> > >>> I take it the build.cmd file should be removed since it's not mentioned > >>> in https://github.com/apache/logging-log4net/blob/master/doc/BUILDING.md > >>> ? > >>> > >>> BUILDING.md contains a section called "TL;DR (!Windows):" which is too > >>> easy to confuse with "TL;DR (Windows):", just say "TL;DR (non-Windows):", > >>> there is no need to be clever here IMO. > >>> > >>> When I say "npm i" and then "npm run build", it starts with: > >>> > log4net@2.0.12 prebuild > run-s clean-build > log4net@2.0.12 clean-build > rimraf build > log4net@2.0.12 build > zarro @ > > >>> > >>> Why does it say log4net@2.0.12 when I am building 2.0.17? > >>> > >>> Then the build errors out with https://paste.apache.org/1ropz > >>> > >>> I, off course, don't know what I'm doing with .net... ;-) > >>> > >>> Gary > >>> > >>> On 2024/03/15 12:28:03 Davyd McColl wrote: > >>> > Hi all, > > This is a vote to release the Apache Log4net 2.0.17. > > Website: > https://logging.staged.apache.org/log4net/release/release-notes.html > GitHub: https://github.com/apache/logging-log4net > GitHub release (pre-release): > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 72 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. > > Thanks to Jan for basically doing all of this (: > > -d > > >>> >
Re: [VOTE] Release Apache Log4Net 2.0.17
Hello Gary, https://paste.apache.org/1ropz looks like you're building 2.0.16? Building the current version is currently very difficult due to the many target frameworks: net20;net35;net40;net40-client;net45;netstandard1.3;netstandard2.0 You need to have each SDK for them and especially the old ones are really difficult to install. In the next version (3.0.0) we have stripped these down to two: net462;netstandard2.0 Then it will be easy to build them on your machine. Regards. Jan Friday, March 15, 2024, 5:47:22 PM, you wrote: > What about the failure? > Gary > On Fri, Mar 15, 2024, 11:35 AM Davyd McColl wrote: >> Hi >> >> Yes, everything should be done via npm scripts. So I should remove any >> confusing .cmd files. >> >> As for the version, I should update that, but it's minor. That version >> comes from package.json and will only show when running npm commands. But I >> admit it's confusing. >> >> -d >> >> On 15 March 2024 16:28:47 "Gary D. Gregory" wrote: >> >>> We might need better build instructions... for me at least ;-) >>> >>> I take it the build.cmd file should be removed since it's not mentioned >>> in https://github.com/apache/logging-log4net/blob/master/doc/BUILDING.md >>> ? >>> >>> BUILDING.md contains a section called "TL;DR (!Windows):" which is too >>> easy to confuse with "TL;DR (Windows):", just say "TL;DR (non-Windows):", >>> there is no need to be clever here IMO. >>> >>> When I say "npm i" and then "npm run build", it starts with: >>> log4net@2.0.12 prebuild run-s clean-build log4net@2.0.12 clean-build rimraf build log4net@2.0.12 build zarro @ >>> >>> Why does it say log4net@2.0.12 when I am building 2.0.17? >>> >>> Then the build errors out with https://paste.apache.org/1ropz >>> >>> I, off course, don't know what I'm doing with .net... ;-) >>> >>> Gary >>> >>> On 2024/03/15 12:28:03 Davyd McColl wrote: >>> Hi all, This is a vote to release the Apache Log4net 2.0.17. Website: https://logging.staged.apache.org/log4net/release/release-notes.html GitHub: https://github.com/apache/logging-log4net GitHub release (pre-release): https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net Please download, test, and cast your votes on this mailing list. [ ] +1, release the artifacts [ ] -1, don't release, because... This vote is open for 72 hours and will pass unless getting a net negative vote count. All votes are welcome and we encourage everyone to test the release, but only the Logging Services PMC votes are officially counted. Thanks to Jan for basically doing all of this (: -d >>>
Re: [VOTE] Release Apache Log4Net 2.0.17
What about the failure? Gary On Fri, Mar 15, 2024, 11:35 AM Davyd McColl wrote: > Hi > > Yes, everything should be done via npm scripts. So I should remove any > confusing .cmd files. > > As for the version, I should update that, but it's minor. That version > comes from package.json and will only show when running npm commands. But I > admit it's confusing. > > -d > > On 15 March 2024 16:28:47 "Gary D. Gregory" wrote: > >> We might need better build instructions... for me at least ;-) >> >> I take it the build.cmd file should be removed since it's not mentioned >> in https://github.com/apache/logging-log4net/blob/master/doc/BUILDING.md >> ? >> >> BUILDING.md contains a section called "TL;DR (!Windows):" which is too >> easy to confuse with "TL;DR (Windows):", just say "TL;DR (non-Windows):", >> there is no need to be clever here IMO. >> >> When I say "npm i" and then "npm run build", it starts with: >> >>> log4net@2.0.12 prebuild >>> run-s clean-build >>> log4net@2.0.12 clean-build >>> rimraf build >>> log4net@2.0.12 build >>> zarro @ >>> >> >> Why does it say log4net@2.0.12 when I am building 2.0.17? >> >> Then the build errors out with https://paste.apache.org/1ropz >> >> I, off course, don't know what I'm doing with .net... ;-) >> >> Gary >> >> On 2024/03/15 12:28:03 Davyd McColl wrote: >> >>> Hi all, >>> >>> This is a vote to release the Apache Log4net 2.0.17. >>> >>> Website: >>> https://logging.staged.apache.org/log4net/release/release-notes.html >>> GitHub: https://github.com/apache/logging-log4net >>> GitHub release (pre-release): >>> https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 >>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net >>> >>> Please download, test, and cast your votes on this mailing list. >>> >>> [ ] +1, release the artifacts >>> [ ] -1, don't release, because... >>> >>> This vote is open for 72 hours and will pass unless getting a >>> net negative vote count. All votes are welcome and we encourage >>> everyone to test the release, but only the Logging Services PMC >>> votes are officially counted. >>> >>> Thanks to Jan for basically doing all of this (: >>> >>> -d >>> >>
Re: [VOTE] Release Apache Log4Net 2.0.17
Hi Yes, everything should be done via npm scripts. So I should remove any confusing .cmd files. As for the version, I should update that, but it's minor. That version comes from package.json and will only show when running npm commands. But I admit it's confusing. -d On 15 March 2024 16:28:47 "Gary D. Gregory" wrote: We might need better build instructions... for me at least ;-) I take it the build.cmd file should be removed since it's not mentioned in https://github.com/apache/logging-log4net/blob/master/doc/BUILDING.md ? BUILDING.md contains a section called "TL;DR (!Windows):" which is too easy to confuse with "TL;DR (Windows):", just say "TL;DR (non-Windows):", there is no need to be clever here IMO. When I say "npm i" and then "npm run build", it starts with: log4net@2.0.12 prebuild run-s clean-build log4net@2.0.12 clean-build rimraf build log4net@2.0.12 build zarro @ Why does it say log4net@2.0.12 when I am building 2.0.17? Then the build errors out with https://paste.apache.org/1ropz I, off course, don't know what I'm doing with .net... ;-) Gary On 2024/03/15 12:28:03 Davyd McColl wrote: Hi all, This is a vote to release the Apache Log4net 2.0.17. Website: https://logging.staged.apache.org/log4net/release/release-notes.html GitHub: https://github.com/apache/logging-log4net GitHub release (pre-release): https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net Please download, test, and cast your votes on this mailing list. [ ] +1, release the artifacts [ ] -1, don't release, because... This vote is open for 72 hours and will pass unless getting a net negative vote count. All votes are welcome and we encourage everyone to test the release, but only the Logging Services PMC votes are officially counted. Thanks to Jan for basically doing all of this (: -d
Re: [VOTE] Release Apache Log4Net 2.0.17
We might need better build instructions... for me at least ;-) I take it the build.cmd file should be removed since it's not mentioned in https://github.com/apache/logging-log4net/blob/master/doc/BUILDING.md ? BUILDING.md contains a section called "TL;DR (!Windows):" which is too easy to confuse with "TL;DR (Windows):", just say "TL;DR (non-Windows):", there is no need to be clever here IMO. When I say "npm i" and then "npm run build", it starts with: > log4net@2.0.12 prebuild > run-s clean-build > log4net@2.0.12 clean-build > rimraf build > log4net@2.0.12 build > zarro @ Why does it say log4net@2.0.12 when I am building 2.0.17? Then the build errors out with https://paste.apache.org/1ropz I, off course, don't know what I'm doing with .net... ;-) Gary On 2024/03/15 12:28:03 Davyd McColl wrote: > Hi all, > > This is a vote to release the Apache Log4net 2.0.17. > > Website: > https://logging.staged.apache.org/log4net/release/release-notes.html > GitHub: https://github.com/apache/logging-log4net > GitHub release (pre-release): > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 72 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. > > > Thanks to Jan for basically doing all of this (: > > -d > >
Re: [VOTE] Release Apache Log4Net 2.0.17
I think this is perfectly valid, he only shared the GitHub view to the `rel/2.0.17-rc1` tag – which is immutable due to `rel/`-prefix. He could have maybe explicitly stated it, but not a biggie, IMHO. If you don't like the GitHub view, you can clone the repository locally and checkout the tag yourself. On Fri, Mar 15, 2024 at 3:05 PM Gary D. Gregory wrote: > > Hi and thank you for RM'ing this release. > > > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 > > This is no good IMO, you should provide an _apache_ link. > > Gary > > On 2024/03/15 12:28:03 Davyd McColl wrote: > > Hi all, > > > > This is a vote to release the Apache Log4net 2.0.17. > > > > Website: > > https://logging.staged.apache.org/log4net/release/release-notes.html > > GitHub: https://github.com/apache/logging-log4net > > GitHub release (pre-release): > > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 > > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net > > > > Please download, test, and cast your votes on this mailing list. > > > > [ ] +1, release the artifacts > > [ ] -1, don't release, because... > > > > This vote is open for 72 hours and will pass unless getting a > > net negative vote count. All votes are welcome and we encourage > > everyone to test the release, but only the Logging Services PMC > > votes are officially counted. > > > > > > Thanks to Jan for basically doing all of this (: > > > > -d > > > >
Re: [VOTE] Release Apache Log4Net 2.0.17
Hi and thank you for RM'ing this release. > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 This is no good IMO, you should provide an _apache_ link. Gary On 2024/03/15 12:28:03 Davyd McColl wrote: > Hi all, > > This is a vote to release the Apache Log4net 2.0.17. > > Website: > https://logging.staged.apache.org/log4net/release/release-notes.html > GitHub: https://github.com/apache/logging-log4net > GitHub release (pre-release): > https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net > > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > This vote is open for 72 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. > > > Thanks to Jan for basically doing all of this (: > > -d > >
