Re: Bugfix release 9.11.1
I expect that the entry will be added in 9.12 except in the 9_11 branch where it should be in 9.11.1. I will synchronize the CHANGES.txt once I am done with the release. On Thu, Jun 20, 2024 at 4:49 PM Dawid Weiss wrote: > > Thank you. I've applied 13315 to main, branch_9x and branch_9_11. Can't > remember what changes.txt policy is - do we copy the entire section for > 9.11 once it's cut back to main/ 9x? > > Dawid > > On Thu, Jun 20, 2024 at 4:41 PM Ignacio Vera wrote: > >> Stefan sounds good. >> >> Sure Dawid. Thanks for moving it forward. >> >> Cheers, >> >> Ignacio >> >> On Thu, Jun 20, 2024 at 4:38 PM Dawid Weiss >> wrote: >> >>> >>> I would like to backport this change to unified highlighter to 9.11.1, >>> if there are no objections. >>> https://github.com/apache/lucene/pull/13315 >>> >>> >>> >>> On Thu, Jun 20, 2024 at 9:37 AM Ignacio Vera wrote: >>> I am now preparing for a bugfix release from branch branch_9_11. I am planning to build the RC next Monday. Please observe the normal rules for committing to this branch: * Before committing to the branch, reply to this thread and argue why the fix needs backporting and how long it will take. * All issues accepted for backporting should be marked with 9.11.1 in GitHub, and issues that should delay the release must be marked as Blocker * All patches that are intended for the branch should first be committed to the unstable branch, merged into the stable branch, and then into the current release branch. * Only issues with Milestone version 9.11.1 and priority "Blocker" will delay a release candidate build. There are already three fixes backported to branch 9.11: [1] https://github.com/apache/lucene/pull/13498 [2] https://github.com/apache/lucene/pull/13504 [3] https://github.com/apache/lucene/pull/13501 @Stefan you mention in another thread an issue with StringValueFacetCounts but I see there is no fix for it yet, what's the status there? Thanks, Ignacio >>>
Re: Bugfix release 9.11.1
Thank you. I've applied 13315 to main, branch_9x and branch_9_11. Can't remember what changes.txt policy is - do we copy the entire section for 9.11 once it's cut back to main/ 9x? Dawid On Thu, Jun 20, 2024 at 4:41 PM Ignacio Vera wrote: > Stefan sounds good. > > Sure Dawid. Thanks for moving it forward. > > Cheers, > > Ignacio > > On Thu, Jun 20, 2024 at 4:38 PM Dawid Weiss wrote: > >> >> I would like to backport this change to unified highlighter to 9.11.1, if >> there are no objections. >> https://github.com/apache/lucene/pull/13315 >> >> >> >> On Thu, Jun 20, 2024 at 9:37 AM Ignacio Vera wrote: >> >>> I am now preparing for a bugfix release from branch branch_9_11. I am >>> planning to build the RC next Monday. >>> >>> Please observe the normal rules for committing to this branch: >>> >>> * Before committing to the branch, reply to this thread and argue >>> why the fix needs backporting and how long it will take. >>> * All issues accepted for backporting should be marked with 9.11.1 >>> in GitHub, and issues that should delay the release must be marked as >>> Blocker >>> * All patches that are intended for the branch should first be committed >>> to the unstable branch, merged into the stable branch, and then into >>> the current release branch. >>> * Only issues with Milestone version 9.11.1 and priority "Blocker" will >>> delay >>> a release candidate build. >>> >>> There are already three fixes backported to branch 9.11: >>> >>> [1] https://github.com/apache/lucene/pull/13498 >>> [2] https://github.com/apache/lucene/pull/13504 >>> [3] https://github.com/apache/lucene/pull/13501 >>> >>> @Stefan you mention in another thread an issue with >>> StringValueFacetCounts but I see there is no fix for it yet, what's the >>> status there? >>> >>> Thanks, >>> >>> Ignacio >>> >>
Re: Bugfix release 9.11.1
Stefan sounds good. Sure Dawid. Thanks for moving it forward. Cheers, Ignacio On Thu, Jun 20, 2024 at 4:38 PM Dawid Weiss wrote: > > I would like to backport this change to unified highlighter to 9.11.1, if > there are no objections. > https://github.com/apache/lucene/pull/13315 > > > > On Thu, Jun 20, 2024 at 9:37 AM Ignacio Vera wrote: > >> I am now preparing for a bugfix release from branch branch_9_11. I am >> planning to build the RC next Monday. >> >> Please observe the normal rules for committing to this branch: >> >> * Before committing to the branch, reply to this thread and argue >> why the fix needs backporting and how long it will take. >> * All issues accepted for backporting should be marked with 9.11.1 >> in GitHub, and issues that should delay the release must be marked as >> Blocker >> * All patches that are intended for the branch should first be committed >> to the unstable branch, merged into the stable branch, and then into >> the current release branch. >> * Only issues with Milestone version 9.11.1 and priority "Blocker" will >> delay >> a release candidate build. >> >> There are already three fixes backported to branch 9.11: >> >> [1] https://github.com/apache/lucene/pull/13498 >> [2] https://github.com/apache/lucene/pull/13504 >> [3] https://github.com/apache/lucene/pull/13501 >> >> @Stefan you mention in another thread an issue with >> StringValueFacetCounts but I see there is no fix for it yet, what's the >> status there? >> >> Thanks, >> >> Ignacio >> >
Re: Bugfix release 9.11.1
I would like to backport this change to unified highlighter to 9.11.1, if there are no objections. https://github.com/apache/lucene/pull/13315 On Thu, Jun 20, 2024 at 9:37 AM Ignacio Vera wrote: > I am now preparing for a bugfix release from branch branch_9_11. I am > planning to build the RC next Monday. > > Please observe the normal rules for committing to this branch: > > * Before committing to the branch, reply to this thread and argue > why the fix needs backporting and how long it will take. > * All issues accepted for backporting should be marked with 9.11.1 > in GitHub, and issues that should delay the release must be marked as > Blocker > * All patches that are intended for the branch should first be committed > to the unstable branch, merged into the stable branch, and then into > the current release branch. > * Only issues with Milestone version 9.11.1 and priority "Blocker" will > delay > a release candidate build. > > There are already three fixes backported to branch 9.11: > > [1] https://github.com/apache/lucene/pull/13498 > [2] https://github.com/apache/lucene/pull/13504 > [3] https://github.com/apache/lucene/pull/13501 > > @Stefan you mention in another thread an issue with StringValueFacetCounts > but I see there is no fix for it yet, what's the status there? > > Thanks, > > Ignacio >
GH-13315: Fix IndexOutOfBoundsException thrown in DefaultPassageFormatter by unordered matches
Hello, I have made requested changes to the PR https://github.com/apache/lucene/pull/13315. Please tell me if I need to add something else to it! Thanks, -- Stephane Campinas signature.asc Description: PGP signature
Re: Bugfix release 9.11.1
Thank you Ignacio for handling the release! I've just updated the PR with the fix [1]. I can push it tomorrow. Stefan [1] https://github.com/apache/lucene/pull/13494 On Thu, 20 Jun 2024 at 08:36, Ignacio Vera wrote: > I am now preparing for a bugfix release from branch branch_9_11. I am > planning to build the RC next Monday. > > Please observe the normal rules for committing to this branch: > > * Before committing to the branch, reply to this thread and argue > why the fix needs backporting and how long it will take. > * All issues accepted for backporting should be marked with 9.11.1 > in GitHub, and issues that should delay the release must be marked as > Blocker > * All patches that are intended for the branch should first be committed > to the unstable branch, merged into the stable branch, and then into > the current release branch. > * Only issues with Milestone version 9.11.1 and priority "Blocker" will > delay > a release candidate build. > > There are already three fixes backported to branch 9.11: > > [1] https://github.com/apache/lucene/pull/13498 > [2] https://github.com/apache/lucene/pull/13504 > [3] https://github.com/apache/lucene/pull/13501 > > @Stefan you mention in another thread an issue with StringValueFacetCounts > but I see there is no fix for it yet, what's the status there? > > Thanks, > > Ignacio >
Bugfix release 9.11.1
I am now preparing for a bugfix release from branch branch_9_11. I am planning to build the RC next Monday. Please observe the normal rules for committing to this branch: * Before committing to the branch, reply to this thread and argue why the fix needs backporting and how long it will take. * All issues accepted for backporting should be marked with 9.11.1 in GitHub, and issues that should delay the release must be marked as Blocker * All patches that are intended for the branch should first be committed to the unstable branch, merged into the stable branch, and then into the current release branch. * Only issues with Milestone version 9.11.1 and priority "Blocker" will delay a release candidate build. There are already three fixes backported to branch 9.11: [1] https://github.com/apache/lucene/pull/13498 [2] https://github.com/apache/lucene/pull/13504 [3] https://github.com/apache/lucene/pull/13501 @Stefan you mention in another thread an issue with StringValueFacetCounts but I see there is no fix for it yet, what's the status there? Thanks, Ignacio