[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.
[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004557#comment-14004557 ] Shai Erera commented on LUCENE-5689: ReaderAndUpdates already clones all FIs and then updates the dvGen of the ones that are updated now. So cloning again is silly ... perhaps we can get rid of it some day, but I agree, let's remove the public first. And yes, if you modify the dvGen on an AtomicReader, you might hit weird exceptions like FNFE when the reader will try to lookup the field's dv-gen'd file. FieldInfo.setDocValuesGen should not be public. --- Key: LUCENE-5689 URL: https://issues.apache.org/jira/browse/LUCENE-5689 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-5689.patch its currently public and users can modify it. We made this class mostly immutable long ago: remember its returned by the atomicreader API! -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.
[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004614#comment-14004614 ] ASF subversion and git services commented on LUCENE-5689: - Commit 1596553 from [~rcmuir] in branch 'dev/trunk' [ https://svn.apache.org/r1596553 ] LUCENE-5689: FieldInfo.setDocValuesGen should not be public FieldInfo.setDocValuesGen should not be public. --- Key: LUCENE-5689 URL: https://issues.apache.org/jira/browse/LUCENE-5689 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-5689.patch its currently public and users can modify it. We made this class mostly immutable long ago: remember its returned by the atomicreader API! -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.
[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004617#comment-14004617 ] ASF subversion and git services commented on LUCENE-5689: - Commit 1596555 from [~rcmuir] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1596555 ] LUCENE-5689: FieldInfo.setDocValuesGen should not be public FieldInfo.setDocValuesGen should not be public. --- Key: LUCENE-5689 URL: https://issues.apache.org/jira/browse/LUCENE-5689 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-5689.patch its currently public and users can modify it. We made this class mostly immutable long ago: remember its returned by the atomicreader API! -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.
[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003556#comment-14003556 ] Shai Erera commented on LUCENE-5689: Looks good. So now FI.setDVGen is used only by ReaderAndUpdates, right? Perhaps it is possible to get rid of it entirely, by having RAU create a new FI instance, setting the new dvGen? FieldInfo.setDocValuesGen should not be public. --- Key: LUCENE-5689 URL: https://issues.apache.org/jira/browse/LUCENE-5689 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-5689.patch its currently public and users can modify it. We made this class mostly immutable long ago: remember its returned by the atomicreader API! -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5689) FieldInfo.setDocValuesGen should not be public.
[ https://issues.apache.org/jira/browse/LUCENE-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003580#comment-14003580 ] Robert Muir commented on LUCENE-5689: - It maybe, i wasnt sure about the implications of that. I think we should first remove the 'public', because I do not know what will happen if someone invokes this setter on e.g. AtomicReader, but I'm guessing its not good :) FieldInfo.setDocValuesGen should not be public. --- Key: LUCENE-5689 URL: https://issues.apache.org/jira/browse/LUCENE-5689 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir Attachments: LUCENE-5689.patch its currently public and users can modify it. We made this class mostly immutable long ago: remember its returned by the atomicreader API! -- This message was sent by Atlassian JIRA (v6.2#6252) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
