[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836204#comment-16836204
]
ASF subversion and git services commented on LUCENE-7840:
-
Commit 214f70cb44d5ef3ff6f689c9cbe98fc6f986552b in lucene-solr's branch
refs/heads/branch_8x from Atri Sharma
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=214f70c ]
LUCENE-7840: Avoid Building Scorer Supplier For Redundant SHOULD Clauses
For boolean queries, we should eliminate redundant SHOULD clauses during
query rewrite and not build the scorer supplier, as opposed to
eliminating them during weight construction
Signed-off-by: jimczi
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836178#comment-16836178
]
Atri Sharma commented on LUCENE-7840:
-
Thank you for committing it!
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836167#comment-16836167
]
ASF subversion and git services commented on LUCENE-7840:
-
Commit c988b04b1888d5091a9455d3ae34762eb0ca0cea in lucene-solr's branch
refs/heads/master from Atri Sharma
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=c988b04 ]
LUCENE-7840: Avoid Building Scorer Supplier For Redundant SHOULD Clauses
For boolean queries, we should eliminate redundant SHOULD clauses during
query rewrite and not build the scorer supplier, as opposed to
eliminating them during weight construction
Signed-off-by: jimczi
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835473#comment-16835473
]
Simon Willnauer commented on LUCENE-7840:
-
LGTM
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834823#comment-16834823
]
Atri Sharma commented on LUCENE-7840:
-
[~simonw] Changed to switch statement. I tend to use braces around branches to
increase readability, hoping that is fine.
[^LUCENE-7840.patch]
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834778#comment-16834778
]
Simon Willnauer commented on LUCENE-7840:
-
I think there are some style issues in this patch like here were _else_ shoud
be on the prev line:
{code:java}
+ }
+}
+else {
+ newQuery.add(clause);
+}
{code}
the other question is if we should use a switch instead of if / else? Otherwise
it's looking fine
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834756#comment-16834756
]
Jim Ferenczi commented on LUCENE-7840:
--
Thanks [~atris], it looks good to me too. I'll commit shortly
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834714#comment-16834714
]
Adrien Grand commented on LUCENE-7840:
--
+1
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834612#comment-16834612
]
Atri Sharma commented on LUCENE-7840:
-
[~jim.ferenczi] Attached an updated patch. Let me know if it looks fine.
An addition is to not return early from rewrite when there are no MUST clauses,
but to return early when there are no MUST clauses and SHOULD clauses need not
be rewritten.
[^LUCENE-7840.patch]
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch, LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834417#comment-16834417
]
Jim Ferenczi commented on LUCENE-7840:
--
Can you build the new query in a single pass ? You could check the condition to
add the SHOULD clauses before the loop with:
{code:java}
boolean keepShould = getMinimumNumberShouldMatch() > 0 ||
(clauseSets.get(Occur.MUST).size() + clauseSets.get(Occur.FILTER).size() == 0);
{code}
and then add the should clauses in the main loop if keepShould is true ?
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834104#comment-16834104
]
Atri Sharma commented on LUCENE-7840:
-
[~jim.ferenczi] Attached a patch, please take a look. Thanks
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
> Attachments: LUCENE-7840.patch
>
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833787#comment-16833787
]
Atri Sharma commented on LUCENE-7840:
-
+1, will raise a patch
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833727#comment-16833727
]
Jim Ferenczi commented on LUCENE-7840:
--
I think so yes, we don't need to build the scorer supplier for the SHOULD
clauses so it makes sense to move the logic there.
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833693#comment-16833693
]
Atri Sharma commented on LUCENE-7840:
-
[~jim.ferenczi]
Sure, would it make sense to refactor to move the code to rewriteNoScoring then?
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833621#comment-16833621
]
Jim Ferenczi commented on LUCENE-7840:
--
Note that the logic to remove SHOULD clauses is already implemented when we
build the Scorer:
https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java#L391
Moving the logic to rewriteNoScoring makes sense to me but this won't optimize
anything since the removal is already in place.
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7840) BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least 1 MUST/FILTER clause and 0==minShouldMatch
[
https://issues.apache.org/jira/browse/LUCENE-7840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833602#comment-16833602
]
Atri Sharma commented on LUCENE-7840:
-
I have a patch for this – will post it shortly
> BooleanQuery.rewriteNoScoring - optimize away any SHOULD clauses if at least
> 1 MUST/FILTER clause and 0==minShouldMatch
> ---
>
> Key: LUCENE-7840
> URL: https://issues.apache.org/jira/browse/LUCENE-7840
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Hoss Man
>Priority: Major
>
> I haven't thought this through completely, let alone write up a patch / test
> case, but IIUC...
> We should be able to optimize {{ BooleanQuery rewriteNoScoring() }} so that
> (after converting MUST clauses to FILTER clauses) we can check for the common
> case of {{0==getMinimumNumberShouldMatch()}} and throw away any SHOULD
> clauses as long as there is is at least one FILTER clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
