[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615482#comment-13615482
]
Erick Erickson commented on SOLR-4632:
--
bq: Great! I was starting to think something was wrong with my setup.
Nope, just something wrong with the tests I wrote. There are some special cases
that are only encountered through the test suite, and those paths were the ones
exercised by the unit tests. The path through those persisted the
transientCacheSize just fine. But the real-world path didn't.
There'll be a discussion on the dev list Real Soon Now ...
Again many thanks for pointing this out, we need as many eyes on this code as
possible.
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615432#comment-13615432
]
dfdeshom commented on SOLR-4632:
Great! I was starting to think something was wrong with my setup.
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614774#comment-13614774
]
Erick Erickson commented on SOLR-4632:
--
Oh my goodness lookit that. It fails. Thanks for the instructions!
BTW, you're in a heap o' trouble with that new core definition, it'll try to
use the same index as "collection1" with disastrous results I'd expect unless
you specify a distinct data dir.
OK, now that I can reproduce this I'll fix it as part of SOLR-4615, thanks
again!
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614589#comment-13614589
]
Erick Erickson commented on SOLR-4632:
--
OK, I'll give it a shot with those instructions.
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614552#comment-13614552
]
dfdeshom commented on SOLR-4632:
I created a solr.xml file that looks like this:
{code:xml}
{code}
I started solr: java -jar start.jar
I issued a command to create another core:
{code} curl
"http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&name=tmp5"{code}
I opened the modified solr.xml file. It contained the newly-created core, but
transientCacheSize was not present anymore. I don't think transientCacheSize
should be modifiable by the http api either, I just don't think it should
swallow it. Ideally, it should work as you said, but it's not for me.
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614549#comment-13614549
]
Erick Erickson commented on SOLR-4632:
--
Nope. Also, there's a test that's been in there from the beginning that
verifies that if the value for transientCacheSize is other than
Integer.MAX_VALUE, it's persisted. If it's not present, the default is
Integer.MAX_VALUE. Reading that value is a bit opaque, it's easy to overlook.
But in looking at the code, it was misleading at best. There's no way to change
the value of transientCacheSize outside of having it in the solr.xml file in
the tag, you can't dynamically change it. None of the create process
for a core changes the value in the tag. Nor should it IMO.
So I don't understand what you're doing to test this. How are you changing the
valur for transientCacheSize?
BTW, all that is entirely separate from not being able to specify loadOnStartup
and transient when creating cores, I've include that patch in what I'm working
on now.
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614303#comment-13614303
]
dfdeshom commented on SOLR-4632:
> Looking more closely, transientCacheSize is persisted when it's value is
> other than Integer.MAX_VALUE. So I don't think this is a problem after all.
I have been able to reproduce the bug today using the example I gave
previously: transientCacheSize is definitely not persisted regardless of its
value. I am using the trunk branch of lucene-solr here:
https://github.com/apache/lucene-solr/commits/trunk
Were you not able to reproduce this bug using the example I gave above?
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613349#comment-13613349
]
Erick Erickson commented on SOLR-4632:
--
Looking more closely, transientCacheSize is persisted when it's value is other
than Integer.MAX_VALUE. So I don't think this is a problem after all.
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613326#comment-13613326
]
Erick Erickson commented on SOLR-4632:
--
Hmmm, why did you remove the check in CoreContainer when persisting the
transientCacheSize around line 1,300 (warning, I've made some other changes so
the file lines may not match).
It seems incorrect to me to persist Integer.MAX_VALUE if nothing has ever been
specified, just let the default value happen next time the file is read rather
than leave the user wondering where the heck that came from.
You don't need to put up a new patch, I'll just change this in SOLR-4615 unless
you convince me that this check is really a bad idea
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Assignee: Erick Erickson
>Priority: Minor
> Fix For: 4.3
>
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4632) transientCacheSize is not retained when persisting solr.xml
[
https://issues.apache.org/jira/browse/SOLR-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611308#comment-13611308
]
dfdeshom commented on SOLR-4632:
patch attached for a fix. Fix also on github here:
https://github.com/dfdeshom/lucene-solr/commit/SOLR-4632
> transientCacheSize is not retained when persisting solr.xml
> ---
>
> Key: SOLR-4632
> URL: https://issues.apache.org/jira/browse/SOLR-4632
> Project: Solr
> Issue Type: Bug
> Components: multicore
>Affects Versions: 4.2
>Reporter: dfdeshom
>Priority: Minor
> Attachments: SOLR-4632.txt
>
>
> transientCacheSize is not persisted solr.xml when creating a new core. I was
> able to reproduce this using the following solr.xml file:
> {code:xml}
>
>
>adminPath="/admin/cores" zkClientTimeout="${zkClientTimeout:15000}"
> hostPort="8983" hostContext="solr">
>
>
>
> {code}
> I created a new core:
> {code} curl
> "http://localhost:8983/solr/admin/cores?action=create&instanceDir=collection1&transient=true&name=tmp5&loadOnStartup=false"{code}
> The resulting solr.xml file has the new core added, but is missing the
> transientCacheSize attribute.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
