[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203589#comment-15203589
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 6ebf61535e90d264755ba72eea9ce51ea89703ff in lucene-solr's branch
refs/heads/jira/SOLR-445 from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6ebf615 ]
SOLR-7339: Upgrade to Jetty 9.3.8.v20160314
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master, 6.0
>
> Attachments: SOLR-7339-jetty-9.3.8.patch,
> SOLR-7339-jetty-9.3.8.patch, SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197500#comment-15197500
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
Okay I see. In that case, can you set this as resolved so it is not a blocker
anymore?
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197528#comment-15197528
]
Mark Miller commented on SOLR-7339:
---
Let's see if anyone has a problem with that.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198788#comment-15198788
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 6ebf61535e90d264755ba72eea9ce51ea89703ff in lucene-solr's branch
refs/heads/master from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6ebf615 ]
SOLR-7339: Upgrade to Jetty 9.3.8.v20160314
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-jetty-9.3.8.patch,
> SOLR-7339-jetty-9.3.8.patch, SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201167#comment-15201167
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 6ebf61535e90d264755ba72eea9ce51ea89703ff in lucene-solr's branch
refs/heads/apiv2 from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6ebf615 ]
SOLR-7339: Upgrade to Jetty 9.3.8.v20160314
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master, 6.0
>
> Attachments: SOLR-7339-jetty-9.3.8.patch,
> SOLR-7339-jetty-9.3.8.patch, SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197246#comment-15197246
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
[~markrmil...@gmail.com] - are you going to revert this upgrade for 6.0?
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198790#comment-15198790
]
ASF subversion and git services commented on SOLR-7339:
---
Commit b648ce5afae48662e433f204ff501ac01e45cd9a in lucene-solr's branch
refs/heads/branch_6x from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b648ce5 ]
SOLR-7339: Upgrade to Jetty 9.3.8.v20160314
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-jetty-9.3.8.patch,
> SOLR-7339-jetty-9.3.8.patch, SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197428#comment-15197428
]
Mark Miller commented on SOLR-7339:
---
Was and then wasn't unless someone spoke up and had an issue with it. Have had
my head under a rock for a bit.
Super easy workaround if you are have a turkish locale - just set default
locale to english.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198791#comment-15198791
]
ASF subversion and git services commented on SOLR-7339:
---
Commit fec14c022c7d4fbca07611560aa54df4aecf991b in lucene-solr's branch
refs/heads/branch_6_0 from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fec14c0 ]
SOLR-7339: Upgrade to Jetty 9.3.8.v20160314
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-jetty-9.3.8.patch,
> SOLR-7339-jetty-9.3.8.patch, SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183951#comment-15183951
]
Steve Rowe commented on SOLR-7339:
--
FYI the Jetty commit addressing the Locale problem is here (pushed to master
and 9.3.8.RC0 branch):
https://github.com/eclipse/jetty.project/commit/145e4bee7139125408acc7388bf58531e96ae3d7
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183913#comment-15183913
]
Steve Rowe commented on SOLR-7339:
--
[~gr...@webtide.com], any updates about the 9.3.8 release? It's not final yet
AFAICT.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171695#comment-15171695
]
Greg Wilkins commented on SOLR-7339:
The locale bug has indeed been fixed already and will be in 9.3.8 (and RC0 of
this is staged now so the full release should be less than a week away).
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
>Priority: Blocker
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169942#comment-15169942
]
Mark Miller commented on SOLR-7339:
---
Looks like I may have to back this out again for the 6.0 release.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155812#comment-15155812
]
Mark Miller commented on SOLR-7339:
---
Just looked at the code on GitHub - looks like latest release does not have it.
We will need to hop on the next release.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155805#comment-15155805
]
Mark Miller commented on SOLR-7339:
---
Oh, good news. This is already fixed in master and perhaps in a release. I move
us up to the latest release.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155784#comment-15155784
]
Mark Miller commented on SOLR-7339:
---
[~gr...@webtide.com], [~joakime], looks like a default locale bug:
HttpParser
{code}
for (String charset : new String[]{"utf-8","iso-8859-1"})
{
CACHE.put(new
PreEncodedHttpField(HttpHeader.CONTENT_TYPE,type+";charset="+charset));
CACHE.put(new
PreEncodedHttpField(HttpHeader.CONTENT_TYPE,type+"; charset="+charset));
CACHE.put(new
PreEncodedHttpField(HttpHeader.CONTENT_TYPE,type+";charset="+charset.toUpperCase()));
CACHE.put(new
PreEncodedHttpField(HttpHeader.CONTENT_TYPE,type+";
charset="+charset.toUpperCase()));
}
{code}
toUpperCase should use an ENGLISH locale or I guess our project has determined
ROOT is better because ENGLISH could change over time. The turkish bug.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154285#comment-15154285
]
Mark Miller commented on SOLR-7339:
---
Hmm, well this first one I'm looking at does look like it may be a Locale issue
after all. If I hardcode ENGLISH locale it passes with my bad test seed.
And there is an error before the last one I posted that points towards this as
well.
{code}
java.lang.ExceptionInInitializerError
at
org.eclipse.jetty.server.HttpConnection.newHttpParser(HttpConnection.java:124)
at
org.eclipse.jetty.server.HttpConnection.(HttpConnection.java:102)
at
org.eclipse.jetty.server.HttpConnectionFactory.newConnection(HttpConnectionFactory.java:58)
at
org.eclipse.jetty.server.ServerConnector$ServerConnectorManager.newConnection(ServerConnector.java:510)
at
org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:411)
at
org.eclipse.jetty.io.ManagedSelector.access$1600(ManagedSelector.java:56)
at
org.eclipse.jetty.io.ManagedSelector$CreateEndPoint.run(ManagedSelector.java:587)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceAndRun(ExecuteProduceConsume.java:213)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.execute(ExecuteProduceConsume.java:101)
at org.eclipse.jetty.io.ManagedSelector.run(ManagedSelector.java:136)
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:654)
at
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:572)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: non ascii character
at org.eclipse.jetty.util.ArrayTrie.put(ArrayTrie.java:171)
at org.eclipse.jetty.util.AbstractTrie.put(AbstractTrie.java:45)
at org.eclipse.jetty.http.HttpParser.(HttpParser.java:204)
... 13 more
{code}
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154269#comment-15154269
]
Mark Miller commented on SOLR-7339:
---
I'm going to work on finding what random setting triggers this.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153343#comment-15153343
]
Mark Miller commented on SOLR-7339:
---
If it's not isolated test fails and a lot fail it's prob the above issue.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153322#comment-15153322
]
Steve Rowe commented on SOLR-7339:
--
I'm seeing an uptick in master test failures on my Jenkins, e.g. this run with
21 test failures; skimming they're mostly caused by connection resets:
[http://jenkins.sarowe.net/job/Lucene-Solr-tests-trunk/5743/].
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150759#comment-15150759
]
Joakim Erdfelt commented on SOLR-7339:
--
>From the gut:
Option 1)
You have multiple jetty-http.jars, and one of them is really old.
Unfortunately, your system picked the old one over the new one.
Option 2)
You had a fundamental jvm runtime issue preventing that class from being
initialized (memory, file descriptors, bad jars, etc..)
Do you have any other log entries that could indicate this sort of issue?
Option 3)
You have a version mismatch between jetty-server.jar and jetty-http.jar
Option 4)
You have jetty-http.jar in your WEB-INF/lib and a testcase that flips the
WebAppContext loaderPriority improperly
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150606#comment-15150606
]
Mark Miller commented on SOLR-7339:
---
Well, at least they are repeatable fails.
Not sure what it is yet, but fails seem to have the following that I don't see
in passes:
{noformat}
23813 DEBUG (qtp1185380035-63) [] o.e.j.i.ManagedSelector
java.lang.NoClassDefFoundError: Could not initialize class
org.eclipse.jetty.http.HttpParser
at
org.eclipse.jetty.server.HttpConnection.newHttpParser(HttpConnection.java:124)
at
org.eclipse.jetty.server.HttpConnection.(HttpConnection.java:102)
at
org.eclipse.jetty.server.HttpConnectionFactory.newConnection(HttpConnectionFactory.java:58)
at
org.eclipse.jetty.server.ServerConnector$ServerConnectorManager.newConnection(ServerConnector.java:510)
at
org.eclipse.jetty.io.ManagedSelector.createEndPoint(ManagedSelector.java:411)
at
org.eclipse.jetty.io.ManagedSelector.access$1600(ManagedSelector.java:56)
at
org.eclipse.jetty.io.ManagedSelector$CreateEndPoint.run(ManagedSelector.java:587)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceAndRun(ExecuteProduceConsume.java:213)
at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.execute(ExecuteProduceConsume.java:101)
at org.eclipse.jetty.io.ManagedSelector.run(ManagedSelector.java:136)
at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:654)
at
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:572)
at java.lang.Thread.run(Thread.java:745)
{noformat}
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150498#comment-15150498
]
Greg Wilkins commented on SOLR-7339:
Yell if there is anything you want us to look at!
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150465#comment-15150465
]
Mark Miller commented on SOLR-7339:
---
Darn, sometimes I'm still seeing connection reset problems. But much rarer.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149316#comment-15149316
]
Mark Miller commented on SOLR-7339:
---
Okay, let's see how this works out...
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149284#comment-15149284
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 0bba332549a11d5c381efc93a66087999b6de210 in lucene-solr's branch
refs/heads/master from markrmiller
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0bba332 ]
SOLR-7339: Jetty 9.3 upgrade.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149220#comment-15149220
]
Mark Miller commented on SOLR-7339:
---
I just tried this out again and had to file SOLR-8683. I think we can upgrade
now though.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Mark Miller
> Fix For: master
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096870#comment-15096870
]
Mark Miller commented on SOLR-7339:
---
SOLR-8453 is now committed, I'll check on the Locale issue soon. If that was
also somehow related and is no longer a problem, we can go ahead with the
update, otherwise we will have to dig in a bit I think.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088674#comment-15088674
]
Mark Miller commented on SOLR-7339:
---
I put up a patch in SOLR-8453. I still have to check and see if the tests that
consistently failed on at least 1 locales was also do to this or not.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088510#comment-15088510
]
Yonik Seeley commented on SOLR-7339:
Yeah, I think we only call sendError in a few places... we could just as easily
replace that with another call that consumes any remaining input as well. We
could make it conditional on a query parameter too... this does feel more like
a higher level decision (whether to consume all input or not).
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088390#comment-15088390
]
Greg Wilkins commented on SOLR-7339:
Mark,
A simple work around could be to install a filter on the server that does read
until EOF - ie the filter will ensure that all the content is consumed.
Something like psuedo code:
```java
doFilter(FilterChain chain, ServletRequest request, ServletResponse response)
{
try
{
chain.doFilter(request,response);
}
finally
{
consumeAll(request.getInputStream());
}
```
It may need to be more sophisticated than this is you sometimes use a Reader
and/or async IO, but the principal is the same - get the filter to do the
behaviour that was in jetty-9.2.From Jetty's point of view it is the
application that can decide to block and wait for this content, so that is OK.
Should I comment on 8453 also?
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087882#comment-15087882
]
Mark Miller commented on SOLR-7339:
---
Yonik mentioned to me that this is probably legal behavior, even if undesirable
as it prevents connection reuse for us in these cases. The problem is that
HttpClient hits this in a way that we can not really work around to get to the
right error and ?ignore? the connection reset?
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087814#comment-15087814
]
Mark Miller commented on SOLR-7339:
---
bq. The request that fails sends data using chunked encoding, but sends one
chunk of length 0x59, but does not send the terminal chunk. The logs show Jetty
reporting that the processing is complete but with unconsumed input, and
therefore closes the connection.
[~joakime], it appears that the terminal chunk is still coming. Jetty is no
longer waiting for it like it previously did. If we speed up how fast we send
the terminal chunk, we can get the test to pass. If we slow it down too much,
say even by turning on all debug logging, even speeding up how fast we send the
terminal chunk is not enough. We basically now have 10-12ms to get that
terminal chunk out, where previously Jetty would wait up to other connection
timeouts (30 seconds) to get that terminal chunk.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087761#comment-15087761
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 1723604 from sha...@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1723604 ]
SOLR-7339: Revert Jetty 9.3 upgrade
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087601#comment-15087601
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
Thanks a lot Mark for looking into this. I'll revert the jetty upgrade for now.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087555#comment-15087555
]
Mark Miller commented on SOLR-7339:
---
We should probably commit that patch - trunk fails are quite noisy now.
I think I've tracked down the other issue in SOLR-8453. I'm thinking it's a
Jetty bug. So I think two bugs are currently preventing us from upgrading.
I sent an email to the Jetty dev list to ask about the issue in SOLR-8453.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339-revert.patch, SOLR-7339.patch,
> SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069580#comment-15069580
]
Uwe Schindler commented on SOLR-7339:
-
bq. We should probably try and isolate what is causing it so we can file a bug,
but we would still need to wait for a good version.
...maybe suggest to Jetty people that they use forbidden-apis with
{{jdk-unsafe}} bundled signatures! :-)
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069551#comment-15069551
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
bq. I still think we probably have to roll this update back because it appears
to break Solr under certain default Locales. We should probably try and isolate
what is causing it so we can file a bug, but we would still need to wait for a
good version.
Makes sense. I'll revert.
bq. Interesting exception in a CollectionsAPIDistributedZkTest fail:
I don't think that is caused by the jetty upgrade because it happens on 5x and
5.4 branches too. I had opened SOLR-8380 to track it.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069122#comment-15069122
]
Mark Miller commented on SOLR-7339:
---
Interesting exception in a CollectionsAPIDistributedZkTest fail:
{noformat}
[junit4] 2> 232756 ERROR (qtp543233699-1130) [n:127.0.0.1:43044_kqam]
o.a.s.s.HttpSolrCall null:org.apache.solr.common.SolrException: Error trying to
proxy request for url: http://127.0.0.1:34586/kqam/awholynewcollection_0/select
[junit4] 2>at
org.apache.solr.servlet.HttpSolrCall.remoteQuery(HttpSolrCall.java:591)
[junit4] 2>at
org.apache.solr.servlet.HttpSolrCall.call(HttpSolrCall.java:441)
[junit4] 2>at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:226)
[junit4] 2>at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:184)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
[junit4] 2>at
org.apache.solr.client.solrj.embedded.JettySolrRunner$DebugFilter.doFilter(JettySolrRunner.java:111)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
[junit4] 2>at
org.eclipse.jetty.servlets.GzipFilter.doFilter(GzipFilter.java:45)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1668)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:581)
[junit4] 2>at
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:224)
[junit4] 2>at
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1158)
[junit4] 2>at
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:511)
[junit4] 2>at
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
[junit4] 2>at
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1090)
[junit4] 2>at
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
[junit4] 2>at
org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:437)
[junit4] 2>at
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:119)
[junit4] 2>at
org.eclipse.jetty.server.Server.handle(Server.java:517)
[junit4] 2>at
org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:308)
[junit4] 2>at
org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:242)
[junit4] 2>at
org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:261)
[junit4] 2>at
org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95)
[junit4] 2>at
org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:75)
[junit4] 2>at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceAndRun(ExecuteProduceConsume.java:213)
[junit4] 2>at
org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:147)
[junit4] 2>at
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:654)
[junit4] 2>at
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:572)
[junit4] 2>at java.lang.Thread.run(Thread.java:745)
[junit4] 2> Caused by: java.io.IOException: Response header too large
[junit4] 2>at
org.eclipse.jetty.http.HttpGenerator.generateResponse(HttpGenerator.java:404)
[junit4] 2>at
org.eclipse.jetty.server.HttpConnection$SendCallback.process(HttpConnection.java:678)
[junit4] 2>at
org.eclipse.jetty.util.IteratingCallback.processing(IteratingCallback.java:241)
[junit4] 2>at
org.eclipse.jetty.util.IteratingCallback.iterate(IteratingCallback.java:224)
[junit4] 2>at
org.eclipse.jetty.server.HttpConnection.send(HttpConnection.java:509)
[junit4] 2>at
org.eclipse.jetty.server.HttpChannel.sendResponse(HttpChannel.java:668)
[junit4] 2>at
org.eclipse.jetty.server.HttpChannel.write(HttpChannel.java:722)
[junit4] 2>at
org.eclipse.jetty.server.handler.gzip.GzipHttpOutputInterceptor.commit(GzipHttpOutputInterceptor.java:201)
[junit4] 2>at
org.eclipse.jetty.server.handler.gzip.GzipHttpOutputInterceptor.write(GzipHttpOutputInterceptor.java:100)
[junit4] 2>at
org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:177)
[junit4] 2>at
org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:163)
[junit4] 2>at
org.eclipse.jetty.server.HttpOutput.write(HttpOutput.java:413)
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069089#comment-15069089
]
Mark Miller commented on SOLR-7339:
---
It's not very often, but I seem to see the following pop up after the update
and don't remember it being an issue before (for a long time anyway):
[junit4] 2> 327513 ERROR
(TEST-BasicDistributedZk2Test.test-seed#[EAADE41C3F03EAEF])
[n:127.0.0.1:38892_i c:collection1 s:shard1 r:core_node2 x:collection1]
o.a.s.c.ChaosMonkey Could not get the port to start jetty again
[junit4] 2> java.net.BindException: Address already in use
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069011#comment-15069011
]
Mark Miller commented on SOLR-7339:
---
bq. My patch for SOLR-8453 seems to solve pretty much all the connection resets
I have been seeing except for the Locale issue.
So this still stands. I think I've solved the general issue with the patch in
SOLR-8453. I'm still banging around with it, but it's looking pretty good on my
machine.
I still think we probably have to roll this update back because it appears to
break Solr under certain default Locales. We should probably try and isolate
what is causing it so we can file a bug, but we would still need to wait for a
good version.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068087#comment-15068087
]
Mark Miller commented on SOLR-7339:
---
My patch for SOLR-8453 seems to solve pretty much all the connection resets I
have been seeing except for the Locale issue. SolrExampleBinaryTest,
TestManagedSchemaDynamicFieldResource and a bunch of others can fail with the
wrong Locale.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067107#comment-15067107
]
Mark Miller commented on SOLR-7339:
---
I filed SOLR-8453 to deal with this SolrExampleStreamingBinaryTest fail issue.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066933#comment-15066933
]
Mark Miller commented on SOLR-7339:
---
I don't know how to solve this for the general case. Especially for streaming,
with this behavior we really need make sure the exception gets set on the
response rather than cutting off the request while the client is still sending.
For this particular version issue with this container behavior, you need
something like the following instead of throwing an exception, though we
probably want something more general and that plays nicer with doFinish:
SolrException e = new SolrException(ErrorCode.CONFLICT, "version conflict for "
+ cmd.getPrintableId() + " expected=" + versionOnUpdate + " actual=" +
foundVersion);;
rsp.setException(e);
return true;
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066863#comment-15066863
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
Yeah, it is ConcurrentHttpSolrClient. The tracked exception in this case is a
connection reset exception and not a "Conflict".
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066832#comment-15066832
]
Mark Miller commented on SOLR-7339:
---
bq. So that fail seems pretty odd.
Okay, sorry, I thought SolrExampleBinaryTest was hitting this, I was working
from the wrong test. It's SolrExampleStreamingBinaryTest. I can't easily
reproduce a fail in either one, but I have seen it happen in some test runs.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066825#comment-15066825
]
Ishan Chattopadhyaya commented on SOLR-7339:
I changed it to "public volatile static JettySolrRunner jetty", and without
your patch. Still same error:
{code}
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=SolrExampleStreamingBinaryTest -Dtests.method=testUpdateField
-Dtests.seed=C198E930F63ED207 -Dtests.slow=true -Dtests.locale=es_PR
-Dtests.timezone=America/Martinique -Dtests.asserts=true
-Dtests.file.encoding=US-ASCII
[junit4] FAILURE 2.00s | SolrExampleStreamingBinaryTest.testUpdateField <<<
[junit4]> Throwable #1: java.lang.AssertionError:
ConcurrentUpdateSolrClient did not report an error
[junit4]>at
__randomizedtesting.SeedInfo.seed([C198E930F63ED207:94EB43643616C2C1]:0)
[junit4]>at
org.apache.solr.client.solrj.SolrExampleTests.testUpdateField(SolrExampleTests.java:1633)
[junit4]>at java.lang.Thread.run(Thread.java:745)
[junit4] 2> 7502 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[C198E930F63ED207]-worker) []
o.e.j.s.ServerConnector Stopped
ServerConnector@66fa0f59{HTTP/1.1,[http/1.1]}{127.0.0.1:0}
{code}
In a few hours, I can trace through and find out the exact class of the client,
and what is the corresponding behaviour on branch_5x for this test.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066795#comment-15066795
]
Mark Miller commented on SOLR-7339:
---
[~ichattopadhyaya], could you try making: 'public static JettySolrRunner
jetty' in SolrJettyTestBase volatile?
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066781#comment-15066781
]
Mark Miller commented on SOLR-7339:
---
So that fail seems pretty odd.
We can only hit that fail if: !(client instanceof HttpSolrClient)
And client can only be HttpSolrClient or EmbeddedSolrServer. It should not be
EmbeddedSolrServer, because we make a Jetty for this test and presumably a
Jetty is involved in this connection reset business. So we really expect that
client to be an HttpSolrClient don't we?
So how do we get to this fail message below unless we are using
EmbeddedSolrServer?
{code}
client.add(doc);
if(client instanceof HttpSolrClient) { //XXX concurrent client reports
exceptions differently
fail("Operation should throw an exception!");
} else {
client.commit(); //just to be sure the client has sent the doc
ErrorTrackingConcurrentUpdateSolrClient concurrentClient =
(ErrorTrackingConcurrentUpdateSolrClient) client;
assertNotNull("ConcurrentUpdateSolrClient did not report an error",
concurrentClient.lastError);
assertTrue("ConcurrentUpdateSolrClient did not report correct error: "
+ concurrentClient.lastError.getMessage(),
concurrentClient.lastError.getMessage().contains("Conflict"));
}
{code}
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066756#comment-15066756
]
Ishan Chattopadhyaya commented on SOLR-7339:
Right, same as without the patch. Here's the relevant part of the log from a
run without the patch.
{code}
[junit4] 2> 6916 INFO
(TEST-SolrExampleStreamingBinaryTest.testUpdateField-seed#[DD2B3DCB4B87359]) [
] o.a.s.SolrTestCaseJ4 ###Ending testUpdateField
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=SolrExampleStreamingBinaryTest -Dtests.method=testUpdateField
-Dtests.seed=DD2B3DCB4B87359 -Dtests.slow=true -Dtests.locale=it_IT
-Dtests.timezone=Europe/Skopje -Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 2.03s | SolrExampleStreamingBinaryTest.testUpdateField <<<
[junit4]> Throwable #1: java.lang.AssertionError:
ConcurrentUpdateSolrClient did not report an error
[junit4]>at
__randomizedtesting.SeedInfo.seed([DD2B3DCB4B87359:58A119887490639F]:0)
[junit4]>at
org.apache.solr.client.solrj.SolrExampleTests.testUpdateField(SolrExampleTests.java:1633)
[junit4]>at java.lang.Thread.run(Thread.java:745)
{code}
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066745#comment-15066745
]
Mark Miller commented on SOLR-7339:
---
bq. but the exact error isn't clear to me from that output.
It's tripping: assertTrue("ConcurrentUpdateSolrClient did not report an error",
concurrentClient.lastError.getMessage().contains("Conflict"));
Is that the same fail as without the patch? I assume so, but just to confirm.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066737#comment-15066737
]
Mark Miller commented on SOLR-7339:
---
Yeah, I just hit the fail for the first time as well. (with the patch applied).
Thanks for the confirm.
I filed SOLR-8451 for the above change.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066735#comment-15066735
]
Ishan Chattopadhyaya commented on SOLR-7339:
Mark, I applied your patch and ran the test, but the test still fails with the
following output. It appears to be the same as what I saw without your patch,
but the exact error isn't clear to me from that output.
{code}
[ishan@x230 solr]$ ant clean test -Dtestcase=SolrExampleStreamingBinaryTest
-Dtests.method=testUpdateField
...
ivy-configure:
[ivy:configure] :: loading settings :: file =
/home/ishan/code/lucene-solr-svn/lucene/ivy-settings.xml
resolve:
init:
compile-core:
validate:
resolve-groovy:
-init-totals:
-test:
[mkdir] Created dir:
/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test
[mkdir] Created dir:
/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/temp
[junit4] says 今日は! Master seed: EC056F9D893F1A9A
[junit4] Executing 1 suite with 1 JVM.
[junit4]
[junit4] Started J0 PID(1129@x230).
[junit4] Suite:
org.apache.solr.client.solrj.embedded.SolrExampleStreamingBinaryTest
[junit4] 2> Creating dataDir:
/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/init-core-data-001
[junit4] 2> 0INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.SolrTestCaseJ4 initCore
[junit4] 2> 2INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.SolrTestCaseJ4 initCore end
[junit4] 2> 6INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.SolrTestCaseJ4 Writing core.properties file to
/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/tempDir-002/cores/core
[junit4] 2> 46 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.e.j.u.log Logging initialized @2663ms
[junit4] 2> 277 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.e.j.s.Server jetty-9.3.6.v20151106
[junit4] 2> 323 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.e.j.s.h.ContextHandler Started
o.e.j.s.ServletContextHandler@6ec49310{/solr,null,AVAILABLE}
[junit4] 2> 339 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.e.j.s.ServerConnector Started
ServerConnector@3b2c45{HTTP/1.1,[http/1.1]}{127.0.0.1:33129}
[junit4] 2> 339 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.e.j.s.Server Started @2960ms
[junit4] 2> 340 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.c.s.e.JettySolrRunner Jetty properties: {hostContext=/solr,
hostPort=33129,
configSetBaseDir=/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/tempDir-001,
coreRootDirectory=/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/tempDir-002/cores}
[junit4] 2> 349 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.s.SolrDispatchFilter SolrDispatchFilter.init():
sun.misc.Launcher$AppClassLoader@4e0e2f2a
[junit4] 2> 385 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.c.SolrResourceLoader new SolrResourceLoader for directory:
'/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/tempDir-001'
[junit4] 2> 391 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.c.SolrResourceLoader JNDI not configured for solr (NoInitialContextEx)
[junit4] 2> 393 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.c.SolrResourceLoader using system property solr.solr.home:
/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/tempDir-001
[junit4] 2> 401 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.c.SolrXmlConfig Loading container configuration from
/home/ishan/code/lucene-solr-svn/solr/build/solr-solrj/test/J0/temp/solr.client.solrj.embedded.SolrExampleStreamingBinaryTest_EC056F9D893F1A9A-001/tempDir-001/solr.xml
[junit4] 2> 914 INFO
(SUITE-SolrExampleStreamingBinaryTest-seed#[EC056F9D893F1A9A]-worker) []
o.a.s.c.CorePropertiesLocator Config-defined core root directory:
/home/ishan/code
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066716#comment-15066716
]
Mark Miller commented on SOLR-7339:
---
I moved the method abort call out of 'shouldClose' - it doesn't seem like it
should be tied up in that.
I also made it first. I was just kind of guessing on that, but it looks like it
should be first according to:
https://hc.apache.org/httpcomponents-client-ga/httpclient/examples/org/apache/http/examples/client/ClientAbortMethod.java
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066701#comment-15066701
]
Mark Miller commented on SOLR-7339:
---
The above test does not easily replicate for me.
For someone that it does, could you give this patch a shot?
{noformat}
Index: solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
===
--- solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
(revision 1720969)
+++ solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
(working copy)
@@ -589,14 +589,16 @@
throw new SolrServerException(
"IOException occured when talking to server at: " + getBaseURL(), e);
} finally {
- if (respBody != null && shouldClose) {
-try {
- respBody.close();
-} catch (IOException e) {
- log.error("", e);
-} finally {
- if (!success) {
-method.abort();
+ try {
+if (!success) {
+ method.abort();
+}
+ } finally {
+if (respBody != null && shouldClose) {
+ try {
+respBody.close();
+ } catch (IOException e) {
+log.error("", e);
}
}
}
{noformat}
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066487#comment-15066487
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
bq. Let's open a separate issue for that. Internal HttpClient usage should be
getting an instance setup with the Retry policy that we want. I'm a little
skeptical that we just want to hard code it as off in the HttpSolrClient
constructor, but perhaps there is something to dig into there.
I opened SOLR-8450
bq. This upgrade is a bit scary at the moment. I see in one of the repeatable
connection reset issues, hard coding the Locale to English for the test makes
it pass. Other issues don't seem to relate to the Locale. Unless we can get to
the bottom of this quickly, we may want to pull this back and get a handle a
better handle on the problems before putting it in.
Agreed. Let's give it a day or two. If we can't find the root cause, I will
revert this upgrade.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066465#comment-15066465
]
Mark Miller commented on SOLR-7339:
---
bq. I think we should add that anyway even though it doesn't help fix these
failures.
Let's open a separate issue for that. Internal HttpClient usage should get
getting an instance setup with the Retry policy that we want. I'm a little
skeptical that we just want to hard code it as off in the HttpSolrClient
constructor, but perhaps there is something to dig into there.
This upgrade is a bit scary at the moment. I see in one of the repeatable
connection reset issues, hard coding the Locale to English for the test makes
it pass. Other issues don't seem to relate to the Locale. Unless we can get to
the bottom of this quickly, we may want to pull this back and get a handle a
better handle on the problems before putting it in.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065807#comment-15065807
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
Comparing the debug output from Jetty 9.2.13.v20150730, I see that Solr's
behavior has remained the same but Jetty now closes the connection on
unconsumed input. I also found that HttpClient by default will retry 3 times
when such a thing happens which is clearly not right. Adding
params.set(HttpClientUtil.PROP_USE_RETRY, false); to the HttpSolrClient
constructor disables those retries. I think we should add that anyway even
though it doesn't help fix these failures.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037874#comment-15037874
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
Thanks [~joakime]. I'll dig into why this is happening. As Ishan pointed out,
adding a breakpoint in the test makes it pass so there's a subtle race
condition somewhere.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037870#comment-15037870
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 171 from sha...@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r171 ]
SOLR-7339: Remove http2-parent as a dependency because it is only a pom and
thus fails our maven builds
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036273#comment-15036273
]
Ishan Chattopadhyaya commented on SOLR-7339:
Yesterday, I ran the same test using a debugger, and I put a breakpoint at
SolrCore.postDecorateResponse's first line (and subsequently I hit resume at
every instance of the breakpoint), then the test passes. I suspect there is
some timing issue here. I couldn't find anything obvious.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036185#comment-15036185
]
Joakim Erdfelt commented on SOLR-7339:
--
The Jetty Project developers took a look at this and ...
If you turn on DEBUG logging for Jetty, you'll see that the test does not send
correct data to the server.
The request that fails sends data using chunked encoding, but sends one chunk
of length 0x59, but does not send the terminal chunk.
The logs show Jetty reporting that the processing is complete but with
unconsumed input, and therefore closes the connection.
Could this be a Solr client bug in disguise?
Look at the attached
SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
Filter: tcp.stream eq 4
POST /solr/collection1/update?wt=javabin&version=2 HTTP/1.1
User-Agent: Solr[org.apache.solr.client.solrj.impl.HttpSolrClient] 1.0
Content-Type: application/javabin
Transfer-Encoding: chunked
Host: 127.0.0.1:52488
Connection: Keep-Alive
59
...¶ms..&delByQ..'docsMap.?"id&unique.)_version_4.'price_f
..#setT...
HTTP/1.1 409 Conflict
Date: Tue, 01 Dec 2015 19:44:38 GMT
Content-Type: application/octet-stream
Content-Length: 144
Server: Jetty(9.3.6.v20151106)
responseHeader..&statusY..%QTimeP..%error..#msg?4version conflict for
unique expected=1519385657324077057 actual=1519385657324077056.$codeY.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034670#comment-15034670
]
Gregg Donovan commented on SOLR-7339:
-
Thanks, [~shalinmangar]!
Wireshark dumps of SolrExampleStreamingBinaryTest.testUpdateField show Jetty
9.3 sends an RST after the expected "HTTP 409 Conflict" and Jetty 9.2 does not.
I haven't figured out what's changed in 9.3 that leads to this, though.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034495#comment-15034495
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 1717512 from sha...@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1717512 ]
SOLR-7339: Disabling testUpdateField until we can fix the underlying issue
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033865#comment-15033865
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
There's still a curious failure in
SolrExampleStreamingBinaryTest.testUpdateField which runs into connection reset
errors with the new jetty and I'm not sure why.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033665#comment-15033665
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 1717431 from sha...@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1717431 ]
SOLR-7339: Use GzipHandler instead of GzipFilter
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
>Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 6.0
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033045#comment-15033045
]
ASF subversion and git services commented on SOLR-7339:
---
Commit 1717377 from sha...@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1717377 ]
SOLR-7339: Upgrade Jetty to v9.3.6.v20151106
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
> Attachments: SOLR-7339.patch, SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702560#comment-14702560
]
Shalin Shekhar Mangar commented on SOLR-7339:
-
See LUCENE-6722 for the Java 8 discussion. The consensus is to move to Java 8
in 6.x and keep 5.x releases on Java 7.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
> Attachments: SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702549#comment-14702549
]
Bill Bell commented on SOLR-7339:
-
Java 7 is EOL
Java SE 7 End of Public Updates Notice
After April 2015, Oracle will no longer post updates of Java SE 7 to its public
download sites. Existing Java SE 7 downloads already posted as of April 2015
will remain accessible in the Java Archive on the Oracle Technology Network.
Developers and end-users are encouraged to update to more recent Java SE
versions that remain available for public download in order to continue
receiving public updates and security enhancements.
https://www.java.com/en/download/faq/java_7.xml
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
> Attachments: SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14587673#comment-14587673
]
Uwe Schindler commented on SOLR-7339:
-
9.3.0 was finally released on Jun 12.
Please keep in mind, that we can do the upgrade only on trunk, because Jety 9.3
requires Java 8 as minimum requirement.
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
> Attachments: SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7339) Upgrade Jetty from 9.2 to 9.3
[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568519#comment-14568519
]
Bill Bell commented on SOLR-7339:
-
http://central.maven.org/maven2/org/eclipse/jetty/jetty-distribution/9.3.0.RC0/
RC0 released
> Upgrade Jetty from 9.2 to 9.3
> -
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
>Reporter: Gregg Donovan
> Attachments: SOLR-7339.patch
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
