[GitHub] madlib issue #211: Change madlib gppkg version string
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/211 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/303/ ---
[GitHub] madlib issue #211: Change madlib gppkg version string
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/211 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/302/ ---
Re: PyXB version in MADlib github page
Thank you for the PR Frank. NJ On Thu, Dec 7, 2017 at 3:43 PM, Frank McQuillan wrote: > here is the PR > https://github.com/apache/madlib/pull/212 > > On Thu, Dec 7, 2017 at 3:25 PM, Frank McQuillan > wrote: > > > Yes there was a JIRA/PR to remove GPL components in 1.13: > > > > https://issues.apache.org/jira/browse/MADLIB-1103 > > https://github.com/apache/madlib/pull/190 > > > > Prior to that, the GPL component was removed during build in > > src/patch/PyXB.sh, > > which is fixed in the above PR. > > > > I will update the README.md > > > > Frank > > > > On Thu, Dec 7, 2017 at 2:25 PM, Nandish Jayaram > > wrote: > > > >> Hi All, > >> > >> The README page in MADlib's github page lists PyXB-1.2.4 > >> in Third Party Components. Should it be changed to PyXB-1.2.6 now? > >> > >> NJ > >> > > > > >
[GitHub] madlib issue #212: update PyXB version in README.md
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/212 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/301/ ---
[GitHub] madlib pull request #212: update PyXB version in README.md
Github user fmcquillan99 commented on a diff in the pull request: https://github.com/apache/madlib/pull/212#discussion_r155685205 --- Diff: README.md --- @@ -11,9 +11,11 @@ Installation and Contribution == See the project website [`MADlib Home`](http://madlib.apache.org/) for links to the latest binary and source packages. For installation and contribution guides, -and other useful information +and other useful information such as compiling from source --- End diff -- I put the top level link only since the pages and headings change in the wiki and wanted to avoid broken link. But I will put the sub-link, no harm. ---
[GitHub] madlib pull request #212: update PyXB version in README.md
Github user njayaram2 commented on a diff in the pull request: https://github.com/apache/madlib/pull/212#discussion_r155684500 --- Diff: README.md --- @@ -11,9 +11,11 @@ Installation and Contribution == See the project website [`MADlib Home`](http://madlib.apache.org/) for links to the latest binary and source packages. For installation and contribution guides, -and other useful information +and other useful information such as compiling from source --- End diff -- Compiling from source is actually in https://cwiki.apache.org/confluence/display/MADLIB/Installation+Guide#InstallationGuide-CompileFromSourceCompilingFromSource. We need to navigate through multiple links to reach here from the main MADlib wiki page. Can we use this link directly for `compiling from source on Linux` specifically? ---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user jingyimei commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155683583
--- Diff: cmake/LinuxUtils.cmake ---
@@ -9,3 +9,14 @@ macro(rh_version OUT_VERSION)
set(${OUT_VERSION} "${OUT_VERSION}-NOTFOUND")
endif(EXISTS "/etc/redhat-release")
endmacro(rh_version)
+
--- End diff --
yes, I can use a regex to grep RH_MAJOR_VERSION from RH_VERSION after
running`rh_version(RH_VERSION)`.
---
[GitHub] madlib issue #211: Change madlib gppkg version string
Github user jingyimei commented on the issue: https://github.com/apache/madlib/pull/211 @fmcquillan99 Yes, the version string is saved in Version.yml file and when we make the release, we will change the version string from 1.13_dev to 1.13, and cmake will directly get it from the yml file. ---
[GitHub] madlib issue #212: update PyXB version in README.md
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/212 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/300/ ---
[GitHub] madlib issue #212: update PyXB version in README.md
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/212 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/299/ ---
Re: PyXB version in MADlib github page
here is the PR https://github.com/apache/madlib/pull/212 On Thu, Dec 7, 2017 at 3:25 PM, Frank McQuillan wrote: > Yes there was a JIRA/PR to remove GPL components in 1.13: > > https://issues.apache.org/jira/browse/MADLIB-1103 > https://github.com/apache/madlib/pull/190 > > Prior to that, the GPL component was removed during build in > src/patch/PyXB.sh, > which is fixed in the above PR. > > I will update the README.md > > Frank > > On Thu, Dec 7, 2017 at 2:25 PM, Nandish Jayaram > wrote: > >> Hi All, >> >> The README page in MADlib's github page lists PyXB-1.2.4 >> in Third Party Components. Should it be changed to PyXB-1.2.6 now? >> >> NJ >> > >
[GitHub] madlib issue #209: add grouping predict e.g. for lin reg
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/209 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/298/ ---
[GitHub] madlib pull request #212: update PyXB version in README.md
GitHub user fmcquillan99 opened a pull request: https://github.com/apache/madlib/pull/212 update PyXB version in README.md minor version update for PyXB from 1.2.4 to 1.2.6 in README.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/fmcquillan99/incubator-madlib 1dot13-doc-updates-v3 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/madlib/pull/212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #212 commit db16d986b4f2bf3fb5a2f700ee541ea623b5c608 Author: Frank McQuillan Date: 2017-12-07T23:35:30Z update PyXB version in README.md ---
Re: PyXB version in MADlib github page
Yes there was a JIRA/PR to remove GPL components in 1.13: https://issues.apache.org/jira/browse/MADLIB-1103 https://github.com/apache/madlib/pull/190 Prior to that, the GPL component was removed during build in src/patch/PyXB.sh, which is fixed in the above PR. I will update the README.md Frank On Thu, Dec 7, 2017 at 2:25 PM, Nandish Jayaram wrote: > Hi All, > > The README page in MADlib's github page lists PyXB-1.2.4 > in Third Party Components. Should it be changed to PyXB-1.2.6 now? > > NJ >
PyXB version in MADlib github page
Hi All, The README page in MADlib's github page lists PyXB-1.2.4 in Third Party Components. Should it be changed to PyXB-1.2.6 now? NJ
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155598266
--- Diff: cmake/LinuxUtils.cmake ---
@@ -9,3 +9,14 @@ macro(rh_version OUT_VERSION)
set(${OUT_VERSION} "${OUT_VERSION}-NOTFOUND")
endif(EXISTS "/etc/redhat-release")
endmacro(rh_version)
+
--- End diff --
Would it be possible to get the major version from the above macro instead
of a new macro? Maybe after running `rh_version(RH_VERSION)`?
---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155597507
--- Diff: CMakeLists.txt ---
@@ -275,4 +275,3 @@ install(CODE "
${CMAKE_MADLIB_ROOT}/doc
)
")
--- End diff --
Let's put the newline back.
---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155599007
--- Diff: src/ports/greenplum/cmake/GreenplumUtils.cmake ---
@@ -17,6 +17,9 @@ function(add_gppkg GPDB_VERSION GPDB_VARIANT
GPDB_VARIANT_SHORT UPGRADE_SUPPORT)
string(TOLOWER ${GPDB_VERSION} GPDB_VERSION_LC)
string(REPLACE "." "_" VERSION_ "${GPDB_VERSION}")
+# Get information about the rhel version
+rh_major_version(RH_VERSION)
--- End diff --
`RPM/cmakelists.txt` is also setting `RH_VERSION`. How about we call this
RH_MAJOR_VERSION?
---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155598502
--- Diff: cmake/LinuxUtils.cmake ---
@@ -9,3 +9,14 @@ macro(rh_version OUT_VERSION)
set(${OUT_VERSION} "${OUT_VERSION}-NOTFOUND")
endif(EXISTS "/etc/redhat-release")
endmacro(rh_version)
+
+macro(rh_major_version OUT_VERSION)
+if(EXISTS "/etc/redhat-release")
+file(READ "/etc/redhat-release" _REDHAT_RELEASE_CONTENT)
+string(REGEX MATCH "([0-9])" ${OUT_VERSION}
+"${_REDHAT_RELEASE_CONTENT}"
+)
+else(EXISTS "/etc/redhat-release")
+set(${OUT_VERSION} "${OUT_VERSION}-NOTFOUND")
+endif(EXISTS "/etc/redhat-release")
+endmacro(rh_major_version)
--- End diff --
Newline needed here.
---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155598453
--- Diff: CMakeLists.txt ---
@@ -275,4 +275,3 @@ install(CODE "
${CMAKE_MADLIB_ROOT}/doc
)
")
-
--- End diff --
We should put the newline at end of file.
---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request: https://github.com/apache/madlib/pull/211#discussion_r155598729 --- Diff: deploy/gppkg/CMakeLists.txt --- @@ -2,8 +2,11 @@ # Packaging for Greenplum's gppkg # -- -set(MADLIB_GPPKG_VERSION "1.9.9") -set(MADLIB_GPPKG_RELEASE_NUMBER 1) +# not used now +# set(MADLIB_GPPKG_VERSION "1.9.9") --- End diff -- IMO, we can delete this. Don't need to keep it for posterity. ---
[GitHub] madlib pull request #211: Change madlib gppkg version string
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/madlib/pull/211#discussion_r155598556
--- Diff: deploy/CMakeLists.txt ---
@@ -82,4 +82,4 @@ cpack_add_component_group(ports
file(GLOB PORT_COMPONENTS "${CMAKE_CURRENT_BINARY_DIR}/Component_*.cmake")
foreach(PORT_COMPONENT ${PORT_COMPONENTS})
include("${PORT_COMPONENT}")
-endforeach(PORT_COMPONENT)
+endforeach(PORT_COMPONENT)
--- End diff --
Let's add the newline back.
---
[GitHub] madlib issue #211: Change madlib gppkg version string
Github user fmcquillan99 commented on the issue: https://github.com/apache/madlib/pull/211 naming convention looks good. I assume for prod releases there is no "_dev" in the name. ---
[GitHub] madlib issue #211: Change madlib gppkg version string
Github user asfgit commented on the issue: https://github.com/apache/madlib/pull/211 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/madlib-pr-build/297/ ---
[GitHub] madlib pull request #211: Change madlib gppkg version string
GitHub user jingyimei opened a pull request: https://github.com/apache/madlib/pull/211 Change madlib gppkg version string This commit changes the naming convention for madlib gppkg, after renaming, the format of madlib gppkg will look like: madlib-1.13_dev-gp5-rhel6-x86_64.gppkg madlib-1.12_dev-gp4.3orca-rhel5-x86_64.gppkg You can merge this pull request into a Git repository by running: $ git pull https://github.com/jingyimei/madlib gppkg_rename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/madlib/pull/211.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #211 commit 192e7208e2cab2845642eb0995e277382c2af250 Author: Jingyi Mei Date: 2017-12-06T04:13:34Z Change madlib gppkg version string This commit changes the naming convention for madlib gppkg, after renaming, the format of madlib gppkg will look like: madlib-1.13_dev-gp5-rhel6-x86_64.gppkg madlib-1.12_dev-gp4.3orca-rhel5-x86_64.gppkg ---
