[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065757#comment-16065757
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


Github user AdityaAS closed the pull request at:

https://github.com/apache/mahout/pull/321


> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
> Fix For: 0.13.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065585#comment-16065585
 ] 

ASF GitHub Bot commented on MAHOUT-1993:


Github user andrewpalumbo closed the pull request at:

https://github.com/apache/mahout/pull/327


> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to 
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped 
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065584#comment-16065584
 ] 

ASF GitHub Bot commented on MAHOUT-1993:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/327
  
committed in a799ead59aa77cab0596f72bbe40872b59367e35


> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to 
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped 
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1994) Remove ViennCL jars upon mvn clean.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065550#comment-16065550
 ] 

ASF GitHub Bot commented on MAHOUT-1994:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/328


> Remove ViennCL jars upon mvn clean.
> ---
>
> Key: MAHOUT-1994
> URL: https://issues.apache.org/jira/browse/MAHOUT-1994
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> currently, after running `mvn clean` from $MAHOUT_HOME, VinenaCL jars are not 
> removed from the base level directory.
> add in something similar to: 
> {code}
>  
> maven-clean-plugin
> 3.0.0
> 
>   
> 
>   ../
>   
> mahout-spark*.jar
>   
>   false
> 
>   
> 
>   
> 
>   
> {code} 
> in both {{vienncl}} and {{viennacl-omp}} module pom.xmls



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063891#comment-16063891
 ] 

ASF GitHub Bot commented on MAHOUT-1993:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/327
  
Cool.. I'm at dr, and won't be back for a little while.  If u r working on 
this now and need to push , please feel free to push.



Sent from my Verizon Wireless 4G LTE smartphone


 Original message 
From: Trevor Grant 
Date: 06/26/2017 3:12 PM (GMT-08:00)
To: apache/mahout 
Cc: Andrew Palumbo , Author 
Subject: Re: [apache/mahout] MAHOUT-1993: fix hardcoding of scala version 
in spark dependency-reduced.xml (#327)


squash and lgtm
(failed tests were re oracle7 no longer being supported by travis)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to 
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped 
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1994) Remove ViennCL jars upon mvn clean.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063889#comment-16063889
 ] 

ASF GitHub Bot commented on MAHOUT-1994:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/328
  
lgtm- failed on oracle7 no longer being supported by travis, which has been 
fixed in another pr


> Remove ViennCL jars upon mvn clean.
> ---
>
> Key: MAHOUT-1994
> URL: https://issues.apache.org/jira/browse/MAHOUT-1994
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> currently, after running `mvn clean` from $MAHOUT_HOME, VinenaCL jars are not 
> removed from the base level directory.
> add in something similar to: 
> {code}
>  
> maven-clean-plugin
> 3.0.0
> 
>   
> 
>   ../
>   
> mahout-spark*.jar
>   
>   false
> 
>   
> 
>   
> 
>   
> {code} 
> in both {{vienncl}} and {{viennacl-omp}} module pom.xmls



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063887#comment-16063887
 ] 

ASF GitHub Bot commented on MAHOUT-1993:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/327
  
squash and lgtm
(failed tests were re oracle7 no longer being supported by travis)



> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to 
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped 
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1969) Create Profiles for Spark 1.6, 2.0.2, 2.1.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063876#comment-16063876
 ] 

ASF GitHub Bot commented on MAHOUT-1969:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/329

MAHOUT-1969 Add Spark Profiles

### Purpose of PR:
Please give a short description of what this PR is for.


### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [x] Created unit tests where appropriate
- [x] Added licenses correct on newly added files
- [x] Assigned JIRA to self
- [x] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally. 

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?
no

Is this the beginning of a larger project for which a feature branch should 
be made?
no


NOTE: didn't test locally- easier to do with travis. (minor change, only 
updating poms)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1969

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/329.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #329






> Create Profiles for Spark 1.6, 2.0.2, 2.1.0
> ---
>
> Key: MAHOUT-1969
> URL: https://issues.apache.org/jira/browse/MAHOUT-1969
> Project: Mahout
>  Issue Type: Improvement
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>  Labels: beginner
> Fix For: 0.13.1
>
>
> Create profiles for spark 1.6, 2.0.2 and 2.1.0.  Spark 1.6 should be default. 
> Update CI tests to use profiles instead of variable setting.
> Further- Spark 1.6 should invoke scala 2.10 profile by default, Spark 2.x 
> should invoke scala 2.11.
> As such Mahout-1968 is a blocker



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1795) Release Scala 2.11 bindings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063855#comment-16063855
 ] 

ASF GitHub Bot commented on MAHOUT-1795:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179
  
going to merge this and fix outstanding issues with other PRs. 


> Release Scala 2.11 bindings
> ---
>
> Key: MAHOUT-1795
> URL: https://issues.apache.org/jira/browse/MAHOUT-1795
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Mike Kaplinskiy
> Fix For: 0.13.1
>
> Attachments: patch.diff
>
>
> It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. 
> (I'm not sure of other users, but mahout-shell isn't nearly at the top of my 
> list here).
> It looks simple enough for those two - the attached patch is a 
> proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not 
> sure what the proper way to do this is, but it doesn't look too daunting. 
> (Famous last words?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063850#comment-16063850
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/321
  
@AdityaAS  go ahead and close this please.


> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
> Fix For: 0.13.1
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063841#comment-16063841
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/326


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1994) Remove ViennCL jars upon mvn clean.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063714#comment-16063714
 ] 

ASF GitHub Bot commented on MAHOUT-1994:


GitHub user andrewpalumbo opened a pull request:

https://github.com/apache/mahout/pull/328

MAHOUT-1994: clean viennacl jars on 'mvn clean -Pviennacl -Phadoop2'

### Purpose of PR:
Please give a short description of what this PR is for.


### Important ToDos
Please mark each with an "x"
- [x ] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x ] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [x ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should 
be made?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewpalumbo/mahout MAHOUT-1994

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #328


commit eaa54ad64dd9920b52ff255f802c3a0913f0c487
Author: Andrew Palumbo 
Date:   2017-06-26T20:27:11Z

clean viennacl jars on 'mvn clean -Pviennacl -Phadoop2'




> Remove ViennCL jars upon mvn clean.
> ---
>
> Key: MAHOUT-1994
> URL: https://issues.apache.org/jira/browse/MAHOUT-1994
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> currently, after running `mvn clean` from $MAHOUT_HOME, VinenaCL jars are not 
> removed from the base level directory.
> add in something similar to: 
> {code}
>  
> maven-clean-plugin
> 3.0.0
> 
>   
> 
>   ../
>   
> mahout-spark*.jar
>   
>   false
> 
>   
> 
>   
> 
>   
> {code} 
> in both {{vienncl}} and {{viennacl-omp}} module pom.xmls



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062415#comment-16062415
 ] 

ASF GitHub Bot commented on MAHOUT-1993:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/327
  
to be committed on top of #326 


> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to 
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
>Priority: Blocker
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped 
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062390#comment-16062390
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123904856
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

+1 - I'd forgotten that last night.  


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062320#comment-16062320
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123898430
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

fwiw- travis now runs all unit tests in pseudocluster. just fyi- of spark 
1.6, 2.0, 2.1


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062164#comment-16062164
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123887027
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

@rawkintrevo lgtm - ship it! we swill still need to do some testing against 
other spark versions though.  As well, there are some other issues that I've 
noticed, but can be addressed in other PRs on top of this anyways, eg. #327. 


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1993) ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to scala 2.10

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062163#comment-16062163
 ] 

ASF GitHub Bot commented on MAHOUT-1993:


GitHub user andrewpalumbo opened a pull request:

https://github.com/apache/mahout/pull/327

MAHOUT-1993: fix hardcoding of scala version in spark dependency-reduced.xml

### Purpose of PR:
Please give a short description of what this PR is for.


### Important ToDos
Please mark each with an "x"
- [ ] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [ ] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should 
be made?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewpalumbo/mahout MAHOUT-1993

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/327.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #327


commit fad2b573b4234c1cc67a29d6302786d26d9ed49c
Author: Andrew Palumbo 
Date:   2017-06-24T22:43:29Z

fix hardcoding of scala version




> ViennaCL dependency-reduced.xml assembly scala versions are hardcoded to 
> scala 2.10
> ---
>
> Key: MAHOUT-1993
> URL: https://issues.apache.org/jira/browse/MAHOUT-1993
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Andrew Palumbo
> Fix For: 0.13.1
>
>
> in {{spark/src/assembly/dependency-reduced.xml}} ViennaCL deps to be shipped 
> are hard-coded to scala-2.10.:
> {code}
> org.apache.mahout:mahout-native-viennacl_2.10
> org.apache.mahout:mahout-native-viennacl-omp_2.10
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062128#comment-16062128
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123885295
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

If you'd like to merge this first i'd be +1 on that.  Then testing on 
pseudo cluster could be a separate issue.   The `spark/dependency reduced.xml` 
needs to be updated.  


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062126#comment-16062126
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123885270
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

@rawkintrevo: 
```
$MAHOUT_HOME/viennacl$ mvn  test -Dscala.version=2.11.2 
-Dscala.compat.version=2.11 -Pviennacl  
```
(I'd tried built with 2.11.2)
tests pass: 
```
All tests passed.
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 01:36 min
[INFO] Finished at: 2017-06-24T13:49:59-07:00
[INFO] Final Memory: 20M/296M
[INFO] 

```
Sweet- I'd like to try this in Pseudo cluster mode as well, this afternoon.


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062121#comment-16062121
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123885153
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

rebuilding abd testing now with the correct scala flags.. noticed this in 
spark/dependency-reduced-pom.xmlpom.xml:  [INFO] Reading assembly descriptor: 
src/main/assembly/dependency-reduced.xml

```
[WARNING] The following patterns were never triggered in this artifact 
inclusion filter:
o  'org.apache.mahout:mahout-native-viennacl_2.10'
o  'org.apache.mahout:mahout-native-viennacl-omp_2.10'

[INFO] Building jar: 
/home/andy/sandbox/mahout_cuda/spark/target/mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
```
*easyhack*: add
to `spark/dependency reduced.xml`:
```
  'org.apache.mahout:mahout-native-viennacl_2.11'
  'org.apache.mahout:mahout-native-viennacl-omp_2.11'
```
though that pom should honor the `{scala.compat.version}` 


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061723#comment-16061723
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123867359
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

@andrewpalumbo can you try

`mvn test -Dscala.version=2.11.8 -Dscala.compat.version=2.11`

The reason I believe this works is- 
```

  org.scalatest
  scalatest_${scala.compat.version}

```
where scala-compat-version is by default 2.10.  So when you `mvn test` you 
are doing so with scala-test_2.10, and that's where its losing its mind.

(Also explains why these were passing in Travis)


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061714#comment-16061714
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123866703
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

@andrewpalumbo thanks for the review

If you look at line 49 and 56 below- this is what replaces.  Line 49 lets 
you call the constructor with out a default context (same as what happened 
here) line 56 lets you explicitly pass a context. 

Re: Scala 2.11.2, I made a comment on MAHOUT-1975.  We probably need to 
figure out where the dependency comes from and try to work around it. 

Will also dig in on my end- viennacl always fails for me bc I don't have 
strong enough GPUs- but results should be same for ViennaCL-OMP.


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1795) Release Scala 2.11 bindings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061712#comment-16061712
 ] 

ASF GitHub Bot commented on MAHOUT-1795:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r123866644
  
--- Diff: pom.xml ---
@@ -917,6 +914,26 @@
   
 
 
+  scala-2.10
+  
+!scala-2.11
+  
+  
+2.10
+2.10.4
+  
+
+
+  scala-2.11
+  
+scala-2.11
+  
+  
+2.11
+2.11.8
--- End diff --

We need to cap at 2.11.2 to maintain breeze compatibility. see 
https://github.com/apache/mahout/pull/326/files#diff-5d8d832c3c4016dd77a9c3d92a2c5b69


> Release Scala 2.11 bindings
> ---
>
> Key: MAHOUT-1795
> URL: https://issues.apache.org/jira/browse/MAHOUT-1795
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Mike Kaplinskiy
> Fix For: 0.13.1
>
> Attachments: patch.diff
>
>
> It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. 
> (I'm not sure of other users, but mahout-shell isn't nearly at the top of my 
> list here).
> It looks simple enough for those two - the attached patch is a 
> proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not 
> sure what the proper way to do this is, but it doesn't look too daunting. 
> (Famous last words?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061655#comment-16061655
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123863312
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

@rawkintrevo I have no problems building this for scala-2.11, with E.g.: 
`mvn clean install -Dscala.version=2.11.2 -Dscala.compat.version=2.11 
-Pviennacl -Phadoop2  -DskipTests`` *note* the scala version is @ 2.11 which I 
think wee may need to make our cap due to the Breeze vector cap @scala 2.11.2 :
```
 [WARNING]  org.scalanlp:breeze_2.11:0.11.2 requires scala version: 2.11.4 
```
```
[INFO] 

[INFO] Reactor Summary:
[INFO] 
[INFO] Mahout Build Tools . SUCCESS [  
3.189 s]
[INFO] Apache Mahout .. SUCCESS [  
0.080 s]
[INFO] Mahout Math  SUCCESS [ 
13.226 s]
[INFO] Mahout HDFS  SUCCESS [  
3.310 s]
[INFO] Mahout Map-Reduce .. SUCCESS [ 
21.442 s]
[INFO] Mahout Integration . SUCCESS [  
6.183 s]
[INFO] Mahout Examples  SUCCESS [ 
21.106 s]
[INFO] Mahout Math Scala bindings . SUCCESS [ 
54.202 s]
[INFO] Mahout Spark bindings .. SUCCESS [ 
51.939 s]
[INFO] Mahout Native VienniaCL OpenCL Bindings  SUCCESS [ 
48.965 s]
[INFO] Mahout Native VienniaCL OpenMP Bindings  SUCCESS [ 
25.782 s]
[INFO] Mahout Release Package . SUCCESS [  
2.567 s]
[INFO] Mahout H2O backend . SUCCESS [ 
22.381 s]
[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 04:34 min
[INFO] Finished at: 2017-06-23T16:39:21-07:00
[INFO] Final Memory: 132M/1124M
[INFO] ---
```

tests are failing for me though in `viennacl`.  I'll to dig deeper.


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061605#comment-16061605
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123857432
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

hmm. when running `mvn test` on a scala 2.11.2 build it seems to bee 
looking for ViennCL built for 2.10:  `mahout-native-viennacl_2.10 `
```
[INFO] Copying 3 resources
[INFO] 
[INFO] --- scala-maven-plugin:3.2.0:testCompile (scala-test-compile) @ 
mahout-native-viennacl_2.10 ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ 
mahout-native-viennacl_2.10 ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ 
mahout-native-viennacl_2.10 ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- scalatest-maven-plugin:1.0:test (test) @ 
mahout-native-viennacl_2.10 ---
```
Maybe the scalatest plugin in scala version is hardcoded in a pom somewere?.



> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061541#comment-16061541
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123850836
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

getting: ```*** RUN ABORTED *** java.lang.NoSuchMethodError: 
scala.runtime.IntRef.create(I)Lscala/runtime/IntRef; at 
org.apache.mahout.viennacl.opencl.package$.repackCSR(package.scala:227) at 
org.apache.mahout.viennacl.opencl.package$.toVclCmpMatrixAlt(package.scala:120) 
at 
org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$gpuRWCW(GPUMMul.scala:161)
 at 
org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$jvmRWRW(GPUMMul.scala:208)
 at 
org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78) 
at 
org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78) 
at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:127) at 
org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:33) at 
org.apache.mahout.math.scalabindings.RLikeMatrixOps.$percent$times$percent(RLikeMatrixOps.scala:37)
 at 
org.apache.mahout.opencl.viennacl.ViennaCLSuiteVCL$$anonfun$2.apply$mcV$sp(ViennaCLSuiteVCL.scala:92)```

when running `mvn test` in the viennacl package.


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061539#comment-16061539
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/326#discussion_r123573034
  
--- Diff: 
viennacl/src/main/scala/org/apache/mahout/viennacl/opencl/javacpp/DenseColumnMatrix.scala
 ---
@@ -36,12 +36,24 @@ import org.bytedeco.javacpp.annotation._
 @Name(Array("viennacl::matrix"))
 final class DenseColumnMatrix(initDefault:Boolean = true) extends 
MatrixBase {
 
-  def this(nrow: Int, ncol: Int, ctx: Context = new Context()) {
+  def this(nrow: Int, ncol: Int) {
+this(false)
+allocate(nrow, ncol, new Context())
+  }
+
+  def this(nrow: Int, ncol: Int, ctx: Context) {
 this(false)
 allocate(nrow, ncol, ctx)
   }
 
-  def this(data: DoublePointer, nrow: Int, ncol: Int, ctx: Context = new 
Context(Context.MAIN_MEMORY)) {
--- End diff --

this _should_ be ok, i'm not sure if we have a need for a default `Context` 
here, but we may want to accept a `Context` in place here, Which, It seems has 
been added  below at line 56 - I'm not sure what this has replaced thogh.(line 
56).  I'll dig into it later.. From what you said earlier this doesn't seem to 
be API breaking.  


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) ViennaCL and OMP not building for Scala 2.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061486#comment-16061486
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/326
  
getting: ```*** RUN ABORTED ***
  java.lang.NoSuchMethodError: 
scala.runtime.IntRef.create(I)Lscala/runtime/IntRef;
  at org.apache.mahout.viennacl.opencl.package$.repackCSR(package.scala:227)
  at 
org.apache.mahout.viennacl.opencl.package$.toVclCmpMatrixAlt(package.scala:120)
  at 
org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$gpuRWCW(GPUMMul.scala:161)
  at 
org.apache.mahout.viennacl.opencl.GPUMMul$.org$apache$mahout$viennacl$opencl$GPUMMul$$jvmRWRW(GPUMMul.scala:208)
  at 
org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78)
  at 
org.apache.mahout.viennacl.opencl.GPUMMul$$anonfun$12.apply(GPUMMul.scala:78)
  at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:127)
  at org.apache.mahout.viennacl.opencl.GPUMMul$.apply(GPUMMul.scala:33)
  at 
org.apache.mahout.math.scalabindings.RLikeMatrixOps.$percent$times$percent(RLikeMatrixOps.scala:37)
  at 
org.apache.mahout.opencl.viennacl.ViennaCLSuiteVCL$$anonfun$2.apply$mcV$sp(ViennaCLSuiteVCL.scala:92)```
 when running `mvn test` in the viennacl package.


> ViennaCL and OMP not building for Scala 2.11
> 
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1989) Paul Komarek's Thesis URL is 403'ing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061142#comment-16061142
 ] 

ASF GitHub Bot commented on MAHOUT-1989:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/322


> Paul Komarek's Thesis URL is 403'ing
> 
>
> Key: MAHOUT-1989
> URL: https://issues.apache.org/jira/browse/MAHOUT-1989
> Project: Mahout
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Clay B.
>Priority: Trivial
>
> Going to 
> {{http://www.autonlab.org/autonweb/14709/version/4/part/5/data/komarek:lr_thesis.pdf?branch=main&language=en}}
>  e.g. from 
> https://mahout.apache.org/users/classification/logistic-regression.html 
> results in a 403. The current URL is from his lab. Using a web search I find 
> that his thesis is hosted at 
> {{http://repository.cmu.edu/cgi/viewcontent.cgi?article=1221&context=robotics}}
>  which is likely to be stable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) scala 2.10 is hardcoded somewhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059620#comment-16059620
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/326
  
fwiw- this doesn't actually fix the dependency issue. I think I'll make a 
new jira ticket for this, then down grade mahout-1988 to trivial



>  scala 2.10 is hardcoded somewhere
> --
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1988) scala 2.10 is hardcoded somewhere

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058329#comment-16058329
 ] 

ASF GitHub Bot commented on MAHOUT-1988:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/326

MAHOUT-1988 Make Native Solvers Scala 2.11 Complient

### Purpose of PR:
Please give a short description of what this PR is for.


### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [x] Assigned JIRA to self
- [x] Successfully built and ran all unit tests, verified that all tests 
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?
no

Is this the beginning of a larger project for which a feature branch should 
be made?
no

Issue was- as error message stated, default arguments not allowed in 
multiple constructors- scala gets confuzzled.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1988

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #326


commit 76408bf1a76fb0e028859d898b6c231f0e29a9fb
Author: rawkintrevo 
Date:   2017-06-21T21:59:01Z

MAHOUT-1988 Make Native Solvers Scala 2.11 Complient




>  scala 2.10 is hardcoded somewhere
> --
>
> Key: MAHOUT-1988
> URL: https://issues.apache.org/jira/browse/MAHOUT-1988
> Project: Mahout
>  Issue Type: Bug
>Affects Versions: 0.13.0
>Reporter: Andrew Palumbo
>Assignee: Trevor Grant
>Priority: Blocker
> Fix For: 0.13.1
>
>
> After building mahout against scala 2.11: 
> {code}
> mvn clean install -Dscala.version=2.11.4 -Dscala.compat.version=2.11 
> -Phadoop2  -DskipTests
> {code}
> ViennaCL jars are built hard-coded to scala 2.10.  This is currently blocking 
> the 0.13.1 release. 
> {code}
> mahout-h2o_2.11-0.13.1-SNAPSHOT.jar
> mahout-hdfs-0.13.1-SNAPSHOT.jar
> mahout-math-0.13.1-SNAPSHOT.jar
> mahout-math-scala_2.11-0.13.1-SNAPSHOT.jar
> mahout-mr-0.13.1-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.0-SNAPSHOT.jar
> mahout-native-cuda_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl_2.10-0.13.1-SNAPSHOT.jar
> mahout-native-viennacl-omp_2.10-0.13.1-SNAPSHOT.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT-dependency-reduced.jar
> mahout-spark_2.11-0.13.1-SNAPSHOT.jar
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1795) Release Scala 2.11 bindings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053540#comment-16053540
 ] 

ASF GitHub Bot commented on MAHOUT-1795:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/179#discussion_r122633209
  
--- Diff: spark/src/main/assembly/dependency-reduced.xml ---
@@ -38,14 +38,14 @@
   
 
 com.google.guava:guava
-com.github.scopt
+com.github.scopt_${scala.compat.version}
--- End diff --

@pferrel @andrewpalumbo is this the thing ^^ 


> Release Scala 2.11 bindings
> ---
>
> Key: MAHOUT-1795
> URL: https://issues.apache.org/jira/browse/MAHOUT-1795
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Mike Kaplinskiy
> Fix For: 1.0.0
>
> Attachments: patch.diff
>
>
> It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. 
> (I'm not sure of other users, but mahout-shell isn't nearly at the top of my 
> list here).
> It looks simple enough for those two - the attached patch is a 
> proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not 
> sure what the proper way to do this is, but it doesn't look too daunting. 
> (Famous last words?)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043499#comment-16043499
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/318
  
@nsakharnykh sorry for the state of this branch, I tend to commit a lot on 
this project, and leave a lot of [WIP]s in when jumping around to other 
branches.  Resolved all conflicts the against CUDA branch.. going to start 
looking at Dense %*% sparse again. First need to read up on `JCublas2._`.


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027899#comment-16027899
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/321
  
Willdo, having trouble logging on to github this morning... (not sure why 
they logged me out).



Sent from my Verizon Wireless 4G LTE smartphone


 Original message 
From: Trevor Grant 
Date: 05/28/2017 9:26 AM (GMT-08:00)
To: apache/mahout 
Cc: Andrew Palumbo , Mention 

Subject: Re: [apache/mahout] MAHOUT-1973 (#321)


This is a very curious case.

@andrewpalumbo would you take a look? 
It's only failing on the viennaCL profiles. Perhaps this is related to (would 
be resolved by) the work you are doing wrt the Scala 2.11 clean up for the 
viennaCL files?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027853#comment-16027853
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/321
  
This is a very curious case. 

@andrewpalumbo would you take a look? It's only failing on the viennaCL 
profiles. Perhaps this is related to (would be resolved by) the work you are 
doing wrt the Scala 2.11 clean up for the viennaCL files?


> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1989) Paul Komarek's Thesis URL is 403'ing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027851#comment-16027851
 ] 

ASF GitHub Bot commented on MAHOUT-1989:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/322
  
@cbaenziger well spotted and thanks for the contribution!

lgtm if no further comment



> Paul Komarek's Thesis URL is 403'ing
> 
>
> Key: MAHOUT-1989
> URL: https://issues.apache.org/jira/browse/MAHOUT-1989
> Project: Mahout
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Clay B.
>Priority: Trivial
>
> Going to 
> {{http://www.autonlab.org/autonweb/14709/version/4/part/5/data/komarek:lr_thesis.pdf?branch=main&language=en}}
>  e.g. from 
> https://mahout.apache.org/users/classification/logistic-regression.html 
> results in a 403. The current URL is from his lab. Using a web search I find 
> that his thesis is hosted at 
> {{http://repository.cmu.edu/cgi/viewcontent.cgi?article=1221&context=robotics}}
>  which is likely to be stable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1990) Implement Multilayer Perceptron

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027850#comment-16027850
 ] 

ASF GitHub Bot commented on MAHOUT-1990:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/323

MAHOUT-1990 [WIP] Add Multilayer Perceptron

### Purpose of PR:
Implements multi-layer perceptron style neural network

Also introduces some SGD functionality (namely learning strategies) (will, 
doesn't yet)

Also introduces classifier trait


### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [x] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally.

Does this change break earlier versions?
**yes** refactored linear regression to new sub-package, and created 
nonlinear package.

Is this the beginning of a larger project for which a feature branch should 
be made?
... possibly, but I think I will have it all working in short enough order 
that it can stay on mine- however I am open to this idea if someone else wants 
to chip in. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1990

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #323


commit d15a9c2730888aeb0973c173ccdaeb12957b2c53
Author: rawkintrevo 
Date:   2017-05-25T06:49:10Z

initial incoreMLP work

commit ab2b1213b76f1f94297a617d7f465479825d7377
Author: rawkintrevo 
Date:   2017-05-27T15:48:07Z

Distributed MLP

commit 226a884c8e7d520cd4656ab9d8cfd71647a84b0f
Author: rawkintrevo 
Date:   2017-05-28T04:30:45Z

Distributed works now

commit 7ea981e53af692a43bc4b75c176b46b7ff6ce328
Author: rawkintrevo 
Date:   2017-05-28T14:05:47Z

Distributed works now

commit c32585be8d0260c0a6000ebd6944c0b1a2c95595
Author: rawkintrevo 
Date:   2017-05-28T16:03:24Z

Added regression and classifier wrappers




> Implement Multilayer Perceptron
> ---
>
> Key: MAHOUT-1990
> URL: https://issues.apache.org/jira/browse/MAHOUT-1990
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.13.2
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> Following strategy
> It should- 
> 1. implement incoreMLPs which can be 'plugged together' for purposes of back 
> propegation (this makes for easy extension into more complex networks)
> 2. implement a common distributed MLP which maps out incoreMLPs and then 
> averages parameters
> 3. regression and classifier wrappers around the base MLP to reduce 
> duplication of code
> 4. would be nice to make distributed and incore neural network 'trait' for 
> consistent API across all future neural networks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1989) Paul Komarek's Thesis URL is 403'ing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024246#comment-16024246
 ] 

ASF GitHub Bot commented on MAHOUT-1989:


GitHub user cbaenziger opened a pull request:

https://github.com/apache/mahout/pull/322

MAHOUT-1989 - Paul Komarek's Thesis URL is 403'ing

### Purpose of PR:
MAHOUT-1989 to fix Paul Komarek's Thesis URL

### Important ToDos
Please mark each with an "x"
- [X] A JIRA ticket exists 
(MAHOUT-1989)[https://issues.apache.org/jira/browse/MAHOUT-1989]
- [X ] Title of PR is "MAHOUT-1989 - Paul Komarek's Thesis URL is 403'ing" 
where 1989 is the JIRA number.
- [NA] Created unit tests where appropriate
- [NA] Added licenses correct on newly added files
- [ ] Assigned JIRA to self (I can not seem to do this?)
- [NA] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally. (Sorry I didn't try building the docs; but here's the change...)

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should 
be made?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cbaenziger/mahout MAHOUT-1989

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #322


commit f027cca435859bb0f9f48447bf3b8ce5fc8a7a1e
Author: Clay Baenziger 
Date:   2017-05-25T05:53:30Z

MAHOUT-1989 - Paul Komarek's Thesis URL is 403'ing




> Paul Komarek's Thesis URL is 403'ing
> 
>
> Key: MAHOUT-1989
> URL: https://issues.apache.org/jira/browse/MAHOUT-1989
> Project: Mahout
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Clay B.
>Priority: Trivial
>
> Going to 
> {{http://www.autonlab.org/autonweb/14709/version/4/part/5/data/komarek:lr_thesis.pdf?branch=main&language=en}}
>  e.g. from 
> https://mahout.apache.org/users/classification/logistic-regression.html 
> results in a 403. The current URL is from his lab. Using a web search I find 
> that his thesis is hosted at 
> {{http://repository.cmu.edu/cgi/viewcontent.cgi?article=1221&context=robotics}}
>  which is likely to be stable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1976) Add Canopy Clustering Algorithm

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018681#comment-16018681
 ] 

ASF GitHub Bot commented on MAHOUT-1976:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/314


> Add Canopy Clustering Algorithm
> ---
>
> Key: MAHOUT-1976
> URL: https://issues.apache.org/jira/browse/MAHOUT-1976
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.13.2
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> Primarily, we need to lay out the clustering section of the Algorihtms 
> Framework.
> The Canopy Clustering Algorithm is very simple and yet very useful as a 
> preprocessing step for more advanced clustering algorithms such as KMeans and 
> Hierarchical Clustering. 
> https://en.wikipedia.org/wiki/Canopy_clustering_algorithm
> The majority of the "work" on this PR will be creating the framework. 
> It is also one of the Legacy MR algorithms that would be nice to port.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018680#comment-16018680
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/300


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1795) Release Scala 2.11 bindings

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018679#comment-16018679
 ] 

ASF GitHub Bot commented on MAHOUT-1795:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/179
  
hey @mikekap sorry I missed this- we changed the travis yml.  Can you 
rebase off of that.  This is failing on the viennaCL stuff, this is a known 
problem (scala 2.11 not working with viennaCL bindings).  The new travis.yml 
tests for spark 1.6/scala 2.10, spark 2.0/scala 2.11, spark 2.1/scala 2.11. 

But the scala 2.11's aren't tested with viennaCL. (only scala 2.10)

this should fix your build issue, and if you woundn't mind update the 
travis yml to utilize your profiles. 


> Release Scala 2.11 bindings
> ---
>
> Key: MAHOUT-1795
> URL: https://issues.apache.org/jira/browse/MAHOUT-1795
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Mike Kaplinskiy
> Fix For: 1.0.0
>
> Attachments: patch.diff
>
>
> It would be nice to ship scala 2.11 bindings for mahout-math/mahout-spark. 
> (I'm not sure of other users, but mahout-shell isn't nearly at the top of my 
> list here).
> It looks simple enough for those two - the attached patch is a 
> proof-of-concept to compile (and pass all tests) under scala 2.11. I'm not 
> sure what the proper way to do this is, but it doesn't look too daunting. 
> (Famous last words?)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017051#comment-16017051
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


Github user AdityaAS commented on the issue:

https://github.com/apache/mahout/pull/321
  
@rawkintrevo  I changed the .travis.yml file and pushed it.. I thought I'd 
be able to squash the commits on github but haven't found how to. Would really 
appreciate some help. 


> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016907#comment-16016907
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/321
  
Hey @AdityaAS thanks for the contribution. 

if you wouldn't mind, please also update `.travis.yml` line 37 adds 
`-Phadoop2` to all profiles. If this works as expected, that should no longer 
be necessary. 




> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016901#comment-16016901
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/300
  
sorry for delay @dustinvanstee 

I'm still not in love with moving all of the summary string generation to 
one function- but I think really we should re think the entire thing and try to 
do as much as possible in one pass. 

This however would be a separate JIRA. 

lgtm unless any further comments


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1973) When building profiles conditionally (say Flink, Viennacl) a hadoop.version related error occurs. Need to check if conditional building of other modules also has this

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016538#comment-16016538
 ] 

ASF GitHub Bot commented on MAHOUT-1973:


GitHub user AdityaAS opened a pull request:

https://github.com/apache/mahout/pull/321

MAHOUT-1973

[BF] Bug Fix
Fixed the hadoop2 related error mentioned in issue MAHOUT-1973

### Purpose of PR:
Please give a short description of what this PR is for.


### Important ToDos
Please mark each with an "x"
- [ ] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [ ] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should 
be made?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AdityaAS/mahout MAHOUT-1973

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #321


commit 21754e154fa91b321c3f33afbffe468d63e3cbf6
Author: AdityaAS 
Date:   2017-05-18T21:58:31Z

[BF] Bug Fix
Fixed the hadoop2 related error mentioned in issue MAHOUT-1973




> When building profiles conditionally (say Flink, Viennacl) a hadoop.version 
> related error occurs. Need to check if conditional building of other modules 
> also has this error and fix the issue.
> ---
>
> Key: MAHOUT-1973
> URL: https://issues.apache.org/jira/browse/MAHOUT-1973
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Reporter: Aditya AS
>Assignee: Aditya AS
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1983) Clean up Stubs before launching

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009209#comment-16009209
 ] 

ASF GitHub Bot commented on MAHOUT-1983:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/317


> Clean up Stubs before launching
> ---
>
> Key: MAHOUT-1983
> URL: https://issues.apache.org/jira/browse/MAHOUT-1983
> Project: Mahout
>  Issue Type: Improvement
>  Components: website
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>  Labels: beginner
>
> There are many stubs of pages 'that would be nice' but haven't materialized 
> including 
> website/docs/native-solvers (need seperate JIRA, as these are high priority 
> documentation that needs to be produced)
> links in nav-bar to non-existent page w tutorials on creating own distributed 
> backend and native solver (also move this to JIRA)
> comb through rest of site looking for TODO and stub pages- remove / clean up 
> where appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004053#comment-16004053
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/318
  
@nsakharnykh @pat @rawkintrevo FYI `Sparse Sparse` vlaues are correct, 
`dense dense` is implemented but untested. 


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003982#comment-16003982
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/318
  
need to rebase


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002659#comment-16002659
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


GitHub user andrewpalumbo opened a pull request:

https://github.com/apache/mahout/pull/318

[WIP]MAHOUT-1974 (dense cuda multiplication)

### Purpose of PR:
Please give a short description of what this PR is for.


### Important ToDos
Please mark each with an "x"
- [x ] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/MAHOUT/]
- [x ] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [ ] Created unit tests where appropriate
- [ ] Added licenses correct on newly added files
- [ ] Assigned JIRA to self
- [ ] Added documentation in scala docs/java docs, and to website
- [ ] Successfully built and ran all unit tests, verified that all tests 
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should 
be made?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andrewpalumbo/mahout MAHOUT-1974

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #318


commit 9706bb88f3e21ddb910864c85f9d859f9d73708d
Author: Nikolai Sakharnykh 
Date:   2017-03-27T19:59:49Z

Initial version of CUDA bindings using JCuda

commit ab5e6353cc4abc5ef086bd4326d26e9c909c572f
Author: Andrew Palumbo 
Date:   2017-03-30T04:17:59Z

[WIP]Quick unit test benchmarks.. have not installed cusparse library yet

commit eaedfceb5378655b5a1a3edfa22b82aaebf7a71c
Author: Andrew Palumbo 
Date:   2017-04-06T03:10:32Z

Fix parameter name in comments

commit 0d0b4e69bdcc28cd203a35ad608e0dbafe93f7ca
Author: Andrew Palumbo 
Date:   2017-04-06T09:22:52Z

Added test to read env variables:

andy@micheal:~/sandbox/mahout_cuda/cuda$ export SIZE_N=5000
andy@micheal:~/sandbox/mahout_cuda/cuda$ export SIZE_M=5000
andy@micheal:~/sandbox/mahout_cuda/cuda$ export SIZE_S=5000
andy@micheal:~/sandbox/mahout_cuda/cuda$ export DENSITY=.2
andy@micheal:~/sandbox/mahout_cuda/cuda$ export NUM_RUNS=2
andy@micheal:~/sandbox/mahout_cuda/cuda$ export SEED=1234

commit b06678d0dc08b176863e311da59a869c4899974b
Author: Andrew Palumbo 
Date:   2017-04-06T09:27:47Z

add  default run size (and a timer)

commit 2cfbf75968fccded1350b7d297bc4195d0034399
Author: Andrew Palumbo 
Date:   2017-04-06T15:09:34Z

Fix error in hard coded unit test

commit 35c540e4eebadfa11f761bc0c61e97db48e840ea
Author: Andrew Palumbo 
Date:   2017-04-06T15:48:25Z

Change geometry of test vars for a faster run.

commit 9cc58a6c8495dd090abbc3609ffcfe5149c59c43
Author: Andrew Palumbo 
Date:   2017-04-06T17:30:52Z

add in some verbosity for cuda mmul test

commit dd561bc577d35b3e30f871b705887af3105f843c
Author: Andrew Palumbo 
Date:   2017-04-06T18:09:51Z

Cosmetic changes to unit tests

commit cdb6ca002c78f466db09bf9321e070c3546294c9
Author: Andrew Palumbo 
Date:   2017-04-06T18:11:11Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/mahout 
into AP-UNIT-TEST

commit e72053df98fc8281952d6fd108696daa5d62afe6
Author: Andrew Palumbo 
Date:   2017-04-06T18:22:43Z

cosmetic change for user defined variable run

commit 72bbf131f33dfd84cfbd5478004405dfffc5a966
Author: Andrew Palumbo 
Date:   2017-04-20T04:03:17Z

Supply default environment settings for tests.

commit 68e8400fae4d3487f93da8b085e68f4d55bf1e07
Author: Nikolai Sakharnykh 
Date:   2017-04-25T19:20:46Z

Enable exceptions for JCuda libraries

commit ec686e17ca6ca2fb6b26a6ae4e4e8c4fbe027f64
Author: Andrew Palumbo 
Date:   2017-04-27T18:16:22Z

Merge branch 'mahout-1974' of https://github.com/nsakharnykh/mahout into 
MAHOUT-1974

commit eaddbf06a19b8f347d68756b0f8effe54fd39291
Author: Andrew Palumbo 
Date:   2017-04-27T04:43:25Z

[WIP][nocompile] begining of DenseMatrixem and Dense Dense MMul. Likely 
ending branch here

commit 808660d19dcba0b1d1bd8e6f13ed466821fc0196
Author: Andrew Palumbo 
Date:   2017-05-01T04:22:49Z

[WIP][nocompile] out of time tonight.  Need to consider wheather JCUDA 
needs to repacked mahout in-core matrices (row-major) as column major per the 
wrapped call to NVIDIA cublasDgemm operation.  The fact that cusparse uses CSR 
rather than CSC is somewhat confusing in this ca

[jira] [Commented] (MAHOUT-1983) Clean up Stubs before launching

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001516#comment-16001516
 ] 

ASF GitHub Bot commented on MAHOUT-1983:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/317

Mahout 1984

### Purpose of PR:
Please give a short description of what this PR is for.

This PR establishes prodedure for pushing to svn for staging.

Also addresses
MAHOUT-1983 Clean up stubs
and MAHOUT-1985 add page of upcoming talks


### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where  
is the JIRA number.
- [x] Created unit tests where appropriate
- [x] Added licenses correct on newly added files
- [x] Assigned JIRA to self
- [x] Added documentation in scala docs/java docs, and to website
- [x] Successfully built and ran all unit tests, verified that all tests 
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should 
be made?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1984

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #317


commit f07ce114b4aff8df5c0773e3d328bff7559ac7f9
Author: rawkintrevo 
Date:   2017-05-07T20:17:00Z

MAHOUT-1979 Remove delelop branch references

commit 17bfce94c228a9282ecabbc33d050177e4e0bbc9
Author: rawkintrevo 
Date:   2017-05-08T13:47:03Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/mahout

commit ecddd000e865281483927aaa9ebf7db5c4389fad
Author: rawkintrevo 
Date:   2017-05-08T20:54:35Z

MAHOUT-1984 Establish Website Staging Procedure




> Clean up Stubs before launching
> ---
>
> Key: MAHOUT-1983
> URL: https://issues.apache.org/jira/browse/MAHOUT-1983
> Project: Mahout
>  Issue Type: Improvement
>  Components: website
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>  Labels: beginner
>
> There are many stubs of pages 'that would be nice' but haven't materialized 
> including 
> website/docs/native-solvers (need seperate JIRA, as these are high priority 
> documentation that needs to be produced)
> links in nav-bar to non-existent page w tutorials on creating own distributed 
> backend and native solver (also move this to JIRA)
> comb through rest of site looking for TODO and stub pages- remove / clean up 
> where appropriate.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000195#comment-16000195
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
@rawkintrevo I asked @nsakharnykh  to just go ahead and push this to the 
mahout/CUDA branch,  since he's already up at GTC, and we're pushing this 
through as quickly as possible, and has spotty time to do this. I will 
immediately open up a [WIP] PR from my  
https://github.com/andrewpalumbo/mahout/tree/MAHOUT-1974/cuda  branch (on top 
of his) and will fill out the md from there. 


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000146#comment-16000146
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/310
  
looking awesome @nsakharnykh @andrewpalumbo 

Before merging, don't forget to fill out

https://github.com/apache/mahout/blob/master/website/docs/native-solvers/cuda.md



> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1980) Create Tutorial for Contributing Algorithms

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000113#comment-16000113
 ] 

ASF GitHub Bot commented on MAHOUT-1980:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/316


> Create Tutorial for Contributing Algorithms
> ---
>
> Key: MAHOUT-1980
> URL: https://issues.apache.org/jira/browse/MAHOUT-1980
> Project: Mahout
>  Issue Type: Improvement
>  Components: website
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> Make a walk through explaining how to contribute an algorithm in a way that 
> is consistent with the new 'algorithms' framework.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1980) Create Tutorial for Contributing Algorithms

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000112#comment-16000112
 ] 

ASF GitHub Bot commented on MAHOUT-1980:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/316

MAHOUT-1980 Add Tutorial for Contributing Algorithms

### Purpose of PR:
Please give a short description of what this PR is for.

A tutorial for new users wishing to contribute an algorithm.

### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where 
is the JIRA number.
- [x] Created unit tests where appropriate
- [x] Added licenses correct on newly added files
- [x] Assigned JIRA to self
- [x] Added documentation in scala docs/java docs, (and website once that
is merged to dev)
- [x] Successfully built and ran all unit tests, verified that all tests
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Oh by the way, does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should 
be made?
No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1980

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/316.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #316


commit 42e10d6829384a54581861c9dff1b470b72ec6e9
Author: rawkintrevo 
Date:   2017-05-07T23:04:12Z

MAHOUT-1980 Tutorial for contributing Algos

MAHOUT-1979 Remove references to develop branch




> Create Tutorial for Contributing Algorithms
> ---
>
> Key: MAHOUT-1980
> URL: https://issues.apache.org/jira/browse/MAHOUT-1980
> Project: Mahout
>  Issue Type: Improvement
>  Components: website
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> Make a walk through explaining how to contribute an algorithm in a way that 
> is consistent with the new 'algorithms' framework.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1979) Remove references to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000108#comment-16000108
 ] 

ASF GitHub Bot commented on MAHOUT-1979:


Github user rawkintrevo closed the pull request at:

https://github.com/apache/mahout/pull/315


> Remove references to develop branch
> ---
>
> Key: MAHOUT-1979
> URL: https://issues.apache.org/jira/browse/MAHOUT-1979
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> There are references to a develop branch on the (git hub based) website, and 
> in the PR template.
> Remove these



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000106#comment-16000106
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
Great, thanks.  I figured you were there, and very busy, I'll keep working 
on my end, and there should be no (or few conflicts)..  no rush, since my 
branch is based off of yours.


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000105#comment-16000105
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user nsakharnykh commented on the issue:

https://github.com/apache/mahout/pull/310
  
@andrewpalumbo Ok, sounds good. I'll try to push what I have as soon as I 
have some time in front of my laptop. I'm currently at GTC so my schedule is a 
bit fragmented.


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1699#comment-1699
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
@nsakharnykh https://github.com/andrewpalumbo/mahout/tree/MAHOUT-1974/cuda 
^^



> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1698#comment-1698
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
@nsakharnykh I have my MAHOUT-1974 branch that is almost complete with 
dense, etc (less the column major issues.  We'd discussed just making a PR 
against this. but It may be easiest if you just went ahead and pushed this to 
MAHOUT/CUDA, and then I'll make a PR against that, which will be public so that 
others may comment on it. 


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1694#comment-1694
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user nsakharnykh commented on a diff in the pull request:

https://github.com/apache/mahout/pull/310#discussion_r115155451
  
--- Diff: cuda/pom.xml ---
@@ -0,0 +1,251 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+
+  
+org.apache.mahout
+mahout
+0.13.0-SNAPSHOT
--- End diff --

Done


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1979) Remove references to develop branch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1642#comment-1642
 ] 

ASF GitHub Bot commented on MAHOUT-1979:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/315

MAHOUT-1979 Remove delelop branch references

### Purpose of PR:
Please give a short description of what this PR is for.
Removing references to "develop" branch

### Important ToDos
Please mark each with an "x"
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where 
is the JIRA number.
- [x] Created unit tests where appropriate
- [x] Added licenses correct on newly added files
- [x] Assigned JIRA to self
- [x] Added documentation in scala docs/java docs, (and website once that
is merged to dev)
- [x] Successfully built and ran all unit tests, verified that all tests
pass locally.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Oh by the way, does this change break earlier versions?
No
Is this the beginning of a larger project for which a feature branch should 
be made?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1979

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #315


commit f07ce114b4aff8df5c0773e3d328bff7559ac7f9
Author: rawkintrevo 
Date:   2017-05-07T20:17:00Z

MAHOUT-1979 Remove delelop branch references




> Remove references to develop branch
> ---
>
> Key: MAHOUT-1979
> URL: https://issues.apache.org/jira/browse/MAHOUT-1979
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> There are references to a develop branch on the (git hub based) website, and 
> in the PR template.
> Remove these



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999628#comment-15999628
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/310#discussion_r115131284
  
--- Diff: cuda/pom.xml ---
@@ -0,0 +1,251 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
+  4.0.0
+
+  
+org.apache.mahout
+mahout
+0.13.0-SNAPSHOT
--- End diff --

needs to be `0.13.1-SNAPSHOT`


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1976) Add Canopy Clustering Algorithm

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999581#comment-15999581
 ] 

ASF GitHub Bot commented on MAHOUT-1976:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/314

MAHOUT-1976 Add CanopyClustering

MAHOUT-1976 Add Canopy Clustering

### Purpose of PR:
1 . Primarily, this PR adds CanopyClustering to Algorithms Framework.
2. This PR introduces the "clustering" framework of the algorithms framework
3. this PR introduces distance metrics and ports two metrics from the old 
MR code base. 

### Important ToDos
Please mark each with an "x"
- [x] Opening PR against `develop` NOT `master` (OR `feature-name` if this 
is part of an ongoing feature development). **need to delete this requirement, 
JIRA needed**
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where 
is the JIRA number.
- [x] Created unit tests where appropriate
- [x] Added licenses correct on newly added files
- [x] Assigned JIRA to self
- [x] Added documentation in scala docs/java docs, (and website once that
is merged to dev)
- [x] Successfully built and ran all unit tests, verified that all tests
pass locally.


Oh by the way, does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should 
be made?
No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1976

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/314.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #314


commit 7f18775afae639c1b291fb0273d92dc71de24884
Author: rawkintrevo 
Date:   2017-05-04T14:25:42Z

MAHOUT-1976 Add CanopyClustering

MAHOUT-1976 Add Canopy Clustering

forgot unit tests




> Add Canopy Clustering Algorithm
> ---
>
> Key: MAHOUT-1976
> URL: https://issues.apache.org/jira/browse/MAHOUT-1976
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.13.2
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> Primarily, we need to lay out the clustering section of the Algorihtms 
> Framework.
> The Canopy Clustering Algorithm is very simple and yet very useful as a 
> preprocessing step for more advanced clustering algorithms such as KMeans and 
> Hierarchical Clustering. 
> https://en.wikipedia.org/wiki/Canopy_clustering_algorithm
> The majority of the "work" on this PR will be creating the framework. 
> It is also one of the Legacy MR algorithms that would be nice to port.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996884#comment-15996884
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user nsakharnykh commented on the issue:

https://github.com/apache/mahout/pull/310
  
@andrewpalumbo regarding column-major: yes, this is the default mode for 
CUBLAS, sorry I think I didn't mention it in my original email. There are a 
couple options we can exercise here. 1. We can use transposed versions of 
`gemm` routines if the input matrices are row-major. I think the output matrix 
will be always column-major so we'll have to transpose it by using `geam` if we 
want to keep it in a different format. 2. We can also keep the dense matrices 
in column-major format on the GPU and move between `csc` and `csr` formats for 
sparse matrices by using CUSPARSE conversion routines like `csr2csc`. There are 
also existing API functions in CUSPARSE to convert sparse to dense `csr2dense` 
and the other way around `dense2csr`. I think we should try to use the 
available conversion APIs from CUSPARSE as much as possible to avoid writing 
this on our own.


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995564#comment-15995564
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/300
  
Big job @dustinvanstee ! Looking awesome. Made a few more comments, you're 
getting pretty close. 

Thanks again!


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995558#comment-15995558
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114641008
  
--- Diff: 
math-scala/src/test/scala/org/apache/mahout/math/algorithms/RegressionTestsSuiteBase.scala
 ---
@@ -106,4 +106,83 @@ trait RegressionTestsSuiteBase extends 
DistributedMahoutSuite with Matchers {
 (myAnswer - correctAnswer) should be < epsilon
   }
 
+  test("OLS w/Ftest and Ttest validation") {
+
--- End diff --

actually this all can be moved to the "fitness tests" , use the R-prototype 
in there and just confirm the F-test, should be in good shape.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995560#comment-15995560
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114641056
  
--- Diff: 
math-scala/src/test/scala/org/apache/mahout/math/algorithms/RegressionTestsSuiteBase.scala
 ---
@@ -106,4 +106,83 @@ trait RegressionTestsSuiteBase extends 
DistributedMahoutSuite with Matchers {
 (myAnswer - correctAnswer) should be < epsilon
   }
 
+  test("OLS w/Ftest and Ttest validation") {
+
--- End diff --

e.g. you don't need these separate tests.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1599#comment-1599
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114640575
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
 val mse = residuals.assign(SQUARE).sum / residuals.nrow
 model.mse = mse
 model.testResults += ('mse -> mse)
 model.summary += s"\nMean Squared Error: ${mse}"
 model
   }
+
+  // https://en.wikipedia.org/wiki/
+  def FTest[R[K] <: RegressorModel[K], K](model: R[K],  drmFeatures: 
DrmLike[K], drmTarget: DrmLike[K]): R[K] = {
+
+// This is the residual sum of squares for just the intercept
+//println(" drmTarget.ncol) = " +  drmTarget.ncol)
+val interceptCol = drmTarget.ncol - 1
+//val targetMean: Double = drmTarget
+val targetMean: Double = drmTarget.colMeans().get(0)
+
+val rssint: Double = ((drmTarget - targetMean  ).t %*% (drmTarget - 
targetMean)).zSum()
+// ete above is the RSS for the calculated model
+
+//println(" model.beta(0) = " +  model.beta(0))
+//println(" model.beta(interceptCol) = " +  model.beta(interceptCol))
+//println("rssint = " + rssint)
+//println("rssmod = " + rssmod)
+
+val groupDof = drmFeatures.ncol-1
+val fScore = ((rssint - model.rss) / groupDof) / ( model.rss / 
(drmFeatures.nrow - groupDof- 1 ))
--- End diff --

this line is the crux of it- Looks good, but I'll feel better if you can 
verify with an R-prototype


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995540#comment-15995540
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114639405
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
 val mse = residuals.assign(SQUARE).sum / residuals.nrow
 model.mse = mse
 model.testResults += ('mse -> mse)
 model.summary += s"\nMean Squared Error: ${mse}"
 model
   }
+
+  // https://en.wikipedia.org/wiki/
+  def FTest[R[K] <: RegressorModel[K], K](model: R[K],  drmFeatures: 
DrmLike[K], drmTarget: DrmLike[K]): R[K] = {
+
+// This is the residual sum of squares for just the intercept
+//println(" drmTarget.ncol) = " +  drmTarget.ncol)
+val interceptCol = drmTarget.ncol - 1
+//val targetMean: Double = drmTarget
+val targetMean: Double = drmTarget.colMeans().get(0)
+
+val rssint: Double = ((drmTarget - targetMean  ).t %*% (drmTarget - 
targetMean)).zSum()
+// ete above is the RSS for the calculated model
+
+//println(" model.beta(0) = " +  model.beta(0))
+//println(" model.beta(interceptCol) = " +  model.beta(interceptCol))
+//println("rssint = " + rssint)
+//println("rssmod = " + rssmod)
+
+val groupDof = drmFeatures.ncol-1
--- End diff --

replace this with `model.degreesFreedom` (and refactor to not need the 
features in the signature)


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995538#comment-15995538
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114639185
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
 val mse = residuals.assign(SQUARE).sum / residuals.nrow
 model.mse = mse
 model.testResults += ('mse -> mse)
 model.summary += s"\nMean Squared Error: ${mse}"
 model
   }
+
+  // https://en.wikipedia.org/wiki/
+  def FTest[R[K] <: RegressorModel[K], K](model: R[K],  drmFeatures: 
DrmLike[K], drmTarget: DrmLike[K]): R[K] = {
+
+// This is the residual sum of squares for just the intercept
+//println(" drmTarget.ncol) = " +  drmTarget.ncol)
+val interceptCol = drmTarget.ncol - 1
--- End diff --

In addition- it seems that this is only used in some print statements that 
need to be deleted anyway. Probably can drop this line all together


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995536#comment-15995536
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114638847
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/RegressorModel.scala
 ---
@@ -30,6 +30,9 @@ trait RegressorModel[K] extends SupervisedModel[K] {
   // Common Applicable Tests- here only for convenience.
   var mse: Double = _
   var r2: Double = _
+  var fpval: Double = _
+  var rss:Double = -.0
--- End diff --

Sure there is a reason, but why are you initializing to -.0 instead of 
_ ?


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995532#comment-15995532
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114638688
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/OrdinaryLeastSquaresModel.scala
 ---
@@ -55,6 +55,8 @@ class OrdinaryLeastSquares[K] extends 
LinearRegressorFitter[K] {
 }
 
 var X = drmFeatures
+
+// TODO : move intercept betas to the first column, not the last 
column ??
--- End diff --

Start a JIRA, don't introduce a comment into the code in a file you're 
otherwise not touching ;)


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995530#comment-15995530
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114638453
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/LinearRegressorModel.scala
 ---
@@ -54,46 +58,72 @@ trait LinearRegressorFitter[K] extends 
RegressorFitter[K] {
 addIntercept = hyperparameters.asInstanceOf[Map[Symbol, 
Boolean]].getOrElse('addIntercept, true)
   }
 
+
   def calculateStandardError[M[K] <: LinearRegressorModel[K]](X: 
DrmLike[K],
  drmTarget: DrmLike[K],
  drmXtXinv: Matrix,
  model: M[K]): M[K] = {
 import org.apache.mahout.math.function.Functions.SQRT
 import org.apache.mahout.math.scalabindings.MahoutCollections._
-var modelOut = model
+
 val yhat = X %*% model.beta
 val residuals = drmTarget - yhat
-val ete = (residuals.t %*% residuals).collect // 1x1
+
+// Setting modelOut.rss
+// Changed name from ete, to rssModel.  This is residual sum of 
squares for model of yhat vs y
+var modelOut = calculateResidualSumOfSquares(model,residuals)
+
 val n = drmTarget.nrow
 val k = safeToNonNegInt(X.ncol)
 val invDegFreedomKindOf = 1.0 / (n - k)
-val varCovarMatrix = invDegFreedomKindOf * ete(0,0) * drmXtXinv
+val varCovarMatrix = invDegFreedomKindOf * modelOut.rss * drmXtXinv
 val se = varCovarMatrix.viewDiagonal.assign(SQRT)
 val tScore = model.beta / se
-val tDist = new 
org.apache.commons.math3.distribution.TDistribution(n-k)
+val tDist = new TDistribution(n-k)
+
 val pval = dvec(tScore.toArray.map(t => 2 * (1.0 - 
tDist.cumulativeProbability(Math.abs(t))) ))
+
 // ^^ TODO bug in this calculation- fix and add test
 //degreesFreedom = k
-
-
 modelOut.se = se
 modelOut.tScore = tScore
 modelOut.pval = pval
-modelOut.degreesFreedom = X.ncol
-modelOut.summary = generateSummaryString(modelOut)
+// for degrees of freedom, dont count the intercept term that was added
+modelOut.degreesFreedom = X.ncol - 1
+
+modelOut.trainingExamples = n.toInt
+
 if (calcCommonStatistics){
-  modelOut = calculateCommonStatistics(modelOut, drmTarget, residuals)
+  modelOut = calculateCommonStatistics(modelOut, X, drmTarget, 
residuals)
 }
+
+// Let Statistics Get Calculated prior to assigning the summary
+modelOut.summary = generateSummaryString(modelOut)
+
 modelOut
   }
 
+  // Since rss is needed for multiple test statistics, use this function 
to cache this value
+  def calculateResidualSumOfSquares[M[K] <: 
LinearRegressorModel[K]](model: M[K],residuals: DrmLike[K]) : M[K] ={
--- End diff --

As a stylistic point and because other non-linear regressors may/will need 
this- please move to `FitnessTests`


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995519#comment-15995519
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114637027
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/LinearRegressorModel.scala
 ---
@@ -54,46 +58,72 @@ trait LinearRegressorFitter[K] extends 
RegressorFitter[K] {
 addIntercept = hyperparameters.asInstanceOf[Map[Symbol, 
Boolean]].getOrElse('addIntercept, true)
   }
 
+
   def calculateStandardError[M[K] <: LinearRegressorModel[K]](X: 
DrmLike[K],
  drmTarget: DrmLike[K],
  drmXtXinv: Matrix,
  model: M[K]): M[K] = {
 import org.apache.mahout.math.function.Functions.SQRT
 import org.apache.mahout.math.scalabindings.MahoutCollections._
-var modelOut = model
+
 val yhat = X %*% model.beta
 val residuals = drmTarget - yhat
-val ete = (residuals.t %*% residuals).collect // 1x1
+
+// Setting modelOut.rss
+// Changed name from ete, to rssModel.  This is residual sum of 
squares for model of yhat vs y
+var modelOut = calculateResidualSumOfSquares(model,residuals)
+
 val n = drmTarget.nrow
 val k = safeToNonNegInt(X.ncol)
 val invDegFreedomKindOf = 1.0 / (n - k)
-val varCovarMatrix = invDegFreedomKindOf * ete(0,0) * drmXtXinv
+val varCovarMatrix = invDegFreedomKindOf * modelOut.rss * drmXtXinv
 val se = varCovarMatrix.viewDiagonal.assign(SQRT)
 val tScore = model.beta / se
-val tDist = new 
org.apache.commons.math3.distribution.TDistribution(n-k)
+val tDist = new TDistribution(n-k)
+
 val pval = dvec(tScore.toArray.map(t => 2 * (1.0 - 
tDist.cumulativeProbability(Math.abs(t))) ))
+
 // ^^ TODO bug in this calculation- fix and add test
 //degreesFreedom = k
-
-
 modelOut.se = se
 modelOut.tScore = tScore
 modelOut.pval = pval
-modelOut.degreesFreedom = X.ncol
-modelOut.summary = generateSummaryString(modelOut)
+// for degrees of freedom, dont count the intercept term that was added
+modelOut.degreesFreedom = X.ncol - 1
+
+modelOut.trainingExamples = n.toInt
+
 if (calcCommonStatistics){
-  modelOut = calculateCommonStatistics(modelOut, drmTarget, residuals)
+  modelOut = calculateCommonStatistics(modelOut, X, drmTarget, 
residuals)
--- End diff --

OK- you changed this to take `X` but the only thing you use X for is to 
calculate teh d.o.f. and `model.trainingExamples` which are already included in 
teh model (you just added them).  I would refactor this so X isn't a parameter.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995513#comment-15995513
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114635749
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/LinearRegressorModel.scala
 ---
@@ -54,46 +58,72 @@ trait LinearRegressorFitter[K] extends 
RegressorFitter[K] {
 addIntercept = hyperparameters.asInstanceOf[Map[Symbol, 
Boolean]].getOrElse('addIntercept, true)
   }
 
+
   def calculateStandardError[M[K] <: LinearRegressorModel[K]](X: 
DrmLike[K],
  drmTarget: DrmLike[K],
  drmXtXinv: Matrix,
  model: M[K]): M[K] = {
 import org.apache.mahout.math.function.Functions.SQRT
 import org.apache.mahout.math.scalabindings.MahoutCollections._
-var modelOut = model
+
 val yhat = X %*% model.beta
 val residuals = drmTarget - yhat
-val ete = (residuals.t %*% residuals).collect // 1x1
+
+// Setting modelOut.rss
+// Changed name from ete, to rssModel.  This is residual sum of 
squares for model of yhat vs y
+var modelOut = calculateResidualSumOfSquares(model,residuals)
+
 val n = drmTarget.nrow
 val k = safeToNonNegInt(X.ncol)
 val invDegFreedomKindOf = 1.0 / (n - k)
-val varCovarMatrix = invDegFreedomKindOf * ete(0,0) * drmXtXinv
+val varCovarMatrix = invDegFreedomKindOf * modelOut.rss * drmXtXinv
 val se = varCovarMatrix.viewDiagonal.assign(SQRT)
 val tScore = model.beta / se
-val tDist = new 
org.apache.commons.math3.distribution.TDistribution(n-k)
+val tDist = new TDistribution(n-k)
+
 val pval = dvec(tScore.toArray.map(t => 2 * (1.0 - 
tDist.cumulativeProbability(Math.abs(t))) ))
+
 // ^^ TODO bug in this calculation- fix and add test
 //degreesFreedom = k
-
-
 modelOut.se = se
 modelOut.tScore = tScore
 modelOut.pval = pval
-modelOut.degreesFreedom = X.ncol
-modelOut.summary = generateSummaryString(modelOut)
+// for degrees of freedom, dont count the intercept term that was added
+modelOut.degreesFreedom = X.ncol - 1
+
+modelOut.trainingExamples = n.toInt
--- End diff --

This is dangerous- could be to big of a number to fit in an Int. 
`safeToNonNegInt(residuals.nrow)`


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995506#comment-15995506
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114635070
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/LinearRegressorModel.scala
 ---
@@ -54,46 +58,72 @@ trait LinearRegressorFitter[K] extends 
RegressorFitter[K] {
 addIntercept = hyperparameters.asInstanceOf[Map[Symbol, 
Boolean]].getOrElse('addIntercept, true)
   }
 
+
   def calculateStandardError[M[K] <: LinearRegressorModel[K]](X: 
DrmLike[K],
  drmTarget: DrmLike[K],
  drmXtXinv: Matrix,
  model: M[K]): M[K] = {
 import org.apache.mahout.math.function.Functions.SQRT
 import org.apache.mahout.math.scalabindings.MahoutCollections._
-var modelOut = model
+
 val yhat = X %*% model.beta
 val residuals = drmTarget - yhat
-val ete = (residuals.t %*% residuals).collect // 1x1
+
+// Setting modelOut.rss
+// Changed name from ete, to rssModel.  This is residual sum of 
squares for model of yhat vs y
+var modelOut = calculateResidualSumOfSquares(model,residuals)
+
 val n = drmTarget.nrow
 val k = safeToNonNegInt(X.ncol)
 val invDegFreedomKindOf = 1.0 / (n - k)
-val varCovarMatrix = invDegFreedomKindOf * ete(0,0) * drmXtXinv
+val varCovarMatrix = invDegFreedomKindOf * modelOut.rss * drmXtXinv
 val se = varCovarMatrix.viewDiagonal.assign(SQRT)
 val tScore = model.beta / se
-val tDist = new 
org.apache.commons.math3.distribution.TDistribution(n-k)
+val tDist = new TDistribution(n-k)
+
 val pval = dvec(tScore.toArray.map(t => 2 * (1.0 - 
tDist.cumulativeProbability(Math.abs(t))) ))
+
 // ^^ TODO bug in this calculation- fix and add test
 //degreesFreedom = k
-
-
 modelOut.se = se
 modelOut.tScore = tScore
 modelOut.pval = pval
-modelOut.degreesFreedom = X.ncol
-modelOut.summary = generateSummaryString(modelOut)
+// for degrees of freedom, dont count the intercept term that was added
+modelOut.degreesFreedom = X.ncol - 1
--- End diff --

you're correct you but you need to check if a intercept was added- `if 
(model.addIntercept) {`


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995471#comment-15995471
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114629899
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
 val mse = residuals.assign(SQUARE).sum / residuals.nrow
 model.mse = mse
 model.testResults += ('mse -> mse)
 model.summary += s"\nMean Squared Error: ${mse}"
 model
   }
+
+  // https://en.wikipedia.org/wiki/
+  def FTest[R[K] <: RegressorModel[K], K](model: R[K],  drmFeatures: 
DrmLike[K], drmTarget: DrmLike[K]): R[K] = {
+
+// This is the residual sum of squares for just the intercept
+//println(" drmTarget.ncol) = " +  drmTarget.ncol)
+val interceptCol = drmTarget.ncol - 1
--- End diff --

should this be `drmFeatures.ncol`?


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995465#comment-15995465
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114629530
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
 val mse = residuals.assign(SQUARE).sum / residuals.nrow
 model.mse = mse
 model.testResults += ('mse -> mse)
 model.summary += s"\nMean Squared Error: ${mse}"
 model
   }
+
+  // https://en.wikipedia.org/wiki/
+  def FTest[R[K] <: RegressorModel[K], K](model: R[K],  drmFeatures: 
DrmLike[K], drmTarget: DrmLike[K]): R[K] = {
+
+// This is the residual sum of squares for just the intercept
+//println(" drmTarget.ncol) = " +  drmTarget.ncol)
+val interceptCol = drmTarget.ncol - 1
+//val targetMean: Double = drmTarget
+val targetMean: Double = drmTarget.colMeans().get(0)
+
+val rssint: Double = ((drmTarget - targetMean  ).t %*% (drmTarget - 
targetMean)).zSum()
+// ete above is the RSS for the calculated model
+
+//println(" model.beta(0) = " +  model.beta(0))
+//println(" model.beta(interceptCol) = " +  model.beta(interceptCol))
+//println("rssint = " + rssint)
+//println("rssmod = " + rssmod)
--- End diff --

get rid of these.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995463#comment-15995463
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114629177
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
--- End diff --

you may be right, why do you think this?


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995462#comment-15995462
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114629137
  
--- Diff: 
math-scala/src/main/scala/org/apache/mahout/math/algorithms/regression/tests/FittnessTests.scala
 ---
@@ -47,10 +52,44 @@ object FittnessTests {
 
   // https://en.wikipedia.org/wiki/Mean_squared_error
   def MeanSquareError[R[K] <: RegressorModel[K], K](model: R[K], 
residuals: DrmLike[K]): R[K] = {
+// TODO : I think mse denom should be (row - col) ??
 val mse = residuals.assign(SQUARE).sum / residuals.nrow
 model.mse = mse
 model.testResults += ('mse -> mse)
 model.summary += s"\nMean Squared Error: ${mse}"
 model
   }
+
+  // https://en.wikipedia.org/wiki/
--- End diff --

might as well finish out the link.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995457#comment-15995457
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r114628480
  
--- Diff: 
math-scala/src/test/scala/org/apache/mahout/math/algorithms/RegressionTestsSuiteBase.scala
 ---
@@ -106,4 +106,83 @@ trait RegressionTestsSuiteBase extends 
DistributedMahoutSuite with Matchers {
 (myAnswer - correctAnswer) should be < epsilon
   }
 
+  test("OLS w/Ftest and Ttest validation") {
+
--- End diff --

Needs an R prototype


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1953) jars in $MAHOUT_HOME should be deleted on mvn clean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995349#comment-15995349
 ] 

ASF GitHub Bot commented on MAHOUT-1953:


Github user rawkintrevo closed the pull request at:

https://github.com/apache/mahout/pull/312


> jars in $MAHOUT_HOME should be deleted on mvn clean
> ---
>
> Key: MAHOUT-1953
> URL: https://issues.apache.org/jira/browse/MAHOUT-1953
> Project: Mahout
>  Issue Type: Bug
>Reporter: Trevor Grant
> Fix For: 0.13.1
>
>
> MAHOUT-1950 copies jars to $MAHOUT_HOME to be picked up.  
> They should be deleted by mvn clean



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1975) Pull Request Template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995346#comment-15995346
 ] 

ASF GitHub Bot commented on MAHOUT-1975:


Github user rawkintrevo closed the pull request at:

https://github.com/apache/mahout/pull/313


> Pull Request Template
> -
>
> Key: MAHOUT-1975
> URL: https://issues.apache.org/jira/browse/MAHOUT-1975
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>Priority: Minor
> Fix For: 0.13.0, 0.13.1
>
>
> Create a template for guiding new pull requests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1975) Pull Request Template

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991442#comment-15991442
 ] 

ASF GitHub Bot commented on MAHOUT-1975:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/313

MAHOUT-1975 Add PR Template for Github PRs

### Purpose of PR:

This PR adds this slick template to the message box when people open PRs!

### Important ToDos
Please mark each with an "x"
- [x] Opening PR against `develop` NOT `master` (OR `feature-name` if this 
is part of an ongoing feature development).
- [x] A JIRA ticket exists (if not, please create this 
first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
- [x] Title of PR is "MAHOUT- Brief Description of Changes" where 
is the JIRA number.
- [ ] Created unit tests where appropriate **N/A**
- [ ] Added licenses correct on newly added files **N/A** (adding license 
will mess up the template)
- [x] Assigned JIRA to self (almost forgot- thanks template!)
- [ ] Added documentation in scala docs/java docs, (and website once that
is merged to dev) **N/A**
- [ ] Successfully built and ran all unit tests, verified that all tests
pass locally. **N/A** Won't know this is working for sure until it is added 
to master.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT- before the
descriptions- e.g. "MAHOUT- [WIP] Description of Change"

Oh by the way, does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should 
be made?
No- straight to dev

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1975

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/313.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #313






> Pull Request Template
> -
>
> Key: MAHOUT-1975
> URL: https://issues.apache.org/jira/browse/MAHOUT-1975
> Project: Mahout
>  Issue Type: Improvement
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>Priority: Minor
> Fix For: 0.13.0, 0.13.1
>
>
> Create a template for guiding new pull requests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990588#comment-15990588
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
 @nsakharnykh , @rawkintrevo, I ran out of time tonight to finish out 
`dense %*% dense` and `dense %x% sparse`; went down a rabbit hole woth the 
NVIDIA `c` api docs for cusparse.  I noticed that JCuda supported only a single 
`dense dense` dgemm algorithm, with column major-matrices.  Most mahout 
matrices are row-major, but i began considering the `dense sparse` 
multiplication, and was slightly thrown off by what seems to be required `csr` 
compression.  it seems that sparse matrices should be compressed as `csc` since 
the. Anyways I ended up in the LAPACK fortran;  apologies for not finishing it 
up tonight guys, I got off on a long tangent and ran out of time.

I pushed my beginning work up to my MAHOUT-1974 branch.  Nothing really 
worth looking at right now, but I wil' make a PR against this when I get the 
`dense`work together.   

Regardless, I should have at least  a quick n dirty version ready to go 
soon,  while i work out what we'll need for experiments and benchmarking.  We 
can still discuss and consider different SPARK configurations tomorrow with out 
`dense` cases.  but I'd of course like to get this right.  

As I mentioned on the last call we allow a "Sparse" DRM's in-core 
components to be both sparse and dense.  Currently the threshold for conversion 
of a DRM block to be changed from a sparse to a dense matrix is pretty high 
(25% non zero estimate).  In the future we will need to allow the user to set 
the sparsity somehow. 

FYI:

https://github.com/apache/mahout/blob/master/math-scala/src/main/scala/org/apache/mahout/math/scalabindings/package.scala#L431
  


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989285#comment-15989285
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
@nsakharnykh @rawkintrevo I intend to have `dense` hammered out on Sunday.
  


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1949) Create Docker Base IT Framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988937#comment-15988937
 ] 

ASF GitHub Bot commented on MAHOUT-1949:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/296
  
closed JIRA


> Create Docker Base IT Framework
> ---
>
> Key: MAHOUT-1949
> URL: https://issues.apache.org/jira/browse/MAHOUT-1949
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> As we move to multiple spark/scala/native/etc versions we need a more sane 
> method for testings. 
> Many projects use a docker based test env. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1949) Create Docker Base IT Framework

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988938#comment-15988938
 ] 

ASF GitHub Bot commented on MAHOUT-1949:


Github user rawkintrevo closed the pull request at:

https://github.com/apache/mahout/pull/296


> Create Docker Base IT Framework
> ---
>
> Key: MAHOUT-1949
> URL: https://issues.apache.org/jira/browse/MAHOUT-1949
> Project: Mahout
>  Issue Type: Bug
>  Components: build
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
>Assignee: Trevor Grant
>
> As we move to multiple spark/scala/native/etc versions we need a more sane 
> method for testings. 
> Many projects use a docker based test env. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1953) jars in $MAHOUT_HOME should be deleted on mvn clean

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987990#comment-15987990
 ] 

ASF GitHub Bot commented on MAHOUT-1953:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/312

MAHOUT-1953 Delete jars from MAHOUT_HOME

Jars are coppied on `mvn package` to MAHOUT_HOME however, `mvn clean` does 
not delete this packages. 

This corrects that oversite. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1953

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #312


commit f08e5a925c800078732b361727b2395075ff0bbf
Author: rawkintrevo 
Date:   2017-04-28T01:21:20Z

MAHOUT-1953 Delete jars from MAHOUT_HOME




> jars in $MAHOUT_HOME should be deleted on mvn clean
> ---
>
> Key: MAHOUT-1953
> URL: https://issues.apache.org/jira/browse/MAHOUT-1953
> Project: Mahout
>  Issue Type: Bug
>Reporter: Trevor Grant
> Fix For: 0.13.0
>
>
> MAHOUT-1950 copies jars to $MAHOUT_HOME to be picked up.  
> They should be deleted by mvn clean



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987232#comment-15987232
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/310
  
Tests pass on my system: 
```
Mahout JVM Sparse multiplication time: 1914 ms.
Mahout JCuda Sparse multiplication time: 195 ms.
- sparse mmul at geometry of 1000 x 1000 %*% 1000 x 1000 density = .2.  5 
runs
Mahout JVM Sparse multiplication time: 43 ms.
Mahout JCuda Sparse multiplication time: 11 ms.
- sparse mmul at geometry of 1000 x 1000 %*% 1000 x 1000 density = .02.  5 
runs
Mahout JVM Sparse multiplication time: 2 ms.
Mahout JCuda Sparse multiplication time: 1 ms.
- sparse mmul at geometry of 1000 x 1000 %*% 1000 x 1000 density = .002.  5 
runs
UserSetCUDATestSuite:
Mahout JVM Sparse multiplication time: 45 ms.
Mahout JCuda Sparse multiplication time: 10 ms.
User Defined sparse mmul at geometry of 1000 x 1000 %*% 1000 x 1000 density 
= 0.02 3 runs : 10 ms
- User Defined sparse mmul at geometry of 1000 x 1000 %*% 1000 x 1000 
density = 0.02 3 runs 
``` 


> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1974) CUDA support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985918#comment-15985918
 ] 

ASF GitHub Bot commented on MAHOUT-1974:


GitHub user nsakharnykh opened a pull request:

https://github.com/apache/mahout/pull/310

MAHOUT-1974 CUDA support



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nsakharnykh/mahout mahout-1974

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #310


commit 9706bb88f3e21ddb910864c85f9d859f9d73708d
Author: Nikolai Sakharnykh 
Date:   2017-03-27T19:59:49Z

Initial version of CUDA bindings using JCuda

commit ab5e6353cc4abc5ef086bd4326d26e9c909c572f
Author: Andrew Palumbo 
Date:   2017-03-30T04:17:59Z

[WIP]Quick unit test benchmarks.. have not installed cusparse library yet

commit eaedfceb5378655b5a1a3edfa22b82aaebf7a71c
Author: Andrew Palumbo 
Date:   2017-04-06T03:10:32Z

Fix parameter name in comments

commit 0d0b4e69bdcc28cd203a35ad608e0dbafe93f7ca
Author: Andrew Palumbo 
Date:   2017-04-06T09:22:52Z

Added test to read env variables:

andy@micheal:~/sandbox/mahout_cuda/cuda$ export SIZE_N=5000
andy@micheal:~/sandbox/mahout_cuda/cuda$ export SIZE_M=5000
andy@micheal:~/sandbox/mahout_cuda/cuda$ export SIZE_S=5000
andy@micheal:~/sandbox/mahout_cuda/cuda$ export DENSITY=.2
andy@micheal:~/sandbox/mahout_cuda/cuda$ export NUM_RUNS=2
andy@micheal:~/sandbox/mahout_cuda/cuda$ export SEED=1234

commit b06678d0dc08b176863e311da59a869c4899974b
Author: Andrew Palumbo 
Date:   2017-04-06T09:27:47Z

add  default run size (and a timer)

commit 2cfbf75968fccded1350b7d297bc4195d0034399
Author: Andrew Palumbo 
Date:   2017-04-06T15:09:34Z

Fix error in hard coded unit test

commit 35c540e4eebadfa11f761bc0c61e97db48e840ea
Author: Andrew Palumbo 
Date:   2017-04-06T15:48:25Z

Change geometry of test vars for a faster run.

commit 9cc58a6c8495dd090abbc3609ffcfe5149c59c43
Author: Andrew Palumbo 
Date:   2017-04-06T17:30:52Z

add in some verbosity for cuda mmul test

commit dd561bc577d35b3e30f871b705887af3105f843c
Author: Andrew Palumbo 
Date:   2017-04-06T18:09:51Z

Cosmetic changes to unit tests

commit cdb6ca002c78f466db09bf9321e070c3546294c9
Author: Andrew Palumbo 
Date:   2017-04-06T18:11:11Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/mahout 
into AP-UNIT-TEST

commit e72053df98fc8281952d6fd108696daa5d62afe6
Author: Andrew Palumbo 
Date:   2017-04-06T18:22:43Z

cosmetic change for user defined variable run

commit 72bbf131f33dfd84cfbd5478004405dfffc5a966
Author: Andrew Palumbo 
Date:   2017-04-20T04:03:17Z

Supply default environment settings for tests.

commit 68e8400fae4d3487f93da8b085e68f4d55bf1e07
Author: Nikolai Sakharnykh 
Date:   2017-04-25T19:20:46Z

Enable exceptions for JCuda libraries




> CUDA support
> 
>
> Key: MAHOUT-1974
> URL: https://issues.apache.org/jira/browse/MAHOUT-1974
> Project: Mahout
>  Issue Type: New Feature
>Reporter: Nikolay Sakharnykh
>  Labels: features
>
> Implement native CUDA bindings using JCuda



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981549#comment-15981549
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/300
  
this is not really apropos of this PR, but looking through, reminded me 
that we have some a classification stats package in 
https://github.com/apache/mahout/tree/master/math-scala/src/main/scala/org/apache/mahout/classifier/stats.
  There may be some useful code there, that could be refactored into to the new 
framework.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981491#comment-15981491
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/300
  
Just beezing through this again... I would drop 
`spark/src/test/scala/org/apache/mahout/math/algorithms/regression/OlsSparkTestSuite.scala`
 all together.


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1962) Add F-test to Linear Regression Fitness Tests

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981490#comment-15981490
 ] 

ASF GitHub Bot commented on MAHOUT-1962:


Github user rawkintrevo commented on a diff in the pull request:

https://github.com/apache/mahout/pull/300#discussion_r112998796
  
--- Diff: 
spark/src/test/scala/org/apache/mahout/math/algorithms/regression/OlsSparkTestSuite.scala
 ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.mahout.math.algorithms.regression
+
+import org.apache.mahout.math.regression._
+import org.apache.mahout.sparkbindings.test.DistributedSparkSuite
+import org.apache.mahout.test.MahoutSuite
+import org.scalatest.FunSuite
+
+
+class OlsSparkTestSuite extends FunSuite with MahoutSuite with 
DistributedSparkSuite with OrdinaryLeastSquaresTest {
+  // Common tests located in OrdinaryLeastSquaresTest.scala
+  // The test below is common to spark as I created an random RDD for 
larger size
+  test("Simple Medium Model2 - Spark Specific") {
--- End diff --

Never mind- build is failing on this. 

Keep the math tests in the math suite.  They will be tested on spark as 
well as others. 


> Add F-test to Linear Regression  Fitness Tests
> --
>
> Key: MAHOUT-1962
> URL: https://issues.apache.org/jira/browse/MAHOUT-1962
> Project: Mahout
>  Issue Type: Improvement
>  Components: Algorithms
>Affects Versions: 0.12.0, 0.12.1, 0.13.0, 0.12.2
>Reporter: Dustin VanStee
>Priority: Minor
>  Labels: beginner
> Fix For: 0.13.1
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> This update will modify 
> org.apache.mahout.math.algorithms.regression.tests.FittnessTests.scala and 
> add an overall Ftest for significance of one or more parameters being not 
> equal to zero.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1933) Migrate website from CMS to Jekyll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980663#comment-15980663
 ] 

ASF GitHub Bot commented on MAHOUT-1933:


Github user dustinvanstee closed the pull request at:

https://github.com/apache/mahout/pull/304


> Migrate website from CMS to Jekyll
> --
>
> Key: MAHOUT-1933
> URL: https://issues.apache.org/jira/browse/MAHOUT-1933
> Project: Mahout
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
> Fix For: 0.13.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1933) Migrate website from CMS to Jekyll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980466#comment-15980466
 ] 

ASF GitHub Bot commented on MAHOUT-1933:


Github user andrewpalumbo commented on the issue:

https://github.com/apache/mahout/pull/304
  
Yeah I think everybody will have to close their own prs until we get the 
auto close issue sorted out.



Sent from my Verizon Wireless 4G LTE smartphone


 Original message 
From: Trevor Grant 
Date: 04/23/2017 07:44 (GMT-08:00)
To: apache/mahout 
Cc: Andrew Palumbo , Mention 

Subject: Re: [apache/mahout] MAHOUT-1933 (#304)


So this was merged to the website branch. Any ideas how to close the PR, or 
should @dustinvanstee just close it on his 
end?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



> Migrate website from CMS to Jekyll
> --
>
> Key: MAHOUT-1933
> URL: https://issues.apache.org/jira/browse/MAHOUT-1933
> Project: Mahout
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
> Fix For: 0.13.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1933) Migrate website from CMS to Jekyll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980413#comment-15980413
 ] 

ASF GitHub Bot commented on MAHOUT-1933:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/304
  
So this was merged to the website branch.  Any ideas how to close the PR, 
or should @dustinvanstee just close it on his end?



> Migrate website from CMS to Jekyll
> --
>
> Key: MAHOUT-1933
> URL: https://issues.apache.org/jira/browse/MAHOUT-1933
> Project: Mahout
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
> Fix For: 0.13.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1971) Aggregate Transpose Bug

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980084#comment-15980084
 ] 

ASF GitHub Bot commented on MAHOUT-1971:


Github user asfgit closed the pull request at:

https://github.com/apache/mahout/pull/307


> Aggregate Transpose Bug
> ---
>
> Key: MAHOUT-1971
> URL: https://issues.apache.org/jira/browse/MAHOUT-1971
> Project: Mahout
>  Issue Type: Bug
>Reporter: Trevor Grant
>Assignee: Trevor Grant
> Fix For: 0.13.1
>
>
> In the At operation of Flink and spark there is a line that looks like:
> case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)
> that ought to be 
> case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)
> Since it isnt'- the 'aggregate transpose' does not operate as expected. 
> This needs to be updated in the Spark and Flink bindings (same one char fix). 
> Test coverage should be updated to catch this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1971) Aggregate Transpose Bug

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980072#comment-15980072
 ] 

ASF GitHub Bot commented on MAHOUT-1971:


GitHub user rawkintrevo opened a pull request:

https://github.com/apache/mahout/pull/307

MAHOUT-1971 Aggregate Transpose Bug

Fixes in Spark and Flink bindings- adds test coverage to both.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rawkintrevo/mahout mahout-1971

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mahout/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #307


commit 371dfc26a411768b2eae5111edb269b9c9301d2e
Author: rawkintrevo 
Date:   2017-04-22T18:38:05Z

MAHOUT-1971 Aggregate Transpose Bug




> Aggregate Transpose Bug
> ---
>
> Key: MAHOUT-1971
> URL: https://issues.apache.org/jira/browse/MAHOUT-1971
> Project: Mahout
>  Issue Type: Bug
>Reporter: Trevor Grant
>Assignee: Trevor Grant
> Fix For: 0.13.1
>
>
> In the At operation of Flink and spark there is a line that looks like:
> case (row, blockRow) => colV(row) = blockA(blockRow, blockCol)
> that ought to be 
> case (row, blockRow) => colV(row) += blockA(blockRow, blockCol)
> Since it isnt'- the 'aggregate transpose' does not operate as expected. 
> This needs to be updated in the Spark and Flink bindings (same one char fix). 
> Test coverage should be updated to catch this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (MAHOUT-1933) Migrate website from CMS to Jekyll

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MAHOUT-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980063#comment-15980063
 ] 

ASF GitHub Bot commented on MAHOUT-1933:


Github user rawkintrevo commented on the issue:

https://github.com/apache/mahout/pull/304
  
I also want to call out a big +1 on mathjax support- the dssvd and dspca 
pages now render the markdown correctly- a little late easter egg for anyone 
reviewing...



> Migrate website from CMS to Jekyll
> --
>
> Key: MAHOUT-1933
> URL: https://issues.apache.org/jira/browse/MAHOUT-1933
> Project: Mahout
>  Issue Type: Improvement
>  Components: Documentation
>Affects Versions: 0.13.1
>Reporter: Trevor Grant
> Fix For: 0.13.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)