Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Robert Scholte]

that works because OpenJDK uses module-source-path, i.e.  
src//<*.java>
Maven uses source-path because it matches exactly one module , i.e.  
src/main/java/<*.java>


Aggregator for modules requires to make use of module-source-paths.
I guess we need to consider to make use of symbolic links :(

thanks,
Robert

On Sat, 18 Nov 2017 17:44:23 +0100, Hervé BOUTEMY   
wrote:



JDK javadoc seems to cover the "aggregated javadocs" scenario: in Java 9
terms, that's "multi-modules" = exactly the case for JDK 9 javadoc [1]
I don't know what's the command line to produce this, but looks feasible  
from

javadoc side

Regards,

Hervé

[1] https://docs.oracle.com/javase/9/docs/api/overview-summary.html

Le samedi 18 novembre 2017, 17:38:23 CET Hervé BOUTEMY a écrit :

Le samedi 18 novembre 2017, 17:18:06 CET Mark Raynsford a écrit :
> On 2017-11-18T16:14:04 +
>
> Mark Raynsford  wrote:
> > Presumably, with the module-info.java files
> > excluded, it reverts back to plain classpath style JavaDoc.
>
> Actually, it results in sort of weird looking JavaDoc that only
> contains a single module, and claims that all packages are in
>
> that module:
>   http://outland.iw.int.arc7.info/2017/11/18/apidocs/index.html
>
> That behaviour seems like it might be a bug in the actual JavaDoc tool
> itself.

IIUC, javadoc does not cover aggregated javadocs scenario?

I would not call that a bug, but a missing feature :)

Regards,

Hervé




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Mark Raynsford]

On 2017-11-18T17:44:23 +0100
Hervé BOUTEMY  wrote:

> JDK javadoc seems to cover the "aggregated javadocs" scenario: in Java 9 
> terms, that's "multi-modules" = exactly the case for JDK 9 javadoc [1]
> I don't know what's the command line to produce this, but looks feasible from 
> javadoc side
> 

It looked like a bug in the JavaDoc tool because the generation went
ahead and yet packages were placed into the wrong modules in the
output, but I think it might just be a matter of perspective. I think
the tool maybe worked correctly based on what it was given (a pile of
sources with some important module descriptors taken out).

-- 
Mark Raynsford | http://www.io7m.com



pgpMYYDKLLnLf.pgp
Description: OpenPGP digital signature

Re: Second MNG-6296: New option -Dstyle.color is not working

[Anton Tanasenko]

I was actually going to ask on the list eventually. Tried using it with -B
to no success a few days ago.

I've also had no luck finding where this option is documented on the maven
site.
The only place to look was in the Jira and PR, but those mostly have the
syntax that's not actually what was implemented.

2017-11-18 17:31 GMT+02:00 Robert Scholte :

> Hi,
>
> MNG-6220[1] was incomplete, which will be fixed with MNG-6296[2].
>
> Commit: https://git1-us-west.apache.org/repos/asf?p=maven.git;a=comm
> it;h=b2afafe5
> CI: https://builds.apache.org/view/M-R/view/Maven/job/maven-3.
> x-jenkinsfile/job/MNG-6296/
>
> Who wants to second this?
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MNG-6220
> [2] https://issues.apache.org/jira/browse/MNG-6296
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


-- 
Regards,
Anton.

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Hervé BOUTEMY]

JDK javadoc seems to cover the "aggregated javadocs" scenario: in Java 9 
terms, that's "multi-modules" = exactly the case for JDK 9 javadoc [1]
I don't know what's the command line to produce this, but looks feasible from 
javadoc side

Regards,

Hervé

[1] https://docs.oracle.com/javase/9/docs/api/overview-summary.html

Le samedi 18 novembre 2017, 17:38:23 CET Hervé BOUTEMY a écrit :
> Le samedi 18 novembre 2017, 17:18:06 CET Mark Raynsford a écrit :
> > On 2017-11-18T16:14:04 +
> > 
> > Mark Raynsford  wrote:
> > > Presumably, with the module-info.java files
> > > excluded, it reverts back to plain classpath style JavaDoc.
> > 
> > Actually, it results in sort of weird looking JavaDoc that only
> > contains a single module, and claims that all packages are in
> > 
> > that module:
> >   http://outland.iw.int.arc7.info/2017/11/18/apidocs/index.html
> > 
> > That behaviour seems like it might be a bug in the actual JavaDoc tool
> > itself.
> 
> IIUC, javadoc does not cover aggregated javadocs scenario?
> 
> I would not call that a bug, but a missing feature :)
> 
> Regards,
> 
> Hervé
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Hervé BOUTEMY]

Le samedi 18 novembre 2017, 17:18:06 CET Mark Raynsford a écrit :
> On 2017-11-18T16:14:04 +
> 
> Mark Raynsford  wrote:
> > Presumably, with the module-info.java files
> > excluded, it reverts back to plain classpath style JavaDoc.
> 
> Actually, it results in sort of weird looking JavaDoc that only
> contains a single module, and claims that all packages are in
> that module:
> 
>   http://outland.iw.int.arc7.info/2017/11/18/apidocs/index.html
> 
> That behaviour seems like it might be a bug in the actual JavaDoc tool
> itself.
IIUC, javadoc does not cover aggregated javadocs scenario?

I would not call that a bug, but a missing feature :)

Regards,

Hervé




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Mark Raynsford]

On 2017-11-18T16:14:04 +
Mark Raynsford  wrote:
> Presumably, with the module-info.java files
> excluded, it reverts back to plain classpath style JavaDoc.

Actually, it results in sort of weird looking JavaDoc that only
contains a single module, and claims that all packages are in
that module:

  http://outland.iw.int.arc7.info/2017/11/18/apidocs/index.html

That behaviour seems like it might be a bug in the actual JavaDoc tool
itself.

-- 
Mark Raynsford | http://www.io7m.com



pgpvXwKtxV4Ds.pgp
Description: OpenPGP digital signature

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Mark Raynsford]

On 2017-11-18T17:04:12 +0100
"Robert Scholte"  wrote:

> That's similar to MJAVADOC-479[1]
> 
> Seems like all Java 9 issues are not resolved yet.
> I don't mind canceling the vote if we can fix this as well.
> 
> thanks,
> Robert
> 
> [1] https://issues.apache.org/jira/browse/MJAVADOC-479

Yeah, that does seem to be the one.

I think it'd be best to fix this. If I could apply a workaround, I'd
vote to release, but it seems that the workaround (excluding
module-info.java files) results in JavaDoc that doesn't contain any
module information. Presumably, with the module-info.java files
excluded, it reverts back to plain classpath style JavaDoc.

Your call!

-- 
Mark Raynsford | http://www.io7m.com



pgpW6Drpb7mP9.pgp
Description: OpenPGP digital signature

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Robert Scholte]

That's similar to MJAVADOC-479[1]

Seems like all Java 9 issues are not resolved yet.
I don't mind canceling the vote if we can fix this as well.

thanks,
Robert

[1] https://issues.apache.org/jira/browse/MJAVADOC-479

On Sat, 18 Nov 2017 16:57:36 +0100, Mark Raynsford  
<org.apache.maven.u...@io7m.com> wrote:



Hello!

I'd like to vote on this issue, but I still have a remaining problem
and am not sure if it's because the plugin is broken due to the new
module changes, or just because my project setup is slightly
unusual.

See here:

https://github.com/io7m/maven-javadoc-bug-20171118

The "c" module attempts to aggregate the javadoc of the other modules
in the reactor into a single directory. It fails because the plugin
attempts to load the module descriptors of the other projects,
resulting in a "too many module descriptors" error.

This is a simplified version of a real project here (all of my
projects follow the same basic structure):

  https://github.com/io7m/jequality

The javadoc of all of the modules is aggregated into a directory and
combined with some other documentation into a .zip for deployment.

I'd could use the "aggregate" goal, but that causes too many problems
due to the way that the goal forks and re-runs previous goals bound to
the compile phase. Apart from anything, in larger projects with lots of
modules, re-running all of those goals takes unacceptably long.

It's not clear to me if this is actually a problem with the current
plugin, or just because I'm not supposed to do things this way.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Mark Raynsford]

Hello!

I'd like to vote on this issue, but I still have a remaining problem
and am not sure if it's because the plugin is broken due to the new
module changes, or just because my project setup is slightly
unusual.

See here:

https://github.com/io7m/maven-javadoc-bug-20171118

The "c" module attempts to aggregate the javadoc of the other modules
in the reactor into a single directory. It fails because the plugin
attempts to load the module descriptors of the other projects,
resulting in a "too many module descriptors" error.

This is a simplified version of a real project here (all of my
projects follow the same basic structure):

  https://github.com/io7m/jequality

The javadoc of all of the modules is aggregated into a directory and
combined with some other documentation into a .zip for deployment.

I'd could use the "aggregate" goal, but that causes too many problems
due to the way that the goal forks and re-runs previous goals bound to
the compile phase. Apart from anything, in larger projects with lots of
modules, re-running all of those goals takes unacceptably long.

It's not clear to me if this is actually a problem with the current
plugin, or just because I'm not supposed to do things this way.

-- 
Mark Raynsford | http://www.io7m.com



pgp4jK7aghfEo.pgp
Description: OpenPGP digital signature

Second MNG-6296: New option -Dstyle.color is not working

[Robert Scholte]

Hi,

MNG-6220[1] was incomplete, which will be fixed with MNG-6296[2].

Commit:  
https://git1-us-west.apache.org/repos/asf?p=maven.git;a=commit;h=b2afafe5
CI:  
https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6296/


Who wants to second this?

thanks,
Robert

[1] https://issues.apache.org/jira/browse/MNG-6220
[2] https://issues.apache.org/jira/browse/MNG-6296

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[VOTE] Release Apache Maven Javadoc Plugin version 3.0.0 (take 2)

[Robert Scholte]

Hi,

We solved 27 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529=12330875=Text

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1377/
https://repository.apache.org/content/repositories/maven-1377/org/apache/maven/plugins/maven-javadoc-plugin/3.0.0/maven-javadoc-plugin-3.0.0-source-release.zip

Source release checksum(s):
maven-javadoc-plugin-3.0.0-source-release.zip sha1:  
9f70c385b6be7666f35b5a24ede9c5c60e28dfce


Staging site:
https://maven.apache.org/plugins-archives/maven-javadoc-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[CANCELED] [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

[Robert Scholte]

Issue found related to a Maven multimodule projects and Java 9 module  
descriptors.


This needs to be fixed for 3.0.0.

thanks,
Robert

On Fri, 17 Nov 2017 18:37:16 +0100, Robert Scholte   
wrote:



Hi,

We solved 26 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529=12330875=Text

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317529%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1376/
https://repository.apache.org/content/repositories/maven-1376/org/apache/maven/plugins/maven-javadoc-plugin/3.0.0/maven-javadoc-plugin-3.0.0-source-release.zip

Source release checksum(s):
maven-javadoc-plugin-3.0.0-source-release.zip sha1:  
deb02ee67944fcc6a765bf3df81586c9632a67b3


Staging site:
https://maven.apache.org/plugins-archives/maven-javadoc-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

[Robert Scholte]

Hi Mark,

thanks for testing. I can confirm the problem.
I'll cancel the vote and roll out another release based on your patch.

thanks,
Robert

On Sat, 18 Nov 2017 12:46:51 +0100, Mark Raynsford  
 wrote:



On 2017-11-17T19:00:54 +
Mark Raynsford  wrote:


-1 (non-binding)

The staged version still fails with a basic module setup:

  https://github.com/io7m/maven-javadoc-bug-20171117


I've submitted a PR that I believe fixes the issue, but I'm not sure if
it's already too late to get it into 3.0.0:

  https://github.com/apache/maven-plugins/pull/137

Releasing 3.0.0 as is simply won't work for multi-module builds (and
may be broken elsewhere, I don't know).


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: Download links

[Hervé BOUTEMY]

found something that can explain: when using the real url starting with /
components/, the CGI script works [4]
But not when using the user-visible url (that uses .htaccess rewrite rules) 
[5]

INFRA Jira issue opened: https://issues.apache.org/jira/browse/INFRA-15513

Regards,

Hervé


[4] https://maven.apache.org/components/plugins/maven-jdeprscan-plugin/
download.cgi

[5] https://maven.apache.org/plugins/maven-jdeprscan-plugin/download.cgi

Le samedi 18 novembre 2017, 01:18:27 CET Hervé BOUTEMY a écrit :
> ok, xdoc/download.xml.vm was missing for this new plugin: I added it and
> manually added a generated html result to svnpubsub location [1]
> 
> this is not yet sufficient: I don't know why download.cgi script does not
> find download.html
> 
> this is working on main Maven site [2] from its own svnpubsub location [3]
> 
> any hint?
> 
> Regards,
> 
> Hervé
> 
> [1] https://svn.apache.org/repos/infra/websites/production/maven/components/
> plugins/maven-jdeprscan-plugin/
> 
> [2] http://maven.apache.org/download.cgi
> 
> [3] https://svn.apache.org/repos/infra/websites/production/maven/content/
> 
> Le vendredi 17 novembre 2017, 12:47:51 CET Hervé BOUTEMY a écrit :
> > the deeplink used to work: that's the objective of our
> > "resources/download.cgi + xdoc/download.xml.vm" pattern that was created
> > some years ago.
> > download.cgi is supposed to use standard ASF script that uses
> > download.html
> > as content
> > 
> > I don't know why this does not work any more.
> > 
> > I vaguely remember something a few years ago about executable bit, some
> > headache I had at that time to try to fix working with interested people
> > (ie. not many, but Sebb was probably one of the few). Perhaps it's time to
> > rework on it: I'll see tonight if I can find references on the analysis
> > already done at that time.
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le vendredi 17 novembre 2017, 12:27:49 CET Robert Scholte a écrit :
> > > This topic deserves a separate mailthread.
> > > 
> > > Quoting Sebb on a different thread:
> > > "The download link points to the top-level of the ASF mirror system.
> > > 
> > > This makes it very hard to use."
> > > 
> > > AFAIK the ASF says there should be a download button for every released
> > > product.
> > > In case of Maven we're talking about a lot of projects, and downloads
> > > should be redirected via a mirror.
> > > I don't think it is possible to do a deeplink to a specific folder.
> > > 
> > > Also, in case of Maven plugins and other dependencies (all excluding the
> > > Maven distribution itself) it is kind of strange to provide a download
> > > link when we could assume that they only want to have the
> > > plugin/dependency XML fragment.
> > > 
> > > I agree that the link is kind of useless right now, but also the best we
> > > can do when providing a direct download link.
> > > If there's no way to do a deeplink, I'd prefer to remove it from the
> > > pages
> > > and announcements.
> > > 
> > > thanks,
> > > Robert
> > > 
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven Javadoc Plugin version 3.0.0

[Mark Raynsford]

On 2017-11-17T19:00:54 +
Mark Raynsford  wrote:

> -1 (non-binding)
> 
> The staged version still fails with a basic module setup:
> 
>   https://github.com/io7m/maven-javadoc-bug-20171117

I've submitted a PR that I believe fixes the issue, but I'm not sure if
it's already too late to get it into 3.0.0:

  https://github.com/apache/maven-plugins/pull/137

Releasing 3.0.0 as is simply won't work for multi-module builds (and
may be broken elsewhere, I don't know).

-- 
Mark Raynsford | http://www.io7m.com



pgpQO_QFj9uyK.pgp
Description: OpenPGP digital signature

[GitHub] maven-plugins pull request #137: [MJAVADOC-489] Find the main module descrip...

[io7m]

GitHub user io7m opened a pull request:

https://github.com/apache/maven-plugins/pull/137

[MJAVADOC-489] Find the main module descriptor

The existing code was checking for the existence of a file
"src/main/module-info.java" relative to the current directory. The
problem is that in a multi-module build, the current directory is
the project root, not the root of the current module. As a result,
the module descriptor was not being found and all dependencies were
ending up on the classpath instead.

Fixes: MJAVADOC-489

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/io7m/maven-plugins MJAVADOC-489

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #137


commit 72046ff41b90a7667b07396623487f128542922f
Author: Mark Raynsford 
Date:   2017-11-18T11:43:45Z

[MJAVADOC-489] Find the main module descriptor

The existing code was checking for the existence of a file
"src/main/module-info.java" relative to the current directory. The
problem is that in a multi-module build, the current directory is
the project root, not the root of the current module. As a result,
the module descriptor was not being found and all dependencies were
ending up on the classpath instead.

Fixes: MJAVADOC-489




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-plugins pull request #136: [MDEP-584] Update plexus-utils to 3.1.0

[io7m]

GitHub user io7m opened a pull request:

https://github.com/apache/maven-plugins/pull/136

[MDEP-584] Update plexus-utils to 3.1.0

This updates the plexus-utils dependency to 3.1.0. It corrects four
unit tests that were failing due to new behaviour in 3.1.0: It appears
that the new plexus-utils copies the lastModified attributes of files,
and the old tests were implicitly depending on the attributes not
being copied.

Fixes: MDEP-584

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/io7m/maven-plugins MDEP-584

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #136


commit 178f30ff90efd73276ef636114377d74d047af11
Author: Mark Raynsford 
Date:   2017-11-18T11:38:40Z

[MDEP-584] Update plexus-utils to 3.1.0

This updates the plexus-utils dependency to 3.1.0. It corrects four
unit tests that were failing due to new behaviour in 3.1.0: It appears
that the new plexus-utils copies the lastModified attributes of files,
and the old tests were implicitly depending on the attributes not
being copied.

Fixes: MDEP-584




---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-plugins pull request #135: [MDEP-584] Update plexus-utils to 3.1.0

[io7m]

Github user io7m closed the pull request at:

https://github.com/apache/maven-plugins/pull/135


---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org