Re: [VOTE] Release Maven Antrun plugin version 1.4 [take 2]

2010-05-25 Thread Paul Gier 
You're right, I will cancel and restart the vote.

Arnaud Héritier wrote:
> I think you should have restart another vote.
> +1 for it.
> 
> On May 25, 2010, at 6:46 PM, Paul Gier wrote:
> 
>> Benjamin Bentmann wrote:
>>> Paul Gier wrote:
>>>
 Staging repo:
 https://repository.apache.org/content/repositories/maven-013/
>>> -1
>>>
>>> The implementation for MANTRUN-100 has two flaws:
>>>
>>>  if ( classifier == null )
>>>  {
>>>mavenProject.setFile( file );
>>>  }
>>>  else
>>>  {
>>>ArtifactHandler handler = new DefaultArtifactHandler( type );
>>>Artifact artifact = new AttachedArtifact(mavenProject.getArtifact(),
>>> type, classifier, handler);
>>>artifact.setFile( file );
>>>artifact.setResolved( true );
>>>log( "Attaching " + file + " as an attached artifact",
>>> Project.MSG_VERBOSE );
>>>mavenProject.addAttachedArtifact( artifact );
>>>  }
>>>
>>> a)
>>> mavenProject.setFile( file ) sets the path to the POM, not the main
>>> artifact.
>>>
>>> b)
>>> DefaultArtifactHandler and AttachedArtifact are internal implementation
>>> classes, the code should use MavenProjectHelper and interfaces instead.
>>>
>>>
>>> Benjamin
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>>> For additional commands, e-mail: dev-h...@maven.apache.org
>>>
>> Hi Benjamin,
>>
>> Thanks for the feedback and thanks for fixing MANTRUN-139.
>>
>> I have fixed a) and b) according to your suggestions, and recreated the 
>> release.
>> The new staging repository is
>>
>> https://repository.apache.org/content/repositories/maven-014/
>>
>> Regarding DefaultArtifactHandler vs. MavenProjectHelper, I was trying to 
>> find a
>> way that the task could be dependent only on the Maven project since the task
>> does not have direct access to the Maven components.  Maybe there should be a
>> way to attach an artifact to a project without requiring the project helper?
>>
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
> 
> Arnaud Héritier
> eXo - Software Factory Manager
> +33 (0)6 89 76 64 24
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4 [take 2]

2010-05-25 Thread Arnaud Héritier 
I think you should have restart another vote.
+1 for it.

On May 25, 2010, at 6:46 PM, Paul Gier wrote:

> Benjamin Bentmann wrote:
>> Paul Gier wrote:
>> 
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/maven-013/
>> 
>> -1
>> 
>> The implementation for MANTRUN-100 has two flaws:
>> 
>>  if ( classifier == null )
>>  {
>>mavenProject.setFile( file );
>>  }
>>  else
>>  {
>>ArtifactHandler handler = new DefaultArtifactHandler( type );
>>Artifact artifact = new AttachedArtifact(mavenProject.getArtifact(),
>> type, classifier, handler);
>>artifact.setFile( file );
>>artifact.setResolved( true );
>>log( "Attaching " + file + " as an attached artifact",
>> Project.MSG_VERBOSE );
>>mavenProject.addAttachedArtifact( artifact );
>>  }
>> 
>> a)
>> mavenProject.setFile( file ) sets the path to the POM, not the main
>> artifact.
>> 
>> b)
>> DefaultArtifactHandler and AttachedArtifact are internal implementation
>> classes, the code should use MavenProjectHelper and interfaces instead.
>> 
>> 
>> Benjamin
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>> 
> 
> Hi Benjamin,
> 
> Thanks for the feedback and thanks for fixing MANTRUN-139.
> 
> I have fixed a) and b) according to your suggestions, and recreated the 
> release.
> The new staging repository is
> 
> https://repository.apache.org/content/repositories/maven-014/
> 
> Regarding DefaultArtifactHandler vs. MavenProjectHelper, I was trying to find 
> a
> way that the task could be dependent only on the Maven project since the task
> does not have direct access to the Maven components.  Maybe there should be a
> way to attach an artifact to a project without requiring the project helper?
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

Arnaud Héritier
eXo - Software Factory Manager
+33 (0)6 89 76 64 24




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread Benjamin Bentmann 

Paul Gier wrote:


The new staging repository is

https://repository.apache.org/content/repositories/maven-014/


+1


Benjamin

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread Paul Gier 
Benjamin Bentmann wrote:
> Paul Gier wrote:
> 
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-013/
> 
> -1
> 
> The implementation for MANTRUN-100 has two flaws:
> 
>   if ( classifier == null )
>   {
> mavenProject.setFile( file );
>   }
>   else
>   {
> ArtifactHandler handler = new DefaultArtifactHandler( type );
> Artifact artifact = new AttachedArtifact(mavenProject.getArtifact(),
> type, classifier, handler);
> artifact.setFile( file );
> artifact.setResolved( true );
> log( "Attaching " + file + " as an attached artifact",
> Project.MSG_VERBOSE );
> mavenProject.addAttachedArtifact( artifact );
>   }
> 
> a)
> mavenProject.setFile( file ) sets the path to the POM, not the main
> artifact.
> 
> b)
> DefaultArtifactHandler and AttachedArtifact are internal implementation
> classes, the code should use MavenProjectHelper and interfaces instead.
> 
> 
> Benjamin
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 

Hi Benjamin,

Thanks for the feedback and thanks for fixing MANTRUN-139.

I have fixed a) and b) according to your suggestions, and recreated the release.
 The new staging repository is

https://repository.apache.org/content/repositories/maven-014/

Regarding DefaultArtifactHandler vs. MavenProjectHelper, I was trying to find a
way that the task could be dependent only on the Maven project since the task
does not have direct access to the Maven components.  Maybe there should be a
way to attach an artifact to a project without requiring the project helper?




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread Benjamin Bentmann 

Paul Gier wrote:


Staging repo:
https://repository.apache.org/content/repositories/maven-013/


-1

The implementation for MANTRUN-100 has two flaws:

  if ( classifier == null )
  {
mavenProject.setFile( file );
  }
  else
  {
ArtifactHandler handler = new DefaultArtifactHandler( type );
Artifact artifact = new 
AttachedArtifact(mavenProject.getArtifact(), type, classifier, handler);

artifact.setFile( file );
artifact.setResolved( true );
log( "Attaching " + file + " as an attached artifact", 
Project.MSG_VERBOSE );

mavenProject.addAttachedArtifact( artifact );
  }

a)
mavenProject.setFile( file ) sets the path to the POM, not the main 
artifact.


b)
DefaultArtifactHandler and AttachedArtifact are internal implementation 
classes, the code should use MavenProjectHelper and interfaces instead.



Benjamin

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread Paul Merlin 

+1 (non-binding)



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread nicolas de loof 
+1

Le 25 mai 2010 10:11, Arnaud Héritier  a écrit :

> +1
>
> On May 25, 2010, at 4:20 AM, Paul Gier wrote:
>
> > Hi,
> >
> > We solved 13 issues:
> >
> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11125&version=14641
> >
> > There are still a couple of issues left in JIRA:
> >
> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11125&status=1
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-013/
> >
> > Staging site:
> > http://maven.apache.org/plugins/maven-antrun-plugin-1.4/
> >
> > SCM Tag:
> >
> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-antrun-plugin-1.4/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> >
> >
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread Arnaud Héritier 
+1

On May 25, 2010, at 4:20 AM, Paul Gier wrote:

> Hi,
> 
> We solved 13 issues:
> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11125&version=14641
> 
> There are still a couple of issues left in JIRA:
> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11125&status=1
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-013/
> 
> Staging site:
> http://maven.apache.org/plugins/maven-antrun-plugin-1.4/
> 
> SCM Tag:
> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-antrun-plugin-1.4/
> 
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

RE: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-25 Thread Johann Reyes 
Waiting for this release

+1

-Original Message-
From: Paul Gier [mailto:pg...@redhat.com] 
Sent: Monday, May 24, 2010 10:20 PM
To: Maven Developers List
Subject: [VOTE] Release Maven Antrun plugin version 1.4

Hi,

We solved 13 issues:
http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11125&version=146
41

There are still a couple of issues left in JIRA:
http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11125&sta
tus=1

Staging repo:
https://repository.apache.org/content/repositories/maven-013/

Staging site:
http://maven.apache.org/plugins/maven-antrun-plugin-1.4/

SCM Tag:
http://svn.apache.org/repos/asf/maven/plugins/tags/maven-antrun-plugin-1.4/

Guide to testing staged releases:
http://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Maven Antrun plugin version 1.4

2010-05-24 Thread Stephen Connolly 
+1

On 25 May 2010 03:20, Paul Gier  wrote:

> Hi,
>
> We solved 13 issues:
>
> http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11125&version=14641
>
> There are still a couple of issues left in JIRA:
>
> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11125&status=1
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-013/
>
> Staging site:
> http://maven.apache.org/plugins/maven-antrun-plugin-1.4/
>
> SCM Tag:
> http://svn.apache.org/repos/asf/maven/plugins/tags/maven-antrun-plugin-1.4/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>