Re: Super POM release-profile: jar-no-fork for source JAR
On Thu, Nov 27, 2014 at 10:36 PM, Anders Hammar and...@hammar.net wrote: I recently took a look at the release-profile in Maven's super POM. It uses the jar goal of the maven-source-plugin to create the source JAR. Wouldn't it be better to use the jar-no-fork goal for that? sounds definitively like a good idea...to change that... I have created an appropriate JIRA for it and fixed it. https://issues.apache.org/jira/browse/MPOM-64 The topic was the Super-POM (which is part of Maven core) not the ASF parent. (Even though there could be something similar i ASF parent). Indeed, I meant the Super-POM in Maven core. This change could have a major impact so we really need to be careful! Does anyone know if there is a specific reason for choosing the 'jar' goal? /Anders I guess it's just because the jar goal is about two years older than jar-no-fork and in most build setup nobody will notice the difference. Changing the goal to jar-no-fork might interfere with Maven projects that generate source JARs outside of the release-profile. But I still think that jar-no-fork ist the better and correct option for the release-profile. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Super POM release-profile: jar-no-fork for source JAR
On Fri, Nov 28, 2014 at 1:28 AM, Manfred Moser manf...@mosabuam.com wrote: To be honest I would be more inclined to remove the release profile from the super pom altogether .. manfred +1, I would appreciate that too. However, in 2009 there was apperently an attempt to remove the profile from the Super POM but it was restored for compatibility reasons [1]. Probably it would be a better approach to set the useReleaseProfile property in the maven-release-plugin to false (assuming that most people are activating the release-profile by using the maven-release-plugin). [1] https://github.com/apache/maven/commit/3870ab0e6021eb17d04883f97fe144d2db96e745 Cheers, Stefan Anders Hammar wrote on 27.11.2014 13:36: I recently took a look at the release-profile in Maven's super POM. It uses the jar goal of the maven-source-plugin to create the source JAR. Wouldn't it be better to use the jar-no-fork goal for that? sounds definitively like a good idea...to change that... I have created an appropriate JIRA for it and fixed it. https://issues.apache.org/jira/browse/MPOM-64 The topic was the Super-POM (which is part of Maven core) not the ASF parent. (Even though there could be something similar i ASF parent). This change could have a major impact so we really need to be careful! Does anyone know if there is a specific reason for choosing the 'jar' goal? /Anders Thanks for the improvement. For example, if a projects spends a lot of time in the generate-sources phase, the jar goal would cause the execution of that phase twice. With jar-no-fork that wouldn't happen. Cheers, Stefan Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Super POM release-profile: jar-no-fork for source JAR
Hi Stefan, On 11/27/14 7:39 PM, Stefan Ferstl wrote: I recently took a look at the release-profile in Maven's super POM. It uses the jar goal of the maven-source-plugin to create the source JAR. Wouldn't it be better to use the jar-no-fork goal for that? sounds definitively like a good idea...to change that... I have created an appropriate JIRA for it and fixed it. https://issues.apache.org/jira/browse/MPOM-64 Thanks for the improvement. For example, if a projects spends a lot of time in the generate-sources phase, the jar goal would cause the execution of that phase twice. With jar-no-fork that wouldn't happen. Cheers, Stefan Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Super POM release-profile: jar-no-fork for source JAR
I recently took a look at the release-profile in Maven's super POM. It uses the jar goal of the maven-source-plugin to create the source JAR. Wouldn't it be better to use the jar-no-fork goal for that? sounds definitively like a good idea...to change that... I have created an appropriate JIRA for it and fixed it. https://issues.apache.org/jira/browse/MPOM-64 The topic was the Super-POM (which is part of Maven core) not the ASF parent. (Even though there could be something similar i ASF parent). This change could have a major impact so we really need to be careful! Does anyone know if there is a specific reason for choosing the 'jar' goal? /Anders Thanks for the improvement. For example, if a projects spends a lot of time in the generate-sources phase, the jar goal would cause the execution of that phase twice. With jar-no-fork that wouldn't happen. Cheers, Stefan Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Super POM release-profile: jar-no-fork for source JAR
To be honest I would be more inclined to remove the release profile from the super pom altogether .. manfred Anders Hammar wrote on 27.11.2014 13:36: I recently took a look at the release-profile in Maven's super POM. It uses the jar goal of the maven-source-plugin to create the source JAR. Wouldn't it be better to use the jar-no-fork goal for that? sounds definitively like a good idea...to change that... I have created an appropriate JIRA for it and fixed it. https://issues.apache.org/jira/browse/MPOM-64 The topic was the Super-POM (which is part of Maven core) not the ASF parent. (Even though there could be something similar i ASF parent). This change could have a major impact so we really need to be careful! Does anyone know if there is a specific reason for choosing the 'jar' goal? /Anders Thanks for the improvement. For example, if a projects spends a lot of time in the generate-sources phase, the jar goal would cause the execution of that phase twice. With jar-no-fork that wouldn't happen. Cheers, Stefan Kind regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
