Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-02-01 Thread Norbert Wnuk
SUREFIRE-1136 finally integrated, thx for the support.

Regards,
NW

On Sat, Jan 31, 2015 at 10:37 AM, Norbert Wnuk norbertw...@gmail.com
wrote:

 Hi Tibor  Andreas,
 Surefire855, it was only a remark - I was not touching it.
 New pull request attached -
 https://github.com/apache/maven-surefire/pull/84

 Regards,
 NW

 On Fri, Jan 30, 2015 at 6:16 PM, Tibor Digana tibordig...@apache.org
 wrote:

 Hi Norbert,

 Definitely we should make notes about Maven 2 limitations.
 After you have opened new PR in GitHub we would add a text in our docu.

 I had a reason to use easytesting in Surefire855 IT - it's only IT, the
 main
 code is not affected, just upgrade to JDK6. I can skip this test in JDK5,
 do
 you want me to do that? We will switch to JDK 6 in Maven 3 - I hope soon.



 --
 View this message in context:
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5825274.html
 Sent from the Maven Developers mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org





Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-31 Thread Norbert Wnuk
Hi Tibor  Andreas,
Surefire855, it was only a remark - I was not touching it.
New pull request attached - https://github.com/apache/maven-surefire/pull/84

Regards,
NW

On Fri, Jan 30, 2015 at 6:16 PM, Tibor Digana tibordig...@apache.org
wrote:

 Hi Norbert,

 Definitely we should make notes about Maven 2 limitations.
 After you have opened new PR in GitHub we would add a text in our docu.

 I had a reason to use easytesting in Surefire855 IT - it's only IT, the
 main
 code is not affected, just upgrade to JDK6. I can skip this test in JDK5,
 do
 you want me to do that? We will switch to JDK 6 in Maven 3 - I hope soon.



 --
 View this message in context:
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5825274.html
 Sent from the Maven Developers mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org




Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-30 Thread Tibor Digana
Hi Norbert,

Definitely we should make notes about Maven 2 limitations.
After you have opened new PR in GitHub we would add a text in our docu.

I had a reason to use easytesting in Surefire855 IT - it's only IT, the main
code is not affected, just upgrade to JDK6. I can skip this test in JDK5, do
you want me to do that? We will switch to JDK 6 in Maven 3 - I hope soon.



--
View this message in context: 
http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5825274.html
Sent from the Maven Developers mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-28 Thread Norbert Wnuk
Yes, will do that shortly. I would like to aggregate fixes for unit and
integration test in one pull request, the link was only to show the
progress.

NW

On Wed, Jan 28, 2015 at 8:51 AM, Andreas Gudian andreas.gud...@gmail.com
wrote:

 Thanks, Norbert!

 Could you also create a new Pull-Request for it? Then I can fetch it more
 easily :-)


 Am Mittwoch, 28. Januar 2015 schrieb Norbert Wnuk :

  Link after pushing amended commit -
 
 
 https://github.com/norbertwnuk/maven-surefire/commit/d6a8af593fc03e12ecf2dc8047669472f7ca263b
 
  On Wed, Jan 28, 2015 at 3:10 AM, Norbert Wnuk norbertw...@gmail.com
  javascript:; wrote:
 
   Hi Tibor / Andreas,
   I found a time to address problem with unit test, will take a look at
   integration test tomorrow.
  
  
 
 https://github.com/norbertwnuk/maven-surefire/commit/44b6ffaddc93c34c3e76abd4ea5fd3b8d837a130
  
   NW
  
   On Sun, Jan 25, 2015 at 1:32 AM, Tibor Digana tibordig...@apache.org
  javascript:;
   wrote:
  
   Hi Norbert,
   I have updaated PR #82 with comment on GitHub.
   The Ubuntu builds fail.
   I would prefer keeping the test anyway.
   Try to find a solution for Ubuntu as well; otherwise use JUnit
  assumption
   statement
   assumeThat( os, anyOf( is( Windows ), is( Ubuntu1 ) ) )
   in the particular IT method, possibly unit test.
  
  
  
  
   --
   View this message in context:
  
 
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824683.html
   Sent from the Maven Developers mailing list archive at Nabble.com.
  
   -
   To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 javascript:;
   For additional commands, e-mail: dev-h...@maven.apache.org
  javascript:;
  
  
  
 



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-28 Thread Norbert Wnuk
/d6a8af593fc03e12ecf2dc8047669472f7ca263b
 
  On Wed, Jan 28, 2015 at 3:10 AM, Norbert Wnuk norbertw...@gmail.com
  javascript:; wrote:
 
   Hi Tibor / Andreas,
   I found a time to address problem with unit test, will take a look at
   integration test tomorrow.
  
  
 
 https://github.com/norbertwnuk/maven-surefire/commit/44b6ffaddc93c34c3e76abd4ea5fd3b8d837a130
  
   NW
  
   On Sun, Jan 25, 2015 at 1:32 AM, Tibor Digana tibordig...@apache.org
  javascript:;
   wrote:
  
   Hi Norbert,
   I have updaated PR #82 with comment on GitHub.
   The Ubuntu builds fail.
   I would prefer keeping the test anyway.
   Try to find a solution for Ubuntu as well; otherwise use JUnit
  assumption
   statement
   assumeThat( os, anyOf( is( Windows ), is( Ubuntu1 ) ) )
   in the particular IT method, possibly unit test.
  
  
  
  
   --
   View this message in context:
  
 
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824683.html
   Sent from the Maven Developers mailing list archive at Nabble.com.
  
   -
   To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 javascript:;
   For additional commands, e-mail: dev-h...@maven.apache.org
  javascript:;
  
  
  
 





Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-27 Thread Norbert Wnuk
Hi Tibor / Andreas,
I found a time to address problem with unit test, will take a look at
integration test tomorrow.
https://github.com/norbertwnuk/maven-surefire/commit/44b6ffaddc93c34c3e76abd4ea5fd3b8d837a130

NW

On Sun, Jan 25, 2015 at 1:32 AM, Tibor Digana tibordig...@apache.org
wrote:

 Hi Norbert,
 I have updaated PR #82 with comment on GitHub.
 The Ubuntu builds fail.
 I would prefer keeping the test anyway.
 Try to find a solution for Ubuntu as well; otherwise use JUnit assumption
 statement
 assumeThat( os, anyOf( is( Windows ), is( Ubuntu1 ) ) )
 in the particular IT method, possibly unit test.




 --
 View this message in context:
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824683.html
 Sent from the Maven Developers mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org




Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-27 Thread Andreas Gudian
Thanks, Norbert!

Could you also create a new Pull-Request for it? Then I can fetch it more
easily :-)


Am Mittwoch, 28. Januar 2015 schrieb Norbert Wnuk :

 Link after pushing amended commit -

 https://github.com/norbertwnuk/maven-surefire/commit/d6a8af593fc03e12ecf2dc8047669472f7ca263b

 On Wed, Jan 28, 2015 at 3:10 AM, Norbert Wnuk norbertw...@gmail.com
 javascript:; wrote:

  Hi Tibor / Andreas,
  I found a time to address problem with unit test, will take a look at
  integration test tomorrow.
 
 
 https://github.com/norbertwnuk/maven-surefire/commit/44b6ffaddc93c34c3e76abd4ea5fd3b8d837a130
 
  NW
 
  On Sun, Jan 25, 2015 at 1:32 AM, Tibor Digana tibordig...@apache.org
 javascript:;
  wrote:
 
  Hi Norbert,
  I have updaated PR #82 with comment on GitHub.
  The Ubuntu builds fail.
  I would prefer keeping the test anyway.
  Try to find a solution for Ubuntu as well; otherwise use JUnit
 assumption
  statement
  assumeThat( os, anyOf( is( Windows ), is( Ubuntu1 ) ) )
  in the particular IT method, possibly unit test.
 
 
 
 
  --
  View this message in context:
 
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824683.html
  Sent from the Maven Developers mailing list archive at Nabble.com.
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org javascript:;
  For additional commands, e-mail: dev-h...@maven.apache.org
 javascript:;
 
 
 



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-27 Thread Norbert Wnuk
Link after pushing amended commit -
https://github.com/norbertwnuk/maven-surefire/commit/d6a8af593fc03e12ecf2dc8047669472f7ca263b

On Wed, Jan 28, 2015 at 3:10 AM, Norbert Wnuk norbertw...@gmail.com wrote:

 Hi Tibor / Andreas,
 I found a time to address problem with unit test, will take a look at
 integration test tomorrow.

 https://github.com/norbertwnuk/maven-surefire/commit/44b6ffaddc93c34c3e76abd4ea5fd3b8d837a130

 NW

 On Sun, Jan 25, 2015 at 1:32 AM, Tibor Digana tibordig...@apache.org
 wrote:

 Hi Norbert,
 I have updaated PR #82 with comment on GitHub.
 The Ubuntu builds fail.
 I would prefer keeping the test anyway.
 Try to find a solution for Ubuntu as well; otherwise use JUnit assumption
 statement
 assumeThat( os, anyOf( is( Windows ), is( Ubuntu1 ) ) )
 in the particular IT method, possibly unit test.




 --
 View this message in context:
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824683.html
 Sent from the Maven Developers mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org





Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-24 Thread Tibor Digana
Hi Norbert,
I have updaated PR #82 with comment on GitHub.
The Ubuntu builds fail.
I would prefer keeping the test anyway.
Try to find a solution for Ubuntu as well; otherwise use JUnit assumption
statement 
assumeThat( os, anyOf( is( Windows ), is( Ubuntu1 ) ) ) 
in the particular IT method, possibly unit test.




--
View this message in context: 
http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824683.html
Sent from the Maven Developers mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-23 Thread Andreas Gudian
Hi Norbert,

yesterday I ran the whole build locally (Windows) with JDK 5 and everything
worked for me.

For the linux case, I guess it's hard to create an directory with an
invalid name. In case you don't find an alternative approach, I wouldn't be
devastated if we just removed that test case again... ;-)

Andreas

2015-01-22 23:47 GMT+01:00 Norbert Wnuk norbertw...@gmail.com:

 Hi Andreas,
 My pull request seems to be unusually problematic ... I was running all
 tests on Ubuntu (and Windows too) but apparently assumption that '\0'
 cannot be used in directory name on Linux might not be always true:
 https://builds.apache.org/job/maven-surefire/1386/
 https://builds.apache.org/job/maven-surefire-mvn-2.2.1/1539/

 http://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names
 Are you able to recreate the behavior?
 Not sure how it is related to the fact that I was forced to swap to first
 characters in directory name: ?\0InvalidDirectoryName after last
 refactoring (removing nio API) since leading '\0' just after '\' in the
 path name started to affect getCanonicalPath on Windows (it was terminating
 path name at this position). Need one day more to clarify unit test and
 additionally re-run integration test with maven 2.x.

 Regards,
 NW


 On Thu, Jan 22, 2015 at 1:52 AM, Norbert Wnuk norbertw...@gmail.com
 wrote:

  Pull request with the fix -
  https://github.com/apache/maven-surefire/pull/82
 
  NW
 
  On Wed, Jan 21, 2015 at 9:27 PM, Tibor Digana tibordig...@apache.org
  wrote:
 
  This is a traditional problem with animal-sniffer-maven-plugin.
  We had the same issue in JUnit project. Alrerady reported in JIRA
  http://jira.codehaus.org/browse/MANIMALSNIFFER-54
  http://jira.codehaus.org/browse/MANIMALSNIFFER-40
  I would like to have the check-test goal or a new parameter.
  It's still assigned to @stephenc.
  I would appreciate it working and utilized in Maven and JUnit projects.
 
 
 
  --
  View this message in context:
 
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824348.html
  Sent from the Maven Developers mailing list archive at Nabble.com.
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
  For additional commands, e-mail: dev-h...@maven.apache.org
 
 
 



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-22 Thread Norbert Wnuk
Hi Andreas,
My pull request seems to be unusually problematic ... I was running all
tests on Ubuntu (and Windows too) but apparently assumption that '\0'
cannot be used in directory name on Linux might not be always true:
https://builds.apache.org/job/maven-surefire/1386/
https://builds.apache.org/job/maven-surefire-mvn-2.2.1/1539/
http://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names
Are you able to recreate the behavior?
Not sure how it is related to the fact that I was forced to swap to first
characters in directory name: ?\0InvalidDirectoryName after last
refactoring (removing nio API) since leading '\0' just after '\' in the
path name started to affect getCanonicalPath on Windows (it was terminating
path name at this position). Need one day more to clarify unit test and
additionally re-run integration test with maven 2.x.

Regards,
NW


On Thu, Jan 22, 2015 at 1:52 AM, Norbert Wnuk norbertw...@gmail.com wrote:

 Pull request with the fix -
 https://github.com/apache/maven-surefire/pull/82

 NW

 On Wed, Jan 21, 2015 at 9:27 PM, Tibor Digana tibordig...@apache.org
 wrote:

 This is a traditional problem with animal-sniffer-maven-plugin.
 We had the same issue in JUnit project. Alrerady reported in JIRA
 http://jira.codehaus.org/browse/MANIMALSNIFFER-54
 http://jira.codehaus.org/browse/MANIMALSNIFFER-40
 I would like to have the check-test goal or a new parameter.
 It's still assigned to @stephenc.
 I would appreciate it working and utilized in Maven and JUnit projects.



 --
 View this message in context:
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824348.html
 Sent from the Maven Developers mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org





Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-21 Thread Norbert Wnuk
Pull request with the fix - https://github.com/apache/maven-surefire/pull/82

NW

On Wed, Jan 21, 2015 at 9:27 PM, Tibor Digana tibordig...@apache.org
wrote:

 This is a traditional problem with animal-sniffer-maven-plugin.
 We had the same issue in JUnit project. Alrerady reported in JIRA
 http://jira.codehaus.org/browse/MANIMALSNIFFER-54
 http://jira.codehaus.org/browse/MANIMALSNIFFER-40
 I would like to have the check-test goal or a new parameter.
 It's still assigned to @stephenc.
 I would appreciate it working and utilized in Maven and JUnit projects.



 --
 View this message in context:
 http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824348.html
 Sent from the Maven Developers mailing list archive at Nabble.com.

 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org




Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-21 Thread Tibor Digana
This is a traditional problem with animal-sniffer-maven-plugin.
We had the same issue in JUnit project. Alrerady reported in JIRA
http://jira.codehaus.org/browse/MANIMALSNIFFER-54
http://jira.codehaus.org/browse/MANIMALSNIFFER-40
I would like to have the check-test goal or a new parameter.
It's still assigned to @stephenc.
I would appreciate it working and utilized in Maven and JUnit projects.



--
View this message in context: 
http://maven.40175.n5.nabble.com/Surefire-Plugin-does-not-handle-workingDirectory-in-fork-mode-properly-tp5824054p5824348.html
Sent from the Maven Developers mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-20 Thread Norbert Wnuk
Hi Andreas,
The JDK API level is not enforced during build so that my accidental usage
of JDK 1.7 API in tests was not discovered till recent Jenkins build:
https://builds.apache.org/job/maven-surefire/1385/ Should I create new pull
request / what is the procedure after closing original pull request?

Regards,
NW

On Tue, Jan 20, 2015 at 1:24 AM, Norbert Wnuk norbertw...@gmail.com wrote:

 JIRA created, pull request with more mature fix attached (including
 integration test).

 https://jira.codehaus.org/browse/SUREFIRE-1136
 https://github.com/apache/maven-surefire/pull/80

 Regards,
 NW

 On Mon, Jan 19, 2015 at 8:03 AM, Karl Heinz Marbaise khmarba...@gmx.de
 wrote:

 Hi Norbert,

 It's great that you asking for permission to create a jira but you don't
 need to just create one and describe the situation etc. why and how it went
 wrong or what can be improved and of course your patch is really
 great...but it would be much easier if you could either provide a test for
 your patch or at least add an example project which shows the wrong
 behaviour...

 Thanks in advance

 Kind regards
 Karl Heinz Marbaise


 On 1/18/15 10:56 PM, Norbert Wnuk wrote:

 Hi All,
 Not sure whether this is a proper place however Surefire webpage
 redirects to this mailing group.
 Recently we found two issues in Surefire plugin related to
 surefire.forkNumber variable and ability to define separate working
 directory per forked JVM. First issue is that the same directory is set
 for each of forked JVMs, the second problem is that surefire.forkNumber
 is expanded only for user.dir property and not for actual working
 directory (it leads to the situations like described here:
 http://stackoverflow.com/questions/1234795/why-is-the-
 user-dir-system-property-working-in-java).
 Attaching patch that resolves both problems for us (without test cases
 yet). Asking for a permission to create a JIRA.

 workingDirectorydirectory_${surefire.forkNumber}/workingDirectory

 Regards,
 Norbert


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org





Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-20 Thread Andreas Gudian
Hi Norbert,

Oh, I misses that one as well - our animal sniffer seems to put its nose
only into the main classes.

A new pull-request would be great.

Am Dienstag, 20. Januar 2015 schrieb Norbert Wnuk :

 Hi Andreas,
 The JDK API level is not enforced during build so that my accidental usage
 of JDK 1.7 API in tests was not discovered till recent Jenkins build:
 https://builds.apache.org/job/maven-surefire/1385/ Should I create new
 pull
 request / what is the procedure after closing original pull request?

 Regards,
 NW

 On Tue, Jan 20, 2015 at 1:24 AM, Norbert Wnuk norbertw...@gmail.com
 javascript:; wrote:

  JIRA created, pull request with more mature fix attached (including
  integration test).
 
  https://jira.codehaus.org/browse/SUREFIRE-1136
  https://github.com/apache/maven-surefire/pull/80
 
  Regards,
  NW
 
  On Mon, Jan 19, 2015 at 8:03 AM, Karl Heinz Marbaise khmarba...@gmx.de
 javascript:;
  wrote:
 
  Hi Norbert,
 
  It's great that you asking for permission to create a jira but you don't
  need to just create one and describe the situation etc. why and how it
 went
  wrong or what can be improved and of course your patch is really
  great...but it would be much easier if you could either provide a test
 for
  your patch or at least add an example project which shows the wrong
  behaviour...
 
  Thanks in advance
 
  Kind regards
  Karl Heinz Marbaise
 
 
  On 1/18/15 10:56 PM, Norbert Wnuk wrote:
 
  Hi All,
  Not sure whether this is a proper place however Surefire webpage
  redirects to this mailing group.
  Recently we found two issues in Surefire plugin related to
  surefire.forkNumber variable and ability to define separate working
  directory per forked JVM. First issue is that the same directory is set
  for each of forked JVMs, the second problem is that surefire.forkNumber
  is expanded only for user.dir property and not for actual working
  directory (it leads to the situations like described here:
  http://stackoverflow.com/questions/1234795/why-is-the-
  user-dir-system-property-working-in-java).
  Attaching patch that resolves both problems for us (without test cases
  yet). Asking for a permission to create a JIRA.
 
  workingDirectorydirectory_${surefire.forkNumber}/workingDirectory
 
  Regards,
  Norbert
 
 
  -
  To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org javascript:;
  For additional commands, e-mail: dev-h...@maven.apache.org
 javascript:;
 
 
 



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-19 Thread Norbert Wnuk
JIRA created, pull request with more mature fix attached (including
integration test).

https://jira.codehaus.org/browse/SUREFIRE-1136
https://github.com/apache/maven-surefire/pull/80

Regards,
NW

On Mon, Jan 19, 2015 at 8:03 AM, Karl Heinz Marbaise khmarba...@gmx.de
wrote:

 Hi Norbert,

 It's great that you asking for permission to create a jira but you don't
 need to just create one and describe the situation etc. why and how it went
 wrong or what can be improved and of course your patch is really
 great...but it would be much easier if you could either provide a test for
 your patch or at least add an example project which shows the wrong
 behaviour...

 Thanks in advance

 Kind regards
 Karl Heinz Marbaise


 On 1/18/15 10:56 PM, Norbert Wnuk wrote:

 Hi All,
 Not sure whether this is a proper place however Surefire webpage
 redirects to this mailing group.
 Recently we found two issues in Surefire plugin related to
 surefire.forkNumber variable and ability to define separate working
 directory per forked JVM. First issue is that the same directory is set
 for each of forked JVMs, the second problem is that surefire.forkNumber
 is expanded only for user.dir property and not for actual working
 directory (it leads to the situations like described here:
 http://stackoverflow.com/questions/1234795/why-is-the-
 user-dir-system-property-working-in-java).
 Attaching patch that resolves both problems for us (without test cases
 yet). Asking for a permission to create a JIRA.

 workingDirectorydirectory_${surefire.forkNumber}/workingDirectory

 Regards,
 Norbert


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org




Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-19 Thread Karl Heinz Marbaise

Hi Norbert,

It's great that you asking for permission to create a jira but you don't 
need to just create one and describe the situation etc. why and how it 
went wrong or what can be improved and of course your patch is really 
great...but it would be much easier if you could either provide a test 
for your patch or at least add an example project which shows the wrong 
behaviour...


Thanks in advance

Kind regards
Karl Heinz Marbaise

On 1/18/15 10:56 PM, Norbert Wnuk wrote:

Hi All,
Not sure whether this is a proper place however Surefire webpage
redirects to this mailing group.
Recently we found two issues in Surefire plugin related to
surefire.forkNumber variable and ability to define separate working
directory per forked JVM. First issue is that the same directory is set
for each of forked JVMs, the second problem is that surefire.forkNumber
is expanded only for user.dir property and not for actual working
directory (it leads to the situations like described here:
http://stackoverflow.com/questions/1234795/why-is-the-user-dir-system-property-working-in-java).
Attaching patch that resolves both problems for us (without test cases
yet). Asking for a permission to create a JIRA.

workingDirectorydirectory_${surefire.forkNumber}/workingDirectory

Regards,
Norbert



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-18 Thread Andreas Gudian
Hi Norbert,

sounds great! To create a Jira-Issue for surefire [1], you just need to
sign-up on xircles [2].

You can attach your path to the Jira issue, if you like. The most fluent
way to suggest patches is by making a pull-request on GitHub where we can
directly discuss the patch.

In the end, for a patch to be applied, we need an intergration test - but
we can guide you to that step by step, if you want to let us take a first
look on what you changed.

Thanks,
Andreas

1: http://jira.codehaus.org/browse/SUREFIRE
2: https://xircles.codehaus.org/signup/

2015-01-18 22:56 GMT+01:00 Norbert Wnuk norbertw...@gmail.com:

 Hi All,
 Not sure whether this is a proper place however Surefire webpage redirects
 to this mailing group.
 Recently we found two issues in Surefire plugin related to
 surefire.forkNumber variable and ability to define separate working
 directory per forked JVM. First issue is that the same directory is set for
 each of forked JVMs, the second problem is that surefire.forkNumber is
 expanded only for user.dir property and not for actual working directory
 (it leads to the situations like described here:
 http://stackoverflow.com/questions/1234795/why-is-the-user-dir-system-property-working-in-java).
 Attaching patch that resolves both problems for us (without test cases
 yet). Asking for a permission to create a JIRA.

 workingDirectorydirectory_${surefire.forkNumber}/workingDirectory

 Regards,
 Norbert


 -
 To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
 For additional commands, e-mail: dev-h...@maven.apache.org



Surefire Plugin does not handle workingDirectory in fork mode properly

2015-01-18 Thread Norbert Wnuk
Hi All,
Not sure whether this is a proper place however Surefire webpage redirects
to this mailing group.
Recently we found two issues in Surefire plugin related to
surefire.forkNumber variable and ability to define separate working
directory per forked JVM. First issue is that the same directory is set for
each of forked JVMs, the second problem is that surefire.forkNumber is
expanded only for user.dir property and not for actual working directory
(it leads to the situations like described here:
http://stackoverflow.com/questions/1234795/why-is-the-user-dir-system-property-working-in-java).
Attaching patch that resolves both problems for us (without test cases
yet). Asking for a permission to create a JIRA.

workingDirectorydirectory_${surefire.forkNumber}/workingDirectory

Regards,
Norbert

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org