Re: maven git commit: better plugin/extensions realm parent classloader
Opened https://jira.codehaus.org/browse/MNG-5752, thank you for the
reminder.
The change does not affect classloading of normal maven runtime, so
there is no need to update the diagram or documentation. Speaking of
which, that documentation is somewhat outdated and does not mention core
extensions realm, for example. I meant to update it some time ago, but
could not find the sources of the diagram. Does anyone know where they are?
I do not believe this change deserves dedicated integration test, at
least not in maven. There is only so many ways you can access system
classloader and if anyone decides to change this in the future javadoc
comment should give enough context.
--
Regards,
Igor
On 2015-01-11 11:17, Hervé BOUTEMY wrote:
please:
1. create a Jira issue
2. update our Class loading documentation [1] with MNG and Maven version
reference
then ideally, having a core IT to show what difference is expected from new
code would be great (I don't know how hard this one can be)
Regards,
Hervé
[1] https://cwiki.apache.org/confluence/display/MAVEN/Maven+3.x+Class+Loading
Le jeudi 8 janvier 2015 13:09:10 ifedore...@apache.org a écrit :
Repository: maven
Updated Branches:
refs/heads/master 5f71f9789 - bb4988496
better plugin/extensions realm parent classloader
Signed-off-by: Igor Fedorenko ifedore...@apache.org
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/bb498849
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/bb498849
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/bb498849
Branch: refs/heads/master
Commit: bb4988496a0e3b50ee5a1922bcd54f731eb2d5b2
Parents: 5f71f97
Author: Igor Fedorenko ifedore...@apache.org
Authored: Thu Jan 8 08:08:42 2015 -0500
Committer: Igor Fedorenko ifedore...@apache.org
Committed: Thu Jan 8 08:08:47 2015 -0500
--
.../maven/classrealm/DefaultClassRealmManager.java| 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/bb498849/maven-core/src/ma
in/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
-- diff
--git
a/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmMan
ager.java
b/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmMan
ager.java index 3584d53..a5bb352 100644
---
a/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmMan
ager.java +++
b/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmMan
ager.java @@ -59,6 +59,16 @@ public class DefaultClassRealmManager
implements ClassRealmManager
{
+/**
+ * During normal command line build, ClassWorld is loaded by jvm system
classloader, which only includes + * plexus-classworlds jar and
possibly javaagent classes, see http://jira.codehaus.org/browse/MNG-4747. +
* p
+ * Using ClassWorld to determine plugin/extensions realm parent
classloaders gives m2e and integration test harness + * flexibility to
load multiple version of maven into dedicated classloaders without assuming
state of jvm system + * classloader.
+ */
+private static final ClassLoader PARENT_CLASSLOADER =
ClassWorld.class.getClassLoader(); +
@Requirement
private Logger logger;
@@ -329,7 +339,7 @@ public class DefaultClassRealmManager
throw new IllegalArgumentException( extension plugin missing
); }
-ClassLoader parent = ClassLoader.getSystemClassLoader();
+ClassLoader parent = PARENT_CLASSLOADER;
MapString, ClassLoader foreignImports =
Collections.String, ClassLoadersingletonMap( ,
getMavenApiRealm() ); @@ -347,7 +357,7 @@ public class
DefaultClassRealmManager
if ( parent == null )
{
-parent = ClassLoader.getSystemClassLoader();
+parent = PARENT_CLASSLOADER;
}
return createRealm( getKey( plugin, false ), RealmType.Plugin,
parent, parentImports, foreignImports, artifacts );
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
Re: maven git commit: better plugin/extensions realm parent classloader
Le dimanche 11 janvier 2015 12:19:01 Igor Fedorenko a écrit :
Opened https://jira.codehaus.org/browse/MNG-5752, thank you for the
reminder.
thank you: I now better understand the reasoning
The change does not affect classloading of normal maven runtime, so
there is no need to update the diagram or documentation.
IIUC, in the Wiki, what is currently described as system classloader is now
initial classloader, containing classworlds, which is the system when using
CLI but may be another classloader in other situations where Maven is
integrated
Speaking of
which, that documentation is somewhat outdated and does not mention core
extensions realm, for example. I meant to update it some time ago, but
could not find the sources of the diagram. Does anyone know where they are?
if you look at attachements, there is a svg associated with the png image
I do not believe this change deserves dedicated integration test, at
least not in maven. There is only so many ways you can access system
classloader and if anyone decides to change this in the future javadoc
comment should give enough context.
ok
Regards,
Hervé
--
Regards,
Igor
On 2015-01-11 11:17, Hervé BOUTEMY wrote:
please:
1. create a Jira issue
2. update our Class loading documentation [1] with MNG and Maven version
reference
then ideally, having a core IT to show what difference is expected from
new
code would be great (I don't know how hard this one can be)
Regards,
Hervé
[1]
https://cwiki.apache.org/confluence/display/MAVEN/Maven+3.x+Class+Loading
Le jeudi 8 janvier 2015 13:09:10 ifedore...@apache.org a écrit :
Repository: maven
Updated Branches:
refs/heads/master 5f71f9789 - bb4988496
better plugin/extensions realm parent classloader
Signed-off-by: Igor Fedorenko ifedore...@apache.org
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/bb498849
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/bb498849
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/bb498849
Branch: refs/heads/master
Commit: bb4988496a0e3b50ee5a1922bcd54f731eb2d5b2
Parents: 5f71f97
Author: Igor Fedorenko ifedore...@apache.org
Authored: Thu Jan 8 08:08:42 2015 -0500
Committer: Igor Fedorenko ifedore...@apache.org
Committed: Thu Jan 8 08:08:47 2015 -0500
--
.../maven/classrealm/DefaultClassRealmManager.java| 14
--
1 file changed, 12 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/maven/blob/bb498849/maven-core/src
/ma in/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
--
diff
--git
a/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmM
an
ager.java
b/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmM
an
ager.java index 3584d53..a5bb352 100644
---
a/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmM
an
ager.java +++
b/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmM
an
ager.java @@ -59,6 +59,16 @@ public class DefaultClassRealmManager
implements ClassRealmManager
{
+/**
+ * During normal command line build, ClassWorld is loaded by jvm
system classloader, which only includes + * plexus-classworlds jar
and possibly javaagent classes, see
http://jira.codehaus.org/browse/MNG-4747. +
* p
+ * Using ClassWorld to determine plugin/extensions realm parent
classloaders gives m2e and integration test harness + * flexibility
to
load multiple version of maven into dedicated classloaders without
assuming
state of jvm system + * classloader.
+ */
+private static final ClassLoader PARENT_CLASSLOADER =
ClassWorld.class.getClassLoader(); +
@Requirement
private Logger logger;
@@ -329,7 +339,7 @@ public class DefaultClassRealmManager
throw new IllegalArgumentException( extension plugin
missing
); }
-ClassLoader parent = ClassLoader.getSystemClassLoader();
+ClassLoader parent = PARENT_CLASSLOADER;
MapString, ClassLoader foreignImports =
Collections.String, ClassLoadersingletonMap( ,
getMavenApiRealm() ); @@ -347,7 +357,7 @@ public class
DefaultClassRealmManager
if ( parent == null )
{
-parent = ClassLoader.getSystemClassLoader();
+parent = PARENT_CLASSLOADER;
}
return createRealm( getKey( plugin, false ), RealmType.Plugin,
parent, parentImports, foreignImports, artifacts
Re: maven git commit: better plugin/extensions realm parent classloader
On 2015-01-11 14:48, Hervé BOUTEMY wrote: The change does not affect classloading of normal maven runtime, so there is no need to update the diagram or documentation. IIUC, in the Wiki, what is currently described as system classloader is now initial classloader, containing classworlds, which is the system when using CLI but may be another classloader in other situations where Maven is integrated The change does not affect what is described as System Class Loader at all. It only affects the parent of Project Class Loader and Plugin Class Loader and only when Maven is embedded in other runtimes. The wiki does not document the plugin/project classloader parent and it explicitly avoids talking about embedding scenarios. The change is out of scope of the information provided on the wiki. Speaking of which, that documentation is somewhat outdated and does not mention core extensions realm, for example. I meant to update it some time ago, but could not find the sources of the diagram. Does anyone know where they are? if you look at attachements, there is a svg associated with the png image Unfortunately, I am not fluent enough in SVG to make the changes (and the file looks generated to me). -- Regards, Igor - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: plugin extensions
It is an optimisation to ensure you don't need to look at all of the plugins first. Possibly a better alternative is to resolve plugins in two phases (get all the plugins up front, figure this stuff out, get dependencies of the plugins later when the code is actually executed). I think that is the only reason it is of benefit. - Brett Kenney Westerhof wrote: Hi, I was wondering if the pluginextensionstrue couldn't be auto-detected by maven by looking at the components.xml in the plugin's jar or something similar, or wheter it could on by default. It seems that when a plugin defines packaging/lifecycle extensions and you do not specify extensionstrue/extensions you get a ComponentLookupException (Error looking up lifecycle mapping ...). I haven't looked at the code yet but I'm wondering why this manual step is necessary. The project model descriptor says it's disabled by default for performance reasons. I don't understand why this can have a performance impact, since maven-core also defines lifecycle mappings, and a plugin's components.xml is processed anyway (again, I haven't looked at the code). Btw, what's happened to the idea of having a discussion queue of 5 items for design issues? -- Kenney -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Brett Porter [EMAIL PROTECTED] Apache Maven - http://maven.apache.org/ Better Builds with Maven - http://library.mergere.com/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
plugin extensions
Hi, I was wondering if the pluginextensionstrue couldn't be auto-detected by maven by looking at the components.xml in the plugin's jar or something similar, or wheter it could on by default. It seems that when a plugin defines packaging/lifecycle extensions and you do not specify extensionstrue/extensions you get a ComponentLookupException (Error looking up lifecycle mapping ...). I haven't looked at the code yet but I'm wondering why this manual step is necessary. The project model descriptor says it's disabled by default for performance reasons. I don't understand why this can have a performance impact, since maven-core also defines lifecycle mappings, and a plugin's components.xml is processed anyway (again, I haven't looked at the code). Btw, what's happened to the idea of having a discussion queue of 5 items for design issues? -- Kenney -- Kenney Westerhof http://www.neonics.com GPG public key: http://www.gods.nl/~forge/kenneyw.key - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=all ] John Casey updated MNG-1323: Fix Version: (was: 2.0.3) 2.0.4 Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: Plugins and Lifecycle Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.4 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_54941 ] ruel loehr commented on MNG-1323: - Are there any suggested work arounds for this issue?Hence, if I wish to use a custom ant task in a child module (which would require a dependency upon the antrun plugin), how would I accomplish it, or is it impossible at this time? Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: Plugins and Lifecycle Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.3 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_54948 ] Brett Porter commented on MNG-1323: --- workaround is to include the dependency in the first antrun plugin instance encountered. one way to guarantee would be to include this in the root project. Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: Plugins and Lifecycle Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.3 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_54612 ] Georges Polyzois commented on MNG-1323: --- Is this beeing resolved? I have exactly this problem as Kenney stated on 04/Nov/05. I am using Maven 2.0.1 and even changed to using antrun version 1.1-SNAPSHOT - with no sucess. Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: Plugins and Lifecycle Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.3 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_54633 ] Brett Porter commented on MNG-1323: --- note above that this is scheduled for 2.0.3 (Feb release). Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: Plugins and Lifecycle Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.3 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=all ] John Casey updated MNG-1323: Fix Version: (was: 2.0.1) 2.0.2 Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: Plugins and Lifecycle Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.2 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_50268 ] John Casey commented on MNG-1323: - It looks like some of the work I did to get the ant-mojo support up and running was related to this. Kenney's 04/Nov/2005 post was related to my fix for the ant-mojo stuff... I added code to search the project instance for a matching Plugin instance before I used the current Plugin instance to verify the plugin. This is key here, since the one constructed by the lifecycle executor may not have any of the project's plugin-dependencies in it. NOW, as for the latest incarnation of the problem, this is undoubtedly caused by Maven not disposing of plugin containers between project builds. If we did this, we would have the added benefit of cleaning out plugin-extensions (though we'd have to be *very* careful about this last, since it means cleaning up things like the ArtifactHandlerManager, too). Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.1 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Closed: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=all ] Kenney Westerhof closed MNG-1323: - Resolution: Fixed Somehow the problem has gone away! Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.1 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_50020 ] Brett Porter commented on MNG-1323: --- did you test it with 2.0 or 2.0.1? Maybe this should be closed as cannot reproduce? Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.1 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Reopened: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=all ] Kenney Westerhof reopened MNG-1323: --- The issue is a bit different - i got it reproducible now. It seems, in the following situation: root/pom.xml, modules: a, b a/pom.xml: define antrun, with any tasks (like echo/) b/pom.xml: define antrun, with dependencies section. When run from 'root', dependencies are not resolved for plugin antrun in project b. Probably because the plugin is already 'resolved' the different dependencies for this instance are not resolved. Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.1 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=all ] Brett Porter updated MNG-1323: -- Description: I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. was: I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. Fix Version: 2.0.1 Environment: is this because they are not inherited, rather than anything to do with the reactor? Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.1 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
[ http://jira.codehaus.org/browse/MNG-1323?page=comments#action_50012 ] Kenney Westerhof commented on MNG-1323: --- I don't think so - inheritance doesn't play a role. The parent-pom is just an empty pom stating 1 module - the pom discussed above. I'll find the it for it and augment it for this issue. Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof Fix For: 2.0.1 I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (MNG-1323) Plugin extensions (dependencies) not resolved in reactor build
Plugin extensions (dependencies) not resolved in reactor build -- Key: MNG-1323 URL: http://jira.codehaus.org/browse/MNG-1323 Project: Maven 2 Type: Bug Components: maven-core Versions: 2.0 Reporter: Kenney Westerhof I've added a dependency on an Ant Task in project/build/plugins/plugin[artifactId='maven-antrun-plugin']/dependencies/ and run that anttask using the antrun plugin. When run from the project dir itself it runs fine. When running from the root of the project tree (reactor build, project one level below root), antrun bails out because the taskdef can't be found (not on classpath). It looks like the dependency isn't resolved, or not added to the plugins' classrealm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
