[GitHub] [maven-shared-jar] slachiewicz edited a comment on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies
slachiewicz edited a comment on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636472449 See other jira and commit https://github.com/apache/maven-shared-jar/commit/580f53c1b63a7630cb3a70822035f4531bfadf2b This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-shared-jar] elharo merged pull request #3: ignore more metadata files
elharo merged pull request #3: URL: https://github.com/apache/maven-shared-jar/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-shared-jar] elharo commented on pull request #4: [MSHARED-905] set Maven 3.1.0 as minimum and cleanup dependencies
elharo commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636474949 That code doesn't seem to be in HEAD? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-shared-jar] slachiewicz commented on pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies
slachiewicz commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636504356 I use the plexus version that was imported by the Maven 3.1 dependencies (3.1.1 already has a different version). It seems to me that if we use a newer version of Plexus and someone uses the classes/methods that were available before then this plugin may not work properly. I think Maven 3.1 will use artifacts that are provided by Core (https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo merged pull request #172: docs: https links
elharo merged pull request #172: URL: https://github.com/apache/maven-site/pull/172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-shared-jar] elharo commented on pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies
elharo commented on pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4#issuecomment-636486988 @slachiewicz After looking at that commit, the difference seems to be that this PR imports plexus-containers-default and that one imports org.eclipse.sisu.plexus. I'm not sure why one should be chosen over the other or why two different artifacts provide the same classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-shared-jar] elharo closed pull request #4: [MSHARED-887] set Maven 3.1.0 as minimum and cleanup dependencies
elharo closed pull request #4: URL: https://github.com/apache/maven-shared-jar/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo opened a new pull request #29: [MSITE-861] remove obsolete dependency
elharo opened a new pull request #29: URL: https://github.com/apache/maven-site-plugin/pull/29 @michael-o exclusion no longer necessary with latest doxias [INFO] +- org.apache.maven.doxia:doxia-site-renderer:jar:1.9.2:compile [INFO] | +- org.apache.maven.doxia:doxia-skin-model:jar:1.9.2:compile [INFO] | +- org.codehaus.plexus:plexus-velocity:jar:1.2:compile [INFO] | +- org.apache.velocity:velocity:jar:1.7:compile [INFO] | | \- commons-lang:commons-lang:jar:2.4:compile [INFO] | +- org.apache.velocity:velocity-tools:jar:2.0:compile [INFO] | | +- commons-beanutils:commons-beanutils:jar:1.7.0:compile [INFO] | | +- commons-digester:commons-digester:jar:1.8:compile [INFO] | | +- commons-chain:commons-chain:jar:1.1:compile [INFO] | | +- dom4j:dom4j:jar:1.1:compile [INFO] | | \- oro:oro:jar:2.0.8:compile [INFO] | \- commons-collections:commons-collections:jar:3.2.2:compile This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] asfgit closed pull request #12: [MSITE-845] Drop Maven 2 support
asfgit closed pull request #12: URL: https://github.com/apache/maven-site-plugin/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] slachiewicz closed pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5
slachiewicz closed pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] elharo opened a new pull request #12: [MNGSITE-393] drop Maven 2
elharo opened a new pull request #12: URL: https://github.com/apache/maven-artifact-transfer/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo merged pull request #24: [MSITE-757] remove Maven 2 support
elharo merged pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-artifact-transfer] elharo merged pull request #12: [MNGSITE-393] drop Maven 2
elharo merged pull request #12: URL: https://github.com/apache/maven-artifact-transfer/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo merged pull request #171: docs: remove links that don't go where they say
elharo merged pull request #171: URL: https://github.com/apache/maven-site/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] slachiewicz commented on pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5
slachiewicz commented on pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27#issuecomment-633969397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo opened a new pull request #28: docs: use https
elharo opened a new pull request #28: URL: https://github.com/apache/maven-site-plugin/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo merged pull request #26: [MSITE-757] drop Maven 2 mention
elharo merged pull request #26: URL: https://github.com/apache/maven-site-plugin/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] slachiewicz commented on pull request #24: [MSITE-845] remove Maven 2 support
slachiewicz commented on pull request #24: URL: https://github.com/apache/maven-site-plugin/pull/24#issuecomment-633713346 Ok #12 merged to master. Please rebase a d resolve conflicts in this pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] slachiewicz opened a new pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5
slachiewicz opened a new pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo merged pull request #29: [MSITE-861] remove obsolete dependency
elharo merged pull request #29: URL: https://github.com/apache/maven-site-plugin/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo merged pull request #28: docs: use https
elharo merged pull request #28: URL: https://github.com/apache/maven-site-plugin/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo commented on pull request #27: [MSITE-757] More cleanup after upgrade to Maven 3.0.5
elharo commented on pull request #27: URL: https://github.com/apache/maven-site-plugin/pull/27#issuecomment-634132747 seems to have broken Jenkins: https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/master/99/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] elharo opened a new pull request #26: [MSITE-845] drop Maven 2 mention
elharo opened a new pull request #26: URL: https://github.com/apache/maven-site-plugin/pull/26 @olamy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dadon-david commented on pull request #200: Fix Create the archetype descriptor example
dadon-david commented on pull request #200: URL: https://github.com/apache/maven-site/pull/200#issuecomment-695781151 Hi @michael-o :) Thank you for your rapid response, Maybe I didn't explained my PR enough, sorry if this is the case. On the existing `maven-archetype-quickstart` the `targetNamespace` on the XSD match the `xmlns` on the XML . So I thought it would solve my problem. [Source code here](https://github.com/apache/maven-archetypes/blob/maven-archetype-bundles-1.4/maven-archetype-quickstart/src/main/resources/META-INF/maven/archetype-metadata.xml) ``` http://www.w3.org/2001/XMLSchema; xmlns="http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.0.0; elementFormDefault="qualified" targetNamespace="http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.0.0;> ``` ``` http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.0.0 http://maven.apache.org/xsd/archetype-descriptor-1.0.0.xsd; name="quickstart" partial="false"> ``` The reason why I am opening this PR is because, without having `targetNamespace` and `xmlns` that match my IDE (IDEA 2020.2) can't find the associated schema and is in error (See the image below) I tried to fix this, to register it and to change many settings on the IDE side without success. And simply changing the namespace solved my issue. Maybe I miss something obvious or maybe it's a bug on IDEA. I've read a bit about XML and Namespace before opening this PR, maybe misunderstood something. In any case I would love to have a small explanation from you, With `targetNamespace` != `xmlns`  With `targetNamespace` == `xmlns`  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on pull request #200: Fix Create the archetype descriptor example
elharo commented on pull request #200: URL: https://github.com/apache/maven-site/pull/200#issuecomment-695782562 The problem is in IntelliJ. It's assuming things about the relationships between namespaces and schemas that simply aren't true. The Maven code is correct. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on pull request #200: Fix Create the archetype descriptor example
michael-o commented on pull request #200: URL: https://github.com/apache/maven-site/pull/200#issuecomment-695752443 Learn namespace first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o closed pull request #200: Fix Create the archetype descriptor example
michael-o closed pull request #200: URL: https://github.com/apache/maven-site/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dadon-david opened a new pull request #200: Fix Create the archetype descriptor example
dadon-david opened a new pull request #200: URL: https://github.com/apache/maven-site/pull/200 Hello :) The the `targetNamespace` of the [Archetype Descriptor XML Schema Definition](https://maven.apache.org/xsd/archetype-descriptor-1.1.0.xsd) is > http**s**://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.1.0 The namespace used in this file is > http://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.1.0 In the example, the `s` was missing from `http`, this PR fix that. Thank you very much for all the work down in this project, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dadon-david commented on pull request #200: Fix Create the archetype descriptor example
dadon-david commented on pull request #200: URL: https://github.com/apache/maven-site/pull/200#issuecomment-695782987 Hi @elharo, So IntelliJ fooled me :p Thanks for your answer, I will open a ticket on their side, Have a nice day, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] hboutemy commented on pull request #211: Fixes custom header configuration example
hboutemy commented on pull request #211: URL: https://github.com/apache/maven-site/pull/211#issuecomment-715441132 issue/fix found with https://github.com/mattjohnson/maven_custom_headers Maven setup and checking headers at server level tested with recent Maven version, no idea if there was a parameter renaming during Maven code evolution, or if the doc was just not updated while implementing what looked a proposal https://github.com/apache/maven-site/commit/8e6560a54941610a688f220d641ea760dca20a60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
michael-o commented on a change in pull request #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r512931043
##
File path: content/apt/guides/mini/guide-http-settings.apt
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 180ms (~30 minutes) (see section <<>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<>> below)
Review comment:
World's end is neither Rio Grande nor 49th parallel north.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
michael-o commented on a change in pull request #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r512929903
##
File path: content/apt/guides/mini/guide-http-settings.apt
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 180ms (~30 minutes) (see section <<>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<>> below)
Review comment:
Of course, there are:
https://www.bipm.org/utils/common/pdf/si-brochure/SI-Brochure-9-concise-EN.pdf
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
elharo commented on a change in pull request #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r512893365
##
File path: content/apt/guides/mini/guide-http-settings.apt
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 180ms (~30 minutes) (see section <<>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<>> below)
Review comment:
I don't think there's any international standard on this unlike, for
example, dates; and this page is written in English.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info
michael-o commented on a change in pull request #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r512845349
##
File path: content/apt/guides/mini/guide-http-settings.apt
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
- * readTimeout: default to 180ms (~30 minutes) (see section <<>> below)
+ * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<>> below)
Review comment:
` 1 800 000 ms`
##
File path: content/apt/guides/mini/guide-http-settings.apt
##
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
You can use the default wagon implementation for a given
protocol, or you can select an alternative wagon <<>> on a
per-protocol basis.
For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon
Providers}} \[3\].
- The default wagon http(s) is the HttpClient based on
{{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
- HTTP connection pooling prevents reopening http(s) to remote server for each
requests.
+ The default wagon http(s) is the HttpClient based on
{{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+ HTTP connection pooling prevents reopening new connections to the same
server for each request.
This pool feature is configurable with some parameters \[4\].
The default wagon comes with some default configuration:
* http(s) connection pool: default to 20.
Review comment:
It is somewhat incomplete:
https://github.com/apache/maven-wagon/blob/9b4f2fee4b0460aa16dee90d37a49440f09ed0db/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L286-L295
##
File path: content/apt/guides/mini/guide-http-settings.apt
##
@@ -88,7 +88,7 @@ the target server's authentication.
problems with HTTP servers and proxies that do not support HTTP/1.1 protocol.
-
- Without this setting, PUT requests that require authentication will transfer
their entire payload to the server before that server
+ Without this setting, PUT requests that require authentication transfer
their entire payload to the server before that server
Review comment:
This has been on by default for quite some time:
https://github.com/apache/maven-wagon/blob/9b4f2fee4b0460aa16dee90d37a49440f09ed0db/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L963-L967
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #36: Bump commons-lang3 from 3.8.1 to 3.11
dependabot[bot] opened a new pull request #36: URL: https://github.com/apache/maven-doxia/pull/36 Bumps commons-lang3 from 3.8.1 to 3.11. [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #181: grammar nit subject verb agreement
elharo opened a new pull request #181: URL: https://github.com/apache/maven-site/pull/181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #180: grammar nit: an -> a
elharo opened a new pull request #180: URL: https://github.com/apache/maven-site/pull/180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] garydgregory commented on pull request #32: install dependabot
garydgregory commented on pull request #32: URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-665593051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #185: docs: omit needless words
elharo opened a new pull request #185: URL: https://github.com/apache/maven-site/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #186: maven-dependency-analyzer 1.11.2 release
elharo opened a new pull request #186: URL: https://github.com/apache/maven-site/pull/186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] elharo merged pull request #4: [MSHARED-933] set Maven 3.1.0 as minimum supported version
elharo merged pull request #4: URL: https://github.com/apache/maven-project-utils/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #188: Introduce section heading for BOM pattern
michael-o commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463952483
##
File path:
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
* {{{Importing_Dependencies}Importing Dependencies}}
+ * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
Review comment:
That is not what I was referring to.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mkarg commented on a change in pull request #188: Introduce section heading for BOM pattern
mkarg commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463934565
##
File path:
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
* {{{Importing_Dependencies}Importing Dependencies}}
+ * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
Review comment:
I think what Ed wanted to say with this is correct: "Bill of Material -
style POM, a.k.a. BOM"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #188: Introduce section heading for BOM pattern
michael-o commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463934456
##
File path:
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
* {{{Importing_Dependencies}Importing Dependencies}}
+ * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
Review comment:
poms > POMs
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] edburns commented on pull request #188: Introduce section heading for BOM pattern
edburns commented on pull request #188: URL: https://github.com/apache/maven-site/pull/188#issuecomment-668297271 @michael-o I applied the suggested changes and squashed it to one commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #191: docs: system dependencies are not always available
elharo commented on a change in pull request #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r465312675 ## File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt ## @@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism unit tests (src/test/java) but not in the model code (src/main/java). * <>\ - This scope is similar to <<>> except that you have to provide the JAR - which contains it explicitly. The artifact is always available and is not - looked up in a repository. + Maven does not add system-scoped dependencies to any classpath. Review comment: They're usually (though not always) in the classpath but Maven doesn't put them there. The JVM (or something else) does. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available
michael-o commented on a change in pull request #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r465301282 ## File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt ## @@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism unit tests (src/test/java) but not in the model code (src/main/java). * <>\ - This scope is similar to <<>> except that you have to provide the JAR - which contains it explicitly. The artifact is always available and is not - looked up in a repository. + Maven does not add system-scoped dependencies to any classpath. Review comment: If it is not added to a classpath, what's the point in having them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available
michael-o commented on a change in pull request #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r465335645 ## File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt ## @@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism unit tests (src/test/java) but not in the model code (src/main/java). * <>\ - This scope is similar to <<>> except that you have to provide the JAR - which contains it explicitly. The artifact is always available and is not - looked up in a repository. + Maven does not add system-scoped dependencies to any classpath. Review comment: I don't see the maybe in the modified text. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available
michael-o commented on a change in pull request #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r465314300 ## File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt ## @@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism unit tests (src/test/java) but not in the model code (src/main/java). * <>\ - This scope is similar to <<>> except that you have to provide the JAR - which contains it explicitly. The artifact is always available and is not - looked up in a repository. + Maven does not add system-scoped dependencies to any classpath. Review comment: But at least for compilation purposes it is in the classpath or maybe at runtime available. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #191: docs: system dependencies are not always available
elharo commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465334195
##
File path:
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
unit tests (src/test/java) but not in the model code (src/main/java).
* <>\
- This scope is similar to <<>> except that you have to provide the
JAR
- which contains it explicitly. The artifact is always available and is not
- looked up in a repository.
+ Maven does not add system-scoped dependencies to any classpath.
Review comment:
The keyword is "maybe". There's no guarantee it is, and the current text
makes it sound like this is guaranteed. The case that made me pay attention to
this was Guava doing a complicated dance to load src.zip for use in javaDoc:
```
srczip-parent
${java.home}/../src.zip
jdk
srczip
999
system
${java.home}/../src.zip
true
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #191: docs: system dependencies are not always available
elharo commented on a change in pull request #191: URL: https://github.com/apache/maven-site/pull/191#discussion_r468747113 ## File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt ## @@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism unit tests (src/test/java) but not in the model code (src/main/java). * <>\ - This scope is similar to <<>> except that you have to provide the JAR - which contains it explicitly. The artifact is always available and is not - looked up in a repository. + Maven does not add system-scoped dependencies to any classpath. Review comment: I was referring to the "maybe"in your comment. :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] edburns commented on pull request #188: Introduce section heading for BOM pattern
edburns commented on pull request #188: URL: https://github.com/apache/maven-site/pull/188#issuecomment-672292707 Hello, this is approved. Can someone please merge it, or let me know what I need to do to have it merged? Thanks, Ed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] olamy merged pull request #188: Introduce section heading for BOM pattern
olamy merged pull request #188: URL: https://github.com/apache/maven-site/pull/188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] asfgit closed pull request #165: docs: git migration is complete
asfgit closed pull request #165: URL: https://github.com/apache/maven-site/pull/165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] slachiewicz commented on pull request #165: docs: git migration is complete
slachiewicz commented on pull request #165: URL: https://github.com/apache/maven-site/pull/165#issuecomment-672632977 Yes, we have only few remaining - but this info is longer interesting to wider forum. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo merged pull request #190: grammar nit: subject verb agreement
elharo merged pull request #190: URL: https://github.com/apache/maven-site/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #191: docs: system dependencies are not always available
elharo opened a new pull request #191: URL: https://github.com/apache/maven-site/pull/191 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #187: [MNGSITE-419] 3.3.9 or later is required to build
elharo opened a new pull request #187: URL: https://github.com/apache/maven-site/pull/187 @dennisl This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] elharo opened a new pull request #4: set Maven 3.1.0 as minimum supported version
elharo opened a new pull request #4: URL: https://github.com/apache/maven-project-utils/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] edburns commented on pull request #188: Introduce section heading for BOM pattern
edburns commented on pull request #188: URL: https://github.com/apache/maven-site/pull/188#issuecomment-667405962 Given how important BOM poms are, I think they deserve a section heading here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] edburns opened a new pull request #188: Introduce section heading for BOM pattern
edburns opened a new pull request #188:
URL: https://github.com/apache/maven-site/pull/188
modified:
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
- TOC:* {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
- ** {Bill of Materials (BOM) poms}
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #190: grammar nit: subject verb agreement
elharo opened a new pull request #190: URL: https://github.com/apache/maven-site/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dennisl opened a new pull request #189: Maven Shared Utils 3.3.3
dennisl opened a new pull request #189: URL: https://github.com/apache/maven-site/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dennisl opened a new pull request #192: maven-resources-plugin-3.2.0
dennisl opened a new pull request #192: URL: https://github.com/apache/maven-site/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dennisl opened a new pull request #193: maven-filtering-3.2.0
dennisl opened a new pull request #193: URL: https://github.com/apache/maven-site/pull/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] olamy merged pull request #189: Maven Shared Utils 3.3.3
olamy merged pull request #189: URL: https://github.com/apache/maven-site/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] olamy merged pull request #192: maven-resources-plugin-3.2.0
olamy merged pull request #192: URL: https://github.com/apache/maven-site/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] olamy merged pull request #193: maven-filtering-3.2.0
olamy merged pull request #193: URL: https://github.com/apache/maven-site/pull/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo opened a new pull request #179: small grammar improvements; add periods and fix run-on sentences
elharo opened a new pull request #179: URL: https://github.com/apache/maven-site/pull/179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dpd73 opened a new pull request #178: [MNGSITE-408] Fix alignment of events logo
dpd73 opened a new pull request #178: URL: https://github.com/apache/maven-site/pull/178 Submitted by: David Pead o change events to float left This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo merged pull request #178: [MNGSITE-408] Fix alignment of events logo
elharo merged pull request #178: URL: https://github.com/apache/maven-site/pull/178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] elharo merged pull request #179: small grammar improvements; add periods and fix run-on sentences
elharo merged pull request #179: URL: https://github.com/apache/maven-site/pull/179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dpd73 opened a new pull request #177: Bug/mngsite 416 getting started gives build failure
dpd73 opened a new pull request #177: URL: https://github.com/apache/maven-site/pull/177 https://issues.apache.org/jira/browse/MNGSITE-416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders removed a comment on pull request #177: Bug/mngsite 416 getting started gives build failure
mthmulders removed a comment on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657210544 Thanks for updating this guide! Overall it looks good to me, I have left one small remark. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders commented on a change in pull request #177: Bug/mngsite 416 getting started gives build failure
mthmulders commented on a change in pull request #177: URL: https://github.com/apache/maven-site/pull/177#discussion_r453305679 ## File path: content/apt/guides/getting-started/index.apt ## @@ -370,40 +378,47 @@ mvn install Upon executing this command you should see the following output: -[INFO] -[INFO] Building Maven Quick Start Archetype -[INFO]task-segment: [install] -[INFO] -[INFO] [resources:resources] -[INFO] [compiler:compile] -Compiling 1 source file to /my-app/target/classes -[INFO] [resources:testResources] -[INFO] [compiler:testCompile] -Compiling 1 source file to /my-app/target/test-classes -[INFO] [surefire:test] -[INFO] Setting reports dir: /my-app/target/surefire-reports - - T E S T S -[surefire] Running com.mycompany.app.AppTest -[surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.001 sec - -Results : -[surefire] Tests run: 1, Failures: 0, Errors: 0 - -[INFO] [jar:jar] +[INFO] Scanning for projects... +[INFO] +[INFO] --< com.mycompany.app:my-app >-- +[INFO] Building my-app 1.0-SNAPSHOT +[INFO] [ jar ]- +[INFO] +[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ my-app --- +... +[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ my-app --- +[INFO] Nothing to compile - all classes are up to date +[INFO] +[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ my-app --- +... +[INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ my-app --- +[INFO] Nothing to compile - all classes are up to date +[INFO] +[INFO] --- maven-surefire-plugin:2.22.1:test (default-test) @ my-app --- +[INFO] +[INFO] --- +[INFO] T E S T S +[INFO] --- +[INFO] Running com.mycompany.app.AppTest +[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 s - in com.mycompany.app.AppTest +[INFO] +[INFO] Results: +[INFO] +[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 +[INFO] +[INFO] +[INFO] --- maven-jar-plugin:3.0.2:jar (default-jar) @ my-app --- [INFO] Building jar: /my-app/target/my-app-1.0-SNAPSHOT.jar -[INFO] [install:install] -[INFO] Installing /my-app/target/my-app-1.0-SNAPSHOT.jar to \ - /com/mycompany/app/my-app/1.0-SNAPSHOT/my-app-1.0-SNAPSHOT.jar -[INFO] -[INFO] BUILD SUCCESSFUL -[INFO] -[INFO] Total time: 5 seconds -[INFO] Finished at: Tue Oct 04 13:20:32 GMT-05:00 2005 -[INFO] Final Memory: 3M/8M -[INFO] +[INFO] +[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ my-app --- +[INFO] Installing /my-app/target/my-app-1.0-SNAPSHOT.jar to local-repository/com/mycompany/app/my-app/1.0-SNAPSHOT/my-app-1.0-SNAPSHOT.jar +[INFO] Installing /dir>/my-app/pom.xml to /local-repository/com/mycompany/app/my-app/1.0-SNAPSHOT/my-app-1.0-SNAPSHOT.pom Review comment: I think `/local-repository` should read `` in both lines. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders commented on pull request #177: Bug/mngsite 416 getting started gives build failure
mthmulders commented on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657210544 Thanks for updating this guide! Overall it looks good to me, I have left one small remark. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] dpd73 commented on a change in pull request #177: Bug/mngsite 416 getting started gives build failure
dpd73 commented on a change in pull request #177: URL: https://github.com/apache/maven-site/pull/177#discussion_r453312612 ## File path: content/apt/guides/getting-started/index.apt ## @@ -370,40 +378,47 @@ mvn install Upon executing this command you should see the following output: -[INFO] -[INFO] Building Maven Quick Start Archetype -[INFO]task-segment: [install] -[INFO] -[INFO] [resources:resources] -[INFO] [compiler:compile] -Compiling 1 source file to /my-app/target/classes -[INFO] [resources:testResources] -[INFO] [compiler:testCompile] -Compiling 1 source file to /my-app/target/test-classes -[INFO] [surefire:test] -[INFO] Setting reports dir: /my-app/target/surefire-reports - - T E S T S -[surefire] Running com.mycompany.app.AppTest -[surefire] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.001 sec - -Results : -[surefire] Tests run: 1, Failures: 0, Errors: 0 - -[INFO] [jar:jar] +[INFO] Scanning for projects... +[INFO] +[INFO] --< com.mycompany.app:my-app >-- +[INFO] Building my-app 1.0-SNAPSHOT +[INFO] [ jar ]- +[INFO] +[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ my-app --- +... +[INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @ my-app --- +[INFO] Nothing to compile - all classes are up to date +[INFO] +[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ my-app --- +... +[INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @ my-app --- +[INFO] Nothing to compile - all classes are up to date +[INFO] +[INFO] --- maven-surefire-plugin:2.22.1:test (default-test) @ my-app --- +[INFO] +[INFO] --- +[INFO] T E S T S +[INFO] --- +[INFO] Running com.mycompany.app.AppTest +[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 s - in com.mycompany.app.AppTest +[INFO] +[INFO] Results: +[INFO] +[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 +[INFO] +[INFO] +[INFO] --- maven-jar-plugin:3.0.2:jar (default-jar) @ my-app --- [INFO] Building jar: /my-app/target/my-app-1.0-SNAPSHOT.jar -[INFO] [install:install] -[INFO] Installing /my-app/target/my-app-1.0-SNAPSHOT.jar to \ - /com/mycompany/app/my-app/1.0-SNAPSHOT/my-app-1.0-SNAPSHOT.jar -[INFO] -[INFO] BUILD SUCCESSFUL -[INFO] -[INFO] Total time: 5 seconds -[INFO] Finished at: Tue Oct 04 13:20:32 GMT-05:00 2005 -[INFO] Final Memory: 3M/8M -[INFO] +[INFO] +[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ my-app --- +[INFO] Installing /my-app/target/my-app-1.0-SNAPSHOT.jar to local-repository/com/mycompany/app/my-app/1.0-SNAPSHOT/my-app-1.0-SNAPSHOT.jar +[INFO] Installing /dir>/my-app/pom.xml to /local-repository/com/mycompany/app/my-app/1.0-SNAPSHOT/my-app-1.0-SNAPSHOT.pom Review comment: Good catch, done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders edited a comment on pull request #177: Bug/mngsite 416 getting started gives build failure
mthmulders edited a comment on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657255635 Your pull request has been merged. Thanks again for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders commented on pull request #177: Bug/mngsite 416 getting started gives build failure
mthmulders commented on pull request #177: URL: https://github.com/apache/maven-site/pull/177#issuecomment-657255635 Your pull request has been merged into master. Thanks again for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site] mthmulders closed pull request #177: Bug/mngsite 416 getting started gives build failure
mthmulders closed pull request #177: URL: https://github.com/apache/maven-site/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] hboutemy commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser
hboutemy commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447273790 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractXmlParser.java ## @@ -49,18 +32,33 @@ import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet; import org.apache.maven.doxia.util.HtmlTools; import org.apache.maven.doxia.util.XmlValidator; - import org.codehaus.plexus.util.FileUtils; import org.codehaus.plexus.util.IOUtil; import org.codehaus.plexus.util.StringUtils; import org.codehaus.plexus.util.xml.pull.MXParser; import org.codehaus.plexus.util.xml.pull.XmlPullParser; import org.codehaus.plexus.util.xml.pull.XmlPullParserException; - import org.xml.sax.EntityResolver; import org.xml.sax.InputSource; import org.xml.sax.SAXException; +import java.io.BufferedReader; Review comment: is it possible to avoid such reformatting of imports, please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] hboutemy commented on a change in pull request #35: DOXIA-614: support source reference in doxia parser
hboutemy commented on a change in pull request #35: URL: https://github.com/apache/maven-doxia/pull/35#discussion_r447273709 ## File path: doxia-core/src/main/java/org/apache/maven/doxia/parser/AbstractParser.java ## @@ -37,6 +29,13 @@ import org.apache.maven.doxia.sink.Sink; import org.codehaus.plexus.component.annotations.Requirement; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.io.Reader; +import java.io.StringReader; +import java.util.Properties; + Review comment: is it possible to avoid such reformatting of imports, please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] elharo opened a new pull request #2: fill in undeclared dependencies
elharo opened a new pull request #2: URL: https://github.com/apache/maven-project-utils/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] elharo opened a new pull request #3: update JIRA URL
elharo opened a new pull request #3: URL: https://github.com/apache/maven-project-utils/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] elharo opened a new pull request #1: update test dependencies
elharo opened a new pull request #1: URL: https://github.com/apache/maven-project-utils/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-site-plugin] mthmulders commented on pull request #32: install dependabot
mthmulders commented on pull request #32: URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-657116214 > As a general principle I prefer automation over convention. E.g. if we shouldn't use squash commits, then the squash commit button should be disabled on the repo rather than expecting devs not to press it. There are many other examples of this. If there are accepted conventions for code commits, it would be worth investing some time to enforce in our systems. Totally agree with this. If having a JIRA issue is relevant, I could spend some time trying to automate it with a Github action that could follow Dependabot. We'd probably need some kind of non-personal account to ASF JIRA but let's build that bridge when we get there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] slachiewicz merged pull request #1: update test dependencies
slachiewicz merged pull request #1: URL: https://github.com/apache/maven-project-utils/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] slachiewicz merged pull request #2: fill in undeclared dependencies
slachiewicz merged pull request #2: URL: https://github.com/apache/maven-project-utils/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] slachiewicz merged pull request #3: update JIRA URL
slachiewicz merged pull request #3: URL: https://github.com/apache/maven-project-utils/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-project-utils] pzygielo commented on a change in pull request #3: update JIRA URL
pzygielo commented on a change in pull request #3: URL: https://github.com/apache/maven-project-utils/pull/3#discussion_r453213245 ## File path: pom.xml ## @@ -46,7 +46,7 @@ under the License. jira -https://issues.apache.org/jira/browse/MSHARED/component/12329913 + https://issues.apache.org/jira/browse/MSHARED-933?jql=project%20%3D%20MSHARED%20AND%20component%20%3D%20maven-project-utils Review comment: IMO it would be better without reference to specific issue, ie. `https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20component%20%3D%20maven-project-utils`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia-site] elharo opened a new pull request #7: we don't use subversion any more
elharo opened a new pull request #7: URL: https://github.com/apache/maven-doxia-site/pull/7 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia-site] elharo merged pull request #7: we don't use subversion any more
elharo merged pull request #7: URL: https://github.com/apache/maven-doxia-site/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #32: Bump itext from 1.4 to 4.2.1
dependabot[bot] opened a new pull request #32: URL: https://github.com/apache/maven-doxia/pull/32 Bumps [itext](https://github.com/itext/itextpdf) from 1.4 to 4.2.1. Commits See full diff in https://github.com/itext/itextpdf/commits;>compare view [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #31: Bump xmlunit-matchers from 2.6.3 to 2.7.0
dependabot[bot] opened a new pull request #31:
URL: https://github.com/apache/maven-doxia/pull/31
Bumps [xmlunit-matchers](https://github.com/xmlunit/xmlunit) from 2.6.3 to
2.7.0.
Release notes
Sourced from https://github.com/xmlunit/xmlunit/releases;>xmlunit-matchers's
releases.
XMLUnit 2.7.0
The biggest changes are to the placeholder and assertj modules. The
assertj module should now work with AssertJ 3.15+.
This version contains a backwards incompatible change to the
PlaceholderHandler interface that is part of the experimental
placeholders module: The evaluate method now receives a variable
number of string arguments in addition to the textual content of the
element/attribute. This allows placeholders like
${xmlunit.matchesRegex(some\s*regex)}.
the AssertJ tests now pass on non-English locales as well
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/pull/180;>#180
added a workaround for a binary incompatible change in AssertJ that
caused xmlunit-assertj to be incompatible with AssertJ 3.15.0
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/181;>#181
added a new ${xmlunit.matchesRegex(regex)} placeholder
PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/178;>#178
by https://github.com/Jazzyekim;>@Jazzyekim.
add a new ${xmlunit.isDateTime} placeholder
inspired by https://github-redirect.dependabot.com/xmlunit/xmlunit.net/pull/31;>#xmlunit.net/31
and https://github-redirect.dependabot.com/xmlunit/xmlunit.net/pull/32;>#xmlunit.net/32
by https://github.com/MilkyWare;>MilkyWare
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/174;>#174
avoid unnecessary creation of DocumentBuilderFactory in
DOMDifferenceEngine when a custom factory has been provided to
DiffBuilder.
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/182;>#182
XMLUnit 2.6.4
This release fixes a bug that affects the XPath for missing nodes in
certain corner cases and improves the AsssertJ module. In particular XMLUnit
2.6.4 is supposed to be compatible with AssertJ 3.13.x.
The full list of changes:
the dependencies on JAXB implementation and its transitive
dependencies has been promoted from test scope to optional for Java
9 and later
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/162;>#162
added containsAnyNodeHavingXPath,
containsAllNodesHavingXPath
and hasXPath assertions to xmlunit-assertj.
added extractingAttribute method to xmlunit-assertj.
removed some redundant instanceof checks.
PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/171;>#171
by
https://github.com/PascalSchumacher;>@PascalSchumacher.
xmlunit-assertj should now work with AssertJ-Core 3.13.x
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/166;>#166
the XPath values for comparisons resulting in CHILD_LOOKUP
differences could be wrong when NodeFilters were present.
XMLUnit.NET Issue
[xmlunit.net/https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/29;>#29](https://github-redirect.dependabot.com/xmlunit/xmlunit.net/issues/29;>xmlunit/xmlunit.net#29)
xmlunit-legacy will now use NewDifferenceEngine even when an
ElementQualifier different from the built-in ones is used.
... (truncated)
Changelog
Sourced from https://github.com/xmlunit/xmlunit/blob/master/RELEASE_NOTES.md;>xmlunit-matchers's
changelog.
XMLUnit for Java 2.7.0 - /Released 2020-05-12/
This version contains a backwards incompatible change to the
PlaceholderHandler interface that is part of the experimental
placeholders module: The evaluate method now receives a variable
number of string arguments in addition to the textual content of the
element/attribute. This allows placeholders like
${xmlunit.matchesRegex(some\s*regex)}.
the AssertJ tests now pass on non-English locales as well
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/pull/180;>#180
added a workaround for a binary incompatible change in AssertJ that
caused xmlunit-assertj to be incompatible with AssertJ 3.15.0
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/181;>#181
added a new ${xmlunit.matchesRegex(regex)} placeholder
PR https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/178;>#178
by
https://github.com/Jazzyekim;>@Jazzyekim.
add a new ${xmlunit.isDateTime} placeholder
inspired by https://github-redirect.dependabot.com/xmlunit/xmlunit.net/pull/31;>#xmlunit.net/31
and
https://github-redirect.dependabot.com/xmlunit/xmlunit.net/pull/32;>#xmlunit.net/32
by
https://github.com/MilkyWare;>MilkyWare
Issue https://github-redirect.dependabot.com/xmlunit/xmlunit/issues/174;>#174
avoid unnecessary
[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #33: Bump commons-lang3 from 3.5 to 3.10
dependabot[bot] opened a new pull request #33: URL: https://github.com/apache/maven-doxia/pull/33 Bumps commons-lang3 from 3.5 to 3.10. [](https://help.github.com/articles/configuring-automated-security-fixes) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] elharo merged pull request #31: Bump xmlunit-matchers from 2.6.3 to 2.7.0
elharo merged pull request #31: URL: https://github.com/apache/maven-doxia/pull/31 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] elharo merged pull request #26: Bump xmlunit-core from 2.6.3 to 2.7.0
elharo merged pull request #26: URL: https://github.com/apache/maven-doxia/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] elharo merged pull request #25: Bump plexus-container-default from 1.7.1 to 2.1.0
elharo merged pull request #25: URL: https://github.com/apache/maven-doxia/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] elharo merged pull request #28: Bump fop from 2.4 to 2.5
elharo merged pull request #28: URL: https://github.com/apache/maven-doxia/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] [maven-doxia] elharo closed pull request #33: Bump commons-lang3 from 3.5 to 3.10
elharo closed pull request #33: URL: https://github.com/apache/maven-doxia/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
