Re: Review Request 25079: Replaced macro expansion with variadic template
On Aug. 26, 2014, 5:58 p.m., Ben Mahler wrote: It was done using macro expansion because variadic templates require C++11. We're not yet able to assume C++11: https://issues.apache.org/jira/browse/MESOS-750 Niklas Nielsen wrote: But as this reduce compile time for folks with C++11 compilers, can we make this guarded by #ifdef and enable it for good when we make the transition? +1. It seems like we can handle this version by adding it to the c++11 directory and guarding it with #ifdef similar to defer.hpp. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review51595 --- On Aug. 26, 2014, 5:44 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 26, 2014, 5:44 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1734 https://issues.apache.org/jira/browse/MESOS-1734 Repository: mesos-git Description --- Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp Diffs - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly
Re: Review Request 25079: Replaced macro expansion with variadic template
On Aug. 26, 2014, 7:36 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [25079] Failed command: ./support/mesos-style.py Error: Checking 506 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/include/process/help.hpp:61: public: should not be indented inside class TLineHelper [whitespace/indent] [3] 3rdparty/libprocess/include/process/help.hpp:72: public: should not be indented inside class TLineHelper [whitespace/indent] [3] 3rdparty/libprocess/src/help.cpp:77: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:78: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:124: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:136: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:139: Tab found; better to use spaces [whitespace/tab] [1] 3rdparty/libprocess/src/help.cpp:154: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 8 Probably not you guys, but can you address these style bugs too? You can run ./support/mesos-style.py to get the style report. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review51633 --- On Aug. 26, 2014, 2:44 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 26, 2014, 2:44 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1734 https://issues.apache.org/jira/browse/MESOS-1734 Repository: mesos-git Description --- Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp Diffs - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly
Re: Review Request 25079: Replaced macro expansion with variadic template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 27, 2014, 5:20 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1734 https://issues.apache.org/jira/browse/MESOS-1734 Repository: mesos-git Description --- Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp Diffs (updated) - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly
Re: Review Request 25079: Replaced macro expansion with variadic template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review51666 --- Bad patch! Reviews applied: [25079] Failed command: ./support/mesos-style.py Error: Checking 506 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo 3rdparty/libprocess/include/process/help.hpp:61: public: should not be indented inside class TLineHelper [whitespace/indent] [3] 3rdparty/libprocess/include/process/help.hpp:72: public: should not be indented inside class TLineHelper [whitespace/indent] [3] Total errors found: 2 - Mesos ReviewBot On Aug. 27, 2014, 5:20 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 27, 2014, 5:20 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1734 https://issues.apache.org/jira/browse/MESOS-1734 Repository: mesos-git Description --- Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp Diffs - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly
Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 5:59 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Design Review: Maintenance Primitives
Glad to see that you are really thinking this through. Yes it's explicit that resources won't be revoked and will stay outstanding in this case but I would just add that the slave won't enter the drained state. It's just hard to follow the drain/revoke/outstanding/inverse offer/reclaim vocabulary. Actually, did you also think about the name? Inverse offer sounds weird to me. Maybe resourceOffers() and resource Revoke()? You probably have better arguments and idea than me though :) Another small note: the OfferID in the inverse offer is completely new and just used to identify the inverse offer right? I got a bit confused about a link between a previous offerID and this but then I saw the Resource field. Wouldn't it be clearer to have InverseOfferID? Thanks for the work! I really want to have these primitives. On Aug 26, 2014 10:59 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: You're right, we don't account for that in the current design because such a framework would be relying on disk resources outside of the sandbox. Currently, we don't have a model for these persistent resources (e.g. disk volume used for HDFS DataNode data). Unlike the existing resources, persistent resources will not be tied to the lifecycle of the executor/task. When we have a model for persistent resources, I can see this fitting into the primitives we are proposing here. Since inverse offers work at the resource level, we can provide control to the operators to determine whether the persistent resources should be reclaimed from the framework as part of the maintenance: E.g. If decommissioning a machine, the operator can ensure that all persistent resources are reclaimed. If rebooting a machine, the operator can leave these resources allocated to the framework for when the machine is back in the cluster. Now, since we have the soft deadlines on inverse offers, a framework like HDFS can determine when it can comply to inverse offers based on the global data replication state (e.g. always ensure that 2/3 replicas of a block are available). If relinquishing a particular data volume would mean that only 1 copy of a block is available, the framework can wait to comply with the inverse offer, or can take steps to create more replicas. One interesting question is how the resource expiry time will interact with persistent resources, we may want to expose the expiry time at the resource level rather than the offer level. Will think about this. *However could you specify that when you drain a slave with hard:false you don't enter the drained state even when the deadline has passed if tasks are still running? This is not explicit in the document and we want to make sure operators have the information about this and could avoid unfortunate rolling restarts.* This is explicit in the document under the soft deadline section: the inverse offer will remain outstanding after the soft deadline elapses, we won't forcibly drain the task. Anything that's not clear here? On Mon, Aug 25, 2014 at 1:08 PM, Maxime Brugidou maxime.brugi...@gmail.com wrote: Nice work! First question: don't you think that operations should differentiate short and long maintenance? I am thinking about frameworks that use persistent storage on disk for example. A short maintenance such as a slave reboot or upgrade could be done without moving the data to another slave. However decommissioning requires to drain the storage too. If you have an HDFS datanode with 50TB of (replicated) data, you might not want to drain it for a reboot (assuming your replication factor is high enough) since it takes ages. However for decommission it might make sense to drain it. Not sure if this is a good example but I feel the need to know if the maintenance is planned to be short or is forever. I know this does not fit the nice modeling you describe :-/ Actually for HDFS we could define a threshold where good enough replication without the slave would be considered enough and thus we could deactivate the slave. This would prevent a rolling restart to go too fast. However could you specify that when you drain a slave with hard:false you don't enter the drained state even when the deadline has passed if tasks are still running? This is not explicit in the document and we want to make sure operators have the information about this and could avoid unfortunate rolling restarts. On Aug 25, 2014 9:25 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: Hi all, I wanted to take a moment to thank Alexandra Sava, who completed her OPW internship this past week. We worked together in the second half of her internship to create a design document for maintenance primitives in Mesos (the original ticket is MESOS-1474 https://issues.apache.org/jira/browse/MESOS-1474, but the design document is the most up-to-date plan). Maintenance in this context consists of anything that requires the tasks running on the slave to
Re: Review Request 25079: Replaced macro expansion with variadic template
On Aug. 26, 2014, 9:58 p.m., Ben Mahler wrote: It was done using macro expansion because variadic templates require C++11. We're not yet able to assume C++11: https://issues.apache.org/jira/browse/MESOS-750 Niklas Nielsen wrote: But as this reduce compile time for folks with C++11 compilers, can we make this guarded by #ifdef and enable it for good when we make the transition? Michael Park wrote: +1. It seems like we can handle this version by adding it to the c++11 directory and guarding it with #ifdef similar to defer.hpp. Michael Park please make that change. I guess we will just check with: __cplusplus = 201103L - Patrick --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/#review51595 --- On Aug. 27, 2014, 6:10 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 27, 2014, 6:10 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1734 https://issues.apache.org/jira/browse/MESOS-1734 Repository: mesos-git Description --- Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp Diffs - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly
Re: Review Request 25079: Replaced macro expansion with variadic template
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 27, 2014, 6:10 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1734 https://issues.apache.org/jira/browse/MESOS-1734 Repository: mesos-git Description --- Reduce compile time: - replacing a macro expansion with a variadic template - moving implementation from help.hpp to help.cpp Diffs (updated) - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51669 --- src/slave/containerizer/isolators/cgroups/blkio.hpp https://reviews.apache.org/r/25105/#comment90184 End your comment with a period. src/slave/containerizer/isolators/cgroups/blkio.hpp https://reviews.apache.org/r/25105/#comment90185 We typically use single line comment for TODOs. // TODO(preilly): src/slave/containerizer/isolators/cgroups/blkio.hpp https://reviews.apache.org/r/25105/#comment90186 ditto src/slave/containerizer/isolators/cgroups/blkio.hpp https://reviews.apache.org/r/25105/#comment90187 Single line comments. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90189 These two lines can become a single line since it fits 80 char width. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90190 We never throw exceptions in Mesos code (so let's not make this the first). Return Failure(TODO: Implement) for the same intention. However, I think instead of throwing an error you probably want to just return Nothing() and have a TODO comment. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90192 ditto. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90193 ditto src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90194 ditto src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90195 Not used? - Timothy Chen On Aug. 27, 2014, 5:59 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 5:59 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51672 --- First pass looks great. See Tim Chen's review too! include/mesos/mesos.proto https://reviews.apache.org/r/25105/#comment90198 Let's use put the units at the end. Also, we can pull out read vs write: disk_read_total_iops disk_write_total_iops disk_read_total_bytes disk_write_total_bytes I like that the 'disk_' prefix matches the current resource name (disk), but I wonder if we want to use 'blk_' as the prefix instead, especially if we want to introduce new disk specific resources. src/slave/containerizer/isolators/cgroups/blkio.hpp https://reviews.apache.org/r/25105/#comment90199 This doesn't compile. ;-) src/slave/containerizer/mesos/containerizer.cpp https://reviews.apache.org/r/25105/#comment90191 Is there a reason to #ifdef this away? Like (most of) the other isolators, once this is in the code base we should always build it and let the operator decide whether or not they want ot use it. The network isolator is a bit more special case because it does a lot more. - Benjamin Hindman On Aug. 27, 2014, 5:59 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 5:59 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 6:37 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Fix some style issues Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Differentiate user requests protobuf messages
On Mon, Aug 25, 2014 at 5:03 PM, Vinod Kone vinodk...@gmail.com wrote: See my answers inline. Based on what you say, looks like there are more HTTP endpoints (rw) exposed to slaves and frameworks, like /shutdown. We don't want to implement auth for these endpoints, atm. Yes. There are more user visible endpoints. See master:port/help for the list of endpoints. That said, i think, we should authenticate /master/state.json only. Can I assume, this can be implemented in Master::Http::state method, using process::http::Request and process::http::Response? Or, does slave/framework use /master/state.json endpoint? Any changes to this method will not affect protobuf message exchange between master and slave/framework, I think. Correct me if i'm wrong. For authorizing static http endpoints, we could resurrect some code that didn't make it into 0.20.0. See the diff here ( https://github.com/apache/mesos/commit/a5cc9b435aad080a79230f0366a6ce77116c95a4) and let me know if that is what you are looking for. It's more for authorizing frameworks. We looking for authenticating users for certain HTTP endpoints. If i understand right, the above patch expect certain authz credentials like principal role for framework registration and principal user for running tasks. For web requests, i don't think angularJS is exchanging any credential or query-param with master. It's always GET specific json. We are thinking to solve this problem by running a proxy in front of each mesos master and implement authN based on path and/or User-Agent. We'll keep you posted if we want any changes to be made in mesos. Note, the HTTP endpoints exposed by master for web requests do not impact the internal HTTP endpoints used for communicating with frameworks/slaves. Good to know. This will make our implementation simple, as we don't want to authenticate HTTP requests from frameworks/slaves. Thank you, -- Regards, Bhuvan Arumugam www.livecipher.com
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 6:40 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- A small fix for the style issues Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 6:50 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Fix silly error. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25030: Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.
On Aug. 26, 2014, 12:38 a.m., Timothy St. Clair wrote: configure.ac, line 407 https://reviews.apache.org/r/25030/diff/1/?file=668368#file668368line407 Can we just do the compile check? I will add a TODO for using AX_CXX_CHECK_LIB once we resolve the legal issue. For now, I'll just use the old patch and check for _init. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25030/#review51468 --- On Aug. 25, 2014, 11:29 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25030/ --- (Updated Aug. 25, 2014, 11:29 p.m.) Review request for mesos, Benjamin Hindman and Timothy St. Clair. Bugs: MESOS-1727 https://issues.apache.org/jira/browse/MESOS-1727 Repository: mesos-git Description --- See summary and ticket. Some people suggested that PKG_CHECK_MODULES is considered harmful. Diffs - configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c m4/ax_cxx_check_lib.m4 PRE-CREATION Diff: https://reviews.apache.org/r/25030/diff/ Testing --- ./bootstrap.sh ./configure Thanks, Jie Yu
Re: Review Request 25105: Explore disk io isolation in cgroups
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/#review51678
---
Please close issues once you've addressed them.
src/slave/containerizer/isolators/cgroups/blkio.cpp
https://reviews.apache.org/r/25105/#comment90201
Correct alphabetical ordering.
src/slave/containerizer/isolators/cgroups/blkio.cpp
https://reviews.apache.org/r/25105/#comment90203
This shouldn't be a check. Just return a Failure(Pid ... for container ...
has already been isolated)
src/slave/containerizer/isolators/cgroups/blkio.cpp
https://reviews.apache.org/r/25105/#comment90206
Can you push this into linux/cgroups.cpp and namespace appropriately. See
the memory and cpu for guidance.
src/slave/containerizer/isolators/cgroups/blkio.cpp
https://reviews.apache.org/r/25105/#comment90207
Push into linux/cgroups.{c,h}pp
- Ian Downes
On Aug. 27, 2014, 11:50 a.m., Patrick Reilly wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25105/
---
(Updated Aug. 27, 2014, 11:50 a.m.)
Review request for mesos, Adam B and Benjamin Hindman.
Bugs: MESOS-350
https://issues.apache.org/jira/browse/MESOS-350
Repository: mesos-git
Description
---
Currently there is no disk isolation in place and this affects an executor to
be starved of disk when another disk heavy operation such as copying a multi
gigabyte file is being performed by another executor.
Diffs
-
include/mesos/mesos.proto dea51f9
src/Makefile.am 40b9f6b
src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION
src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp 5116b14
Diff: https://reviews.apache.org/r/25105/diff/
Testing
---
In progress.
Thanks,
Patrick Reilly
Review Request 25111: Added the concept of dynamically configurable slave attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 18464ba src/slave/slave.hpp 9d4607e src/slave/slave.cpp 6253a5d Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51680 --- src/common/attributes.cpp https://reviews.apache.org/r/25111/#comment90208 We can't support C++11 yet. - Timothy Chen On Aug. 27, 2014, 7:39 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 7:39 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 18464ba src/slave/slave.hpp 9d4607e src/slave/slave.cpp 6253a5d Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 7:48 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Remove some of the C++11 features ;-) Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs (updated) - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
On Aug. 27, 2014, 7:40 p.m., Timothy Chen wrote: src/common/attributes.cpp, line 162 https://reviews.apache.org/r/25111/diff/1/?file=670376#file670376line162 We can't support C++11 yet. We've removed the c++11 auto moved back to foreach - Patrick --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51680 --- On Aug. 27, 2014, 7:48 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 7:48 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51687 --- src/master/master.hpp https://reviews.apache.org/r/25111/#comment90216 I think this exceeds 70 char comment limit. src/master/master.hpp https://reviews.apache.org/r/25111/#comment90223 I don't think you need a bool either. It should either succeed or not, and when it doesn't you throw an error anyways (doesn't contain info.id). So I think it should be a TryNothing src/master/master.hpp https://reviews.apache.org/r/25111/#comment90218 Period in the end src/master/master.hpp https://reviews.apache.org/r/25111/#comment90219 Return Error instead. src/master/master.hpp https://reviews.apache.org/r/25111/#comment90221 space between for ( src/master/master.hpp https://reviews.apache.org/r/25111/#comment90222 space bewteen if ( src/master/master.hpp https://reviews.apache.org/r/25111/#comment90220 We have a Unreachable define you can throw. #include stout/unreachable.hpp return UNREACHABLE(); src/master/master.hpp https://reviews.apache.org/r/25111/#comment90224 s/NOTE: // src/master/master.hpp https://reviews.apache.org/r/25111/#comment90225 period in the end. src/master/master.hpp https://reviews.apache.org/r/25111/#comment90230 Period in the end. src/master/master.hpp https://reviews.apache.org/r/25111/#comment90226 space between for loop. src/master/master.hpp https://reviews.apache.org/r/25111/#comment90227 space between if ( src/master/master.cpp https://reviews.apache.org/r/25111/#comment90228 I assume you're not finished here. src/slave/slave.cpp https://reviews.apache.org/r/25111/#comment90231 You already have a Try in the return type, doesn't need another try in the method name. src/slave/slave.cpp https://reviews.apache.org/r/25111/#comment90232 refernece operator is next to the ie: const OptionAttributes attrs, src/slave/slave.cpp https://reviews.apache.org/r/25111/#comment90233 No ending period in error messages. src/slave/slave.cpp https://reviews.apache.org/r/25111/#comment90234 You're checking if the new resources is a subset though? src/slave/slave.cpp https://reviews.apache.org/r/25111/#comment90236 Please add periods in all the comments in this method src/slave/slave.cpp https://reviews.apache.org/r/25111/#comment90235 Space before the last return - Timothy Chen On Aug. 27, 2014, 7:48 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 7:48 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2368
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2368/changes
Changes:
[yujie.jay] Replaced PKG_CHECK_MODULES with AC_CHECKs in configure.ac.
[yujie.jay] Replaced PKG_CHECK_MODULES with AC_CHECKs in libprocess
configure.ac.
--
[...truncated 23561 lines...]
I0827 20:36:23.616559 18037 group.cpp:787] Syncing group operations: queue size
(joins, cancels, datas) = (0, 0, 0)
I0827 20:36:23.616574 18037 group.cpp:385] Trying to create path
'/znode/log_replicas' in ZooKeeper
I0827 20:36:23.616781 18034 group.cpp:313] Group process
(group(4)@67.195.81.186:49273) connected to ZooKeeper
I0827 20:36:23.616821 18034 group.cpp:787] Syncing group operations: queue size
(joins, cancels, datas) = (0, 0, 0)
I0827 20:36:23.616833 18034 group.cpp:385] Trying to create path '/znode' in
ZooKeeper
2014-08-27 20:36:23,617:18008(0x2aca63df6700):ZOO_INFO@check_events@1750:
session establishment complete on server [127.0.0.1:56082],
sessionId=0x148192eff150003, negotiated timeout=1
I0827 20:36:23.617689 18031 group.cpp:313] Group process
(group(2)@67.195.81.186:49273) connected to ZooKeeper
I0827 20:36:23.617713 18031 group.cpp:787] Syncing group operations: queue size
(joins, cancels, datas) = (1, 0, 0)
I0827 20:36:23.617725 18031 group.cpp:385] Trying to create path
'/znode/log_replicas' in ZooKeeper
I0827 20:36:23.638625 18029 contender.cpp:247] New candidate (id='0') has
entered the contest for leadership
I0827 20:36:23.641109 18034 group.cpp:714] Found non-sequence node
'log_replicas' at '/znode' in ZooKeeper
I0827 20:36:23.641260 18035 detector.cpp:138] Detected a new leader: (id='0')
I0827 20:36:23.641393 18026 group.cpp:714] Found non-sequence node
'log_replicas' at '/znode' in ZooKeeper
I0827 20:36:23.641561 18022 group.cpp:658] Trying to get
'/znode/info_00' in ZooKeeper
I0827 20:36:23.645103 18035 detector.cpp:426] A new leading master
(UPID=master@67.195.81.186:49273) is detected
I0827 20:36:23.645179 18024 master.cpp:1205] The newly elected leader is
master@67.195.81.186:49273 with id 20140827-203623-3125920579-49273-18008
I0827 20:36:23.645206 18024 master.cpp:1218] Elected as the leading master!
I0827 20:36:23.645217 18024 master.cpp:1036] Recovering from registrar
I0827 20:36:23.645447 18030 registrar.cpp:313] Recovering registrar
I0827 20:36:23.64 18029 network.hpp:423] ZooKeeper group memberships changed
I0827 20:36:23.645757 18030 group.cpp:658] Trying to get
'/znode/log_replicas/00' in ZooKeeper
I0827 20:36:23.645807 18036 log.cpp:656] Attempting to start the writer
I0827 20:36:23.646709 18027 replica.cpp:474] Replica received implicit promise
request with proposal 1
I0827 20:36:23.647060 18028 network.hpp:461] ZooKeeper group PIDs: {
log-replica(134)@67.195.81.186:49273 }
I0827 20:36:23.647233 18027 leveldb.cpp:306] Persisting metadata (8 bytes) to
leveldb took 499696ns
I0827 20:36:23.647254 18027 replica.cpp:342] Persisted promised to 1
I0827 20:36:23.647662 18026 coordinator.cpp:230] Coordinator attemping to fill
missing position
I0827 20:36:23.648377 18027 replica.cpp:375] Replica received explicit promise
request for position 0 with proposal 2
I0827 20:36:23.648510 18027 leveldb.cpp:343] Persisting action (8 bytes) to
leveldb took 108878ns
I0827 20:36:23.648530 18027 replica.cpp:676] Persisted action at 0
I0827 20:36:23.649034 18033 replica.cpp:508] Replica received write request for
position 0
I0827 20:36:23.649071 18033 leveldb.cpp:438] Reading position from leveldb took
16241ns
I0827 20:36:23.649427 18033 leveldb.cpp:343] Persisting action (14 bytes) to
leveldb took 334420ns
I0827 20:36:23.649446 18033 replica.cpp:676] Persisted action at 0
I0827 20:36:23.649771 18036 replica.cpp:655] Replica received learned notice
for position 0
I0827 20:36:23.649911 18036 leveldb.cpp:343] Persisting action (16 bytes) to
leveldb took 117325ns
I0827 20:36:23.649940 18036 replica.cpp:676] Persisted action at 0
I0827 20:36:23.649955 18036 replica.cpp:661] Replica learned NOP action at
position 0
I0827 20:36:23.650184 18036 log.cpp:672] Writer started with ending position 0
I0827 20:36:23.650632 18029 leveldb.cpp:438] Reading position from leveldb took
11101ns
I0827 20:36:23.652402 18022 registrar.cpp:346] Successfully fetched the
registry (0B)
I0827 20:36:23.652446 18022 registrar.cpp:422] Attempting to update the
'registry'
I0827 20:36:23.655201 18036 log.cpp:680] Attempting to append 140 bytes to the
log
I0827 20:36:23.655402 18026 coordinator.cpp:340] Coordinator attempting to
write APPEND action at position 1
I0827 20:36:23.655912 18033 replica.cpp:508] Replica received write request for
position 1
I0827 20:36:23.656443 18033 leveldb.cpp:343] Persisting action (159 bytes) to
leveldb took 492030ns
I0827 20:36:23.656501 18033 replica.cpp:676] Persisted action at 1
I0827 20:36:23.657109 18026 replica.cpp:655] Replica received learned notice
for position 1
I0827 20:36:23.657611
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 27, 2014, 8:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325 configure.ac 4b34173ed23bfe4e6f108db57f2611e50927ed2b mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Review Request 25116: Fix External Containerizer creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25116/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git Description --- Fix External Containerizer creation Diffs - src/slave/containerizer/containerizer.cpp 0e686848d8d027cda39dfd3013dcf1788c51fff9 src/slave/containerizer/external_containerizer.hpp b32efdd3bc365cab025ad468ef0f1f43a5dbf4ab src/slave/containerizer/external_containerizer.cpp e5726e1b98623cfe9761c3135d7b62d27290a00f Diff: https://reviews.apache.org/r/25116/diff/ Testing --- make check. Tried running external containerizer and was able to launch up external containerizer now. Thanks, Timothy Chen
Re: Review Request 25116: Fix External Containerizer creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25116/ --- (Updated Aug. 27, 2014, 8:46 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-1737 https://issues.apache.org/jira/browse/MESOS-1737 Repository: mesos-git Description --- Fix External Containerizer creation Diffs - src/slave/containerizer/containerizer.cpp 0e686848d8d027cda39dfd3013dcf1788c51fff9 src/slave/containerizer/external_containerizer.hpp b32efdd3bc365cab025ad468ef0f1f43a5dbf4ab src/slave/containerizer/external_containerizer.cpp e5726e1b98623cfe9761c3135d7b62d27290a00f Diff: https://reviews.apache.org/r/25116/diff/ Testing --- make check. Tried running external containerizer and was able to launch up external containerizer now. Thanks, Timothy Chen
Re: Review Request 25105: Explore disk io isolation in cgroups
On Aug. 27, 2014, 11:32 a.m., Benjamin Hindman wrote: include/mesos/mesos.proto, lines 440-441 https://reviews.apache.org/r/25105/diff/1/?file=670315#file670315line440 Let's use put the units at the end. Also, we can pull out read vs write: disk_read_total_iops disk_write_total_iops disk_read_total_bytes disk_write_total_bytes I like that the 'disk_' prefix matches the current resource name (disk), but I wonder if we want to use 'blk_' as the prefix instead, especially if we want to introduce new disk specific resources. We've got (or may have) multiple types of disk storage, these come to mind: 1) A directory on a shared filesystem. 2) A dedicated filesystem mounted somewhere in a container. 3) A raw block device exposed to the container. I second [~benhindman] that these IO statistics should keep the blk prefix; the statistics and throttling tunables are actually block device specific so I think we should preserve that particular naming while other disk types are worked on. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51672 --- On Aug. 27, 2014, 11:50 a.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 11:50 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
On Aug. 27, 2014, 8:29 p.m., Timothy Chen wrote: src/master/master.hpp, line 1169 https://reviews.apache.org/r/25111/diff/2/?file=670389#file670389line1169 I don't think you need a bool either. It should either succeed or not, and when it doesn't you throw an error anyways (doesn't contain info.id). So I think it should be a TryNothing We have to match the protoype of the virtual function of Operation in registrar.h here. The bool return in the general case is used by the registrar currently. - Cody --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51687 --- On Aug. 27, 2014, 7:48 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 7:48 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Review Request 25121: Try to give a hint as to what might have gone wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25121/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1735 https://issues.apache.org/jira/browse/MESOS-1735 Repository: mesos-git Description --- Output Already running Diffs - 3rdparty/libprocess/src/process.cpp 3ac56c7 Diff: https://reviews.apache.org/r/25121/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 9:10 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Addressing reviewer comments Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs (updated) - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 9:28 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Fix build, address missed comment Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs (updated) - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25111: Added the concept of dynamically configurable slave attributes
On Aug. 27, 2014, 8:29 p.m., Timothy Chen wrote: src/master/master.hpp, line 1169 https://reviews.apache.org/r/25111/diff/2/?file=670389#file670389line1169 I don't think you need a bool either. It should either succeed or not, and when it doesn't you throw an error anyways (doesn't contain info.id). So I think it should be a TryNothing Cody Maloney wrote: We have to match the protoype of the virtual function of Operation in registrar.h here. The bool return in the general case is used by the registrar currently. Unless, I'm missing something about TryNothing I think we need to keep it this way? - Patrick --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51687 --- On Aug. 27, 2014, 9:28 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014, 9:28 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1739 https://issues.apache.org/jira/browse/MESOS-1739 Repository: mesos-git Description --- Add basic stub for dynamic slave attributes Diffs - src/common/attributes.hpp 0a043d5 src/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 9:38 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Various small fixes still a total work in progress, (WIP) Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Crashed task is not reaped
While playing with Rendler https://github.com/mesosphere/RENDLER I noticed that if the task (read: python executor) crashes, the underlying executor stays alive and therefore is not reaped, which renders the task running indefinitely. Here https://gist.github.com/rukletsov/4a74743c5b67f304e661 is a part of the slave log (exception itself doesn't matter, it's there to test the behaviour). Not sure, whether it's a bug or a feature, for me it looks like a bug. Regards, Alex
Shutdown by timeout in mesos
There are at least two mechanisms for shutdown by timeout in mesos: * through the separate ShutdownProcess (src/exec/exec.cpp:383) * delay in the same process (src/launcher/executor.cpp:325) Why do we need two different ways of doing that? Regards, Alex
Review Request 25124: Added 'net-bench' libprocess benchmarking tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- Added libprocess connection throughput stress test (basically two libprocess programs sending messsages back and forth). One end is multihomed so we can scale the number of clients. One client will issue multiple concurrent messages (messages sent before waiting for acknowledgement). The motivation is to stress test libprocess communication and get an idea on theoretical throughput / scale-properties for increase slave-fanout. Diffs - src/Makefile.am 40b9f6b src/net-bench/main.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25124/diff/ Testing --- Server: $ ./src/mesos-net-bench WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:01.605250 259977216 main.cpp:111] Running server at (1)@10.0.0.224:53492 I0827 15:48:13.617341 259977216 main.cpp:135] 14628.2 requests / second I0827 15:48:14.617578 258367488 main.cpp:135] 13886.7 requests / second I0827 15:48:15.617683 257830912 main.cpp:135] 8677.19 requests / second I0827 15:48:16.617771 257830912 main.cpp:135] 8304.19 requests / second Client: $ ./build/src/mesos-net-bench --server=(1)@10.0.0.224:53492 WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at (1)@10.0.0.224:53492... Thanks, Niklas Nielsen
Review Request 25126: Fixed signal handling for stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25126/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --- Moved back installSignalHandler to src/logging.cpp in mesos, because it's no longer used by anyone else. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b18dbd3adb43581783121c52effac179423755f9 3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp cec7f4d3fd7c6e69c1d9aa43dcc62ddd6838e5d4 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp f32130acd2aa3c34876a929a77ef274218be0e89 3rdparty/libprocess/3rdparty/stout/tests/main.cpp fa8093b1007e04fa5eee14bfe434be1dc30dd670 Diff: https://reviews.apache.org/r/25126/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 25128: Fixed signal handling in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25128/ --- Review request for mesos and Jie Yu. Bugs: MESOS-1705 https://issues.apache.org/jira/browse/MESOS-1705 Repository: mesos-git Description --- Fixed signal handling in libprocess. Diffs - 3rdparty/libprocess/src/tests/main.cpp 57269cbbde0dae2d57b7f7eee779a857a45668f7 Diff: https://reviews.apache.org/r/25128/diff/ Testing --- make check Thanks, Vinod Kone
Re: Crashed task is not reaped
A crashed thread does not terminate the Python interpreter, so the executor here will stay alive. If you want an abnormal thread exit to result in an executor termination, you will have to implement that behavior explicitly. We use a thread liveness detector that looks something like: https://gist.github.com/wickman/dc11896d782f9a2160b8 When you create a thread, you do registry.register(thread). That thread should call registry.unregister(self) prior to terminating normally. If it terminates abnormally, the registry.dead event will be set. Our MainThread in practice just does something like: while registry.dead.wait(timeout=10): pass We also have a library (twitter.common.exceptions on pypi) that provides a class called ExceptionalThread which guarantees that sys.excepthook() is called. You could implement similar behavior by making all threads ExceptionalThreads and wrapping sys.excepthook with something that provides an event to MainThread to signal termination as described above. ~brian On Wed, Aug 27, 2014 at 2:55 PM, Alex Rukletsov a...@mesosphere.io wrote: While playing with Rendler https://github.com/mesosphere/RENDLER I noticed that if the task (read: python executor) crashes, the underlying executor stays alive and therefore is not reaped, which renders the task running indefinitely. Here https://gist.github.com/rukletsov/4a74743c5b67f304e661 is a part of the slave log (exception itself doesn't matter, it's there to test the behaviour). Not sure, whether it's a bug or a feature, for me it looks like a bug. Regards, Alex
Re: Review Request 25126: Fixed signal handling for stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25126/#review51714 --- Ship it! Ship It! - Jie Yu On Aug. 27, 2014, 10:50 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25126/ --- (Updated Aug. 27, 2014, 10:50 p.m.) Review request for mesos and Jie Yu. Repository: mesos-git Description --- Moved back installSignalHandler to src/logging.cpp in mesos, because it's no longer used by anyone else. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am b18dbd3adb43581783121c52effac179423755f9 3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp cec7f4d3fd7c6e69c1d9aa43dcc62ddd6838e5d4 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp f32130acd2aa3c34876a929a77ef274218be0e89 3rdparty/libprocess/3rdparty/stout/tests/main.cpp fa8093b1007e04fa5eee14bfe434be1dc30dd670 Diff: https://reviews.apache.org/r/25126/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25128: Fixed signal handling in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25128/#review51715 --- Ship it! Ship It! - Jie Yu On Aug. 27, 2014, 10:54 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25128/ --- (Updated Aug. 27, 2014, 10:54 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1705 https://issues.apache.org/jira/browse/MESOS-1705 Repository: mesos-git Description --- Fixed signal handling in libprocess. Diffs - 3rdparty/libprocess/src/tests/main.cpp 57269cbbde0dae2d57b7f7eee779a857a45668f7 Diff: https://reviews.apache.org/r/25128/diff/ Testing --- make check Thanks, Vinod Kone
Review Request 25129: Fixed signal handling for Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25129/ --- Review request for mesos and Jie Yu. Bugs: MESOS-1729 https://issues.apache.org/jira/browse/MESOS-1729 Repository: mesos-git Description --- Reset SIGPIPE handler to default handler to avoid issues with embedded ZooKeeper. See bug for details. Diffs - src/logging/logging.cpp 547673c7584a0962d3a54da51f3ad069d9285bb9 src/tests/main.cpp 32a24564ff460a9bc0d11bc02b7a5b29f599c57b Diff: https://reviews.apache.org/r/25129/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25124: Added 'net-bench' libprocess benchmarking tool.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/#review51716 --- src/net-bench/main.cpp https://reviews.apache.org/r/25124/#comment90265 it might be worth (for a future version) allowing this to be a random string of user-defined length and also tracking statistics for bytes sent/received. - Dominic Hamon On Aug. 27, 2014, 3:49 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/ --- (Updated Aug. 27, 2014, 3:49 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- Added libprocess connection throughput stress test (basically two libprocess programs sending messsages back and forth). One end is multihomed so we can scale the number of clients. One client will issue multiple concurrent messages (messages sent before waiting for acknowledgement). The motivation is to stress test libprocess communication and get an idea on theoretical throughput / scale-properties for increase slave-fanout. Diffs - src/Makefile.am 40b9f6b src/net-bench/main.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25124/diff/ Testing --- Server: $ ./src/mesos-net-bench WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:01.605250 259977216 main.cpp:111] Running server at (1)@10.0.0.224:53492 I0827 15:48:13.617341 259977216 main.cpp:135] 14628.2 requests / second I0827 15:48:14.617578 258367488 main.cpp:135] 13886.7 requests / second I0827 15:48:15.617683 257830912 main.cpp:135] 8677.19 requests / second I0827 15:48:16.617771 257830912 main.cpp:135] 8304.19 requests / second Client: $ ./build/src/mesos-net-bench --server=(1)@10.0.0.224:53492 WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at (1)@10.0.0.224:53492... Thanks, Niklas Nielsen
Re: Review Request 25129: Fixed signal handling for Mesos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25129/#review51718 --- Ship it! src/logging/logging.cpp https://reviews.apache.org/r/25129/#comment90266 I don't quite get this part. But let's ship this first as you just moved it. - Jie Yu On Aug. 27, 2014, 10:57 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25129/ --- (Updated Aug. 27, 2014, 10:57 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1729 https://issues.apache.org/jira/browse/MESOS-1729 Repository: mesos-git Description --- Reset SIGPIPE handler to default handler to avoid issues with embedded ZooKeeper. See bug for details. Diffs - src/logging/logging.cpp 547673c7584a0962d3a54da51f3ad069d9285bb9 src/tests/main.cpp 32a24564ff460a9bc0d11bc02b7a5b29f599c57b Diff: https://reviews.apache.org/r/25129/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 25124: Added 'net-bench' libprocess benchmarking tool.
On Aug. 27, 2014, 4:01 p.m., Dominic Hamon wrote: src/net-bench/main.cpp, line 166 https://reviews.apache.org/r/25124/diff/1/?file=670615#file670615line166 it might be worth (for a future version) allowing this to be a random string of user-defined length and also tracking statistics for bytes sent/received. Good point - we would need to install message handlers accordingly though. I would categorize it as future work :-) Want a TODO in place? - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/#review51716 --- On Aug. 27, 2014, 3:49 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/ --- (Updated Aug. 27, 2014, 3:49 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- Added libprocess connection throughput stress test (basically two libprocess programs sending messsages back and forth). One end is multihomed so we can scale the number of clients. One client will issue multiple concurrent messages (messages sent before waiting for acknowledgement). The motivation is to stress test libprocess communication and get an idea on theoretical throughput / scale-properties for increase slave-fanout. Diffs - src/Makefile.am 40b9f6b src/net-bench/main.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25124/diff/ Testing --- Server: $ ./src/mesos-net-bench WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:01.605250 259977216 main.cpp:111] Running server at (1)@10.0.0.224:53492 I0827 15:48:13.617341 259977216 main.cpp:135] 14628.2 requests / second I0827 15:48:14.617578 258367488 main.cpp:135] 13886.7 requests / second I0827 15:48:15.617683 257830912 main.cpp:135] 8677.19 requests / second I0827 15:48:16.617771 257830912 main.cpp:135] 8304.19 requests / second Client: $ ./build/src/mesos-net-bench --server=(1)@10.0.0.224:53492 WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at (1)@10.0.0.224:53492... Thanks, Niklas Nielsen
Re: Review Request 25124: Added 'net-bench' libprocess benchmarking tool.
On Aug. 27, 2014, 4:01 p.m., Dominic Hamon wrote: src/net-bench/main.cpp, line 166 https://reviews.apache.org/r/25124/diff/1/?file=670615#file670615line166 it might be worth (for a future version) allowing this to be a random string of user-defined length and also tracking statistics for bytes sent/received. Niklas Nielsen wrote: Good point - we would need to install message handlers accordingly though. I would categorize it as future work :-) Want a TODO in place? sure. i was also going to suggest using the libprocess metrics library to get access to the counters through an endpoint, but that's almost certainly overkill. as an aside, the numbers you get are similar to some theoretical upper-bound numbers we saw when testing the rate limiting framework. that suggests that 1. your methodology is sound and 2. that libprocess is the bottleneck rather than the communication up the stack to mesos. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/#review51716 --- On Aug. 27, 2014, 3:49 p.m., Niklas Nielsen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25124/ --- (Updated Aug. 27, 2014, 3:49 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos-git Description --- Added libprocess connection throughput stress test (basically two libprocess programs sending messsages back and forth). One end is multihomed so we can scale the number of clients. One client will issue multiple concurrent messages (messages sent before waiting for acknowledgement). The motivation is to stress test libprocess communication and get an idea on theoretical throughput / scale-properties for increase slave-fanout. Diffs - src/Makefile.am 40b9f6b src/net-bench/main.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25124/diff/ Testing --- Server: $ ./src/mesos-net-bench WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:01.605250 259977216 main.cpp:111] Running server at (1)@10.0.0.224:53492 I0827 15:48:13.617341 259977216 main.cpp:135] 14628.2 requests / second I0827 15:48:14.617578 258367488 main.cpp:135] 13886.7 requests / second I0827 15:48:15.617683 257830912 main.cpp:135] 8677.19 requests / second I0827 15:48:16.617771 257830912 main.cpp:135] 8304.19 requests / second Client: $ ./build/src/mesos-net-bench --server=(1)@10.0.0.224:53492 WARNING: Logging before InitGoogleLogging() is written to STDERR I0827 15:48:12.624887 124162048 main.cpp:115] Connecting to server at (1)@10.0.0.224:53492... Thanks, Niklas Nielsen
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2369
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2369/changes Changes: [vinodkone] Fixed signal handling for stout. [vinodkone] Fixed signal handling in libprocess. [vinodkone] Fixed signal handling for Mesos. -- [...truncated 260 lines...] 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/strings_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/subcommand_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/thread_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/uuid_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/proc_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/os/setns_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am: installing './depcomp' Makefile.am:32: warning: source file 'src/http.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/latch.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/metrics/metrics.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/process.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/reap.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/subprocess.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/timeseries.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/decoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/encoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/http_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/io_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/main.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/mutex_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/metrics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/owned_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/process_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/queue_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/reap_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/sequence_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/shared_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/statistics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/subprocess_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/system_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/timeseries_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/time_tests.cpp' is in a
Re: Review Request 25116: Fix External Containerizer creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25116/#review51722 --- Ship it! Ship It! - Benjamin Hindman On Aug. 27, 2014, 8:46 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25116/ --- (Updated Aug. 27, 2014, 8:46 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-1737 https://issues.apache.org/jira/browse/MESOS-1737 Repository: mesos-git Description --- Fix External Containerizer creation Diffs - src/slave/containerizer/containerizer.cpp 0e686848d8d027cda39dfd3013dcf1788c51fff9 src/slave/containerizer/external_containerizer.hpp b32efdd3bc365cab025ad468ef0f1f43a5dbf4ab src/slave/containerizer/external_containerizer.cpp e5726e1b98623cfe9761c3135d7b62d27290a00f Diff: https://reviews.apache.org/r/25116/diff/ Testing --- make check. Tried running external containerizer and was able to launch up external containerizer now. Thanks, Timothy Chen
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2370
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2370/changes Changes: [vinodkone] Improved the signal handling comment in Mesos tests. [benjamin.hindman] Fix External Containerizer creation. -- [...truncated 260 lines...] 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/strings_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/subcommand_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/thread_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/uuid_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/proc_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:179: warning: source file '$(STOUT)/tests/os/setns_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:179: but option 'subdir-objects' is disabled 3rdparty/Makefile.am: installing './depcomp' Makefile.am:32: warning: source file 'src/http.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/latch.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/metrics/metrics.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/pid.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/process.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/reap.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/subprocess.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:32: warning: source file 'src/timeseries.cpp' is in a subdirectory, Makefile.am:32: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/decoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/encoder_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/http_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/io_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/main.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/mutex_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/metrics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/owned_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/process_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/queue_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/reap_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/sequence_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/shared_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/statistics_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/subprocess_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/system_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/timeseries_tests.cpp' is in a subdirectory, Makefile.am:90: but option 'subdir-objects' is disabled Makefile.am:90: warning: source file 'src/tests/time_tests.cpp' is in a subdirectory,
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51724 --- src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90273 We usually put the + in the previous line, and pad this 2nd line with 4 spaces. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90275 Not trying to nitpick, but if you don't plan to implement this, please put period in the end. src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90274 return Nothing(); src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90276 4 spaces pad. src/linux/cgroups.hpp https://reviews.apache.org/r/25105/#comment90270 Need to space out the closing for compatibility reasons. Trystd::pairuint64_t, uint64_t src/linux/cgroups.cpp https://reviews.apache.org/r/25105/#comment90271 ditto src/linux/cgroups.cpp https://reviews.apache.org/r/25105/#comment90272 End with period. - Timothy Chen On Aug. 27, 2014, 9:49 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 27, 2014, 9:49 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2346
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2346/changes
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:27 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Various fixes for reported issues. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
On Aug. 27, 2014, 6:32 p.m., Benjamin Hindman wrote: src/slave/containerizer/isolators/cgroups/blkio.hpp, line 35 https://reviews.apache.org/r/25105/diff/1/?file=670317#file670317line35 This doesn't compile. ;-) Yeah I'm not quite sure how I ended up with an unescaped # causing the preprocessor to barf. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51672 --- On Aug. 28, 2014, 12:27 a.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:27 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51728 --- src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90284 Pad this with 4 more spaces. - Timothy Chen On Aug. 28, 2014, 12:27 a.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:27 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:48 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Pad with 4 more spaces Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs (updated) - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25084: Switched to single variadic 'join' function
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- (Updated Aug. 28, 2014, 12:51 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Added guard for C++11 parts with ifdef. Bugs: MESOS-1733 https://issues.apache.org/jira/browse/MESOS-1733 Repository: mesos-git Description --- Changed the stout path utility to declare a single, variadic 'join' function instead of several separate declarations of various discrete arities Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am db9766d 3rdparty/libprocess/3rdparty/stout/Makefile.am b6464de 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25084/diff/ Testing --- Ran make check created path_tests unit test. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51730 --- src/slave/containerizer/isolators/cgroups/blkio.hpp https://reviews.apache.org/r/25105/#comment90294 Are you working on unit tests? src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90288 Spacing between src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90290 2 more spaces src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90293 plus on previous line src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90289 ditto src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90291 ditto src/slave/containerizer/isolators/cgroups/blkio.cpp https://reviews.apache.org/r/25105/#comment90292 + on previous line - Timothy Chen On Aug. 28, 2014, 12:48 a.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:48 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Re: Review Request 25105: Explore disk io isolation in cgroups
On Aug. 28, 2014, 12:56 a.m., Timothy Chen wrote: src/slave/containerizer/isolators/cgroups/blkio.hpp, line 36 https://reviews.apache.org/r/25105/diff/8/?file=670662#file670662line36 Are you working on unit tests? [~tnachen] they are currently being worked on. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51730 --- On Aug. 28, 2014, 1:12 a.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 1:12 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-350 https://issues.apache.org/jira/browse/MESOS-350 Repository: mesos-git Description --- Currently there is no disk isolation in place and this affects an executor to be starved of disk when another disk heavy operation such as copying a multi gigabyte file is being performed by another executor. Diffs - include/mesos/mesos.proto dea51f9 src/Makefile.am 40b9f6b src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 989e307 src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly
Build failed in Jenkins: mesos-reviewbot #1421
See https://builds.apache.org/job/mesos-reviewbot/1421/
--
[...truncated 5416 lines...]
rm -f slave/containerizer/isolators/network/.dirstamp
rm -f sched/*.o
rm -f slave/containerizer/mesos/.deps/.dirstamp
rm -f slave/containerizer/mesos/.dirstamp
rm -f sched/*.lo
rm -f state/.deps/.dirstamp
rm -f scheduler/*.o
rm -f state/.dirstamp
rm -f scheduler/*.lo
rm -f tests/.deps/.dirstamp
rm -f slave/*.o
rm -rf authorizer/.libs authorizer/_libs
rm -f tests/.dirstamp
rm -rf common/.libs common/_libs
rm -f tests/common/.deps/.dirstamp
rm -rf containerizer/.libs containerizer/_libs
rm -f tests/common/.dirstamp
rm -rf docker/.libs docker/_libs
rm -f usage/.deps/.dirstamp
rm -rf exec/.libs exec/_libs
rm -f usage/.dirstamp
rm -f slave/*.lo
rm -rf files/.libs files/_libs
rm -f zookeeper/.deps/.dirstamp
rm -f slave/containerizer/*.o
rm -rf java/jni/.libs java/jni/_libs
rm -f zookeeper/.dirstamp
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -f slave/containerizer/*.lo
rm -rf linux/routing/.libs linux/routing/_libs
rm -f slave/containerizer/isolators/cgroups/*.o
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -f slave/containerizer/isolators/network/*.o
rm -rf local/.libs local/_libs
rm -f slave/containerizer/isolators/network/*.lo
rm -rf log/.libs log/_libs
rm -f slave/containerizer/mesos/*.o
rm -f slave/containerizer/mesos/*.lo
rm -f state/*.o
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -f state/*.lo
rm -rf master/.libs master/_libs
rm -f tests/*.o
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -f tests/common/*.o
rm -f usage/*.o
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -f zookeeper/*.lo
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps
state/.deps tests/.deps tests/common/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/src'
Making distclean in ec2
make[2]: Entering directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -rf .libs _libs
rm -f *.lo
test -z || rm -f
test . = ../../ec2 || test -z || rm -f
rm -f Makefile
make[2]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build/ec2'
rm -f config.status config.cache config.log configure.lineno
config.status.lineno
rm -f Makefile
make[1]: Leaving directory
`https://builds.apache.org/job/mesos-reviewbot/ws/mesos-0.21.0/_build'
if test -d mesos-0.21.0; then find mesos-0.21.0 -type d ! -perm -200 -exec
chmod u+w {} ';' rm -rf mesos-0.21.0 || { sleep 5 rm -rf
mesos-0.21.0; }; else :; fi
==
mesos-0.21.0 archives ready for distribution:
mesos-0.21.0.tar.gz
==
real62m9.303s
user138m56.837s
sys 7m30.126s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap
compile config.guess config.log config.lt config.status config.sub configure
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh
m4 mesos-0.21.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/gmock_sources.cc
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing
Jenkins build is back to normal : mesos-reviewbot #1422
See https://builds.apache.org/job/mesos-reviewbot/1422/changes
