Re: Review Request 25523: Add Docker pull to docker abstraction

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25523/#review53658
---

Ship it!


Did we lose the test? We need that back to Ship It please.


src/docker/docker.cpp


I'd love to add a comment for now that explains why this is not discardable 
but the other future is, and how that correctly works out. In addition, what 
happened to the test that is testing this discardability?



src/docker/docker.cpp


Swap these two please.



src/slave/containerizer/docker.cpp


Comment is out of date now.


lose

- Benjamin Hindman


On Sept. 17, 2014, 1:07 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25523/
> ---
> 
> (Updated Sept. 17, 2014, 1:07 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/25523
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp e7adedb93272209231a3a9aefecfd6ccc7802ff5 
>   src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 
> 
> Diff: https://reviews.apache.org/r/25523/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Build failed in Jenkins: mesos-reviewbot #1592

[Apache Jenkins Server]

See 

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Re: Review Request 25523: Add Docker pull to docker abstraction

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25523/
---

(Updated Sept. 17, 2014, 8:23 a.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/25523


Diffs (updated)
-

  src/docker/docker.hpp e7adedb93272209231a3a9aefecfd6ccc7802ff5 
  src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1 
  src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
  src/tests/docker_tests.cpp e6c228a27a9c3cbf2fa0cc58843989c49fa90456 

Diff: https://reviews.apache.org/r/25523/diff/


Testing
---

make check


Thanks,

Timothy Chen

Build failed in Jenkins: mesos-reviewbot #1593

[Apache Jenkins Server]

See 

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Build failed in Jenkins: mesos-reviewbot #1594

[Apache Jenkins Server]

See 

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Re: Review Request 25523: Add Docker pull to docker abstraction

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25523/#review53675
---

Ship it!



src/tests/docker_tests.cpp


Please move '{' to newline.



src/tests/docker_tests.cpp


Why isn't all of this just:

future.discard();

AWAIT_DISCARDED(future);

The extra promise->set(Nothing()) is not testing anything new here. Perhaps 
the important thing for me to say is that just because we're calling 
'future.discard()' does not mean that the future will get discarded, hence 
AWAIT_DISCARDED(future) is sufficient.


Minor cleanup/simplification in the test then lets get this committed!

- Benjamin Hindman


On Sept. 17, 2014, 8:23 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25523/
> ---
> 
> (Updated Sept. 17, 2014, 8:23 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/25523
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp e7adedb93272209231a3a9aefecfd6ccc7802ff5 
>   src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_tests.cpp e6c228a27a9c3cbf2fa0cc58843989c49fa90456 
> 
> Diff: https://reviews.apache.org/r/25523/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Review Request 25735: change const pass-by-value to const reference in stout

[Kamil Domanski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
---

Review request for mesos.


Bugs: MESOS-1805
https://issues.apache.org/jira/browse/MESOS-1805


Repository: mesos-git


Description
---

os::shell and an overload of strings::internal::fmt in stout pass a const 
string parameter by copy instead of reference


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 

Diff: https://reviews.apache.org/r/25735/diff/


Testing
---

cd 3rdparty/libprocess/3rdparty/ && make check


Thanks,

Kamil Domanski

Re: Review Request 25735: change const pass-by-value to const reference in stout

[Kamil Domanski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
---

(Updated Sept. 17, 2014, 4:25 p.m.)


Review request for mesos.


Bugs: MESOS-1805
https://issues.apache.org/jira/browse/MESOS-1805


Repository: mesos-git


Description
---

os::shell and an overload of strings::internal::fmt in stout pass a const 
string parameter by copy instead of reference. This patch fixes that.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 

Diff: https://reviews.apache.org/r/25735/diff/


Testing
---

cd 3rdparty/libprocess/3rdparty/ && make check


Thanks,

Kamil Domanski

Re: Review Request 25735: change const pass-by-value to const reference in stout

[Kamil Domanski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/
---

(Updated Sept. 17, 2014, 4:25 p.m.)


Review request for mesos.


Bugs: MESOS-1805
https://issues.apache.org/jira/browse/MESOS-1805


Repository: mesos-git


Description (updated)
---

os::shell and an overload of strings::internal::fmt in stout pass a const 
string parameter by copy instead of reference. This patch fixes that.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 

Diff: https://reviews.apache.org/r/25735/diff/


Testing
---

cd 3rdparty/libprocess/3rdparty/ && make check


Thanks,

Kamil Domanski

Build failed in Jenkins: mesos-reviewbot #1595

[Apache Jenkins Server]

See 

--
[...truncated 4021 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Build failed in Jenkins: mesos-reviewbot #1596

[Apache Jenkins Server]

See 

--
[...truncated 4021 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/
---

(Updated Sept. 17, 2014, 3:48 p.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Bugs: MESOS-1770
https://issues.apache.org/jira/browse/MESOS-1770


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/25403


Diffs (updated)
-

  src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1 

Diff: https://reviews.apache.org/r/25403/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 25403: Override entrypoint when shell enabled in Docker

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25403/#review53682
---


Just rebased on master

- Timothy Chen


On Sept. 17, 2014, 3:48 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25403/
> ---
> 
> (Updated Sept. 17, 2014, 3:48 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1770
> https://issues.apache.org/jira/browse/MESOS-1770
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/25403
> 
> 
> Diffs
> -
> 
>   src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1 
> 
> Diff: https://reviews.apache.org/r/25403/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Build failed in Jenkins: mesos-reviewbot #1597

[Apache Jenkins Server]

See 

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Build failed in Jenkins: mesos-reviewbot #1598

[Apache Jenkins Server]

See 

Changes:

[benjamin.hindman] Override entrypoint when shell enabled in Docker.

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../s

Re: Review Request 25735: change const pass-by-value to const reference in stout

[Dominic Hamon]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review53688
---

Ship it!


I'm not convinced that this is necessarily the way we want to go, given the 
benefits of move semantics in modern compilers, but for consistency we can ship 
this until we have proof that performance favours the alternative.

- Dominic Hamon


On Sept. 17, 2014, 7:25 a.m., Kamil Domanski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25735/
> ---
> 
> (Updated Sept. 17, 2014, 7:25 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1805
> https://issues.apache.org/jira/browse/MESOS-1805
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> os::shell and an overload of strings::internal::fmt in stout pass a const 
> string parameter by copy instead of reference. This patch fixes that.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 
> 
> Diff: https://reviews.apache.org/r/25735/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/ && make check
> 
> 
> Thanks,
> 
> Kamil Domanski
> 
>

Build failed in Jenkins: mesos-reviewbot #1599

[Apache Jenkins Server]

See 

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Re: Review Request 25523: Add Docker pull to docker abstraction

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25523/
---

(Updated Sept. 17, 2014, 4:45 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/25523


Diffs (updated)
-

  src/docker/docker.hpp e7adedb93272209231a3a9aefecfd6ccc7802ff5 
  src/docker/docker.cpp a8becb8290c8982c64546c7f72d4bfe89f7ca5a1 
  src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
  src/tests/docker_tests.cpp e6c228a27a9c3cbf2fa0cc58843989c49fa90456 

Diff: https://reviews.apache.org/r/25523/diff/


Testing
---

make check


Thanks,

Timothy Chen

Build failed in Jenkins: mesos-reviewbot #1600

[Apache Jenkins Server]

See 

--
[...truncated 4022 lines...]
make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.cpp 
python/native/src/mesos/native/module.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/module.hpp 
python/native/src/mesos/native/module.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.cpp 
python/native/src/mesos/native/proxy_executor.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_executor.hpp 
python/native/src/mesos/native/proxy_executor.hpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.cpp 
python/native/src/mesos/native/proxy_scheduler.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/proxy_scheduler.hpp 
python/native/src/mesos/native/p

Re: Review Request 24776: Add docker containerizer destroy tests

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53692
---


Bad patch!

Reviews applied: [24776]

Failed command: git apply --index 24776.patch

Error:
 error: patch failed: src/slave/containerizer/docker.cpp:73
error: src/slave/containerizer/docker.cpp: patch does not apply
error: patch failed: src/tests/docker_containerizer_tests.cpp:1630
error: src/tests/docker_containerizer_tests.cpp: patch does not apply

- Mesos ReviewBot


On Sept. 17, 2014, 12:21 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 12:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 0febbac5df4126f6c8d9a06dd0ba1668d041b34a 
>   src/tests/docker_containerizer_tests.cpp 
> 8654f9c787bd207f6a7b821651e0c083bea9dc8a 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Jenkins build is back to normal : mesos-reviewbot #1601

[Apache Jenkins Server]

See 

Build failed in Jenkins: Mesos-Ubuntu-distcheck #335

[Apache Jenkins Server]

See 

Changes:

[benjamin.hindman] Override entrypoint when shell enabled in Docker.

--
[...truncated 3905 lines...]
libtool: link: g++ -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -o tests 
tests-decoder_tests.o tests-encoder_tests.o tests-http_tests.o tests-io_tests.o 
tests-main.o tests-mutex_tests.o tests-metrics_tests.o tests-owned_tests.o 
tests-process_tests.o tests-queue_tests.o tests-reap_tests.o 
tests-sequence_tests.o tests-shared_tests.o tests-statistics_tests.o 
tests-subprocess_tests.o tests-system_tests.o tests-timeseries_tests.o 
tests-time_tests.o  3rdparty/.libs/libgmock.a ./.libs/libprocess.a 

 

 3rdparty/glog-0.3.3/.libs/libglog.a -lpthread 
3rdparty/.libs/libry_http_parser.a 3rdparty/libev-4.15/.libs/libev.a -lm -lz 
-lrt
make[6]: Leaving directory 
`
make  check-local
make[6]: Entering directory 
`
./tests
WARNING: Logging before InitGoogleLogging() is written to STDERR
I0917 17:15:35.842186 17250 process.cpp:1771] libprocess is initialized on 
67.195.81.190:47543 for 16 cpus
Note: Google Test filter = 
[==] Running 0 tests from 0 test cases.
[==] 0 tests from 0 test cases ran. (0 ms total)
[  PASSED  ] 0 tests.

  YOU HAVE 3 DISABLED TESTS

make[6]: Leaving directory 
`
make[5]: Leaving directory 
`
Making check in include
make[5]: Entering directory 
`
make[5]: Nothing to be done for `check'.
make[5]: Leaving directory 
`
make[4]: Leaving directory 
`
make[4]: Entering directory 
`
make[4]: Nothing to be done for `check-am'.
make[4]: Leaving directory 
`
make[3]: Leaving directory 
`
make[2]: Leaving directory 
`
Making check in src
make[2]: Entering directory 
`
make  check-am
make[3]: Entering directory 
`
test "../.." = ".." ||  \
(/bin/mkdir -p python/src/mesos && cp -pf 
../../src/python/src/mesos/__init__.py python/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos && cp -pf 
../../src/python/interface/src/mesos/__init__.py 
python/interface/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/interface/src/mesos/interface && cp -pf 
../../src/python/interface/src/mesos/interface/__init__.py 
python/interface/src/mesos/interface/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos && cp -pf 
../../src/python/native/src/mesos/__init__.py 
python/native/src/mesos/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/__init__.py 
python/native/src/mesos/native/__init__.py)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.cpp 
python/native/src/mesos/native/mesos_executor_driver_impl.cpp)
test "../.." = ".." ||  \
(/bin/mkdir -p python/native/src/mesos/native && cp -pf 
../../src/python/native/src/mesos/native/mesos_executor_driver_impl.hpp 
python/native/src/mesos/native/mesos_executor_driver_impl.hpp)
test "../.." = ".." ||  \
(/bin/mkdir

Re: Review Request 25735: change const pass-by-value to const reference in stout

[Kamil Domanski]

> On Sept. 17, 2014, 6:32 p.m., Dominic Hamon wrote:
> > I'm not convinced that this is necessarily the way we want to go, given the 
> > benefits of move semantics in modern compilers, but for consistency we can 
> > ship this until we have proof that performance favours the alternative.

Isn't move construction more expensive than const reference?


- Kamil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review53688
---


On Sept. 17, 2014, 4:25 p.m., Kamil Domanski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25735/
> ---
> 
> (Updated Sept. 17, 2014, 4:25 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1805
> https://issues.apache.org/jira/browse/MESOS-1805
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> os::shell and an overload of strings::internal::fmt in stout pass a const 
> string parameter by copy instead of reference. This patch fixes that.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 
> 
> Diff: https://reviews.apache.org/r/25735/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/ && make check
> 
> 
> Thanks,
> 
> Kamil Domanski
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2107

[Apache Jenkins Server]

See 


Changes:

[benjamin.hindman] Override entrypoint when shell enabled in Docker.

--
[...truncated 3716 lines...]
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/python_message.py to 
python_message.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/descriptor.py to 
descriptor.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/descriptor_database.py to 
descriptor_database.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/message.py to 
message.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/descriptor_pool.py 
to descriptor_pool.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/dependency_links.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/namespace_packages.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/requires.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying protobuf.egg-info/top_level.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
creating dist
creating 'dist/protobuf-2.5.0-py2.7.egg' and adding 
'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
running bdist_egg
running egg_info
creating src/mesos.egg-info
writing requirements to src/mesos.egg-info/requires.txt
writing src/mesos.egg-info/PKG-INFO
writing namespace_packages to src/mesos.egg-info/namespace_packages.txt
writing top-level names to src/mesos.egg-info/top_level.txt
writing dependency_links to src/mesos.egg-info/dependency_links.txt
writing requirements to src/mesos.egg-info/requires.txt
writing src/mesos.egg-info/PKG-INFO
writing namespace_packages to src/mesos.egg-info/namespace_packages.txt
writing top-level names to src/mesos.egg-info/top_level.txt
writing dependency_links to src/mesos.egg-info/dependency_links.txt
writing manifest file 'src/mesos.egg-info/SOURCES.txt'
reading manifest file 'src/mesos.egg-info/SOURCES.txt'
writing manifest file 'src/mesos.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/mesos
copying src/mesos/__init__.py -> build/lib.linux-x86_64-2.7/mesos
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/egg
creating build/bdist.linux-x86_64/egg/mesos
copying build/lib.linux-x86_64-2.7/mesos/__init__.py -> 
build/bdist.linux-x86_64/egg/mesos
byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/dependency_links.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/namespace_packages.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/requires.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/top_level.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
mesos.__init__: module references __path__
creating dist
creating 'dist/mesos-0.21.0-py2.7.egg' and adding 
'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
running bdist_egg
running egg_info
creating src/mesos.interface.egg-info
writing requirements to src/mesos.interface.egg-info/requires.txt
writing src/mesos.interface.egg-info/PKG-INFO
writing namespace_packages to 
src/mesos.interface.egg-info/namespace_packages.txt
writing top-level names to src/mesos.interface.egg-info/top_level.txt
writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt
writing requirements to src/mesos.interface.egg-info/requires.txt
writing src/mesos.interface.egg-info/PKG-INFO
writing namespace_packages to 
src/mesos.interface.egg-info/namespace_packages.txt
writing top-level names to src/mesos.interface.egg-info/top_level.txt
writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt
writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt'
reading manifest file 'src/mesos.interface.egg-info/SOURCES.txt'
writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/mesos
copying src/mesos/__init__.py -> build/lib.linux-x86_64-2.7/mesos
creating build/lib.linux-x86_64-2.7/mesos/interface
copying src/mesos/interface/mesos_pb2.py -> 
build/lib.l

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25663/
---

(Updated Sept. 17, 2014, 11:12 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

New version: now Group::data() returns Future > instead of 
Future to capture the "NONODE" case.


Bugs: MESOS-1392
https://issues.apache.org/jira/browse/MESOS-1392


Repository: mesos-git


Description
---

See summary.


Diffs (updated)
-

  src/log/network.hpp fc85a57a38f89190fe246f16cd1fde3168d70613 
  src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
  src/tests/group_tests.cpp 7ed98956181f167e16cd723c049738f1c217c73b 
  src/zookeeper/group.hpp 16f9b7b390551402e3c1eddaf5657aa18766b47c 
  src/zookeeper/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 

Diff: https://reviews.apache.org/r/25663/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

[Jiang Yan Xu]

> On Sept. 16, 2014, 11:20 a.m., Ben Mahler wrote:
> > src/master/detector.cpp, lines 396-404
> > 
> >
> > Any way to explicitly ignore the no node case?
> > 
> > Here we're ignoring all failures, which is a bit scary, since it's not 
> > obvious why the more serious errors would be caught elsewhere.
> > 
> > I haven't put a lot of thought into this, could we return a 
> > Future > data? Or should we consider wrapping our things in 
> > some kind of ZKOperation which lets us look at the various error 
> > cases?
> > 
> > Happy to chat further!

Yeah I was (unnecessarily) concerned about the ambiguity of returning a None if 
the method is changed to: "Result > GroupProcess::doData(const 
Group::Membership& membership)".
Group needs to interpret the three different cases from the return value:
1. retryable error -> retry
2. nonode -> None
3. non-retryable error -> Failure

It turns out it's not that hard and we have precedence in the code base: 
https://github.com/apache/mesos/blob/190e87c51d25646fa501ffca0bf7150157982050/src/state/zookeeper.cpp#L427

So I revised the review to have Group return a None in the case of NONODE.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25663/#review53558
---


On Sept. 17, 2014, 11:12 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25663/
> ---
> 
> (Updated Sept. 17, 2014, 11:12 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1392
> https://issues.apache.org/jira/browse/MESOS-1392
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/log/network.hpp fc85a57a38f89190fe246f16cd1fde3168d70613 
>   src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
>   src/tests/group_tests.cpp 7ed98956181f167e16cd723c049738f1c217c73b 
>   src/zookeeper/group.hpp 16f9b7b390551402e3c1eddaf5657aa18766b47c 
>   src/zookeeper/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 
> 
> Diff: https://reviews.apache.org/r/25663/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Build failed in Jenkins: mesos-reviewbot #1600

[Vinod Kone]

On Wed, Sep 17, 2014 at 9:56 AM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:

> ../../src/tests/docker_tests.cpp: In member function 'virtual void
> DockerTest_ROOT_DOCKER_CheckPortResource_Test::TestBody()':
> ../../src/tests/docker_tests.cpp:263:28: error: 'AWAIT_EXPECTED_FAILED'
> was not declared in this scope
>AWAIT_EXPECTED_FAILED(run);
> ^
>

@Tim: Can you fix this?

Re: Review Request 25735: change const pass-by-value to const reference in stout

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review53704
---


Patch looks great!

Reviews applied: [25735]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2014, 2:25 p.m., Kamil Domanski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25735/
> ---
> 
> (Updated Sept. 17, 2014, 2:25 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1805
> https://issues.apache.org/jira/browse/MESOS-1805
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> os::shell and an overload of strings::internal::fmt in stout pass a const 
> string parameter by copy instead of reference. This patch fixes that.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 
> 
> Diff: https://reviews.apache.org/r/25735/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/ && make check
> 
> 
> Thanks,
> 
> Kamil Domanski
> 
>

Re: Build failed in Jenkins: mesos-reviewbot #1600

[Timothy Chen]

This should already been fixed with the latest master.

Tim

On Wed, Sep 17, 2014 at 2:17 PM, Vinod Kone  wrote:
>
> On Wed, Sep 17, 2014 at 9:56 AM, Apache Jenkins Server
>  wrote:
>>
>> ../../src/tests/docker_tests.cpp: In member function 'virtual void
>> DockerTest_ROOT_DOCKER_CheckPortResource_Test::TestBody()':
>> ../../src/tests/docker_tests.cpp:263:28: error: 'AWAIT_EXPECTED_FAILED'
>> was not declared in this scope
>>AWAIT_EXPECTED_FAILED(run);
>> ^
>
>
> @Tim: Can you fix this?
>

Re: Review Request 25035: Updated allocator to offer cpu only or memory only resources.

[Martin Weindel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---

(Updated Sept. 17, 2014, 6:36 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Updated the summary.

Also edited the CHANGELOG to point to a new ticket regarding deprecation.

I'll commit this now.


Summary (updated)
-

Updated allocator to offer cpu only or memory only resources.


Bugs: MESOS-1688
https://issues.apache.org/jira/browse/MESOS-1688


Repository: mesos-git


Description
---

As already explained in JIRA MESOS-1688, there are schedulers allocating memory 
only for the executor and not for tasks. For tasks only CPU resources are 
allocated in this case.
Such a scheduler does not get offered any idle CPUs if the slave has nearly 
used up all memory.
This can easily lead to a dead lock (in the application, not in Mesos).

Simple example:
1. Scheduler allocates all memory of a slave for an executor
2. Scheduler launches a task for this executor (allocating 1 CPU)
3. Task finishes: 1 CPU , 0 MB memory allocatable.
4. No offers are made, as no memory is left. Scheduler will wait for offers 
forever. Dead lock in the application.

To fix this problem, offers must be made if CPU resources are allocatable 
without considering allocatable memory


Diffs
-

  CHANGELOG a822cc4 
  src/common/resources.cpp edf36b1 
  src/master/constants.cpp faa1503 
  src/master/hierarchical_allocator_process.hpp 34f8cd6 
  src/master/master.cpp 18464ba 
  src/tests/allocator_tests.cpp 774528a 

Diff: https://reviews.apache.org/r/25035/diff/


Testing
---

Deployed patched Mesos 0.19.1 on a small cluster with 3 slaves and tested 
running multiple parallel Spark jobs in "fine-grained" mode to saturate 
allocatable memory. The jobs run fine now. This load always caused a dead lock 
in all Spark jobs within one minute with the unpatched Mesos.


Thanks,

Martin Weindel

Build failed in Jenkins: mesos-reviewbot #1603

[Apache Jenkins Server]

See 

Changes:

[yujie.jay] Added per-container egress rate limit for port mapping network 
isolator.

--
[...truncated 5415 lines...]
rm -f slave/containerizer/*.lo
rm -f slave/containerizer/isolators/cgroups/*.o
rm -f slave/containerizer/isolators/cgroups/*.lo
rm -f slave/containerizer/isolators/network/*.o
rm -f slave/containerizer/isolators/network/*.lo
rm -f slave/containerizer/mesos/*.o
rm -f slave/containerizer/mesos/*.lo
rm -f state/*.o
rm -f state/*.lo
rm -f tests/*.o
rm -rf authorizer/.libs authorizer/_libs
rm -rf common/.libs common/_libs
rm -rf containerizer/.libs containerizer/_libs
rm -rf docker/.libs docker/_libs
rm -rf exec/.libs exec/_libs
rm -rf files/.libs files/_libs
rm -rf java/jni/.libs java/jni/_libs
rm -rf jvm/.libs jvm/_libs
rm -rf jvm/org/apache/.libs jvm/org/apache/_libs
rm -rf linux/.libs linux/_libs
rm -rf linux/routing/.libs linux/routing/_libs
rm -rf linux/routing/filter/.libs linux/routing/filter/_libs
rm -rf linux/routing/link/.libs linux/routing/link/_libs
rm -rf linux/routing/queueing/.libs linux/routing/queueing/_libs
rm -rf local/.libs local/_libs
rm -rf log/.libs log/_libs
rm -rf log/tool/.libs log/tool/_libs
rm -rf logging/.libs logging/_libs
rm -rf master/.libs master/_libs
rm -f tests/common/*.o
rm -f usage/*.o
rm -f usage/*.lo
rm -f zookeeper/*.o
rm -rf messages/.libs messages/_libs
rm -rf sasl/.libs sasl/_libs
rm -f zookeeper/*.lo
rm -rf sched/.libs sched/_libs
rm -rf scheduler/.libs scheduler/_libs
rm -rf slave/.libs slave/_libs
rm -rf slave/containerizer/.libs slave/containerizer/_libs
rm -rf slave/containerizer/isolators/cgroups/.libs 
slave/containerizer/isolators/cgroups/_libs
rm -rf slave/containerizer/isolators/network/.libs 
slave/containerizer/isolators/network/_libs
rm -rf slave/containerizer/mesos/.libs slave/containerizer/mesos/_libs
rm -rf state/.libs state/_libs
rm -rf usage/.libs usage/_libs
rm -rf zookeeper/.libs zookeeper/_libs
rm -rf ./.deps authorizer/.deps cli/.deps common/.deps containerizer/.deps 
docker/.deps examples/.deps exec/.deps files/.deps health-check/.deps 
java/jni/.deps jvm/.deps jvm/org/apache/.deps launcher/.deps linux/.deps 
linux/routing/.deps linux/routing/filter/.deps linux/routing/link/.deps 
linux/routing/queueing/.deps local/.deps log/.deps log/tool/.deps logging/.deps 
master/.deps messages/.deps sasl/.deps sched/.deps scheduler/.deps slave/.deps 
slave/containerizer/.deps slave/containerizer/isolators/cgroups/.deps 
slave/containerizer/isolators/network/.deps slave/containerizer/mesos/.deps 
state/.deps tests/.deps tests/common/.deps usage/.deps zookeeper/.deps
rm -f Makefile
make[2]: Leaving directory 
`
Making distclean in ec2
make[2]: Entering directory 
`
rm -rf .libs _libs
rm -f *.lo
test -z "" || rm -f 
test . = "../../ec2" || test -z "" || rm -f 
rm -f Makefile
make[2]: Leaving directory 
`
rm -f config.status config.cache config.log configure.lineno 
config.status.lineno
rm -f Makefile
make[1]: Leaving directory 
`
if test -d "mesos-0.21.0"; then find "mesos-0.21.0" -type d ! -perm -200 -exec 
chmod u+w {} ';' && rm -rf "mesos-0.21.0" || { sleep 5 && rm -rf 
"mesos-0.21.0"; }; else :; fi
==
mesos-0.21.0 archives ready for distribution: 
mesos-0.21.0.tar.gz
==

real16m49.534s
user109m45.547s
sys 5m36.338s
+ chmod -R +w 3rdparty CHANGELOG Doxyfile LICENSE Makefile Makefile.am 
Makefile.in NOTICE README.md aclocal.m4 ar-lib autom4te.cache bin bootstrap 
compile config.guess config.log config.lt config.status config.sub configure 
configure.ac depcomp docs ec2 frameworks include install-sh libtool ltmain.sh 
m4 mesos-0.20.0 mesos-0.21.0.tar.gz mesos.pc mesos.pc.in missing mpi src support
+ git clean -fdx
Removing .libs/
Removing 3rdparty/Makefile
Removing 3rdparty/Makefile.in
Removing 3rdparty/libprocess/.deps/
Removing 3rdparty/libprocess/3rdparty/.deps/
Removing 3rdparty/libprocess/3rdparty/Makefile
Removing 3rdparty/libprocess/3rdparty/Makefile.in
Removing 3rdparty/libprocess/3rdparty/gmock_sources.cc
Removing 3rdparty/libprocess/3rdparty/stout/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/Makefile.in
Removing 3rdparty/libprocess/3rdparty/stout/aclocal.m4
Removing 3rdparty/libprocess/3rdparty/stout/autom4te.cache/
Removing 3rdparty/libprocess/3rdparty/stout/config.log
Removing 3rdparty/libprocess/3rdparty/stout/config.status
Removing 3rdparty/libprocess/3rdparty/stout/configure
Removing 3rdparty/libprocess/3rdparty/stout/include/Makefile
Removing 3rdparty/libprocess/3rdparty/stout/include/Makefile.in
Removing 3rdparty/l

Re: Review Request 25549: Basic filesystem isolator for Linux.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25549/#review53710
---


I'll take a look once the outstanding issues are addressed.

- Vinod Kone


On Sept. 15, 2014, 8:01 p.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25549/
> ---
> 
> (Updated Sept. 15, 2014, 8:01 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1586
> https://issues.apache.org/jira/browse/MESOS-1586
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Does not report usage or enforce quota but can create 'private' directories 
> for each container which mask parts of the shared host filesystem.
> 
> This review replaces https://reviews.apache.org/r/24178/ because of some file 
> renaming. I addressed all comments from earlier reviews.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 
>   src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/slave/containerizer/isolators/filesystem/shared.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/shared.cpp PRE-CREATION 
>   src/slave/containerizer/linux_launcher.cpp 
> d5ef1d6aa762cf81a3e8384552d97fe95b9cbd95 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9d083294caa5c5a47ba3ceaa1b57346144cb795c 
>   src/slave/flags.hpp 21e00212bc402674eaea73b44b3f91df477a7213 
>   src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 
>   src/tests/isolator_tests.cpp c38f87632cb6984543cb3767dbd656cde7459610 
>   src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 
> 
> Diff: https://reviews.apache.org/r/25549/diff/
> 
> 
> Testing
> ---
> 
> make check # added a test
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 25655: Add alternate os::chown taking uid and gid.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25655/#review53714
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 15, 2014, 8 p.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25655/
> ---
> 
> (Updated Sept. 15, 2014, 8 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Add alternate os::chown taking uid and gid.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5bbf829b3fa5d09a92e1d64c52c1fc7eed73fc91 
> 
> Diff: https://reviews.apache.org/r/25655/diff/
> 
> 
> Testing
> ---
> 
> Add alternate os::chown taking uid and gid.
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 25261: Check for variadic template support

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25261/#review53715
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 15, 2014, 10:26 p.m., Dominic Hamon wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25261/
> ---
> 
> (Updated Sept. 15, 2014, 10:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1752
> https://issues.apache.org/jira/browse/MESOS-1752
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> add c++11 language features to m4 macro that checks for c++11 support
> 
> 
> Diffs
> -
> 
>   docs/mesos-c++-style-guide.md 4381d24412aa3d5a6edd940ea8817515d6339f12 
>   m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b 
> 
> Diff: https://reviews.apache.org/r/25261/diff/
> 
> 
> Testing
> ---
> 
> built with g++-4.4, the minimum compiler we support.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2377

[Apache Jenkins Server]

See 

Re: Review Request 25622: Update the Mesos Style Guide with C++11 and naming notes.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25622/#review53718
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 15, 2014, 10:20 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25622/
> ---
> 
> (Updated Sept. 15, 2014, 10:20 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Dominic Hamon, and 
> Till Toenshoff.
> 
> 
> Bugs: MESOS-1793
> https://issues.apache.org/jira/browse/MESOS-1793
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Explicitly prohibit the use of namespace aliases. The discussion about using 
> namespace aliases took place in [the other 
> review](https://reviews.apache.org/r/25434/#comment91754). The majority 
> agreed not to introduce them in code.
> 
> Add a note about allowed C++11 features. This issue was discussed 
> [here](https://mail-archives.apache.org/mod_mbox/mesos-dev/201408.mbox/%3CCA+A2mTvk9RpUY0mFzdQnJTg8sA0nW-51fAwpuPrRjyGp+QV=a...@mail.gmail.com%3E)
>  and has to be officially documented.
> 
> 
> Diffs
> -
> 
>   docs/mesos-c++-style-guide.md 4381d24 
> 
> Diff: https://reviews.apache.org/r/25622/diff/
> 
> 
> Testing
> ---
> 
> Documentation change, no `make check` needed.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25663/#review53719
---


Bad patch!

Reviews applied: [25663]

Failed command: ./support/mesos-style.py

Error:
 Checking 506 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/tab,+whitespace/todo
src/log/network.hpp:142:  Lines should be <= 80 characters long  
[whitespace/line_length] [2]
Total errors found: 1

- Mesos ReviewBot


On Sept. 17, 2014, 6:12 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25663/
> ---
> 
> (Updated Sept. 17, 2014, 6:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1392
> https://issues.apache.org/jira/browse/MESOS-1392
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/log/network.hpp fc85a57a38f89190fe246f16cd1fde3168d70613 
>   src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
>   src/tests/group_tests.cpp 7ed98956181f167e16cd723c049738f1c217c73b 
>   src/zookeeper/group.hpp 16f9b7b390551402e3c1eddaf5657aa18766b47c 
>   src/zookeeper/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 
> 
> Diff: https://reviews.apache.org/r/25663/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Jenkins build is back to normal : mesos-reviewbot #1604

[Apache Jenkins Server]

See 

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #336

[Apache Jenkins Server]

See 

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

[Jiang Yan Xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25663/
---

(Updated Sept. 17, 2014, 12:26 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Minor styling fix.


Bugs: MESOS-1392
https://issues.apache.org/jira/browse/MESOS-1392


Repository: mesos-git


Description
---

See summary.


Diffs (updated)
-

  src/log/network.hpp fc85a57a38f89190fe246f16cd1fde3168d70613 
  src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
  src/tests/group_tests.cpp 7ed98956181f167e16cd723c049738f1c217c73b 
  src/zookeeper/group.hpp 16f9b7b390551402e3c1eddaf5657aa18766b47c 
  src/zookeeper/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 

Diff: https://reviews.apache.org/r/25663/diff/


Testing
---

make check.


Thanks,

Jiang Yan Xu

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25663/#review53739
---


Patch looks great!

Reviews applied: [25663]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2014, 7:26 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25663/
> ---
> 
> (Updated Sept. 17, 2014, 7:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1392
> https://issues.apache.org/jira/browse/MESOS-1392
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/log/network.hpp fc85a57a38f89190fe246f16cd1fde3168d70613 
>   src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
>   src/tests/group_tests.cpp 7ed98956181f167e16cd723c049738f1c217c73b 
>   src/zookeeper/group.hpp 16f9b7b390551402e3c1eddaf5657aa18766b47c 
>   src/zookeeper/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 
> 
> Diff: https://reviews.apache.org/r/25663/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 25735: change const pass-by-value to const reference in stout

[Dominic Hamon]

> On Sept. 17, 2014, 9:32 a.m., Dominic Hamon wrote:
> > I'm not convinced that this is necessarily the way we want to go, given the 
> > benefits of move semantics in modern compilers, but for consistency we can 
> > ship this until we have proof that performance favours the alternative.
> 
> Kamil Domanski wrote:
> Isn't move construction more expensive than const reference?

http://stackoverflow.com/questions/21605579/how-true-is-want-speed-pass-by-value

copy, yes. move, no. maybe. ;)


- Dominic


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25735/#review53688
---


On Sept. 17, 2014, 7:25 a.m., Kamil Domanski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25735/
> ---
> 
> (Updated Sept. 17, 2014, 7:25 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1805
> https://issues.apache.org/jira/browse/MESOS-1805
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> os::shell and an overload of strings::internal::fmt in stout pass a const 
> string parameter by copy instead of reference. This patch fixes that.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 
> 
> Diff: https://reviews.apache.org/r/25735/diff/
> 
> 
> Testing
> ---
> 
> cd 3rdparty/libprocess/3rdparty/ && make check
> 
> 
> Thanks,
> 
> Kamil Domanski
> 
>

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2108

[Apache Jenkins Server]

See 


Changes:

[benjamin.hindman] Add Docker pull to docker abstraction.

[yujie.jay] Added per-container egress rate limit for port mapping network 
isolator.

--
[...truncated 3692 lines...]
writing requirements to src/mesos.egg-info/requires.txt
writing src/mesos.egg-info/PKG-INFO
writing namespace_packages to src/mesos.egg-info/namespace_packages.txt
writing top-level names to src/mesos.egg-info/top_level.txt
writing dependency_links to src/mesos.egg-info/dependency_links.txt
writing manifest file 'src/mesos.egg-info/SOURCES.txt'
reading manifest file 'src/mesos.egg-info/SOURCES.txt'
writing manifest file 'src/mesos.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/mesos
copying src/mesos/__init__.py -> build/lib.linux-x86_64-2.7/mesos
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/egg
creating build/bdist.linux-x86_64/egg/mesos
copying build/lib.linux-x86_64-2.7/mesos/__init__.py -> 
build/bdist.linux-x86_64/egg/mesos
byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/dependency_links.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/namespace_packages.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/requires.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.egg-info/top_level.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
mesos.__init__: module references __path__
creating dist
creating 'dist/mesos-0.21.0-py2.7.egg' and adding 
'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
running bdist_egg
running egg_info
creating src/mesos.interface.egg-info
writing requirements to src/mesos.interface.egg-info/requires.txt
writing src/mesos.interface.egg-info/PKG-INFO
writing namespace_packages to 
src/mesos.interface.egg-info/namespace_packages.txt
writing top-level names to src/mesos.interface.egg-info/top_level.txt
writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt
writing requirements to src/mesos.interface.egg-info/requires.txt
writing src/mesos.interface.egg-info/PKG-INFO
writing namespace_packages to 
src/mesos.interface.egg-info/namespace_packages.txt
writing top-level names to src/mesos.interface.egg-info/top_level.txt
writing dependency_links to src/mesos.interface.egg-info/dependency_links.txt
writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt'
reading manifest file 'src/mesos.interface.egg-info/SOURCES.txt'
writing manifest file 'src/mesos.interface.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/mesos
copying src/mesos/__init__.py -> build/lib.linux-x86_64-2.7/mesos
creating build/lib.linux-x86_64-2.7/mesos/interface
copying src/mesos/interface/mesos_pb2.py -> 
build/lib.linux-x86_64-2.7/mesos/interface
copying src/mesos/interface/__init__.py -> 
build/lib.linux-x86_64-2.7/mesos/interface
copying src/mesos/interface/containerizer_pb2.py -> 
build/lib.linux-x86_64-2.7/mesos/interface
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/egg
creating build/bdist.linux-x86_64/egg/mesos
creating build/bdist.linux-x86_64/egg/mesos/interface
copying build/lib.linux-x86_64-2.7/mesos/interface/mesos_pb2.py -> 
build/bdist.linux-x86_64/egg/mesos/interface
copying build/lib.linux-x86_64-2.7/mesos/interface/__init__.py -> 
build/bdist.linux-x86_64/egg/mesos/interface
copying build/lib.linux-x86_64-2.7/mesos/interface/containerizer_pb2.py -> 
build/bdist.linux-x86_64/egg/mesos/interface
copying build/lib.linux-x86_64-2.7/mesos/__init__.py -> 
build/bdist.linux-x86_64/egg/mesos
byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/mesos_pb2.py to 
mesos_pb2.pyc
byte-compiling build/bdist.linux-x86_64/egg/mesos/interface/__init__.py to 
__init__.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/mesos/interface/containerizer_pb2.py to 
containerizer_pb2.pyc
byte-compiling build/bdist.linux-x86_64/egg/mesos/__init__.py to __init__.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.interface.egg-info/PKG-INFO -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.interface.egg-info/SOURCES.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.interface.egg-info/dependency_links.txt -> 
build/bdist.linux-x86_64/egg/EGG-INFO
copying src/mesos.interface.egg-info

Review Request 25756: post-reviews.py: added --no-color to git log.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/
---

Review request for mesos.


Repository: mesos-git


Description
---

- For setups that have colored output for git log.


Diffs
-

  support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e 

Diff: https://reviews.apache.org/r/25756/diff/


Testing
---

Created this review request using the updated script.


Thanks,

Kapil Arya

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/#review53755
---

Ship it!


Ship It!

- Timothy Chen


On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25756/
> ---
> 
> (Updated Sept. 17, 2014, 10:26 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> - For setups that have colored output for git log.
> 
> 
> Diffs
> -
> 
>   support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e 
> 
> Diff: https://reviews.apache.org/r/25756/diff/
> 
> 
> Testing
> ---
> 
> Created this review request using the updated script.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25565: Added a removeExecutor helper in the Master.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25565/
---

(Updated Sept. 17, 2014, 10:47 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Rephrased logging message per Vinod's review.


Repository: mesos-git


Description
---

This adds a removeExecutor helper based on a TODO that I added awhile ago.

Much like removeTask, removeExecutor will help avoid future resource accounting 
bugs. I also cleaned up Master::finalize 


Diffs (updated)
-

  src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 
  src/master/master.cpp 41dcc462f04ee44ab16cde2c542a7bf27e46a913 

Diff: https://reviews.apache.org/r/25565/diff/


Testing
---

no functional change

make check


Thanks,

Ben Mahler

Re: Review Request 25565: Added a removeExecutor helper in the Master.

[Ben Mahler]

> On Sept. 12, 2014, 9:45 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 3312
> > 
> >
> > We do have a executorLost() callback now! Just send it already and fix 
> > MESOS-313?

Yikes! I'm a bit weary of sneaking that in this cleanup change. There are some 
bigger questions around that callback, since it's not reliable I'm not sure how 
we'd expect frameworks to leverage it. Executors are also not reconciled 
correctly between the master and the slave.


> On Sept. 12, 2014, 9:45 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 3828
> > 
> >
> > I think "absent in re-registration of slave" is a bit unclear for 
> > people reading this log line in master logs?
> > 
> > How about "...possibly unknown to the slave"? I'm assuming you wanted 
> > to rephrase because slave could actually know it?

The main reason I rephrased was because we now log "Removing executor" inside 
removeExecutor().

I've re-phrased per your comment and left a NOTE about the current issues 
around MESOS-1466, MESOS-1800, and MESOS-1720.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25565/#review53222
---


On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25565/
> ---
> 
> (Updated Sept. 12, 2014, 2:01 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> This adds a removeExecutor helper based on a TODO that I added awhile ago.
> 
> Much like removeTask, removeExecutor will help avoid future resource 
> accounting bugs. I also cleaned up Master::finalize 
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp b4926001178ebb00b34b0b7e03f491d4a800afc2 
>   src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 
> 
> Diff: https://reviews.apache.org/r/25565/diff/
> 
> 
> Testing
> ---
> 
> no functional change
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Review Request 25755: Replace os::Release with Version.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/
---

Review request for mesos.


Repository: mesos-git


Description
---

Version is now the preferred way for managing releases/versions.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
02a1e5842110f87cb12a917e5dc5ccadb54faacb 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
84ef49c410a08d60f77131e05e8ecfc5ed825f38 
  src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 

Diff: https://reviews.apache.org/r/25755/diff/


Testing
---

Ran make check


Thanks,

Kapil Arya

Re: Review Request 25663: MESOS-1392: MasterDetector now returns a None when it cannot read the content of the ZNode it has detected.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25663/#review53762
---

Ship it!


Thanks for adding the test!

Too bad there is so much duplicated code between Group and ZooKeeperStorage, we 
already solved this problem in ZooKeeperStorage! ;)

- Ben Mahler


On Sept. 17, 2014, 7:26 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25663/
> ---
> 
> (Updated Sept. 17, 2014, 7:26 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1392
> https://issues.apache.org/jira/browse/MESOS-1392
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/log/network.hpp fc85a57a38f89190fe246f16cd1fde3168d70613 
>   src/master/detector.cpp 6436b8ee7e1ab6451a6b999a1cfbb2f79190e6ca 
>   src/tests/group_tests.cpp 7ed98956181f167e16cd723c049738f1c217c73b 
>   src/zookeeper/group.hpp 16f9b7b390551402e3c1eddaf5657aa18766b47c 
>   src/zookeeper/group.cpp 58491c01052b68ddaee6af32f33192d5a1f20e58 
> 
> Diff: https://reviews.apache.org/r/25663/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 25755: Replace os::Release with Version.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/#review53763
---

Ship it!


Ship It!

- Ian Downes


On Sept. 17, 2014, 3:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25755/
> ---
> 
> (Updated Sept. 17, 2014, 3:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Version is now the preferred way for managing releases/versions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 02a1e5842110f87cb12a917e5dc5ccadb54faacb 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 84ef49c410a08d60f77131e05e8ecfc5ed825f38 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25755/diff/
> 
> 
> Testing
> ---
> 
> Ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25755: Replace os::Release with Version.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/#review53764
---

Ship it!


Looks great! Thanks for following up.

I will split this patch for you across stout and mesos this time. We split our 
reviews across stout/libprocess/mesos because the former two are still 
considered separate libraries. :)

- Ben Mahler


On Sept. 17, 2014, 10:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25755/
> ---
> 
> (Updated Sept. 17, 2014, 10:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Version is now the preferred way for managing releases/versions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 02a1e5842110f87cb12a917e5dc5ccadb54faacb 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 84ef49c410a08d60f77131e05e8ecfc5ed825f38 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25755/diff/
> 
> 
> Testing
> ---
> 
> Ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/#review53765
---


Can you add a little more description as to what this is fixing? It's hard to 
tell.

- Ben Mahler


On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25756/
> ---
> 
> (Updated Sept. 17, 2014, 10:26 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> - For setups that have colored output for git log.
> 
> 
> Diffs
> -
> 
>   support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e 
> 
> Diff: https://reviews.apache.org/r/25756/diff/
> 
> 
> Testing
> ---
> 
> Created this review request using the updated script.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 11:11 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Summary (updated)
-

Add docker containerizer destroy tests and modify docker pull


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs (updated)
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53767
---



src/slave/containerizer/docker.cpp


Why call new DockerContainerizerProcess twice?


- Adam B


On Sept. 17, 2014, 4:11 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 4:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
>   src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/tests/docker_containerizer_tests.cpp 
> 1981f49d228903ccaa094a9747dec49054c1e0f2 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 25755: Replace os::Release with Version.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/#review53766
---


Whoops, looks like the test fails for me. Since we need to fix it, can you 
split the patch while you're at it?

I think the parsing needs to be more advanced to handle OSes with labels on the 
versions.


3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp


This test fails on my machine:

[ RUN  ] OsTest.release
../../../../3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp:270: 
Failure
info: Version string has 4 components; maximum 3 components allowed

$ uname -a
 2.6.44-LABEL.el5 #1 SMP Tue May 13 15:46:59 PDT 2014 x86_64 x86_64 
x86_64 GNU/Linux


- Ben Mahler


On Sept. 17, 2014, 10:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25755/
> ---
> 
> (Updated Sept. 17, 2014, 10:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Version is now the preferred way for managing releases/versions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 02a1e5842110f87cb12a917e5dc5ccadb54faacb 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 84ef49c410a08d60f77131e05e8ecfc5ed825f38 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25755/diff/
> 
> 
> Testing
> ---
> 
> Ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

> On Sept. 17, 2014, 11:20 p.m., Adam B wrote:
> > src/slave/containerizer/docker.cpp, lines 353-358
> > 
> >
> > Why call new DockerContainerizerProcess twice?

Oops, bad merge!


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53767
---


On Sept. 17, 2014, 11:11 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 11:11 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
>   src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/tests/docker_containerizer_tests.cpp 
> 1981f49d228903ccaa094a9747dec49054c1e0f2 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 11:22 p.m.)


Review request for drill, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs (updated)
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/
---

(Updated Sept. 17, 2014, 11:22 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/24776


Diffs
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
  src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/24776/diff/


Testing
---

make check


Thanks,

Timothy Chen

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2109

[Apache Jenkins Server]

See 


Changes:

[vinodkone] Updated allocator to offer cpu only or memory only resources.

[adam] Added CHANGELOG for 0.20.1.

[dhamon] Check for variadic template support

--
[...truncated 2109 lines...]
checking ucontext.h presence... yes
checking for ucontext.h... yes
checking sys/utsname.h usability... yes
checking sys/utsname.h presence... yes
checking for sys/utsname.h... yes
checking pwd.h usability... yes
checking pwd.h presence... yes
checking for pwd.h... yes
checking syslog.h usability... yes
checking syslog.h presence... yes
checking for syslog.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking glob.h usability... yes
checking glob.h presence... yes
checking for glob.h... yes
checking unwind.h usability... yes
checking unwind.h presence... yes
checking for unwind.h... yes
checking size of void *... 8
checking for uint16_t... yes
checking for u_int16_t... yes
checking for __uint16... no
checking for sigaltstack... yes
checking for dladdr... no
checking for fcntl... yes
checking for __attribute__... yes
checking for __builtin_expect... yes
checking for __sync_val_compare_and_swap... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking whether to check for GCC pthread/shared inconsistencies... yes
checking whether -pthread is sufficient with -shared... yes
checking for pthread_self in -lpthread... yes
checking for main in -lgflags... no
checking for gtest-config... no
checking support for pthread_rwlock_* functions... yes
checking whether the compiler implements namespaces... yes
checking what namespace STL code is in... std
checking whether compiler supports using ::operator<<... 1
checking for ucontext.h... (cached) yes
checking sys/ucontext.h usability... yes
checking sys/ucontext.h presence... yes
checking for sys/ucontext.h... yes
checking how to access the program counter from a struct ucontext... 
uc_mcontext.gregs[REG_RIP]
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/glog/logging.h
config.status: creating src/glog/raw_logging.h
config.status: creating src/glog/vlog_is_on.h
config.status: creating src/glog/stl_logging.h
config.status: creating libglog.pc
config.status: creating src/config.h
config.status: executing depfiles commands
config.status: executing libtool commands
make[7]: Entering directory 
`
/bin/bash ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src 
 -I./src-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  
-DNO_FRAME_POINTER  -DNDEBUG -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 
-MT libglog_la-logging.lo -MD -MP -MF .deps/libglog_la-logging.Tpo -c -o 
libglog_la-logging.lo `test -f 'src/logging.cc' || echo './'`src/logging.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall 
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER 
-DNDEBUG -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT 
libglog_la-logging.lo -MD -MP -MF .deps/libglog_la-logging.Tpo -c 
src/logging.cc  -fPIC -DPIC -o libglog_la-logging.o
mv -f .deps/libglog_la-logging.Tpo .deps/libglog_la-logging.Plo
/bin/bash ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src 
 -I./src-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  
-DNO_FRAME_POINTER  -DNDEBUG -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 
-MT libglog_la-raw_logging.lo -MD -MP -MF .deps/libglog_la-raw_logging.Tpo -c 
-o libglog_la-raw_logging.lo `test -f 'src/raw_logging.cc' || echo 
'./'`src/raw_logging.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I./src -I./src -Wall 
-Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -DNO_FRAME_POINTER 
-DNDEBUG -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 -MT 
libglog_la-raw_logging.lo -MD -MP -MF .deps/libglog_la-raw_logging.Tpo -c 
src/raw_logging.cc  -fPIC -DPIC -o libglog_la-raw_logging.o
mv -f .deps/libglog_la-raw_logging.Tpo .deps/libglog_la-raw_logging.Plo
/bin/bash ./libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I./src 
 -I./src-Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare  
-DNO_FRAME_POINTER  -DNDEBUG -g -g2 -O2 -Wno-unused-local-typedefs -std=c++11 
-MT libglog_la-vlog_is_on.lo -MD -MP -MF .deps/libglog_la-vlog_is_on.Tpo -c -o 
libglog_la-vlog_is_on.lo `test -f 'src/vlog_is_on.cc' || ech

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/#review53772
---


Patch looks great!

Reviews applied: [25756]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2014, 10:26 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25756/
> ---
> 
> (Updated Sept. 17, 2014, 10:26 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> - For setups that have colored output for git log.
> 
> 
> Diffs
> -
> 
>   support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e 
> 
> Diff: https://reviews.apache.org/r/25756/diff/
> 
> 
> Testing
> ---
> 
> Created this review request using the updated script.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 25756: post-reviews.py: added --no-color to git log.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25756/
---

(Updated Sept. 17, 2014, 7:35 p.m.)


Review request for mesos.


Changes
---

Updated problem description


Repository: mesos-git


Description (updated)
---

For setups that have colored output for git log.

For example, the command "git --no-pager log --pretty=oneline --reverse 
master..HEAD" should generate output similiar to the following:
```
fa7e46cfc228e9f80e08d7c28a978d561fbba5a7 post-reviews.py: added --no-color to 
git log. - For setups that have colored output for git log.
```

However, in a setup where git emits colored output, the raw output would look 
like the following:
```
^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m post-reviews.py: added 
--no-color to git log. - For setups that have colored output for git log.
```

The parser in post-review.py then picks 
'`^[[33mfa7e46cfc228e9f80e08d7c28a978d561fbba5a7^[[m`' as the sha and crashes.

The fix is to add '--no-color' to force git to never emit colored ouput.


Diffs
-

  support/post-reviews.py ee27bb8119b4992d5533d09de260b4668b9d6b3e 

Diff: https://reviews.apache.org/r/25756/diff/


Testing
---

Created this review request using the updated script.


Thanks,

Kapil Arya

Review Request 25758: Modify docker pull to call inspect after pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25758/
---

Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description
---

Modify docker pull to call inspect after pull


Diffs
-

  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/25758/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 25755: Replace os::Release with Version.

[Kapil Arya]

> On Sept. 17, 2014, 7:20 p.m., Ben Mahler wrote:
> > Whoops, looks like the test fails for me. Since we need to fix it, can you 
> > split the patch while you're at it?
> > 
> > I think the parsing needs to be more advanced to handle OSes with labels on 
> > the versions.

Not just labels, but also more than three components.  Should we change the 
Version to support arbitrary number of components before pushing this change 
through?  In this particular case, the version string has four components 
"2.6.44-LABEL.el5" and the current parser will fail even if there were no 
labels.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/#review53766
---


On Sept. 17, 2014, 6:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25755/
> ---
> 
> (Updated Sept. 17, 2014, 6:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Version is now the preferred way for managing releases/versions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 02a1e5842110f87cb12a917e5dc5ccadb54faacb 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 84ef49c410a08d60f77131e05e8ecfc5ed825f38 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25755/diff/
> 
> 
> Testing
> ---
> 
> Ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2110

[Apache Jenkins Server]

See 

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24776/#review53781
---


Patch looks great!

Reviews applied: [24776]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2014, 11:22 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24776/
> ---
> 
> (Updated Sept. 17, 2014, 11:22 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/24776
> 
> 
> Diffs
> -
> 
>   src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
>   src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
>   src/slave/containerizer/docker.hpp fbbd45d77e5f2f74ca893552f85eb893b3dd948f 
>   src/slave/containerizer/docker.cpp 9a2948951f57f3ab16291df51cd9f33e5e96add4 
>   src/tests/docker_containerizer_tests.cpp 
> 1981f49d228903ccaa094a9747dec49054c1e0f2 
> 
> Diff: https://reviews.apache.org/r/24776/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

[VOTE] Release Apache Mesos 0.20.1 (rc2)

[Adam Bordelon]

Hi all,

Please vote on releasing the following candidate as Apache Mesos 0.20.1.


0.20.1 includes the following:

Minor bug fixes for docker integration, network isolation, etc.

The CHANGELOG for the release is available at:
https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc2


The candidate for Mesos 0.20.1 release is available at:
https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz

The tag to be voted on is 0.20.1-rc2:
https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc2

The MD5 checksum of the tarball can be found at:
https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.md5

The signature of the tarball can be found at:
https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.asc

The PGP key used to sign the release is here:
https://dist.apache.org/repos/dist/release/mesos/KEYS

The JAR is up in Maven in a staging repository here:
https://repository.apache.org/content/repositories/orgapachemesos-1034

Please vote on releasing this package as Apache Mesos 0.20.1!

The vote is open until  and passes if a majority of at least 3 +1 PMC votes
are cast.

[ ] +1 Release this package as Apache Mesos 0.20.1
[ ] -1 Do not release this package because ...

Thanks,
-Adam-

Re: Review Request 25755: Replace os::Release with Version.

[Ben Mahler]

> On Sept. 17, 2014, 11:20 p.m., Ben Mahler wrote:
> > Whoops, looks like the test fails for me. Since we need to fix it, can you 
> > split the patch while you're at it?
> > 
> > I think the parsing needs to be more advanced to handle OSes with labels on 
> > the versions.
> 
> Kapil Arya wrote:
> Not just labels, but also more than three components.  Should we change 
> the Version to support arbitrary number of components before pushing this 
> change through?  In this particular case, the version string has four 
> components "2.6.44-LABEL.el5" and the current parser will fail even if there 
> were no labels.

Yeah, longer term probably we should handle everything allowed by semantic 
versioning: http://semver.org/

I think the easiest thing for now is to just keep the sscanf in os.hpp and 
construct the Version with the parsed integers. That way, we can get this 
committed with a TODO on Version for parsing labels and build metadata.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25755/#review53766
---


On Sept. 17, 2014, 10:50 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25755/
> ---
> 
> (Updated Sept. 17, 2014, 10:50 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Version is now the preferred way for managing releases/versions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 02a1e5842110f87cb12a917e5dc5ccadb54faacb 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 84ef49c410a08d60f77131e05e8ecfc5ed825f38 
>   src/linux/perf.cpp 1a851a11abb1292eeb2267ed679c68fbb5aa8290 
> 
> Diff: https://reviews.apache.org/r/25755/diff/
> 
> 
> Testing
> ---
> 
> Ran make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/
---

(Updated Sept. 17, 2014, 6:47 p.m.)


Review request for mesos.


Changes
---

Addressed all issues. Adapted to changes from rebasing changes related to the 
hashmap for pending tasks. Thus no longer depending on the proposed small 
change to stout - cancelling that. 


Bugs: MESOS-947
https://issues.apache.org/jira/browse/MESOS-947


Repository: mesos-git


Description (updated)
---

Fixes MESOS-947 "Slave should properly handle a killTask() that arrives between 
runTask() and _runTask()".

Slave::killTask() did not check for task in question combination to be 
"pending" (i.e. Slave::runTask had happened, but Slave::_runTask had not yet) 
and then erroneously assumed that Slave::runTask() had not been executed. The 
task was then marked "LOST" instead of "KILLED". But Slave::runTask had already 
scheduled Slave::_runTask to follow. Now the entry for being "pending" is 
removed, and the task is marked "KILLED", and _runTask gets informed about 
this. It checks whether the task in question is currently "pending" and if it 
is not, then it infers that the task has been killed and does not erroneously 
try to complete launching it.


Diffs (updated)
-

  src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 
  src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e 
  src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 
  src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773 
  src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4 

Diff: https://reviews.apache.org/r/23912/diff/


Testing (updated)
---

Wrote a unit test that reliably created the situation described in the ticket. 
Observed that TASK_LOST and the listed log output occurred. This pointed 
directly to the lines in killTask() where the problem is rooted. Ran the test 
after fixing, it succeeded. Checked the log. It looks like a "clean kill" now 
:-)


Thanks,

Bernd Mathiske

Re: [VOTE] Release Apache Mesos 0.20.1 (rc2)

[Adam Bordelon]

Update: The vote is open until Mon Sep 22 10:00:00 PDT 2014 and passes if a
majority of at least 3 +1 PMC votes are cast.

On Wed, Sep 17, 2014 at 6:27 PM, Adam Bordelon  wrote:

> Hi all,
>
> Please vote on releasing the following candidate as Apache Mesos 0.20.1.
>
>
> 0.20.1 includes the following:
>
> 
> Minor bug fixes for docker integration, network isolation, etc.
>
> The CHANGELOG for the release is available at:
>
> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc2
>
> 
>
> The candidate for Mesos 0.20.1 release is available at:
> https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz
>
> The tag to be voted on is 0.20.1-rc2:
> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc2
>
> The MD5 checksum of the tarball can be found at:
>
> https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.md5
>
> The signature of the tarball can be found at:
>
> https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.asc
>
> The PGP key used to sign the release is here:
> https://dist.apache.org/repos/dist/release/mesos/KEYS
>
> The JAR is up in Maven in a staging repository here:
> https://repository.apache.org/content/repositories/orgapachemesos-1034
>
> Please vote on releasing this package as Apache Mesos 0.20.1!
>
> The vote is open until  and passes if a majority of at least 3 +1 PMC
> votes are cast.
>
> [ ] +1 Release this package as Apache Mesos 0.20.1
> [ ] -1 Do not release this package because ...
>
> Thanks,
> -Adam-
>

Re: Review Request 23912: Fix MESOS-947: Slave should properly handle a killTask() that arrives between runTask() and _runTask()

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23912/#review53790
---


Patch looks great!

Reviews applied: [23912]

All tests passed.

- Mesos ReviewBot


On Sept. 18, 2014, 1:47 a.m., Bernd Mathiske wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23912/
> ---
> 
> (Updated Sept. 18, 2014, 1:47 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-947
> https://issues.apache.org/jira/browse/MESOS-947
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Fixes MESOS-947 "Slave should properly handle a killTask() that arrives 
> between runTask() and _runTask()".
> 
> Slave::killTask() did not check for task in question combination to be 
> "pending" (i.e. Slave::runTask had happened, but Slave::_runTask had not yet) 
> and then erroneously assumed that Slave::runTask() had not been executed. The 
> task was then marked "LOST" instead of "KILLED". But Slave::runTask had 
> already scheduled Slave::_runTask to follow. Now the entry for being 
> "pending" is removed, and the task is marked "KILLED", and _runTask gets 
> informed about this. It checks whether the task in question is currently 
> "pending" and if it is not, then it infers that the task has been killed and 
> does not erroneously try to complete launching it.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 
>   src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e 
>   src/tests/mesos.hpp 957e2233cc11c438fd80d3b6d1907a1223093104 
>   src/tests/mesos.cpp 3dcb2acd5ad4ab5e3a7b4fe524ee077558112773 
>   src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4 
> 
> Diff: https://reviews.apache.org/r/23912/diff/
> 
> 
> Testing
> ---
> 
> Wrote a unit test that reliably created the situation described in the 
> ticket. Observed that TASK_LOST and the listed log output occurred. This 
> pointed directly to the lines in killTask() where the problem is rooted. Ran 
> the test after fixing, it succeeded. Checked the log. It looks like a "clean 
> kill" now :-)
> 
> 
> Thanks,
> 
> Bernd Mathiske
> 
>

Re: [VOTE] Release Apache Mesos 0.20.1 (rc2)

[Vinod Kone]

+1 (binding)

make check passes on CentOS 5.5 w/ gcc 4.8.2.



On Wed, Sep 17, 2014 at 7:42 PM, Adam Bordelon  wrote:

> Update: The vote is open until Mon Sep 22 10:00:00 PDT 2014 and passes if
> a majority of at least 3 +1 PMC votes are cast.
>
> On Wed, Sep 17, 2014 at 6:27 PM, Adam Bordelon  wrote:
>
>> Hi all,
>>
>> Please vote on releasing the following candidate as Apache Mesos 0.20.1.
>>
>>
>> 0.20.1 includes the following:
>>
>> 
>> Minor bug fixes for docker integration, network isolation, etc.
>>
>> The CHANGELOG for the release is available at:
>>
>> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.20.1-rc2
>>
>> 
>>
>> The candidate for Mesos 0.20.1 release is available at:
>>
>> https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz
>>
>> The tag to be voted on is 0.20.1-rc2:
>> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.20.1-rc2
>>
>> The MD5 checksum of the tarball can be found at:
>>
>> https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.md5
>>
>> The signature of the tarball can be found at:
>>
>> https://dist.apache.org/repos/dist/dev/mesos/0.20.1-rc2/mesos-0.20.1.tar.gz.asc
>>
>> The PGP key used to sign the release is here:
>> https://dist.apache.org/repos/dist/release/mesos/KEYS
>>
>> The JAR is up in Maven in a staging repository here:
>> https://repository.apache.org/content/repositories/orgapachemesos-1034
>>
>> Please vote on releasing this package as Apache Mesos 0.20.1!
>>
>> The vote is open until  and passes if a majority of at least 3 +1 PMC
>> votes are cast.
>>
>> [ ] +1 Release this package as Apache Mesos 0.20.1
>> [ ] -1 Do not release this package because ...
>>
>> Thanks,
>> -Adam-
>>
>
>

Re: Review Request 25758: Modify docker pull to call inspect after pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25758/
---

(Updated Sept. 18, 2014, 5:51 a.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos-git


Description (updated)
---

Review: https://reviews.apache.org/r/25758


Diffs (updated)
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/25758/diff/


Testing
---

make check


Thanks,

Timothy Chen

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2381

[Apache Jenkins Server]

See 


Changes:

[yan] MESOS-1392: MasterDetector now returns a None when it cannot read the 
content of the ZNode it has detected.

--
[...truncated 56842 lines...]
I0918 05:53:10.551653 18237 replica.cpp:676] Persisted action at 4
I0918 05:53:10.551663 18237 replica.cpp:661] Replica learned TRUNCATE action at 
position 4
I0918 05:53:10.552196 18237 hierarchical_allocator_process.hpp:659] Performed 
allocation for 1 slaves in 19675ns
I0918 05:53:10.552340 18217 master.cpp:120] No whitelist given. Advertising 
offers for all slaves
I0918 05:53:10.552553 18222 slave.cpp:2347] Received ping from 
slave-observer(167)@67.195.81.187:38947
I0918 05:53:10.562322 18222 hierarchical_allocator_process.hpp:659] Performed 
allocation for 1 slaves in 10491ns
I0918 05:53:10.562371 18222 master.cpp:120] No whitelist given. Advertising 
offers for all slaves
I0918 05:53:10.562487 18222 slave.cpp:3075] Current usage 5.96%. Max allowed 
age: 5.882624472725741days
I0918 05:53:10.562572 18222 slave.cpp:587] No pings from master received within 
75secs
I0918 05:53:10.562589 18222 slave.cpp:647] Detecting new master
I0918 05:53:10.562674 18222 slave.cpp:600] New master detected at 
master@67.195.81.187:38947
I0918 05:53:10.562701 18222 slave.cpp:674] Authenticating with master 
master@67.195.81.187:38947
I0918 05:53:10.562752 18222 slave.cpp:647] Detecting new master
I0918 05:53:10.562791 18222 status_update_manager.cpp:167] New master detected 
at master@67.195.81.187:38947
I0918 05:53:10.562830 18222 authenticatee.hpp:128] Creating new client SASL 
connection
I0918 05:53:10.562927 18222 master.cpp:1711] Disconnecting slave 
20140918-055308-3142697795-38947-18196-0
I0918 05:53:10.562950 18222 master.cpp:3669] Authenticating 
slave(195)@67.195.81.187:38947
I0918 05:53:10.563029 18222 hierarchical_allocator_process.hpp:481] Slave 
20140918-055308-3142697795-38947-18196-0 deactivated
I0918 05:53:10.563060 18222 authenticator.hpp:156] Creating new server SASL 
connection
I0918 05:53:10.563119 18222 authenticatee.hpp:219] Received SASL authentication 
mechanisms: CRAM-MD5
I0918 05:53:10.563138 18222 authenticatee.hpp:245] Attempting to authenticate 
with mechanism 'CRAM-MD5'
I0918 05:53:10.563166 18222 authenticator.hpp:262] Received SASL authentication 
start
I0918 05:53:10.563215 18222 authenticator.hpp:384] Authentication requires more 
steps
I0918 05:53:10.563247 18222 authenticatee.hpp:265] Received SASL authentication 
step
I0918 05:53:10.563287 18222 authenticator.hpp:290] Received SASL authentication 
step
I0918 05:53:10.563305 18222 auxprop.cpp:81] Request to lookup properties for 
user: 'test-principal' realm: 'pomona.apache.org' server FQDN: 
'pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false 
SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: false 
I0918 05:53:10.563316 18222 auxprop.cpp:153] Looking up auxiliary property 
'*userPassword'
I0918 05:53:10.563330 18222 auxprop.cpp:153] Looking up auxiliary property 
'*cmusaslsecretCRAM-MD5'
I0918 05:53:10.563343 18222 auxprop.cpp:81] Request to lookup properties for 
user: 'test-principal' realm: 'pomona.apache.org' server FQDN: 
'pomona.apache.org' SASL_AUXPROP_VERIFY_AGAINST_HASH: false 
SASL_AUXPROP_OVERRIDE: false SASL_AUXPROP_AUTHZID: true 
I0918 05:53:10.563351 18222 auxprop.cpp:103] Skipping auxiliary property 
'*userPassword' since SASL_AUXPROP_AUTHZID == true
I0918 05:53:10.563360 18222 auxprop.cpp:103] Skipping auxiliary property 
'*cmusaslsecretCRAM-MD5' since SASL_AUXPROP_AUTHZID == true
I0918 05:53:10.563375 18222 authenticator.hpp:376] Authentication success
I0918 05:53:10.563407 18222 authenticatee.hpp:305] Authentication success
I0918 05:53:10.563432 18222 master.cpp:3709] Successfully authenticated 
principal 'test-principal' at slave(195)@67.195.81.187:38947
I0918 05:53:10.563504 18222 slave.cpp:731] Successfully authenticated with 
master master@67.195.81.187:38947
I0918 05:53:10.563555 18222 slave.cpp:994] Will retry registration in 2.84152ms 
if necessary
W0918 05:53:10.563612 18222 master.cpp:2985] Slave at 
slave(195)@67.195.81.187:38947 (pomona.apache.org) is being allowed to 
re-register with an already in use id (20140918-055308-3142697795-38947-18196-0)
I0918 05:53:10.763890 18222 slave.cpp:827] Re-registered with master 
master@67.195.81.187:38947
I0918 05:53:10.763936 18222 hierarchical_allocator_process.hpp:495] Slave 
20140918-055308-3142697795-38947-18196-0 reactivated
I0918 05:53:10.783864 18196 master.cpp:650] Master terminating
I0918 05:53:10.784272 18233 slave.cpp:2379] master@67.195.81.187:38947 exited
W0918 05:53:10.784304 18233 slave.cpp:2382] Master disconnected! Waiting for a 
new master to be elected
I0918 05:53:10.847774 18245 slave.cpp:477] Slave terminating
[   OK ] SlaveTest.PingTimeoutSomePings (2776 ms)
[ RUN  ] SlaveTest.TerminalTaskContainerizerUp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2111

[Apache Jenkins Server]

See 


Changes:

[yan] MESOS-1392: MasterDetector now returns a None when it cannot read the 
content of the ZNode it has detected.

--
[...truncated 64967 lines...]
I0918 05:56:14.204608 19712 leveldb.cpp:306] Persisting metadata (8 bytes) to 
leveldb took 322127ns
I0918 05:56:14.204628 19712 replica.cpp:342] Persisted promised to 1
I0918 05:56:14.204691 19717 leveldb.cpp:306] Persisting metadata (8 bytes) to 
leveldb took 537458ns
I0918 05:56:14.204704 19717 replica.cpp:342] Persisted promised to 1
I0918 05:56:14.204926 19715 coordinator.cpp:230] Coordinator attemping to fill 
missing position
I0918 05:56:14.205322 19722 replica.cpp:375] Replica received explicit promise 
request for position 0 with proposal 2
I0918 05:56:14.205431 19717 replica.cpp:375] Replica received explicit promise 
request for position 0 with proposal 2
I0918 05:56:14.205840 19717 leveldb.cpp:343] Persisting action (8 bytes) to 
leveldb took 390826ns
I0918 05:56:14.205860 19717 replica.cpp:676] Persisted action at 0
I0918 05:56:14.216131 19722 leveldb.cpp:343] Persisting action (8 bytes) to 
leveldb took 10.786813ms
I0918 05:56:14.216158 19722 replica.cpp:676] Persisted action at 0
I0918 05:56:14.216439 19716 replica.cpp:508] Replica received write request for 
position 0
I0918 05:56:14.216450 19713 replica.cpp:508] Replica received write request for 
position 0
I0918 05:56:14.216466 19716 leveldb.cpp:438] Reading position from leveldb took 
11180ns
I0918 05:56:14.216470 19713 leveldb.cpp:438] Reading position from leveldb took 
7585ns
I0918 05:56:14.216771 19716 leveldb.cpp:343] Persisting action (14 bytes) to 
leveldb took 277780ns
I0918 05:56:14.216789 19716 replica.cpp:676] Persisted action at 0
I0918 05:56:14.216935 19713 leveldb.cpp:343] Persisting action (14 bytes) to 
leveldb took 336723ns
I0918 05:56:14.216951 19713 replica.cpp:676] Persisted action at 0
I0918 05:56:14.217063 19713 replica.cpp:655] Replica received learned notice 
for position 0
I0918 05:56:14.217125 19725 replica.cpp:655] Replica received learned notice 
for position 0
I0918 05:56:14.217241 19713 leveldb.cpp:343] Persisting action (16 bytes) to 
leveldb took 150140ns
I0918 05:56:14.217248 19725 leveldb.cpp:343] Persisting action (16 bytes) to 
leveldb took 106863ns
I0918 05:56:14.217258 19713 replica.cpp:676] Persisted action at 0
I0918 05:56:14.217262 19725 replica.cpp:676] Persisted action at 0
I0918 05:56:14.217272 19725 replica.cpp:661] Replica learned NOP action at 
position 0
I0918 05:56:14.217272 19713 replica.cpp:661] Replica learned NOP action at 
position 0
I0918 05:56:14.217386 19725 log.cpp:672] Writer started with ending position 0
I0918 05:56:14.217566 19725 leveldb.cpp:438] Reading position from leveldb took 
9371ns
I0918 05:56:14.218955 19725 registrar.cpp:346] Successfully fetched the 
registry (0B)
I0918 05:56:14.218977 19725 registrar.cpp:422] Attempting to update the 
'registry'
I0918 05:56:14.220368 19725 log.cpp:680] Attempting to append 144 bytes to the 
log
I0918 05:56:14.220402 19725 coordinator.cpp:340] Coordinator attempting to 
write APPEND action at position 1
I0918 05:56:14.220895 19712 replica.cpp:508] Replica received write request for 
position 1
I0918 05:56:14.221308 19710 replica.cpp:508] Replica received write request for 
position 1
I0918 05:56:14.221565 19710 leveldb.cpp:343] Persisting action (163 bytes) to 
leveldb took 237637ns
I0918 05:56:14.221585 19710 replica.cpp:676] Persisted action at 1
I0918 05:56:14.221642 19712 leveldb.cpp:343] Persisting action (163 bytes) to 
leveldb took 725907ns
I0918 05:56:14.221660 19712 replica.cpp:676] Persisted action at 1
I0918 05:56:14.221876 19719 replica.cpp:655] Replica received learned notice 
for position 1
I0918 05:56:14.221978 19723 replica.cpp:655] Replica received learned notice 
for position 1
I0918 05:56:14.222036 19719 leveldb.cpp:343] Persisting action (165 bytes) to 
leveldb took 142878ns
I0918 05:56:14.222064 19719 replica.cpp:676] Persisted action at 1
I0918 05:56:14.222074 19719 replica.cpp:661] Replica learned APPEND action at 
position 1
I0918 05:56:14.222110 19723 leveldb.cpp:343] Persisting action (165 bytes) to 
leveldb took 115133ns
I0918 05:56:14.222122 19723 replica.cpp:676] Persisted action at 1
I0918 05:56:14.222131 19723 replica.cpp:661] Replica learned APPEND action at 
position 1
I0918 05:56:14.222337 19723 registrar.cpp:479] Successfully updated 'registry'
I0918 05:56:14.222364 19723 registrar.cpp:372] Successfully recovered registrar
I0918 05:56:14.222383 19723 log.cpp:699] Attempting to truncate the log to 1
I0918 05:56:14.222420 19723 coordinator.cpp:340] Coordinator attempting to 
write TRUNCATE action at position 2
I0918 05:56:14.222604 19723 replica.cpp:508] Replica received write request for 
position 2
I0918 05:56:14.222671 19719 replica.cpp:508] Replica received write request for 
position 2
I0918 05:56:14.222

Re: Review Request 25758: Modify docker pull to call inspect after pull

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25758/
---

(Updated Sept. 18, 2014, 6:04 a.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1809
https://issues.apache.org/jira/browse/MESOS-1809


Repository: mesos-git


Description
---

Review: https://reviews.apache.org/r/25758


Diffs
-

  src/docker/docker.hpp 443db49318a5923b987c06cda8060ccfb3301a2f 
  src/docker/docker.cpp 6063114e700d13b1cd5d59cff356518021eb3286 
  src/tests/docker_containerizer_tests.cpp 
1981f49d228903ccaa094a9747dec49054c1e0f2 

Diff: https://reviews.apache.org/r/25758/diff/


Testing
---

make check


Thanks,

Timothy Chen