Re: Review Request 27122: Reorganized authentication implementation locations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27122/ --- (Updated Oct. 25, 2014, 1:21 p.m.) Review request for mesos, Adam B and Vinod Kone. Changes --- Namespace updates. Bugs: MESOS-1893 https://issues.apache.org/jira/browse/MESOS-1893 Repository: mesos-git Description (updated) --- For paving the way into further authentication mechanism implementations, the existing is reorganized. Move src/sasl to src/authentication/cram_md5, rename src/tests/sasl_tests.cpp to src/tests/crammd5_authentication_tests.cpp. Adapt depending include paths. Rename specific test implementations from SASL to CRAMMD5Authentication. Rename sasl namespace to cram_md5 throughout all uses. Diffs (updated) - src/Makefile.am 2617f77 src/authentication/cram_md5/authenticatee.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/authentication/cram_md5/auxprop.hpp PRE-CREATION src/authentication/cram_md5/auxprop.cpp PRE-CREATION src/master/master.hpp b1a2cd0 src/master/master.cpp 95589b8 src/sasl/authenticatee.hpp ec2c841 src/sasl/authenticator.hpp 6f4d3db src/sasl/auxprop.hpp 44e201b src/sasl/auxprop.cpp 6de1222 src/sched/sched.cpp e89e5e5 src/scheduler/scheduler.cpp fb88a3e src/slave/slave.hpp eb5de73 src/slave/slave.cpp 55e5264 src/tests/crammd5_authentication_tests.cpp PRE-CREATION src/tests/sasl_tests.cpp 30556fa Diff: https://reviews.apache.org/r/27122/diff/ Testing --- make check Thanks, Till Toenshoff
Re: Review Request 27111: Block IO Isolator: usage metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 25, 2014, 5:48 p.m.) Review request for mesos, Benjamin Hindman and Ian Downes. Changes --- Re-organize blkio stats. Make blkio unit test setup async-signal-safe. Bugs: MESOS-1977 https://issues.apache.org/jira/browse/MESOS-1977 Repository: mesos-git Description --- Implement a block io isolator that just publishes read / write, bytes / operations per second. A split of r25922 as suggested by Ian. Diffs (updated) - include/mesos/mesos.proto 6b93e90 src/Makefile.am 2617f77 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 62df4b7 src/linux/fs.hpp ac8b5f4 src/linux/fs.cpp b01d14c src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 9d08329 src/tests/isolator_tests.cpp 52b38a3 Diff: https://reviews.apache.org/r/27111/diff/ Testing --- make check sudo ./mesos-tests --gtest_filter=BlkIOIsolatorTest* Thanks, Joris Van Remoortere
Re: Review Request 27111: Block IO Isolator: usage metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 25, 2014, 5:53 p.m.) Review request for mesos, Benjamin Hindman and Ian Downes. Changes --- Add async-signal-safe comments. Fix cosmetics. Bugs: MESOS-1977 https://issues.apache.org/jira/browse/MESOS-1977 Repository: mesos-git Description --- Implement a block io isolator that just publishes read / write, bytes / operations per second. A split of r25922 as suggested by Ian. Diffs (updated) - include/mesos/mesos.proto 6b93e90 src/Makefile.am 2617f77 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 62df4b7 src/linux/fs.hpp ac8b5f4 src/linux/fs.cpp b01d14c src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 9d08329 src/tests/isolator_tests.cpp 52b38a3 Diff: https://reviews.apache.org/r/27111/diff/ Testing --- make check sudo ./mesos-tests --gtest_filter=BlkIOIsolatorTest* Thanks, Joris Van Remoortere
Re: Review Request 27111: Block IO Isolator: usage metrics
On Oct. 25, 2014, 1:02 a.m., Ian Downes wrote: src/slave/containerizer/isolators/cgroups/blkio.cpp, line 252 https://reviews.apache.org/r/27111/diff/2/?file=731349#file731349line252 What's the difference between blkio.throttle.io_service_bytes and blkio.io_service_bytes? From my experimentation: blkio.io_service_bytes does not actually report the bytes read/written, whereas blkio.throttle.io_service_bytes does. - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58418 --- On Oct. 25, 2014, 5:53 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 25, 2014, 5:53 p.m.) Review request for mesos, Benjamin Hindman and Ian Downes. Bugs: MESOS-1977 https://issues.apache.org/jira/browse/MESOS-1977 Repository: mesos-git Description --- Implement a block io isolator that just publishes read / write, bytes / operations per second. A split of r25922 as suggested by Ian. Diffs - include/mesos/mesos.proto 6b93e90 src/Makefile.am 2617f77 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 62df4b7 src/linux/fs.hpp ac8b5f4 src/linux/fs.cpp b01d14c src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 9d08329 src/tests/isolator_tests.cpp 52b38a3 Diff: https://reviews.apache.org/r/27111/diff/ Testing --- make check sudo ./mesos-tests --gtest_filter=BlkIOIsolatorTest* Thanks, Joris Van Remoortere
Re: Review Request 27111: Block IO Isolator: usage metrics
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/#review58524 --- Patch looks great! Reviews applied: [27111] All tests passed. - Mesos ReviewBot On Oct. 25, 2014, 5:53 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27111/ --- (Updated Oct. 25, 2014, 5:53 p.m.) Review request for mesos, Benjamin Hindman and Ian Downes. Bugs: MESOS-1977 https://issues.apache.org/jira/browse/MESOS-1977 Repository: mesos-git Description --- Implement a block io isolator that just publishes read / write, bytes / operations per second. A split of r25922 as suggested by Ian. Diffs - include/mesos/mesos.proto 6b93e90 src/Makefile.am 2617f77 src/linux/cgroups.hpp abf31df src/linux/cgroups.cpp 62df4b7 src/linux/fs.hpp ac8b5f4 src/linux/fs.cpp b01d14c src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 9d08329 src/tests/isolator_tests.cpp 52b38a3 Diff: https://reviews.apache.org/r/27111/diff/ Testing --- make check sudo ./mesos-tests --gtest_filter=BlkIOIsolatorTest* Thanks, Joris Van Remoortere
Review Request 27199: Introduced a FutureResult action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27199/ --- Review request for mesos and Timothy Chen. Repository: mesos-git Description --- The FutureResult action enables capturing the result from an inner action, e.g., an Invoke* action. Diffs - 3rdparty/libprocess/include/process/gmock.hpp 6330ea658df72ea63cf4a22e47225bb7ee700132 Diff: https://reviews.apache.org/r/27199/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26857: Added CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26857/ --- (Updated Oct. 25, 2014, 8:12 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- rebased. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description (updated) --- Introducing the CRAM-MD5 SASL authenticator module based on the former sasl/authenticator. The former sasl/authenticator.hpp still remains as part of libmesos but now is located at authentication/cram_md5. Diffs (updated) - src/Makefile.am 2617f77 src/authentication/authenticator.hpp PRE-CREATION src/authentication/cram_md5/authenticator.hpp PRE-CREATION src/examples/test_authenticator_module.cpp PRE-CREATION src/module/manager.cpp 1613e39 Diff: https://reviews.apache.org/r/26857/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 25, 2014, 8:22 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- rebased and fixed all towards in master.cpp/.hpp Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description (updated) --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs (updated) - src/master/flags.hpp 9d06856 src/master/master.hpp b1a2cd0 src/master/master.cpp 95589b8 src/module/authenticator.hpp PRE-CREATION src/tests/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26859: Integrated CRAM-MD5 Authenticator module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26859/ --- (Updated Oct. 25, 2014, 8:28 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- namespace glitch fixed. Bugs: MESOS-1889 https://issues.apache.org/jira/browse/MESOS-1889 Repository: mesos-git Description --- Enables selecting a module based authenticator via the new --authenticators flag for mesos master. Additionally, all have been fixed towards in master.hpp and master.cpp. Diffs (updated) - src/master/flags.hpp 9d06856 src/master/master.hpp b1a2cd0 src/master/master.cpp 95589b8 src/module/authenticator.hpp PRE-CREATION src/tests/crammd5_authentication_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/26859/diff/ Testing --- make check NOTE all three CRAM-MD5 authenticator module related RRs need to get applied before running make check. Thanks, Till Toenshoff
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 25, 2014, 8:35 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
---
rebased and added comment in flags.hpp.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.so\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]}
Diffs (updated)
-
src/tests/flags.hpp 80f0cee
src/tests/mesos.cpp bff10d2
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.dylib\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_authenticator_crammd5' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 27199: Introduced a FutureResult action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27199/#review58529 --- Patch looks great! Reviews applied: [27199] All tests passed. - Mesos ReviewBot On Oct. 25, 2014, 8:05 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27199/ --- (Updated Oct. 25, 2014, 8:05 p.m.) Review request for mesos and Timothy Chen. Repository: mesos-git Description --- The FutureResult action enables capturing the result from an inner action, e.g., an Invoke* action. Diffs - 3rdparty/libprocess/include/process/gmock.hpp 6330ea658df72ea63cf4a22e47225bb7ee700132 Diff: https://reviews.apache.org/r/27199/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26860: Integrated CRAM-MD5 Authenticator module into tests.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/#review58530
---
Bad patch!
Reviews applied: [27122, 26727, 26796, 26797, 27051, 26727, 26796, 26797]
Failed command: ./support/apply-review.sh -n -r 26797
Error:
2014-10-25 21:17:09 URL:https://reviews.apache.org/r/26797/diff/raw/
[2092/2092] - 26797.patch [1]
error: patch failed: src/tests/flags.hpp:75
error: src/tests/flags.hpp: patch does not apply
error: patch failed: src/tests/mesos.cpp:170
error: src/tests/mesos.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Oct. 25, 2014, 8:35 p.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26860/
---
(Updated Oct. 25, 2014, 8:35 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1889
https://issues.apache.org/jira/browse/MESOS-1889
Repository: mesos-git
Description
---
The CRAM-MD5 authenticator module is now usable via mesos-tests.sh
Example usage:
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.so\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]}
Diffs
-
src/tests/flags.hpp 80f0cee
src/tests/mesos.cpp bff10d2
Diff: https://reviews.apache.org/r/26860/diff/
Testing
---
make check
bin/mesos-tests.sh --authenticators=org_apache_mesos_authenticator_crammd5
--modules={\libraries\: [{\file\:
\src/.libs/libauthentication_crammd5.dylib\,\modules\: [{\name\:
\org_apache_mesos_authenticator_crammd5\}]}]} --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:16:14.764703 298631168 master.cpp:3874] Using
'org_apache_mesos_authenticator_crammd5' authenticator
bin/mesos-tests.sh --verbose
--gtest_filter=AuthenticationTest.AuthenticatedSlave
Shows:
I1024 06:21:39.526159 275554304 master.cpp:3865] Using default CRAM-MD5
authenticator
Thanks,
Till Toenshoff
Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/ --- (Updated Oct. 25, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- See summary. Note that this hard codes the location of the subversion and Apache Portable Runtime (APR) headers. Diffs (updated) - 3rdparty/libprocess/3rdparty/Makefile.am 1e24886628d07a788385e5056f05869b373d970a 3rdparty/libprocess/3rdparty/stout/Makefile.am 41360620ee28bd2fca50f4b57ebe5803b10437cf 3rdparty/libprocess/3rdparty/stout/include/Makefile.am d5290130a5864aa38dc6aadb0d9664efb1424488 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/24535/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24535: Added functionality to create SVN based diffs of arbitrary strings.
On Oct. 15, 2014, 12:22 a.m., Ben Mahler wrote: Looks good modulo some issues below, would like to take a final pass when you update the APR() abstraction to be thread safe. Ben Mahler wrote: Hm.. have you looked at whether the other calls here are thread safe? For example, svn_pool_create(). Yes, according to http://goo.gl/NX0hps, apr_pool_create_ex is thread safe, which is what svn_pool_create calls (through svn_pool_create_ex). I added a comment and pointed to this documentation. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/#review56597 --- On Oct. 25, 2014, 11:18 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24535/ --- (Updated Oct. 25, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- See summary. Note that this hard codes the location of the subversion and Apache Portable Runtime (APR) headers. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 1e24886628d07a788385e5056f05869b373d970a 3rdparty/libprocess/3rdparty/stout/Makefile.am 41360620ee28bd2fca50f4b57ebe5803b10437cf 3rdparty/libprocess/3rdparty/stout/include/Makefile.am d5290130a5864aa38dc6aadb0d9664efb1424488 3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/24535/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.
On Oct. 18, 2014, 9:42 p.m., Ben Mahler wrote: src/state/log.cpp, lines 370-373 https://reviews.apache.org/r/24536/diff/5/?file=725137#file725137line370 This comment looks like a leftover from the bug in the last diff? We won't find a minimum now, only when there are no shapshots. This is still a very valid TODO, we'll just always have a minimum, so I updated the first sentence. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/#review57282 --- On Oct. 25, 2014, 11:18 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/ --- (Updated Oct. 25, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- See summary. Note that this hard codes the location of the subversion and Apache Portable Runtime (APR) headers. Diffs - src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad src/state/log.hpp 6bd054fcd1cf79a2ad1a59da59c9a903cb25882f src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a src/tests/state_tests.cpp 0948b9fb7d1c378f8c90abc85b34773a6963d91f Diff: https://reviews.apache.org/r/24536/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24536: Added DIFF to the replicated log state storage implementation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24536/ --- (Updated Oct. 25, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- See summary. Note that this hard codes the location of the subversion and Apache Portable Runtime (APR) headers. Diffs (updated) - src/Makefile.am 2617f77b757cb7414889520c88b1bc203dedef09 src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION src/messages/state.proto 59276e55fcbebdb754c20d39b13b402fd11c3dad src/state/log.hpp 6bd054fcd1cf79a2ad1a59da59c9a903cb25882f src/state/log.cpp fd8b28a0b5d14f5ba3e6fde4695f6d09acf9c56a src/tests/state_tests.cpp 0948b9fb7d1c378f8c90abc85b34773a6963d91f Diff: https://reviews.apache.org/r/24536/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
On Oct. 13, 2014, 4:25 p.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 271 https://reviews.apache.org/r/26634/diff/1/?file=719342#file719342line271 this should return an Error to indicate out of bounds access attempt. I choose to return None instead. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review56405 --- On Oct. 25, 2014, 11:40 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- (Updated Oct. 25, 2014, 11:40 p.m.) Review request for mesos, Alexander Rukletsov and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5 Diff: https://reviews.apache.org/r/26634/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- (Updated Oct. 25, 2014, 11:41 p.m.) Review request for mesos, Alexander Rukletsov and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5 Diff: https://reviews.apache.org/r/26634/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- (Updated Oct. 25, 2014, 11:40 p.m.) Review request for mesos, Alexander Rukletsov and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5 Diff: https://reviews.apache.org/r/26634/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
On Oct. 13, 2014, 5:23 a.m., Timothy Chen wrote: 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 232 https://reviews.apache.org/r/26634/diff/1/?file=719343#file719343line232 Also what happens if you access out of bounds? See a few lines down! ;-) - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review56377 --- On Oct. 25, 2014, 11:40 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- (Updated Oct. 25, 2014, 11:40 p.m.) Review request for mesos, Alexander Rukletsov and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5 Diff: https://reviews.apache.org/r/26634/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
On Oct. 14, 2014, 1:50 p.m., Alexander Rukletsov wrote: It looks to me that adding this functionality imposes a restriction on key names in JSON. We won't be able to do something like this: object.values[name_[en]_full] = Name; auto result = object.findJSON::String(name_[en]_full); I don't think it is a big deal or we would need it, but maybe let's make this restriction explicit by introducing a vaidation function. You use the dot notation to look up fields (e.g., name_.en._full), and the array subscript to look up elements in an array. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review56504 --- On Oct. 25, 2014, 11:40 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- (Updated Oct. 25, 2014, 11:40 p.m.) Review request for mesos, Alexander Rukletsov and Ben Mahler. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5 Diff: https://reviews.apache.org/r/26634/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 24341: Added Java replicated log implementation of State.
On Oct. 15, 2014, 6:01 p.m., Ben Mahler wrote: src/Makefile.am, line 878 https://reviews.apache.org/r/24341/diff/3/?file=719229#file719229line878 Where is this file? That file gets generated at compile time! Note the rest of the header files are also not in the repository. ;-) - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/#review56625 --- On Oct. 12, 2014, 4:14 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24341/ --- (Updated Oct. 12, 2014, 4:14 a.m.) Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Description --- See summary. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/java/jni/org_apache_mesos_state_LogState.cpp PRE-CREATION src/java/src/org/apache/mesos/state/LogState.java PRE-CREATION Diff: https://reviews.apache.org/r/24341/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26634: Implemented array subscript lookup in JSON::Object::find.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/#review58537 --- Ship it! Ship It! - Timothy Chen On Oct. 25, 2014, 11:41 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26634/ --- (Updated Oct. 25, 2014, 11:41 p.m.) Review request for mesos, Alexander Rukletsov and Timothy Chen. Repository: mesos-git Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 2e1f78e509b4270bdf33c50f5bca59bca4cb1bc4 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 3bfc8e639185323a3809ca82c09428b3b1b8afe5 Diff: https://reviews.apache.org/r/26634/diff/ Testing --- make check Thanks, Benjamin Hindman
Re: Review Request 26896: Add privileged option to docker info
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26896/#review58538 --- Ship it! Ship It! - Benjamin Hindman On Oct. 17, 2014, 10:52 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26896/ --- (Updated Oct. 17, 2014, 10:52 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add privileged option to docker info Diffs - include/mesos/mesos.proto 6b93e90 src/docker/docker.cpp e09b51c Diff: https://reviews.apache.org/r/26896/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26898: Add hostname option to docker info
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/#review58539 --- include/mesos/mesos.proto https://reviews.apache.org/r/26898/#comment99604 Shouldn't this be a generic ContainerInfo field? - Benjamin Hindman On Oct. 17, 2014, 10:57 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26898/ --- (Updated Oct. 17, 2014, 10:57 p.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add hostname option to docker info Diffs - include/mesos/mesos.proto 6b93e90 src/docker/docker.cpp e09b51c Diff: https://reviews.apache.org/r/26898/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 26517: Symlink sandbox directories in docker containerizer
On Oct. 20, 2014, 4:14 a.m., Benjamin Hindman wrote: src/slave/containerizer/docker.hpp, line 36 https://reviews.apache.org/r/26517/diff/3/?file=724991#file724991line36 Are all directories symlinked? Timothy Chen wrote: Only the ones that has colon in the path. Can we explain as much in the comment please? ;-) I should have been more explicit in my previous comment, sorry. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/#review57307 --- On Oct. 22, 2014, 1:12 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26517/ --- (Updated Oct. 22, 2014, 1:12 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-1833 https://issues.apache.org/jira/browse/MESOS-1833 Repository: mesos-git Description --- Review: https://reviews.apache.org/r/26517 Diffs - src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 Diff: https://reviews.apache.org/r/26517/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 25250: Mark running tasks killed during framework shutdown.
On Oct. 22, 2014, 9:19 a.m., Adam B wrote: I took care of these for Alex since he was blocked on my JSON::Object.find updates. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review57771 --- On Oct. 10, 2014, 2:15 p.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Oct. 10, 2014, 2:15 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Till Toenshoff. Bugs: MESOS-1736 https://issues.apache.org/jira/browse/MESOS-1736 Repository: mesos-git Description --- When a framework is shut down e.g. by calling driver.stop() from the scheduler, running tasks are marked KILLED before migrating them to completed. Diffs - src/master/master.cpp cb46cec src/tests/master_tests.cpp d9dc40c Diff: https://reviews.apache.org/r/25250/diff/ Testing --- make check (OS X, Ubuntu 14.04) Thanks, Alexander Rukletsov
Re: Review Request 26862: Fix docker flaky tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/#review58545 --- src/slave/containerizer/docker.cpp https://reviews.apache.org/r/26862/#comment99607 If we're going to take ownership than we need to make that explicit in the constructor please! Also, why a 'const Docker'? src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/26862/#comment99608 Can you please redirect people to the explanation in src/tests/containerizer.cpp which explains why we set up defaults with EXPECT_CALL/WillRepeatedly instead of ON_CALL/WillByDefault. As an example, see MockGarbageCollector() in src/tests/mesos.hpp. Also, did you copy this code from someplace that doesn't have a comment? Because it would be great to get that everywhere so people don't end up making that change (like I once did) only to have to undo it because of gmock annoyances. src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/26862/#comment99609 Hmm, I feel like I ask this question everytime, but can we not just s/MockDocker::_logs/Docker::logs/ here and it does the right thing? src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/26862/#comment99613 This doesn't look like it was used by any call sites. src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/26862/#comment99610 s/ // src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/26862/#comment99611 Shouldn't this just be an automatic upcast so the explicit cast isn't necessary? src/tests/docker_containerizer_tests.cpp https://reviews.apache.org/r/26862/#comment99612 I don't understand, isn't the point of this test to show that the container was at least stopped (since now we're not removing them until after the delay)? The same for the other tests where this was removed too? - Benjamin Hindman On Oct. 22, 2014, 12:46 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26862/ --- (Updated Oct. 22, 2014, 12:46 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Docker tests are flaky, mostly around getting expected output from the docker container forwarded to stdout/stderr. This is due to Docker not always have the stdout/stderr output available for docker logs if kill/rm is called. Diffs - src/docker/docker.hpp 9656f15 src/docker/docker.cpp e09b51c src/slave/containerizer/docker.hpp fbbd45d src/slave/containerizer/docker.cpp 9a29489 src/tests/docker_containerizer_tests.cpp 67d60a8 src/tests/docker_tests.cpp 04139af src/tests/environment.cpp 4dd78e7 Diff: https://reviews.apache.org/r/26862/diff/ Testing --- make with gtest_repeat=-1 gtest_shuffle=1 Thanks, Timothy Chen
Re: Review Request 27199: Introduced a FutureResult action.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27199/#review58546 --- Ship it! Ship It! - Timothy Chen On Oct. 25, 2014, 8:05 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27199/ --- (Updated Oct. 25, 2014, 8:05 p.m.) Review request for mesos and Timothy Chen. Repository: mesos-git Description --- The FutureResult action enables capturing the result from an inner action, e.g., an Invoke* action. Diffs - 3rdparty/libprocess/include/process/gmock.hpp 6330ea658df72ea63cf4a22e47225bb7ee700132 Diff: https://reviews.apache.org/r/27199/diff/ Testing --- make check Thanks, Benjamin Hindman
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2209
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2209/changes Changes: [benjamin.hindman] Implemented array subscript lookup in JSON::Object::find. [benjamin.hindman] Fixes necessary due to JSON::Array::values change to std::vector. [benjamin.hindman] Mark running tasks killed during framework shutdown. -- [...truncated 44477 lines...] I1026 02:25:49.223804 32339 hierarchical_allocator_process.hpp:734] Offering mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2 on slave 20141026-015844-3193029443-56864-32300-S2 to framework 20141026-015844-3193029443-56864-32300- I1026 02:25:49.224258 32339 hierarchical_allocator_process.hpp:816] Filtered mem(*):9984; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-015844-3193029443-56864-32300-S1 for framework 20141026-015844-3193029443-56864-32300- I1026 02:25:49.224474 32339 hierarchical_allocator_process.hpp:734] Offering cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-015844-3193029443-56864-32300-S0 to framework 20141026-015844-3193029443-56864-32300- I1026 02:25:49.224863 32339 hierarchical_allocator_process.hpp:659] Performed allocation for 3 slaves in 1.346526ms I1026 02:25:49.225396 32325 master.cpp:3795] Sending 2 offers to framework 20141026-015844-3193029443-56864-32300- (Test Framework (C++)) at scheduler-3434505d-12e3-4f60-8daa-5e5b74d46dbb@67.195.81.190:56864 Received offer 20141026-015844-3193029443-56864-32300-O972 with cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] Received offer 20141026-015844-3193029443-56864-32300-O973 with mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2 I1026 02:25:49.225918 32325 sched.cpp:544] Scheduler::resourceOffers took 130030ns I1026 02:25:49.226402 32325 master.cpp:2321] Processing reply for offers: [ 20141026-015844-3193029443-56864-32300-O972 ] on slave 20141026-015844-3193029443-56864-32300-S0 at slave(1)@67.195.81.190:56864 (pietas.apache.org) for framework 20141026-015844-3193029443-56864-32300- (Test Framework (C++)) at scheduler-3434505d-12e3-4f60-8daa-5e5b74d46dbb@67.195.81.190:56864 I1026 02:25:49.226913 32325 master.cpp:2321] Processing reply for offers: [ 20141026-015844-3193029443-56864-32300-O973 ] on slave 20141026-015844-3193029443-56864-32300-S2 at slave(3)@67.195.81.190:56864 (pietas.apache.org) for framework 20141026-015844-3193029443-56864-32300- (Test Framework (C++)) at scheduler-3434505d-12e3-4f60-8daa-5e5b74d46dbb@67.195.81.190:56864 I1026 02:25:49.227473 32339 hierarchical_allocator_process.hpp:563] Recovered cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] (total allocatable: cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]) on slave 20141026-015844-3193029443-56864-32300-S0 from framework 20141026-015844-3193029443-56864-32300- I1026 02:25:49.227524 32339 hierarchical_allocator_process.hpp:599] Framework 20141026-015844-3193029443-56864-32300- filtered slave 20141026-015844-3193029443-56864-32300-S0 for 5secs I1026 02:25:49.227761 32339 hierarchical_allocator_process.hpp:563] Recovered mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2 (total allocatable: mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2) on slave 20141026-015844-3193029443-56864-32300-S2 from framework 20141026-015844-3193029443-56864-32300- I1026 02:25:49.227808 32339 hierarchical_allocator_process.hpp:599] Framework 20141026-015844-3193029443-56864-32300- filtered slave 20141026-015844-3193029443-56864-32300-S2 for 5secs I1026 02:25:49.399585 32330 monitor.cpp:140] Failed to collect resource usage for container '43672299-fb4e-45d7-a27a-2addab6dcff0' for executor 'default' of framework '20141026-015844-3193029443-56864-32300-': Unknown container: 43672299-fb4e-45d7-a27a-2addab6dcff0 I1026 02:25:49.399737 32330 monitor.cpp:140] Failed to collect resource usage for container 'b48131e9-07c2-490c-8100-e569c93837fe' for executor 'default' of framework '20141026-015844-3193029443-56864-32300-': Unknown container: b48131e9-07c2-490c-8100-e569c93837fe I1026 02:25:49.629504 32336 master.cpp:120] No whitelist given. Advertising offers for all slaves I1026 02:25:50.225728 32340 hierarchical_allocator_process.hpp:816] Filtered mem(*):9984; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-015844-3193029443-56864-32300-S1 for framework 20141026-015844-3193029443-56864-32300- I1026 02:25:50.226048 32340 hierarchical_allocator_process.hpp:816] Filtered cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-015844-3193029443-56864-32300-S0 for framework 20141026-015844-3193029443-56864-32300- I1026 02:25:50.226338 32340 hierarchical_allocator_process.hpp:816] Filtered mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000];
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2487
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2487/changes Changes: [benjamin.hindman] Introduced a FutureResult action. -- [...truncated 31020 lines...] I1026 03:29:35.996134 9107 hierarchical_allocator_process.hpp:563] Recovered cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] (total allocatable: cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]) on slave 20141026-030030-3142697795-38676-9075-S2 from framework 20141026-030030-3142697795-38676-9075- I1026 03:29:35.996181 9107 hierarchical_allocator_process.hpp:599] Framework 20141026-030030-3142697795-38676-9075- filtered slave 20141026-030030-3142697795-38676-9075-S2 for 5secs I1026 03:29:36.001066 9103 monitor.cpp:140] Failed to collect resource usage for container 'b51d53cf-1654-4f82-bd2c-9e8884702378' for executor 'default' of framework '20141026-030030-3142697795-38676-9075-': Unknown container: b51d53cf-1654-4f82-bd2c-9e8884702378 I1026 03:29:36.001900 9099 monitor.cpp:140] Failed to collect resource usage for container 'c89d7949-b121-4ec4-a935-f0848128cd4f' for executor 'default' of framework '20141026-030030-3142697795-38676-9075-': Unknown container: c89d7949-b121-4ec4-a935-f0848128cd4f I1026 03:29:36.096349 9101 master.cpp:120] No whitelist given. Advertising offers for all slaves I1026 03:29:36.994582 9111 hierarchical_allocator_process.hpp:816] Filtered mem(*):10112; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):1 on slave 20141026-030030-3142697795-38676-9075-S1 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:36.994772 9111 hierarchical_allocator_process.hpp:816] Filtered cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-030030-3142697795-38676-9075-S2 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:36.994926 9111 hierarchical_allocator_process.hpp:816] Filtered mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2 on slave 20141026-030030-3142697795-38676-9075-S0 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:36.994982 9111 hierarchical_allocator_process.hpp:659] Performed allocation for 3 slaves in 897793ns I1026 03:29:37.001737 9102 monitor.cpp:140] Failed to collect resource usage for container 'b51d53cf-1654-4f82-bd2c-9e8884702378' for executor 'default' of framework '20141026-030030-3142697795-38676-9075-': Unknown container: b51d53cf-1654-4f82-bd2c-9e8884702378 I1026 03:29:37.002626 9099 monitor.cpp:140] Failed to collect resource usage for container 'c89d7949-b121-4ec4-a935-f0848128cd4f' for executor 'default' of framework '20141026-030030-3142697795-38676-9075-': Unknown container: c89d7949-b121-4ec4-a935-f0848128cd4f I1026 03:29:37.996212 9099 hierarchical_allocator_process.hpp:816] Filtered cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-030030-3142697795-38676-9075-S2 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:37.996426 9099 hierarchical_allocator_process.hpp:816] Filtered mem(*):10112; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):1 on slave 20141026-030030-3142697795-38676-9075-S1 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:37.996583 9099 hierarchical_allocator_process.hpp:816] Filtered mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2 on slave 20141026-030030-3142697795-38676-9075-S0 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:37.996649 9099 hierarchical_allocator_process.hpp:659] Performed allocation for 3 slaves in 870348ns I1026 03:29:38.002389 9099 monitor.cpp:140] Failed to collect resource usage for container 'b51d53cf-1654-4f82-bd2c-9e8884702378' for executor 'default' of framework '20141026-030030-3142697795-38676-9075-': Unknown container: b51d53cf-1654-4f82-bd2c-9e8884702378 I1026 03:29:38.003495 9114 monitor.cpp:140] Failed to collect resource usage for container 'c89d7949-b121-4ec4-a935-f0848128cd4f' for executor 'default' of framework '20141026-030030-3142697795-38676-9075-': Unknown container: c89d7949-b121-4ec4-a935-f0848128cd4f I1026 03:29:38.997797 9112 hierarchical_allocator_process.hpp:816] Filtered cpus(*):2; mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000] on slave 20141026-030030-3142697795-38676-9075-S2 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:38.997989 9112 hierarchical_allocator_process.hpp:816] Filtered mem(*):10240; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):2 on slave 20141026-030030-3142697795-38676-9075-S0 for framework 20141026-030030-3142697795-38676-9075- I1026 03:29:38.998142 9112 hierarchical_allocator_process.hpp:816] Filtered mem(*):10112; disk(*):3.70122e+06; ports(*):[31000-32000]; cpus(*):1 on slave
Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2210
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2210/changes
Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2488
See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2488/changes Changes: [yujie.jay] PortMappingIsolator: Swap TX/RX in statistic collection in usage -- [...truncated 21400 lines...] I1026 05:37:40.692209 1944 master.cpp:1242] The newly elected leader is master@67.195.81.187:48044 with id 20141026-053740-3142697795-48044-1919 I1026 05:37:40.692231 1944 master.cpp:1255] Elected as the leading master! I1026 05:37:40.692258 1944 master.cpp:1073] Recovering from registrar I1026 05:37:40.692318 1938 recover.cpp:188] Received a recover response from a replica in STARTING status I1026 05:37:40.692419 1947 registrar.cpp:313] Recovering registrar I1026 05:37:40.692847 1936 recover.cpp:554] Updating replica status to VOTING I1026 05:37:40.717001 1939 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 763823ns I1026 05:37:40.717027 1939 replica.cpp:320] Persisted replica status to VOTING I1026 05:37:40.717118 1948 recover.cpp:568] Successfully joined the Paxos group I1026 05:37:40.717316 1948 recover.cpp:452] Recover process terminated I1026 05:37:40.717768 1934 log.cpp:656] Attempting to start the writer I1026 05:37:40.719187 1935 replica.cpp:474] Replica received implicit promise request with proposal 1 I1026 05:37:40.719761 1935 leveldb.cpp:306] Persisting metadata (8 bytes) to leveldb took 553560ns I1026 05:37:40.719779 1935 replica.cpp:342] Persisted promised to 1 I1026 05:37:40.720424 1945 coordinator.cpp:230] Coordinator attemping to fill missing position I1026 05:37:40.721951 1933 replica.cpp:375] Replica received explicit promise request for position 0 with proposal 2 I1026 05:37:40.722365 1933 leveldb.cpp:343] Persisting action (8 bytes) to leveldb took 385625ns I1026 05:37:40.722385 1933 replica.cpp:676] Persisted action at 0 I1026 05:37:40.723311 1939 replica.cpp:508] Replica received write request for position 0 I1026 05:37:40.723372 1939 leveldb.cpp:438] Reading position from leveldb took 35296ns I1026 05:37:40.723793 1939 leveldb.cpp:343] Persisting action (14 bytes) to leveldb took 387051ns I1026 05:37:40.723814 1939 replica.cpp:676] Persisted action at 0 I1026 05:37:40.724311 1942 replica.cpp:655] Replica received learned notice for position 0 I1026 05:37:40.724762 1942 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 424112ns I1026 05:37:40.724787 1942 replica.cpp:676] Persisted action at 0 I1026 05:37:40.724809 1942 replica.cpp:661] Replica learned NOP action at position 0 I1026 05:37:40.725275 1936 log.cpp:672] Writer started with ending position 0 I1026 05:37:40.726511 1945 leveldb.cpp:438] Reading position from leveldb took 33201ns I1026 05:37:40.729558 1947 registrar.cpp:346] Successfully fetched the registry (0B) in 37.101056ms I1026 05:37:40.729665 1947 registrar.cpp:445] Applied 1 operations in 19075ns; attempting to update the 'registry' I1026 05:37:40.732529 1937 log.cpp:680] Attempting to append 138 bytes to the log I1026 05:37:40.732743 1943 coordinator.cpp:340] Coordinator attempting to write APPEND action at position 1 I1026 05:37:40.733597 1940 replica.cpp:508] Replica received write request for position 1 I1026 05:37:40.734328 1940 leveldb.cpp:343] Persisting action (157 bytes) to leveldb took 702340ns I1026 05:37:40.734354 1940 replica.cpp:676] Persisted action at 1 I1026 05:37:40.734871 1939 replica.cpp:655] Replica received learned notice for position 1 I1026 05:37:40.735640 1939 leveldb.cpp:343] Persisting action (159 bytes) to leveldb took 743999ns I1026 05:37:40.735673 1939 replica.cpp:676] Persisted action at 1 I1026 05:37:40.735704 1939 replica.cpp:661] Replica learned APPEND action at position 1 I1026 05:37:40.736652 1940 registrar.cpp:490] Successfully updated the 'registry' in 6.947072ms I1026 05:37:40.736780 1940 registrar.cpp:376] Successfully recovered registrar I1026 05:37:40.737062 1936 master.cpp:1100] Recovered 0 slaves from the Registry (100B) ; allowing 10mins for slaves to re-register I1026 05:37:40.737082 1940 log.cpp:699] Attempting to truncate the log to 1 I1026 05:37:40.737210 1934 coordinator.cpp:340] Coordinator attempting to write TRUNCATE action at position 2 I1026 05:37:40.737901 1941 replica.cpp:508] Replica received write request for position 2 I1026 05:37:40.738412 1941 leveldb.cpp:343] Persisting action (16 bytes) to leveldb took 484781ns I1026 05:37:40.738432 1941 replica.cpp:676] Persisted action at 2 I1026 05:37:40.738870 1941 replica.cpp:655] Replica received learned notice for position 2 I1026 05:37:40.739341 1941 leveldb.cpp:343] Persisting action (18 bytes) to leveldb took 451900ns I1026 05:37:40.739384 1941 leveldb.cpp:401] Deleting ~1 keys from leveldb took 28203ns I1026 05:37:40.739397 1941 replica.cpp:676] Persisted action at 2 I1026 05:37:40.739411 1941 replica.cpp:661] Replica learned TRUNCATE action at position 2 I1026
