Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
On Nov. 11, 2014, 7:28 p.m., Niklas Nielsen wrote: Thomas, can you expand a bit on what is going on? It looks like you are doing more than just enabling the configuration of the master endpoint? That's really it. To allow configuration of the master endpoint, a config dialog and directive was introduced. To make sure all configuration is part of that, the existing longDate toggle was moved into that namespace. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review60826 --- On Oct. 16, 2014, 6:41 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 16, 2014, 6:41 p.m.) Review request for mesos, Michael Lunøe and Niklas Nielsen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 16, 2014, 5:38 p.m.) Review request for mesos, Michael Lunøe and Niklas Nielsen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd1916373a7e525be967885bbd1a3a4aa0104 configure.ac bb4fee4e7c7497336d61d5a47da3667a9bc14ee5 src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/master/main.cpp 29ded49f5c18b12dbe4ff9b69ee3343c04ce2cf8 src/master/master.cpp 0a5c9a374062a241c90ea238725fbb8dd2408ef4 src/slave/flags.hpp 159d4ef63643d17be353533992049a38aec72437 src/slave/main.cpp b27cc32ebccb1c97f2f2ae0b904c725bbf541ebf src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 16, 2014, 6:41 p.m.) Review request for mesos, Michael Lunøe and Niklas Nielsen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am c44a9ad47d6e1262949b9049f4ae25b049440d99 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Review Request 26788: Added DISTRIBUTE_EGG reference so that protobuf egg can be built locally.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- Review request for mesos. Repository: mesos-git Description --- Added DISTRIBUTE_EGG reference so that protobuf egg can be built locally. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 15, 2014, 11:50 p.m.) Review request for mesos. Summary (updated) - Added DISTRIBUTE reference so that protobuf egg can be built locally. Repository: mesos-git Description (updated) --- Added DISTRIBUTE reference so that protobuf egg can be built locally. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 15, 2014, 11:51 p.m.) Review request for mesos. Repository: mesos-git Description --- Added DISTRIBUTE reference so that protobuf egg can be built locally. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing (updated) --- make -j6 Thanks, Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:29 a.m.) Review request for mesos. Repository: mesos-git Description --- Added DISTRIBUTE reference so that protobuf egg can be built locally. Diffs (updated) - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing --- make -j6 Thanks, Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:35 a.m.) Review request for mesos. Repository: mesos-git Description --- Added DISTRIBUTE reference so that protobuf egg can be built locally. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing (updated) --- make -j6 make ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/python/dist/protobuf-2.5.0-py2.6.egg Thanks, Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.
On Oct. 16, 2014, 12:26 a.m., Vinod Kone wrote: Hey Thomas. Can you add more description on what the bug is and what the fix is here? Also, please assign it to a reviewer (me?). Yup, let me add some more context =) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/#review56847 --- On Oct. 16, 2014, 12:35 a.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:35 a.m.) Review request for mesos. Repository: mesos-git Description --- Added DISTRIBUTE reference so that protobuf egg can be built locally. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing --- make -j6 make ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/python/dist/protobuf-2.5.0-py2.6.egg Thanks, Thomas Rampelberg
Re: Review Request 26788: Added DISTRIBUTE reference so that protobuf egg can be built locally.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26788/ --- (Updated Oct. 16, 2014, 12:41 a.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description (updated) --- Added DISTRIBUTE reference so that protobuf egg can be built locally. In MESOS-899, we cleaned the 3rdparty build process up a little bit by no longer making eggs for libraries that we didn't need to. This reference wasn't updated in that patch and needs to be. It has been working for most people because python would go and download the right version for you in the background. The bug ended up being uncovered by users running CI builds without access to external services. Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 Diff: https://reviews.apache.org/r/26788/diff/ Testing --- make -j6 make ../3rdparty/libprocess/3rdparty/protobuf-2.5.0/python/dist/protobuf-2.5.0-py2.6.egg Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
On Oct. 14, 2014, 4:02 p.m., Niklas Nielsen wrote: The latest diff looks broken - Thomas, mind updating it (if you still want this to go in)? Why in the world didn't this get in. I'll fix it up =) - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review56533 --- On Jan. 29, 2014, 8:51 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 29, 2014, 8:51 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - CHANGELOG e75a3411f865cb7f3768df1299f469f49c3a0009 bin/lldb-mesos-local.sh.in 35011fd483e477701efd7e204b514bb362713ccb bin/lldb-mesos-master.sh.in b1c7f9f1b98b5f410729f5a7e7a1729709f7e744 bin/lldb-mesos-slave.sh.in 896c411b2b05d3c4a14288002520a5391a88d955 bin/lldb-mesos-tests.sh.in f001b0b7f35839a101a86cd7df86fb7ebfc1c47e configure.ac 18bf4bfb345bdd443defccc4e53d357b35c7b533 docs/upgrades.md fe8b60470f7431accef44977e7036a2688289037 src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 14, 2014, 10:52 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 14, 2014, 10:53 p.m.) Review request for mesos and Michael Lunøe. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Oct. 14, 2014, 10:54 p.m.) Review request for mesos, Michael Lunøe and Niklas Nielsen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d503c8df73cda15a9d59254e8265e4a5d0e003a4 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js 41a70a80442501a2bf7b217939dbe504662941d2 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 24469: Created pure python package for the CLI.
/test_resolve.py PRE-CREATION src/python/cli/tests/integration/test_scp.py PRE-CREATION src/python/cli/tests/integration/test_ssh.py PRE-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/unit/test_master.py PRE-CREATION src/python/cli/tests/unit/test_slave.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 24469: Created pure python package for the CLI.
/test_resolve.py PRE-CREATION src/python/cli/tests/integration/test_scp.py PRE-CREATION src/python/cli/tests/integration/test_ssh.py PRE-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/unit/test_master.py PRE-CREATION src/python/cli/tests/unit/test_slave.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing (updated) --- make distcheck -j6 Thanks, Thomas Rampelberg
Re: Review Request 24469: Created pure python package for the CLI.
/integration/test_resolve.py PRE-CREATION src/python/cli/tests/integration/test_scp.py PRE-CREATION src/python/cli/tests/integration/test_ssh.py PRE-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/unit/test_master.py PRE-CREATION src/python/cli/tests/unit/test_slave.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing --- make distcheck -j6 Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
On Sept. 15, 2014, 6:53 p.m., Cody Maloney wrote: src/Makefile.am, line 1043 https://reviews.apache.org/r/24264/diff/11/?file=674261#file674261line1043 Shouldn't we install these globally / not for '--user'? It isn't getting installed for the user. I'm setting the install location via. `PYTHONUSERBASE`. This is the only way to make sure the python install gets restricted to the same prefix as configured. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review53375 --- On Sept. 2, 2014, 9:25 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Sept. 2, 2014, 9:25 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325 configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089 mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Getting Started with Mesos on Fedora 21 and CentOS 7
This is *so* awesome. Thanks for getting the packages *and* docs together Tim =) On Mon, Sep 8, 2014 at 7:50 PM, Tim St Clair tstcl...@redhat.com wrote: http://timothysc.github.io/blog/2014/09/08/mesos-breeze/ -- Cheers, Timothy St. Clair Red Hat Inc.
Re: The mesos.interface python egg
I'm not sure what happened, but I got it fixed up this morning. On Thu, Sep 4, 2014 at 4:55 AM, Till Toenshoff toensh...@me.com wrote: Has someone been changing things relating to the new *mesos.interface* python egg on pypi? I don't seem to be able to install it anymore.. which is strange as it's listed as available on the pypi site. Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 I am getting the same results, the log-file shows: /usr/local/bin/pip run on Thu Sep 4 13:51:38 2014 Downloading/unpacking mesos.interface Getting page https://pypi.python.org/simple/mesos.interface/ URLs to search for versions for mesos.interface: * https://pypi.python.org/simple/mesos.interface/ Analyzing links from page https://pypi.python.org/simple/mesos.interface/ Skipping link https://pypi.python.org/packages/2.7/m/mesos.interface/mesos.interface-0.20.0-py2.7.egg#md5=21382705ad44629dc8e00cb3a7ba0407 (from https://pypi.python.org/simple/mesos.interface/); unknown archive format: .egg Could not find any downloads that satisfy the requirement mesos.interface No distributions at all found for mesos.interface However, manually downloading that egg via the pypi website https://pypi.python.org/pypi/mesos.interface/0.20.0 works fine. As mentioned on IRC, people seemed to expect a source distribution instead of an egg - is that the problem for pip as well?
Re: Review Request 25334: Fixed python egg proto imports.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52316 --- Ship it! :thumbsup: Is there any reason we're not running `test-containerizer` as part of the normal unit tests? I'd hate for something like this to happen accidentally again. - Thomas Rampelberg On Sept. 4, 2014, 11:46 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- (Updated Sept. 4, 2014, 11:46 a.m.) Review request for mesos, Benjamin Hindman, Tom Arnfeld, Thomas Rampelberg, and Vinod Kone. Bugs: MESOS-1750 https://issues.apache.org/jira/browse/MESOS-1750 Repository: mesos-git Description --- Fixes defective import introduced by the flat folder hierachy of the mesos.interface Python egg generation. Diffs - src/Makefile.am 5526189 Diff: https://reviews.apache.org/r/25334/diff/ Testing --- make check (OSX and linux) functional test by running build/src/examples/python/test-containerizer Thanks, Till Toenshoff
Review Request 25272: Added instructions for getting started with centos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --- Added instructions for getting started with centos. Diffs - docs/getting-started.md 78205dde40b0e088990d9511e3518160e62f4c8c Diff: https://reviews.apache.org/r/25272/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 25272: Added instructions for getting started with centos.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/ --- (Updated Sept. 2, 2014, 9:17 p.m.) Review request for mesos and Jie Yu. Repository: mesos-git Description --- Added instructions for getting started with centos. Diffs (updated) - docs/getting-started.md 78205dde40b0e088990d9511e3518160e62f4c8c Diff: https://reviews.apache.org/r/25272/diff/ Testing (updated) --- Stock Centos 6.5 image (base GCE image). Thanks, Thomas Rampelberg
Re: Review Request 25272: Added instructions for getting started with centos.
On Sept. 2, 2014, 9:05 p.m., Vinod Kone wrote: im assuming you tested this on a stock centos6.5 box? vagrant? Yup, stock centos6.5 (base GCE image). On Sept. 2, 2014, 9:05 p.m., Vinod Kone wrote: docs/getting-started.md, lines 66-68 https://reviews.apache.org/r/25272/diff/1/?file=674232#file674232line66 Is there no rpm for maven that one can install via yum? It is kinda ridiculous. There's an apache EPEL repo that could be added to get maven, but even then you need to do the symlink yourself and it installs a bunch of dependencies that conflict. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/#review52083 --- On Sept. 2, 2014, 8:58 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25272/ --- (Updated Sept. 2, 2014, 8:58 p.m.) Review request for mesos and Jie Yu. Repository: mesos-git Description --- Added instructions for getting started with centos. Diffs - docs/getting-started.md 78205dde40b0e088990d9511e3518160e62f4c8c Diff: https://reviews.apache.org/r/25272/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Sept. 2, 2014, 9:25 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325 configure.ac c4b43911f5f8f651ddf8f2e12c263849e07e8089 mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 27, 2014, 8:45 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION Makefile.am e4ffa35a56b0fdfe6ead4f778ee69b7a37cec325 configure.ac 4b34173ed23bfe4e6f108db57f2611e50927ed2b mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 26, 2014, 9:32 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 525d3048ca895952177f35d7c573a1bb3ddd5b3e mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 25, 2014, 11:49 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 25, 2014, 11:52 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
On Aug. 14, 2014, 6:28 p.m., Timothy St. Clair wrote: configure.ac, line 903 https://reviews.apache.org/r/24264/diff/6/?file=657733#file657733line903 We have a .m4 that can check python mods Doesn't look like it checks anything I'd use =/ - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review50616 --- On Aug. 25, 2014, 11:52 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 25, 2014, 11:52 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 7cf0c88aa772909427fffd38fb91bffd967b77d2 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 996c21d52a731744058bba76040a8aa454dd8b5c mpi/mpiexec-mesos.in 82a135091fa3a25bc118e4d51be0ee6194ac441f src/Makefile.am 40b9f6b69f9970a3a5bac6f055f0897224478481 src/examples/python/test-containerizer.in c82f3dc29f48e389a70e17ce310e75496dae3274 src/examples/python/test-executor.in 0725568c81bfa753bfed12fc0d97a2bb1c61caae src/examples/python/test-framework.in 1a4300213083dcd03d8ef7d599149877c51df231 Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Python bindings are changing!
There is one important step to do during the upgrade: - Upgrade your python framework and executor. You'll be able to either import using the new configuration or the old. Replace the existing imports with this: try: from mesos.native import MesosExecutorDriver, MesosSchedulerDriver from mesos.interface import Executor, Scheduler from mesos.interface import mesos_pb2 except ImportError: from mesos import Executor, MesosExecutorDriver, MesosSchedulerDriver, Scheduler import mesos_pb2 Then, you'll be able to follow the normal upgrade instructions. Following the ones from the 0.18.x - 0.19.x instructions: - Install the new master binaries and restart the masters. - Install the new slave binaries and restart the slaves. - Upgrade the schedulers by installing the latest python egg. - Restart the schedulers. - Upgrade the executors by installing the latest python egg. On Wed, Aug 13, 2014 at 10:19 AM, Jie Yu yujie@gmail.com wrote: Thomas, We are about to cut the 0.20.0 release. I am updating the docs/upgrades.md. Regarding the python binding change, can you let us know the exact deploy procedure if someone is using the old python binding? More specifically, say all masters/slaves/executors/schedulers are using 0.19.1. What should we upgrade first? For example 1) If we upgrade the slaves first (libmesos.so will be updated), what happens if the new slave launches an old executor? (here, you actually have two cases: a) the executor bundles libmesos.so; b) the execute does not bundle libmesos.so) 2) Same question for framework, which one should we upgrade first (scheduler or master)? Also, would you please test all these scenarios so that we can provide correct guidance to the community. Thanks a lot! - Jie On Sun, Aug 3, 2014 at 11:18 PM, Benjamin Mahler benjamin.mah...@gmail.com wrote: It might work to use 0.19 with a 0.20 mesos (or visa versa), but there be dragons =) Is there a deprecation cycle? How should folks be upgrading Python schedulers and executors to 0.20.0 if they are not statically bundling libmesos? Is there an upgrade order required? We will need to document this carefully in the upgrade procedures for 0.20.0. Thanks for cleaning this up Thomas! Appreciate it. On Sat, Aug 2, 2014 at 12:12 PM, Thomas Rampelberg tho...@saunter.org wrote: You'll want to match the python bindings to your mesos version as the functionality is coming from libmesos itself. It might work to use 0.19 with a 0.20 mesos (or visa versa), but there be dragons =) On Fri, Aug 1, 2014 at 1:30 PM, Jie Yu yujie@gmail.com wrote: Thomas, Thank you for the heads-up. One question: what if mesos and python binding have different versions? For example, is it ok to use a 0.19.0 python binding and having a 0.20.0 mesos? Same question for the reverse. - Jie On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg tho...@saunter.org wrote: - What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be distributed easily. This forces python projects using mesos to copy protobufs around and forces a onerous dependency on anyone who would like to do a pure python binding. - How was this problem solved? The current python package has been split into two separate packages: - mesos.interface (stub implementations and protobufs) - mesos.native (old _mesos module) These are python meta-packages and can be installed as separate pieces. The `mesos.interface` package will be hosted on pypi and can be installed via. easy_install and pip. See https://issues.apache.org/jira/browse/MESOS-857 and https://reviews.apache.org/r/23224/. - Why should I care? These changes are not backwards compatible. With 0.20.0 you will need to change how you use the python bindings. Here's a quick overview: mesos.Scheduler - mesos.interface.Scheduler mesos.mesos_pb2 - mesos.interface.mesos_pb2 mesos.MesosSchedulerDriver - mesos.native.MesosSchedulerDriver For more details, you can take a look at the examples in `src/examples/python.
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 11, 2014, 6:09 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/libprocess/include/process/defer.hpp dce7f3b71fc30e28fe55b2ed20ea48090aa57781 3rdparty/libprocess/include/process/deferred.hpp 8bdc69235c7c25d8c8c0a5a6dcc99c4a2c34f94a 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION Doxyfile 8bba46152f59478bbd5a4573eab85ec9628316bf configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b docs/authorization.md 669794457f10e357bdd10b1a096a2ee9b629971f include/mesos/mesos.proto cc9f20e5cf0ecad58a9c8fa2e4e6e79cea8b344c mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/credentials/credentials.hpp 4cdadb1b6d5a607cee8caeb38f2cbf2e3ec5da7a src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 src/master/flags.hpp 5e9ecb567fb2f4576b38303a9d73b93d8cd14115 src/master/hierarchical_allocator_process.hpp 34f8cd658920b36b1062bd3b7f6bfbd1bcb6bb52 src/master/http.cpp 9317a95133e9bba54d037057a147ae6d91125441 src/master/master.hpp c9f989aa209c1067b60d02cfb4f032afe0f9de4c src/master/master.cpp d53d6c2d2c89258880df42b1c0a2cfb04cffa215 src/sasl/authenticator.hpp 35ab79449093e10877248b91ba7070e04c9cdd6f src/slave/constants.hpp 9030871fa2c6b449a7eee7644691ca54b0635566 src/slave/constants.cpp e1da5c064b3ea4f2c0d18f4da64111cbea2544d1 src/slave/containerizer/isolators/cgroups/mem.hpp c734dae834c3f771b2954868138a622b7712aa32 src/slave/containerizer/isolators/cgroups/mem.cpp 3ba580d7b5e16ca2ea04c2843780b2e5bc52ec95 src/slave/containerizer/isolators/network/port_mapping.cpp 938782ae2ab1da34eb316381131e9bfcb7c810d1 src/slave/flags.hpp 1e36c517ccebf42d18cd2534d40d98badd488cad src/tests/allocator_tests.cpp 774528a61c937b2f6aa9fa3ecc59868070e21860 src/tests/authorization_tests.cpp a8fa4ccf4558532f6717f7a6e6301565aec7d5d1 src/tests/health_check_tests.cpp 731d944dd92ac325b0752655f8454f6ec7275c03 src/tests/master_authorization_tests.cpp f0f064808d8bf36a2a756bc907c477dd6440636c src/tests/mesos.hpp b31c347299707cba242619c3dc6915f295bee9cb src/tests/mesos.cpp 5bd8ba0bb56c9be9d0a3c49c27b6ebc03cfbdf7a src/tests/port_mapping_tests.cpp a990da38bd1ff8dcfb6510ed4aa411253020ba20 src/tests/reconciliation_tests.cpp 3c4d7ed886333f0ccc1460178b9e06e7e38246c9 src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51 src/tests/shutdown_tests.cpp 12ebef43a1ff339b30329d96d3c00646462ba37e support/timed_tests.sh e060966b67089a60d4c93759bf907b3c8015e92f Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 11, 2014, 6:09 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24469: Created pure python package for the CLI.
-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 7, 2014, 7 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
On Aug. 6, 2014, 10:44 p.m., Benjamin Hindman wrote: mpi/mpiexec-mesos.in, line 32 https://reviews.apache.org/r/24264/diff/2/?file=652335#file652335line32 Can we throw a comment above this block to explain what it is that you're doing? It's starting to get more and more complicated. Looking at it, there's a way to simplify this whole thing significantly. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review49824 --- On Aug. 7, 2014, 7 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 7, 2014, 7 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Review Request 24469: Created pure python package for the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24469/ --- Review request for mesos and Benjamin Hindman. Bugs: mesos-1016 https://issues.apache.org/jira/browse/mesos-1016 Repository: mesos-git Description --- This is a re-implementation of the CLI tools that removes the dependencies on compiled code and implements everything purely in python. You will now be able to `pip install mesos.cli` and get these tools anywhere (such as developer's laptops who don't have mesos itself installed or even a windows machine). The interface has changed and the tool has been made task centric. You can configure the master you'd like to use and then ignore which framework a task is running under completely. Diffs - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/cli/mesos-cat 73dc63ebc2fab9150f4dd691e10defaf989b9e6b src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a src/cli/mesos-scp 77b8557d8ca33960d9135ad4fa6bfe3dcd087108 src/cli/mesos-tail 256a804b98b2efb2fb0256635449b36a3a4d0a6b src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py 857059e2c12ed7f1419dfbf0d11dda0ff9fae235 src/cli/python/mesos/futures.py da2f4ceb72f4d8f1a1a48b0c3a1723b2f638 src/cli/python/mesos/http.py 0e19aa8dd6595a9b292189364fd51fb9b3bfb285 src/cli/resolve.cpp a99b6094dffc9f7aa44bcf63ad40121e1abb120b src/python/cli/README.rst PRE-CREATION src/python/cli/bin/mesos-zsh-completion.sh PRE-CREATION src/python/cli/docs/debugging.md PRE-CREATION src/python/cli/mesos/__init__.py PRE-CREATION src/python/cli/mesos/cli/__init__.py PRE-CREATION src/python/cli/mesos/cli/cfg.py PRE-CREATION src/python/cli/mesos/cli/cli.py PRE-CREATION src/python/cli/mesos/cli/cmds/cat.py PRE-CREATION src/python/cli/mesos/cli/cmds/completion.py PRE-CREATION src/python/cli/mesos/cli/cmds/config.py PRE-CREATION src/python/cli/mesos/cli/cmds/events.py PRE-CREATION src/python/cli/mesos/cli/cmds/find.py PRE-CREATION src/python/cli/mesos/cli/cmds/head.py PRE-CREATION src/python/cli/mesos/cli/cmds/help.py PRE-CREATION src/python/cli/mesos/cli/cmds/ls.py PRE-CREATION src/python/cli/mesos/cli/cmds/ps.py PRE-CREATION src/python/cli/mesos/cli/cmds/resolve.py PRE-CREATION src/python/cli/mesos/cli/cmds/scp.py PRE-CREATION src/python/cli/mesos/cli/cmds/ssh.py PRE-CREATION src/python/cli/mesos/cli/cmds/state.py PRE-CREATION src/python/cli/mesos/cli/cmds/tail.py PRE-CREATION src/python/cli/mesos/cli/exceptions.py PRE-CREATION src/python/cli/mesos/cli/log.py PRE-CREATION src/python/cli/mesos/cli/main.py PRE-CREATION src/python/cli/mesos/cli/master.py PRE-CREATION src/python/cli/mesos/cli/mesos_file.py PRE-CREATION src/python/cli/mesos/cli/slave.py PRE-CREATION src/python/cli/mesos/cli/ssh.py PRE-CREATION src/python/cli/mesos/cli/state.py PRE-CREATION src/python/cli/mesos/cli/task.py PRE-CREATION src/python/cli/mesos/cli/util.py PRE-CREATION src/python/cli/mesos/cli/zookeeper.py PRE-CREATION src/python/cli/setup.cfg PRE-CREATION src/python/cli/setup.py PRE-CREATION src/python/cli/tests/__init__.py PRE-CREATION src/python/cli/tests/data/browse.json PRE-CREATION src/python/cli/tests/data/config.json PRE-CREATION src/python/cli/tests/data/master-host PRE-CREATION src/python/cli/tests/data/master.pb PRE-CREATION src/python/cli/tests/data/master_state.json PRE-CREATION src/python/cli/tests/data/sandbox/stderr PRE-CREATION src/python/cli/tests/data/sandbox/stdout PRE-CREATION src/python/cli/tests/data/slave-20140619-151434-16842879-5050-1196-0.json PRE-CREATION src/python/cli/tests/data/slave_statistics.json PRE-CREATION src/python/cli/tests/integration/__init__.py PRE-CREATION src/python/cli/tests/integration/test_cat.py PRE-CREATION src/python/cli/tests/integration/test_completion.py PRE-CREATION src/python/cli/tests/integration/test_config.py PRE-CREATION src/python/cli/tests/integration/test_find.py PRE-CREATION src/python/cli/tests/integration/test_head.py PRE-CREATION src/python/cli/tests/integration/test_ls.py PRE-CREATION src/python/cli/tests/integration/test_ps.py PRE-CREATION src/python/cli/tests/integration/test_resolve.py PRE-CREATION src/python/cli/tests/integration/test_scp.py PRE-CREATION src/python/cli/tests/integration/test_ssh.py PRE-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing --- Thanks, Thomas Rampelberg
Updates to the CLI tools
I've gone through and done a ton of updates to the CLI tools. If you'd like to give them a try, there's a review posted and you can check out the readme here: https://reviews.apache.org/r/24469/diff/#11 (tldr. `pip install mesos.cli`) Please take the time to read the README if you are at all interested. It goes over the design goals, installation steps, features and implemented commands.
Re: Review Request 24469: Created pure python package for the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24469/ --- (Updated Aug. 7, 2014, 9:49 p.m.) Review request for mesos and Benjamin Hindman. Bugs: mesos-1016 https://issues.apache.org/jira/browse/mesos-1016 Repository: mesos-git Description --- This is a re-implementation of the CLI tools that removes the dependencies on compiled code and implements everything purely in python. You will now be able to `pip install mesos.cli` and get these tools anywhere (such as developer's laptops who don't have mesos itself installed or even a windows machine). The interface has changed and the tool has been made task centric. You can configure the master you'd like to use and then ignore which framework a task is running under completely. Diffs (updated) - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/cli/mesos-cat 73dc63ebc2fab9150f4dd691e10defaf989b9e6b src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a src/cli/mesos-scp 77b8557d8ca33960d9135ad4fa6bfe3dcd087108 src/cli/mesos-tail 256a804b98b2efb2fb0256635449b36a3a4d0a6b src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py 857059e2c12ed7f1419dfbf0d11dda0ff9fae235 src/cli/python/mesos/futures.py da2f4ceb72f4d8f1a1a48b0c3a1723b2f638 src/cli/python/mesos/http.py 0e19aa8dd6595a9b292189364fd51fb9b3bfb285 src/cli/resolve.cpp a99b6094dffc9f7aa44bcf63ad40121e1abb120b src/python/cli/README.rst PRE-CREATION src/python/cli/bin/mesos-zsh-completion.sh PRE-CREATION src/python/cli/docs/debugging.md PRE-CREATION src/python/cli/mesos/__init__.py PRE-CREATION src/python/cli/mesos/cli/__init__.py PRE-CREATION src/python/cli/mesos/cli/cfg.py PRE-CREATION src/python/cli/mesos/cli/cli.py PRE-CREATION src/python/cli/mesos/cli/cmds/cat.py PRE-CREATION src/python/cli/mesos/cli/cmds/completion.py PRE-CREATION src/python/cli/mesos/cli/cmds/config.py PRE-CREATION src/python/cli/mesos/cli/cmds/events.py PRE-CREATION src/python/cli/mesos/cli/cmds/find.py PRE-CREATION src/python/cli/mesos/cli/cmds/head.py PRE-CREATION src/python/cli/mesos/cli/cmds/help.py PRE-CREATION src/python/cli/mesos/cli/cmds/ls.py PRE-CREATION src/python/cli/mesos/cli/cmds/ps.py PRE-CREATION src/python/cli/mesos/cli/cmds/resolve.py PRE-CREATION src/python/cli/mesos/cli/cmds/scp.py PRE-CREATION src/python/cli/mesos/cli/cmds/ssh.py PRE-CREATION src/python/cli/mesos/cli/cmds/state.py PRE-CREATION src/python/cli/mesos/cli/cmds/tail.py PRE-CREATION src/python/cli/mesos/cli/exceptions.py PRE-CREATION src/python/cli/mesos/cli/log.py PRE-CREATION src/python/cli/mesos/cli/main.py PRE-CREATION src/python/cli/mesos/cli/master.py PRE-CREATION src/python/cli/mesos/cli/mesos_file.py PRE-CREATION src/python/cli/mesos/cli/slave.py PRE-CREATION src/python/cli/mesos/cli/ssh.py PRE-CREATION src/python/cli/mesos/cli/state.py PRE-CREATION src/python/cli/mesos/cli/task.py PRE-CREATION src/python/cli/mesos/cli/util.py PRE-CREATION src/python/cli/mesos/cli/zookeeper.py PRE-CREATION src/python/cli/setup.cfg PRE-CREATION src/python/cli/setup.py PRE-CREATION src/python/cli/tests/__init__.py PRE-CREATION src/python/cli/tests/data/browse.json PRE-CREATION src/python/cli/tests/data/config.json PRE-CREATION src/python/cli/tests/data/master-host PRE-CREATION src/python/cli/tests/data/master.pb PRE-CREATION src/python/cli/tests/data/master_state.json PRE-CREATION src/python/cli/tests/data/sandbox/stderr PRE-CREATION src/python/cli/tests/data/sandbox/stdout PRE-CREATION src/python/cli/tests/data/slave-20140619-151434-16842879-5050-1196-0.json PRE-CREATION src/python/cli/tests/data/slave_statistics.json PRE-CREATION src/python/cli/tests/integration/__init__.py PRE-CREATION src/python/cli/tests/integration/test_cat.py PRE-CREATION src/python/cli/tests/integration/test_completion.py PRE-CREATION src/python/cli/tests/integration/test_config.py PRE-CREATION src/python/cli/tests/integration/test_find.py PRE-CREATION src/python/cli/tests/integration/test_head.py PRE-CREATION src/python/cli/tests/integration/test_ls.py PRE-CREATION src/python/cli/tests/integration/test_ps.py PRE-CREATION src/python/cli/tests/integration/test_resolve.py PRE-CREATION src/python/cli/tests/integration/test_scp.py PRE-CREATION src/python/cli/tests/integration/test_ssh.py PRE-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing --- Thanks, Thomas
Re: Review Request 24469: Created pure python package for the CLI.
, Thomas Rampelberg
Re: Review Request 24469: Created pure python package for the CLI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24469/ --- (Updated Aug. 8, 2014, 12:37 a.m.) Review request for mesos and Benjamin Hindman. Bugs: mesos-1016 https://issues.apache.org/jira/browse/mesos-1016 Repository: mesos-git Description --- This is a re-implementation of the CLI tools that removes the dependencies on compiled code and implements everything purely in python. You will now be able to `pip install mesos.cli` and get these tools anywhere (such as developer's laptops who don't have mesos itself installed or even a windows machine). The interface has changed and the tool has been made task centric. You can configure the master you'd like to use and then ignore which framework a task is running under completely. Diffs (updated) - src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/cli/mesos-cat 73dc63ebc2fab9150f4dd691e10defaf989b9e6b src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a src/cli/mesos-scp 77b8557d8ca33960d9135ad4fa6bfe3dcd087108 src/cli/mesos-tail 256a804b98b2efb2fb0256635449b36a3a4d0a6b src/cli/mesos.cpp 171a707cd2ba2348898e7fbe8fe9f0634edd6d86 src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef src/cli/python/mesos/cli.py 857059e2c12ed7f1419dfbf0d11dda0ff9fae235 src/cli/python/mesos/futures.py da2f4ceb72f4d8f1a1a48b0c3a1723b2f638 src/cli/python/mesos/http.py 0e19aa8dd6595a9b292189364fd51fb9b3bfb285 src/cli/resolve.cpp a99b6094dffc9f7aa44bcf63ad40121e1abb120b src/python/cli/README.rst PRE-CREATION src/python/cli/bin/mesos-zsh-completion.sh PRE-CREATION src/python/cli/docs/debugging.md PRE-CREATION src/python/cli/mesos/__init__.py PRE-CREATION src/python/cli/mesos/cli/__init__.py PRE-CREATION src/python/cli/mesos/cli/cfg.py PRE-CREATION src/python/cli/mesos/cli/cli.py PRE-CREATION src/python/cli/mesos/cli/cmds/cat.py PRE-CREATION src/python/cli/mesos/cli/cmds/completion.py PRE-CREATION src/python/cli/mesos/cli/cmds/config.py PRE-CREATION src/python/cli/mesos/cli/cmds/events.py PRE-CREATION src/python/cli/mesos/cli/cmds/find.py PRE-CREATION src/python/cli/mesos/cli/cmds/head.py PRE-CREATION src/python/cli/mesos/cli/cmds/help.py PRE-CREATION src/python/cli/mesos/cli/cmds/ls.py PRE-CREATION src/python/cli/mesos/cli/cmds/ps.py PRE-CREATION src/python/cli/mesos/cli/cmds/resolve.py PRE-CREATION src/python/cli/mesos/cli/cmds/scp.py PRE-CREATION src/python/cli/mesos/cli/cmds/ssh.py PRE-CREATION src/python/cli/mesos/cli/cmds/state.py PRE-CREATION src/python/cli/mesos/cli/cmds/tail.py PRE-CREATION src/python/cli/mesos/cli/exceptions.py PRE-CREATION src/python/cli/mesos/cli/log.py PRE-CREATION src/python/cli/mesos/cli/main.py PRE-CREATION src/python/cli/mesos/cli/master.py PRE-CREATION src/python/cli/mesos/cli/mesos_file.py PRE-CREATION src/python/cli/mesos/cli/slave.py PRE-CREATION src/python/cli/mesos/cli/ssh.py PRE-CREATION src/python/cli/mesos/cli/state.py PRE-CREATION src/python/cli/mesos/cli/task.py PRE-CREATION src/python/cli/mesos/cli/util.py PRE-CREATION src/python/cli/mesos/cli/zookeeper.py PRE-CREATION src/python/cli/setup.cfg PRE-CREATION src/python/cli/setup.py PRE-CREATION src/python/cli/tests/__init__.py PRE-CREATION src/python/cli/tests/data/browse.json PRE-CREATION src/python/cli/tests/data/config.json PRE-CREATION src/python/cli/tests/data/master-host PRE-CREATION src/python/cli/tests/data/master.pb PRE-CREATION src/python/cli/tests/data/master_state.json PRE-CREATION src/python/cli/tests/data/sandbox/stderr PRE-CREATION src/python/cli/tests/data/sandbox/stdout PRE-CREATION src/python/cli/tests/data/slave-20140619-151434-16842879-5050-1196-0.json PRE-CREATION src/python/cli/tests/data/slave_statistics.json PRE-CREATION src/python/cli/tests/integration/__init__.py PRE-CREATION src/python/cli/tests/integration/test_cat.py PRE-CREATION src/python/cli/tests/integration/test_completion.py PRE-CREATION src/python/cli/tests/integration/test_config.py PRE-CREATION src/python/cli/tests/integration/test_find.py PRE-CREATION src/python/cli/tests/integration/test_head.py PRE-CREATION src/python/cli/tests/integration/test_ls.py PRE-CREATION src/python/cli/tests/integration/test_ps.py PRE-CREATION src/python/cli/tests/integration/test_resolve.py PRE-CREATION src/python/cli/tests/integration/test_scp.py PRE-CREATION src/python/cli/tests/integration/test_ssh.py PRE-CREATION src/python/cli/tests/integration/test_state.py PRE-CREATION src/python/cli/tests/integration/test_tail.py PRE-CREATION src/python/cli/tests/utils.py PRE-CREATION src/python/cli/tox.ini PRE-CREATION Diff: https://reviews.apache.org/r/24469/diff/ Testing --- Thanks, Thomas
Re: Updates to the CLI tools
Along with this, I'd like to write some docs up on situational debugging (frequently encountered errors?) eg: - My framework says a task isn't working, now what? If anyone has a situation that they experience on a regular basis, let me know so that I can get it added to the list! On Thu, Aug 7, 2014 at 5:08 PM, Tom Arnfeld t...@duedil.com wrote: This is really quite awesome, I too have found myself needing something like this...! On 8 August 2014 00:26, Vinod Kone vinodk...@gmail.com wrote: This is really awesome. I love it! Can't wait to use it in production. On Thu, Aug 7, 2014 at 1:57 PM, Thomas Rampelberg tho...@saunter.org wrote: I've gone through and done a ton of updates to the CLI tools. If you'd like to give them a try, there's a review posted and you can check out the readme here: https://reviews.apache.org/r/24469/diff/#11 (tldr. `pip install mesos.cli`) Please take the time to read the README if you are at all interested. It goes over the design goals, installation steps, features and implemented commands.
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 6, 2014, 10:35 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
On Aug. 6, 2014, 10:44 p.m., Benjamin Hindman wrote: src/Makefile.am, lines 977-978 https://reviews.apache.org/r/24264/diff/2/?file=652336#file652336line977 Just my ignorance here, but do you need to specify --dist-dir= twice? Once for bdist_egg and once for bdist_wheel? distutils in its infinite wisdom consumes the optional parameters between each step. Because `bdist_egg` and `bdist_wheel` are separate steps, they both need their own --dist-dir. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review49824 --- On Aug. 6, 2014, 10:35 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 6, 2014, 10:35 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac 8fb0a3a794db4d3671243d06ff45232eae53c27b mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 39af0365e429b8d08addadb09ee18080a19625f8 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [24264] Failed command: git apply --index 24264.patch Error: error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz' error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz' error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz' error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz' error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply The files are in the patch. Did I miss something? - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review49607 --- On Aug. 4, 2014, 9:37 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 4, 2014, 9:37 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 5, 2014, 8:10 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs (updated) - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am c741cdc9d59ad2c4e3132b080a8fcdd517942aa5 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
On Aug. 5, 2014, 4:11 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [24264] Failed command: git apply --index 24264.patch Error: error: missing binary patch data for '3rdparty/pip-1.5.6.tar.gz' error: binary patch does not apply to '3rdparty/pip-1.5.6.tar.gz' error: 3rdparty/pip-1.5.6.tar.gz: patch does not apply error: missing binary patch data for '3rdparty/wheel-0.24.0.tar.gz' error: binary patch does not apply to '3rdparty/wheel-0.24.0.tar.gz' error: 3rdparty/wheel-0.24.0.tar.gz: patch does not apply Thomas Rampelberg wrote: The files are in the patch. Did I miss something? Vinod Kone wrote: i suspect it's because of the binary files not being present in the diff. i remember we had this issue before. @benh: do you remember how to upload binary files to the diff? I did a `git diff --full-index --binary master` and it looks like the patch includes the actual bytes. We'll see if reviewbot likes that or not. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/#review49607 --- On Aug. 5, 2014, 8:10 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 5, 2014, 8:10 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am c741cdc9d59ad2c4e3132b080a8fcdd517942aa5 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- `make distcheck -j6` Thanks, Thomas Rampelberg
Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- Review request for mesos. Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 4, 2014, 9:36 p.m.) Review request for mesos. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 4, 2014, 9:37 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing (updated) --- `make distcheck -j6` Thanks, Thomas Rampelberg
Re: Review Request 24264: Installed python libraries during make install.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24264/ --- (Updated Aug. 4, 2014, 9:37 p.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-899 https://issues.apache.org/jira/browse/MESOS-899 Repository: mesos-git Description --- Because eggs are impossible to uninstall, pip + wheel has been added as a packaging format. The wheels are generated in addition to eggs and then subsequently installed/uninstalled. Note that the building of eggs has not been removed. This is because wheels cannot be run in place like eggs are via. modification of PYTHONPATH. The eggs are needed for all the test scripts to run correctly without actually installing anything locally. Diffs - 3rdparty/Makefile.am 70b45fe8b846a2a3fda599c0b5b7cfa5eb7e78e0 3rdparty/pip-1.5.6.tar.gz PRE-CREATION 3rdparty/versions.am cd7c1cf087dbcfd385ac33145a562764e426c5e5 3rdparty/wheel-0.24.0.tar.gz PRE-CREATION configure.ac a9cc6df5869616e9fe17fd68b88ee23e9a5ada15 mpi/mpiexec-mesos.in 8812ee28c1f845bc3de40ffbf9e9d18033e450f2 src/Makefile.am 0d9e3f072f055963016c8d8e7176b5e0b6e5c8d7 src/examples/python/test-containerizer.in f71828db98a90f455c88d90cb4e3320b7e8c9e9e src/examples/python/test-executor.in b22e7a7dc0c26f805eb63c7139066ce7dc830636 src/examples/python/test-framework.in 64fb1ddc1a0e5772c12d7497dfc1cf6ca2a7dceb Diff: https://reviews.apache.org/r/24264/diff/ Testing --- Thanks, Thomas Rampelberg
Review Request 24292: Forced mesos_pb2 to be generated in a flat fashion.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24292/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: mesos-git Description --- This fixes the regression caused by https://reviews.apache.org/r/23704/ Diffs - src/Makefile.am 04be4e0892c9d592b0880edddcd4c28896cc8dd1 Diff: https://reviews.apache.org/r/24292/diff/ Testing --- make python/interface/src/mesos/interface/mesos_pb2.py Thanks, Thomas Rampelberg
Re: Python bindings are changing!
You'll want to match the python bindings to your mesos version as the functionality is coming from libmesos itself. It might work to use 0.19 with a 0.20 mesos (or visa versa), but there be dragons =) On Fri, Aug 1, 2014 at 1:30 PM, Jie Yu yujie@gmail.com wrote: Thomas, Thank you for the heads-up. One question: what if mesos and python binding have different versions? For example, is it ok to use a 0.19.0 python binding and having a 0.20.0 mesos? Same question for the reverse. - Jie On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg tho...@saunter.org wrote: - What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be distributed easily. This forces python projects using mesos to copy protobufs around and forces a onerous dependency on anyone who would like to do a pure python binding. - How was this problem solved? The current python package has been split into two separate packages: - mesos.interface (stub implementations and protobufs) - mesos.native (old _mesos module) These are python meta-packages and can be installed as separate pieces. The `mesos.interface` package will be hosted on pypi and can be installed via. easy_install and pip. See https://issues.apache.org/jira/browse/MESOS-857 and https://reviews.apache.org/r/23224/. - Why should I care? These changes are not backwards compatible. With 0.20.0 you will need to change how you use the python bindings. Here's a quick overview: mesos.Scheduler - mesos.interface.Scheduler mesos.mesos_pb2 - mesos.interface.mesos_pb2 mesos.MesosSchedulerDriver - mesos.native.MesosSchedulerDriver For more details, you can take a look at the examples in `src/examples/python.
Python bindings are changing!
- What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be distributed easily. This forces python projects using mesos to copy protobufs around and forces a onerous dependency on anyone who would like to do a pure python binding. - How was this problem solved? The current python package has been split into two separate packages: - mesos.interface (stub implementations and protobufs) - mesos.native (old _mesos module) These are python meta-packages and can be installed as separate pieces. The `mesos.interface` package will be hosted on pypi and can be installed via. easy_install and pip. See https://issues.apache.org/jira/browse/MESOS-857 and https://reviews.apache.org/r/23224/. - Why should I care? These changes are not backwards compatible. With 0.20.0 you will need to change how you use the python bindings. Here's a quick overview: mesos.Scheduler - mesos.interface.Scheduler mesos.mesos_pb2 - mesos.interface.mesos_pb2 mesos.MesosSchedulerDriver - mesos.native.MesosSchedulerDriver For more details, you can take a look at the examples in `src/examples/python.
Re: Python bindings are changing!
`pip install mesos.interface` now works =) On Fri, Aug 1, 2014 at 9:37 AM, Thomas Rampelberg tho...@saunter.org wrote: - What problem are we trying to solve? Currently, the python bindings group protobufs, stub implementations and compiled code into a single python package that cannot be distributed easily. This forces python projects using mesos to copy protobufs around and forces a onerous dependency on anyone who would like to do a pure python binding. - How was this problem solved? The current python package has been split into two separate packages: - mesos.interface (stub implementations and protobufs) - mesos.native (old _mesos module) These are python meta-packages and can be installed as separate pieces. The `mesos.interface` package will be hosted on pypi and can be installed via. easy_install and pip. See https://issues.apache.org/jira/browse/MESOS-857 and https://reviews.apache.org/r/23224/. - Why should I care? These changes are not backwards compatible. With 0.20.0 you will need to change how you use the python bindings. Here's a quick overview: mesos.Scheduler - mesos.interface.Scheduler mesos.mesos_pb2 - mesos.interface.mesos_pb2 mesos.MesosSchedulerDriver - mesos.native.MesosSchedulerDriver For more details, you can take a look at the examples in `src/examples/python.
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 31, 2014, 10:05 p.m.) Review request for mesos. Changes --- Of course bsd and gnu find aren't the same. No need for crazy regex, just use -o instead. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated Aug. 1, 2014, 12:41 a.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_modules.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated Aug. 1, 2014, 1:39 a.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_modules.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated Aug. 1, 2014, 1:58 a.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_modules.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 29, 2014, 6:39 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 29, 2014, 6:47 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing (updated) --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 29, 2014, 6:47 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 29, 2014, 6:48 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/setup.py.in PRE-CREATION src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- - `make distcheck -j6` (note that this runs the actual python framework tests) - `import mesos.native` - `python setup.py sdist bdist_egg register upload` `pip install mesos.interface` Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 28, 2014, 5:39 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 28, 2014, 5:40 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description (updated) --- The existing module has been split into two separate ones: - mesos.interface - This contains the stub implementations for the Executor/Scheduler as well as the protobufs. - mesos.native - The old _mesos module. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.interface can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am b660d912c92594ef679b71caf508134f20511dae src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: Looks good Thomas, just a few cleanups and we'll get this committed! Also, I still have a few questions regarding the naming/structure of the modules. ;-) In particular, if we didn't have a native component, would we still create sub modules and an empty metapackage? Or at that point would we just put everything inside of the 'mesos' module (including the protobufs). Given that we'll be killing the native component in due time I don't want us to do something that is specific to that now. Thomas Rampelberg wrote: I still like having the sub-modules. It might be overly-verbose, but it is nice to have the protobufs and general interface stuff moved away out of the main package (freeing the main package up for the interface that external users would use). Using meta-packages, we can fold everything back to a single mesos module in the future when it makes sense as most people will be doing `pip install mesos` to begin with. Brian Wickman wrote: I also like the submodules, since it means things like pesos can just pull in mesos.api (or whatever it's eventually called) which is just a dependency-free interface. We can always choose to consolidate later. Since it has come up a couple times now, `interface` won't be the only mesos submodule. This whole patch is in preparation of the new cli. It will now be able to live in the `cli` module. In the future, we'll be able to have a `native` implementation of the driver as well as a `pure` one. Because they're all submodules, you'll be able to pick and choose between which you'd like to use. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review48480 --- On July 25, 2014, 6:41 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 25, 2014, 6:41 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/interface/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: Looks good Thomas, just a few cleanups and we'll get this committed! Also, I still have a few questions regarding the naming/structure of the modules. ;-) In particular, if we didn't have a native component, would we still create sub modules and an empty metapackage? Or at that point would we just put everything inside of the 'mesos' module (including the protobufs). Given that we'll be killing the native component in due time I don't want us to do something that is specific to that now. I still like having the sub-modules. It might be overly-verbose, but it is nice to have the protobufs and general interface stuff moved away out of the main package (freeing the main package up for the interface that external users would use). Using meta-packages, we can fold everything back to a single mesos module in the future when it makes sense as most people will be doing `pip install mesos` to begin with. On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: src/Makefile.am, line 967 https://reviews.apache.org/r/23224/diff/9/?file=625487#file625487line967 Does this only delete stuff in the 'python' directory? Or throughout all of 'src'? Only in the python directory. On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: src/python/native/setup.py.in, line 17 https://reviews.apache.org/r/23224/diff/9/?file=625507#file625507line17 Why import this versus keeping this inline in one file? I was trying to make the file a little bit cleaner and separate the building of the extension from the actual setup. At this point, I'm not sure that makes sense anymore. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review48480 --- On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 8, 2014, 5:58 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: src/Makefile.am, lines 939-941 https://reviews.apache.org/r/23224/diff/9/?file=625487#file625487line939 Weird indenting here? -1 space maybe? No, these are all dep targets for make. Is there a better syntax for this? On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote: src/python/native/setup.py.in, line 17 https://reviews.apache.org/r/23224/diff/9/?file=625507#file625507line17 Why import this versus keeping this inline in one file? Thomas Rampelberg wrote: I was trying to make the file a little bit cleaner and separate the building of the extension from the actual setup. At this point, I'm not sure that makes sense anymore. After trying to merge them again ... I really like having it separate, cleans the code up and keeps all that nastiness out of the main setup file (making it look very similar to the template that the rest use). - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review48480 --- On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 8, 2014, 5:58 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Mesos language bindings in the wild
I've started preparing the python bindings to hopefully take this route ( https://reviews.apache.org/r/23224/ would love some reviews! ). In fact, there is already a native python implementation of both libprocess and the framework apis! (https://github.com/wickman/pesos/ , https://github.com/wickman/compactor ). What are the benefits of bindings being part of the project source itself instead of having blessed implementations like mesos-python where the source and versioning becomes separate? I've been running into difficulties making automake and python's build tools play nicely together. It seems like there'd be more flexibility in general by splitting them out. On Thu, Jul 10, 2014 at 3:57 PM, Niklas Nielsen nik...@mesosphere.io wrote: I just wanted to clarify - native, meaning _no_ dependency to libmesos and native to its language (only Go, only Python and so on) i.e. use the low-level API. Sorry for the confusion, Niklas On 10 July 2014 15:55, Dominic Hamon dha...@twopensource.com wrote: In my dream world, we wouldn't need any native bindings. I can imagine having example frameworks or starter frameworks that use the low-level API (the wire protocol with protocol buffers for message passing), but nothing like we have that needs C or JNI, etc. On Thu, Jul 10, 2014 at 3:26 PM, Niklas Nielsen nik...@mesosphere.io wrote: Hi all, I wanted to start a discussion around the language bindings in the wild (Go, Haskell, native Python, Go, Java and so on) and possibly get to a strategy where we start bringing those into Mesos proper. As most things points towards, it will probably make sense to focus on the native bindings leveraging the low-level API. To name one candidate to start with, we are especially interested in getting Go native support in Mesos proper (and in a solid state). So Vladimir, we'd be super thrilled to start collaborating with you on your current work. We are interested to hear what thoughts you all might have on this. Thanks, Niklas
Re: Mesos language bindings in the wild
I guess one argument is that you have more fragmentation of the code (e.g every library has it's own copy of the protos) but I'm not sure that's a bad thing. I'd planned on having mesos be a submodule. That way, you'll get the correct protos without any duplication.
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 8, 2014, 5:05 p.m.) Review request for mesos. Changes --- Alright, should be passing `distcheck` now. I'd appreciate some eyes so that this can get merged in. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 8, 2014, 5:20 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [23224]
Failed command: make -j3 distcheck
Error:
if test -d mesos-0.20.0; then find mesos-0.20.0 -type d ! -perm -200
-exec chmod u+w {} ';' rm -rf mesos-0.20.0 || { sleep 5 rm -rf
mesos-0.20.0; }; else :; fi
test -d mesos-0.20.0 || mkdir mesos-0.20.0
(cd 3rdparty make top_distdir=../mesos-0.20.0
distdir=../mesos-0.20.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd libprocess make top_distdir=../../mesos-0.20.0
distdir=../../mesos-0.20.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[2]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d ../../mesos-0.20.0/3rdparty/libprocess || mkdir
../../mesos-0.20.0/3rdparty/libprocess
(cd 3rdparty make top_distdir=../../../mesos-0.20.0
distdir=../../../mesos-0.20.0/3rdparty/libprocess/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[3]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
(cd stout make top_distdir=../../../../mesos-0.20.0
distdir=../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[4]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d ../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout ||
mkdir ../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout
test -n : \
|| find ../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r
../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout
make[4]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[3]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
test -n : \
|| find ../../mesos-0.20.0/3rdparty/libprocess -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
! -type d ! -perm -400 -exec chmod a+r {} \; -o \
! -type d ! -perm -444 -exec /bin/bash
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
-c -m a+r {} {} \; \
|| chmod -R a+r ../../mesos-0.20.0/3rdparty/libprocess
make[2]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
(cd src make top_distdir=../mesos-0.20.0 distdir=../mesos-0.20.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=:
distdir)
make[1]: Entering directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
/bin/mkdir -p python/src/mesos
/bin/mkdir -p python/api/src/mesos
/bin/mkdir -p python/api/src/mesos/api
cp -pf ./python/api/src/mesos/api/__init__.py
python/api/src/mesos/api/__init__.py
cp -pf ./python/src/mesos/__init__.py python/src/mesos/__init__.py
cp -pf ./python/api/src/mesos/__init__.py python/api/src/mesos/__init__.py
cp: `./python/src/mesos/__init__.py' and `python/src/mesos/__init__.py' are
the same file
cp: cp: `./python/api/src/mesos/__init__.py' and
`python/api/src/mesos/__init__.py' are the same
file`./python/api/src/mesos/api/__init__.py' and
`python/api/src/mesos/api/__init__.py' are the same file
make[1]: *** [python/src/mesos/__init__.py] Error 1
make[1]: *** Waiting for unfinished jobs
make[1]: *** [python/api/src/mesos/api/__init__.py] Error 1
make[1]: *** [python/api/src/mesos/__init__.py] Error 1
make[1]: Leaving directory
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make: *** [distdir] Error 1
Or, I continue to fight with distcheck, *shakes fist*
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47454
---
On July 8, 2014, 5:05 p.m., Thomas Rampelberg wrote
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 8, 2014, 5:58 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 3, 2014, 5:25 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Build Issue?
I have a patch that splits the python module out into separate packages (so that people can pick and choose what they want) (https://reviews.apache.org/r/23224/). Locally, this all builds just fine. Unfortunately, remotely, reviewbot is complaining: cp: cannot stat `../../src/python/protocol/src/mesos/__init__.py': No such file or directory In `src/Makefile.am` I have the following: python/protocol/src/mesos/__init__.py: $(PYTHON_PROTOS) cp $(srcdir)/$@ $@ Any suggestions? I can't figure out why it isn't working for the life of me.
Re: Build Issue?
I thought it was, on a fresh checkout it didn't though! I've got a path to follow now. Thanks for the tip :) On Thursday, July 3, 2014, Vinod Kone vinodk...@gmail.com wrote: does 'make distcheck' work for you? On Thu, Jul 3, 2014 at 3:33 PM, Thomas Rampelberg tho...@saunter.org javascript:; wrote: I have a patch that splits the python module out into separate packages (so that people can pick and choose what they want) (https://reviews.apache.org/r/23224/). Locally, this all builds just fine. Unfortunately, remotely, reviewbot is complaining: cp: cannot stat `../../src/python/protocol/src/mesos/__init__.py': No such file or directory In `src/Makefile.am` I have the following: python/protocol/src/mesos/__init__.py: $(PYTHON_PROTOS) cp $(srcdir)/$@ $@ Any suggestions? I can't figure out why it isn't working for the life of me.
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 2, 2014, 6:17 p.m., Brian Wickman wrote: This seems to be missing the setup.py(.in)s from mesos.api, mesos.native, mesos.protocol. Forget to git add? Otherwise this is looking great! Argh, how'd I miss those. Thanks! - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review47213 --- On July 2, 2014, 8:36 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 2, 2014, 8:36 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 2, 2014, 8:46 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 2, 2014, 11:53 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 3, 2014, 12:10 a.m., Brian Wickman wrote: src/python/native/setup.py.in, line 29 https://reviews.apache.org/r/23224/diff/4/?file=623204#file623204line29 what's your philosophy on versioning here? should we always require deps==version or just deps=major,major+1 or similar? can always punt for later. At the moment, the separate modules all have versions identical to mesos' (PACKAGE_VERSION). While I'm not sure that is the correct decision in the long term, it works for now. Given that, it seems to make sense to me that the inter-dependencies are `deps==version` (as they're all fixed to the mesos version itself). - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review47259 --- On July 2, 2014, 11:53 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 2, 2014, 11:53 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 3, 2014, 12:10 a.m., Brian Wickman wrote: src/Makefile.am, line 137 https://reviews.apache.org/r/23224/diff/1/?file=622309#file622309line137 i would love to see all protos contained here, including messages protos. this will allow for the development of a pure python api. mind adding those? or possibly create a mesos.api_internal? Would you open a new JIRA for that? I'd like to have a separate patch for that. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review47259 --- On July 2, 2014, 11:53 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 2, 2014, 11:53 p.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
On July 3, 2014, 12:10 a.m., Brian Wickman wrote: src/python/protocol/setup.py.in, line 27 https://reviews.apache.org/r/23224/diff/4/?file=623207#file623207line27 same here, to be conservative, might want protobuf=2.5.0,3 Good call. On July 3, 2014, 12:10 a.m., Brian Wickman wrote: src/python/native/ext_def.py.in, line 1 https://reviews.apache.org/r/23224/diff/4/?file=623193#file623193line1 not sure about process but does this need the ASF license headers? Added. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/#review47259 --- On July 3, 2014, 12:46 a.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 3, 2014, 12:46 a.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- (Updated July 3, 2014, 12:46 a.m.) Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs (updated) - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/setup.py.in PRE-CREATION src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/ext_def.py.in PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/setup.py.in PRE-CREATION src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/setup.py.in PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
Review Request 23224: Refactored the python bindings into multiple modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23224/ --- Review request for mesos. Bugs: MESOS-857 https://issues.apache.org/jira/browse/MESOS-857 Repository: mesos-git Description --- The existing module has been split into three separate ones: - mesos.api - This contains the stub implementations for the Executor/Scheduler - mesos.native - The old _mesos module. - mesos.protocol - All protobufs. There is also a base metapackage `mesos` that allows a potential `pip install mesos` to correctly install everything required. While mesos.api and mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not changed and will need some more work first. Diffs - Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 src/Makefile.am 918b0d04a5de69a9213e3d31c8f9424756e4ade5 src/examples/python/test-containerizer.in 569519b3b9755959f9bf931d3c81be9a00b64bc9 src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 src/examples/python/test-framework.in c4683b97b87ba8753e842b0c75cc3d65140a5cf7 src/examples/python/test_containerizer.py c65d891539bcee775741626596997afe8471c930 src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 src/examples/python/test_framework.py fce090fe542e3863770d7daea3d8764da1d8d5df src/python/api/src/mesos/__init__.py PRE-CREATION src/python/native/mesos_executor_driver_impl.hpp src/python/native/mesos_executor_driver_impl.cpp src/python/native/mesos_scheduler_driver_impl.hpp src/python/native/mesos_scheduler_driver_impl.cpp src/python/native/module.hpp src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 src/python/native/proxy_executor.hpp src/python/native/proxy_executor.cpp src/python/native/proxy_scheduler.hpp src/python/native/proxy_scheduler.cpp src/python/native/src/mesos/__init__.py PRE-CREATION src/python/native/src/mesos/native/__init__.py PRE-CREATION src/python/protocol/src/mesos/__init__.py PRE-CREATION src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 src/python/src/mesos/__init__.py PRE-CREATION Diff: https://reviews.apache.org/r/23224/diff/ Testing --- Thanks, Thomas Rampelberg
[jira] [Created] (MESOS-1473) Mesos slave becomes unresponsive after launching 8 external containers
Thomas Rampelberg created MESOS-1473:
Summary: Mesos slave becomes unresponsive after launching 8
external containers
Key: MESOS-1473
URL: https://issues.apache.org/jira/browse/MESOS-1473
Project: Mesos
Issue Type: Bug
Components: containerization
Affects Versions: 0.19.0
Reporter: Thomas Rampelberg
After 8 tasks have been launched by marathon/mesos that use external
containerizer, the mesos slave becomes unresponsive and is eventually removed
from the master (requiring a restart of the process).
Replication steps:
:; git clone g...@github.com:mesosphere/playa-mesos.git
:; cd playa-mesos
:; vagrant up
:; vagrant ssh
:; sudo mkdir -p /etc/mesos-slave
:; sudo mkdir -p /etc/mesos-master
:; echo /usr/bin/deimos | sudo dd of=/etc/mesos-slave/containerizer_path
:; echo external | sudo dd of=/etc/mesos-slave/isolation
:; curl -H Content-Type: application/json -X POST localhost:8080/v2/apps -d
'{id: sleep, cmd: while true; do sleep 10;
done,instances:8,cpus:0.1,mem:16.0}'
Once the 8 instances are done launching (you can verify via. `docker ps`),
mesos slave will be completely unresponsive.
Here's a gist with the slave logs during the event:
https://gist.github.com/pyronicide/9dc68332a29faf38c890
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
On Jan. 29, 2014, 8:39 p.m., Ross Allen wrote: src/webui/master/static/index.html, line 65 https://reviews.apache.org/r/17431/diff/11/?file=453075#file453075line65 This can lead to an odd state, although it might be fine for now: 1. Open the config and set the host to something invalid like http://google.com 2. The alert displays, says Failed to connect to google.com ... 3. Click set a new master and delete the value, click Save After the modal closes, the alert now reads Failed to connect to localhost:5050 ... even though it hasn't tried to connect to it yet. Maybe the config modal could poll once on close if the master URL changed? This also might be too nuanced to be worth fixing. It isn't optimal but I'd like to leave it this way for now. If it becomes a huge problem, we can fix it in the future. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review33161 --- On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
On Jan. 29, 2014, 8:34 p.m., Ross Allen wrote: src/webui/master/static/js/controllers.js, line 342 https://reviews.apache.org/r/17431/diff/11/?file=453077#file453077line342 Nuke the console.log for production use. I need a pre-commit lint hook for console.log. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review33160 --- On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 6:45 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 8:46 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments (updated) Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 8:51 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Connection Issue Alert https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png Thanks, Thomas Rampelberg
Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- Review request for mesos. Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Diffs - src/webui/master/static/config.html PRE-CREATION src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 27, 2014, 11:47 p.m.) Review request for mesos. Repository: mesos-git Description (updated) --- Enabled configuration of the mesos master from the UI. This solution is to help out with development and testing of the UI irrespective of Mesos' version. Diffs - src/webui/master/static/config.html PRE-CREATION src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 27, 2014, 11:50 p.m.) Review request for mesos. Repository: mesos-git Description (updated) --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/webui/master/static/config.html PRE-CREATION src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 27, 2014, 11:55 p.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:34 a.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:52 a.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:53 a.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments (updated) Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
On Jan. 28, 2014, 12:45 a.m., Ben Mahler wrote: Screenshots? :) If we were to have a way to spin up the webui standalone, perhaps that's the only time we would want to expose this? I suspect that you're right. The impetus for the feature is having the UI be standalone at least. In general however, there's now a method for allowing local config (Ross' point about timestamps is a great one, I'll move those over). That doesn't mean that we couldn't hide the config menu however. At the moment, I'm treating this as a debug feature more than anything else. For a real standalone solution, I'd personally like to have something a little more usable. - Thomas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32927 --- On Jan. 28, 2014, 12:53 a.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 12:53 a.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 1:44 a.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Thanks, Thomas Rampelberg
Re: Review Request 17431: Enabled configuration of the mesos master from the UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/ --- (Updated Jan. 28, 2014, 1:48 a.m.) Review request for mesos and Ross Allen. Bugs: mesos-885 https://issues.apache.org/jira/browse/mesos-885 Repository: mesos-git Description --- Enabled configuration of the mesos master from the UI. Review: http://reviews.apache.org/r/17431 Diffs (updated) - src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 src/webui/master/static/config.html PRE-CREATION src/webui/master/static/css/mesos.css 5b1227e9d64757f9fc106e497f7fa3ed72112c10 src/webui/master/static/directives/timestamp.html 5e422b9f22f8ddaf987feec3e02a849f21e5e22c src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 src/webui/master/static/js/controllers.js afb24fb9c2184772f7314162f5637dbabaa2ab94 Diff: https://reviews.apache.org/r/17431/diff/ Testing --- File Attachments Config Dialog https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png Thanks, Thomas Rampelberg
