Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review62336
---
Bad patch!
Reviews applied: [27865]
Failed command: ./support/apply-review.sh -n -r 27865
Error:
2014-11-20 08:06:16 URL:https://reviews.apache.org/r/27865/diff/raw/
[2260/2260] - 27865.patch [1]
error: patch failed: 3rdparty/libprocess/src/pid.cpp:64
error: 3rdparty/libprocess/src/pid.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 20, 2014, 1:01 a.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 20, 2014, 1:01 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts. The User-Agent header is left
untouched for backwards compatibility reasons. Even strict HTTP parser
shouldn't error, but just ignore everything between the invalid character and
the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/pid.cpp 20ff25c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 21, 2014, 12:08 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts. The User-Agent header is left untouched for backwards
compatibility reasons. Even strict HTTP parser shouldn't error, but just ignore
everything between the invalid character and the CRLF.
Diffs (updated)
-
3rdparty/libprocess/src/encoder.hpp 2b0d83f
3rdparty/libprocess/src/tests/process_tests.cpp 902d4d3
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 21, 2014, 12:09 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts. The User-Agent header is left untouched for backwards
compatibility reasons. Even strict HTTP parser shouldn't error, but just ignore
everything between the invalid character and the CRLF.
Diffs (updated)
-
3rdparty/libprocess/src/encoder.hpp 2b0d83f
3rdparty/libprocess/src/tests/process_tests.cpp 902d4d3
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 21, 2014, 1:04 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description (updated)
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds the Libprocess-From header. The User-Agent header is
left untouched for backwards compatibility reasons. Even strict HTTP parser
shouldn't error, but just ignore everything between the invalid character and
the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 2b0d83f
3rdparty/libprocess/src/tests/process_tests.cpp 902d4d3
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review62480
---
Patch looks great!
Reviews applied: [27865]
All tests passed.
- Mesos ReviewBot
On Nov. 21, 2014, 1:04 a.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 21, 2014, 1:04 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds the Libprocess-From header. The
User-Agent header is left untouched for backwards compatibility reasons. Even
strict HTTP parser shouldn't error, but just ignore everything between the
invalid character and the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 2b0d83f
3rdparty/libprocess/src/tests/process_tests.cpp 902d4d3
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review62496
---
Ship it!
I'll get this committed, thanks Dario!
- Benjamin Hindman
On Nov. 21, 2014, 1:04 a.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 21, 2014, 1:04 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds the Libprocess-From header. The
User-Agent header is left untouched for backwards compatibility reasons. Even
strict HTTP parser shouldn't error, but just ignore everything between the
invalid character and the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 2b0d83f
3rdparty/libprocess/src/tests/process_tests.cpp 902d4d3
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review62279
---
This is great! The continuation of the Libproces-From work from before. ;-)
3rdparty/libprocess/src/encoder.hpp
https://reviews.apache.org/r/27865/#comment104302
s/in_addr */in_addr*/
And double check the place you copied the code from to fix it too. ;-)
3rdparty/libprocess/src/encoder.hpp
https://reviews.apache.org/r/27865/#comment104301
If we can use 'Libprocess-From' that would be preferred since we've already
introduced it (but if we can't because of HTTP restrictions on header
field-value let me know).
- Benjamin Hindman
On Nov. 13, 2014, 8:27 p.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 13, 2014, 8:27 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts. The User-Agent header is left
untouched for backwards compatibility reasons. Even strict HTTP parser
shouldn't error, but just ignore everything between the invalid character and
the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 20, 2014, 1:01 a.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts. The User-Agent header is left untouched for backwards
compatibility reasons. Even strict HTTP parser shouldn't error, but just ignore
everything between the invalid character and the CRLF.
Diffs (updated)
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/pid.cpp 20ff25c
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 13, 2014, 8:27 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
---
Making @benjaminhindman as shepherd as he is more familiar with this code base.
-- @vinodkone
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts. The User-Agent header is left untouched for backwards
compatibility reasons. Even strict HTTP parser shouldn't error, but just ignore
everything between the invalid character and the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 12, 2014, 1:09 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description (updated)
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts.
edit: The User-Agent header is left untouched for backwards compatibility
reasons. Even strict HTTP parser shouldn't error, but just ignore everything
between the invalid character and the CRLF.
Diffs (updated)
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review60983
---
Ship it!
Ship It!
- Alexander Rukletsov
On Nov. 12, 2014, 1:09 p.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 12, 2014, 1:09 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts.
edit: The User-Agent header is left untouched for backwards compatibility
reasons. Even strict HTTP parser shouldn't error, but just ignore everything
between the invalid character and the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 12, 2014, 1:53 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description (updated)
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts. The User-Agent header is left untouched for backwards
compatibility reasons. Even strict HTTP parser shouldn't error, but just ignore
everything between the invalid character and the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review60984
---
Patch looks great!
Reviews applied: [27865]
All tests passed.
- Mesos ReviewBot
On Nov. 12, 2014, 1:53 p.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 12, 2014, 1:53 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts. The User-Agent header is left
untouched for backwards compatibility reasons. Even strict HTTP parser
shouldn't error, but just ignore everything between the invalid character and
the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review61005
---
3rdparty/libprocess/src/encoder.hpp
https://reviews.apache.org/r/27865/#comment102462
Have you run mesos-style.py? Looks like this line exceeds 80 columns.
We tend to stick pointer * and reference to the type, to is becomes
(in_addr*)
More high-level comment: try to take a look at
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp#L312
You should be able to use the IP class alongside the operator overload
- Niklas Nielsen
On Nov. 12, 2014, 5:53 a.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 12, 2014, 5:53 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts. The User-Agent header is left
untouched for backwards compatibility reasons. Even strict HTTP parser
shouldn't error, but just ignore everything between the invalid character and
the CRLF.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review60781
---
3rdparty/libprocess/src/encoder.hpp
https://reviews.apache.org/r/27865/#comment102189
Wrap if-body in parenthethis.
- Alexander Rukletsov
On Nov. 11, 2014, 1:48 p.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 11, 2014, 1:48 p.m.)
Review request for mesos.
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/#review60783
---
Patch looks great!
Reviews applied: [27865]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2014, 1:48 p.m., Dario Rexin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 11, 2014, 1:48 p.m.)
Review request for mesos.
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP
1.0, which has only been added in HTTP 1.1. Additionally it stores the PID in
the User-Agent field with an incompatibe format ('@' and ':' are not
allowed). This patch sets the HTTP version to 1.1, adds an empty Host header
(Host is mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip,
X-Mesos-Port containing the PID parts.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
Re: Review Request 27865: Made libprocess generate valid http.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27865/
---
(Updated Nov. 11, 2014, 11:13 a.m.)
Review request for mesos and Vinod Kone.
Changes
---
adding bug reference and added reviewer.
fwiw, #shipit pending the if statement braces.
Bugs: MESOS-2071
https://issues.apache.org/jira/browse/MESOS-2071
Repository: mesos-git
Description
---
While working on a pure Scala driver for Mesos, I discovered that libprocess
does not generate valid HTTP. It uses chunked encoding combined with HTTP 1.0,
which has only been added in HTTP 1.1. Additionally it stores the PID in the
User-Agent field with an incompatibe format ('@' and ':' are not allowed). This
patch sets the HTTP version to 1.1, adds an empty Host header (Host is
mandatory in 1.1) and adds 3 new fields: X-Mesos-Id, X-Mesos-Ip, X-Mesos-Port
containing the PID parts.
Diffs
-
3rdparty/libprocess/src/encoder.hpp 9c5aa81
3rdparty/libprocess/src/tests/process_tests.cpp b985fb7
Diff: https://reviews.apache.org/r/27865/diff/
Testing
---
- ran `make check` on Linux and OSX
- setup a cluster consisting of 1 Master, 1 Slave and 1 Marathon instance,
deployed a couple of tasks and destroyed them afterwards
Thanks,
Dario Rexin
