subject:"Review Request 23224\: Refactored the python bindings into multiple modules."

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-08-01 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review49334
---


Patch looks great!

Reviews applied: [23224]

All tests passed.

- Mesos ReviewBot


On Aug. 1, 2014, 2:26 a.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated Aug. 1, 2014, 2:26 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into two separate ones:
> 
> - mesos.interface - This contains the stub implementations for the 
> Executor/Scheduler as well as the protobufs.
> - mesos.native - The old _mesos module.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.interface can 
> now be uploaded to the cheeseshop, mesos.native has not changed and will need 
> some more work first.
> 
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/interface/setup.py.in PRE-CREATION 
>   src/python/interface/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_modules.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> - `make distcheck -j6` (note that this runs the actual python framework tests)
> - `import mesos.native`
> - `python setup.py sdist bdist_egg register upload` && `pip install 
> mesos.interface`
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Benjamin Hindman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review49319
---

Ship it!


Rad Thomas! Can you draft a note to the dev/user lists giving people a heads up 
that this will hit master and folks that are using/running Python off of master 
will need to upgrade. Thanks!

- Benjamin Hindman


On Aug. 1, 2014, 2:26 a.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated Aug. 1, 2014, 2:26 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into two separate ones:
> 
> - mesos.interface - This contains the stub implementations for the 
> Executor/Scheduler as well as the protobufs.
> - mesos.native - The old _mesos module.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.interface can 
> now be uploaded to the cheeseshop, mesos.native has not changed and will need 
> some more work first.
> 
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/interface/setup.py.in PRE-CREATION 
>   src/python/interface/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_modules.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> - `make distcheck -j6` (note that this runs the actual python framework tests)
> - `import mesos.native`
> - `python setup.py sdist bdist_egg register upload` && `pip install 
> mesos.interface`
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated Aug. 1, 2014, 2:26 a.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_modules.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated Aug. 1, 2014, 1:58 a.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_modules.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated Aug. 1, 2014, 1:39 a.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_modules.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review49316
---


Patch looks great!

Reviews applied: [23224]

All tests passed.

- Mesos ReviewBot


On Aug. 1, 2014, 1:39 a.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated Aug. 1, 2014, 1:39 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into two separate ones:
> 
> - mesos.interface - This contains the stub implementations for the 
> Executor/Scheduler as well as the protobufs.
> - mesos.native - The old _mesos module.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.interface can 
> now be uploaded to the cheeseshop, mesos.native has not changed and will need 
> some more work first.
> 
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/interface/setup.py.in PRE-CREATION 
>   src/python/interface/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_modules.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp f523c1f3a5b62413ec01e5101c680c30980874dc 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> - `make distcheck -j6` (note that this runs the actual python framework tests)
> - `import mesos.native`
> - `python setup.py sdist bdist_egg register upload` && `pip install 
> mesos.interface`
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated Aug. 1, 2014, 12:41 a.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_modules.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated Aug. 1, 2014, 12:35 a.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-31 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 31, 2014, 10:05 p.m.)


Review request for mesos.


Changes
---

Of course bsd and gnu find aren't the same. No need for crazy regex, just use 
-o instead.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-29 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 29, 2014, 6:48 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-29 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 29, 2014, 6:47 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  docs/upgrades.md 919f0108655568d91060e6db998094e6dc39127b 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-29 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 29, 2014, 6:47 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing (updated)
---

- `make distcheck -j6` (note that this runs the actual python framework tests)
- `import mesos.native`
- `python setup.py sdist bdist_egg register upload` && `pip install 
mesos.interface`


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-29 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 29, 2014, 6:39 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/setup.py.in PRE-CREATION 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-28 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48974
---


Bad patch!

Reviews applied: [23224]

Failed command: ./bootstrap

Error:
 autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:45: warning: back quotes and double quotes must not be escaped in: 
unrecognized option: $[1]
configure.ac:45: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:45: the top level
configure.ac:45: warning: back quotes and double quotes must not be escaped in: 
unrecognized argument: $[1]
configure.ac:45: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:45: the top level
configure.ac:395: warning: The macro `AC_LANG_SAVE' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/lang.m4:126: AC_LANG_SAVE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:395: warning: The macro `AC_LANG_C' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/c.m4:73: AC_LANG_C is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:395: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:395: warning: The macro `AC_LANG_RESTORE' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/lang.m4:135: AC_LANG_RESTORE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:722: warning: The macro `AC_PYTHON_DEVEL' is obsolete.
configure.ac:722: You should run autoupdate.
m4/ax_python_devel.m4:72: AC_PYTHON_DEVEL is expanded from...
configure.ac:722: the top level
autoreconf: configure.ac: adding subdirectory 3rdparty/libprocess to autoreconf
autoreconf: Entering directory `3rdparty/libprocess'
configure.ac:29: warning: back quotes and double quotes must not be escaped in: 
unrecognized option: $[1]
configure.ac:29: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:29: the top level
configure.ac:29: warning: back quotes and double quotes must not be escaped in: 
unrecognized argument: $[1]
configure.ac:29: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:29: the top level
configure.ac:333: warning: The macro `AC_LANG_SAVE' is obsolete.
configure.ac:333: You should run autoupdate.
../../lib/autoconf/lang.m4:126: AC_LANG_SAVE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:333: the top level
configure.ac:333: warning: The macro `AC_LANG_C' is obsolete.
configure.ac:333: You should run autoupdate.
../../lib/autoconf/c.m4:73: AC_LANG_C is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:333: the top level
configure.ac:333: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:333: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:333: the top level
configure.ac:333: warning: The macro `AC_LANG_RESTORE' is obsolete.
configure.ac:333: You should run autoupdate.
../../lib/autoconf/lang.m4:135: AC_LANG_RESTORE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:333: the top level
autoreconf: configure.ac: adding subdirectory 3rdparty/stout to autoreconf
autoreconf: Entering directory `3rdparty/stout'
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf --warnings=all
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:10: installing `./missing'
autoreconf: Leaving directory `3rdparty/stout'
autoreconf: running: libtoolize --install --copy
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./config.guess'
libtoolize: copying file `./config.sub'
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: You should add the contents of `m4/libtool.m4' to `aclocal.m4'.
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: You should add the contents of `m4/ltoptions.m4' to `aclocal.m4'.
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: You should add the contents of `m4/ltsugar.m4' to `aclocal.m4'.
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~o

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-28 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 28, 2014, 9:24 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-28 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 28, 2014, 5:40 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description (updated)
---

The existing module has been split into two separate ones:

- mesos.interface - This contains the stub implementations for the 
Executor/Scheduler as well as the protobufs.
- mesos.native - The old _mesos module.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.interface can now 
be uploaded to the cheeseshop, mesos.native has not changed and will need some 
more work first.



Diffs
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-28 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 28, 2014, 5:39 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am b660d912c92594ef679b71caf508134f20511dae 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in 60add3b39d09dc5a1b74764b2b6c4b3c461f150a 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-26 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48813
---


Bad patch!

Reviews applied: [23224]

Failed command: git apply --index 23224.patch

Error:
 error: patch failed: src/Makefile.am:913
error: src/Makefile.am: patch does not apply
error: patch failed: src/python/setup.py.in:1
error: src/python/setup.py.in: patch does not apply


- Mesos ReviewBot


On July 25, 2014, 6:41 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 25, 2014, 6:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/interface/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-25 Thread Thomas Rampelberg



> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > Looks good Thomas, just a few cleanups and we'll get this committed!
> > 
> > Also, I still have a few questions regarding the naming/structure of the 
> > modules. ;-)
> > 
> > In particular, if we didn't have a native component, would we still create 
> > sub modules and an "empty" metapackage? Or at that point would we just put 
> > everything inside of the 'mesos' module (including the protobufs). Given 
> > that we'll be killing the native component in due time I don't want us to 
> > do something that is specific to that now.
> 
> Thomas Rampelberg wrote:
> I still like having the sub-modules. It might be overly-verbose, but it 
> is nice to have the protobufs and general interface stuff moved away out of 
> the main package (freeing the main package up for the interface that external 
> users would use).
> 
> Using meta-packages, we can fold everything back to a single mesos module 
> in the future when it makes sense as most people will be doing `pip install 
> mesos` to begin with.
> 
> Brian Wickman wrote:
> I also like the submodules, since it means things like pesos can just 
> pull in mesos.api (or whatever it's eventually called) which is just a 
> dependency-free interface.  We can always choose to consolidate later.

Since it has come up a couple times now, `interface` won't be the only mesos 
submodule. This whole patch is in preparation of the new cli. It will now be 
able to live in the `cli` module. In the future, we'll be able to have a 
`native` implementation of the driver as well as a `pure` one. Because they're 
all submodules, you'll be able to pick and choose between which you'd like to 
use.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---


On July 25, 2014, 6:41 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 25, 2014, 6:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/interface/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-25 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 25, 2014, 6:41 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/interface/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-25 Thread Thomas Rampelberg



> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 966
> > 
> >
> > Doesn't this delete the setup.py that got generated by configure?

Isn't that the way it is supposed to work? At this point, the `setup.py` 
doesn't appear to exist in the build directory and all the files get 
re-generated and copied over during the preceding build steps.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---


On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Thomas Rampelberg



> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, lines 939-941
> > 
> >
> > Weird indenting here? -1 space maybe?

No, these are all dep targets for make. Is there a better syntax for this?


> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > src/python/native/setup.py.in, line 17
> > 
> >
> > Why import this versus keeping this inline in one file?
> 
> Thomas Rampelberg wrote:
> I was trying to make the file a little bit cleaner and separate the 
> building of the extension from the actual setup. At this point, I'm not sure 
> that makes sense anymore.

After trying to merge them again ... I really like having it separate, cleans 
the code up and keeps all that nastiness out of the main setup file (making it 
look very similar to the template that the rest use).


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---


On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Thomas Rampelberg



> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > Looks good Thomas, just a few cleanups and we'll get this committed!
> > 
> > Also, I still have a few questions regarding the naming/structure of the 
> > modules. ;-)
> > 
> > In particular, if we didn't have a native component, would we still create 
> > sub modules and an "empty" metapackage? Or at that point would we just put 
> > everything inside of the 'mesos' module (including the protobufs). Given 
> > that we'll be killing the native component in due time I don't want us to 
> > do something that is specific to that now.

I still like having the sub-modules. It might be overly-verbose, but it is nice 
to have the protobufs and general interface stuff moved away out of the main 
package (freeing the main package up for the interface that external users 
would use).

Using meta-packages, we can fold everything back to a single mesos module in 
the future when it makes sense as most people will be doing `pip install mesos` 
to begin with.


> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > src/Makefile.am, line 967
> > 
> >
> > Does this only delete stuff in the 'python' directory? Or throughout 
> > all of 'src'?

Only in the python directory.


> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > src/python/native/setup.py.in, line 17
> > 
> >
> > Why import this versus keeping this inline in one file?

I was trying to make the file a little bit cleaner and separate the building of 
the extension from the actual setup. At this point, I'm not sure that makes 
sense anymore.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---


On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Brian Wickman



> On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
> > Looks good Thomas, just a few cleanups and we'll get this committed!
> > 
> > Also, I still have a few questions regarding the naming/structure of the 
> > modules. ;-)
> > 
> > In particular, if we didn't have a native component, would we still create 
> > sub modules and an "empty" metapackage? Or at that point would we just put 
> > everything inside of the 'mesos' module (including the protobufs). Given 
> > that we'll be killing the native component in due time I don't want us to 
> > do something that is specific to that now.
> 
> Thomas Rampelberg wrote:
> I still like having the sub-modules. It might be overly-verbose, but it 
> is nice to have the protobufs and general interface stuff moved away out of 
> the main package (freeing the main package up for the interface that external 
> users would use).
> 
> Using meta-packages, we can fold everything back to a single mesos module 
> in the future when it makes sense as most people will be doing `pip install 
> mesos` to begin with.

I also like the submodules, since it means things like pesos can just pull in 
mesos.api (or whatever it's eventually called) which is just a dependency-free 
interface.  We can always choose to consolidate later.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---


On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-24 Thread Benjamin Hindman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---


Looks good Thomas, just a few cleanups and we'll get this committed!

Also, I still have a few questions regarding the naming/structure of the 
modules. ;-)

In particular, if we didn't have a native component, would we still create sub 
modules and an "empty" metapackage? Or at that point would we just put 
everything inside of the 'mesos' module (including the protobufs). Given that 
we'll be killing the native component in due time I don't want us to do 
something that is specific to that now.


Makefile.am


Can you kill the whitespace?



src/Makefile.am


Kill whitespace please.



src/Makefile.am


Weird indenting here? -1 space maybe?



src/Makefile.am


Doesn't this delete the setup.py that got generated by configure?



src/Makefile.am


Does this only delete stuff in the 'python' directory? Or throughout all of 
'src'?



src/examples/python/test-framework.in


Every time I see this in this review without a : between PROTOBUF_EGG and 
MESOS_EGGS it seems like a bug and I have to remind myself that above in the 
code you prefixed MESOS_EGGS with :, any reason not to use : in the suffix and 
then force the : between PROTOBUF_EGG and MESOS_EGGS so people don't have to go 
back and look at code to confirm this is correct?



src/python/native/setup.py.in


Why import this versus keeping this inline in one file?



src/python/setup.py.in


Let's use d...@apache.mesos.org (here and everywhere else too).


- Benjamin Hindman


On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   s

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-08 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47461
---


Patch looks great!

Reviews applied: [23224]

All tests passed.

- Mesos ReviewBot


On July 8, 2014, 5:58 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:58 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-08 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 8, 2014, 5:58 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/protocol/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-08 Thread Thomas Rampelberg



> On July 8, 2014, 5:20 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [23224]
> > 
> > Failed command: make -j3 distcheck
> > 
> > Error:
> >  if test -d "mesos-0.20.0"; then find "mesos-0.20.0" -type d ! -perm -200 
> > -exec chmod u+w {} ';' && rm -rf "mesos-0.20.0" || { sleep 5 && rm -rf 
> > "mesos-0.20.0"; }; else :; fi
> > test -d "mesos-0.20.0" || mkdir "mesos-0.20.0"
> >  (cd 3rdparty && make  top_distdir=../mesos-0.20.0 
> > distdir=../mesos-0.20.0/3rdparty \
> >  am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: 
> > distdir)
> > make[1]: Entering directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
> >  (cd libprocess && make  top_distdir=../../mesos-0.20.0 
> > distdir=../../mesos-0.20.0/3rdparty/libprocess \
> >  am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: 
> > distdir)
> > make[2]: Entering directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
> > :
> > test -d "../../mesos-0.20.0/3rdparty/libprocess" || mkdir 
> > "../../mesos-0.20.0/3rdparty/libprocess"
> >  (cd 3rdparty && make  top_distdir=../../../mesos-0.20.0 
> > distdir=../../../mesos-0.20.0/3rdparty/libprocess/3rdparty \
> >  am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: 
> > distdir)
> > make[3]: Entering directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
> >  (cd stout && make  top_distdir=../../../../mesos-0.20.0 
> > distdir=../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout \
> >  am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: 
> > distdir)
> > make[4]: Entering directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
> > :
> > test -d "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout" || 
> > mkdir "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout"
> > test -n ":" \
> > || find "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout" 
> > -type d ! -perm -755 \
> > -exec chmod u+rwx,go+rx {} \; -o \
> >   ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
> >   ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
> >   ! -type d ! -perm -444 -exec /bin/bash 
> > /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
> >  -c -m a+r {} {} \; \
> > || chmod -R a+r 
> > "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout"
> > make[4]: Leaving directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
> > make[3]: Leaving directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
> > test -n ":" \
> > || find "../../mesos-0.20.0/3rdparty/libprocess" -type d ! -perm -755 \
> > -exec chmod u+rwx,go+rx {} \; -o \
> >   ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
> >   ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
> >   ! -type d ! -perm -444 -exec /bin/bash 
> > /home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
> >  -c -m a+r {} {} \; \
> > || chmod -R a+r "../../mesos-0.20.0/3rdparty/libprocess"
> > make[2]: Leaving directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
> > make[1]: Leaving directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
> >  (cd src && make  top_distdir=../mesos-0.20.0 distdir=../mesos-0.20.0/src \
> >  am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: 
> > distdir)
> > make[1]: Entering directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
> > /bin/mkdir -p python/src/mesos
> > /bin/mkdir -p python/api/src/mesos
> > /bin/mkdir -p python/api/src/mesos/api
> > cp -pf ./python/api/src/mesos/api/__init__.py 
> > python/api/src/mesos/api/__init__.py
> > cp -pf ./python/src/mesos/__init__.py python/src/mesos/__init__.py
> > cp -pf ./python/api/src/mesos/__init__.py python/api/src/mesos/__init__.py
> > cp: `./python/src/mesos/__init__.py' and `python/src/mesos/__init__.py' are 
> > the same file
> > cp: cp: `./python/api/src/mesos/__init__.py' and 
> > `python/api/src/mesos/__init__.py' are the same 
> > file`./python/api/src/mesos/api/__init__.py' and 
> > `python/api/src/mesos/api/__init__.py' are the same file
> > 
> > make[1]: *** [python/src/mesos/__init__.py] Error 1
> > make[1]: *** Waiting for unfinished jobs
> > make[1]: *** [python/api/src/mesos/api/__init__.py] Error 1
> > make[1]: *** [python/api/src/mesos/__init__.py] Error 1
> > make[1]: Leaving directory 
> > `/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
> > make: *** [distdir] Error 1
> >

Or, I continue to fight with distcheck, *shakes fist*


- Thomas


---
This is an automatically generated e-mail. To reply,

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-08 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47454
---


Bad patch!

Reviews applied: [23224]

Failed command: make -j3 distcheck

Error:
 if test -d "mesos-0.20.0"; then find "mesos-0.20.0" -type d ! -perm -200 -exec 
chmod u+w {} ';' && rm -rf "mesos-0.20.0" || { sleep 5 && rm -rf 
"mesos-0.20.0"; }; else :; fi
test -d "mesos-0.20.0" || mkdir "mesos-0.20.0"
 (cd 3rdparty && make  top_distdir=../mesos-0.20.0 
distdir=../mesos-0.20.0/3rdparty \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[1]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd libprocess && make  top_distdir=../../mesos-0.20.0 
distdir=../../mesos-0.20.0/3rdparty/libprocess \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.20.0/3rdparty/libprocess" || mkdir 
"../../mesos-0.20.0/3rdparty/libprocess"
 (cd 3rdparty && make  top_distdir=../../../mesos-0.20.0 
distdir=../../../mesos-0.20.0/3rdparty/libprocess/3rdparty \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
 (cd stout && make  top_distdir=../../../../mesos-0.20.0 
distdir=../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout" || mkdir 
"../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout"
test -n ":" \
|| find "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout" 
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash 
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
 -c -m a+r {} {} \; \
|| chmod -R a+r 
"../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout"
make[4]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[3]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
test -n ":" \
|| find "../../mesos-0.20.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash 
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
 -c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.20.0/3rdparty/libprocess"
make[2]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd src && make  top_distdir=../mesos-0.20.0 distdir=../mesos-0.20.0/src \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[1]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
/bin/mkdir -p python/src/mesos
/bin/mkdir -p python/api/src/mesos
/bin/mkdir -p python/api/src/mesos/api
cp -pf ./python/api/src/mesos/api/__init__.py 
python/api/src/mesos/api/__init__.py
cp -pf ./python/src/mesos/__init__.py python/src/mesos/__init__.py
cp -pf ./python/api/src/mesos/__init__.py python/api/src/mesos/__init__.py
cp: `./python/src/mesos/__init__.py' and `python/src/mesos/__init__.py' are the 
same file
cp: cp: `./python/api/src/mesos/__init__.py' and 
`python/api/src/mesos/__init__.py' are the same 
file`./python/api/src/mesos/api/__init__.py' and 
`python/api/src/mesos/api/__init__.py' are the same file

make[1]: *** [python/src/mesos/__init__.py] Error 1
make[1]: *** Waiting for unfinished jobs
make[1]: *** [python/api/src/mesos/api/__init__.py] Error 1
make[1]: *** [python/api/src/mesos/__init__.py] Error 1
make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make: *** [distdir] Error 1


- Mesos ReviewBot


On July 8, 2014, 5:05 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 8, 2014, 5:05 p.m.)
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-08 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 8, 2014, 5:05 p.m.)


Review request for mesos.


Changes
---

Alright, should be passing `distcheck` now. I'd appreciate some eyes so that 
this can get merged in.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am 45afcd145f3b502043424a6dac2197979aefbca2 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-03 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 3, 2014, 5:25 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-03 Thread Brian Wickman



> On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
> > src/Makefile.am, line 137
> > 
> >
> > i would love to see all protos contained here, including messages 
> > protos.  this will allow for the development of a pure python api.  mind 
> > adding those?  or possibly create a mesos.api_internal?
> 
> Thomas Rampelberg wrote:
> Would you open a new JIRA for that? I'd like to have a separate patch for 
> that.

Filed https://issues.apache.org/jira/browse/MESOS-1561


> On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
> > src/python/native/setup.py.in, line 29
> > 
> >
> > what's your philosophy on versioning here?
> > 
> > should we always require deps==version or just deps>=major, > similar?  can always punt for later.
> 
> Thomas Rampelberg wrote:
> At the moment, the separate modules all have versions identical to mesos' 
> (PACKAGE_VERSION). While I'm not sure that is the correct decision in the 
> long term, it works for now. Given that, it seems to make sense to me that 
> the inter-dependencies are `deps==version` (as they're all fixed to the mesos 
> version itself).

sgtm


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47259
---


On July 3, 2014, 12:46 a.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 3, 2014, 12:46 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg



> On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
> > src/python/protocol/setup.py.in, line 27
> > 
> >
> > same here, to be conservative, might want protobuf>=2.5.0,<3

Good call.


> On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
> > src/python/native/ext_def.py.in, line 1
> > 
> >
> > not sure about process but does this need the ASF license headers?

Added.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47259
---


On July 3, 2014, 12:46 a.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 3, 2014, 12:46 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 3, 2014, 12:46 a.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg



> On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
> > src/Makefile.am, line 137
> > 
> >
> > i would love to see all protos contained here, including messages 
> > protos.  this will allow for the development of a pure python api.  mind 
> > adding those?  or possibly create a mesos.api_internal?

Would you open a new JIRA for that? I'd like to have a separate patch for that.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47259
---


On July 2, 2014, 11:53 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 2, 2014, 11:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg



> On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
> > src/python/native/setup.py.in, line 29
> > 
> >
> > what's your philosophy on versioning here?
> > 
> > should we always require deps==version or just deps>=major, > similar?  can always punt for later.

At the moment, the separate modules all have versions identical to mesos' 
(PACKAGE_VERSION). While I'm not sure that is the correct decision in the long 
term, it works for now. Given that, it seems to make sense to me that the 
inter-dependencies are `deps==version` (as they're all fixed to the mesos 
version itself).


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47259
---


On July 2, 2014, 11:53 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 2, 2014, 11:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47259
---


thanks for doing this work.  this will be a huge improvement going forward and 
opens the possibility of pure python implementations of frameworks.  exciting!


src/Makefile.am


i would love to see all protos contained here, including messages protos.  
this will allow for the development of a pure python api.  mind adding those?  
or possibly create a mesos.api_internal?



src/python/native/ext_def.py.in


not sure about process but does this need the ASF license headers?



src/python/native/setup.py.in


what's your philosophy on versioning here?

should we always require deps==version or just deps>=major,https://reviews.apache.org/r/23224/#comment82920>

same here, to be conservative, might want protobuf>=2.5.0,<3


- Brian Wickman


On July 2, 2014, 11:53 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 2, 2014, 11:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 2, 2014, 11:53 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 2, 2014, 11:48 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47235
---


Bad patch!

Reviews applied: [23224]

Failed command: make -j3 distcheck

Error:
 if test -d "mesos-0.20.0"; then find "mesos-0.20.0" -type d ! -perm -200 -exec 
chmod u+w {} ';' && rm -rf "mesos-0.20.0" || { sleep 5 && rm -rf 
"mesos-0.20.0"; }; else :; fi
test -d "mesos-0.20.0" || mkdir "mesos-0.20.0"
 (cd 3rdparty && make  top_distdir=../mesos-0.20.0 
distdir=../mesos-0.20.0/3rdparty \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[1]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd libprocess && make  top_distdir=../../mesos-0.20.0 
distdir=../../mesos-0.20.0/3rdparty/libprocess \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
:
test -d "../../mesos-0.20.0/3rdparty/libprocess" || mkdir 
"../../mesos-0.20.0/3rdparty/libprocess"
 (cd 3rdparty && make  top_distdir=../../../mesos-0.20.0 
distdir=../../../mesos-0.20.0/3rdparty/libprocess/3rdparty \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
 (cd stout && make  top_distdir=../../../../mesos-0.20.0 
distdir=../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
:
test -d "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout" || mkdir 
"../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout"
test -n ":" \
|| find "../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout" 
-type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash 
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout/install-sh
 -c -m a+r {} {} \; \
|| chmod -R a+r 
"../../../../mesos-0.20.0/3rdparty/libprocess/3rdparty/stout"
make[4]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty/stout'
make[3]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/3rdparty'
test -n ":" \
|| find "../../mesos-0.20.0/3rdparty/libprocess" -type d ! -perm -755 \
-exec chmod u+rwx,go+rx {} \; -o \
  ! -type d ! -perm -444 -links 1 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -400 -exec chmod a+r {} \; -o \
  ! -type d ! -perm -444 -exec /bin/bash 
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/install-sh
 -c -m a+r {} {} \; \
|| chmod -R a+r "../../mesos-0.20.0/3rdparty/libprocess"
make[2]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess'
make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty'
 (cd src && make  top_distdir=../mesos-0.20.0 distdir=../mesos-0.20.0/src \
 am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[1]: Entering directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make[1]: *** No rule to make target `python/native/module.hpp', needed by 
`distdir'.  Stop.
make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src'
make: *** [distdir] Error 1


- Mesos ReviewBot


On July 2, 2014, 8:46 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 2, 2014, 8:46 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 2, 2014, 8:46 p.m.)


Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg



> On July 2, 2014, 6:17 p.m., Brian Wickman wrote:
> > This seems to be missing the setup.py(.in)s from mesos.api, mesos.native, 
> > mesos.protocol.  Forget to git add?
> > 
> > Otherwise this is looking great!

Argh, how'd I miss those. Thanks!


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47213
---


On July 2, 2014, 8:36 p.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 2, 2014, 8:36 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/setup.py.in PRE-CREATION 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/ext_def.py.in PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/setup.py.in PRE-CREATION 
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/setup.py.in PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

(Updated July 2, 2014, 8:36 p.m.)


Review request for mesos.


Changes
---

Added the mysteriously missing *.in files.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs (updated)
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am e3ff6d71d9324ea8376c14fae056568452f22bdc 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/setup.py.in PRE-CREATION 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/ext_def.py.in PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/setup.py.in PRE-CREATION 
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/setup.py.in PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47228
---


Bad patch!

Reviews applied: [23224]

Failed command: ./bootstrap

Error:
 autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:45: warning: back quotes and double quotes must not be escaped in: 
unrecognized option: $[1]
configure.ac:45: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:45: the top level
configure.ac:45: warning: back quotes and double quotes must not be escaped in: 
unrecognized argument: $[1]
configure.ac:45: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:45: the top level
configure.ac:395: warning: The macro `AC_LANG_SAVE' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/lang.m4:126: AC_LANG_SAVE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:395: warning: The macro `AC_LANG_C' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/c.m4:73: AC_LANG_C is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:395: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:395: warning: The macro `AC_LANG_RESTORE' is obsolete.
configure.ac:395: You should run autoupdate.
../../lib/autoconf/lang.m4:135: AC_LANG_RESTORE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:395: the top level
configure.ac:722: warning: The macro `AC_PYTHON_DEVEL' is obsolete.
configure.ac:722: You should run autoupdate.
m4/ax_python_devel.m4:72: AC_PYTHON_DEVEL is expanded from...
configure.ac:722: the top level
autoreconf: configure.ac: adding subdirectory 3rdparty/libprocess to autoreconf
autoreconf: Entering directory `3rdparty/libprocess'
configure.ac:29: warning: back quotes and double quotes must not be escaped in: 
unrecognized option: $[1]
configure.ac:29: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:29: the top level
configure.ac:29: warning: back quotes and double quotes must not be escaped in: 
unrecognized argument: $[1]
configure.ac:29: Try \`$[0] --help' for more information.
aclocal.m4:625: LT_OUTPUT is expanded from...
configure.ac:29: the top level
configure.ac:259: warning: The macro `AC_LANG_SAVE' is obsolete.
configure.ac:259: You should run autoupdate.
../../lib/autoconf/lang.m4:126: AC_LANG_SAVE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:259: the top level
configure.ac:259: warning: The macro `AC_LANG_C' is obsolete.
configure.ac:259: You should run autoupdate.
../../lib/autoconf/c.m4:73: AC_LANG_C is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:259: the top level
configure.ac:259: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:259: You should run autoupdate.
../../lib/autoconf/general.m4:2688: AC_TRY_LINK is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:259: the top level
configure.ac:259: warning: The macro `AC_LANG_RESTORE' is obsolete.
configure.ac:259: You should run autoupdate.
../../lib/autoconf/lang.m4:135: AC_LANG_RESTORE is expanded from...
m4/acx_pthread.m4:63: ACX_PTHREAD is expanded from...
configure.ac:259: the top level
autoreconf: configure.ac: adding subdirectory 3rdparty/stout to autoreconf
autoreconf: Entering directory `3rdparty/stout'
autoreconf: configure.ac: not using Libtool
autoreconf: running: /usr/bin/autoconf --warnings=all
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:10: installing `./missing'
autoreconf: Leaving directory `3rdparty/stout'
autoreconf: running: libtoolize --install --copy
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./config.guess'
libtoolize: copying file `./config.sub'
libtoolize: copying file `./ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: You should add the contents of `m4/libtool.m4' to `aclocal.m4'.
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: You should add the contents of `m4/ltoptions.m4' to `aclocal.m4'.
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: You should add the contents of `m4/ltsugar.m4' to `aclocal.m4'.
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~o

Re: Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-02 Thread Brian Wickman


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47213
---


This seems to be missing the setup.py(.in)s from mesos.api, mesos.native, 
mesos.protocol.  Forget to git add?

Otherwise this is looking great!

- Brian Wickman


On July 2, 2014, 1:32 a.m., Thomas Rampelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23224/
> ---
> 
> (Updated July 2, 2014, 1:32 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-857
> https://issues.apache.org/jira/browse/MESOS-857
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> The existing module has been split into three separate ones:
> 
> - mesos.api - This contains the stub implementations for the 
> Executor/Scheduler
> - mesos.native - The old _mesos module.
> - mesos.protocol - All protobufs.
> 
> There is also a base metapackage `mesos` that allows a potential `pip install 
> mesos` to correctly install everything required. While mesos.api and 
> mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
> changed and will need some more work first.
> 
> 
> Diffs
> -
> 
>   Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
>   configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
>   mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
>   mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
>   src/Makefile.am 918b0d04a5de69a9213e3d31c8f9424756e4ade5 
>   src/examples/python/test-containerizer.in 
> 569519b3b9755959f9bf931d3c81be9a00b64bc9 
>   src/examples/python/test-executor.in 
> 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
>   src/examples/python/test-framework.in 
> c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
>   src/examples/python/test_containerizer.py 
> c65d891539bcee775741626596997afe8471c930 
>   src/examples/python/test_executor.py 
> 065b50a6146cb39a82024d82c20cf89f940a9e57 
>   src/examples/python/test_framework.py 
> fce090fe542e3863770d7daea3d8764da1d8d5df 
>   src/python/api/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/mesos_executor_driver_impl.hpp  
>   src/python/native/mesos_executor_driver_impl.cpp  
>   src/python/native/mesos_scheduler_driver_impl.hpp  
>   src/python/native/mesos_scheduler_driver_impl.cpp  
>   src/python/native/module.hpp  
>   src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
>   src/python/native/proxy_executor.hpp  
>   src/python/native/proxy_executor.cpp  
>   src/python/native/proxy_scheduler.hpp  
>   src/python/native/proxy_scheduler.cpp  
>   src/python/native/src/mesos/__init__.py PRE-CREATION 
>   src/python/native/src/mesos/native/__init__.py PRE-CREATION 
>   src/python/protocol/src/mesos/__init__.py PRE-CREATION 
>   src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
>   src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
>   src/python/src/mesos/__init__.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23224/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Thomas Rampelberg
> 
>

Review Request 23224: Refactored the python bindings into multiple modules.

2014-07-01 Thread Thomas Rampelberg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---

Review request for mesos.


Bugs: MESOS-857
https://issues.apache.org/jira/browse/MESOS-857


Repository: mesos-git


Description
---

The existing module has been split into three separate ones:

- mesos.api - This contains the stub implementations for the Executor/Scheduler
- mesos.native - The old _mesos module.
- mesos.protocol - All protobufs.

There is also a base metapackage `mesos` that allows a potential `pip install 
mesos` to correctly install everything required. While mesos.api and 
mesos.protocol can now be uploaded to the cheeseshop, mesos.native has not 
changed and will need some more work first.


Diffs
-

  Makefile.am b91d8cf011832e6e91b16f03a2d80fbb601eba8f 
  configure.ac e7472081339fc9c773eb2cf2d5f15dc459ac378d 
  mpi/mpiexec-mesos.in da0733fc29f97e67385cab55d60d4e2afd76aba9 
  mpi/mpiexec-mesos.py 0ab50167eaa43f9d69f37b7c10e26fa7a7d9f250 
  src/Makefile.am 918b0d04a5de69a9213e3d31c8f9424756e4ade5 
  src/examples/python/test-containerizer.in 
569519b3b9755959f9bf931d3c81be9a00b64bc9 
  src/examples/python/test-executor.in 7e8875f0fd74dc9f9207986864edbce588ec3fb8 
  src/examples/python/test-framework.in 
c4683b97b87ba8753e842b0c75cc3d65140a5cf7 
  src/examples/python/test_containerizer.py 
c65d891539bcee775741626596997afe8471c930 
  src/examples/python/test_executor.py 065b50a6146cb39a82024d82c20cf89f940a9e57 
  src/examples/python/test_framework.py 
fce090fe542e3863770d7daea3d8764da1d8d5df 
  src/python/api/src/mesos/__init__.py PRE-CREATION 
  src/python/native/mesos_executor_driver_impl.hpp  
  src/python/native/mesos_executor_driver_impl.cpp  
  src/python/native/mesos_scheduler_driver_impl.hpp  
  src/python/native/mesos_scheduler_driver_impl.cpp  
  src/python/native/module.hpp  
  src/python/native/module.cpp b94712681e6f0e9bf5dfdafa10621d1df82dc367 
  src/python/native/proxy_executor.hpp  
  src/python/native/proxy_executor.cpp  
  src/python/native/proxy_scheduler.hpp  
  src/python/native/proxy_scheduler.cpp  
  src/python/native/src/mesos/__init__.py PRE-CREATION 
  src/python/native/src/mesos/native/__init__.py PRE-CREATION 
  src/python/protocol/src/mesos/__init__.py PRE-CREATION 
  src/python/setup.py.in b996dfef5c7a6d330991522bf0047ed3cac6760d 
  src/python/src/mesos.py 0152ab456f072f8d4a1c4ab19fe74e181eadbd05 
  src/python/src/mesos/__init__.py PRE-CREATION 

Diff: https://reviews.apache.org/r/23224/diff/


Testing
---


Thanks,

Thomas Rampelberg

46 matches

Mail list logo