Re: Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- (Updated Nov. 3, 2014, 7:51 p.m.) Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Changes --- Addressed Bernd's comments. Repository: mesos-git Description --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Here is the url for markdown view: https://github.com/karya0/mesos/blob/modules/docs/modules.md Diffs (updated) - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/#review59702 --- Ship it! Looks great. Just some minor nits here and there :) docs/home.md https://reviews.apache.org/r/27453/#comment101007 master, slave and tests. ? docs/modules.md https://reviews.apache.org/r/27453/#comment100999 Not sure this is needed. Mesos as a whole is work in progress. Maybe stating that this was the initial version would be cleaner. But I dont have a strong opinion on that. docs/modules.md https://reviews.apache.org/r/27453/#comment101000 (and tests)? Also s/slace/slave/ docs/modules.md https://reviews.apache.org/r/27453/#comment101001 atleast - not sure that word exists. :) docs/modules.md https://reviews.apache.org/r/27453/#comment101002 Add a blank line. docs/modules.md https://reviews.apache.org/r/27453/#comment101003 Even though our style demands two blank lines here, I think for the sake of this document we should leave as is. docs/modules.md https://reviews.apache.org/r/27453/#comment101004 i.e., - is that correct? docs/modules.md https://reviews.apache.org/r/27453/#comment101005 ... module selected for isolation: ? docs/modules.md https://reviews.apache.org/r/27453/#comment101006 src/module/manager.cpp docs/modules.md https://reviews.apache.org/r/27453/#comment100997 This should be libraries docs/modules.md https://reviews.apache.org/r/27453/#comment100998 This should be parameters - Till Toenshoff On Nov. 4, 2014, 12:51 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- (Updated Nov. 4, 2014, 12:51 a.m.) Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Repository: mesos-git Description --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Here is the url for markdown view: https://github.com/karya0/mesos/blob/modules/docs/modules.md Diffs - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- (Updated Nov. 3, 2014, 8:55 p.m.) Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Changes --- Addressed Till's comments. Repository: mesos-git Description --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Here is the url for markdown view: https://github.com/karya0/mesos/blob/modules/docs/modules.md Diffs (updated) - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- (Updated Nov. 3, 2014, 9:04 p.m.) Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Changes --- Added bug ids. Bugs: MESOS-1937, MESOS-1950 and MESOS-1981 https://issues.apache.org/jira/browse/MESOS-1937 https://issues.apache.org/jira/browse/MESOS-1950 https://issues.apache.org/jira/browse/MESOS-1981 Repository: mesos-git Description --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Here is the url for markdown view: https://github.com/karya0/mesos/blob/modules/docs/modules.md Diffs - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 27453: First version of docs/modules.md.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27453/#review59562
---
docs/modules.md
https://reviews.apache.org/r/27453/#comment100830
explain graced
docs/modules.md
https://reviews.apache.org/r/27453/#comment100831
Module = Modules
docs/modules.md
https://reviews.apache.org/r/27453/#comment100832
remove a
docs/modules.md
https://reviews.apache.org/r/27453/#comment100833
... algorithms insert: written in scripting languages
docs/modules.md
https://reviews.apache.org/r/27453/#comment100834
indentation
docs/modules.md
https://reviews.apache.org/r/27453/#comment100835
This means that inline JSON and file JSON are not the same. Then we might
as well not have inline JSON at all. How about this instead?
...
--modules='{libraries:[{file:/path/to/libfoo.so,
modules:[{name:org_apache_mesos_bar}]}]}'
...
docs/modules.md
https://reviews.apache.org/r/27453/#comment100836
Why are backquotes used here?
docs/modules.md
https://reviews.apache.org/r/27453/#comment100837
foo = foo
docs/modules.md
https://reviews.apache.org/r/27453/#comment100838
You could also write What kinds of modules are supported? Just a
suggestion.
docs/modules.md
https://reviews.apache.org/r/27453/#comment100839
support = only provides
docs/modules.md
https://reviews.apache.org/r/27453/#comment100840
Additional graced modules will be added in the near future
docs/modules.md
https://reviews.apache.org/r/27453/#comment100841
The ...
docs/modules.md
https://reviews.apache.org/r/27453/#comment100842
The ...
docs/modules.md
https://reviews.apache.org/r/27453/#comment100843
modules = module
docs/modules.md
https://reviews.apache.org/r/27453/#comment100844
Add a recommendation to not simply use the kind name as module name.
Different modules from the same org still need different names.
docs/modules.md
https://reviews.apache.org/r/27453/#comment100845
Role = Kind
docs/modules.md
https://reviews.apache.org/r/27453/#comment100846
role = kind
docs/modules.md
https://reviews.apache.org/r/27453/#comment100847
role = kind
docs/modules.md
https://reviews.apache.org/r/27453/#comment100848
The = to
docs/modules.md
https://reviews.apache.org/r/27453/#comment100850
Move the summary up front?
docs/modules.md
https://reviews.apache.org/r/27453/#comment100849
Role = Kind
- Bernd Mathiske
On Oct. 31, 2014, 4:23 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27453/
---
(Updated Oct. 31, 2014, 4:23 p.m.)
Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff.
Repository: mesos-git
Description
---
With bits copied from
https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide.
Here is the url for markdown view:
https://github.com/karya0/mesos/blob/modules/docs/modules.md
Diffs
-
docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199
docs/modules.md PRE-CREATION
Diff: https://reviews.apache.org/r/27453/diff/
Testing
---
Thanks,
Kapil Arya
Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Repository: mesos-git Description --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Diffs - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- (Updated Oct. 31, 2014, 7:23 p.m.) Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Changes --- Added github link. Repository: mesos-git Description (updated) --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Here is the url for markdown view: https://github.com/karya0/mesos/blob/modules/docs/modules.md Diffs - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 27453: First version of docs/modules.md.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/#review59441 --- Patch looks great! Reviews applied: [27453] All tests passed. - Mesos ReviewBot On Oct. 31, 2014, 11:23 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27453/ --- (Updated Oct. 31, 2014, 11:23 p.m.) Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Till Toenshoff. Repository: mesos-git Description --- With bits copied from https://cwiki.apache.org/confluence/display/MESOS/Mesos+Modules+Developer+Guide. Here is the url for markdown view: https://github.com/karya0/mesos/blob/modules/docs/modules.md Diffs - docs/home.md 416a52ed99dba5ba55af97a300ce428355edd199 docs/modules.md PRE-CREATION Diff: https://reviews.apache.org/r/27453/diff/ Testing --- Thanks, Kapil Arya
