Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review78046 --- Ship it! Ship It! - Alexander Rojas On March 26, 2015, 12:20 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 26, 2015, 12:20 a.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 31ca72463abb4ef6629983391527745bbb8df2df Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
On March 25, 2015, 3:37 p.m., Michael Park wrote: Perhaps a dumb question, but I'm wondering why the enclosing braces belong here rather than in `operator (std::ostream stream, const FlagsBase flags)`? Adressed - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review77739 --- On March 25, 2015, 11:20 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 25, 2015, 11:20 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 31ca72463abb4ef6629983391527745bbb8df2df Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review77739 --- Perhaps a dumb question, but I'm wondering why the enclosing braces belong here rather than in `operator (std::ostream stream, const FlagsBase flags)`? - Michael Park On March 16, 2015, 3:20 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 16, 2015, 3:20 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review77834 --- Patch looks great! Reviews applied: [32105, 30931] All tests passed. - Mesos ReviewBot On March 25, 2015, 11:20 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 25, 2015, 11:20 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 31ca72463abb4ef6629983391527745bbb8df2df Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review77724 --- Ship it! Ship It! - Till Toenshoff On March 16, 2015, 3:20 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 16, 2015, 3:20 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 25, 2015, 11:20 p.m.) Review request for mesos and Till Toenshoff. Changes --- Adressed Bens comments. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 31ca72463abb4ef6629983391527745bbb8df2df Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 16, 2015, 3:20 p.m.) Review request for mesos and Till Toenshoff. Changes --- Adressed Ben's comment and split patch. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review76564 --- Patch looks great! Reviews applied: [32105, 30931] All tests passed. - Mesos ReviewBot On March 16, 2015, 3:20 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 16, 2015, 3:20 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
On Feb. 25, 2015, 10:54 p.m., Ben Mahler wrote: src/common/type_utils.cpp, lines 203-205 https://reviews.apache.org/r/30931/diff/8/?file=873690#file873690line203 You're taking a logging::Flags but you're iterating over non-logging flags (i.e. slave::Flags, master::Flags), that's fairly non-intuitive. Any reason that this `operator ` can't be defined inside stout for `FlagsBase`? This makes sense, however I would like to see such functions defind in `.cpp` files, which is not possible for stout. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review74123 --- On March 16, 2015, 3:20 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated March 16, 2015, 3:20 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - src/master/master.cpp dccd7c635da4b7031cd109bd84e7f17b31777ef1 src/slave/slave.cpp 0f99e4efb8fa2b96f120a3e49191158ca0364c06 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote: src/slave/slave.cpp, line 176 https://reviews.apache.org/r/30931/diff/4/?file=863304#file863304line176 How about supporting Mesos local and possibly the test as well? Joerg Schad wrote: Is already automatially provided by the previous version as in both cases the calls go via master/slave intialize as well. Doh, certainly - I somehow thought that you had implemented this within slave/main.cpp master/main.cpp. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73563 --- On Feb. 24, 2015, 9:30 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 24, 2015, 9:30 a.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 24, 2015, 9:30 a.m.) Review request for mesos and Till Toenshoff. Changes --- Addressed Alex's comments on style. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73786 --- Patch looks great! Reviews applied: [30931] All tests passed. - Mesos ReviewBot On Feb. 24, 2015, 9:30 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 24, 2015, 9:30 a.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73563 --- include/mesos/type_utils.hpp https://reviews.apache.org/r/30931/#comment119956 move this further down, after the installed headers (those in sharp brackets). We generally have the following group ordering: 1. c standard headers (.h) 2. c installed headers (.h) 3. c++ standard headers () 4. c++ installed headers (.hpp) 5. c++ internal, local headers (.hpp) All of the above get sorted alphabetically within their own group. include/mesos/type_utils.hpp https://reviews.apache.org/r/30931/#comment119957 Are we missing a namespace close via bracket? src/common/type_utils.cpp https://reviews.apache.org/r/30931/#comment119958 Maybe add a single space? src/slave/slave.cpp https://reviews.apache.org/r/30931/#comment119959 How about supporting Mesos local and possibly the test as well? - Till Toenshoff On Feb. 13, 2015, 4:10 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 4:10 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73573 --- Bad patch! Reviews applied: [30931] Failed command: ./support/apply-review.sh -n -r 30931 Error: 2015-02-23 15:58:16 URL:https://reviews.apache.org/r/30931/diff/raw/ [3100/3100] - 30931.patch [1] error: patch failed: src/common/type_utils.cpp:189 error: src/common/type_utils.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Feb. 13, 2015, 4:10 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 4:10 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote: src/common/type_utils.cpp, line 208 https://reviews.apache.org/r/30931/diff/4/?file=863302#file863302line208 Maybe add a single space? I followed the format of *curl localhost:5050/state.json* which does not have any spaces. On Feb. 23, 2015, 2:34 p.m., Till Toenshoff wrote: src/slave/slave.cpp, line 176 https://reviews.apache.org/r/30931/diff/4/?file=863304#file863304line176 How about supporting Mesos local and possibly the test as well? Is already automatially provided by the previous version as in both cases the calls go via master/slave intialize as well. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73563 --- On Feb. 13, 2015, 4:10 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 4:10 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 23, 2015, 3:59 p.m.) Review request for mesos and Till Toenshoff. Changes --- Rebased and addressed Till's comments. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 57e86ee19879cc8a2a9b9fb69f602eea0a06e906 src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 23, 2015, 4:06 p.m.) Review request for mesos and Till Toenshoff. Changes --- Just to trigger the Mesos Review Bot. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 57e86ee19879cc8a2a9b9fb69f602eea0a06e906 src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73644 --- include/mesos/type_utils.hpp https://reviews.apache.org/r/30931/#comment120041 An installed header cannot depend on an internal header. Does this include have to be in include/type_utils.hpp? - Vinod Kone On Feb. 23, 2015, 4:06 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 23, 2015, 4:06 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 57e86ee19879cc8a2a9b9fb69f602eea0a06e906 src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review73748 --- Patch looks great! Reviews applied: [30931] All tests passed. - Mesos ReviewBot On Feb. 23, 2015, 11:34 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 23, 2015, 11:34 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 23, 2015, 11:34 p.m.) Review request for mesos and Till Toenshoff. Changes --- Changed import to forward declaration. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45 src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 src/master/master.cpp 713307e1be596651283cc2cc95f114c42ad34a5e src/slave/slave.cpp d44910838fc479b62200cdfd342ad13524504838 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review72366 --- src/common/type_utils.cpp https://reviews.apache.org/r/30931/#comment118446 Do we need to include this one more time? We already have it from type_utils.hpp. src/common/type_utils.cpp https://reviews.apache.org/r/30931/#comment118452 Newline, please! - Alexander Rukletsov On Feb. 13, 2015, 12:44 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 12:44 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 3:59 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/#review72379 --- include/mesos/type_utils.hpp https://reviews.apache.org/r/30931/#comment118454 Newline, please! src/common/type_utils.cpp https://reviews.apache.org/r/30931/#comment118456 Newline, please. - Alexander Rukletsov On Feb. 13, 2015, 3:59 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 3:59 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 4:10 p.m.) Review request for mesos and Till Toenshoff. Changes --- Fixed Alex's comments. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
Re: Review Request 30931: Added flags to logs at master and slave startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30931/ --- (Updated Feb. 13, 2015, 12:44 p.m.) Review request for mesos and Till Toenshoff. Changes --- Addressed Till's comments. Bugs: MESOS-2323 https://issues.apache.org/jira/browse/MESOS-2323 Repository: mesos Description --- Added flags to logs at master and slave startup. Diffs (updated) - include/mesos/type_utils.hpp 32dc6ed489f43ba3695507f59c4c2d94028c8df1 src/common/type_utils.cpp 12a36bbd7d7773b25dedf2d0d951c79e0b5141d6 src/master/master.cpp f10a3cffdb0b9831b2b8af0dfd30f73d1d8ed937 src/slave/slave.cpp 1e60454cecfe387c4906a74f176bef00c2e0dbb7 Diff: https://reviews.apache.org/r/30931/diff/ Testing --- make check Thanks, Joerg Schad
