Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 4, 2015, 12:39 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
---

Updated to reflect review comments


Bugs: mesos-2591
https://issues.apache.org/jira/browse/mesos-2591


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
ae61a0fcd19f2ba808624312401f020121baf5d4 
  src/slave/containerizer/mesos/containerizer.cpp 
e4136095fca55637864f495098189ab3ad8d8fe7 
  src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Ian Downes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/#review78861
---



src/slave/containerizer/mesos/containerizer.hpp


We favor `const char foobar[]`.



src/tests/port_mapping_tests.cpp


directory and name?



src/tests/port_mapping_tests.cpp


Move down to where used. Why change and introduce a variable?



src/tests/port_mapping_tests.cpp


Not yours, but why is `preparation` an `Option`? And why don't we check 
it's some?



src/tests/port_mapping_tests.cpp


Why the change from std{in,out,err}?



src/tests/port_mapping_tests.cpp


keep the newline?


- Ian Downes


On April 3, 2015, 3:36 p.m., Paul Brett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32655/
> ---
> 
> (Updated April 3, 2015, 3:36 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: mesos-2591
> https://issues.apache.org/jira/browse/mesos-2591
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
> class
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> ae61a0fcd19f2ba808624312401f020121baf5d4 
>   src/slave/containerizer/mesos/containerizer.cpp 
> e4136095fca55637864f495098189ab3ad8d8fe7 
>   src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 
> 
> Diff: https://reviews.apache.org/r/32655/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 3, 2015, 10:36 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Bugs: mesos-2591
https://issues.apache.org/jira/browse/mesos-2591


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
ae61a0fcd19f2ba808624312401f020121baf5d4 
  src/slave/containerizer/mesos/containerizer.cpp 
e4136095fca55637864f495098189ab3ad8d8fe7 
  src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 3, 2015, 10:17 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
---

Correct indentation


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
ae61a0fcd19f2ba808624312401f020121baf5d4 
  src/slave/containerizer/mesos/containerizer.cpp 
e4136095fca55637864f495098189ab3ad8d8fe7 
  src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-03 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 3, 2015, 9:58 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
---

Rebase


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
ae61a0fcd19f2ba808624312401f020121baf5d4 
  src/slave/containerizer/mesos/containerizer.cpp 
e4136095fca55637864f495098189ab3ad8d8fe7 
  src/tests/port_mapping_tests.cpp 58709b5a0ac58f13985dcc4b71250ec41487ff18 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-01 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 1, 2015, 11:41 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp ae61a0f 
  src/slave/containerizer/mesos/containerizer.cpp e413609 
  src/tests/port_mapping_tests.cpp f4124c3 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-04-01 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 1, 2015, 3:44 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs
-

  src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-31 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 1, 2015, 1:11 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-31 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated April 1, 2015, 12:41 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-31 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/#review78422
---



src/tests/port_mapping_tests.cpp


Could you make it a bit more explict to say this variable is 
mesos-containerizer *path*?

is the indent off by 1? ;)


- Chi Zhang


On March 31, 2015, 5:35 a.m., Paul Brett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32655/
> ---
> 
> (Updated March 31, 2015, 5:35 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
> class
> 
> 
> Diffs
> -
> 
>   src/tests/port_mapping_tests.cpp f4124c3 
> 
> Diff: https://reviews.apache.org/r/32655/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated March 31, 2015, 5:35 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs
-

  src/tests/port_mapping_tests.cpp f4124c3 

Diff: https://reviews.apache.org/r/32655/diff/


Testing (updated)
---

make check


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/#review78341
---


Patch looks great!

Reviews applied: [32655]

All tests passed.

- Mesos ReviewBot


On March 31, 2015, 3:55 a.m., Paul Brett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32655/
> ---
> 
> (Updated March 31, 2015, 3:55 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
> class
> 
> 
> Diffs
> -
> 
>   src/tests/port_mapping_tests.cpp f4124c3 
> 
> Diff: https://reviews.apache.org/r/32655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated March 31, 2015, 3:55 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Changes
---

Remove dependency on having applied waitForFileCreation first


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/tests/port_mapping_tests.cpp f4124c3 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

(Updated March 31, 2015, 3:52 a.m.)


Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Changes
---

Remove dependency on having applied waitForFileCreation first


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs (updated)
-

  src/tests/port_mapping_tests.cpp f4124c3 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---


Thanks,

Paul Brett

Re: Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/#review78322
---


Bad patch!

Reviews applied: [32655]

Failed command: ./support/apply-review.sh -n -r 32655

Error:
 2015-03-31 03:25:16 URL:https://reviews.apache.org/r/32655/diff/raw/ 
[6570/6570] -> "32655.patch" [1]
error: patch failed: src/tests/port_mapping_tests.cpp:271
error: src/tests/port_mapping_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On March 31, 2015, 2:52 a.m., Paul Brett wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32655/
> ---
> 
> (Updated March 31, 2015, 2:52 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.
> 
> 
> Bugs: mesos-2332
> https://issues.apache.org/jira/browse/mesos-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
> class
> 
> 
> Diffs
> -
> 
>   src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4 
> 
> Diff: https://reviews.apache.org/r/32655/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Review Request 32655: Refactor out launchHelper to make is usable outside PortMappingIsolatorTest class

2015-03-30 Thread Paul Brett 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32655/
---

Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang.


Bugs: mesos-2332
https://issues.apache.org/jira/browse/mesos-2332


Repository: mesos


Description
---

Refactor out launchHelper to make is usable outside PortMappingIsolatorTest 
class


Diffs
-

  src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4 

Diff: https://reviews.apache.org/r/32655/diff/


Testing
---


Thanks,

Paul Brett