Re: [VOTE] MINA 2.0.10 release

[Jeff MAURY]

Sorry for being late as I'm out. Let move to +0 and me create the JIRA.

Regards
Jeff


On Tue, Dec 15, 2015 at 11:11 AM, Emmanuel Lécharny 
wrote:

> Hi Jeff,
>
> I'd like to know if you hold on your -1 vote. Release vote are majority
> votes, there is no veto, but in this case, I think it's important to
> have your opinion. We have three options here :
> - You maintain your -1, and we bypass it. I think that would be the very
> first time, and would be bad taste, IMHO.
> - You maintain your -1, we cancel the vote and teh release, fix the pb,
> and cut a new release
> - You withdraw your -1, we create a JIRA, and get the issue fixed for
> 2.0.11
>
> I really think that the first option is a big no-no.
>
> So between the two other options, I let you decide. Both are fine.
>
> Thanks a lot !
>



-- 
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury

Re: [VOTE] MINA 2.0.10 release

[Emmanuel Lécharny]

Hi Jeff,

I'd like to know if you hold on your -1 vote. Release vote are majority
votes, there is no veto, but in this case, I think it's important to
have your opinion. We have three options here :
- You maintain your -1, and we bypass it. I think that would be the very
first time, and would be bad taste, IMHO.
- You maintain your -1, we cancel the vote and teh release, fix the pb,
and cut a new release
- You withdraw your -1, we create a JIRA, and get the issue fixed for 2.0.11

I really think that the first option is a big no-no.

So between the two other options, I let you decide. Both are fine.

Thanks a lot !

Re: [VOTE] MINA 2.0.10 release

[Ashish]

+1

Ran the build, works fine, all test cases passed

On Mon, Dec 7, 2015 at 2:08 AM, Emmanuel Lecharny  wrote:
> Hi,
>
> Here is a vote for a new bug fix release of Mina 2 : 2.0.10.
>
> No new features, but a few critical fixes :
>
> - a race condition in the SSL handler
>
> - some OSGi package declaration fixes
>
> - removed a lock in the decoder, speeding up MINA.
>
> Here is the list of fixed issues :
> Improvements :
> --
>
> [DIRMINA-1018 
> ]FetchAppBuffer
> shrink
> [DIRMINA-1020 ]Change
> minimum version for slf4j in MANIFEST
>
> Bugs :
> --
>
> [DIRMINA-992 ]
> NioSocketConnector.newHandle throws the wrong exception
> [DIRMINA-994 ] The
> ConnectionRequest.cancel() method is inconsistent wrt concurrent
> access
> [DIRMINA-995 ]
> Deadlock when using SSL and proxy
> [DIRMINA-1013 ]
> Threading model is supressed by ProtocolCodecFilter
> [DIRMINA-1016 ]
> Regression with 2.0.9: Missing javax.net.ssl import in manifest
> [DIRMINA-1017 ]
> SSLEngine BUFFER_OVERFLOW (unwrap)
> [DIRMINA-1019 ]
> SslHandler flushScheduledEvents race condition
>
>
> A temporary tag has been created (it can be removed if the vote is not
> approved):
>
> - GIT tag : "2.0.10" SHA-1 : "d0263e8a00cf6e60d18317d1e8899554c53083bc"
>
> Project: http://git-wip-us.apache.org/repos/asf/mina/repo
> Commit:http://git-wip-us.apache.org/repos/asf/mina/commit/d0263e8a
> Tree:http://git-wip-us.apache.org/repos/asf/mina/tree/d0263e8a
>
>
> - Nexus 
> repository:https://repository.apache.org/content/repositories/orgapachemina-1015
>
> -Binaries:http://people.apache.org/~elecharny
>
> Let us vote :
> [ ] +1 | Release MINA 2.0.10
> [ ] ± | Abstain
> [ ] -1 | Do **NOT**  release MINA 2.0.10
>
> Thanks !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com



-- 
thanks
ashish

Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal

RE: [VOTE] MINA 2.0.10 release

[Lyor Goldstein]

+1

-Original Message-
From: Guillaume Nodet [mailto:gno...@apache.org] 
Sent: Friday, December 11, 2015 09:20
To: dev@mina.apache.org; Lecharny, Emmanuel (EMC) 
Subject: Re: [VOTE] MINA 2.0.10 release

+1

2015-12-07 11:08 GMT+01:00 Emmanuel Lecharny :

> Hi,
>
> Here is a vote for a new bug fix release of Mina 2 : 2.0.10.
>
> No new features, but a few critical fixes :
>
> - a race condition in the SSL handler
>
> - some OSGi package declaration fixes
>
> - removed a lock in the decoder, speeding up MINA.
>
> Here is the list of fixed issues :
> Improvements :
> --
>
> [DIRMINA-1018 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D1018-0A&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVe
> Aw-YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDN
> up0V5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=dGwsnis_72LTWrGNwTuK7XqidqqDh
> dIf6t1mtOP3tK8&e= > ">]FetchAppBuffer shrink
> [DIRMINA-1020 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D1020&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0
> V5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=x8EIgcjD2d7QxzBXcSA_c0W2iNx5DGID
> T9x2cuUiFic&e= ">]Change minimum version for slf4j in MANIFEST
>
> Bugs :
> --
>
> [DIRMINA-992 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D992&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-Y
> ihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0V
> 5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=ZsvX3sr-Z7lpThZ-lN1TABcFFWhc-j-yC
> c9VzZYutTU&e= ">] NioSocketConnector.newHandle throws the wrong 
> exception
> [DIRMINA-994 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D994&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-Y
> ihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0V
> 5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=ClqqY-vdA5BZm665WmYojmoDk880idBRA
> y7CTyOMcZ8&e= ">] The
> ConnectionRequest.cancel() method is inconsistent wrt concurrent 
> access
> [DIRMINA-995 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D995&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-Y
> ihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0V
> 5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=FbzS-f0ynHTBN_kLLadGdivgxVndCG4Ul
> H3jnp1RSHo&e= ">] Deadlock when using SSL and proxy
> [DIRMINA-1013 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D1013&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0
> V5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=NQCKVvZT70e-HjvQmMdqxDNbioteYpeB
> M8YYx83L9aA&e= ">] Threading model is supressed by ProtocolCodecFilter
> [DIRMINA-1016 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D1016&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0
> V5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=dlS978wzj8mMy6wSVgAHhtxJdJdu8aqP
> gtauZUZS2xg&e= ">] Regression with 2.0.9: Missing javax.net.ssl import 
> in manifest
> [DIRMINA-1017 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D1017&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0
> V5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=DZWRxqgJUKx4riezOjMAFxlmJHkOUOfs
> qheMsaBesSI&e= ">] SSLEngine BUFFER_OVERFLOW (unwrap)
> [DIRMINA-1019 
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.or
> g_jira_browse_DIRMINA-2D1019&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-
> YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=64kDNup0
> V5PfRw2QzHAsLpub5nP5Wg371KC_L6JEI98&s=eHZF8bcfOdcHKSIH8V-9AO8SLuEQHSJc
> XYU0p_ChYU0&e= ">] SslHandler flushScheduledEvents race condition
>
>
> A temporary tag has been created (it can be removed if the vote is not
> approved):
>
> - GIT tag : "2.0.10" SHA-1 : "d0263e8a00cf6e60d18317d1e8899554c53083bc"
>
> Project: 
> https://urldefense.proofpoint.com/v2/url?u=http-3A__git-2Dwip-2Dus.apa
> che.org_repos_asf_mina_repo&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-Y
> ihVMNtXt-uEs&

Re: [VOTE] MINA 2.0.10 release

[Guillaume Nodet]

+1

2015-12-07 11:08 GMT+01:00 Emmanuel Lecharny :

> Hi,
>
> Here is a vote for a new bug fix release of Mina 2 : 2.0.10.
>
> No new features, but a few critical fixes :
>
> - a race condition in the SSL handler
>
> - some OSGi package declaration fixes
>
> - removed a lock in the decoder, speeding up MINA.
>
> Here is the list of fixed issues :
> Improvements :
> --
>
> [DIRMINA-1018  ">]FetchAppBuffer
> shrink
> [DIRMINA-1020 ]Change
> minimum version for slf4j in MANIFEST
>
> Bugs :
> --
>
> [DIRMINA-992 ]
> NioSocketConnector.newHandle throws the wrong exception
> [DIRMINA-994 ] The
> ConnectionRequest.cancel() method is inconsistent wrt concurrent
> access
> [DIRMINA-995 ]
> Deadlock when using SSL and proxy
> [DIRMINA-1013 ]
> Threading model is supressed by ProtocolCodecFilter
> [DIRMINA-1016 ]
> Regression with 2.0.9: Missing javax.net.ssl import in manifest
> [DIRMINA-1017 ]
> SSLEngine BUFFER_OVERFLOW (unwrap)
> [DIRMINA-1019 ]
> SslHandler flushScheduledEvents race condition
>
>
> A temporary tag has been created (it can be removed if the vote is not
> approved):
>
> - GIT tag : "2.0.10" SHA-1 : "d0263e8a00cf6e60d18317d1e8899554c53083bc"
>
> Project: http://git-wip-us.apache.org/repos/asf/mina/repo
> Commit:http://git-wip-us.apache.org/repos/asf/mina/commit/d0263e8a
> Tree:http://git-wip-us.apache.org/repos/asf/mina/tree/d0263e8a
>
>
> - Nexus repository:
> https://repository.apache.org/content/repositories/orgapachemina-1015
>
> -Binaries:http://people.apache.org/~elecharny
>
> Let us vote :
> [ ] +1 | Release MINA 2.0.10
> [ ] ± | Abstain
> [ ] -1 | Do **NOT**  release MINA 2.0.10
>
> Thanks !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>

Re: [VOTE] MINA 2.0.10 release

[Emmanuel Lécharny]

Hi,

replying to Jeff's mail I never received (no idea why...) :


   - mina-example: contains log4j.properties + MANIFEST.MF does not contain
   OSGI metadata

I don't see why the example package, which is not intended to be included in 
any project, should expose OSGI metadata. This is just a set of examples for 
users to understand how MINA is working.

   - mina-integration-beans: import org.apache.mina.transport.vmpipe but
   not org.apache.mina.core packages, don't know if this is relevant

We do expose the needed imports :

  

  
org.apache.felix
maven-bundle-plugin
true
true

  META-INF
  

${project.groupId}.integration.beans

  
org.apache.mina.integration.beans;version=${project.version};-noimport:=true


  org.apache.mina.transport.vmpipe;version=${project.version},

  

  

  


resulting to  :

Export-Package: org.apache.mina.integration.beans;version="2.0.11.SNAPSHOT"
Import-Package: org.apache.mina.transport.vmpipe;version="2.0.11.SNAPSHOT"

The 'org.apache.mina.transport.vmpipe' package is all what we need from 
mina-core


 - mina-integration-xbean: MANIFEST.MF does not contain OSGI metadata

Not sure it was intended to expose anything OSGI related for a package that is 
intended to be pure Spring.

Re: [VOTE] MINA 2.0.10 release

[Emmanuel Lécharny]

Le 10/12/15 15:55, Ashish a écrit :
> Do we still continue the vote with Jeff's binding -1?

Seems like I never received it, but it's on the archive.

Give me some time to process the info

Thanks !

Re: [VOTE] MINA 2.0.10 release

[Emmanuel Lécharny]

Le 10/12/15 15:55, Ashish a écrit :
> Do we still continue the vote with Jeff's binding -1?

H. I haven't seen his vote...

Re: [VOTE] MINA 2.0.10 release

[Ashish]

Do we still continue the vote with Jeff's binding -1?

On Wed, Dec 9, 2015 at 11:12 PM, Emmanuel Lecharny  wrote:
> Reminder ...
>
>
> -- Forwarded message --
> From: Emmanuel Lecharny 
> Date: Mon, Dec 7, 2015 at 11:08 AM
> Subject: [VOTE] MINA 2.0.10 release
> To: "dev@mina.apache.org" 
>
>
> Hi,
>
> Here is a vote for a new bug fix release of Mina 2 : 2.0.10.
>
> No new features, but a few critical fixes :
>
> - a race condition in the SSL handler
>
> - some OSGi package declaration fixes
>
> - removed a lock in the decoder, speeding up MINA.
>
> Here is the list of fixed issues :
> Improvements :
> --
>
> [DIRMINA-1018 
> ]FetchAppBuffer
> shrink
> [DIRMINA-1020 ]Change
> minimum version for slf4j in MANIFEST
>
> Bugs :
> --
>
> [DIRMINA-992 ]
> NioSocketConnector.newHandle throws the wrong exception
> [DIRMINA-994 ] The
> ConnectionRequest.cancel() method is inconsistent wrt concurrent
> access
> [DIRMINA-995 ]
> Deadlock when using SSL and proxy
> [DIRMINA-1013 ]
> Threading model is supressed by ProtocolCodecFilter
> [DIRMINA-1016 ]
> Regression with 2.0.9: Missing javax.net.ssl import in manifest
> [DIRMINA-1017 ]
> SSLEngine BUFFER_OVERFLOW (unwrap)
> [DIRMINA-1019 ]
> SslHandler flushScheduledEvents race condition
>
>
> A temporary tag has been created (it can be removed if the vote is not
> approved):
>
> - GIT tag : "2.0.10" SHA-1 : "d0263e8a00cf6e60d18317d1e8899554c53083bc"
>
> Project: http://git-wip-us.apache.org/repos/asf/mina/repo
> Commit:http://git-wip-us.apache.org/repos/asf/mina/commit/d0263e8a
> Tree:http://git-wip-us.apache.org/repos/asf/mina/tree/d0263e8a
>
>
> - Nexus 
> repository:https://repository.apache.org/content/repositories/orgapachemina-1015
>
> -Binaries:http://people.apache.org/~elecharny
>
> Let us vote :
> [ ] +1 | Release MINA 2.0.10
> [ ] ± | Abstain
> [ ] -1 | Do **NOT**  release MINA 2.0.10
>
> Thanks !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com



-- 
thanks
ashish

Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal

Re: [VOTE] MINA 2.0.10 release

[Jeff MAURY]

Please find my following remarks:


   - mina-example: contains log4j.properties + MANIFEST.MF does not contain
   OSGI metadata
   - mina-integration-beans: import org.apache.mina.transport.vmpipe but
   not org.apache.mina.core packages, don't know if this is relevant
   - mina-integration-xbean: MANIFEST.MF does not contain OSGI metadata


So, for the last point, here is my -1

Jeff


On Mon, Dec 7, 2015 at 11:08 AM, Emmanuel Lecharny 
wrote:

> Hi,
>
> Here is a vote for a new bug fix release of Mina 2 : 2.0.10.
>
> No new features, but a few critical fixes :
>
> - a race condition in the SSL handler
>
> - some OSGi package declaration fixes
>
> - removed a lock in the decoder, speeding up MINA.
>
> Here is the list of fixed issues :
> Improvements :
> --
>
> [DIRMINA-1018  ">]FetchAppBuffer
> shrink
> [DIRMINA-1020 ]Change
> minimum version for slf4j in MANIFEST
>
> Bugs :
> --
>
> [DIRMINA-992 ]
> NioSocketConnector.newHandle throws the wrong exception
> [DIRMINA-994 ] The
> ConnectionRequest.cancel() method is inconsistent wrt concurrent
> access
> [DIRMINA-995 ]
> Deadlock when using SSL and proxy
> [DIRMINA-1013 ]
> Threading model is supressed by ProtocolCodecFilter
> [DIRMINA-1016 ]
> Regression with 2.0.9: Missing javax.net.ssl import in manifest
> [DIRMINA-1017 ]
> SSLEngine BUFFER_OVERFLOW (unwrap)
> [DIRMINA-1019 ]
> SslHandler flushScheduledEvents race condition
>
>
> A temporary tag has been created (it can be removed if the vote is not
> approved):
>
> - GIT tag : "2.0.10" SHA-1 : "d0263e8a00cf6e60d18317d1e8899554c53083bc"
>
> Project: http://git-wip-us.apache.org/repos/asf/mina/repo
> Commit:http://git-wip-us.apache.org/repos/asf/mina/commit/d0263e8a
> Tree:http://git-wip-us.apache.org/repos/asf/mina/tree/d0263e8a
>
>
> - Nexus repository:
> https://repository.apache.org/content/repositories/orgapachemina-1015
>
> -Binaries:http://people.apache.org/~elecharny
>
> Let us vote :
> [ ] +1 | Release MINA 2.0.10
> [ ] ± | Abstain
> [ ] -1 | Do **NOT**  release MINA 2.0.10
>
> Thanks !
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>



-- 
Jeff MAURY


"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury