[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/292#issuecomment-199137191
  
Thanks for following up, @pvillard31 . I think maybe building with other 
default locales may be worth exploring to add to travis-ci (tagging @apiri who 
may know if that's possible (I added -Duser.language=fr -Duser.region=FR to my 
env when testing))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Closing in on the Apache NiFi 0.6.0 release

[Tony Kurc]

The Locale issue was reviewed, confirmed as fixed by reporter and merged in.

On Sun, Mar 20, 2016 at 10:35 PM, Joe Witt  wrote:

> Team,
>
> There are a couple finishing touches PRs to fix a big defect in
> SplitText for certain input types, improve locale handling and test
> behavior for Kit bundle, and to clean up content viewing from
> connections.
>
> Getting good input on findings folks have so please keep it coming as
> that helps ensure a solid/healthy RC.
>
> Thanks
> Joe
>
> On Sat, Mar 19, 2016 at 6:21 PM, Tony Kurc  wrote:
> > Recommend https://issues.apache.org/jira/browse/NIFI-1651 be included in
> > 0.6.0
> >
> > On Wed, Mar 16, 2016 at 4:08 PM, Joe Witt  wrote:
> >
> >> Team,
> >>
> >> Ok sooo close.  We have 5 tickets remaining.
> >>
> >> - Additional functionality/cleanup for SplitText [1]
> >> [status] Still in discussions. Recommend we move this change to 0.7.0.
> >> Solid effort on both code contributor and reviewer side but this is a
> >> tricky one.
> >>
> >> - Support Kerberos based authentication to REST API [2]
> >> [status] PR is in. Reviewing and PR tweaking appears active.  Looks
> >> quite close and comments indicate great results.
> >>
> >> - Add Kerberos support to HBase processors [3]
> >> [status] Patch in. Under review.  Running on live test system with
> >> great results.
> >>
> >> - Add support for Spring Context loaded processors (Spring
> >> Integrations, Camel, ...) [4]
> >> [status] Appears ready. Getting review feedback.
> >>
> >> - Zookeeper interaction for NiFI state management should limit state to
> >> 1MB [6]
> >> [status] Patch is in and review under way.  Looks close.
> >>
> >> [1] https://issues.apache.org/jira/browse/NIFI-1118
> >> [2] https://issues.apache.org/jira/browse/NIFI-1274
> >> [3] https://issues.apache.org/jira/browse/NIFI-1488
> >> [4] https://issues.apache.org/jira/browse/NIFI-1571
> >> [5] https://issues.apache.org/jira/browse/NIFI-1626
> >>
> >> Thanks
> >>
> >> On Wed, Mar 16, 2016 at 4:04 PM, Joe Witt  wrote:
> >> > Team,
> >> >
> >> > Ok sooo close.  We have 6 tickets remaining.
> >> >
> >> > - Additional functionality/cleanup for SplitText [1]
> >> > [status] Still in discussions. Recommend we move this change to 0.7.0.
> >> > Solid effort on both code contributor and reviewer side but this is a
> >> > tricky one.
> >> >
> >> > - Support Kerberos based authentication to REST API [2]
> >> > [status] PR is in. Reviewing and PR tweaking appears active.  Looks
> >> > quite close and comments indicate great results.
> >> >
> >> > - Add Kerberos support to HBase processors [3]
> >> > [status] Patch in. Under review.  Running on live test system with
> >> > great results.
> >> >
> >> > - Add support for Spring Context loaded processors (Spring
> >> > Integrations, Camel, ...) [4]
> >> > [status] Appears ready. Getting review feedback.
> >> >
> >> > - Support based database snapshot/query/change capture [5]
> >> > [status] Appears ready. Needs review.
> >> >
> >> > - Zookeeper interaction for NiFI state management should limit state
> to
> >> 1MB [6]
> >> > [status] Patch is in and review under way.  Looks close.
> >> >
> >> > [1] https://issues.apache.org/jira/browse/NIFI-1118
> >> > [2] https://issues.apache.org/jira/browse/NIFI-1274
> >> > [3] https://issues.apache.org/jira/browse/NIFI-1488
> >> > [4] https://issues.apache.org/jira/browse/NIFI-1571
> >> > [5] https://issues.apache.org/jira/browse/NIFI-1575
> >> > [6] https://issues.apache.org/jira/browse/NIFI-1626
> >> >
> >> > Thanks
> >> > Joe
> >> >
> >> > On Tue, Mar 15, 2016 at 11:56 AM, Aldrin Piri 
> >> wrote:
> >> >> Sounds great.  Will scope those out in the process.  Thanks, Tony.
> >> >>
> >> >> On Tue, Mar 15, 2016 at 11:37 AM, Tony Kurc 
> wrote:
> >> >>
> >> >>> Aldrin,
> >> >>> I did some crappy shell scripts to help, I'll try to put those up on
> >> the
> >> >>> wiki.
> >> >>>
> >> >>> Tony
> >> >>>
> >> >>> On Tue, Mar 15, 2016 at 11:29 AM, Aldrin Piri  >
> >> >>> wrote:
> >> >>>
> >> >>> > In an effort to avoid me missing helpers and spamming the list, I
> >> will
> >> >>> > throw my hat into the ring to do this one.
> >> >>> >
> >> >>> > On Tue, Mar 15, 2016 at 11:28 AM, Joe Witt 
> >> wrote:
> >> >>> >
> >> >>> > > Team,
> >> >>> > >
> >> >>> > > Seeing good progress today.  Great!
> >> >>> > >
> >> >>> > > I know I volunteered to do the RM for the release but now I need
> >> to be
> >> >>> > > out of town and will have questionable Internet access.  Can
> >> someone
> >> >>> > > else grab it?
> >> >>> > >
> >> >>> > > Thanks
> >> >>> > > Joe
> >> >>> > >
> >> >>> > > On Mon, Mar 14, 2016 at 9:01 PM, Joe Witt 
> >> wrote:
> >> >>> > > > Team,
> >> >>> > > >
> >> >>> > > > Things are closing in well but we need to get pretty specific
> on
> >> >>> these
> >> >>> > > > to keep the release moving 

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/292


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/292#issuecomment-199134795
  
Everything OK, I'm a :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Closing in on the Apache NiFi 0.6.0 release

[Joe Witt]

Team,

There are a couple finishing touches PRs to fix a big defect in
SplitText for certain input types, improve locale handling and test
behavior for Kit bundle, and to clean up content viewing from
connections.

Getting good input on findings folks have so please keep it coming as
that helps ensure a solid/healthy RC.

Thanks
Joe

On Sat, Mar 19, 2016 at 6:21 PM, Tony Kurc  wrote:
> Recommend https://issues.apache.org/jira/browse/NIFI-1651 be included in
> 0.6.0
>
> On Wed, Mar 16, 2016 at 4:08 PM, Joe Witt  wrote:
>
>> Team,
>>
>> Ok sooo close.  We have 5 tickets remaining.
>>
>> - Additional functionality/cleanup for SplitText [1]
>> [status] Still in discussions. Recommend we move this change to 0.7.0.
>> Solid effort on both code contributor and reviewer side but this is a
>> tricky one.
>>
>> - Support Kerberos based authentication to REST API [2]
>> [status] PR is in. Reviewing and PR tweaking appears active.  Looks
>> quite close and comments indicate great results.
>>
>> - Add Kerberos support to HBase processors [3]
>> [status] Patch in. Under review.  Running on live test system with
>> great results.
>>
>> - Add support for Spring Context loaded processors (Spring
>> Integrations, Camel, ...) [4]
>> [status] Appears ready. Getting review feedback.
>>
>> - Zookeeper interaction for NiFI state management should limit state to
>> 1MB [6]
>> [status] Patch is in and review under way.  Looks close.
>>
>> [1] https://issues.apache.org/jira/browse/NIFI-1118
>> [2] https://issues.apache.org/jira/browse/NIFI-1274
>> [3] https://issues.apache.org/jira/browse/NIFI-1488
>> [4] https://issues.apache.org/jira/browse/NIFI-1571
>> [5] https://issues.apache.org/jira/browse/NIFI-1626
>>
>> Thanks
>>
>> On Wed, Mar 16, 2016 at 4:04 PM, Joe Witt  wrote:
>> > Team,
>> >
>> > Ok sooo close.  We have 6 tickets remaining.
>> >
>> > - Additional functionality/cleanup for SplitText [1]
>> > [status] Still in discussions. Recommend we move this change to 0.7.0.
>> > Solid effort on both code contributor and reviewer side but this is a
>> > tricky one.
>> >
>> > - Support Kerberos based authentication to REST API [2]
>> > [status] PR is in. Reviewing and PR tweaking appears active.  Looks
>> > quite close and comments indicate great results.
>> >
>> > - Add Kerberos support to HBase processors [3]
>> > [status] Patch in. Under review.  Running on live test system with
>> > great results.
>> >
>> > - Add support for Spring Context loaded processors (Spring
>> > Integrations, Camel, ...) [4]
>> > [status] Appears ready. Getting review feedback.
>> >
>> > - Support based database snapshot/query/change capture [5]
>> > [status] Appears ready. Needs review.
>> >
>> > - Zookeeper interaction for NiFI state management should limit state to
>> 1MB [6]
>> > [status] Patch is in and review under way.  Looks close.
>> >
>> > [1] https://issues.apache.org/jira/browse/NIFI-1118
>> > [2] https://issues.apache.org/jira/browse/NIFI-1274
>> > [3] https://issues.apache.org/jira/browse/NIFI-1488
>> > [4] https://issues.apache.org/jira/browse/NIFI-1571
>> > [5] https://issues.apache.org/jira/browse/NIFI-1575
>> > [6] https://issues.apache.org/jira/browse/NIFI-1626
>> >
>> > Thanks
>> > Joe
>> >
>> > On Tue, Mar 15, 2016 at 11:56 AM, Aldrin Piri 
>> wrote:
>> >> Sounds great.  Will scope those out in the process.  Thanks, Tony.
>> >>
>> >> On Tue, Mar 15, 2016 at 11:37 AM, Tony Kurc  wrote:
>> >>
>> >>> Aldrin,
>> >>> I did some crappy shell scripts to help, I'll try to put those up on
>> the
>> >>> wiki.
>> >>>
>> >>> Tony
>> >>>
>> >>> On Tue, Mar 15, 2016 at 11:29 AM, Aldrin Piri 
>> >>> wrote:
>> >>>
>> >>> > In an effort to avoid me missing helpers and spamming the list, I
>> will
>> >>> > throw my hat into the ring to do this one.
>> >>> >
>> >>> > On Tue, Mar 15, 2016 at 11:28 AM, Joe Witt 
>> wrote:
>> >>> >
>> >>> > > Team,
>> >>> > >
>> >>> > > Seeing good progress today.  Great!
>> >>> > >
>> >>> > > I know I volunteered to do the RM for the release but now I need
>> to be
>> >>> > > out of town and will have questionable Internet access.  Can
>> someone
>> >>> > > else grab it?
>> >>> > >
>> >>> > > Thanks
>> >>> > > Joe
>> >>> > >
>> >>> > > On Mon, Mar 14, 2016 at 9:01 PM, Joe Witt 
>> wrote:
>> >>> > > > Team,
>> >>> > > >
>> >>> > > > Things are closing in well but we need to get pretty specific on
>> >>> these
>> >>> > > > to keep the release moving roughly along the lines of the
>> schedule
>> >>> > > > we've discussed previously.  Those of you who have tickets on
>> here
>> >>> > > > that can be moved to 0.7.0 please do so.  Otherwise, let's please
>> >>> keep
>> >>> > > > discussion/status information up so we can all see how we're
>> trending
>> >>> > > > toward release candidate readiness.
>> >>> > > >
>> >>> > > > The current items on the release based on 

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

[joewitt]

Github user joewitt commented on the pull request:

https://github.com/apache/nifi/pull/272#issuecomment-199086549
  
@pvillard31 If you stay focused on the goal of NIFI-1620 here and avoid the 
body manipulation this seems like a good step.  Clearly you found a case worthy 
of support (null body means unset or empty strong content type).  But, i do 
share Adam's view that it is best to avoid the content manipulation here.  Do 
you agree or do you feel like for the use case(s) you envisioned this would be 
problematic?

Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1620 Allow empty Content-Type in InvokeHTT...

[taftster]

Github user taftster commented on the pull request:

https://github.com/apache/nifi/pull/272#issuecomment-199086081
  
This pull request is not strictly dealing with NIFI-1620.  The edge case of 
suppressing the Content-Type header for an empty message-body makes sense to 
fix and address. NIFI-1620 is dealing with this edge case.

However, this PR is adding the ability to specify an HTTP request 
message-body directly as a property of InvokeHTTP.  In my opinion, this is not 
a desired feature, and I am -1 on this.  A static message-body can always be 
provided in a dataflow using a tool like ReplaceText; keeping the semantics 
that InvokeHTTP always reads from flowfile payloads has a good consistency.

Recommend that this PR focus solely on the problem dealing with 
Content-Type of an empty payload for a POST/PUT operation.  Another JIRA can be 
opened to discuss the merits of how to provide static content to an HTTP 
transaction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/292#issuecomment-199051348
  
@pvillard31 - can you try this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1656 Added locale support to ConvertAvroSc...

[trkurc]

GitHub user trkurc opened a pull request:

https://github.com/apache/nifi/pull/292

NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale …

…problems in unit tests
See:
https://issues.apache.org/jira/browse/NIFI-1656

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/trkurc/nifi NIFI-1656

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #292


commit 56832747d365ca87ecc51660e3d9637d9dee825f
Author: trkurc 
Date:   2016-03-20T22:25:04Z

NIFI-1656 Added locale support to ConvertAvroSchema and fixed locale 
problems in unit tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198997621
  
So, likely needs a processor change to add a default locale and some 
ability to override it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1578: Create PutSlack processor

[joewitt]

Github user joewitt commented on the pull request:

https://github.com/apache/nifi/pull/256#issuecomment-198996892
  
@adamonduty Saw your tweet. 
https://twitter.com/microbatch/status/711618210886340608  I've not worked with 
Slack myself but have heard very positive things.  We should definitely work 
this into the next feature release.  Would be cool to hear a bit about your use 
case ideas for this or how you are using it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[joewitt]

Github user joewitt commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198995171
  
hmm good find @pvillard31  We need to make the code more locale tolerant 
apparently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198994990
  
Just for the record, the error is because of my local env. This is fixed by 
setting the locale to US on the scanner:

`scanner.useLocale(java.util.Locale.US);`

I don't know if there is a way to set this at a global scale.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/291


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198987604
  
@trkurc I am currently checking on my side why the other unit tests are in 
failure. But as you said, this is not related to this PR, so it is OK for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198986806
  
@pvillard31 - I was able to replicate the errors in the txt file you 
included by adding \r's to the file (windows line endings). The other errors 
are on tests that haven't changed in this PR, but I can dig in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198982574
  
Sorry for the delay... I am on a different computer than usual and forgot 
to check the git property. Did a full clone again (so slow with airport 
wifi...) and checked the schema (looks OK to me). The git property solved most 
of the issues, but some are remaining:

```
Running org.apache.nifi.processors.kite.TestAvroRecordConverter
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.377 sec 
<<< FAILURE! - in org.apache.nifi.processors.kite.TestAvroRecordConverter

testDefaultConversion(org.apache.nifi.processors.kite.TestAvroRecordConverter)  
Time elapsed: 0.011 sec  <<< ERROR!

org.apache.nifi.processors.kite.AvroRecordConverter$AvroConversionException: 
Cannot convert 5.5 to double
at 
org.apache.nifi.processors.kite.AvroRecordConverter.convertData(AvroRecordConverter.java:246)
at 
org.apache.nifi.processors.kite.AvroRecordConverter.convert(AvroRecordConverter.java:170)
at 
org.apache.nifi.processors.kite.TestAvroRecordConverter.testDefaultConversion(TestAvroRecordConverter.java:98)

Running org.apache.nifi.processors.kite.TestConfigurationProperty
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.849 sec - 
in org.apache.nifi.processors.kite.TestConfigurationProperty
Running org.apache.nifi.processors.kite.TestConvertAvroSchema
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.22 sec 
<<< FAILURE! - in org.apache.nifi.processors.kite.TestConvertAvroSchema
testBasicConversion(org.apache.nifi.processors.kite.TestConvertAvroSchema)  
Time elapsed: 0.21 sec  <<< FAILURE!
java.lang.AssertionError: Should convert 2 rows expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at 
org.apache.nifi.processors.kite.TestConvertAvroSchema.testBasicConversion(TestConvertAvroSchema.java:78)
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[apiri]

Github user apiri commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198978900
  
Windows 7, Maven 3.3.3, and JDK 8u71 looks good here.  

Will look for updates from @pvillard31 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[mosermw]

Github user mosermw commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198974775
  
Using Windows 10, maven 3.3.9, java 1.7.0_79 the nifi-kite-bundle fails on 
this unit test before this patch.  nifi-kite-bundle unit tests work fine after 
this patch.  +1 from me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198971642
  
Did you clone the code with autocrlf? Does the schema in src/test/resources 
have line endings?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198970178
  
Windows 7 Pro / Maven 3.3.9 / Java 1.8.0_74


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198969736
  
Pierre, what environment are you running on?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Re: Re: Re: Processor additional documentation

[Joe Witt]

Uwe

Noticed your other threads on great progress.  That is awesome.

Really want to help you get to the bottom of the additional details
piece though.  We clearly have to do a better job with documenting (or
implementing) how to do this.  Do you have any more details to share
on symptoms you're seeing?

Thanks
Joe

On Fri, Mar 18, 2016 at 5:35 PM, Uwe Geercken  wrote:
> Dan,
>
> ok. I was wrong. The index file is created - it's my additionalDetails.html 
> file that is missing. I have no idea what is wrong.
>
> I will try it tomorrow - maybe I will find something with a clear head.
>
> Rgds,
>
> Uwe
>
>> Gesendet: Freitag, 18. März 2016 um 19:14 Uhr
>> Von: "dan bress" 
>> An: dev@nifi.apache.org
>> Betreff: Re: Re: Re: Processor additional documentation
>>
>> Uwe,
>>No, the index.html is generated for you.  additionalDetails.html is your
>> responsibility only if you feel like the generated index.html doesn't fully
>> describe your processor.
>>
>>I would guess 80% of the included processors do not have
>> additionalDetails.html.  If you haven't browsed here [1] at examples of the
>> generated index.html and user supplied additionalDetails.html, it might
>> clear things up.
>>
>> [1] https://nifi.apache.org/docs.html
>>
>> Dan
>>
>> On Fri, Mar 18, 2016 at 11:08 AM Uwe Geercken  wrote:
>>
>> > Dan,
>> >
>> > but maybe I have a wrong understanding: do I have to create an index.html
>> > file? Currently I have only created an additionalDetails.html file.
>> >
>> > I will also try to reduce the html code to a minimum and see if it is a
>> > problem with my code.
>> >
>> > Bye,
>> >
>> > Uwe
>> >
>> > > Gesendet: Freitag, 18. März 2016 um 19:03 Uhr
>> > > Von: "dan bress" 
>> > > An: dev@nifi.apache.org
>> > > Betreff: Re: Re: Processor additional documentation
>> > >
>> > > Uwe,
>> > >No its not a problem to have both index.html and
>> > additionalDetails.html
>> > >  The NiFi framework generates nearly all of the documentation for your
>> > > processor for you.  It will generate information about the properties and
>> > > relationships your processor exposes to its users.  If you need to
>> > express
>> > > more about your processor, then that is where additionalDetails.html
>> > comes
>> > > into play.  For example, if your processor uses a custom query language.
>> > >
>> > > Generated index.html example:
>> > >
>> > https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi.processors.attributes.UpdateAttribute/index.html
>> > >
>> > > additionalDetails.html example:
>> > >
>> > https://nifi.apache.org/docs/nifi-docs/components/org.apache.nifi.processors.attributes.UpdateAttribute/additionalDetails.html
>> > >
>> > > On Fri, Mar 18, 2016 at 10:54 AM Uwe Geercken 
>> > wrote:
>> > >
>> > > > Bryan,
>> > > >
>> > > > all looks ok. I looked into the nifi-home/work/docs folder. There is
>> > > > nothing but a components folder. Inside there is a folder for my
>> > processor:
>> > > > com.datamelt.nifi.test.TemplateProcessor and inside the folder there
>> > is a
>> > > > file index.html and it contains the code of my additionalDetails.html
>> > file.
>> > > >
>> > > > when I open the file in the web browser it looks good. I looked at
>> > other
>> > > > index.html files and they look similar.
>> > > >
>> > > > but I noted that some folders have an inde.html file AND an
>> > > > additionalDetails.html file. maybe that is the problem?
>> > > >
>> > > > greetings,
>> > > >
>> > > > Uwe
>> > > >
>> > > >
>> > > >
>> > > > Gesendet: Freitag, 18. März 2016 um 16:18 Uhr
>> > > > Von: "Bryan Bende" 
>> > > > An: dev@nifi.apache.org
>> > > > Betreff: Re: Processor additional documentation
>> > > > Hi Uwe,
>> > > >
>> > > > Do you have the additionalDetails.html file in your processors jar
>> > project,
>> > > > under src/main/resources?
>> > > >
>> > > > Similar to this:
>> > > >
>> > > >
>> > https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/resources
>> > > >
>> > > > The expected project structure is described here:
>> > > >
>> > > >
>> > https://cwiki.apache.org/confluence/display/NIFI/Maven+Projects+for+Extensions#MavenProjectsforExtensions-ExampleProcessorBundleStructure[https://cwiki.apache.org/confluence/display/NIFI/Maven+Projects+for+Extensions#MavenProjectsforExtensions-ExampleProcessorBundleStructure]
>> > 
>> > > > <
>> > 

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[pvillard31]

Github user pvillard31 commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198968796
  
Tried a mvn clean install without success on my side (I missed something?):
[mvn_output.txt](https://github.com/apache/nifi/files/181411/mvn_output.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

[apiri]

Github user apiri commented on the pull request:

https://github.com/apache/nifi/pull/291#issuecomment-198963197
  
reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

[markap14]

Github user markap14 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/280#discussion_r56329501
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
 ---
@@ -143,72 +199,82 @@ protected void init(final 
ProcessorInitializationContext context) {
 return properties;
 }
 
-private int readLines(final InputStream in, final int maxNumLines, 
final OutputStream out, final boolean keepAllNewLines) throws IOException {
+private int readLines(final InputStream in, final int maxNumLines, 
final long maxByteCount, final OutputStream out) throws IOException {
 int numLines = 0;
+long totalBytes = 0L;
 for (int i = 0; i < maxNumLines; i++) {
-final long bytes = countBytesToSplitPoint(in, out, 
keepAllNewLines || (i != maxNumLines - 1));
+final long bytes = countBytesToSplitPoint(in, out, totalBytes, 
maxByteCount);
+totalBytes += bytes;
 if (bytes <= 0) {
 return numLines;
 }
-
 numLines++;
+if (totalBytes >= maxByteCount && numLines > maxNumLines) {
+break;
+}
 }
-
 return numLines;
 }
 
-private long countBytesToSplitPoint(final InputStream in, final 
OutputStream out, final boolean includeLineDelimiter) throws IOException {
-int lastByte = -1;
+private long countBytesToSplitPoint(final InputStream in, final 
OutputStream out, final long bytesReadSoFar, final long maxSize) throws 
IOException {
 long bytesRead = 0L;
+final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
--- End diff --

It looks like we always buffer this data into Java heap, but we don't 
actually use it for anything if out == null (which is the case more often than 
not, I believe). This is pretty concerning, as we should avoid buffering 
potentially large amounts of data into Java heap unless absolutely necessary. I 
think this needs to be reworked so that we don't buffer the data here, if out 
== null, since we won't make use of it anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] nifi pull request: NIFI-856 Implements experimental ListenLumberja...

[Andre]

All,

Apologies for the mess, git got me on this one.

This is my first code contribution in Java and will probably sound a bit
like gibberish to my untrained ears, so please be nice. :-)

Cheers



On Sat, Mar 19, 2016 at 2:37 AM, trixpan  wrote:

> GitHub user trixpan opened a pull request:
>
> https://github.com/apache/nifi/pull/290
>
> NIFI-856  Implements experimental ListenLumberjack Processor
>
> ListenLumberjack processor should allow NiFi to act as a drop in
> replacement on pipelines
> using logstash-forwarder and Logstash's Lumberjack output to move data
> created by
> distributed systems.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/trixpan/nifi NIFI-856v2
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/nifi/pull/290.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #290
>
> 
> commit 777852f1e994be737eeb3f8b832ffd3db25e02f7
> Author: Andre F de Miranda 
> Date:   2016-03-18T14:41:35Z
>
> NIFI-856  Implements experimental ListenLumberjack Processor
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

[mattyb149]

Github user mattyb149 commented on the pull request:

https://github.com/apache/nifi/pull/273#issuecomment-198199315
  
LGTM, successfully built PR, ran unit tests, and tested with running NiFi 
with both a CSV file and an Atom file (both types recognized by extension: 
https://github.com/apache/tika/blob/master/tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml)
 +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

[trkurc]

Github user trkurc commented on the pull request:

https://github.com/apache/nifi/pull/271#issuecomment-197323770
  
@olegz: A sample app would be great. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-site pull request: Added Matt Burgess to committers

[mattyb149]

Github user mattyb149 closed the pull request at:

https://github.com/apache/nifi-site/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/271#discussion_r56446641
  
--- Diff: 
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
 ---
@@ -0,0 +1,392 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.spring;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.nifi.annotation.behavior.TriggerWhenEmpty;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Processor;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.io.InputStreamCallback;
+import org.apache.nifi.processor.io.OutputStreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.spring.SpringDataExchanger.SpringResponse;
+import org.apache.nifi.stream.io.StreamUtils;
+import org.apache.nifi.util.FormatUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.messaging.Message;
+import org.springframework.messaging.MessageChannel;
+import org.springframework.messaging.PollableChannel;
+
+/**
+ * Implementation of {@link Processor} capable of sending and receiving 
data
+ * from application defined in Spring Application context. It does so via
+ * predefined in/out {@link MessageChannel}s (see spring-messaging module 
of
+ * Spring). Once such channels are defined user is free to implement the 
rest of
+ * the application any way they wish (e.g., custom code and/or using 
frameworks
+ * such as Spring Integration or Camel).
+ * 
+ * The requirement and expectations for channel types are:
+ * 
+ * Input channel must be of type {@link MessageChannel} and named 
"fromNiFi"
+ * (see {@link SpringNiFiConstants#FROM_NIFI})
+ * Output channel must be of type {@link PollableChannel} and named 
"toNiFi"
+ * (see {@link SpringNiFiConstants#TO_NIFI})
+ * 
+ * 
+ * Below is the example of sample configuration:
+ *
+ * 
+ * ?xml version="1.0" encoding="UTF-8"?
+ * beans xmlns="http://www.springframework.org/schema/beans;
+ *   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ *   xmlns:int="http://www.springframework.org/schema/integration;
+ *  xsi:schemaLocation="http://www.springframework.org/schema/beans 
http://www.springframework.org/schema/beans/spring-beans.xsd
+ *  http://www.springframework.org/schema/integration 
http://www.springframework.org/schema/integration/spring-integration-4.2.xsd";
+ *
+ *  int:channel id="fromNiFi"/
+ *
+ *  . . . . .
+ *
+ *  int:channel id="toNiFi"
+ *  int:queue/
+ *  /int:channel
+ *
+ * /beans
+ * 
+ * 
+ * Defining {@link MessageChannel} is optional. That's why this processor
+ * supports 3 modes of interaction with Spring Application Context:
+ * 
+ * Headless – no channels are 

[GitHub] nifi pull request: Nifi 1274

[JPercivall]

Github user JPercivall commented on a diff in the pull request:

https://github.com/apache/nifi/pull/284#discussion_r56509790
  
--- Diff: 
nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/test/resources/nifi.properties
 ---
@@ -0,0 +1,185 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Core Properties #
+nifi.version=0.6.0-SNAPSHOT
+nifi.flow.configuration.file=./conf/flow.xml.gz
+nifi.flow.configuration.archive.dir=./conf/archive/
+nifi.flowcontroller.autoResumeState=true
+nifi.flowcontroller.graceful.shutdown.period=10 sec
+nifi.flowservice.writedelay.interval=500 ms
+nifi.administrative.yield.duration=30 sec
+# If a component has no work to do (is "bored"), how long should we wait 
before checking again for work?
+nifi.bored.yield.duration=10 millis
+
+nifi.authority.provider.configuration.file=./conf/authority-providers.xml

+nifi.login.identity.provider.configuration.file=./conf/login-identity-providers.xml
+nifi.templates.directory=./conf/templates
+nifi.ui.banner.text=
+nifi.ui.autorefresh.interval=30 sec
+nifi.nar.library.directory=./lib
+nifi.nar.working.directory=./work/nar/
+nifi.documentation.working.directory=./work/docs/components
+
+
+# State Management #
+
+nifi.state.management.configuration.file=./conf/state-management.xml
+# The ID of the local state provider
+nifi.state.management.provider.local=local-provider
+# The ID of the cluster-wide state provider. This will be ignored if NiFi 
is not clustered but must be populated if running in a cluster.
+nifi.state.management.provider.cluster=zk-provider
+# Specifies whether or not this instance of NiFi should run an embedded 
ZooKeeper server
+nifi.state.management.embedded.zookeeper.start=false
+# Properties file that provides the ZooKeeper properties to use if 
 is set to true

+nifi.state.management.embedded.zookeeper.properties=./conf/zookeeper.properties
+
+
+# H2 Settings
+nifi.database.directory=./database_repository
+nifi.h2.url.append=;LOCK_TIMEOUT=25000;WRITE_DELAY=0;AUTO_SERVER=FALSE
+
+# FlowFile Repository

+nifi.flowfile.repository.implementation=org.apache.nifi.controller.repository.WriteAheadFlowFileRepository
+nifi.flowfile.repository.directory=./flowfile_repository
+nifi.flowfile.repository.partitions=256
+nifi.flowfile.repository.checkpoint.interval=2 mins
+nifi.flowfile.repository.always.sync=false
+

+nifi.swap.manager.implementation=org.apache.nifi.controller.FileSystemSwapManager
+nifi.queue.swap.threshold=2
+nifi.swap.in.period=5 sec
+nifi.swap.in.threads=1
+nifi.swap.out.period=5 sec
+nifi.swap.out.threads=4
+
+# Content Repository

+nifi.content.repository.implementation=org.apache.nifi.controller.repository.FileSystemRepository
+nifi.content.claim.max.appendable.size=10 MB
+nifi.content.claim.max.flow.files=100
+nifi.content.repository.directory.default=./content_repository
+nifi.content.repository.archive.max.retention.period=12 hours
+nifi.content.repository.archive.max.usage.percentage=50%
+nifi.content.repository.archive.enabled=true
+nifi.content.repository.always.sync=false
+nifi.content.viewer.url=/nifi-content-viewer/
+
+# Provenance Repository Properties

+nifi.provenance.repository.implementation=org.apache.nifi.provenance.PersistentProvenanceRepository
+
+# Persistent Provenance Repository Properties
+nifi.provenance.repository.directory.default=./provenance_repository
+nifi.provenance.repository.max.storage.time=24 hours
+nifi.provenance.repository.max.storage.size=1 GB
+nifi.provenance.repository.rollover.time=30 secs
+nifi.provenance.repository.rollover.size=100 MB
+nifi.provenance.repository.query.threads=2
+nifi.provenance.repository.index.threads=1
+nifi.provenance.repository.compress.on.rollover=true
+nifi.provenance.repository.always.sync=false
+nifi.provenance.repository.journal.count=16
+# 

Re: [ANNOUNCE] New Apache NiFi Committer Oleg Zhurakousky

[Joe Percivall]

Congrats Oleg!
 - - - - - - 
Joseph Percivall
linkedin.com/in/Percivall
e: joeperciv...@yahoo.com




On Tuesday, March 15, 2016 9:45 PM, Jeremy Dyer  wrote:
Congrats Oleg!

Sent from my iPhone


> On Mar 15, 2016, at 9:01 PM, Ricky Saltzer  wrote:
> 
> Big congrats!
>> On Mar 15, 2016 8:42 PM, "Michael Moser"  wrote:
>> 
>> Yes, welcome Oleg!  Your hard work is very much appreciated by everyone.
>> 
>> -- Mike
>> 
>> 
>>> On Tue, Mar 15, 2016 at 8:22 PM, Matt Burgess  wrote:
>>> 
>>> Congratulations! Well deserved.
>>> 
 On Mar 15, 2016, at 8:17 PM, Tony Kurc  wrote:
 
 On behalf of the Apache NiFI PMC, I am very pleased to announce that
>> Oleg
 Zhurakousky has accepted the PMC's invitation to become a committer on
>>> the
 Apache NiFi project. We greatly appreciate all of Oleg's hard work and
 generous contributions to the project. We look forward to his continued
 involvement in the project.
 
 Some highlights of Oleg's contributions include identifying and
>>> mitigating
 some challenging framework bugs, amqp support in 0.5.x, and some pretty
 exciting spring support slated for 0.6.x. As I have noticed, many of
>> you
 have already had the opportunity to interact with Oleg on the mailing
 lists, the jiras, and pull request comments. I, for one, look forward
>> to
 the continued community support!
 
 Welcome and congratulations!
 
 Tony
>> 

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

[trkurc]

Github user trkurc commented on a diff in the pull request:

https://github.com/apache/nifi/pull/271#discussion_r56596211
  
--- Diff: 
nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java
 ---
@@ -0,0 +1,448 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.spring;
+
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.annotation.behavior.TriggerWhenEmpty;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Processor;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.io.InputStreamCallback;
+import org.apache.nifi.processor.io.OutputStreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.spring.SpringDataExchanger.SpringResponse;
+import org.apache.nifi.stream.io.StreamUtils;
+import org.apache.nifi.util.FormatUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.messaging.Message;
+import org.springframework.messaging.MessageChannel;
+import org.springframework.messaging.PollableChannel;
+
+/**
+ * Implementation of {@link Processor} capable of sending and receiving 
data
+ * from application defined in Spring Application context. It does so via
+ * predefined in/out {@link MessageChannel}s (see spring-messaging module 
of
+ * Spring). Once such channels are defined user is free to implement the 
rest of
+ * the application any way they wish (e.g., custom code and/or using 
frameworks
+ * such as Spring Integration or Camel).
+ * 
+ * The requirement and expectations for channel types are:
+ * 
+ * Input channel must be of type {@link MessageChannel} and named 
"fromNiFi"
+ * (see {@link SpringNiFiConstants#FROM_NIFI})
+ * Output channel must be of type {@link PollableChannel} and named 
"toNiFi"
+ * (see {@link SpringNiFiConstants#TO_NIFI})
+ * 
+ * 
+ * Below is the example of sample configuration:
+ *
+ * 
+ * ?xml version="1.0" encoding="UTF-8"?
+ * beans xmlns="http://www.springframework.org/schema/beans;
+ *   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ *   xmlns:int="http://www.springframework.org/schema/integration;
+ *  xsi:schemaLocation="http://www.springframework.org/schema/beans 
http://www.springframework.org/schema/beans/spring-beans.xsd
+ *  http://www.springframework.org/schema/integration 
http://www.springframework.org/schema/integration/spring-integration-4.2.xsd";
+ *
+ *  int:channel id="fromNiFi"/
+ *
+ *  . . . . .
+ *
+ *  int:channel id="toNiFi"
+ *  int:queue/
+ *  /int:channel
+ *
+ * /beans
+ * 
+ * 
+ * 

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

[jskora]

Github user jskora commented on a diff in the pull request:

https://github.com/apache/nifi/pull/280#discussion_r56322564
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
 ---
@@ -134,6 +168,28 @@ protected void init(final 
ProcessorInitializationContext context) {
 }
 
 @Override
+protected Collection 
customValidate(ValidationContext validationContext) {
+ArrayList results = new ArrayList<>();
--- End diff --

I'm fixing these.  Update will be pushed shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---