Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
+1 (binding) Verified signature, hashes, didn't see issues with LICENSE or NOTICE aside from what Joe mentioned. Build was a little bit of a challenge because of my environment (had some weird issues with dependency versions (MX Linux)), but powered through to a successful build and test. Tony On Tue, May 24, 2022 at 6:10 PM Joe Witt wrote: > +1 binding. > > Sigs, hashes, L overall look good (very thorough on L!) > > Need to fix the copyright year in NOTICE as it currently lists 2019. > > Thanks > > On Tue, May 24, 2022 at 12:04 PM Marc Parisi wrote: > > > +1 > > > > verified sigs and hashes. > > > > Ran a simple flow, starting, stopping, and changing flow with c2 > protocol. > > > > Everything looks good. Great stuff! > > > > Thanks, > > Marc > > > > > > > > On Tue, May 24, 2022 at 9:56 AM Martin Zink > wrote: > > > > > Good idea, I've renamed the convenience binary > > > > > > On Tue, May 24, 2022 at 2:54 PM Marton Szasz > wrote: > > > > > > > +1 (binding) > > > > > > > > Ran through the release helper guide. Tested the convenience binaries > > > > with a RPG to the NiFi release candidate, then InvokeHTTP to another > > > > MiNiFi C++ RC agent that I've built myself. > > > > > > > > I would rename the convenience binary package from > > > > nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to > > > > nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, > > > > since it works on basically all major linux distros, even though it's > > > > built on CentOS. We did the same with 0.11.0. > > > > > > > > Thanks! > > > > > > > > On Mon, 23 May 2022 at 13:28, Ferenc Gerlits > > > wrote: > > > > > > > > > > +1 (non-binding) > > > > > > > > > > I have > > > > > * verified the checksums and signatures > > > > > * compared the contents of the source tarball to the > > > > minifi-cpp-0.12.0-RC1 > > > > > tag in git > > > > > * ran the binary with a simple GenerateFlowFile -> LogAttribute > flow, > > > > with > > > > > heartbeat logging on > > > > > * connected to C2 > > > > > > > > > > Everything worked correctly. > > > > > > > > > > Thanks, > > > > > Ferenc > > > > > > > > > >
Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
+1 (non-binding) Checked signatures, hashes. Tested binary with a GenerateFlowFile -> LogAttribute flow. Tested c2 commands, debug, restart, property update. Thanks, Adam On Wed, May 25, 2022 at 12:11 AM Joe Witt wrote: > +1 binding. > > Sigs, hashes, L overall look good (very thorough on L!) > > Need to fix the copyright year in NOTICE as it currently lists 2019. > > Thanks > > On Tue, May 24, 2022 at 12:04 PM Marc Parisi wrote: > > > +1 > > > > verified sigs and hashes. > > > > Ran a simple flow, starting, stopping, and changing flow with c2 > protocol. > > > > Everything looks good. Great stuff! > > > > Thanks, > > Marc > > > > > > > > On Tue, May 24, 2022 at 9:56 AM Martin Zink > wrote: > > > > > Good idea, I've renamed the convenience binary > > > > > > On Tue, May 24, 2022 at 2:54 PM Marton Szasz > wrote: > > > > > > > +1 (binding) > > > > > > > > Ran through the release helper guide. Tested the convenience binaries > > > > with a RPG to the NiFi release candidate, then InvokeHTTP to another > > > > MiNiFi C++ RC agent that I've built myself. > > > > > > > > I would rename the convenience binary package from > > > > nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to > > > > nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, > > > > since it works on basically all major linux distros, even though it's > > > > built on CentOS. We did the same with 0.11.0. > > > > > > > > Thanks! > > > > > > > > On Mon, 23 May 2022 at 13:28, Ferenc Gerlits > > > wrote: > > > > > > > > > > +1 (non-binding) > > > > > > > > > > I have > > > > > * verified the checksums and signatures > > > > > * compared the contents of the source tarball to the > > > > minifi-cpp-0.12.0-RC1 > > > > > tag in git > > > > > * ran the binary with a simple GenerateFlowFile -> LogAttribute > flow, > > > > with > > > > > heartbeat logging on > > > > > * connected to C2 > > > > > > > > > > Everything worked correctly. > > > > > > > > > > Thanks, > > > > > Ferenc > > > > > > > > > >
Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
+1 binding. Sigs, hashes, L overall look good (very thorough on L!) Need to fix the copyright year in NOTICE as it currently lists 2019. Thanks On Tue, May 24, 2022 at 12:04 PM Marc Parisi wrote: > +1 > > verified sigs and hashes. > > Ran a simple flow, starting, stopping, and changing flow with c2 protocol. > > Everything looks good. Great stuff! > > Thanks, > Marc > > > > On Tue, May 24, 2022 at 9:56 AM Martin Zink wrote: > > > Good idea, I've renamed the convenience binary > > > > On Tue, May 24, 2022 at 2:54 PM Marton Szasz wrote: > > > > > +1 (binding) > > > > > > Ran through the release helper guide. Tested the convenience binaries > > > with a RPG to the NiFi release candidate, then InvokeHTTP to another > > > MiNiFi C++ RC agent that I've built myself. > > > > > > I would rename the convenience binary package from > > > nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to > > > nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, > > > since it works on basically all major linux distros, even though it's > > > built on CentOS. We did the same with 0.11.0. > > > > > > Thanks! > > > > > > On Mon, 23 May 2022 at 13:28, Ferenc Gerlits > > wrote: > > > > > > > > +1 (non-binding) > > > > > > > > I have > > > > * verified the checksums and signatures > > > > * compared the contents of the source tarball to the > > > minifi-cpp-0.12.0-RC1 > > > > tag in git > > > > * ran the binary with a simple GenerateFlowFile -> LogAttribute flow, > > > with > > > > heartbeat logging on > > > > * connected to C2 > > > > > > > > Everything worked correctly. > > > > > > > > Thanks, > > > > Ferenc > > > > > >
Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
+1 verified sigs and hashes. Ran a simple flow, starting, stopping, and changing flow with c2 protocol. Everything looks good. Great stuff! Thanks, Marc On Tue, May 24, 2022 at 9:56 AM Martin Zink wrote: > Good idea, I've renamed the convenience binary > > On Tue, May 24, 2022 at 2:54 PM Marton Szasz wrote: > > > +1 (binding) > > > > Ran through the release helper guide. Tested the convenience binaries > > with a RPG to the NiFi release candidate, then InvokeHTTP to another > > MiNiFi C++ RC agent that I've built myself. > > > > I would rename the convenience binary package from > > nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to > > nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, > > since it works on basically all major linux distros, even though it's > > built on CentOS. We did the same with 0.11.0. > > > > Thanks! > > > > On Mon, 23 May 2022 at 13:28, Ferenc Gerlits > wrote: > > > > > > +1 (non-binding) > > > > > > I have > > > * verified the checksums and signatures > > > * compared the contents of the source tarball to the > > minifi-cpp-0.12.0-RC1 > > > tag in git > > > * ran the binary with a simple GenerateFlowFile -> LogAttribute flow, > > with > > > heartbeat logging on > > > * connected to C2 > > > > > > Everything worked correctly. > > > > > > Thanks, > > > Ferenc > > >
Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
Good idea, I've renamed the convenience binary On Tue, May 24, 2022 at 2:54 PM Marton Szasz wrote: > +1 (binding) > > Ran through the release helper guide. Tested the convenience binaries > with a RPG to the NiFi release candidate, then InvokeHTTP to another > MiNiFi C++ RC agent that I've built myself. > > I would rename the convenience binary package from > nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to > nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, > since it works on basically all major linux distros, even though it's > built on CentOS. We did the same with 0.11.0. > > Thanks! > > On Mon, 23 May 2022 at 13:28, Ferenc Gerlits wrote: > > > > +1 (non-binding) > > > > I have > > * verified the checksums and signatures > > * compared the contents of the source tarball to the > minifi-cpp-0.12.0-RC1 > > tag in git > > * ran the binary with a simple GenerateFlowFile -> LogAttribute flow, > with > > heartbeat logging on > > * connected to C2 > > > > Everything worked correctly. > > > > Thanks, > > Ferenc >
Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
+1 (binding) Ran through the release helper guide. Tested the convenience binaries with a RPG to the NiFi release candidate, then InvokeHTTP to another MiNiFi C++ RC agent that I've built myself. I would rename the convenience binary package from nifi-minifi-cpp-0.12.0-bin-centos.tar.gz to nifi-minifi-cpp-0.12.0-bin-linux.tar.gz before finishing the release, since it works on basically all major linux distros, even though it's built on CentOS. We did the same with 0.11.0. Thanks! On Mon, 23 May 2022 at 13:28, Ferenc Gerlits wrote: > > +1 (non-binding) > > I have > * verified the checksums and signatures > * compared the contents of the source tarball to the minifi-cpp-0.12.0-RC1 > tag in git > * ran the binary with a simple GenerateFlowFile -> LogAttribute flow, with > heartbeat logging on > * connected to C2 > > Everything worked correctly. > > Thanks, > Ferenc
Re: [VOTE] Release Apache NiFi MiNiFi C++ 0.12.0 (RC1)
+1 (non-binding) I have * verified the checksums and signatures * compared the contents of the source tarball to the minifi-cpp-0.12.0-RC1 tag in git * ran the binary with a simple GenerateFlowFile -> LogAttribute flow, with heartbeat logging on * connected to C2 Everything worked correctly. Thanks, Ferenc
