[jira] Updated: (OFBIZ-1136) Email notification on CSR operations

2007-07-13 Thread Sumit Pandit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sumit Pandit updated OFBIZ-1136:


Attachment: updateMail_notification.patch

This is the updated patch of mail notification. Fixed some bugs in the privious 
one.

 Email notification on CSR operations
 

 Key: OFBIZ-1136
 URL: https://issues.apache.org/jira/browse/OFBIZ-1136
 Project: OFBiz
  Issue Type: New Feature
  Components: party
Affects Versions: SVN trunk
 Environment: CentOS
Reporter: Ashish Vijaywargiya
Priority: Trivial
 Attachments: mail_notification.patch, updateMail_notification.patch, 
 updateMail_notification.patch


 Hi,
 Email notification on following CSR(Customer Service Representative) 
 operations :
 1) New Customer Creation.
 2) Update Personnel Info of Customer.
 3) Update Customer Password 
 I will attach the patch for it ASAP.
 Regards
 Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1109) Ability to add items with modifiers

2007-07-13 Thread Bilgin Ibryam (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512466
 ] 

Bilgin Ibryam commented on OFBIZ-1109:
--

Hi Chris,

I'd like to know how is your progress on this issue?
Are you planning to put a patch, because I also like to see this functionality 
in POS.
I donot know whats the best way to accomplish it but i can help you in 
reviewing and testing it.

- Bilgin Ibryam

 Ability to add items with modifiers
 ---

 Key: OFBIZ-1109
 URL: https://issues.apache.org/jira/browse/OFBIZ-1109
 Project: OFBiz
  Issue Type: New Feature
  Components: pos
Affects Versions: SVN trunk
Reporter: Chris Lombardi

 I would like to add the ability to add and configure aggregated items via 
 the POS system.  
 A few scenarios should be supported.
 1.  The item has a default configuration and can be added without 
 configuration.
 2.  The item requires configuration and a screen to configure the item should 
 present upon adding the item.
 3.  A configurable item should allow editing after both earlier scenarios.
 I have a prototype mostly working, but I'd like to determine the following:
 1.  Is anyone else interested in this functionality?
 2.  What does everyone think is the best way to accomplish this?
 Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-642) Make OFBiz more dial-up friendly

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-642.
-

   Resolution: Fixed
Fix Version/s: SVN trunk

Adrian, Jeremy,

I applied and tested the ofbiz-642-locale_tz.patch. More than only reducing 
http traffic, IMHO it gives really a better user experience (larger place to 
see things)

In trunk rev. 555997

 Make OFBiz more dial-up friendly
 

 Key: OFBIZ-642
 URL: https://issues.apache.org/jira/browse/OFBIZ-642
 Project: OFBiz
  Issue Type: Improvement
Reporter: Adrian Crum
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk

 Attachments: htmlwidget.patch, htmlwidget.patch, htmlwidget.patch, 
 ofbiz-642-locale_tz.patch, ofbiz-642-locale_tz.patch, 
 ofbiz-642-locale_tz.patch, ofbiz-642-locale_tz.patch, 
 ofbiz-642-locale_tz.patch, ofbiz-642-locale_tz.patch


 Reduce OFBiz's HTML output so that pages load faster on dial-up lines.
 Three things can be done to achieve that goal:
 1. Reduce HTML code through better use of styles (currently in progress).
 2. Eliminate the language selection code that is sent out with every page 
 request. Intead of having a selection box in the header, just display the 
 currently selected language and provide a link to change it. Clicking on the 
 link could produce a language selection popup window - similar to the current 
 lookup windows.
 3. Freemarker has the #compress/#compress directives which eliminate 
 unnecessary HTML white space. A recent test showed the directives can yield a 
 33% reduction in markup. Problem is, that only works if the directive is 
 placed in every FTL file. There needs to be a way to make that a global 
 setting in Freemarker, so that ALL markup is reduced - without any additional 
 FTL coding. I looked around the Freemarker website for a way to do that, but 
 couldn't find anything.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-642) Make OFBiz more dial-up friendly

2007-07-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512480
 ] 

Jacques Le Roux commented on OFBIZ-642:
---

Adrian, Jeremy,

The compress patch (htmlwidget.patch) is in trunk rev.  555988
I got a couple of ConcurrentModificationException (whitout consequences) when 
loading back and front ends concurrently at start but anymore thereafter. I 
re-tried and did not reproduce.

Reviewing ant testing the ofbiz-642-locale_tz.patch...

 Make OFBiz more dial-up friendly
 

 Key: OFBIZ-642
 URL: https://issues.apache.org/jira/browse/OFBIZ-642
 Project: OFBiz
  Issue Type: Improvement
Reporter: Adrian Crum
Assignee: Jacques Le Roux
Priority: Trivial
 Attachments: htmlwidget.patch, htmlwidget.patch, htmlwidget.patch, 
 ofbiz-642-locale_tz.patch, ofbiz-642-locale_tz.patch, 
 ofbiz-642-locale_tz.patch, ofbiz-642-locale_tz.patch, 
 ofbiz-642-locale_tz.patch, ofbiz-642-locale_tz.patch


 Reduce OFBiz's HTML output so that pages load faster on dial-up lines.
 Three things can be done to achieve that goal:
 1. Reduce HTML code through better use of styles (currently in progress).
 2. Eliminate the language selection code that is sent out with every page 
 request. Intead of having a selection box in the header, just display the 
 currently selected language and provide a link to change it. Clicking on the 
 link could produce a language selection popup window - similar to the current 
 lookup windows.
 3. Freemarker has the #compress/#compress directives which eliminate 
 unnecessary HTML white space. A recent test showed the directives can yield a 
 33% reduction in markup. Problem is, that only works if the directive is 
 placed in every FTL file. There needs to be a way to make that a global 
 setting in Freemarker, so that ALL markup is reduced - without any additional 
 FTL coding. I looked around the Freemarker website for a way to do that, but 
 couldn't find anything.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-1146) Bug found in createAccountAndCredit service of FinAccountServices.java

2007-07-13 Thread Abhijit Meshram (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abhijit Meshram updated OFBIZ-1146:
---

Attachment: FinAccountServices_bug.patch


Hello,
   This is the patch for removing the bug.
  Thanks and Regards.
Abhijit Meshram.

 Bug found in createAccountAndCredit service of FinAccountServices.java
 --

 Key: OFBIZ-1146
 URL: https://issues.apache.org/jira/browse/OFBIZ-1146
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Reporter: Abhijit Meshram
 Attachments: FinAccountServices_bug.patch


 There was a bug in the createAccountAndCredit service of 
 FinAccountServices.java in accounting component. This was giving problem for 
 creating new FinAccountTrans.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1126) Quirky Behavior In New Time Zone Selection Box

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1126.
--

   Resolution: Fixed
Fix Version/s: SVN trunk
 Assignee: Jacques Le Roux

Adrian,

Your patch is in trunk rev. 556002, thanks

 Quirky Behavior In New Time Zone Selection Box
 --

 Key: OFBIZ-1126
 URL: https://issues.apache.org/jira/browse/OFBIZ-1126
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: commonevents.patch


 Sometimes the time zone selection feature doesn't remember the user's 
 selection.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-1146) Bug found in createAccountAndCredit service of FinAccountServices.java

2007-07-13 Thread Abhijit Meshram (JIRA)
Bug found in createAccountAndCredit service of FinAccountServices.java
--

 Key: OFBIZ-1146
 URL: https://issues.apache.org/jira/browse/OFBIZ-1146
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Reporter: Abhijit Meshram


There was a bug in the createAccountAndCredit service of 
FinAccountServices.java in accounting component. This was giving problem for 
creating new FinAccountTrans.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-1144) Payment applications problems

2007-07-13 Thread Rashko Rejmer (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rashko Rejmer updated OFBIZ-1144:
-

Attachment: payment_applications.patch

Sorry, I forgot to attach resolution for #2. The new patch resolves all the 
problems.

 Payment applications problems
 -

 Key: OFBIZ-1144
 URL: https://issues.apache.org/jira/browse/OFBIZ-1144
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Reporter: Rashko Rejmer
Assignee: Jacopo Cappellato
Priority: Minor
 Attachments: payment_applications.patch, payment_applications.patch


 Due to http://www.nabble.com/Question-about-Billing-Accounts-tf4056081.html
 Problems that occur:
  1. When we apply payment to another payment there is a worng checking if the 
 sender of the one payment is
   the same as the receiver of the other one.
  2. Wnen we try to assign a payment to an invoice that is assigned to the 
 billing account, the payment application is not automatically assigned to the 
 billing account.
  3. When the payment is assigned to billing account wrong available amount 
 method is invocated.
  4. When the amount of the payment to the billing account is changed  - the 
 new unassigned amount is calculated wrongly. 
  
 This patch should fix the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1137) Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId

2007-07-13 Thread Bilgin Ibryam (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512496
 ] 

Bilgin Ibryam commented on OFBIZ-1137:
--

Ok guys,
I will create a new issue for  the currency dropdown. So i will do all of them 
look like USD - American Dollar  and order by abbreviation.
Can someone commit and close this issue. This one was only for replacing hard 
coded USD.


 Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
 ---

 Key: OFBIZ-1137
 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Bilgin Ibryam
Priority: Trivial
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: UomId.patch


 I changed the currency.uom.id.default in general.properties but the default 
 currency was still USD in lots of dropdowns. The reason is that it is hard 
 coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now 
 it is better.
 BTW whats the best way to order by the currency dropdown? I see that it is 
 ordered by abbreviation, description, uomId...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Order held to avoid capture payment failure

2007-07-13 Thread Jacques Le Roux
Hi BJ,

This is more ambitious than what I was thinking about. But yes why not think 
about a generalisation ? Have you already some ideas ?

Jacques


De : BJ Freeman [EMAIL PROTECTED]
 There are a lot of services i have added that deal with fraud, orders
 over a certain amount
 they are hard coded.
 however I think this would be a good place to see if we could start a
 conversation about make the statuses more flexible so customer can add
 statuses and rules
 What do you think?

 Jacques Le Roux sent the following on 7/12/2007 4:55 AM:
  Hi,
 
  I recently wrote a service that runs nighlty to put on hold every 
  outstanding order (backordered or such) payed with a credit
card which expiry date is expired or more exactly will be tomorrow. This to 
avoid picking/packing an order which payment can't be
captured. Actually it's a part of a whole where held orders have also order 
items and OISG held and have also differrent reasons to
explain why (some automatic, etc.). This last remark because I did not look 
closely to OFBiz OOTB code about held orders but it
seems that it's not the case (an held order have no order items held, hence I 
guess no OISG). So I wonder if such things would have
an interest to OFBiz OOTB ?
 
  What do you think ?
 
  Thanks
 
  Jacques
 



[jira] Commented: (OFBIZ-571) Move the various documentation pages to the OFBTECH space on docs.ofbiz.org

2007-07-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512536
 ] 

Jacques Le Roux commented on OFBIZ-571:
---

Can I close this issue ?


 Move the various documentation pages to the OFBTECH space on docs.ofbiz.org
 ---

 Key: OFBIZ-571
 URL: https://issues.apache.org/jira/browse/OFBIZ-571
 Project: OFBiz
  Issue Type: Sub-task
  Components: site
Reporter: Jacopo Cappellato
Assignee: Jacques Le Roux
 Attachments: AScreenCopy.PNG, mini-ss.jpg, simple-methods.html, 
 simple-methods.xsd.patch, simple-methods.xsl, simple-methods.xsl, XSL 
 Output.html


 Move the various documentation pages and even the main Docs  Books page to 
 the OFBTECH space on docs.ofbiz.org

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-574) Simplify the home page and reorganize according to more common ASF project patterns

2007-07-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512537
 ] 

Jacques Le Roux commented on OFBIZ-574:
---

Shall we not consider this issue as closed ? Then we might close its parents 
issue, WDYT ?

 Simplify the home page and reorganize according to more common ASF project 
 patterns
 ---

 Key: OFBIZ-574
 URL: https://issues.apache.org/jira/browse/OFBIZ-574
 Project: OFBiz
  Issue Type: Sub-task
  Components: site
Reporter: Jacopo Cappellato

 simplify the home page and reorganize according to more common ASF project 
 patterns; some of the stuff on the home page we may even want to move to 
 docs.ofbiz.org, but much of it will move to other (new) pages following ASF 
 project patterns 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: Order held to avoid capture payment failure

2007-07-13 Thread BJ Freeman
let me get my thoughts in order and present a draft.
:)
Jacques Le Roux sent the following on 7/13/2007 8:30 AM:
 Hi BJ,
 
 This is more ambitious than what I was thinking about. But yes why not think 
 about a generalisation ? Have you already some ideas ?
 
 Jacques
 
 
 De : BJ Freeman [EMAIL PROTECTED]
 There are a lot of services i have added that deal with fraud, orders
 over a certain amount
 they are hard coded.
 however I think this would be a good place to see if we could start a
 conversation about make the statuses more flexible so customer can add
 statuses and rules
 What do you think?

 Jacques Le Roux sent the following on 7/12/2007 4:55 AM:
 Hi,

 I recently wrote a service that runs nighlty to put on hold every 
 outstanding order (backordered or such) payed with a credit
 card which expiry date is expired or more exactly will be tomorrow. This to 
 avoid picking/packing an order which payment can't be
 captured. Actually it's a part of a whole where held orders have also order 
 items and OISG held and have also differrent reasons to
 explain why (some automatic, etc.). This last remark because I did not look 
 closely to OFBiz OOTB code about held orders but it
 seems that it's not the case (an held order have no order items held, hence I 
 guess no OISG). So I wonder if such things would have
 an interest to OFBiz OOTB ?
 What do you think ?

 Thanks

 Jacques

 
 
 
 


[jira] Closed: (OFBIZ-1136) Email notification on CSR operations

2007-07-13 Thread Anil K Patel (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel closed OFBIZ-1136.
---

Resolution: Fixed

Sumit, Ashish Thanks. Patch applied with minor changes. Its in revision 556116.

 Email notification on CSR operations
 

 Key: OFBIZ-1136
 URL: https://issues.apache.org/jira/browse/OFBIZ-1136
 Project: OFBiz
  Issue Type: New Feature
  Components: party
Affects Versions: SVN trunk
 Environment: CentOS
Reporter: Ashish Vijaywargiya
Assignee: Anil K Patel
Priority: Trivial
 Attachments: mail_notification.patch, updateMail_notification.patch, 
 updateMail_notification.patch, updateMail_notification.patch


 Hi,
 Email notification on following CSR(Customer Service Representative) 
 operations :
 1) New Customer Creation.
 2) Update Personnel Info of Customer.
 3) Update Customer Password 
 I will attach the patch for it ASAP.
 Regards
 Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OFBIZ-1136) Email notification on CSR operations

2007-07-13 Thread Anil K Patel (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anil K Patel reassigned OFBIZ-1136:
---

Assignee: Anil K Patel

 Email notification on CSR operations
 

 Key: OFBIZ-1136
 URL: https://issues.apache.org/jira/browse/OFBIZ-1136
 Project: OFBiz
  Issue Type: New Feature
  Components: party
Affects Versions: SVN trunk
 Environment: CentOS
Reporter: Ashish Vijaywargiya
Assignee: Anil K Patel
Priority: Trivial
 Attachments: mail_notification.patch, updateMail_notification.patch, 
 updateMail_notification.patch, updateMail_notification.patch


 Hi,
 Email notification on following CSR(Customer Service Representative) 
 operations :
 1) New Customer Creation.
 2) Update Personnel Info of Customer.
 3) Update Customer Password 
 I will attach the patch for it ASAP.
 Regards
 Ashish Vijaywargiya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (OFBIZ-1147) Small Fixups for OFBIZ-642

2007-07-13 Thread Adrian Crum (JIRA)
Small Fixups for OFBIZ-642
--

 Key: OFBIZ-1147
 URL: https://issues.apache.org/jira/browse/OFBIZ-1147
 Project: OFBiz
  Issue Type: Improvement
Reporter: Adrian Crum
Priority: Minor
 Attachments: OFBIZ_642_Fixups.patch

Two things needed fixing after the patches in OFBIZ-642 were committed:

1. CommonEvents.setSessionLocale(...) doesn't need to call 
CommonEvents.setSessionTimeZone(...) now that we have separate Change buttons 
for each setting.

2. The HTML compression feature garbled HTML output when an ftl file contained 
a ${screens.render()} statement - probably due to recursion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (OFBIZ-1147) Small Fixups for OFBIZ-642

2007-07-13 Thread Adrian Crum (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-1147:
---

Attachment: OFBIZ_642_Fixups.patch

Attached patch fixes the issues.

 Small Fixups for OFBIZ-642
 --

 Key: OFBIZ-1147
 URL: https://issues.apache.org/jira/browse/OFBIZ-1147
 Project: OFBiz
  Issue Type: Improvement
Reporter: Adrian Crum
Priority: Minor
 Attachments: OFBIZ_642_Fixups.patch


 Two things needed fixing after the patches in OFBIZ-642 were committed:
 1. CommonEvents.setSessionLocale(...) doesn't need to call 
 CommonEvents.setSessionTimeZone(...) now that we have separate Change buttons 
 for each setting.
 2. The HTML compression feature garbled HTML output when an ftl file 
 contained a ${screens.render()} statement - probably due to recursion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1137) Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1137.
--

Resolution: Fixed
  Assignee: Jacques Le Roux

Thanks Bilgin,

Your patch is in trunk rev. 556105.

I tried to merge the patch in release4.0 but I got a conflict in PartyForms.xml 
and after some struggle I surrendered



 Replaced hard coded USD in currency dropdowns with defaultCurrencyUomId
 ---

 Key: OFBIZ-1137
 URL: https://issues.apache.org/jira/browse/OFBIZ-1137
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Bilgin Ibryam
Assignee: Jacques Le Roux
Priority: Trivial
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: UomId.patch


 I changed the currency.uom.id.default in general.properties but the default 
 currency was still USD in lots of dropdowns. The reason is that it is hard 
 coded in the dropdowns. So i replaced them with defaultCurrencyUomId and now 
 it is better.
 BTW whats the best way to order by the currency dropdown? I see that it is 
 ordered by abbreviation, description, uomId...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1147) Small Fixups for OFBIZ-642

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1147.
--

   Resolution: Fixed
Fix Version/s: SVN trunk
 Assignee: Jacques Le Roux

Adrian,

I did not find problem in ftl rendering during my tests. But I must admit that 
they were not very deep. So I applied your new patch in trunk rev. 556141after 
some random tests.

 Small Fixups for OFBIZ-642
 --

 Key: OFBIZ-1147
 URL: https://issues.apache.org/jira/browse/OFBIZ-1147
 Project: OFBiz
  Issue Type: Improvement
Reporter: Adrian Crum
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk

 Attachments: OFBIZ_642_Fixups.patch


 Two things needed fixing after the patches in OFBIZ-642 were committed:
 1. CommonEvents.setSessionLocale(...) doesn't need to call 
 CommonEvents.setSessionTimeZone(...) now that we have separate Change buttons 
 for each setting.
 2. The HTML compression feature garbled HTML output when an ftl file 
 contained a ${screens.render()} statement - probably due to recursion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1041) various values in allowSolicitation variable break some screens

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1041.
--

Resolution: Won't Fix
  Assignee: Jacques Le Roux  (was: Si Chen)

Si, I think this issue should be closed. Else please feel free to re-open

 various values in allowSolicitation variable  break some screens
 

 Key: OFBIZ-1041
 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Krzysztof Podejma
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: allowSolicitation.patch


 in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
 uiLabelMap.CommonN.
 it would be a good idea to force this value to Y or N because it is confusing 
 if you use more than one language
 additionaly different values break forms in other apps like crmsfa
 please see my patch
 Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens

2007-07-13 Thread Krzysztof Podejma (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512623
 ] 

Krzysztof Podejma commented on OFBIZ-1041:
--

so it will not be fixed?

 various values in allowSolicitation variable  break some screens
 

 Key: OFBIZ-1041
 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Krzysztof Podejma
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: allowSolicitation.patch


 in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
 uiLabelMap.CommonN.
 it would be a good idea to force this value to Y or N because it is confusing 
 if you use more than one language
 additionaly different values break forms in other apps like crmsfa
 please see my patch
 Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1044) Could not complete the Create Download as Content error

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1044.
--

Resolution: Won't Fix
  Assignee: Jacques Le Roux

I can't see any VT5225 product in OFBiz OOTB

 Could not complete the Create Download as Content error
 ---

 Key: OFBIZ-1044
 URL: https://issues.apache.org/jira/browse/OFBIZ-1044
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Release Branch 4.0
 Environment: Windows XP. Straightforward installation of Demo 
 application and data
Reporter: Malcolm Robinson
Assignee: Jacques Le Roux

 From Catalog Manager: Edit Product - 
 https://localhost:8443/catalog/control/EditProduct?productId=VT5225
 - selected [Content] tab - 
 https://localhost:8443/catalog/control/EditProductContent?productId=VT5225
 - selected Product Content Type Id of Digital Download and pressed 
 [Prepare Create] - 
 https://localhost:8443/catalog/control/prepareAddContentToProduct
 - entered Content ID, From Date, Description and File and pressed 
 [Create] - 
 https://localhost:8443/catalog/control/createDownloadContentForProduct
 - got error message:
 ERROR: Could not complete the Create Download as Content 
 [file:/D:/OfBiz/applications/content/script/org/ofbiz/content/content/ContentServices.xml#createDownloadContent]
  process [problem invoking the [createOtherDataResource] service with the map 
 named [createDownload] containing [[dataResourceContent=asd, 
 userLogin=[GenericEntity:UserLogin][createdStamp,2007-05-29 
 11:41:27.767(java.sql.Timestamp)][createdTxStamp,2007-05-29 
 11:41:26.027(java.sql.Timestamp)][currentPassword,47ca69ebb4bdc9ae0adec130880165d2cc05db1a(java.lang.String)][disabledDateTime,null()][enabled,Y(java.lang.String)][hasLoggedOut,N(java.lang.String)][isSystem,null()][lastCurrencyUom,null()][lastLocale,null()][lastUpdatedStamp,2007-05-30
  15:47:38.227(java.sql.Timestamp)][lastUpdatedTxStamp,2007-05-30 
 15:47:38.227(java.sql.Timestamp)][partyId,admin(java.lang.String)][passwordHint,null()][successiveFailedLogins,null()][userLoginId,admin(java.lang.String)],
  locale=en_AU, hasPermission=true, responseMessage=success]]: Unknown 
 parameter found: [createOtherDataResource.dataResourceTypeId]] calling 
 service createDownloadContent in createDownloadContentForProduct

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1041) various values in allowSolicitation variable break some screens

2007-07-13 Thread Adrian Crum (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512629
 ] 

Adrian Crum commented on OFBIZ-1041:


The problem still exists. From line 224 of  
applications/party/webapp/partymgr/party/editcontactmech.ftl:

  select name=allowSolicitation

option${(mechMap.partyContactMech.allowSolicitation)?if_exists}/option

option/optionoption${uiLabelMap.CommonY}/optionoption${uiLabelMap.CommonN}/option
  /select

If a user has selected a locale that doesn't use Y and N to represent Yes and 
No, then the data returned by this code will be invalid.

The code should be something like:

select name=allowSolicitation
  #if (mechMap.partyContactMech.allowSolicitation)?exists 
#if (mechMap.partyContactMech.allowSolicitation?default() == 
Y)option value=Y${uiLabelMap.CommonY}/option/#if
#if (mechMap.partyContactMech.allowSolicitation?default() == 
N)option value=N${uiLabelMap.CommonN}/option/#if
  /#if
  option/optionoption value=Y${uiLabelMap.CommonY}/optionoption 
value=N${uiLabelMap.CommonN}/option
/select

Maybe Krzysztof can prepare an updated patch.


 various values in allowSolicitation variable  break some screens
 

 Key: OFBIZ-1041
 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Krzysztof Podejma
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: allowSolicitation.patch


 in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
 uiLabelMap.CommonN.
 it would be a good idea to force this value to Y or N because it is confusing 
 if you use more than one language
 additionaly different values break forms in other apps like crmsfa
 please see my patch
 Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-987) Log configuration in multiple files

2007-07-13 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512630
 ] 

Jacques Le Roux commented on OFBIZ-987:
---

Michael,

Why in debug.properties do you remove other lines than 
log4j.appender.file.File=framework/logs/ofbiz.log in this patch ?

Quickly some remarks, please, don' t  :
. use tabs in your patches
. put comments like : // 15.05.07 Start change by Immi or  //  End Change by 
nowhow DABR

And last but no least, please read carefully : 
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices


 Log configuration in multiple files
 ---

 Key: OFBIZ-987
 URL: https://issues.apache.org/jira/browse/OFBIZ-987
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
 Environment: SUSE Linux 10.1  MySql 5
Reporter: Michael Imhof
Priority: Minor
 Attachments: log4jPatch.txt


 To change a log file location I had to change the following files:
 debug.properties
 start.properties (or install.properties, test.properties,...)
 ofbiz-containers.xml
 And I had to be sure, that the debug.properties location is the same
 as the start.properites location!!
 Patch feature
 ==
 The patch is decreasing the configuration to one file. The start.properties 
 (or install.properties, test.properties, Depends on wich
 functionality you're starting).
 In this file you can define: 
   ofbiz.log.dir=logs
   ofbiz.log.file=ofbiz.log
 Even catalina (access.log) is using the same location if not defined 
 otherwise in the ofbiz-containers.xml.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Assigned: (OFBIZ-987) Log configuration in multiple files

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-987:
-

Assignee: Jacques Le Roux

 Log configuration in multiple files
 ---

 Key: OFBIZ-987
 URL: https://issues.apache.org/jira/browse/OFBIZ-987
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
 Environment: SUSE Linux 10.1  MySql 5
Reporter: Michael Imhof
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: log4jPatch.txt


 To change a log file location I had to change the following files:
 debug.properties
 start.properties (or install.properties, test.properties,...)
 ofbiz-containers.xml
 And I had to be sure, that the debug.properties location is the same
 as the start.properites location!!
 Patch feature
 ==
 The patch is decreasing the configuration to one file. The start.properties 
 (or install.properties, test.properties, Depends on wich
 functionality you're starting).
 In this file you can define: 
   ofbiz.log.dir=logs
   ofbiz.log.file=ofbiz.log
 Even catalina (access.log) is using the same location if not defined 
 otherwise in the ofbiz-containers.xml.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-954) Bug with demo data and MySql

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-954.
-

Resolution: Won't Fix

 Bug with demo data and MySql
 

 Key: OFBIZ-954
 URL: https://issues.apache.org/jira/browse/OFBIZ-954
 Project: OFBiz
  Issue Type: Bug
Affects Versions: SVN trunk
 Environment: Windows 2003, JDK1.6, MySql 5.037
Reporter: Dirk Kissing
Assignee: Jacques Le Roux
Priority: Minor
 Attachments: OFBIZ-954.patch


 The following error happens when i run install (with MySql). 
 It runs very smoothful, until the last lines. With Derby it doesn't happen.
  
  
 O ] The following errors occured in the data load: 
 [java] 2007-05-01 10:01:48,031 (main) [EntityDataLoadContainer.java:289:INF 
 O ] [install.loadData]: Error loading XML Resource 
 file:/D:/OFBiz/applications/ 
 accounting/data/PaymentsInvoices.xml; Error was: A transaction error 
 occurred r 
 eading data 
 [java] 2007-05-01 10:01:48,031 (main) [EntityDataLoadContainer.java:289:INF 
 O ] [install.loadData]: Error loading XML Resource 
 file:/D:/OFBiz/applications/ 
 ecommerce/data/DemoProductCategoriesI18nData.xml; Error was: A transaction 
 erro 
 r occurred reading data 
 [java] 2007-05-01 10:01:48,031 (main) [EntityDataLoadContainer.java:293:INF 
 O ] =-=-=-=-=-=-= Finished the data load with 10139 rows changed. 
 [java] 2007-05-01 10:01:48,031 (main) [ ContainerLoader.java:93 :INFO ] 
 Shutting down containers 
  
 BUILD SUCCESSFUL 
 Total time: 11 minutes 2 seconds 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Reopened: (OFBIZ-1041) various values in allowSolicitation variable break some screens

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reopened OFBIZ-1041:



Yes right sorry, open for a patch (we are close to it I guess ;o)

 various values in allowSolicitation variable  break some screens
 

 Key: OFBIZ-1041
 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Krzysztof Podejma
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: allowSolicitation.patch


 in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
 uiLabelMap.CommonN.
 it would be a good idea to force this value to Y or N because it is confusing 
 if you use more than one language
 additionaly different values break forms in other apps like crmsfa
 please see my patch
 Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (OFBIZ-1041) various values in allowSolicitation variable break some screens

2007-07-13 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-1041.
--

Resolution: Fixed

I finally commited a bunch of changes in trunk rev. 556172 and 556181 and in 
release4.0 rev. 556185  


 various values in allowSolicitation variable  break some screens
 

 Key: OFBIZ-1041
 URL: https://issues.apache.org/jira/browse/OFBIZ-1041
 Project: OFBiz
  Issue Type: Bug
  Components: party
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Krzysztof Podejma
Assignee: Jacques Le Roux
Priority: Minor
 Fix For: SVN trunk, Release Branch 4.0

 Attachments: allowSolicitation.patch


 in contact forms field allowSolicitation is set to uiLabelMap.CommonY or 
 uiLabelMap.CommonN.
 it would be a good idea to force this value to Y or N because it is confusing 
 if you use more than one language
 additionaly different values break forms in other apps like crmsfa
 please see my patch
 Krzysztof Podejma

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (OFBIZ-1144) Payment applications problems

2007-07-13 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512677
 ] 

Jacopo Cappellato commented on OFBIZ-1144:
--

Rashko,

thanks for your patch... I'd love to commit it as soon as possible.
The delay is caused by the fact that I cannot completely review it because I 
simply *don't* understand what the service updatePaymentApplicationDefBd is 
supposed to do.
Of course this is not your fault, it's probably mine... however I'm going to 
ask to the dev list is the authors of that service could help to shed some 
lights on it.
Rashko, just out of curiosity: is the service updatePaymentApplicationDefBd 
completely clear to you? If so, maybe it's just me getting dumb...

Jacopo




 Payment applications problems
 -

 Key: OFBIZ-1144
 URL: https://issues.apache.org/jira/browse/OFBIZ-1144
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Reporter: Rashko Rejmer
Assignee: Jacopo Cappellato
Priority: Minor
 Attachments: payment_applications.patch, payment_applications.patch


 Due to http://www.nabble.com/Question-about-Billing-Accounts-tf4056081.html
 Problems that occur:
  1. When we apply payment to another payment there is a worng checking if the 
 sender of the one payment is
   the same as the receiver of the other one.
  2. Wnen we try to assign a payment to an invoice that is assigned to the 
 billing account, the payment application is not automatically assigned to the 
 billing account.
  3. When the payment is assigned to billing account wrong available amount 
 method is invocated.
  4. When the amount of the payment to the billing account is changed  - the 
 new unassigned amount is calculated wrongly. 
  
 This patch should fix the problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



I need help to review updatePaymentApplicationDefBd service...

2007-07-13 Thread Jacopo Cappellato
To the authors, or other developers comfortable with the logic 
implemented in the service:


InvoiceServices.updatePaymentApplicationDefBd(...)

could you please help to review the patch committed in

https://issues.apache.org/jira/browse/OFBIZ-1144

?

Or help me to understand the logic implemented in the service?

I really cannot understand much of the stuff in it and so it is 
difficult for me to review the important fix in OFBIZ-1144.


Thanks,

Jacopo