[jira] Closed: (OFBIZ-1728) XML export of a no-auto-stamp entity does not work
[ https://issues.apache.org/jira/browse/OFBIZ-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1728. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Bruno and Ray, Ray your patch is in trunk. rev. 647413 XML export of a no-auto-stamp entity does not work -- Key: OFBIZ-1728 URL: https://issues.apache.org/jira/browse/OFBIZ-1728 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: Win XP - OFBIZ SVN trunk 642807 Reporter: Bruno Busco Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: entity_export.patch When trying to XML export an entity that has been configured with the no-auto-stamp=true property the following error is generated: org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://webtools/widget/CommonScreens.xml#main-decorator]: org.ofbiz.entity.transaction.GenericTransactionException: The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Error reading data for XML export:org.ofbiz.entity.GenericModelException: Field with name createdTxStamp not found in the Articolo Entity (Field with name createdTxStamp not found in the Articolo Entity) (The current transaction is marked for rollback, not beginning a new transaction and aborting current operation; the rollbackOnly was caused by: Error reading data for XML export:org.ofbiz.entity.GenericModelException: Field with name createdTxStamp not found in the Articolo Entity (Field with name createdTxStamp not found in the Articolo Entity)) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1743) Remove hardcoded value
[ https://issues.apache.org/jira/browse/OFBIZ-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1743. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Yin T, Your suggestion is committed in trunk revision 647417. Remove hardcoded value -- Key: OFBIZ-1743 URL: https://issues.apache.org/jira/browse/OFBIZ-1743 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: n/a Reporter: Yin T Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk In file RequestManager.java. line#72,line#89 -replace '1' with RequestManager.VIEW_HANDLER_KEY -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1746) Firefox view gantt chart bug
Firefox view gantt chart bug Key: OFBIZ-1746 URL: https://issues.apache.org/jira/browse/OFBIZ-1746 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk Environment: Firefox 2.0.0.13 Reporter: Krzysztof Podejma Priority: Minor Fix For: SVN trunk Chart is not created well under Firefox. Dates in gantChart.ftl have invalid format, proper format is /MM/dd HH:mm . See my patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1746) Firefox view gantt chart bug
[ https://issues.apache.org/jira/browse/OFBIZ-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Podejma updated OFBIZ-1746: - Attachment: projMgrGanttFix.patch Fixes this issue. Firefox view gantt chart bug Key: OFBIZ-1746 URL: https://issues.apache.org/jira/browse/OFBIZ-1746 Project: OFBiz Issue Type: Bug Components: specialpurpose/projectmgr Affects Versions: SVN trunk Environment: Firefox 2.0.0.13 Reporter: Krzysztof Podejma Priority: Minor Fix For: SVN trunk Attachments: projMgrGanttFix.patch Original Estimate: 0.17h Remaining Estimate: 0.17h Chart is not created well under Firefox. Dates in gantChart.ftl have invalid format, proper format is /MM/dd HH:mm . See my patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1716) POS: CVV2 code is not always deleted from the DB
[ https://issues.apache.org/jira/browse/OFBIZ-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588231#action_12588231 ] Jacques Le Roux commented on OFBIZ-1716: Hi Chris, All, I just had a look at it and yes indeed there seems to be a problem there... POS: CVV2 code is not always deleted from the DB Key: OFBIZ-1716 URL: https://issues.apache.org/jira/browse/OFBIZ-1716 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Critical I ran a transaction that was declined by the processor. I later noticed that the cvv2 code was still present in the database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1714) New attributes to ofbiz-component.xml
[ https://issues.apache.org/jira/browse/OFBIZ-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588236#action_12588236 ] Jacques Le Roux commented on OFBIZ-1714: I began a work around this, to be continued... New attributes to ofbiz-component.xml - Key: OFBIZ-1714 URL: https://issues.apache.org/jira/browse/OFBIZ-1714 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Jacopo Cappellato Priority: Minor Fix For: SVN trunk Attachments: menu.patch Hi, The discussion about this issue is here: http://www.nabble.com/new-attributes-for-ofbiz-component.xml---to15993451.html This is already working but needs some style improvements for the footer menu. Please test and review. Comments are welcome. Thanks, Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1716) POS: CVV2 code is not always deleted from the DB
[ https://issues.apache.org/jira/browse/OFBIZ-1716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588237#action_12588237 ] Jacques Le Roux commented on OFBIZ-1716: I did not change it yet in the case of PAYMENT_DECLINED, since I think that, in such case, the transaction may be retried one or more times. If it's well done I suppose that at the end of transactions (with success or not) securityCode and track2 are nullified in the DB. So for now I only nullified int the case of PAYMENT_ERROR and I hope it's the exit door (did not look further) POS: CVV2 code is not always deleted from the DB Key: OFBIZ-1716 URL: https://issues.apache.org/jira/browse/OFBIZ-1716 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Critical I ran a transaction that was declined by the processor. I later noticed that the cvv2 code was still present in the database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
[ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588239#action_12588239 ] Jacques Le Roux commented on OFBIZ-1698: Bruno, Did not find the time yet this weekend, but I do not forget... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
Thank you, Jacques. When you will be on the issue, if you want, I will run the script again on the latest trunk to simplify the commit. Just let me know. -Bruno 2008/4/12, Jacques Le Roux (JIRA) [EMAIL PROTECTED]: [ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588239#action_12588239] Jacques Le Roux commented on OFBIZ-1698: Bruno, Did not find the time yet this weekend, but I do not forget... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1698) Locale labels in language different from the fallback sometime are not displayed
Ok, thanks ! Jacques From: Bruno Busco [EMAIL PROTECTED] Thank you, Jacques. When you will be on the issue, if you want, I will run the script again on the latest trunk to simplify the commit. Just let me know. -Bruno 2008/4/12, Jacques Le Roux (JIRA) [EMAIL PROTECTED]: [ https://issues.apache.org/jira/browse/OFBIZ-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588239#action_12588239] Jacques Le Roux commented on OFBIZ-1698: Bruno, Did not find the time yet this weekend, but I do not forget... Locale labels in language different from the fallback sometime are not displayed Key: OFBIZ-1698 URL: https://issues.apache.org/jira/browse/OFBIZ-1698 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Attachments: cleanlabels.patch.zip A label is not displayed in the selected language but in the fallback one when ALL the following are true: - A language different from the one specified as locale.properties.fallback in framework/common/config/general.properties is selected - The label is defined in more than one XXXUiLabels.XML file (say File1UiLabels.xml and File2UiLabels.xml) - The screen includes first File1UiLabels.xml and then File2UiLabels.xml - In File1UiLabels.xml there is NO translation for the selected language - In File2UiLabels.xml there is the translation for the selected language This bug was not present in Release 4.0 and i think could have been introduced with the new locale system. You can check the bug going in the trunk demo in the ecommerce main page and selecting italian. - Labels Cart Summary and Special Offers are not translated. In the R4.0 demo it is all OK -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Linking OFBIZ to the on-line help system
After the discussion we had in http://www.nabble.com/Loading-Raw-HTML-td16595109.html I am trying to modify ofbiz to optionally include a little help icon in the screenlet title bar. What I want to obtais is the possibility to specify for every container an help page link. I am not expert of Ofbiz and of Java too but I want use this as an exercize to grow my experience up. My roadmap is: 1 - add a little help icon image (help_yellow.gif) to ofbiz 2 - add a helpHomeUrl property in general.properies 3 - add a new helplink property to the container tag to let the programmer to link an help page to every single UI element. When the container is rendered the following HTML should be added in the container. a class=helpLink target=_ofbizhelp href=HELPURL img width=16 height=16 align=absmiddle title=Get online help about Using Ofbiz src=/images/help_yellow.gif/ /a Where HELPURL is a string obtained from the helpHomeUrl, the helplink property and perhaps the actual locale 4- add something in the main.css to make the little help icon displayed inline on the right of the container area So, after the trivial step 1, skipped step 2 for the moment, I started navigating the code to do step 3. I have seen that the screenlet container is someting that is built in two (at least) different ways in .ftl files and in screens.xml files. I have done it for a single .ftl file inserting the HTML code by hand but now I want to make it for the screens.xml files. I have tried to modify the HtmlScreenRenderer.java but I get no effect at all changing this file ant-building and the startofbizing. Could someone help me? -Bruno
Re: Linking OFBIZ to the on-line help system
Ooops, I have resolved. I was modifying the renderScreenletBegin function instead of the renderContainerBegin function. Now I can continue on my road-map... -Bruno 2008/4/12, Bruno Busco [EMAIL PROTECTED]: After the discussion we had in http://www.nabble.com/Loading-Raw-HTML-td16595109.html I am trying to modify ofbiz to optionally include a little help icon in the screenlet title bar. What I want to obtais is the possibility to specify for every container an help page link. I am not expert of Ofbiz and of Java too but I want use this as an exercize to grow my experience up. My roadmap is: 1 - add a little help icon image (help_yellow.gif) to ofbiz 2 - add a helpHomeUrl property in general.properies 3 - add a new helplink property to the container tag to let the programmer to link an help page to every single UI element. When the container is rendered the following HTML should be added in the container. a class=helpLink target=_ofbizhelp href=HELPURL img width=16 height=16 align=absmiddle title=Get online help about Using Ofbiz src=/images/help_yellow.gif/ /a Where HELPURL is a string obtained from the helpHomeUrl, the helplink property and perhaps the actual locale 4- add something in the main.css to make the little help icon displayed inline on the right of the container area So, after the trivial step 1, skipped step 2 for the moment, I started navigating the code to do step 3. I have seen that the screenlet container is someting that is built in two (at least) different ways in .ftl files and in screens.xml files. I have done it for a single .ftl file inserting the HTML code by hand but now I want to make it for the screens.xml files. I have tried to modify the HtmlScreenRenderer.java but I get no effect at all changing this file ant-building and the startofbizing. Could someone help me? -Bruno
[jira] Created: (OFBIZ-1747) When a customPriceCalcService has been run into the calculateProductPrice it was not possible to give custom attributes that the custom service can use it
When a customPriceCalcService has been run into the calculateProductPrice it was not possible to give custom attributes that the custom service can use it -- Key: OFBIZ-1747 URL: https://issues.apache.org/jira/browse/OFBIZ-1747 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Until now it was not possible to give some custom attributes to a custom price calc service that it can use it to calculate the price using those custom attributes. So I add this not mandatory map parameter to the generic custom method for price. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1747) When a customPriceCalcService has been run into the calculateProductPrice it was not possible to give custom attributes that the custom service can use it
[ https://issues.apache.org/jira/browse/OFBIZ-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-1747: -- Attachment: customAttributes.patch New customAttributes parameter for the custom method for price calculation. When a customPriceCalcService has been run into the calculateProductPrice it was not possible to give custom attributes that the custom service can use it -- Key: OFBIZ-1747 URL: https://issues.apache.org/jira/browse/OFBIZ-1747 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: customAttributes.patch Until now it was not possible to give some custom attributes to a custom price calc service that it can use it to calculate the price using those custom attributes. So I add this not mandatory map parameter to the generic custom method for price. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1747) When a customPriceCalcService has been run into the calculateProductPrice it was not possible to give custom attributes that the custom service can use it
[ https://issues.apache.org/jira/browse/OFBIZ-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti closed OFBIZ-1747. - Resolution: Fixed My patch is in trunk rev. 647461. When a customPriceCalcService has been run into the calculateProductPrice it was not possible to give custom attributes that the custom service can use it -- Key: OFBIZ-1747 URL: https://issues.apache.org/jira/browse/OFBIZ-1747 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: customAttributes.patch Until now it was not possible to give some custom attributes to a custom price calc service that it can use it to calculate the price using those custom attributes. So I add this not mandatory map parameter to the generic custom method for price. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1748) Menus styled with the menu-container-style button-bar tab-bar are not visible in IE 7.
Menus styled with the menu-container-style button-bar tab-bar are not visible in IE 7. - Key: OFBIZ-1748 URL: https://issues.apache.org/jira/browse/OFBIZ-1748 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Environment: IE 7 Reporter: Jacques Le Roux See any sub-menu in Party for instance like at the page https://localhost:8443/partymgr/control/viewprofile?partyId=admin I found it at the page https://localhost:8443/projectmgr/control/login?projectId=9000 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1663) POS: All payment types allow change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1663. -- Resolution: Fixed Fix Version/s: Release Branch 4.0 You were right Chris it was related to OFBIZ-1706. So I close this issue even if I discovered that order are not put in the right status (completed) but stay in created status because of this error : 2008-04-12 20:26:03,562 (Thread-26) [ ServiceDispatcher.java:419:ERROR] Service Error [changeOrderStatus]: %Erreur : Ne peut pas changer le statut de la commande ; le statut ne peut pas Ûtre changÚ.% 2008-04-12 20:26:03,578 (Thread-26) [TransactionUtil.java:255:ERROR] exception report -- [TransactionUtil.rollback] Exception: java.lang.Exception Message: Stack Trace stack trace --- java.lang.Exception: Stack Trace org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:254) org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:236) org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:423) org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:211) org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136) org.ofbiz.order.order.OrderChangeHelper.orderStatusChanges(OrderChangeHelper.java:158) org.ofbiz.order.order.OrderChangeHelper.completeOrder(OrderChangeHelper.java:121) org.ofbiz.order.shoppingcart.CheckOutHelper.processPayment(CheckOutHelper.java:1063) org.ofbiz.order.shoppingcart.CheckOutHelper.processPayment(CheckOutHelper.java:834) org.ofbiz.pos.PosTransaction.processSale(PosTransaction.java:624) org.ofbiz.pos.event.PaymentEvents.processSale(PaymentEvents.java:308) sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) java.lang.reflect.Method.invoke(Unknown Source) org.ofbiz.pos.config.ButtonEventConfig.invoke(ButtonEventConfig.java:208) org.ofbiz.pos.config.ButtonEventConfig.invokeButtonEvent(ButtonEventConfig.java:105) org.ofbiz.pos.component.PosButton$1.construct(PosButton.java:120) net.xoetrope.xui.helper.SwingWorker$2.run(Unknown Source) java.lang.Thread.run(Unknown Source) 2008-04-12 20:26:03,578 (Thread-26) [TransactionUtil.java:265:INFO ] [TransactionUtil.rollback] transaction rolled back 2008-04-12 20:26:03,578 (Thread-26) [ ServiceDispatcher.java:467:DEBUG] Sync service [POSDispatcher/changeOrderStatus] finished in [94] milliseconds 2008-04-12 20:26:03,578 (Thread-26) [ OrderChangeHelper.java:160:ERROR] Problems adjusting order header status for order #RS10010 But as it does not prevent to create the invoice and I have not time to investigate further I close this issue. Maybe it's only because face-to-face is not considered and it assumes that the check is not yet received... If someone is annoyed by this simply open a new issue... POS: All payment types allow change to be made Key: OFBIZ-1663 URL: https://issues.apache.org/jira/browse/OFBIZ-1663 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 4.0 Attachments: ofbiz-1663.patch I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction. I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales. Does anyone have any international scenarios that would not follow this rule? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1607) let the ofbiz work with db2
[ https://issues.apache.org/jira/browse/OFBIZ-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1607: -- Assignee: (was: Jacques Le Roux) let the ofbiz work with db2 --- Key: OFBIZ-1607 URL: https://issues.apache.org/jira/browse/OFBIZ-1607 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: db2 v9.1.0.356 Reporter: WeizhanGuo Fix For: SVN trunk Attachments: contentForm.diff, entityFordb2.diff Original Estimate: 0.67h Remaining Estimate: 0.67h create the db2filedtype file ; change the seed/demo data to fixed the db2 requirement; change some relation define if needed; others -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
comments please on flexible import export
http://docs.ofbiz.org/display/OFBIZ/user+friendly+XLS%2C+CSV+import+and+export+integration
[jira] Reopened: (OFBIZ-1663) POS: All payment types allow change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Lombardi reopened OFBIZ-1663: --- So even after ofbiz-1706 has been fixed, you are still seeing this error? That's interesting. I do plan on fixing this, I'm admittedly slow because I'm working on something else at the moment, but I will return. If you would like, assign it to me so it isn't cluttering up your list. POS: All payment types allow change to be made Key: OFBIZ-1663 URL: https://issues.apache.org/jira/browse/OFBIZ-1663 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 4.0 Attachments: ofbiz-1663.patch I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction. I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales. Does anyone have any international scenarios that would not follow this rule? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588329#action_12588329 ] Jacques Le Roux commented on OFBIZ-1663: Chris, If you take care of it I will keep it on my list; to be aware when it will be time to review and hopefully commit, Thanks POS: All payment types allow change to be made Key: OFBIZ-1663 URL: https://issues.apache.org/jira/browse/OFBIZ-1663 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 4.0 Attachments: ofbiz-1663.patch I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction. I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales. Does anyone have any international scenarios that would not follow this rule? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1714) New attributes to ofbiz-component.xml
[ https://issues.apache.org/jira/browse/OFBIZ-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588331#action_12588331 ] Bilgin Ibryam commented on OFBIZ-1714: -- Jacques, thanks for updating the .xsd file New attributes to ofbiz-component.xml - Key: OFBIZ-1714 URL: https://issues.apache.org/jira/browse/OFBIZ-1714 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Jacopo Cappellato Priority: Minor Fix For: SVN trunk Attachments: menu.patch Hi, The discussion about this issue is here: http://www.nabble.com/new-attributes-for-ofbiz-component.xml---to15993451.html This is already working but needs some style improvements for the footer menu. Please test and review. Comments are welcome. Thanks, Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1749) Adding a new address in the split shipment screen does not work
Adding a new address in the split shipment screen does not work --- Key: OFBIZ-1749 URL: https://issues.apache.org/jira/browse/OFBIZ-1749 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Jacques Le Roux Priority: Minor https://localhost:8443/ecommerce/control/updateShippingOptions/editcontactmech?DONE_PAGE=splitshippreContactMechTypeId=POSTAL_ADDRESScontactMechPurposeTypeId=SHIPPING_LOCATION You get: The Following Errors Occurred: Please Select a Shipping Destination. Please Select a Shipping Method. Maybe I did not understand how it works ? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1078) payment is applied to first invoice only
[ https://issues.apache.org/jira/browse/OFBIZ-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588338#action_12588338 ] Jacques Le Roux commented on OFBIZ-1078: It would be interesting to have a way to reproduce because maybe this issue is no longer valid... payment is applied to first invoice only Key: OFBIZ-1078 URL: https://issues.apache.org/jira/browse/OFBIZ-1078 Project: OFBiz Issue Type: Bug Components: accounting, order Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Krzysztof Podejma When you have more than one invoice in order and receive offline payment, this payment is applied to first invoice only. Possible scenarios: 1) Create service that creates one invoice for all productitemtypes - needs redesign create invoice services -simple 2) Change events happened after receive payment to check if there are more invoices that wait for payment - problem which invoice to choose if there is not enough cash. Krzysztof Podejma -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1221) capturePaymentsByInvoice service doesn't return not optional parameter while processing multiple orders invoice
[ https://issues.apache.org/jira/browse/OFBIZ-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588339#action_12588339 ] Jacques Le Roux commented on OFBIZ-1221: Hi Rashko, Please provide a newer patch this one can't be any longer merged easily. Thanks capturePaymentsByInvoice service doesn't return not optional parameter while processing multiple orders invoice --- Key: OFBIZ-1221 URL: https://issues.apache.org/jira/browse/OFBIZ-1221 Project: OFBiz Issue Type: Bug Components: accounting Reporter: Rashko Rejmer Priority: Trivial Attachments: PaymentGatewayServices.patch This patch should fix this. Regards, Rashko Rejmer -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1415) Thread freeze when executing PreparedStatement with PosgreSQL
[ https://issues.apache.org/jira/browse/OFBIZ-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1415. -- Resolution: Cannot Reproduce Assignee: Jacques Le Roux Thread freeze when executing PreparedStatement with PosgreSQL - Key: OFBIZ-1415 URL: https://issues.apache.org/jira/browse/OFBIZ-1415 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Leon Torres Assignee: Jacques Le Roux I'm getting a hard freeze in a thread when it attempts to executeQuery() using the postgresql Jdbc3 Prepared Statement. It affects the OrderServices.createPaymentPreference() method. After extensive probing of the issue, I can't figure out why. Here's a verbose log of what happens. The thread stops after the last line and never resumes, causing the browser to remain loading indefinitely. I suspect something is going on with BigDecimal or the nature of the insert. Any ideas? 2007-11-20 12:22:05,985 (http-0.0.0.0-8443-Processor3) [ ServiceDispatcher.java:347:INFO ] ### Invoking Sync Service [createOrderPaymentPreference] 2007-11-20 12:22:06,003 (http-0.0.0.0-8443-Processor3) [ SequenceUtil.java:258:INFO ] Got bank of sequenced IDs for [OrderPaymentPreference]; curSeqId=10220, maxSeqId=10230, bankSize=10 2007-11-20 12:22:06,006 (http-0.0.0.0-8443-Processor3) [ GenericEntity.java:389:WARN ] In entity field [OrderPaymentPreference.maxAmount] set the value passed in [java.math.BigDecimal] is not compatible with the Java type of the fi eld [Double] 2007-11-20 12:22:06,008 (http-0.0.0.0-8443-Processor3) [ GenericDAO.java:168:INFO ] ### saving fields [EMAIL PROTECTED], [EMAIL PROTECTED], ModelEntity[OrderP [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], ModelEntity[OrderPaymentPreferenc [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], ModelEntity[OrderPaymen [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], Mode [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], ModelEntity[OrderPaymentPrefer [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] from entity [GenericEntity:OrderPaymentPreference][createdByUserLogin,DemoSalesManager(java.lang.String)][cr eatedDate,2007-11-20 12:22:06.007(java.sql.Timestamp)][createdStamp,2007-11-20 12:22:06.007(java.sql.Timestamp)][createdTxStamp,2007-11-20 12:22:05.187(java.sql.Timestamp)][lastUpdatedStamp,2007-11-20 12:22:06.007(java.sql.Timestamp)][l astUpdatedTxStamp,2007-11-20 12:22:05.187(java.sql.Timestamp)][maxAmount,25.07(java.math.BigDecimal)][orderId,WS1(java.lang.String)][orderPaymentPreferenceId,10220(java.lang.String)][paymentMethodId,1(java.lang.String)][paymentM ethodTypeId,CREDIT_CARD(java.lang.String)] 2007-11-20 12:22:06,009 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [orderPaymentPreferenceId] of type [String] and fieldtype [1] to [10220] 2007-11-20 12:22:06,011 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [orderId] of type [String] and fieldtype [1] to [WS1] 2007-11-20 12:22:06,012 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [orderItemSeqId] of type [String] and fieldtype [1] to [null] 2007-11-20 12:22:06,013 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [productPricePurposeId] of type [String] and fieldtype [1] to [null] 2007-11-20 12:22:06,014 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [paymentMethodTypeId] of type [String] and fieldtype [1] to [CREDIT_CARD] 2007-11-20 12:22:06,015 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [paymentMethodId] of type [String] and fieldtype [1] to [1] 2007-11-20 12:22:06,016 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [finAccountId] of type [String] and fieldtype [1] to [null] 2007-11-20 12:22:06,017 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [securityCode] of type [String] and fieldtype [1] to [null] 2007-11-20 12:22:06,025 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [presentFlag] of type [String] and fieldtype [1] to [null] 2007-11-20 12:22:06,026 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ] ### setting field [overflowFlag] of type [String] and fieldtype [1] to [null] 2007-11-20 12:22:06,027 (http-0.0.0.0-8443-Processor3) [ SqlJdbcUtil.java:704:INFO ]
[jira] Commented: (OFBIZ-1189) Cannot approve digital product orders
[ https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588341#action_12588341 ] Jacques Le Roux commented on OFBIZ-1189: Should we not close this issue ? Cannot approve digital product orders - Key: OFBIZ-1189 URL: https://issues.apache.org/jira/browse/OFBIZ-1189 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: David E. Jones Fix For: SVN trunk Attachments: order.patch, order.patch Hi all, There is a bug when approving orders that contains only digital products. If you create an order that contains only digital products and then try to approve it you will get ERROR : Could not change order status ; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] The reason is that there is seca rule and checkDigitalItemFulfillment service will put all the items to ITEM_COMPLETED status. Then another seca calls checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status. All the items are completed and the order is also completed, everything looks fine, but the service called in the beginning to approve the order generates the error [ORDER_COMPLETED] - [ORDER_APPROVED] is not a valid change Any ideas what should be the flow in approving and completing an order in cases where all items are completed while approving ? Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-880) Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation.
[ https://issues.apache.org/jira/browse/OFBIZ-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-880. - Resolution: Fixed Fix Version/s: SVN trunk Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. --- Key: OFBIZ-880 URL: https://issues.apache.org/jira/browse/OFBIZ-880 Project: OFBiz Issue Type: Improvement Components: order Reporter: Jacopo Cappellato Priority: Minor Fix For: SVN trunk Replace calls to deprecated methods in OrderServices.java to avoid warnings during compilation. It would be great to have this fixed before the upcoming release (volunteers?). Here is the list of the warnings: 13 warnings applications/order/src/org/ofbiz/order/order/OrderServices.java:1120: warning: [deprecation] getOrderGrandTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double updatedTotal = orh.getOrderGrandTotal(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderReturnedTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1123: warning: [deprecation] getOrderNonReturnedTaxAndShipping() in org.ofbiz.order.order.OrderReadHelper has been deprecated double remainingSubTotal = updatedTotal - orh.getOrderReturnedTotal() - orh.getOrderNonReturnedTaxAndShipping(); applications/order/src/org/ofbiz/order/order/OrderServices.java:1278: warning: [deprecation] getOrderItemsSubTotal(java.util.List,java.util.List) in org.ofbiz.order.order.OrderReadHelper has been deprecated double orderSubTotal = OrderReadHelper.getOrderItemsSubTotal(validOrderItems, allAdjustments); applications/order/src/org/ofbiz/order/order/OrderServices.java:1281: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated BigDecimal orderShipping = new BigDecimal(OrderReadHelper.calcOrderAdjustments(orderHeaderAdjustments, orderSubTotal, false, false, true)); applications/order/src/org/ofbiz/order/order/OrderServices.java:1289: warning: [deprecation] getOrderItemSubTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated amounts.add(i, new BigDecimal(OrderReadHelper.getOrderItemSubTotal(orderItem, allAdjustments, true, false))); // get the item amount applications/order/src/org/ofbiz/order/order/OrderServices.java:1290: warning: [deprecation] getOrderItemAdjustmentsTotal(org.ofbiz.entity.GenericValue,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated shipAmts.add(i, new BigDecimal(OrderReadHelper.getOrderItemAdjustmentsTotal(orderItem, allAdjustments, false, false, true))); // get the shipping amount applications/order/src/org/ofbiz/order/order/OrderServices.java:1468: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated double currentShipping = OrderReadHelper.getAllOrderItemsAdjustmentsTotal(orh.getOrderItemAndShipGroupAssoc(shipGroupSeqId), orh.getAdjustments(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:1469: warning: [deprecation] calcOrderAdjustments(java.util.List,double,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated currentShipping += OrderReadHelper.calcOrderAdjustments(orh.getOrderHeaderAdjustments(shipGroupSeqId), orh.getOrderItemsSubTotal(), false, false, true); applications/order/src/org/ofbiz/order/order/OrderServices.java:2355: warning: [deprecation] getOrderItemsSubTotal() in org.ofbiz.order.order.OrderReadHelper has been deprecated double orderSubTotal = orh.getOrderItemsSubTotal(); applications/order/src/org/ofbiz/order/order/OrderServices.java:2357: warning: [deprecation] getAllOrderItemsAdjustmentsTotal(java.util.List,java.util.List,boolean,boolean,boolean) in org.ofbiz.order.order.OrderReadHelper has been deprecated double shippingAmount =
[jira] Commented: (OFBIZ-1244) EntityUtil.getFieldListFromEntityList throw NPE under some conditions
[ https://issues.apache.org/jira/browse/OFBIZ-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588342#action_12588342 ] Jacques Le Roux commented on OFBIZ-1244: Commited by Si in trunk rev. 578874, release4.0 578898 EntityUtil.getFieldListFromEntityList throw NPE under some conditions - Key: OFBIZ-1244 URL: https://issues.apache.org/jira/browse/OFBIZ-1244 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk, Release Branch 4.0 Reporter: Oleg Andreyev Assignee: Si Chen Priority: Minor Fix For: SVN trunk, Release Branch 4.0 Attachments: EntityUtil.diff If we call EntityUtil.getFieldListFromEntityList on field that have no values in each row and set distinct to true then FastSet.contains(), inside this method, will throw NPE. The patch corrects this behavior by skipping null values. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-747) Entity declaration: NOT NULL Fields on database
[
https://issues.apache.org/jira/browse/OFBIZ-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588343#action_12588343
]
Jacques Le Roux commented on OFBIZ-747:
---
Why not add this to the trunk ?
Entity declaration: NOT NULL Fields on database
---
Key: OFBIZ-747
URL: https://issues.apache.org/jira/browse/OFBIZ-747
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Environment: SUSE Linux 10.1 MySQL 5.0.18
Reporter: Michael Imhof
Assignee: Adam Heath
Priority: Minor
Attachments: patch747.txt
We added a new attribute: not-null=true|false to the entity/ tag.
Example:
entity entity-name=Archivindex
package-name=ch.nowhow.isgate.archiv
title=Archiv Index Entity no-auto-stamp=true
field name=id type=id-num/field
field name=notNullField type=herkunft not-null=true/field
prim-key field=id/
/entity
This makes the field NOT NULL on the database (like primary key fields).
Changes:
===
1.http://www.ofbiz.org/dtds/entitymodel.xsd
--
Adding attribute to attlist.field.
xs:attributeGroup name=attlist.field
...
xs:attribute name=not-null default=false
xs:simpleType
xs:restriction base=xs:token
xs:enumeration value=true/
xs:enumeration value=false/
/xs:restriction
/xs:simpleType
/xs:attribute
/xs:attributeGroup
2.ModelField.java
-
* New attribute notNull with getter setter.
protected boolean isNotNull = false;
* Constructor addition:
public ModelField(Element fieldElement) {
this.type = UtilXml.checkEmpty(fieldElement.getAttribute(type));
this.name = UtilXml.checkEmpty(fieldElement.getAttribute(name));
this.setColName(UtilXml.checkEmpty(fieldElement.getAttribute(col-name)));
this.isPk = false; // is set elsewhere
this.encrypt =
UtilXml.checkBoolean(fieldElement.getAttribute(encrypt), false);
this.isNotNull =
UtilXml.checkBoolean(fieldElement.getAttribute(not-null), false);
..
}
* Method #toXmlElement(..)
public Element toXmlElement(Document document) {
..
if (this.getIsNotNull()) {
root.setAttribute(not-null, true);
}
..
}
3.DatabaseUtil.java
Add field.getIsNotNull() to NOT NULL statement in method createTable(...)
if (field.getIsNotNull() || field.getIsPk()) {
if (this.datasourceInfo.alwaysUseConstraintKeyword) {
sqlBuf.append( CONSTRAINT NOT NULL, );
} else {
sqlBuf.append( NOT NULL, );
}
} else {
sqlBuf.append(, );
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1235) Widget Engine integrate with dojo
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1235. -- Resolution: Incomplete Assignee: Jacques Le Roux Widget Engine integrate with dojo - Key: OFBIZ-1235 URL: https://issues.apache.org/jira/browse/OFBIZ-1235 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Environment: all the platform Reporter: WeizhanGuo Assignee: Jacques Le Roux Fix For: SVN trunk This is the AJAX featur for the widget egine, I'd like the widget engine can deal with the dojo like the struts2 integrate with dojo, when you want to use the AJAX function just add theme='ajax' in the form elements. and then the form have the AJAX function like submit it without refresh all page, auto validation the input, make the table pages AJAXed and so on. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-610) Remove all instances of 'required-permissions' usage in service definition files.
[ https://issues.apache.org/jira/browse/OFBIZ-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-610. - Resolution: Fixed Fix Version/s: SVN trunk No required-permissions found in any relevant files (actually finally checked in all files to be sure, so not al all) Remove all instances of 'required-permissions' usage in service definition files. - Key: OFBIZ-610 URL: https://issues.apache.org/jira/browse/OFBIZ-610 Project: OFBiz Issue Type: Sub-task Components: framework, order, product Reporter: Andrew Zeneski Assignee: Andrew Zeneski Fix For: SVN trunk There are currently 61 instances of service definitions which use the now deprecated required-permissions tag. These definitions should all be updated and new permissions services implemented (as needed) to use the new premission-service tag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1187) Leaving out rel-field-name in keymap causes NPE
[ https://issues.apache.org/jira/browse/OFBIZ-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588346#action_12588346 ] Jacques Le Roux commented on OFBIZ-1187: Hi Jacopo, Was just reading your comment by chance. Yes this makes sense to me. Maybe that's the reason why Leon forgot it, Leon ? Leaving out rel-field-name in keymap causes NPE --- Key: OFBIZ-1187 URL: https://issues.apache.org/jira/browse/OFBIZ-1187 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Leon Torres Fix For: SVN trunk If you leave out the rel-field-name for a keymap that requires it, DatabaseUtil.java will crash with a NPE when trying to create it. To reproduce, add the following to an entityengine.xml, extend-entity entity-name=OrderAdjustment field name=orderAdjustmentSubTypeId type=id/ relation type=one fk-name=ORDER_ADJ_SUBTYPE rel-entity-name=OrderAdjustmentType key-map field-name=orderAdjustmentSubTypeId / /relation /extend-entity Note that the key-map is missing a rel-field-name=orderAdjustmentTypeId. Do an ant run-install to create the key. It should crash with a NPE pointing to line 2150 in DatabaseUtil.java: ModelField relField = relModelEntity.getField(keyMap.getRelFieldName()); I believe it should be testing that getRelFieldName() is null, and if so then log a warning and skip the key. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1209) Canceling rental product reservations (room booking)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1209: -- Assignee: Jacques Le Roux (was: Bilgin Ibryam) Canceling rental product reservations (room booking) Key: OFBIZ-1209 URL: https://issues.apache.org/jira/browse/OFBIZ-1209 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: cancelRental.patch Hi all, This is an initial service for canceling rental product reservations, visible through fixed asset calendar. It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1219) Refactoring of accounting companies/admin tab
[ https://issues.apache.org/jira/browse/OFBIZ-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588348#action_12588348 ] Jacques Le Roux commented on OFBIZ-1219: I wonde if there is not a relation between this issue and OFBIZ-455 ? Refactoring of accounting companies/admin tab - Key: OFBIZ-1219 URL: https://issues.apache.org/jira/browse/OFBIZ-1219 Project: OFBiz Issue Type: New Feature Components: accounting Reporter: Eriks Dobelis Priority: Minor Attachments: accAdmin.diff This patch changes existing Companies tab in Accounting application by replacing it with a drop down, which allows to select active company for administrative operations. Companies tab is renamed to Admin to reflect the actual usage. Drop down implementation is the same as in patch attached to OFBIZ-455. This improves usability, as now one can select active company, and does not need to select it each time for administrative actions. Further improvement would be to use this company as the default for creating invoices and payments (trivial to implement). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588350#action_12588350 ] Scott Gray commented on OFBIZ-1663: --- Jacques, I think the error that you were seeing about split payments is a trunk feature that doesn't exist in 4.0 POS: All payment types allow change to be made Key: OFBIZ-1663 URL: https://issues.apache.org/jira/browse/OFBIZ-1663 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 4.0 Attachments: ofbiz-1663.patch I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction. I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales. Does anyone have any international scenarios that would not follow this rule? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1663) POS: All payment types allow change to be made
[ https://issues.apache.org/jira/browse/OFBIZ-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12588355#action_12588355 ] Chris Lombardi commented on OFBIZ-1663: --- Thanks SG! I must have skimmed past the references to 4.0. JLR, did you encounter this defect in 4.0 or trunk? That would explain why I wasn't able to reproduce it. POS: All payment types allow change to be made Key: OFBIZ-1663 URL: https://issues.apache.org/jira/browse/OFBIZ-1663 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: Release Branch 4.0 Reporter: Chris Lombardi Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 4.0 Attachments: ofbiz-1663.patch I fat-fingered the amount of the transaction when I was testing credit card processing and was surprised to see the POS making change for a credit card transaction. I would imagine change would be allowed if and only if the amount of change is less than the amount of cash given. This would apply for both cash sales and multiple payment type sales. Does anyone have any international scenarios that would not follow this rule? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r646132 - /ofbiz/trunk/applications/order/servicedef/services_cart.xml
+1 Scott On 13/04/2008, Jacopo Cappellato [EMAIL PROTECTED] wrote: No feedback on this? However, a committer should always be around to explain and provide further details if there are concerns or questions on his commits. Should we revert this commit? Jacopo On Apr 9, 2008, at 4:29 AM, David E Jones wrote: Actually, transactions ARE important for reading as well as writing, and should pretty much always be used. What was the problem you had that this change is supposed to solve? -David On Apr 8, 2008, at 5:21 PM, [EMAIL PROTECTED] wrote: Author: sichen Date: Tue Apr 8 16:21:14 2008 New Revision: 646132 URL: http://svn.apache.org/viewvc?rev=646132view=rev Log: turning off transactions for loading of cart from quote, since there does not seem to be any data being stored, and having a transaction consumes resources unnecessarily and could cause it to fail if there are many items on a quote Modified: ofbiz/trunk/applications/order/servicedef/services_cart.xml Modified: ofbiz/trunk/applications/order/servicedef/services_cart.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/services_cart.xml?rev=646132r1=646131r2=646132view=diff == --- ofbiz/trunk/applications/order/servicedef/services_cart.xml (original) +++ ofbiz/trunk/applications/order/servicedef/services_cart.xml Tue Apr 8 16:21:14 2008 @@ -103,7 +103,7 @@ /service service name=loadCartFromQuote engine=java auth=true - location=org.ofbiz.order.shoppingcart.ShoppingCartServices invoke=loadCartFromQuote + location=org.ofbiz.order.shoppingcart.ShoppingCartServices invoke=loadCartFromQuote use-transaction=false descriptionCreate a ShoppingCart Object based on an existing quote. If applyQuoteAdjustments is set to false then standard cart adjustments are generated./description attribute name=quoteId type=String mode=IN optional=false/ attribute name=applyQuoteAdjustments type=String mode=IN optional=true/
