Re: Issue with a framework dependency on the Party component
David, see below On Sun, 2009-01-25 at 23:00 -0700, David E Jones wrote: There are various things in the framework now that have general infrastructure that applications can plugin to, and I think we could follow that same pattern here. if you can tell me how to insert 'action' and 'widget' statements in the common/widget/commonscreens.xml decorators from a lower level component, I am very happy to do that. regards, Hans -- http://www.antwebsystems.com : Quality OFBiz support for competitive rates
Re: Split the framework/common component?
On Jan 26, 2009, at 7:11 AM, David E Jones wrote: The specific thing about messages is pretty simple... they should like in the lowest level (most depended on) component that uses them. If they are used in the party and common components, then they should go in the common component. Looking at the common component it is frustrating to see a number of labels/messages that include the word party as the common component doesn't know anything about parties (and should remain lower level and not know anything about parties even if we do split some of it into the applications). Yes, I totally agree with you. What to do with the common component is a bit of a tough call. I originally considered a lot of those data structures to be very generic and appropriate to put in a framework. There are lots of examples of low level tools including infrastructure for things like this, the Java APIs being a good example of one that includes things related to many of these. For sure we still need a common component for the framework, but in my opinion it should contain only framework related common artifacts (entities etc...) and not applications related common artifacts (that should be moved into the new common component in the applications folder). Some entities should definitely stay in the framework, like the Status* and Enumeration* entities in common and the WebSite and related entities in webapp, and I still think most of the other ones should too. There may be specific cases, but for the most part I think they are where they should be. Well, in my opinion these entities would be good candidates for the new applications ' common component (unless they are used by other framework related entities, quite possible, I have not checked this). The main goal would be to have a framework as clean as possible, with no ERP/applications related entities in it (just user related and very tech entities). Jacopo I'll admit some are more dubious, so I'll gladly join in discussing specific entities. Some are really generic, but only used in one application component, like the CustomTimePeriod is only used in accounting, but it is a more generic concept so doesn't have to be only used there and could be reused for other things... -David On Jan 25, 2009, at 12:59 PM, Jacopo Cappellato wrote: I really think it is time to start to think about splitting the common component into two components: 1) a common component to be placed into the applications folder and loaded before the other ones 2) a common component that will stay in the framework folder All these labels, plus other ERP related artifacts, should then go in #1 In my opinion entities like Geo, CountryCode, KeywordThesaurus should not appear in a framework only distro. But maybe I am off topic in this thread and I should create a new one. Jacopo On Jan 25, 2009, at 10:14 AM, risali...@gmail.com wrote: Hi Hans, it's ok to move it to the framework is they are more generics and they can be shared by all the components but in this case I think it's better to put the Common prefix on those labels. Thanks Marco Il giorno 25/gen/09, alle ore 02:54, Hans Bakker ha scritto: Hi Marco, sure we can do this, however captcha itself is a framework function, but at the moment only used in myportal... We will move the captcha messages to the framwork regards, Hans On Sat, 2009-01-24 at 22:22 +0100, risali...@gmail.com wrote: Hi Hans, I suggest to use the prefix MyPortal for those type of labels, I spent a lot of days to cleanup all the wasted labels into OFBiz and I think we cannot all use different standard to codify the labels. And if it's possible do not use the underscore character in the labels name could be more readable. In my opinion for example CaptchaMissingError could be MyPortalCaptchaMissingError or something similar to that. If we do not follow this simple rule in two or three months the labels will be completed wasted again. What others thinks about that ? Thanks Marco Il giorno 20/gen/09, alle ore 09:30, hans...@apache.org ha scritto: Author: hansbak Date: Tue Jan 20 00:30:41 2009 New Revision: 735965 URL: http://svn.apache.org/viewvc?rev=735965view=rev Log: first version of captcha, not perfect yet: multiple users registering at the same time, image should be stored in 'runtime' not working on windows. Another problem is what files to put where.the captcha itself looks like a framework feature...however the registration process needs the party componentso let us know, we will correct it Added: ofbiz/trunk/framework/common/src/org/ofbiz/common/Captcha.java (with props) ofbiz/trunk/specialpurpose/myportal/widget/login.ftl (with props) Modified: ofbiz/trunk/framework/common/widget/CommonMenus.xml ofbiz/trunk/specialpurpose/myportal/config/MyPortalUiLabels.xml
Re: svn commit: r729396 [1/2] - in /ofbiz/trunk: applications/accounting/config/ applications/accounting/entitydef/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/sr
On Jan 26, 2009, at 7:14 AM, David E Jones wrote: I think of the BI stuff as being very like where we are going with themes and portal and such. The framework has infrastructure and the applications and such plugin to that infrastructure (through whatever means make the most sense). For BI that would mean all of the tools (including UI) go in the framework, as long as they do not depend on anything in applications, and that data and services and more custom UI and so on go in the applications or specialpurpose components. That will probably require splitting some of the POC stuff that Jacopo did into different components... David, I totally agree, this is the plan. By the way, I already did the split, apart for the last service named quickInitDataWarehouse that I am not sure where to move... but it can be removed as well, for now it is just easier to test the BI features with it. Jacopo -David On Jan 23, 2009, at 4:42 PM, Jacopo Cappellato wrote: I would really prefer to keep it in the framework and just move the quickInitDataWarehouse (demo) service to somewhere else... any of the existing applications' components would be fine. Jacopo On Jan 5, 2009, at 2:11 AM, Bruno Busco wrote: I have read David's post and I understood that having BI in specialpurpose was not correct because it is a core module for an ERP. From this I thought that having it in application could be ok and still have the framework easily isolable. -Bruno 2009/1/5 BJ Freeman bjf...@free-man.net: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think if you read davids comments included, that is the reason. Framework you can have dependencies on, Application you can not have framework depend on applications. Bruno Busco sent the following on 1/4/2009 1:48 PM: Hi Jacopo, I have moved the bi folder from the framework to application (not specialpurpose) and changed build.xml and component-load.xml. It seems to me that it works well there. Are there any specific reasons for having it in the framework folder and not moving to application folder? Thank you, -Bruno 2009/1/4 Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com: Hi Bruno, these service calls are part of the quickInitDataWarehouse method that is just a util method to simplify the BI setup for demo purposes: I know this is not ideal and I agree that the method should be moved outside of the framework. But maybe for now we could leave it as is and just add a comment to it... it is really useful in demos and testing. Jacopo On Dec 26, 2008, at 8:53 AM, Bruno Busco wrote: That's fine, we should then understand how to resolve some dependencies i.e. service calls like: call-service service- name=loadAllProductsInProductDimension in-map-name=inMap/ or call-service service-name=loadSalesInvoiceFact in-map-name=inMap/ that are defined in catalog and accounting components that (I guess) will not part of the framework. -Bruno 2008/12/26 David E. Jones david.jo...@hotwaxmedia.com: I think you misunderstand. The main bi stuff is just a tool, and really belongs in the framework. Built on top of those tools are OOTB star schema data models that can be used along with the OOTB operational data model. Those belong with the base applications, along with reports that are more generic in nature. Either way, most of the bi stuff is core to OFBiz, and an important part of it (especially the star- schema and data warehouse related parts), and is certainly not a peripheral add-on as being in specialpurpose would imply. -David Bruno Busco wrote: But maybe is better to move files using SVN in order to maintain history... 2008/12/25 Bruno Busco bruno.bu...@gmail.com: If needed I can send a patch for this right now. 2008/12/25 Bruno Busco bruno.bu...@gmail.com: David, I was trying to move the BI folder from framework to specialpurpose and, once changed the build.xml and component-load.xml files, it seems to build and work well. Could we move it in order to simplify the framework-only deploy? -Bruno 2008/12/25 David E. Jones david.jo...@hotwaxmedia.com: The placement of BI in the diagram is based on the original implementation, which was not part of the framework as it is now. BI is kind of a funny one and while there are tools for BI in the framework, and base data structures within the base applications, it can really exist in applications, specialpurpose, or hot-deploy/add-on components. -David Bruno Busco wrote: Thank you David, I did not see this page before and it helps very much. I will take this as a Christmas present from you. ;-) BTW, so this confirms that party should be out of the framework and we should remove all dependences on it from the framework (not adding more). Then I see that the BI also is out of the framework (and this is ok) but in my framework-only installation that I got deleting the applications and specialourpose folders from
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667211#action_12667211 ] Eric DE MAULDE commented on OFBIZ-2128: --- In this patch, the main thing is to save and keep the original image, in order to plan future developments and API improvement. Indeed from an original image, we able to work any changes. We can implement services to modify all images in one time : add a logo, resize, cut, compress ... The current ImageIo.read(new File(filePath)) can't read some JPG images ? What do think about these API : JAI (Java Advanced Imaging from Sun http://java.sun.com/javase/technologies/desktop/media/jai/ ) Imagero (free for non-commercial use, http://reader.imagero.com/ ) product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2140) Failure in create operation for entity [PartyRole]
Failure in create operation for entity [PartyRole] -- Key: OFBIZ-2140 URL: https://issues.apache.org/jira/browse/OFBIZ-2140 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk 737660, PostgresQL 8.1 Reporter: Eric DE MAULDE Priority: Blocker When I load an ANT run-install with or not seed or extseed for the first time There is an error in PartyRole entity and I can't login admin with password ofbiz in backend *** Error : cause - Exception: org.ofbiz.entity.GenericDataSourceException Message: SQL Exception while executing the following:INSERT INTO public.PARTY_ROLE (PARTY_ID, ROLE_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (ERREUR: une instruction insert ou update sur la table � party_role � viole la contrainte de cl� �trang�re � party_rle_role � Detail: La cl� (role_type_id)=(CONTENT_GUEST) n'est pas pr�sente dans la table � role_type �.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2140) Failure in create operation for entity [PartyRole]
[ https://issues.apache.org/jira/browse/OFBIZ-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667236#action_12667236 ] Jacques Le Roux commented on OFBIZ-2140: Hi Eric, I just tried and it works well using XP Sp3, r737638, PostGres 8.3. Are you doing something specific (Im' not sure to understand what you mean by with or not seed or extseed for the first time ? Failure in create operation for entity [PartyRole] -- Key: OFBIZ-2140 URL: https://issues.apache.org/jira/browse/OFBIZ-2140 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk 737660, PostgresQL 8.1 Reporter: Eric DE MAULDE Priority: Blocker When I load an ANT run-install with or not seed or extseed for the first time There is an error in PartyRole entity and I can't login admin with password ofbiz in backend *** Error : cause - Exception: org.ofbiz.entity.GenericDataSourceException Message: SQL Exception while executing the following:INSERT INTO public.PARTY_ROLE (PARTY_ID, ROLE_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (ERREUR: une instruction insert ou update sur la table � party_role � viole la contrainte de cl� �trang�re � party_rle_role � Detail: La cl� (role_type_id)=(CONTENT_GUEST) n'est pas pr�sente dans la table � role_type �.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2140) Failure in create operation for entity [PartyRole]
[ https://issues.apache.org/jira/browse/OFBIZ-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE closed OFBIZ-2140. - Resolution: Fixed Fix Version/s: SVN trunk the error comes from my own changes Failure in create operation for entity [PartyRole] -- Key: OFBIZ-2140 URL: https://issues.apache.org/jira/browse/OFBIZ-2140 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk 737660, PostgresQL 8.1 Reporter: Eric DE MAULDE Priority: Blocker Fix For: SVN trunk When I load an ANT run-install with or not seed or extseed for the first time There is an error in PartyRole entity and I can't login admin with password ofbiz in backend *** Error : cause - Exception: org.ofbiz.entity.GenericDataSourceException Message: SQL Exception while executing the following:INSERT INTO public.PARTY_ROLE (PARTY_ID, ROLE_TYPE_ID, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?) (ERREUR: une instruction insert ou update sur la table � party_role � viole la contrainte de cl� �trang�re � party_rle_role � Detail: La cl� (role_type_id)=(CONTENT_GUEST) n'est pas pr�sente dans la table � role_type �.) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: --- Attachment: productImageAutoScale.patch Hi Eric, In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I 'm still to figure out if we should onot introduce rather an external API for such tool. BTW Imagero is not usable because of licence aspects, it's clearly a commercial product. So the candidates seem to be so far # [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp] # [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf] Any imputs appreciated product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667242#action_12667242 ] Jacques Le Roux commented on OFBIZ-2128: Note also that we should be able to deal with PNG files at least... product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667241#action_12667241 ] jacques.le.roux edited comment on OFBIZ-2128 at 1/26/09 5:32 AM: - Hi Eric, In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I have still to figure out if we should not introduce rather an external API. BTW Imagero is not usable because of licence aspect, it's clearly a commercial product. So the candidates seem to be so far # [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp] # [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf] Any imputs appreciated was (Author: jacques.le.roux): Hi Eric, In this new patch I have added a block of lines (near ImageTransform.java[267]) wich allows a dynamic creation of the framework/images/webapp/images/products sub-directories. I did not commit yet because I 'm still to figure out if we should onot introduce rather an external API for such tool. BTW Imagero is not usable because of licence aspects, it's clearly a commercial product. So the candidates seem to be so far # [PMIW: Poor Man's Imaging Wrapper|http://www.mullassery.com/software/PMIW/index.jsp] # [Java Advanced Imaging (JAI) API|http://java.sun.com/javase/technologies/desktop/media/jai/] tough not sure to [its licence|https://jai.dev.java.net/jdl-jai.pdf] Any imputs appreciated product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667243#action_12667243 ] Jacques Le Roux commented on OFBIZ-2128: Finally JAI seems OK since it uses PMIW which is Apache licenced and used in Jakarta Image-Taglib Paul Piper said (but I will check I have already seen something which seamed OK but was not : Selenium). Anyway if it's OK it seems easier to use PMIW for our current needs... product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667244#action_12667244 ] Jacques Le Roux commented on OFBIZ-2128: Clearly PMIW is ok : http://jakarta.apache.org/taglibs/ product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2110) Add initialAccount field to SalesOpportunity entity
[ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667249#action_12667249 ] Vince Clark commented on OFBIZ-2110: Yes I agree. Currently a lead is automatically assigned to the user that is logged in and there is no way to reassign it to someone else. Add initialAccount field to SalesOpportunity entity --- Key: OFBIZ-2110 URL: https://issues.apache.org/jira/browse/OFBIZ-2110 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Vince Clark Priority: Minor There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-2110) Add initialAccount field to SalesOpportunity entity
Please Pierre it's better to comment inside the Jira issue to keep history at hand. I did it for you at https://issues.apache.org/jira/browse/OFBIZ-2110?focusedCommentId=12667261#action_12667261 Thanks Jacques From: Pierre Smits pierre.sm...@gmail.com Not only that, but they should also be linkt to an employee in the role of 'account manager'. 2009/1/25 Vince Clark (JIRA) j...@apache.org [ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667028#action_12667028] Vince Clark commented on OFBIZ-2110: initialAccount is just the name used in the form. Not sure why it is called initialAccount. I think account would be OK. Sales Opportunities just need to be linked to accounts. Add initialAccount field to SalesOpportunity entity --- Key: OFBIZ-2110 URL: https://issues.apache.org/jira/browse/OFBIZ-2110 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Vince Clark Priority: Minor There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2110) Add initialAccount field to SalesOpportunity entity
[ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-2110: -- Assignee: Jacques Le Roux Add initialAccount field to SalesOpportunity entity --- Key: OFBIZ-2110 URL: https://issues.apache.org/jira/browse/OFBIZ-2110 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Vince Clark Assignee: Jacques Le Roux Priority: Minor There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2110) Add initialAccount field to SalesOpportunity entity
[ https://issues.apache.org/jira/browse/OFBIZ-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667261#action_12667261 ] Jacques Le Roux commented on OFBIZ-2110: Vince's comment above was a reply to this Pierre Smits's comment on dev ML {quote}Not only that, but they should also be linkt to an employee in the role of 'account manager'.{quote} Add initialAccount field to SalesOpportunity entity --- Key: OFBIZ-2110 URL: https://issues.apache.org/jira/browse/OFBIZ-2110 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Vince Clark Priority: Minor There is a field in the SalesOpportunity form to link to a Party but no field in the entity to store it in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: --- Attachment: productImageAutoScale.patch New replacing patch, return in block added was not correct for a service product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: --- Attachment: productImageAutoScale.patch Oops, I forgot new files :/ product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: --- Attachment: (was: productImageAutoScale.patch) product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: --- Attachment: (was: productImageAutoScale.patch) product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-2128: --- Attachment: productImageAutoScale.patch Finally a correct patch ? :) product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1825) Colors and localisation for the calendar
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Ruocco updated OFBIZ-1825: Attachment: LocalizedDate_it.patch This is the date pattern localized for the italian language Colors and localisation for the calendar Key: OFBIZ-1825 URL: https://issues.apache.org/jira/browse/OFBIZ-1825 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 9.3 Attachments: calendar.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif I tried to change the calendar colors, to be more in the OFBiz way. Please let me you know what you think. I also changed some colors to respect our CSS best practices (no color names). Here are some remarks : Colors * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #00 or #ff when actually #000 or #fff is sufficient. * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? * The days initials are not centered but at left (It's late and I did not found the reason) We need to provide a localisation mean. From http://electronicholas.com/calendar?style=defaultformat=natural it should not be too hard. I propose a simple way, maybe we can do better * More calendar formats in a calendar.properties file (like the euro or american ones) * For the moment I think all string are harcoded in calendar_date_select.js Date.weekdays = $w(S M T W T F S); Date.first_day_of_week = 0; Date.months = $w(January February March April May June July August September October November December ); _translations = { OK: OK, Now: Now, Today: Today } A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with hardcoded strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1825) Colors and localisation for the calendar
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Ruocco updated OFBIZ-1825: Attachment: CommonScreens.patch This is a patch for the LookupDecorator with the new localized calendar Colors and localisation for the calendar Key: OFBIZ-1825 URL: https://issues.apache.org/jira/browse/OFBIZ-1825 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Fix For: Release Branch 9.3 Attachments: calendar.patch, calendar_sequence.patch, calendarDateSelectColor.patch, calendarDateSelectColor.patch, calendarModified.patch, CommonScreens.patch, Existing.jpg, LocalizedDate_it.patch, Proposition.jpg, WE_CAL.gif I tried to change the calendar colors, to be more in the OFBiz way. Please let me you know what you think. I also changed some colors to respect our CSS best practices (no color names). Here are some remarks : Colors * I kept the 3 chars scheme when it's was obvious. For instance we don't need to set #00 or #ff when actually #000 or #fff is sufficient. * I used Wikipedia as reference http://en.wikipedia.org/wiki/Web_colors for choising colors. While doing this change I wondered if we could not authorise and even recommend to use sandard names for colors as shown in Wikipedia page. I found it easier to recall a color by its names than by an hexa number...! As long as we would use this Wikipedia reference I think it could be possible to use names instead of hexa, WDYT ? * The days initials are not centered but at left (It's late and I did not found the reason) We need to provide a localisation mean. From http://electronicholas.com/calendar?style=defaultformat=natural it should not be too hard. I propose a simple way, maybe we can do better * More calendar formats in a calendar.properties file (like the euro or american ones) * For the moment I think all string are harcoded in calendar_date_select.js Date.weekdays = $w(S M T W T F S); Date.first_day_of_week = 0; Date.months = $w(January February March April May June July August September October November December ); _translations = { OK: OK, Now: Now, Today: Today } A very simple way (but not very clever I must admit) could be to set a property for the language to use in calendar.properties file and use it in a switch statement with hardcoded strings in calendar_date_select.js. Is anybody aware of better ways to do that in Javascript or Prototype ? BTW I think we should delete calendarstyles.css and calendarTable.css. If it's ok, I will do it when I will upate the attached patch later. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667295#action_12667295 ] Eric DE MAULDE commented on OFBIZ-2128: --- I don't have a lot of experience with Java and OFBiz. Any new ideas and means are welcome. Sure, it's more efficient to implement an API. the main idea is to prepare and implement images automation, from the original images. Thanks Jacques to improve this service product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: svn commit: r729396 [1/2] - in /ofbiz/trunk: applications/accounting/config/ applications/accounting/entitydef/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/sr
On Jan 26, 2009, at 3:09 AM, Jacopo Cappellato wrote: On Jan 26, 2009, at 7:14 AM, David E Jones wrote: I think of the BI stuff as being very like where we are going with themes and portal and such. The framework has infrastructure and the applications and such plugin to that infrastructure (through whatever means make the most sense). For BI that would mean all of the tools (including UI) go in the framework, as long as they do not depend on anything in applications, and that data and services and more custom UI and so on go in the applications or specialpurpose components. That will probably require splitting some of the POC stuff that Jacopo did into different components... David, I totally agree, this is the plan. By the way, I already did the split, apart for the last service named quickInitDataWarehouse that I am not sure where to move... but it can be removed as well, for now it is just easier to test the BI features with it. That service is a good example of one that is a handy feature, and that would be nice to always have, but written as-is would have undesirable dependencies. The first solution that comes to mind is to parameterize it in a way that higher level components can add to, preferably without anything changed in any framework component... which means the database might be most natural place for the info (like some kind of list of services to run to init data warehouse data). -David
[jira] Updated: (OFBIZ-2141) Update UPSServices.java to pass UPS Certification Requirements
[ https://issues.apache.org/jira/browse/OFBIZ-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon Torres updated OFBIZ-2141: --- Attachment: ups-certification.patch Update UPSServices.java to pass UPS Certification Requirements -- Key: OFBIZ-2141 URL: https://issues.apache.org/jira/browse/OFBIZ-2141 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Leon Torres Attachments: ups-certification.patch UPS Certification requires the response documents to be saved in a certain format. This patch modifies UPSServices.java to meet these requirements. Specifically: 1. Label images must be saved as label${trackingNumber}.gif to the filesystem 2. The high Value report HTML document must be saved to the filesystem. Additionally, this HTML document is saved in ShipmentRouteSegment.upsHighValue report for reference (simplest change possible without introducing normalized carrier tables). With this patch, all required documents for the UPS certification process can be generated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2141) Update UPSServices.java to pass UPS Certification Requirements
Update UPSServices.java to pass UPS Certification Requirements -- Key: OFBIZ-2141 URL: https://issues.apache.org/jira/browse/OFBIZ-2141 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Leon Torres Attachments: ups-certification.patch UPS Certification requires the response documents to be saved in a certain format. This patch modifies UPSServices.java to meet these requirements. Specifically: 1. Label images must be saved as label${trackingNumber}.gif to the filesystem 2. The high Value report HTML document must be saved to the filesystem. Additionally, this HTML document is saved in ShipmentRouteSegment.upsHighValue report for reference (simplest change possible without introducing normalized carrier tables). With this patch, all required documents for the UPS certification process can be generated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2141) Update UPSServices.java to pass UPS Certification Requirements
[ https://issues.apache.org/jira/browse/OFBIZ-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667355#action_12667355 ] Leon Torres commented on OFBIZ-2141: For reference, this is to meet the requirements for UPS OnLine Tools. The document in which you can find the certification process and requirements is the Shipping XML Tool Developers Gude. You will need an account with UPS to access the documentation. The section in the PDF should be under UPS Label Certification Update UPSServices.java to pass UPS Certification Requirements -- Key: OFBIZ-2141 URL: https://issues.apache.org/jira/browse/OFBIZ-2141 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Leon Torres Attachments: ups-certification.patch UPS Certification requires the response documents to be saved in a certain format. This patch modifies UPSServices.java to meet these requirements. Specifically: 1. Label images must be saved as label${trackingNumber}.gif to the filesystem 2. The high Value report HTML document must be saved to the filesystem. Additionally, this HTML document is saved in ShipmentRouteSegment.upsHighValue report for reference (simplest change possible without introducing normalized carrier tables). With this patch, all required documents for the UPS certification process can be generated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Issue with a framework dependency on the Party component
On Jan 26, 2009, at 1:53 AM, Hans Bakker wrote: David, see below On Sun, 2009-01-25 at 23:00 -0700, David E Jones wrote: There are various things in the framework now that have general infrastructure that applications can plugin to, and I think we could follow that same pattern here. if you can tell me how to insert 'action' and 'widget' statements in the common/widget/commonscreens.xml decorators from a lower level component, I am very happy to do that. The main tool to combine actions and widgets is the screen widget, so including screens would be the natural way to get this information shown in the header. In a way the header is too big right now anyway, ie the code is all in one big block and such, and it would be nice to have it more parameterized and organized, and easier to customize... perhaps even with preferences and what what (seems to be the general direction we're going). What I was saying about the CSS and JS files is that we have a list of those files to include for those, and for things to go in the header we could create a similar list of screens to include, and just loop through it (in the header.ftl file) and include each one using the screens.include thingy. These would just be little informational screenlets to show stuff in the header, just like these things you've added (ie the organization party, even others like the currency, etc). I hope that helps. -David
Re: Issue with a framework dependency on the Party component
Or we could add more sections to the global decorator. -Adrian David E Jones wrote: On Jan 26, 2009, at 1:53 AM, Hans Bakker wrote: David, see below On Sun, 2009-01-25 at 23:00 -0700, David E Jones wrote: There are various things in the framework now that have general infrastructure that applications can plugin to, and I think we could follow that same pattern here. if you can tell me how to insert 'action' and 'widget' statements in the common/widget/commonscreens.xml decorators from a lower level component, I am very happy to do that. The main tool to combine actions and widgets is the screen widget, so including screens would be the natural way to get this information shown in the header. In a way the header is too big right now anyway, ie the code is all in one big block and such, and it would be nice to have it more parameterized and organized, and easier to customize... perhaps even with preferences and what what (seems to be the general direction we're going). What I was saying about the CSS and JS files is that we have a list of those files to include for those, and for things to go in the header we could create a similar list of screens to include, and just loop through it (in the header.ftl file) and include each one using the screens.include thingy. These would just be little informational screenlets to show stuff in the header, just like these things you've added (ie the organization party, even others like the currency, etc). I hope that helps. -David
Re: What is happening with OrderItemShipGroup.productStoreShipMethId?
Bump ? Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com I checked using FishEye and Nabble, it seems that OrderItemShipGroup.productStoreShipMethId field never existed. There are such fields in some Product entities String productStoreShipMethId = cart.getProductStoreShipMethId(); was introduced in in r727381 (OFBIZ-2082) I guess we should better use cart.getProductStoreShipMethId(); But this means to pass a cart someway. I did not look further This prevent to add some types of Product to an existing order and should be fixed ASAP Jacques From: David E Jones david.jo...@hotwaxmedia.com It appears that there used to be a OrderItemShipGroup.productStoreShipMethId field, but there is no longer one, and when an order is saved the productStoreShipMethId in the ShoppingCart object is no longer saved. If anyone knows anything about this... Is that correct? If so, why was this change made? If no one knows anything about this then I think some investigation is needed... :( There is still some code that tries to use it that flares up when trying to edit an order item (orderdetail page in the Order Manager, Edit Items link, change quantity on any item): 2009-01-10 15:35:14,759 (http-0.0.0.0-8443-2) [ ServiceDispatcher.java:500:ERROR] exception report -- Service [recalcShippingTotal] threw an unexpected exception/error Exception: org.ofbiz.service.GenericServiceException Message: Service [recalcShippingTotal] target threw an unexpected exception ([GenericEntity.get] productStoreShipMethId is not a field of OrderItemShipGroup) cause - Exception: java.lang.IllegalArgumentException Message: [GenericEntity.get] productStoreShipMethId is not a field of OrderItemShipGroup stack trace --- java.lang.IllegalArgumentException: [GenericEntity.get] productStoreShipMethId is not a field of OrderItemShipGroup org.ofbiz.entity.GenericEntity.get(GenericEntity.java:308) org.ofbiz.entity.GenericEntity.getString(GenericEntity.java:585) org .ofbiz .order .shoppingcart .shipping.ShippingEvents.getShipEstimate(ShippingEvents.java:121) org .ofbiz .order.order.OrderServices.recalcOrderShipping(OrderServices.java:1602) -David
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667368#action_12667368 ] Jacques Le Roux commented on OFBIZ-2128: Eric, What are the problems you face so far ? Because it's better to have something that works, even incomplete, than nothing, maybe we could already commit as is if the issues are not to annoying... product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667389#action_12667389 ] Eric DE MAULDE commented on OFBIZ-2128: --- Of course, I works with this service, even if the resize resolution isn't excellent. If we save original images, one day with a better API we can resize again by example. I'm not a comitter to decide ! Just I have suggested a solution product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Security Issues
Hi Pierre, From: pierre pierre.gau...@nereide.biz Hi all, Here is a proposition on how to implement such XSS control: First we consider that all HHTP request should be filtering. So we could add a filter into web.xml for each webapp that replaces a set of dangerous characters by there HTML code. By this way we can block all XSS attacks for entire application. Yes it makes sens indeed, that's what Michele also suggested in this thread, (with less details) : http://www.nabble.com/Re%3A-Security-Issues-p21628377.html After filtering all requests, we should add a way to parameterise this. So we could add 2 properties : - the first one to specifie a regex pattern that is used by filter engine - the second one to disable filtering And to be very flexible we can set those properties (or attributes) on 3 levels : - request (from request-map) - webapp (for a complete webbapp) - application (main level) The more flexible the better. And finaly we could consider that if there are no paramateres on request level, then we look for webapp parameters. If there are no parameters on webapp we look for application parameters. By this way we could filter all request and set exeption or regex for a particular request or webb-app or entire application. What do you think about this. Yes this will cover this security aspect, and sounds good to me. Thanks Jacques Pierre David E Jones wrote: Hello all. I'm actually a little surprised we're still where we are on this, so I'm putting some time into this... understanding that it will annoy as many people as it pleases (at first anyway...). In order to address various XSS and XSS-like security threats, I'd like to get some real and comprehensive stuff in place. Right now there are super-easy attacks that can be done, like putting JavaScript in a field during checkout that gets executed when a CSR (or anyone using the Order Manager) looks at the order, or someone looks at it in the Party Manager or wherever. That script can grab the session id and send it to a URL for session hijacking, or it can directly perform some action like marking the order as paid offline or creating a new admin account or changing the users password or whatever. The script could do anything the poor back-end user has access to do, and that's just an example. The best issues on this are: https://issues.apache.org/jira/browse/OFBIZ-1959 (newer one, good review of OFBiz security and applicable comments, good tips to resolve) https://issues.apache.org/jira/browse/OFBIZ-260 (the old/original one, including my silly comment on it) We have some simple code that does escaping for HTML chars, but it's not really used anywhere. Anyway, I think we need something more robust and comprehensive, especially given the fun ways of getting around filters and other things presented here: http://ha.ckers.org/xss.html What I'd like to do is add the OWASP ESAPI library, which is BSD licensed. There is a nice presentation about it as well here: http://code.google.com/p/owasp-esapi-java/ and JavaDocs here: http://owasp-esapi-java.googlecode.com/svn/trunk_doc/index.html == So, there's a tool, now how/where to use it in OFBiz... I think this will require a fair bit of work, and I know I'll miss things that are important in this first pass, but we can do some things to take care of the more obvious problems: 1. validate input: consider not allowing HTML in any field by default, and require an attribute set on service attributes or possibly even entity fields to say that restricted/safe HTML is allowed, or any HTML is allowed; this will break some things that actually need HTML initially, but fixing the broken things once found will be really easy 2. encode output: just in case HTML chars do get in somehow, we want to encode them so they are displayed literally and not interpreted as HTML by the browser; this will help avoid problems with messing up formatting when HTML is present, as well as helping with this security problem; this is easy to do in the various widgets (Screen, Form, Tree, Menu), and is tougher in FTL files if we want it encoded by default instead of manually using ?html on every field we want encoded, and I'd rather use the ESAPI encoder than the FTL one too; since much of this data is displayed right out of GenericValue objects, one possible solution is to change the GenericValue.get methods to do this encoding, and add a new get method that will not do encoding; this would handle the situations where the GenericValue is treated like a Map; this may also cause some crazy stuff to happen in places where gets are used in services and such and not in the UI... but I'm still thinking that through and am not sure if it will be a problem... it is kind of using bomb to swat a fly so collateral damage is likely 3. consider adding a token that is required for all requests in a session except the
[jira] Commented: (OFBIZ-2137) Artifact cleaning after recent changes on xsd files
[ https://issues.apache.org/jira/browse/OFBIZ-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667407#action_12667407 ] Marco Risaliti commented on OFBIZ-2137: --- Committed artifact_cleaning_ecommerce.patch into trunk rev. 737833. Artifact cleaning after recent changes on xsd files --- Key: OFBIZ-2137 URL: https://issues.apache.org/jira/browse/OFBIZ-2137 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: artifact_cleaning1.patch, artifact_cleaning_ecommerce.patch, artifact_cleaning_humanres.patch, artifact_cleaning_manufacturing.patch, artifact_cleaning_marketing.patch, artifact_cleaning_order.patch, artifact_cleaning_party.patch, artifact_cleaning_product.patch Artifact cleaning after recent changes on xsd files -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667443#action_12667443 ] Jacques Le Roux commented on OFBIZ-2128: So the only issues would be not optimal resize resolution, some JPG not working and no PNG at all ? product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Header menu
Hi devs, I would like to take your attention to the fact that when selecting the bluelight theme we get the logout option in the drop down menu (and in some case like projectmgr even the help option) that is not really fine. I did place a logout link in the header of the bluelight theme to be ready to the removal of the logout menu-item from the CommonAppMenu. I propose to create a new _framework_ CommonHeaderMenu with the following menu-items: Preferences, Help, Logout The Preferences link should take to a _framework_ defined screen that let the user to select its own preferences like: VisualTheme, Language, TimeZone, etc. These links could be removed from the header and we will have it less cowded. The actual Logout menu-item should be removed from the CommonAppMenu. The Help link will always be present in the CommonHeaderMenu and we should remove the actual help link that we have is some AppMenu. The help link should be resolved with something to what proposed in* **OFBIZ-2133https://issues.apache.org/jira/browse/OFBIZ-2133 * What do you think about?* *-Bruno * *
Re: Header menu
+1 Jacques From: Bruno Busco bruno.bu...@gmail.com Hi devs, I would like to take your attention to the fact that when selecting the bluelight theme we get the logout option in the drop down menu (and in some case like projectmgr even the help option) that is not really fine. I did place a logout link in the header of the bluelight theme to be ready to the removal of the logout menu-item from the CommonAppMenu. I propose to create a new _framework_ CommonHeaderMenu with the following menu-items: Preferences, Help, Logout The Preferences link should take to a _framework_ defined screen that let the user to select its own preferences like: VisualTheme, Language, TimeZone, etc. These links could be removed from the header and we will have it less cowded. The actual Logout menu-item should be removed from the CommonAppMenu. The Help link will always be present in the CommonHeaderMenu and we should remove the actual help link that we have is some AppMenu. The help link should be resolved with something to what proposed in* **OFBIZ-2133https://issues.apache.org/jira/browse/OFBIZ-2133 * What do you think about?* *-Bruno * *
Re: Split the framework/common component?
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Jan 26, 2009, at 7:11 AM, David E Jones wrote: The specific thing about messages is pretty simple... they should like in the lowest level (most depended on) component that uses them. If they are used in the party and common components, then they should go in the common component. Looking at the common component it is frustrating to see a number of labels/messages that include the word party as the common component doesn't know anything about parties (and should remain lower level and not know anything about parties even if we do split some of it into the applications). Yes, I totally agree with you. From a practical point of view I would prefer Jacopo's solution. For instance take the label CommonGeoLocation. I agree it has nothing to do in Framework. But on the other hand it's no more related to Party than Product (Facility) or Accouting (Fixed Asset). So, from a logical point of view, it does not make sense to put them in Party (most depended on) and we could create a Common application component where such artifacts (not only labels) could reside. I'm sure that at term it will prove useful, because it's logical! Why searching in Party something common at the same level at several components ? What to do with the common component is a bit of a tough call. I originally considered a lot of those data structures to be very generic and appropriate to put in a framework. There are lots of examples of low level tools including infrastructure for things like this, the Java APIs being a good example of one that includes things related to many of these. For sure we still need a common component for the framework, but in my opinion it should contain only framework related common artifacts (entities etc...) and not applications related common artifacts (that should be moved into the new common component in the applications folder). +1 Some entities should definitely stay in the framework, like the Status* and Enumeration* entities in common and the WebSite and related entities in webapp, and I still think most of the other ones should too. There may be specific cases, but for the most part I think they are where they should be. Well, in my opinion these entities would be good candidates for the new applications ' common component (unless they are used by other framework related entities, quite possible, I have not checked this). The main goal would be to have a framework as clean as possible, with no ERP/applications related entities in it (just user related and very tech entities). +1 My 2cts Jacques Jacopo I'll admit some are more dubious, so I'll gladly join in discussing specific entities. Some are really generic, but only used in one application component, like the CustomTimePeriod is only used in accounting, but it is a more generic concept so doesn't have to be only used there and could be reused for other things... -David On Jan 25, 2009, at 12:59 PM, Jacopo Cappellato wrote: I really think it is time to start to think about splitting the common component into two components: 1) a common component to be placed into the applications folder and loaded before the other ones 2) a common component that will stay in the framework folder All these labels, plus other ERP related artifacts, should then go in #1 In my opinion entities like Geo, CountryCode, KeywordThesaurus should not appear in a framework only distro. But maybe I am off topic in this thread and I should create a new one. Jacopo On Jan 25, 2009, at 10:14 AM, risali...@gmail.com wrote: Hi Hans, it's ok to move it to the framework is they are more generics and they can be shared by all the components but in this case I think it's better to put the Common prefix on those labels. Thanks Marco Il giorno 25/gen/09, alle ore 02:54, Hans Bakker ha scritto: Hi Marco, sure we can do this, however captcha itself is a framework function, but at the moment only used in myportal... We will move the captcha messages to the framwork regards, Hans On Sat, 2009-01-24 at 22:22 +0100, risali...@gmail.com wrote: Hi Hans, I suggest to use the prefix MyPortal for those type of labels, I spent a lot of days to cleanup all the wasted labels into OFBiz and I think we cannot all use different standard to codify the labels. And if it's possible do not use the underscore character in the labels name could be more readable. In my opinion for example CaptchaMissingError could be MyPortalCaptchaMissingError or something similar to that. If we do not follow this simple rule in two or three months the labels will be completed wasted again. What others thinks about that ? Thanks Marco Il giorno 20/gen/09, alle ore 09:30, hans...@apache.org ha scritto: Author: hansbak Date: Tue Jan 20 00:30:41 2009 New Revision: 735965 URL: http://svn.apache.org/viewvc?rev=735965view=rev Log: first version of
[jira] Commented: (OFBIZ-2128) product image auto scale
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667485#action_12667485 ] Eric DE MAULDE commented on OFBIZ-2128: --- JPG Images from one supplier can't be read with ImageIO.read, as all tried PNG images. However documentation says these formats are compatible (http://java.sun.com/j2se/1.5.0/docs/api/javax/imageio/package-summary.html) By example resizing resolution is a bit better with Gimp It would be better to try with another API ? product image auto scale - Key: OFBIZ-2128 URL: https://issues.apache.org/jira/browse/OFBIZ-2128 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Environment: Linux Debian, OFBiz trunk rev. 737217 Reporter: Eric DE MAULDE Assignee: Jacques Le Roux Priority: Trivial Fix For: SVN trunk Attachments: productImageAutoScale.patch, productImageAutoScale.patch, screenshot-1.jpg This change allows to auto-scale product image when a user upload an original image. The original image is saved into OFBiz. Default dimensions of each image size type (small, medium, large, detail) are defined in ImageProperties.xml When an user uploads an original image, OFBiz resizes this image and creates each related file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Issue with a framework dependency on the Party component
David, ok i understand, however that means we have to asd the retrieval/display of the logged in party/defaultOrganizationParty in every application component? i still think there is a need for an application-decorator between the application and the global-decorator. Regards, Hans On Mon, 2009-01-26 at 12:33 -0700, David E Jones wrote: On Jan 26, 2009, at 1:53 AM, Hans Bakker wrote: David, see below On Sun, 2009-01-25 at 23:00 -0700, David E Jones wrote: There are various things in the framework now that have general infrastructure that applications can plugin to, and I think we could follow that same pattern here. if you can tell me how to insert 'action' and 'widget' statements in the common/widget/commonscreens.xml decorators from a lower level component, I am very happy to do that. The main tool to combine actions and widgets is the screen widget, so including screens would be the natural way to get this information shown in the header. In a way the header is too big right now anyway, ie the code is all in one big block and such, and it would be nice to have it more parameterized and organized, and easier to customize... perhaps even with preferences and what what (seems to be the general direction we're going). What I was saying about the CSS and JS files is that we have a list of those files to include for those, and for things to go in the header we could create a similar list of screens to include, and just loop through it (in the header.ftl file) and include each one using the screens.include thingy. These would just be little informational screenlets to show stuff in the header, just like these things you've added (ie the organization party, even others like the currency, etc). I hope that helps. -David -- http://www.antwebsystems.com : Quality OFBiz support for competitive rates
Re: svn commit: r737671 - in /ofbiz/trunk/applications: ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl order/webapp/ordermgr/entry/catalog/configproductdetail.ftl
Thanks a lot Bilgin -- Regards Amit Sharma bibr...@apache.org wrote: Author: bibryam Date: Mon Jan 26 10:59:37 2009 New Revision: 737671 URL: http://svn.apache.org/viewvc?rev=737671view=rev Log: Fixed NPE in configurable product screen reported by Amit in user list. Modified: ofbiz/trunk/applications/ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/configproductdetail.ftl Modified: ofbiz/trunk/applications/ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl?rev=737671r1=737670r2=737671view=diff == --- ofbiz/trunk/applications/ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl (original) +++ ofbiz/trunk/applications/ecommerce/webapp/ecommerce/catalog/configproductdetail.ftl Mon Jan 26 10:59:37 2009 @@ -366,7 +366,7 @@ form name=addToShoppingList method=post action=@ofbizUrladdItemToShoppingList#if requestAttributes._CURRENT_VIEW_?exists/${requestAttributes._CURRENT_VIEW_}/#if/@ofbizUrl input type=hidden name=productId value=${product.productId} input type=hidden name=product_id value=${product.productId} - input type=hidden name=configId value=${configId} + input type=hidden name=configId value=${configId?if_exists} select name=shoppingListId #if shoppingLists?has_content #list shoppingLists as shoppingList Modified: ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/configproductdetail.ftl URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/configproductdetail.ftl?rev=737671r1=737670r2=737671view=diff == --- ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/configproductdetail.ftl (original) +++ ofbiz/trunk/applications/order/webapp/ordermgr/entry/catalog/configproductdetail.ftl Mon Jan 26 10:59:37 2009 @@ -366,7 +366,7 @@ form name=addToShoppingList method=post action=@ofbizUrladdItemToShoppingList#if requestAttributes._CURRENT_VIEW_?exists/${requestAttributes._CURRENT_VIEW_}/#if/@ofbizUrl input type=hidden name=productId value=${product.productId} input type=hidden name=product_id value=${product.productId} - input type=hidden name=configId value=${configId} + input type=hidden name=configId value=${configId?if_exists} select name=shoppingListId #if shoppingLists?has_content #list shoppingLists as shoppingList
[jira] Created: (OFBIZ-2142) error message of login service does not show with common/messages.ftl
error message of login service does not show with common/messages.ftl - Key: OFBIZ-2142 URL: https://issues.apache.org/jira/browse/OFBIZ-2142 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Hans Bakker Fix For: SVN trunk if i login to the system and type in a wrong password only the message: The Following Errors Occurred: appears. The actual message as is shown in the log: 2009-01-27 12:50:47,270 (http-0.0.0.0-8443-1) [ ServiceDispatcher.java:522:ERROR] Error in Service [userLogin]: Password incorrect. does not appear.i checked, the service returns the message properly however it does not arrive in the messages.ftl so somewhere in the framework it gets lost. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2143) payrol entities and payrolinvoiceItemtype
payrol entities and payrolinvoiceItemtype - Key: OFBIZ-2143 URL: https://issues.apache.org/jira/browse/OFBIZ-2143 Project: OFBiz Issue Type: Improvement Reporter: Hans Bakker Just a reminder to not forget. Currently it is possible to create apayrolslip inludinbg check. The maojor items on a payslip are: 1.salary/hourly wages 2.Deductions 3. Tax now it appears there are other tables in the system which are very similar or even duplicate information: 1. BenefitType 2. DeductionType 3. TaxType we could consider using the field hasTable=y for these payrol invoice item types -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2143) payrol entities and payrolinvoiceItemtype
[ https://issues.apache.org/jira/browse/OFBIZ-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-2143: --- Description: Just a reminder to not forget. Currently it is possible to create apayrolslip inludinbg check. The maojor items on a payslip are: 1.salary/hourly wages 2.Deductions 3. Tax now it appears there are other tables in the system which are very similar or even duplicate information: 1. BenefitType 2. DeductionType 3. TaxAuthorityRateType we could consider using the field hasTable=y for these payrol invoice item types was: Just a reminder to not forget. Currently it is possible to create apayrolslip inludinbg check. The maojor items on a payslip are: 1.salary/hourly wages 2.Deductions 3. Tax now it appears there are other tables in the system which are very similar or even duplicate information: 1. BenefitType 2. DeductionType 3. TaxType we could consider using the field hasTable=y for these payrol invoice item types payrol entities and payrolinvoiceItemtype - Key: OFBIZ-2143 URL: https://issues.apache.org/jira/browse/OFBIZ-2143 Project: OFBiz Issue Type: Improvement Reporter: Hans Bakker Just a reminder to not forget. Currently it is possible to create apayrolslip inludinbg check. The maojor items on a payslip are: 1.salary/hourly wages 2.Deductions 3. Tax now it appears there are other tables in the system which are very similar or even duplicate information: 1. BenefitType 2. DeductionType 3. TaxAuthorityRateType we could consider using the field hasTable=y for these payrol invoice item types -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.