date:20110114

Hi Hans,

could you please better explain what was the error and why you have decided to 
modify the PerfReviewItem entity?
I am asking you this because, even if I don't know much about this area of the 
data model, from what I understand:
- PerfReview is used to define an employee performance review; this is why we 
have a primary key composed by the employee party id, its role and an index 
(for the specific review)
- PerfReviewItem is used to provide details about a specific review (defined 
above); this is why we had a primary key composed by the primary key of the 
PerfReview entity and an additional subindex (perfReviewItemSeqId)

I don't doubt that the existing services were not working, but I am wondering 
if there was another way to fix them instead of altering the primary key of the 
PerfReviewItem entity.

Kind regards,

Jacopo

On Jan 14, 2011, at 9:40 AM, hans...@apache.org wrote:

 Author: hansbak
 Date: Fri Jan 14 08:40:01 2011
 New Revision: 1058891
 
 URL: http://svn.apache.org/viewvc?rev=1058891view=rev
 Log:
 made the employee review item work, corrected a completely wrong entity 
 definition prefreviewitem, services now work again and added new type data. 
 Added buttons to be able to select reveiw and item list NOTE: This change 
 needs recreating of the PerfReviewItem index, the fields and format did not 
 change, just the indexing
 
 Modified:
ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml
ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml
ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml
 
 Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891r1=1058890r2=1058891view=diff
 ==
 --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
 +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 
 08:40:01 2011
 @@ -153,5 +153,17 @@ under the License.
 
 EmplLeaveReasonType description=Medical hasTable=N parentTypeId= 
 emplLeaveReasonTypeId=Fever/
 EmplLeaveReasonType description=Casual hasTable=N parentTypeId= 
 emplLeaveReasonTypeId=Personal Work/
 +
 +PerfReviewItemType perfRatingTypeId=TECH hasTable=N 
 description=Technical skills/
 +PerfReviewItemType perfRatingTypeId=RESP hasTable=N 
 description=Responsibility/
 +PerfReviewItemType perfRatingTypeId=ATT hasTable=N 
 description=Attitude/
 +PerfReviewItemType perfRatingTypeId=COMM hasTable=N 
 description=Communication skills/
 +PerfReviewItemType perfRatingTypeId=JOBSAT hasTable=N 
 description=Job Satisfaction/
 +
 +PerfRatingType perfRatingTypeId=1 hasTable=N description=Fails to 
 Meet Expectations/
 +PerfRatingType perfRatingTypeId=2 hasTable=N 
 description=Inconsistently Fulfills/
 +PerfRatingType perfRatingTypeId=3 hasTable=N description=Fulfilled 
 Expectations/
 +PerfRatingType perfRatingTypeId=4 hasTable=N 
 description=Frequently Exceeds/
 +PerfRatingType perfRatingTypeId=5 hasTable=N 
 description=Consistently Exceeds/
 
 /entity-engine-xml
 
 Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891r1=1058890r2=1058891view=diff
 ==
 --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original)
 +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 
 08:40:01 2011
 @@ -164,15 +164,13 @@ under the License.
 entity entity-name=PerfReviewItem
 package-name=org.ofbiz.humanres.ability
 title=Performance Review Item Entity
 -  field name=employeePartyId type=id-ne/field
 -  field name=employeeRoleTypeId type=id/field
   field name=perfReviewId type=id-ne/field
   field name=perfReviewItemSeqId type=id-ne/field
   field name=perfRatingTypeId type=id/field
   field name=perfReviewItemTypeId type=id/field
 +  field name=employeePartyId type=id-ne/field
 +  field name=employeeRoleTypeId type=id/field
   field name=comments type=comment/field
 -  prim-key field=employeePartyId/
 -  prim-key field=employeeRoleTypeId/
   prim-key field=perfReviewId/
   prim-key field=perfReviewItemSeqId/
   relation type=one fk-name=PERF_RVITM_PFRV 
 rel-entity-name=PerfReview
 
 Modified: ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/widget/CommonScreens.xml?rev=1058891r1=1058890r2=1058891view=diff

Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid

2011-01-14 Thread Hans Bakker

I changed this entity according the datamodel resource boook and what
the forms and services where expecting,

please note the fields were not added or removed on the forms.

Regards,
Hans

On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote:
 Hi Hans,
 
 could you please better explain what was the error and why you have decided 
 to modify the PerfReviewItem entity?
 I am asking you this because, even if I don't know much about this area of 
 the data model, from what I understand:
 - PerfReview is used to define an employee performance review; this is why we 
 have a primary key composed by the employee party id, its role and an index 
 (for the specific review)
 - PerfReviewItem is used to provide details about a specific review (defined 
 above); this is why we had a primary key composed by the primary key of the 
 PerfReview entity and an additional subindex (perfReviewItemSeqId)
 
 I don't doubt that the existing services were not working, but I am wondering 
 if there was another way to fix them instead of altering the primary key of 
 the PerfReviewItem entity.
 
 Kind regards,
 
 Jacopo
 
 On Jan 14, 2011, at 9:40 AM, hans...@apache.org wrote:
 
  Author: hansbak
  Date: Fri Jan 14 08:40:01 2011
  New Revision: 1058891
  
  URL: http://svn.apache.org/viewvc?rev=1058891view=rev
  Log:
  made the employee review item work, corrected a completely wrong entity 
  definition prefreviewitem, services now work again and added new type data. 
  Added buttons to be able to select reveiw and item list NOTE: This change 
  needs recreating of the PerfReviewItem index, the fields and format did not 
  change, just the indexing
  
  Modified:
 ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
 ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
 ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
 ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml
 ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml
 ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml
  
  Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891r1=1058890r2=1058891view=diff
  ==
  --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
  +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 
  08:40:01 2011
  @@ -153,5 +153,17 @@ under the License.
  
  EmplLeaveReasonType description=Medical hasTable=N parentTypeId= 
  emplLeaveReasonTypeId=Fever/
  EmplLeaveReasonType description=Casual hasTable=N parentTypeId= 
  emplLeaveReasonTypeId=Personal Work/
  +
  +PerfReviewItemType perfRatingTypeId=TECH hasTable=N 
  description=Technical skills/
  +PerfReviewItemType perfRatingTypeId=RESP hasTable=N 
  description=Responsibility/
  +PerfReviewItemType perfRatingTypeId=ATT hasTable=N 
  description=Attitude/
  +PerfReviewItemType perfRatingTypeId=COMM hasTable=N 
  description=Communication skills/
  +PerfReviewItemType perfRatingTypeId=JOBSAT hasTable=N 
  description=Job Satisfaction/
  +
  +PerfRatingType perfRatingTypeId=1 hasTable=N description=Fails 
  to Meet Expectations/
  +PerfRatingType perfRatingTypeId=2 hasTable=N 
  description=Inconsistently Fulfills/
  +PerfRatingType perfRatingTypeId=3 hasTable=N 
  description=Fulfilled Expectations/
  +PerfRatingType perfRatingTypeId=4 hasTable=N 
  description=Frequently Exceeds/
  +PerfRatingType perfRatingTypeId=5 hasTable=N 
  description=Consistently Exceeds/
  
  /entity-engine-xml
  
  Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891r1=1058890r2=1058891view=diff
  ==
  --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original)
  +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 
  08:40:01 2011
  @@ -164,15 +164,13 @@ under the License.
  entity entity-name=PerfReviewItem
  package-name=org.ofbiz.humanres.ability
  title=Performance Review Item Entity
  -  field name=employeePartyId type=id-ne/field
  -  field name=employeeRoleTypeId type=id/field
field name=perfReviewId type=id-ne/field
field name=perfReviewItemSeqId type=id-ne/field
field name=perfRatingTypeId type=id/field
field name=perfReviewItemTypeId type=id/field
  +  field name=employeePartyId type=id-ne/field
  +  field name=employeeRoleTypeId type=id/field
field name=comments type=comment/field
  -  prim-key field=employeePartyId/
  -  prim-key field=employeeRoleTypeId/
prim-key field=perfReviewId/

Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid

2011-01-14 Thread Hans Bakker

Ok i did not see the unusual index of the PerfRreview too:  which
includes the employeeId and role. This is also not according the
dataresource book. I would even suggest to take the employeeparty and
role out of this key too and follow the general pattern that the
perfReview entity has a single key field perfReviewId.

Thanks for commenting on this.

Regards,
Hans

On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote:
 Hi Hans,
 
 could you please better explain what was the error and why you have decided 
 to modify the PerfReviewItem entity?
 I am asking you this because, even if I don't know much about this area of 
 the data model, from what I understand:
 - PerfReview is used to define an employee performance review; this is why we 
 have a primary key composed by the employee party id, its role and an index 
 (for the specific review)
 - PerfReviewItem is used to provide details about a specific review (defined 
 above); this is why we had a primary key composed by the primary key of the 
 PerfReview entity and an additional subindex (perfReviewItemSeqId)
 
 I don't doubt that the existing services were not working, but I am wondering 
 if there was another way to fix them instead of altering the primary key of 
 the PerfReviewItem entity.
 
 Kind regards,
 
 Jacopo
 
 On Jan 14, 2011, at 9:40 AM, hans...@apache.org wrote:
 
  Author: hansbak
  Date: Fri Jan 14 08:40:01 2011
  New Revision: 1058891
  
  URL: http://svn.apache.org/viewvc?rev=1058891view=rev
  Log:
  made the employee review item work, corrected a completely wrong entity 
  definition prefreviewitem, services now work again and added new type data. 
  Added buttons to be able to select reveiw and item list NOTE: This change 
  needs recreating of the PerfReviewItem index, the fields and format did not 
  change, just the indexing
  
  Modified:
 ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
 ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
 ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
 ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml
 ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml
 ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml
  
  Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891r1=1058890r2=1058891view=diff
  ==
  --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
  +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 
  08:40:01 2011
  @@ -153,5 +153,17 @@ under the License.
  
  EmplLeaveReasonType description=Medical hasTable=N parentTypeId= 
  emplLeaveReasonTypeId=Fever/
  EmplLeaveReasonType description=Casual hasTable=N parentTypeId= 
  emplLeaveReasonTypeId=Personal Work/
  +
  +PerfReviewItemType perfRatingTypeId=TECH hasTable=N 
  description=Technical skills/
  +PerfReviewItemType perfRatingTypeId=RESP hasTable=N 
  description=Responsibility/
  +PerfReviewItemType perfRatingTypeId=ATT hasTable=N 
  description=Attitude/
  +PerfReviewItemType perfRatingTypeId=COMM hasTable=N 
  description=Communication skills/
  +PerfReviewItemType perfRatingTypeId=JOBSAT hasTable=N 
  description=Job Satisfaction/
  +
  +PerfRatingType perfRatingTypeId=1 hasTable=N description=Fails 
  to Meet Expectations/
  +PerfRatingType perfRatingTypeId=2 hasTable=N 
  description=Inconsistently Fulfills/
  +PerfRatingType perfRatingTypeId=3 hasTable=N 
  description=Fulfilled Expectations/
  +PerfRatingType perfRatingTypeId=4 hasTable=N 
  description=Frequently Exceeds/
  +PerfRatingType perfRatingTypeId=5 hasTable=N 
  description=Consistently Exceeds/
  
  /entity-engine-xml
  
  Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891r1=1058890r2=1058891view=diff
  ==
  --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original)
  +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 
  08:40:01 2011
  @@ -164,15 +164,13 @@ under the License.
  entity entity-name=PerfReviewItem
  package-name=org.ofbiz.humanres.ability
  title=Performance Review Item Entity
  -  field name=employeePartyId type=id-ne/field
  -  field name=employeeRoleTypeId type=id/field
field name=perfReviewId type=id-ne/field
field name=perfReviewItemSeqId type=id-ne/field
field name=perfRatingTypeId type=id/field
field name=perfReviewItemTypeId type=id/field
  +  field name=employeePartyId type=id-ne/field
  +  field name=employeeRoleTypeId

[jira] Updated: (OFBIZ-4014) i18n from DateTime display fields

2011-01-14 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4014:
---

Attachment: OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch

Patch update against the latest trunk.



 i18n from DateTime display fields 
 --

 Key: OFBIZ-4014
 URL: https://issues.apache.org/jira/browse/OFBIZ-4014
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: OFBIZ-4014_dateJs.zip, OFBIZ-4014_i18nTimepicker.patch, 
 OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch, 
 OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch


 Hi everybody,
 i did a little improvement in the display form fields from type date and 
 date-time. 
 In the past the timestamps where read from the DB and the string was simply 
 cut, that didn't match with (i.e.) German date pattern. I changed this 
 substring stuff and used the locale and timezone with the dateFormatter to 
 create a i18n date string.
 This patch works for: display type=date / and display type=date-time /
 Hope that helps.
 Have a nice day
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4014) i18n from DateTime display fields

2011-01-14 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981743#action_12981743
 ] 

Sascha Rodekamp commented on OFBIZ-4014:


Hm i think the only missing thing are date fields in FTL files.

Maybe we create a simple java method which can be called within FTL to format 
the Date  / Time field?!

 i18n from DateTime display fields 
 --

 Key: OFBIZ-4014
 URL: https://issues.apache.org/jira/browse/OFBIZ-4014
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Sascha Rodekamp
 Fix For: SVN trunk

 Attachments: OFBIZ-4014_dateJs.zip, OFBIZ-4014_i18nTimepicker.patch, 
 OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch, 
 OFBIZ-4014_ModelFormField_DateTimeField_i18n.patch


 Hi everybody,
 i did a little improvement in the display form fields from type date and 
 date-time. 
 In the past the timestamps where read from the DB and the string was simply 
 cut, that didn't match with (i.e.) German date pattern. I changed this 
 substring stuff and used the locale and timezone with the dateFormatter to 
 create a i18n date string.
 This patch works for: display type=date / and display type=date-time /
 Hope that helps.
 Have a nice day
 Sascha

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid

Hans,

I think that you are not interpreting correctly this part of the data model, 
please have a deeper look at it before going on with these modifications.
Also, with reference to the Data Model Resource Book (even if we do not have to 
strictly follow what it is described there), I can't see your point because the 
book defines the entities exactly as they are in OFBiz: see the diagram at page 
330 (and the fields and pk of the PerformanceReviewItem entity at page 480).

Kind regards,

Jacopo

On Jan 14, 2011, at 10:15 AM, Hans Bakker wrote:

 Ok i did not see the unusual index of the PerfRreview too:  which
 includes the employeeId and role. This is also not according the
 dataresource book. I would even suggest to take the employeeparty and
 role out of this key too and follow the general pattern that the
 perfReview entity has a single key field perfReviewId.
 
 Thanks for commenting on this.
 
 Regards,
 Hans
 
 On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote:
 Hi Hans,
 
 could you please better explain what was the error and why you have decided 
 to modify the PerfReviewItem entity?
 I am asking you this because, even if I don't know much about this area of 
 the data model, from what I understand:
 - PerfReview is used to define an employee performance review; this is why 
 we have a primary key composed by the employee party id, its role and an 
 index (for the specific review)
 - PerfReviewItem is used to provide details about a specific review (defined 
 above); this is why we had a primary key composed by the primary key of the 
 PerfReview entity and an additional subindex (perfReviewItemSeqId)
 
 I don't doubt that the existing services were not working, but I am 
 wondering if there was another way to fix them instead of altering the 
 primary key of the PerfReviewItem entity.
 
 Kind regards,
 
 Jacopo
 
 On Jan 14, 2011, at 9:40 AM, hans...@apache.org wrote:
 
 Author: hansbak
 Date: Fri Jan 14 08:40:01 2011
 New Revision: 1058891
 
 URL: http://svn.apache.org/viewvc?rev=1058891view=rev
 Log:
 made the employee review item work, corrected a completely wrong entity 
 definition prefreviewitem, services now work again and added new type data. 
 Added buttons to be able to select reveiw and item list NOTE: This change 
 needs recreating of the PerfReviewItem index, the fields and format did not 
 change, just the indexing
 
 Modified:
   ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
   ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
   ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
   ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml
   ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml
   ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml
 
 Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891r1=1058890r2=1058891view=diff
 ==
 --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
 +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 14 
 08:40:01 2011
 @@ -153,5 +153,17 @@ under the License.
 
EmplLeaveReasonType description=Medical hasTable=N parentTypeId= 
 emplLeaveReasonTypeId=Fever/
EmplLeaveReasonType description=Casual hasTable=N parentTypeId= 
 emplLeaveReasonTypeId=Personal Work/
 +
 +PerfReviewItemType perfRatingTypeId=TECH hasTable=N 
 description=Technical skills/
 +PerfReviewItemType perfRatingTypeId=RESP hasTable=N 
 description=Responsibility/
 +PerfReviewItemType perfRatingTypeId=ATT hasTable=N 
 description=Attitude/
 +PerfReviewItemType perfRatingTypeId=COMM hasTable=N 
 description=Communication skills/
 +PerfReviewItemType perfRatingTypeId=JOBSAT hasTable=N 
 description=Job Satisfaction/
 +
 +PerfRatingType perfRatingTypeId=1 hasTable=N description=Fails 
 to Meet Expectations/
 +PerfRatingType perfRatingTypeId=2 hasTable=N 
 description=Inconsistently Fulfills/
 +PerfRatingType perfRatingTypeId=3 hasTable=N 
 description=Fulfilled Expectations/
 +PerfRatingType perfRatingTypeId=4 hasTable=N 
 description=Frequently Exceeds/
 +PerfRatingType perfRatingTypeId=5 hasTable=N 
 description=Consistently Exceeds/
 
 /entity-engine-xml
 
 Modified: ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml?rev=1058891r1=1058890r2=1058891view=diff
 ==
 --- ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml (original)
 +++ ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml Fri Jan 14 
 08:40:01 2011
 @@ -164,15 +164,13 @@ under the License.
entity entity-name=PerfReviewItem

[VOTE] [RELEASE] Apache OFBiz 10.04

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

[jira] Commented: (OFBIZ-3843) Localized date format for end user

2011-01-14 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981749#action_12981749
 ] 

Sascha Rodekamp commented on OFBIZ-3843:


Hey Nicolas could you please have a look at OFBIZ-4014 ? I update my patch.

 Localized date format for end user
 --

 Key: OFBIZ-3843
 URL: https://issues.apache.org/jira/browse/OFBIZ-3843
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Nicolas Malin
Priority: Minor
 Attachments: OFBIZ-3843.patch, OFBIZ-3843.patch, With the patch.jpg, 
 Without patch (in trunk demo).jpg, Wrong From Date.jpg


 Many French end users don't want to use this date format : -mm-dd.
 To make a better user friendly OFBiz interface, I've added the possibility to 
 configure in general.properties a localized date format. OFBiz use localized 
 format (as dd/mm/) for all interactions with users but keep universal 
 format for its framework. It's then possible to set date with unniversal or 
 localized format.
 What's working : 
   * Dates in screen engine : display, date-find, date-time
   * performFind
   * Service call
 Know problem : 
   * I don't find how to configure js calendar to support this functionality
 It's possible that my solution isn't the best one to do that. But I'm open to 
 all comment 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

R: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread mrisal...@libero.it

+1 

Marco

Messaggio originale
Da: jacopo.cappell...@hotwaxmedia.com
Data: 14/01/2011 14.04
A: dev@ofbiz.apache.org
Ogg: [VOTE] [RELEASE] Apache OFBiz 10.04

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this http://www.apache.
org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Anil Patel

+1

Thanks and Regards
Anil Patel
HotWax Media Inc
Find us on the web at www.hotwaxmedia.com or Google Keyword ofbiz

On Jan 14, 2011, at 6:34 PM, Jacopo Cappellato wrote:

 This is the vote thread to transform our release candidate 10.04 into an 
 official release. This will be the first release of the 10.04 series (that 
 contains the features up to 2010-04).
 
 The files can be downloaded from here:
 
 http://people.apache.org/~jacopoc/dist/
 
 Vote:
 
 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release
 
 For more details about this process please read this 
 http://www.apache.org/foundation/voting.html
 
 Kind Regards,
 
 Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04


+1

Jacques

From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
This is the vote thread to transform our release candidate 10.04 into an official release. This will be the first release of the 
10.04 series (that contains the features up to 2010-04).


The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Erwan de FERRIERES


Le 14/01/2011 14:04, Jacopo Cappellato a écrit :

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo



+1

--
Erwan de FERRIERES
www.nereide.biz

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Sascha Rodekamp

+1


-- 
Sascha Rodekamp
Lynx-Consulting GmbH
Johanniskirchplatz 6
D-33615 Bielefeld
http://www.lynx.de

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Adrian Crum

+1

--- On Fri, 1/14/11, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com 
wrote:

 From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
 Subject: [VOTE] [RELEASE] Apache OFBiz 10.04
 To: dev@ofbiz.apache.org
 Date: Friday, January 14, 2011, 5:04 AM
 This is the vote thread to transform
 our release candidate 10.04 into an official release. This
 will be the first release of the 10.04 series (that contains
 the features up to 2010-04).

 The files can be downloaded from here:

 http://people.apache.org/~jacopoc/dist/

 Vote:

 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release

 For more details about this process please read this 
 http://www.apache.org/foundation/voting.html

 Kind Regards,

 Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Bruno Busco

+1

2011/1/14 Adrian Crum adrian.c...@yahoo.com

 +1

 --- On Fri, 1/14/11, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
 wrote:

  From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
  Subject: [VOTE] [RELEASE] Apache OFBiz 10.04
  To: dev@ofbiz.apache.org
  Date: Friday, January 14, 2011, 5:04 AM
  This is the vote thread to transform
  our release candidate 10.04 into an official release. This
  will be the first release of the 10.04 series (that contains
  the features up to 2010-04).
 
  The files can be downloaded from here:
 
  http://people.apache.org/~jacopoc/dist/http://people.apache.org/%7Ejacopoc/dist/
 
  Vote:
 
  [ +1] release as Apache OFBiz 10.04
  [ -1] do not release
 
  For more details about this process please read this
 http://www.apache.org/foundation/voting.html
 
  Kind Regards,
 
  Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Mirko Vogelsmeier

+1



Mirko Vogelsmeier
Auszubildender Fachinformatiker AEW
Lynx-Consulting GmbH
Johanniskirchplatz 6
33615 Bielefeld
Deutschland
Fon: +49 521 5247-0
Fax: +49 521 5247-250
Mobil: 


Company and Management Headquarters:
Lynx-Consulting GmbH, Johanniskirchplatz 6, 33615 Bielefeld, Deutschland
Fon: +49 521 5247-0, Fax: +49 521 5247-250, www.lynx.de

Court Registration: Amtsgericht Bielefeld HRB 35946
Chief Executive Officers: Karsten Noss, Dirk Osterkamp


This e-mail may contain trade secrets or privileged, undisclosed, or otherwise 
confidential information. If you have received this e-mail in error, you are 
hereby notified that any review, copying, or distribution of it is strictly 
prohibited. Please inform us immediately and destroy the original transmittal. 
Thank you for your cooperation. 





From:   Bruno Busco bruno.bu...@gmail.com
To: dev@ofbiz.apache.org
Date:   14.01.2011 15:29
Subject:Re: [VOTE] [RELEASE] Apache OFBiz 10.04



+1

2011/1/14 Adrian Crum adrian.c...@yahoo.com

 +1

 --- On Fri, 1/14/11, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com
 wrote:

  From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
  Subject: [VOTE] [RELEASE] Apache OFBiz 10.04
  To: dev@ofbiz.apache.org
  Date: Friday, January 14, 2011, 5:04 AM
  This is the vote thread to transform
  our release candidate 10.04 into an official release. This
  will be the first release of the 10.04 series (that contains
  the features up to 2010-04).
 
  The files can be downloaded from here:
 
  http://people.apache.org/~jacopoc/dist/
http://people.apache.org/%7Ejacopoc/dist/
 
  Vote:
 
  [ +1] release as Apache OFBiz 10.04
  [ -1] do not release
 
  For more details about this process please read this
 http://www.apache.org/foundation/voting.html
 
  Kind Regards,
 
  Jacopo
 
 







*

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Young Gu


+1

Please be free to contact with me for any question or suggestion.

Thanks  Best Regards,

Young Gu | Software Engineer | www.infor.com


On 01/14/2011 09:04 PM, Jacopo Cappellato wrote:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

[jira] Commented: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-14 Thread Adrian Crum (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981788#action_12981788
 ] 

Adrian Crum commented on OFBIZ-4092:


Ryan,

Is there any chance you could upload what you have so far?


 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, 
 ac_images.zip, accounting800x600.png, brushed-aluminum.gif, 
 catalog800x600.png, catalogManager.png, content800x600.png, 
 contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, 
 partyManager.png, screenshot.gif, timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: JIRA plugin framework

2011-01-14 Thread Michael Xu (xudong)

hi BJ,

I think you don't understand what I mean. Maybe you can take a look at JIRA
plugin framework.

--
Regards,
Michael Xu (xudong)


On Fri, Jan 14, 2011 at 12:34 PM, BJ Freeman bjf...@free-man.net wrote:

 sounds like you extending the entity engine so the data can be on the
 Cloud.
 Though I would not use it, I can see where some my want to do that.
 if the cloud can run ofbiz (java SDK) then sounds like that is all you
 need.

 =
 BJ Freeman
 Strategic Power Office with Supplier Automation  
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com  http://www.specialtymarket.com/
 Systems Integrator-- Glad to Assist

 Chat  Y! messenger: bjfr33man


 Michael Xu (xudong) sent the following on 1/13/2011 8:05 PM:

  hi all,

 There is a very wonderful feature in JIRA - plugin mechanism based on
 OSGI,
 with which ofbiz application could be extended in a very dynamic way. No
 need to restart.

 It means a lot not from technical perspective but also from business
 perspective. If we can borrow the idea from JIRA, then we can bring ofbiz
 up
 to cloud and have an partner ecosystem around it. Taking CRM component as
 an
 example, if we have the JIRA plugin mechanism, we can turn it into another
 salesforce.

 It seems JIRA plugin is also open source Not sure whether we can merge it
 into ofbiz.

 --
 Regards,
 Michael Xu (xudong)

docbook restructure


we have two focuses on the Docbook usages
1)whole document for user and technical
2)help screens for individual screens.

our current structure is each component has a documents folder then 
data/datahelp folder.


suggest that the documents folder file be a book, one for user and one 
for technical, for that component.

the top file,for user and technical, in data/datahelp/ would be Chapter.
For the user manual, each help screen be a file that is one or more 
sections with id to match entity field names.


This would allow a book be generated per component for both User and 
technical.
for #1 they top book for say user docs would point to the top level file 
in data/datahelp/ so each component would be chapter.


#2 the book gets complied for that component help files as defined in 
the documents folder. the anchors will used to access the section that 
deals with the screen. This also lets us expand the help to field level 
by adding an anchor for entities field names.


I will be glad to do this on my demo to show response times if any one 
is interested.


if no input will refactor the content component and current help system 
to use this.



=

BJ Freeman
Strategic Power Office with Supplier Automation  
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com  http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Bilgin Ibryam

+ 1

Bilgin

On Fri, Jan 14, 2011 at 1:04 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 This is the vote thread to transform our release candidate 10.04 into an
 official release. This will be the first release of the 10.04 series (that
 contains the features up to 2010-04).

 The files can be downloaded from here:

 http://people.apache.org/~jacopoc/dist/http://people.apache.org/%7Ejacopoc/dist/

 Vote:

 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release

 For more details about this process please read this
 http://www.apache.org/foundation/voting.html

 Kind Regards,

 Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04


from the commits there are still bugs being updated.
I would say once the level of bug updated drops to zero would be a time 
to release.

-1

=
BJ Freeman
Strategic Power Office with Supplier Automation  
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com  http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread David E Jones


+1

-David


On Jan 14, 2011, at 5:04 AM, Jacopo Cappellato wrote:

 This is the vote thread to transform our release candidate 10.04 into an 
 official release. This will be the first release of the 10.04 series (that 
 contains the features up to 2010-04).
 
 The files can be downloaded from here:
 
 http://people.apache.org/~jacopoc/dist/
 
 Vote:
 
 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release
 
 For more details about this process please read this 
 http://www.apache.org/foundation/voting.html
 
 Kind Regards,
 
 Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Adrian Crum


BJ,

That's not how the release plan works. Bug fixes can be applied to the 
release, and then a new (minor) version can be released.


-Adrian

On 1/14/2011 9:54 AM, BJ Freeman wrote:

from the commits there are still bugs being updated.
I would say once the level of bug updated drops to zero would be a time
to release.
-1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:

This is the vote thread to transform our release candidate 10.04 into
an official release. This will be the first release of the 10.04
series (that contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04


I agree with your perspective, however note that there is not a 9.04.1

=
BJ Freeman
Strategic Power Office with Supplier Automation  
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com  http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Adrian Crum sent the following on 1/14/2011 10:14 AM:

BJ,

That's not how the release plan works. Bug fixes can be applied to the
release, and then a new (minor) version can be released.

-Adrian

On 1/14/2011 9:54 AM, BJ Freeman wrote:

from the commits there are still bugs being updated.
I would say once the level of bug updated drops to zero would be a time
to release.
-1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:

This is the vote thread to transform our release candidate 10.04 into
an official release. This will be the first release of the 10.04
series (that contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04


The policy has changed since

Jacques

From: BJ Freeman bjf...@free-man.net

I agree with your perspective, however note that there is not a 9.04.1

=
BJ Freeman
Strategic Power Office with Supplier Automation  
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com  http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Adrian Crum sent the following on 1/14/2011 10:14 AM:

BJ,

That's not how the release plan works. Bug fixes can be applied to the
release, and then a new (minor) version can be released.

-Adrian

On 1/14/2011 9:54 AM, BJ Freeman wrote:

from the commits there are still bugs being updated.
I would say once the level of bug updated drops to zero would be a time
to release.
-1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:

This is the vote thread to transform our release candidate 10.04 into
an official release. This will be the first release of the 10.04
series (that contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04



I was going on
https://cwiki.apache.org/OFBADMIN/release-plan.html
# Once a release branch stabilizes an initial stable release tag and 
pre-built package will be issued

to me stable means no bugs being found.

=
BJ Freeman
Strategic Power Office with Supplier Automation  
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com  http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Jacques Le Roux sent the following on 1/14/2011 11:20 AM:

The policy has changed since

Jacques

From: BJ Freeman bjf...@free-man.net

I agree with your perspective, however note that there is not a 9.04.1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Adrian Crum sent the following on 1/14/2011 10:14 AM:

BJ,

That's not how the release plan works. Bug fixes can be applied to the
release, and then a new (minor) version can be released.

-Adrian

On 1/14/2011 9:54 AM, BJ Freeman wrote:

from the commits there are still bugs being updated.
I would say once the level of bug updated drops to zero would be a time
to release.
-1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:

This is the vote thread to transform our release candidate 10.04 into
an official release. This will be the first release of the 10.04
series (that contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Bug fix releases Re: [VOTE] [RELEASE] Apache OFBiz 10.04

Please change subject in order to keep the voting thread clean.
In my opinion we should also release a new version of the 09.04 branch, i.e. 
Apache OFBiz 09.04.01: it will be a big fix release. In fact I was going to 
propose a vote for it after the release process for 10.04 will be complete.

Kind regards,

Jacopo


On Jan 14, 2011, at 8:31 PM, BJ Freeman wrote:

 
 I was going on
 https://cwiki.apache.org/OFBADMIN/release-plan.html
 # Once a release branch stabilizes an initial stable release tag and 
 pre-built package will be issued
 to me stable means no bugs being found.
 
 =
 BJ Freeman
 Strategic Power Office with Supplier Automation  
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com  http://www.specialtymarket.com/
 Systems Integrator-- Glad to Assist
 
 Chat  Y! messenger: bjfr33man
 
 
 Jacques Le Roux sent the following on 1/14/2011 11:20 AM:
 The policy has changed since
 
 Jacques
 
 From: BJ Freeman bjf...@free-man.net
 I agree with your perspective, however note that there is not a 9.04.1
 
 =
 BJ Freeman
 Strategic Power Office with Supplier Automation
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com http://www.specialtymarket.com/
 Systems Integrator-- Glad to Assist
 
 Chat Y! messenger: bjfr33man
 
 
 Adrian Crum sent the following on 1/14/2011 10:14 AM:
 BJ,
 
 That's not how the release plan works. Bug fixes can be applied to the
 release, and then a new (minor) version can be released.
 
 -Adrian
 
 On 1/14/2011 9:54 AM, BJ Freeman wrote:
 from the commits there are still bugs being updated.
 I would say once the level of bug updated drops to zero would be a time
 to release.
 -1
 
 =
 BJ Freeman
 Strategic Power Office with Supplier Automation
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com http://www.specialtymarket.com/
 Systems Integrator-- Glad to Assist
 
 Chat Y! messenger: bjfr33man
 
 
 Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:
 This is the vote thread to transform our release candidate 10.04 into
 an official release. This will be the first release of the 10.04
 series (that contains the features up to 2010-04).
 
 The files can be downloaded from here:
 
 http://people.apache.org/~jacopoc/dist/
 
 Vote:
 
 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release
 
 For more details about this process please read this
 http://www.apache.org/foundation/voting.html
 
 Kind Regards,
 
 Jacopo

Re: svn commit: r1059180 - in /ofbiz/trunk: applications/order/script/org/ofbiz/order/order/ applications/order/servicedef/ specialpurpose/ecommerce/webapp/ecommerce/order/


Hi Scott,

I see now that you introduced the fullPath=true stuff at http://svn.apache.org/viewvc?rev=935146view=rev. Is it really needed 
there?


Thanks

Jacques

From: jler...@apache.org

Author: jleroux
Date: Fri Jan 14 21:47:23 2011
New Revision: 1059180

URL: http://svn.apache.org/viewvc?rev=1059180view=rev
Log:
A modified patch from Sascha based on an intial patch from Abdullah Shaikh permission error on cancel order item from ecommerce 
(https://issues.apache.org/jira/browse/OFBIZ-3075) - OFBIZ-3075


If I cancel an order item from ecommerce. I get, the below error displayed on 
the page.
The Following Errors Occurred:
Unable to cancel order line : WSCO11640 / 1 / null

There have been a discussion about it in this thread 
http://markmail.org/message/dfkudyvbksvls333

How it works: you can cancel an order item if you create it or have the ORDERMGR_CREATE or ORDERMGR_UPDATE permissions (I added 
the later to Sascha's patch, else the order manager would be annoyed ;o)

I think this makes sense, because AFAIK there are no other UIs than
https://demo-trunk.ofbiz.apache.org/ordermgr/control/editOrderItems?orderId=...
and
https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/orderstatus?orderId=...
to cancel an order item. So nobody should be able to bypass his/her permissions... Of course, let me know if you think I could 
have missed something, thanks


Note also that we had to remove fullPath=true in @ofbizUrlcancelOrderItem/@ofbizUrl (orderitems.ftl), to avoid 
InsecureFormPostToSecureRequest error. I don't think it raises any security issues though, has it's done from a javascript call 
with hidden orderItemSeqId parameter.


Modified:
   ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml
   
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml
   ofbiz/trunk/applications/order/servicedef/services.xml
   ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/order/orderitems.ftl

Modified: 
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml?rev=1059180r1=1059179r2=1059180view=diff

==
--- 
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml 
(original)
+++ 
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderServices.xml 
Fri Jan 14 21:47:23 2011
@@ -599,10 +599,6 @@ under the License.
/simple-method

simple-method method-name=recreateOrderAdjustments short-description=Auto 
create OrderAdjustments
-check-permission permission=ORDERMGR action=_UPDATE
-fail-property resource=OrderErrorUiLabels 
property=OrderSecurityErrorToRunAutoCreateOrderAdjustments/
-/check-permission
-check-errors/
entity-one entity-name=OrderHeader value-field=order 
auto-field-map=true/
!-- all existing promo order items are cancelled --
get-related value-field=order relation-name=OrderItem 
list=orderItems/

Modified: 
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml?rev=1059180r1=1059179r2=1059180view=diff

==
--- 
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml
 (original)
+++ 
ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml
 Fri Jan 14 21:47:23 2011
@@ -20,12 +20,44 @@ under the License.

simple-methods xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;

xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/simple-methods.xsd;
+
+!-- Returns hasPermission=true if userLogin partyId equals partyId 
parameter
+ Only the order owner should be able to cancel an item from Ecommerce
+--
+simple-method method-name=orderAdjustmentPermissionCheck 
short-description=Party contact mech permission logic
+if-empty field=parameters.partyId
+set field=parameters.partyId from-field=userLogin.partyId/
+/if-empty
+if-compare-field to-field=userLogin.partyId field=parameters.partyId 
operator=equals
+set field=hasPermission type=Boolean value=true/
+field-to-result field=hasPermission/
+else
+set field=primaryPermission value=ORDERMGR/
+set field=altPermission value=ORDERMGR_ROLE/
+set field=mainAction from-field=parameters.mainAction/
+call-simple-method method-name=genericBasePermissionCheck 
xml-resource=component://common/script/org/ofbiz/common/permission/CommonPermissionServices.xml/

+if-compare field=hasPermission operator=not-equals 
value=true
+set

[jira] Closed: (OFBIZ-3075) permission error on cancel order item from ecommerce

2011-01-14 Thread Jacques Le Roux (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-3075.
--

   Resolution: Fixed
Fix Version/s: SVN trunk
   Release Branch 10.04
   Release Branch 09.04
 Assignee: Jacques Le Roux

Thanks  Abdullah, Sascha,

I have commited a modified patch at r1059180 in trunk, R10.04 at r1059183, 
R9.04 at r1059185.

See my comments in the commit log. I have a little doubt about the 
fullpath=true stuff, I have asked Scott who put it there...


 permission error on cancel order item from ecommerce
 

 Key: OFBIZ-3075
 URL: https://issues.apache.org/jira/browse/OFBIZ-3075
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: Release Branch 4.0, Release Branch 09.04, SVN trunk
Reporter: Abdullah Shaikh
Assignee: Jacques Le Roux
 Fix For: Release Branch 09.04, Release Branch 10.04, SVN trunk

 Attachments: OFBIZ-3075_permission error on cancel order.patch, 
 OFBIZ-3075_permission error on cancel order.patch


 If I cancel an order item from ecommerce. I get, the below error displayed on 
 the page.
 The Following Errors Occurred:
 Unable to cancel order line : WSCO11640 / 1 / null
 Below is the error trace from console, this error is because the party 
 (customer) doesn't have the ORDERMGR_CREATE or ORDERMGR_ADMIN permission, but 
 we can't be this permission to a customer, as the common service is called 
 from ecommerce and order manager for cancel, the solution will be to check 
 the party's role, if its a CUSTOMER, then I guess we can use the SYSTEM user, 
 we need to give ORDERMGR permission to the SYSTEM user.
 But then it will seem as if the SYSTEM user has cancelled the order and not 
 the CUSTOMER.
 The exception on the console is below :
  [java]  exception report 
 --
  [java] [TransactionUtil.setRollbackOnly] Calling transaction 
 setRollbackOnly; this stack trace shows where this is happening:
  [java] Exception: java.lang.Exception
  [java] Message: Error in simple-method [Create an OrderAdjustment 
 [file:/home/abdullah/projects/ofbiz_ws/ofbiz/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml#createOrderAdjustment]]:
  ; [Security Error : to run createOrderAdjustment you must have the 
 ORDERMGR_CREATE or ORDERMGR_ADMIN permission]
  [java]  stack trace 
 ---
  [java] java.lang.Exception: Error in simple-method [Create an 
 OrderAdjustment 
 [file:/home/abdullah/projects/ofbiz-sagepay_ws/ofbiz/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml#createOrderAdjustment]]:
  ; [Security Error : to run createOrderAdjustment you must have the 
 ORDERMGR_CREATE or ORDERMGR_ADMIN permission]
  [java] 
 org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:371)
  [java] 
 org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:318)
  [java] org.ofbiz.minilang.SimpleMethod.exec(SimpleMethod.java:833)
  [java] 
 org.ofbiz.minilang.SimpleMethod.runSimpleMethod(SimpleMethod.java:160)
  [java] 
 org.ofbiz.minilang.SimpleMethod.runSimpleService(SimpleMethod.java:142)
  [java] 
 org.ofbiz.minilang.SimpleServiceEngine.serviceInvoker(SimpleServiceEngine.java:78)
  [java] 
 org.ofbiz.minilang.SimpleServiceEngine.runSync(SimpleServiceEngine.java:53)
  [java] 
 org.ofbiz.service.ModelServiceReader$GenericInvokerImpl.runSync(ModelServiceReader.java:785)
  [java] 
 _$gen.file_58$.home.abdullah.projects.ofbiz_45$sagepay_95$ws.ofbiz.applications.order.servicedef.services_46$xml_35$createOrderAdjustment.runSync(file:/home/abdullah/projects/ofbiz-sagepay_ws/ofbiz/applications/order/servicedef/services.xml#createOrderAdjustment:184)
  [java] 
 org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:394)
  [java] 
 org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:223)
  [java] 
 org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:159)
  [java] 
 org.ofbiz.order.order.OrderServices.recalcOrderTax(OrderServices.java:1600)
  [java] sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  [java] 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  [java] 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  [java] java.lang.reflect.Method.invoke(Method.java:597)
  [java] 
 org.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:100)
  [java]

Re: svn commit: r1059185 - in /ofbiz/branches/release09.04: ./ applications/order/script/org/ofbiz/order/order/OrderServices.xml applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml


I mixed 2 commit comments.

In this should read
Note also that we had not to remove fullPath=true in @ofbizUrlcancelOrderItem/@ofbizUrl (orderitems.ftl), to avoid 
InsecureFormPostToSecureRequest error. It was not there in R9.04 (has been introduced by Scott at 
http://svn.apache.org/viewvc?rev=935146view=rev)


Jacques


Author: jleroux
Date: Fri Jan 14 22:11:07 2011
New Revision: 1059185

URL: http://svn.apache.org/viewvc?rev=1059185view=rev
Log:
Applied fix from trunk for revision: 1059180

r1059180 | jleroux | 2011-01-14 22:47:23 +0100 (ven., 14 janv. 2011) | 16 lines

A modified patch from Sascha based on an intial patch from Abdullah Shaikh permission error on cancel order item from ecommerce 
(https://issues.apache.org/jira/browse/OFBIZ-3075) - OFBIZ-3075


If I cancel an order item from ecommerce. I get, the below error displayed on 
the page.
The Following Errors Occurred:
Unable to cancel order line : WSCO11640 / 1 / null

There have been a discussion about it in this thread 
http://markmail.org/message/dfkudyvbksvls333

How it works: you can cancel an order item if you create it or have the ORDERMGR_CREATE or ORDERMGR_UPDATE permissions (I added 
the later to Sascha's patch, else the order manager would be annoyed ;o)

I think this makes sense, because AFAIK there are no other UIs than
https://demo-trunk.ofbiz.apache.org/ordermgr/control/editOrderItems?orderId=...
and
https://demo-trunk.ofbiz.apache.org:8443/ecommerce/control/orderstatus?orderId=...
to cancel an order item. So nobody should be able to bypass his/her permissions... Of course, let me know if you think I could 
have missed something, thanks


Note also that we had to remove fullPath=true in @ofbizUrlcancelOrderItem/@ofbizUrl (orderitems.ftl), to avoid 
InsecureFormPostToSecureRequest error. I don't think it raises any security issues though, has it's done from a javascript call 
with hidden orderItemSeqId parameter.




Modified:
   ofbiz/branches/release09.04/   (props changed)
   
ofbiz/branches/release09.04/applications/order/script/org/ofbiz/order/order/OrderServices.xml
   
ofbiz/branches/release09.04/applications/order/script/org/ofbiz/order/order/OrderSimpleMethods.xml
   ofbiz/branches/release09.04/applications/order/servicedef/services.xml

Propchange: ofbiz/branches/release09.04/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Fri Jan 14 22:11:07 2011
@@ -1 +1 @@
-/ofbiz/trunk:765933,766011,766015,766293,766307,766316,766325,766462,766522,766800,767060,767072,767093,767098-767099,767102,767123,767125,767127,767279,767287,767671,767688,767694,767822,767845,768358,768490,768550,768675,768686,768705,768811,768815,768960,769030,769500,770272,770308,770997,771073,771477,772401,772464-772465,773076,773557,773628,773659,773697,774014,774632,774661,774995,775292,775667,776227,776594,776620,776922,777004,777020,68,92,777893,777947,778078,778094,778107,778273,778278,778280,778364,778374,778402,778576,778594,778628,779020,779477,779496,779639,779834,779856,779866,779873,780111,780138,780180,780199,780203,780906,780945,781201,781534,781549,781669,781680,781694,782663,783257,783266,783833,783913,783917,785123,785764,785967,786778,787126,787435-787436,787442,787520,788965,788983,788987,789329,789337,789506,789548,796769,799185,800461,800846,801023,802346,804364,805307,806127,806377,806914,808786-808787,808792,809141,810370,810438,810465,8

10

807,810809,810814,810832,810836,810878,810917,811020,811280,811297,811419,811528,811708,811714,811716,811793,811838,811860,811865,811870,812159,812182,812192,812456,812540,812724,813126,813131,813283,813672,813702,814168,814205,814251,814349,814531,814576,814681,814731,815158,815165,815350,815687,815977,816255,816863,818030,818049,818150,818494,818500,818716,818976,819275-819276,819282,819337,821263,821270,822659,823877-823878,823883,823888,823892,824511,825181-825182,826253,827730,828971,829085,829376,829412,829416,829527,830091,830112,830366,830528,830677,830874,830880,831238,831801,832361,832698,832776,832880,832908,833324,833686,833703,834825,835161,835357,835585,836015,881194,881713,882072,882326,882918,883933,884023,884529,884546,884758,885122,885702,887916,888111,888559,888587,889666,890050,890107,890245,891378,891620,896649,899188,899833,900024,900026,900050,900217,900273,901628,907342-907343,910460,912587,915332,916252,916703,916925,917435,922042,923828,927870,9280

3

Re: Bug fix releases Re: [VOTE] [RELEASE] Apache OFBiz 10.04


the reason for my -1 to me is not off topic.
however nice to hear we will have .01 on 9.04.

=
BJ Freeman
Strategic Power Office with Supplier Automation  
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.com  http://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man
Jacopo Cappellato sent the following on 1/14/2011 12:35 PM:

Please change subject in order to keep the voting thread clean.
In my opinion we should also release a new version of the 09.04 branch, i.e. Apache OFBiz 
09.04.01: it will be a big fix release. In fact I was going to propose a vote 
for it after the release process for 10.04 will be complete.

Kind regards,

Jacopo


On Jan 14, 2011, at 8:31 PM, BJ Freeman wrote:



I was going on
https://cwiki.apache.org/OFBADMIN/release-plan.html
# Once a release branch stabilizes an initial stable release tag and 
pre-built package will be issued
to me stable means no bugs being found.

=
BJ Freeman
Strategic Power Office with Supplier 
Automationhttp://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.comhttp://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Jacques Le Roux sent the following on 1/14/2011 11:20 AM:

The policy has changed since

Jacques

From: BJ Freemanbjf...@free-man.net

I agree with your perspective, however note that there is not a 9.04.1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.comhttp://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Adrian Crum sent the following on 1/14/2011 10:14 AM:

BJ,

That's not how the release plan works. Bug fixes can be applied to the
release, and then a new (minor) version can be released.

-Adrian

On 1/14/2011 9:54 AM, BJ Freeman wrote:

from the commits there are still bugs being updated.
I would say once the level of bug updated drops to zero would be a time
to release.
-1

=
BJ Freeman
Strategic Power Office with Supplier Automation
http://www.businessesnetwork.com/automation/viewforum.php?f=52
Specialtymarket.comhttp://www.specialtymarket.com/
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man


Jacopo Cappellato sent the following on 1/14/2011 5:04 AM:

This is the vote thread to transform our release candidate 10.04 into
an official release. This will be the first release of the 10.04
series (that contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-14 Thread Ryan Foster (JIRA)

[
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ryan Foster updated OFBIZ-4092:
---

Attachment: rf_flatgrey.patch

Incorporated Adrian's styling and bug fixes from latest patch, dialed back
styling from my latest patch.

Adrian,
I see where you were going with the whole resizing header idea, but IMHO, I
just don't think it looks good. Having a scrollbar in the masthead just feels
really weird to me. My latest patch leaves that piece out.

Also updated app-navigation background image with a new darker, textured image.
Not as bold as your brushed aluminum, but not quite as light as the image I
had there before. Take a look and let me know what you think. This is my last
patch for this effort. Feel free to make any other mods that you think might
be necessary, but I am pretty comfortable rolling with this as-is.

Update The Flat Grey Visual Theme
-

Key: OFBIZ-4092
URL: https://issues.apache.org/jira/browse/OFBIZ-4092
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip,
ac_images.zip, accounting800x600.png, brushed-aluminum.gif,
catalog800x600.png, catalogManager.png, content800x600.png,
contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch,
flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png,
partyManager.png, rf_flatgrey.patch, screenshot.gif, timeSheet.png

Update the Flat Grey visual theme. Design objectives:
1. Floating, flexible layout - screen can be resized.
2. Sight impaired accessible - users can change font size in their browser.
3. Supports RTL layout.
4. Does not require JavaScript. JavaScript can be used to add embellishments,
but the theme can't depend on it.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-4092) Update The Flat Grey Visual Theme

2011-01-14 Thread Ryan Foster (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Foster updated OFBIZ-4092:
---

Attachment: rf_flatgrey_images.zip

 Update The Flat Grey Visual Theme
 -

 Key: OFBIZ-4092
 URL: https://issues.apache.org/jira/browse/OFBIZ-4092
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: SVN trunk
Reporter: Adrian Crum
Assignee: Adrian Crum
Priority: Minor
 Attachments: ac_flatgrey.patch, ac_flatgrey.patch, ac_images.zip, 
 ac_images.zip, accounting800x600.png, brushed-aluminum.gif, 
 catalog800x600.png, catalogManager.png, content800x600.png, 
 contentManager.png, flatgrey.patch, flatgrey.patch, flatgrey.patch, 
 flatgrey.patch, flatgrey.patch, images.zip, ofbiz_logo.gif, partyDetail.png, 
 partyManager.png, rf_flatgrey.patch, rf_flatgrey_images.zip, screenshot.gif, 
 timeSheet.png


 Update the Flat Grey visual theme. Design objectives:
 1. Floating, flexible layout - screen can be resized.
 2. Sight impaired accessible - users can change font size in their browser.
 3. Supports RTL layout.
 4. Does not require JavaScript. JavaScript can be used to add embellishments, 
 but the theme can't depend on it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (OFBIZ-4117) To reject a new created order, the order status does not change

2011-01-14 Thread Leon (JIRA)

To reject a new created order, the order status does not change
---

 Key: OFBIZ-4117
 URL: https://issues.apache.org/jira/browse/OFBIZ-4117
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: SVN trunk
 Environment: OFBiz trunk
Reporter: Leon
Priority: Minor


Via order manager web application, after I create a order, the order status is 
ORDER_CREATED. If I approve this order, the order status will become 
ORDER_APPROVED just as expected. But if I reject it, the order status is 
still ORDER_CREATED while all the order item status is changed to rejected.

Is it a bug or is there any particular business consideration?

btw, IMHO, if the order is rejected, user who created this order can re-submit 
the order for approval after review the rejected reason and modify the order as 
required. But it seems there's no such create-reject-update-approve workflow in 
current order management application.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid

2011-01-14 Thread Hans Bakker

Hi Jacopo,

I do not have the book here, but just checked the system and there the
perfReviewId is already a unique value, why have employeePartyId and
roleId also in he primary key?

I suggest to change the PerfReviw entity also and take the
employeePartyId and roleId also out of the primary key. 

My further suggestion would be to remove he employeePartyId and roleId
fields from the PerfReviewItem entity because it is duplication of the
header entity PerfReview.

Aft this change this entity follows the same pattern as we have for many
other entities in the system like Invoice, Order, Quote etc

Because this Performance view function was completely unusable anyway i
do not see any need for conversion programs.

Regards,
Hans


On Fri, 2011-01-14 at 14:03 +0100, Jacopo Cappellato wrote:
 Hans,
 
 I think that you are not interpreting correctly this part of the data model, 
 please have a deeper look at it before going on with these modifications.
 Also, with reference to the Data Model Resource Book (even if we do not have 
 to strictly follow what it is described there), I can't see your point 
 because the book defines the entities exactly as they are in OFBiz: see the 
 diagram at page 330 (and the fields and pk of the PerformanceReviewItem 
 entity at page 480).
 
 Kind regards,
 
 Jacopo
 
 On Jan 14, 2011, at 10:15 AM, Hans Bakker wrote:
 
  Ok i did not see the unusual index of the PerfRreview too:  which
  includes the employeeId and role. This is also not according the
  dataresource book. I would even suggest to take the employeeparty and
  role out of this key too and follow the general pattern that the
  perfReview entity has a single key field perfReviewId.
  
  Thanks for commenting on this.
  
  Regards,
  Hans
  
  On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote:
  Hi Hans,
  
  could you please better explain what was the error and why you have 
  decided to modify the PerfReviewItem entity?
  I am asking you this because, even if I don't know much about this area of 
  the data model, from what I understand:
  - PerfReview is used to define an employee performance review; this is why 
  we have a primary key composed by the employee party id, its role and an 
  index (for the specific review)
  - PerfReviewItem is used to provide details about a specific review 
  (defined above); this is why we had a primary key composed by the primary 
  key of the PerfReview entity and an additional subindex 
  (perfReviewItemSeqId)
  
  I don't doubt that the existing services were not working, but I am 
  wondering if there was another way to fix them instead of altering the 
  primary key of the PerfReviewItem entity.
  
  Kind regards,
  
  Jacopo
  
  On Jan 14, 2011, at 9:40 AM, hans...@apache.org wrote:
  
  Author: hansbak
  Date: Fri Jan 14 08:40:01 2011
  New Revision: 1058891
  
  URL: http://svn.apache.org/viewvc?rev=1058891view=rev
  Log:
  made the employee review item work, corrected a completely wrong entity 
  definition prefreviewitem, services now work again and added new type 
  data. Added buttons to be able to select reveiw and item list NOTE: This 
  change needs recreating of the PerfReviewItem index, the fields and 
  format did not change, just the indexing
  
  Modified:
ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
ofbiz/trunk/applications/humanres/widget/CommonScreens.xml
ofbiz/trunk/applications/humanres/widget/HumanresMenus.xml
ofbiz/trunk/applications/humanres/widget/PerfReviewScreens.xml
ofbiz/trunk/applications/humanres/widget/forms/PerfReviewForms.xml
  
  Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
  URL: 
  http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1058891r1=1058890r2=1058891view=diff
  ==
  --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
  +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Jan 
  14 08:40:01 2011
  @@ -153,5 +153,17 @@ under the License.
  
 EmplLeaveReasonType description=Medical hasTable=N 
  parentTypeId= emplLeaveReasonTypeId=Fever/
 EmplLeaveReasonType description=Casual hasTable=N parentTypeId= 
  emplLeaveReasonTypeId=Personal Work/
  +
  +PerfReviewItemType perfRatingTypeId=TECH hasTable=N 
  description=Technical skills/
  +PerfReviewItemType perfRatingTypeId=RESP hasTable=N 
  description=Responsibility/
  +PerfReviewItemType perfRatingTypeId=ATT hasTable=N 
  description=Attitude/
  +PerfReviewItemType perfRatingTypeId=COMM hasTable=N 
  description=Communication skills/
  +PerfReviewItemType perfRatingTypeId=JOBSAT hasTable=N 
  description=Job Satisfaction/
  +
  +PerfRatingType perfRatingTypeId=1 hasTable=N description=Fails 
  to Meet Expectations/
  +PerfRatingType perfRatingTypeId=2

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Sam Hamilton

+1 


On 14 Jan 2011, at 21:04, Jacopo Cappellato wrote:

 This is the vote thread to transform our release candidate 10.04 into an 
 official release. This will be the first release of the 10.04 series (that 
 contains the features up to 2010-04).
 
 The files can be downloaded from here:
 
 http://people.apache.org/~jacopoc/dist/
 
 Vote:
 
 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release
 
 For more details about this process please read this 
 http://www.apache.org/foundation/voting.html
 
 Kind Regards,
 
 Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Deepak Dixit


+1

Thanks  Regards
--
Deepak Dixit



Jacopo Cappellato wrote:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Arun Patidar


+1.

Thanks  Regards

Arun Patidar

Jacopo Cappellato wrote:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Brajesh Patel


+1
--

Thanks and Regards
Brajesh Patel
HotWax Media Inc




Anil Patel wrote:

+1

Thanks and Regards
Anil Patel
HotWax Media Inc
Find us on the web at www.hotwaxmedia.com or Google Keyword ofbiz

On Jan 14, 2011, at 6:34 PM, Jacopo Cappellato wrote:

  

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Ankit Jain


+1

--
Regards
Ankit Jain


On Friday 14 January 2011 06:34 PM, Jacopo Cappellato wrote:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Rishi Solanki

+1.
Recently use the 10.04 for development now issues are minimal.

Rishi Solanki
Manager, Enterprise Software Development
HotWax Media Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxmedia.com


On Sat, Jan 15, 2011 at 10:10 AM, Ankit Jain ankit.j...@hotwaxmedia.comwrote:

 +1

 --
 Regards
 Ankit Jain



 On Friday 14 January 2011 06:34 PM, Jacopo Cappellato wrote:

 This is the vote thread to transform our release candidate 10.04 into an
 official release. This will be the first release of the 10.04 series (that
 contains the features up to 2010-04).

 The files can be downloaded from here:

 http://people.apache.org/~jacopoc/dist/

 Vote:

 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release

 For more details about this process please read this
 http://www.apache.org/foundation/voting.html

 Kind Regards,

 Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Jyotsna Rathore

+1

Regards,

Jyotsna Rathore
HotWax Media Pvt. Ltd.
http://www.hotwaxmedia.com

On Jan 14, 2011, at 6:34 PM, Jacopo Cappellato wrote:

 This is the vote thread to transform our release candidate 10.04 into an 
 official release. This will be the first release of the 10.04 series (that 
 contains the features up to 2010-04).
 
 The files can be downloaded from here:
 
 http://people.apache.org/~jacopoc/dist/
 
 Vote:
 
 [ +1] release as Apache OFBiz 10.04
 [ -1] do not release
 
 For more details about this process please read this 
 http://www.apache.org/foundation/voting.html
 
 Kind Regards,
 
 Jacopo
 



smime.p7s
Description: S/MIME cryptographic signature

Re: [VOTE] [RELEASE] Apache OFBiz 10.04

2011-01-14 Thread Amit Sharma


+1.

Thanks and Regards
Amit Sharma
HotWax Media Pvt. Ltd.
http://www.hotwaxmedia.com

On Friday 14 January 2011 06:34 PM, Jacopo Cappellato wrote:

This is the vote thread to transform our release candidate 10.04 into an 
official release. This will be the first release of the 10.04 series (that 
contains the features up to 2010-04).

The files can be downloaded from here:

http://people.apache.org/~jacopoc/dist/

Vote:

[ +1] release as Apache OFBiz 10.04
[ -1] do not release

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo

Re: svn commit: r1058891 - in /ofbiz/trunk/applications/humanres: data/HumanResTypeData.xml entitydef/entitymodel.xml widget/CommonScreens.xml widget/HumanresMenus.xml widget/PerfReviewScreens.xml wid

Hi Hans,

On Jan 15, 2011, at 3:55 AM, Hans Bakker wrote:

 Hi Jacopo,
 
 I do not have the book here, but just checked the system and there the
 perfReviewId is already a unique value, why have employeePartyId and
 roleId also in he primary key?
 

Because the performance review is done for a party id and the role id: you can 
think of the perfReviewId as a subindex of the employeePartyId/roleId pair.
The fact that the createPerfReview service is setting the perfReviewId field 
using:

sequenced-id sequence-name=PerfReview 
field=newEntity.perfReviewId/

(causing it to be unique in the system) is not a good reason for assuming that 
it should be the primary key; if we don't like it we could for example modify 
the createPerfReview service to set the field using a subindex:

employeePartyId, roleId, perfReviewId 
EMPLOYEE_01, PACKER, 1
EMPLOYEE_01, PACKER, 2
EMPLOYEE_01, PICKER, 3 (or 1)
EMPLOYEE_02, PACKER, 1
EMPLOYEE_02, PACKER, 2
...

 I suggest to change the PerfReviw entity also and take the
 employeePartyId and roleId also out of the primary key. 
 
 My further suggestion would be to remove he employeePartyId and roleId
 fields from the PerfReviewItem entity because it is duplication of the
 header entity PerfReview.
 
 Aft this change this entity follows the same pattern as we have for many
 other entities in the system like Invoice, Order, Quote etc
 

These are different examples of entities that have an associated *Role entity; 
there are many examples in OFBiz of entities that have a compound primary key 
similarly to PerfReview

 Because this Performance view function was completely unusable anyway i
 do not see any need for conversion programs.
 

here is what I propose:

1) we revert the commit (or part of it) in which you altered the pk of the 
PerfReviewItem entity; if possible and easy to do, we can fix the 
screens/services that were not working before your commit
2) in the meantime you will have time to read the book and and others, if 
interested, will comment as well

When the discussion will settle down we will decide if we want to simplify the 
primary key and change this part of the data model that is currently following 
the Data Model Resource Book or not.

Kind regards,

Jacopo


 Regards,
 Hans
 
 
 On Fri, 2011-01-14 at 14:03 +0100, Jacopo Cappellato wrote:
 Hans,
 
 I think that you are not interpreting correctly this part of the data model, 
 please have a deeper look at it before going on with these modifications.
 Also, with reference to the Data Model Resource Book (even if we do not have 
 to strictly follow what it is described there), I can't see your point 
 because the book defines the entities exactly as they are in OFBiz: see the 
 diagram at page 330 (and the fields and pk of the PerformanceReviewItem 
 entity at page 480).
 
 Kind regards,
 
 Jacopo
 
 On Jan 14, 2011, at 10:15 AM, Hans Bakker wrote:
 
 Ok i did not see the unusual index of the PerfRreview too:  which
 includes the employeeId and role. This is also not according the
 dataresource book. I would even suggest to take the employeeparty and
 role out of this key too and follow the general pattern that the
 perfReview entity has a single key field perfReviewId.
 
 Thanks for commenting on this.
 
 Regards,
 Hans
 
 On Fri, 2011-01-14 at 09:59 +0100, Jacopo Cappellato wrote:
 Hi Hans,
 
 could you please better explain what was the error and why you have 
 decided to modify the PerfReviewItem entity?
 I am asking you this because, even if I don't know much about this area of 
 the data model, from what I understand:
 - PerfReview is used to define an employee performance review; this is why 
 we have a primary key composed by the employee party id, its role and an 
 index (for the specific review)
 - PerfReviewItem is used to provide details about a specific review 
 (defined above); this is why we had a primary key composed by the primary 
 key of the PerfReview entity and an additional subindex 
 (perfReviewItemSeqId)
 
 I don't doubt that the existing services were not working, but I am 
 wondering if there was another way to fix them instead of altering the 
 primary key of the PerfReviewItem entity.
 
 Kind regards,
 
 Jacopo
 
 On Jan 14, 2011, at 9:40 AM, hans...@apache.org wrote:
 
 Author: hansbak
 Date: Fri Jan 14 08:40:01 2011
 New Revision: 1058891
 
 URL: http://svn.apache.org/viewvc?rev=1058891view=rev
 Log:
 made the employee review item work, corrected a completely wrong entity 
 definition prefreviewitem, services now work again and added new type 
 data. Added buttons to be able to select reveiw and item list NOTE: This 
 change needs recreating of the PerfReviewItem index, the fields and 
 format did not change, just the indexing
 
 Modified:
  ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
  ofbiz/trunk/applications/humanres/entitydef/entitymodel.xml
  ofbiz/trunk/applications/humanres/widget/CommonScreens.xml

Re: [VOTE] [RELEASE] Apache OFBiz 10.04