Re: [jira] [Updated] (OFBIZ-8718) OFBIZ-7471: Improve all the service level error messages for missing required field for SpecialPurpose/ebay component

[Jacques Le Roux]

I have added a point in 
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices

Jacques


Le 21/09/2017 à 15:15, Jacques Le Roux a écrit :

I have not a strong opinion about this but which other options could be used in 
case of new feature or improvement ?

Jacques


Le 21/09/2017 à 14:52, Deepak Dixit a écrit :

I think while creating ticket fix version should not be set.

http://markmail.org/message/jy3qzmsaoxj56otf
* leave the "Fix Version/s" field empty: this will be used by committers to
specify the future release that will contain the fix





Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Thu, Sep 21, 2017 at 5:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


That's a good point unless you are adding something new then "Upcoming
Release" is fine

Jacques



Le 21/09/2017 à 13:33, Deepak Dixit a écrit :


Hi Anushi,

Please do not set fix version,
While creating issue we can specify Affected version, and while closing
ticket fix version will be set.




Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Thu, Sep 21, 2017 at 4:50 PM, Anushi Gupta (JIRA) 
wrote:

   [ https://issues.apache.org/jira/browse/OFBIZ-8718?page=

com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anushi Gupta updated OFBIZ-8718:

  Fix Version/s: 16.11.04

OFBIZ-7471: Improve all the service level error messages for missing
required field for SpecialPurpose/ebay component





-


  Key: OFBIZ-8718
  URL: https://issues.apache.org/jira/browse/OFBIZ-8718
  Project: OFBiz
   Issue Type: Sub-task
   Components: ALL APPLICATIONS
 Affects Versions: 16.11.01
 Reporter: Jagpreet Kaur
 Assignee: Anushi Gupta
 Priority: Minor
  Fix For: 16.11.04

  Attachments: OFBIZ-8718.patch





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [Proposal] Ability to Record Return Communication

[Jacques Le Roux]

Le 23/09/2017 à 16:29, Ratnesh Upadhyay a écrit :

Hi Jacques,

Thanks for the response. I was thinking that retrieval gets slow down when
we have a lot of data in communication event entity. Actually, I've
prepared this proposal based on the current implementation of
CommunicationEventOrder on this assumption that it's an approved feature
that's its there in the system.

Thanks Ratnesh, I see your point now


I am also in agreement with you and Deepak to use the existing (generic)
data model to achieve this. I'll give it another thought and further
analyze it to fit in existing data model.

I finally think we can go with your proposition, following the same way than 
CommunicationEventOrder, if it eases the introduction of the feature

Jacques


Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

On Sat, Sep 23, 2017 at 5:37 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Le 23/09/2017 à 13:14, Ratnesh Upadhyay a écrit :


Imagine if we use the generic data model to record each kind of
communication and when the system tries to pull a specific email or
specific type email communication from this model then system has to
browse
a lot of data and due to this most of the time, it gets ended up with slow
query/browsing issue. So to avoid such performance issue instead of
extending CommunicationEvent entity, I proposed to make a separate entity.


Hi Ratnesh,

Are you sure about that? What would the bottleneck? If you think the DB
would slow down I don't think it's an issue.

My take is that I prefer a generic data model rather than sacrificing for
hypothetical performance and end up with data model like competitors with
thousands of entities (OFBiz is currently still around 800+)

Jacques

buildbot success in on ofbiz-trunk-framework-plugins

[buildbot]

The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/476

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: orcus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809429
Blamelist: akashjain

Build succeeded!

Sincerely,
 -The Buildbot

buildbot failure in on ofbiz-trunk-framework-plugins

[buildbot]

The Buildbot has detected a new failure on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/475

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-plugins-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-plugins/trunk] 1809427
Blamelist: arunpatidar

BUILD FAILED: failed shell_4

Sincerely,
 -The Buildbot

Re: [Proposal] Ability to Record Return Communication

[Ratnesh Upadhyay]

Hi Jacques,

Thanks for the response. I was thinking that retrieval gets slow down when
we have a lot of data in communication event entity. Actually, I've
prepared this proposal based on the current implementation of
CommunicationEventOrder on this assumption that it's an approved feature
that's its there in the system.

I am also in agreement with you and Deepak to use the existing (generic)
data model to achieve this. I'll give it another thought and further
analyze it to fit in existing data model.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

On Sat, Sep 23, 2017 at 5:37 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 23/09/2017 à 13:14, Ratnesh Upadhyay a écrit :
>
>> Imagine if we use the generic data model to record each kind of
>> communication and when the system tries to pull a specific email or
>> specific type email communication from this model then system has to
>> browse
>> a lot of data and due to this most of the time, it gets ended up with slow
>> query/browsing issue. So to avoid such performance issue instead of
>> extending CommunicationEvent entity, I proposed to make a separate entity.
>>
> Hi Ratnesh,
>
> Are you sure about that? What would the bottleneck? If you think the DB
> would slow down I don't think it's an issue.
>
> My take is that I prefer a generic data model rather than sacrificing for
> hypothetical performance and end up with data model like competitors with
> thousands of entities (OFBiz is currently still around 800+)
>
> Jacques
>

Re: Tracking Data Model changes

[Aditya Sharma]

That would be a much effective solution.

As far as https://cwiki.apache.org/confluence/display/OFBIZ/
Revisions+Requiring+Data+Migration+-+upgrade+ofbiz page is concerned I find
it quite absurd that we provide information based upon only revisions while
users deal with releases.

Though it would be better to link it to data migration page so that user
gets all information through a single path.

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems 


On Sat, Sep 23, 2017 at 2:22 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Aditya,
>
> One way we could use and is already used for the Gradle and Birt Flexible
> documentation in wiki is to create README.md files, uses Pandoc to generate
> a HTML file from it in tools\wiki-files and import this file in wiki using
> the HTML import macro.
>
> Doing  so we follow both way you suggested. So users have it in 2 places
> while it's only maintained in one place where it's versioned (though
> Confluence also versions pages)
>
> Maybe an overkill in this case though. Since we have already
> https://cwiki.apache.org/confluence/display/OFBIZ/Revisions+
> Requiring+Data+Migration+-+upgrade+ofbiz to start from
>
> My 2cts
>
> Jacques
>
>
> Le 23/09/2017 à 10:41, Aditya Sharma a écrit :
>
>> I see two ways to do that
>>
>> 1. A page maintained on Confluence where all the data model changes are
>> updated. Here, we can have a page maintained for the upcoming release when
>> the release is out we make it sub child titled with the release name.
>> 2. A file is maintained in ofbiz-framework code base itself that goes with
>> the package with information about data model changes. Whenever someone
>> downloads the package this file will help track data model changes that
>> come with the package.
>>
>> We can make it part of contributor's practice to update it whenever such
>> changes are done.
>>
>> Which way should we go?
>>
>> Thanks and Regards,
>>
>> *Aditya Sharma* | Enterprise Software Engineer
>> HotWax Systems 
>> 
>>
>> On Sun, Sep 10, 2017 at 4:46 PM, Michael Brohl 
>> wrote:
>>
>> +1 for the documentation of database changes.
>>>
>>> We alreadyy do this for customer projects, along with (database specific)
>>> data migration scripts.
>>>
>>> I'm not sure if we can afford to provide sophisticated additional tool
>>> support which is maintained continiously?
>>>
>>>
>>> As a conclusion, I think we should setup a convention that any database
>>> model change has to provide a proper change log and migration script for
>>> the embedded database (if applicable).
>>>
>>> Thanks,
>>>
>>> Michael
>>>
>>>
>>> Am 01.09.17 um 15:24 schrieb Taher Alkhateeb:
>>>
>>> Groovy scripts are also great and can do the job. To comment on the
>>>
 "advantage" of something like flyway or liquibase I can try to list
 some:
 - The scripts might get too big or complex to accommodate different
 databases and platforms.
 - Out of the box, these solutions are database independent
 - Ability to redo / undo on schema changes
 - Supporting declarative style for schema definitions based on
 multiple formats (YAML, XML, JSON, etc ..)
 - The DSL is easier to use (declarative and short)

 So in short, both solutions are viable, and existing solutions might
 be a bit easier to implement especially if you consider additional
 features in those solutions.

 On Fri, Sep 1, 2017 at 2:23 PM, Nicolas Malin >>> >
 wrote:

 I'm in favor to tracking the different migration but at this time I
> didn't
> see the advantage to use flyway or other instead of manage easily by
> ofbiz
> throw groovy script.
>
> I'm available to help for design or create a POC do realize it because
> many
> time in the past (and currently ow) I want to refactoring some code/db
> schema with data migration but we haven't clean process to do that.
>
> Nicolas
>
>
> Le 31/08/2017 à 12:37, Jacques Le Roux a écrit :
>
> Le 31/08/2017 à 12:32, Taher Alkhateeb a écrit :
>>
>> I would personally prefer to not go any
>>> earlier than 13, or preferably just 16 to trunk, which means we
>>> design
>>> this solution for the future, not necessarily the past.
>>>
>>> +1
>>
>> Jacques
>>
>>
>>
>>
>>>
>

Re: svn commit: r1809410 - in /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common: JsLanguageFileMappingCreator.java JsLanguageFilesMapping.java

[Deepak Dixit]

Thanks Jacques done at r#1809413





Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Sat, Sep 23, 2017 at 6:01 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Deepak,
>
> As explained in its top
>
> // DO NOT EDIT THIS FILE!  THIS IS AUTO GENERATED AND WILL GET WRITTEN
> OVER PERIODICALLY WHEN THE DATA CHANGE
> // Rather use the createJsLanguageFileMapping service to create or
> update it. You will still need to compile thereafter
>
> So maybe you ran this service at some point? because date-en-US.js is the
> default and replace others when missing.
>
> Anyway, I think we should either remove this line or replace it by
>
> localeFiles.put("cs", "/common/js/jquery/plugins/datejs/date-cs-CZ.js");
>
> Jacques
>
>
> Le 23/09/2017 à 14:18, Deepak Dixit a écrit :
>
>> -localeFiles.put("cs", "/common/js/jquery/plugins/
>
 datejs/date-cs-CZ.js");
>>
>>> +localeFiles.put("cs", "/common/js/jquery/plugins/
>
 datejs/date-en-US.js");
>>
>> I don't know why this changes took place, I simply run the
>> createJsLanguageFileMapping
>> and committed the code. Interesting we have  date-cs-CZ.js in system.
>>
>> Thanks & Regards
>> --
>> Deepak Dixit
>> https://ofbiz.apache.org/
>>
>>
>> On Sat, Sep 23, 2017 at 5:41 PM,  wrote:
>>
>> Author: deepak
>>> Date: Sat Sep 23 12:11:31 2017
>>> New Revision: 1809410
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1809410&view=rev
>>> Log:
>>> Fixed: JsLanguageFilesMapping.java location in
>>> createJsLanguageFileMapping
>>> service, and commiting the auto generated java file for language mapping
>>> js.
>>>
>>> Modified:
>>>  ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
>>>  ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java
>>>
>>> Modified: ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
>>> framework/common/src/main/java/org/apache/ofbiz/common/
>>> JsLanguageFileMappingCreator.java?rev=1809410&r1=1809409&
>>> r2=1809410&view=diff
>>> 
>>> ==
>>> --- ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
>>> (original)
>>> +++ ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java Sat Sep
>>> 23
>>> 12:11:31 2017
>>> @@ -180,7 +180,7 @@ public class JsLanguageFileMappingCreato
>>>
>>>   // check the template file
>>>   String template = "themes/common/template/
>>> JsLanguageFilesMapping.ftl";
>>> -String output = "framework/common/src/org/apache/ofbiz/common/
>>> JsLanguageFilesMapping.java";
>>> +String output = "framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java";
>>>   Map mapWrapper = new HashMap();
>>>   mapWrapper.put("datejs", dateJsLocaleFile);
>>>   mapWrapper.put("jquery", jQueryLocaleFile);
>>>
>>> Modified: ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java
>>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
>>> framework/common/src/main/java/org/apache/ofbiz/common/
>>> JsLanguageFilesMapping.java?rev=1809410&r1=1809409&r2=1809410&view=diff
>>> 
>>> ==
>>> --- ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java (original)
>>> +++ ofbiz/ofbiz-framework/trunk/framework/common/src/main/
>>> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java Sat Sep 23
>>> 12:11:31 2017
>>> @@ -68,7 +68,7 @@ public final class JsLanguageFilesMappin
>>>   localeFiles.put("zh_TW", "/common/js/jquery/plugins/
>>> datejs/date-zh-TW.js");
>>>   localeFiles.put("hr", "/common/js/jquery/plugins/
>>> datejs/date-hr-HR.js");
>>>   localeFiles.put("hr_HR", "/common/js/jquery/plugins/
>>> datejs/date-hr-HR.js");
>>> -localeFiles.put("cs", "/common/js/jquery/plugins/
>>> datejs/date-cs-CZ.js");
>>> +localeFiles.put("cs", "/common/js/jquery/plugins/
>>> datejs/date-en-US.js");
>>>   localeFiles.put("cs_CZ", "/common/js/jquery/plugins/
>>> datejs/date-cs-CZ.js");
>>>   localeFiles.put("da", "/common/js/jquery/plugins/
>>> datejs/date-da-DA.js");
>>>   localeFiles.put("da_DK", "/common/js/jquery/plugins/
>>> datejs/date-da-DK.js");
>>> @@ -556,7 +556,7 @@ public final class JsLanguageFilesMappin
>>>
>>>   public static class dateTime {
>>>   private static Map localeFiles = new
>>> HashMap();
>>> -  

Re: [MODERATE EMAIL] Proposal to use Servlet annotations for configuration.

[Yash Sharma]

Hello Jacques,

First of all, thank you for your response, while we declare Servlet
definition in web.xml file we can also do it the java file itself.
Here is an example of declaring a Servlet through annotation:

@WebServlet(name = "/mypluginweb/WelcomeServlet", urlPatterns =
"/mypluginweb/WelcomeServlet", loadOnStartup = 1, description = "Welcome
Servlet")

and for Filters:

@WebFilter(filterName = "MyFilter", displayName = "MyFilter", initParams =
@WebInitParam(name = "allowedPaths", value =
"/error:/control:/select:/index.html:/index.jsp:/default.html:/default.jsp:/images"),
@WebInitParam(name = "redirectPath", value = "/control/main"))

Web components are configurable through annotations it reduces ceremony of
1) Writing XML files
2) Validating and storing Document
3) And finally converting them into Java objects.
4) Annotations based configuration is concise in comparison to XML based
configuration.



On Mon, Sep 18, 2017 at 12:27 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Pradhan,
>
> Could you give us a quick example of what you want to do with it exactly?
>
> Actually more to the point, what advantages this gives to us?
>
> TIA
>
> Jacques
>
>
> Le 18/09/2017 à 07:19, Deepak Dixit a écrit :
> > Hi Yash,
> >
> > Your email has been moderated,
> > Please subscribe to mailing list
> >
> > http://ofbiz.apache.org/mailing-lists.html
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > www.hotwaxsystems.com
> > www.hotwax.co
> >
> >
> > -- Forwarded message --
> > From: Pradhan Yash Sharma 
> > To: dev@ofbiz.apache.org
> > Cc: Yash Sharma 
> > Bcc:
> > Date: Sun, 17 Sep 2017 15:52:51 +0530
> > Subject: Proposal to use Servlet annotations for configuration.
> > Hello All,
> >
> > I would like to propose to use annotations for configuring Servlets. We
> > have declared web.xml file in every webapp to modularize code. I would
> like
> > to use Web Servlet annotations
> > <
> http://docs.oracle.com/javaee/6/api/javax/servlet/annotation/package-summary.html
> >
> > to
> > configure:
> >
> > 1) context params
> > 2) filters
> > 3) listeners
> > 4) servlet
> > 5) session configurations
> >
> > Please let me know your thoughts.
> >
>
> --
Thanks,
*Pradhan Yash Sharma*

Re: svn commit: r1809410 - in /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbi z/common: JsLanguageFileMappingCreator.java JsLanguageFilesMapping.java

[Jacques Le Roux]

Hi Deepak,

As explained in its top

    // DO NOT EDIT THIS FILE!  THIS IS AUTO GENERATED AND WILL GET WRITTEN OVER 
PERIODICALLY WHEN THE DATA CHANGE
    // Rather use the createJsLanguageFileMapping service to create or update 
it. You will still need to compile thereafter

So maybe you ran this service at some point? because date-en-US.js is the 
default and replace others when missing.

Anyway, I think we should either remove this line or replace it by

localeFiles.put("cs", "/common/js/jquery/plugins/datejs/date-cs-CZ.js");

Jacques


Le 23/09/2017 à 14:18, Deepak Dixit a écrit :

-localeFiles.put("cs", "/common/js/jquery/plugins/

datejs/date-cs-CZ.js");

+localeFiles.put("cs", "/common/js/jquery/plugins/

datejs/date-en-US.js");

I don't know why this changes took place, I simply run the
createJsLanguageFileMapping
and committed the code. Interesting we have  date-cs-CZ.js in system.

Thanks & Regards
--
Deepak Dixit
https://ofbiz.apache.org/


On Sat, Sep 23, 2017 at 5:41 PM,  wrote:


Author: deepak
Date: Sat Sep 23 12:11:31 2017
New Revision: 1809410

URL: http://svn.apache.org/viewvc?rev=1809410&view=rev
Log:
Fixed: JsLanguageFilesMapping.java location in createJsLanguageFileMapping
service, and commiting the auto generated java file for language mapping js.

Modified:
 ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
 ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFilesMapping.java

Modified: ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/common/src/main/java/org/apache/ofbiz/common/
JsLanguageFileMappingCreator.java?rev=1809410&r1=1809409&
r2=1809410&view=diff

==
--- ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java Sat Sep 23
12:11:31 2017
@@ -180,7 +180,7 @@ public class JsLanguageFileMappingCreato

  // check the template file
  String template = "themes/common/template/
JsLanguageFilesMapping.ftl";
-String output = "framework/common/src/org/apache/ofbiz/common/
JsLanguageFilesMapping.java";
+String output = "framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFilesMapping.java";
  Map mapWrapper = new HashMap();
  mapWrapper.put("datejs", dateJsLocaleFile);
  mapWrapper.put("jquery", jQueryLocaleFile);

Modified: ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFilesMapping.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
framework/common/src/main/java/org/apache/ofbiz/common/
JsLanguageFilesMapping.java?rev=1809410&r1=1809409&r2=1809410&view=diff

==
--- ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFilesMapping.java (original)
+++ ofbiz/ofbiz-framework/trunk/framework/common/src/main/
java/org/apache/ofbiz/common/JsLanguageFilesMapping.java Sat Sep 23
12:11:31 2017
@@ -68,7 +68,7 @@ public final class JsLanguageFilesMappin
  localeFiles.put("zh_TW", "/common/js/jquery/plugins/
datejs/date-zh-TW.js");
  localeFiles.put("hr", "/common/js/jquery/plugins/
datejs/date-hr-HR.js");
  localeFiles.put("hr_HR", "/common/js/jquery/plugins/
datejs/date-hr-HR.js");
-localeFiles.put("cs", "/common/js/jquery/plugins/
datejs/date-cs-CZ.js");
+localeFiles.put("cs", "/common/js/jquery/plugins/
datejs/date-en-US.js");
  localeFiles.put("cs_CZ", "/common/js/jquery/plugins/
datejs/date-cs-CZ.js");
  localeFiles.put("da", "/common/js/jquery/plugins/
datejs/date-da-DA.js");
  localeFiles.put("da_DK", "/common/js/jquery/plugins/
datejs/date-da-DK.js");
@@ -556,7 +556,7 @@ public final class JsLanguageFilesMappin

  public static class dateTime {
  private static Map localeFiles = new
HashMap();
-private static String defaultDateTime = "/images/webapp/common/js/
jquery/ui/i18n/jquery.ui.datepicker-en.js";
+private static String defaultDateTime =
"/common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js";

  static {
  localeFiles.put("sq", "/common/js/jquery/plugins/
datetimepicker/localization/jquery-ui-timepicker-en.js");

Re: svn commit: r1809410 - in /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common: JsLanguageFileMappingCreator.java JsLanguageFilesMapping.java

[Deepak Dixit]

>>>-localeFiles.put("cs", "/common/js/jquery/plugins/
datejs/date-cs-CZ.js");
>>>+localeFiles.put("cs", "/common/js/jquery/plugins/
datejs/date-en-US.js");

I don't know why this changes took place, I simply run the
createJsLanguageFileMapping
and committed the code. Interesting we have  date-cs-CZ.js in system.

Thanks & Regards
--
Deepak Dixit
https://ofbiz.apache.org/


On Sat, Sep 23, 2017 at 5:41 PM,  wrote:

> Author: deepak
> Date: Sat Sep 23 12:11:31 2017
> New Revision: 1809410
>
> URL: http://svn.apache.org/viewvc?rev=1809410&view=rev
> Log:
> Fixed: JsLanguageFilesMapping.java location in createJsLanguageFileMapping
> service, and commiting the auto generated java file for language mapping js.
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
> ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/common/src/main/java/org/apache/ofbiz/common/
> JsLanguageFileMappingCreator.java?rev=1809410&r1=1809409&
> r2=1809410&view=diff
> 
> ==
> --- ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFileMappingCreator.java Sat Sep 23
> 12:11:31 2017
> @@ -180,7 +180,7 @@ public class JsLanguageFileMappingCreato
>
>  // check the template file
>  String template = "themes/common/template/
> JsLanguageFilesMapping.ftl";
> -String output = "framework/common/src/org/apache/ofbiz/common/
> JsLanguageFilesMapping.java";
> +String output = "framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java";
>  Map mapWrapper = new HashMap();
>  mapWrapper.put("datejs", dateJsLocaleFile);
>  mapWrapper.put("jquery", jQueryLocaleFile);
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/common/src/main/java/org/apache/ofbiz/common/
> JsLanguageFilesMapping.java?rev=1809410&r1=1809409&r2=1809410&view=diff
> 
> ==
> --- ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/common/src/main/
> java/org/apache/ofbiz/common/JsLanguageFilesMapping.java Sat Sep 23
> 12:11:31 2017
> @@ -68,7 +68,7 @@ public final class JsLanguageFilesMappin
>  localeFiles.put("zh_TW", "/common/js/jquery/plugins/
> datejs/date-zh-TW.js");
>  localeFiles.put("hr", "/common/js/jquery/plugins/
> datejs/date-hr-HR.js");
>  localeFiles.put("hr_HR", "/common/js/jquery/plugins/
> datejs/date-hr-HR.js");
> -localeFiles.put("cs", "/common/js/jquery/plugins/
> datejs/date-cs-CZ.js");
> +localeFiles.put("cs", "/common/js/jquery/plugins/
> datejs/date-en-US.js");
>  localeFiles.put("cs_CZ", "/common/js/jquery/plugins/
> datejs/date-cs-CZ.js");
>  localeFiles.put("da", "/common/js/jquery/plugins/
> datejs/date-da-DA.js");
>  localeFiles.put("da_DK", "/common/js/jquery/plugins/
> datejs/date-da-DK.js");
> @@ -556,7 +556,7 @@ public final class JsLanguageFilesMappin
>
>  public static class dateTime {
>  private static Map localeFiles = new
> HashMap();
> -private static String defaultDateTime = "/images/webapp/common/js/
> jquery/ui/i18n/jquery.ui.datepicker-en.js";
> +private static String defaultDateTime =
> "/common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js";
>
>  static {
>  localeFiles.put("sq", "/common/js/jquery/plugins/
> datetimepicker/localization/jquery-ui-timepicker-en.js");
>
>
>

Re: [Proposal] Ability to Record Return Communication

[Jacques Le Roux]

Le 23/09/2017 à 13:14, Ratnesh Upadhyay a écrit :

Imagine if we use the generic data model to record each kind of
communication and when the system tries to pull a specific email or
specific type email communication from this model then system has to browse
a lot of data and due to this most of the time, it gets ended up with slow
query/browsing issue. So to avoid such performance issue instead of
extending CommunicationEvent entity, I proposed to make a separate entity.

Hi Ratnesh,

Are you sure about that? What would the bottleneck? If you think the DB would 
slow down I don't think it's an issue.

My take is that I prefer a generic data model rather than sacrificing for hypothetical performance and end up with data model like competitors with 
thousands of entities (OFBiz is currently still around 800+)


Jacques

Re: [Proposal] Ability to Record Return Communication

[Ratnesh Upadhyay]

Your assumption is correct, Rishi thanks for the inputs.

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

On Sat, Sep 23, 2017 at 4:05 PM, Rishi Solanki 
wrote:

> +1 for the proposal, I'll be happy to discuss and finalizing the things.
>
> Assuming that you have already consider ProductStoreEmailSetting and
> EmailTemplateSetting for sending the different notification for return.
>
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
> On Sat, Sep 23, 2017 at 3:44 PM, Ratnesh Upadhyay <
> upadhyay.ratn...@gmail.com> wrote:
>
> > Hi Devs,
> >
> > In OOTB we are having the ability to record order specific communication
> in
> > *CommunicationEventOrder* and the user can retrieve/review them from
> party
> > > communications screen but we don't have such support for return
> > communications. So It would be great to have an ability to record return
> > specific communication in the system.
> >
> > We have to implement following items to establish this feature :
> >
> > *Data Model Details:*
> > - We will have to create new entity *CommunicationEventReturn* to record
> > return communication. It should have returnId and communicationEventId
> > along with other necessary fields.
> > - We have to implement following view *CommunicationEventAndReturn* to
> > fetch return communications over screens as needed.
> >
> > *New Implementation Details:*
> > - We have to add *CRUD* services for the new entity.
> >
> > *Existing Implementation Details:*
> > - We have to extend *createCommunicationEvent* service definition with
> > retunId field and extend the existing implementation to create the record
> > in *CommunicationEventReturn* based on supplied returnId parameter.
> > - Also, we have to extend return related email services to provide
> returnId
> > in service context.
> >
> > *User Interface Details:*
> > - In the current system we have Party > Communications > Find
> Communication
> > By Order screen, in the same way, we can add another screen to find
> > communication by return.
> > - We can add return communication screenlet over Order Manager > Return >
> > Return History screen or we can add communication tab under Order >
> Return
> > screen, this is just a thought still thinking on it.
> > - We can also provide communication tab in order component as well.
> >
> > Please have a look at details and let me know your inputs. I'll log Jira
> > ticket to implement this feature soon.
> >
> > Thanks!!
> >
> > Regards,
> > Ratnesh Upadhyay
> > HotWax Systems | www.hotwaxsystems.com
> >
>

Re: [Proposal] Ability to Record Return Communication

[Ratnesh Upadhyay]

Thanks for your inputs Deepak.

Agreed that CommunicationEvent is way generic and this is the main use case
to keep the order and return separately from this model as they are using
most frequently in each business.
Imagine if we use the generic data model to record each kind of
communication and when the system tries to pull a specific email or
specific type email communication from this model then system has to browse
a lot of data and due to this most of the time, it gets ended up with slow
query/browsing issue. So to avoid such performance issue instead of
extending CommunicationEvent entity, I proposed to make a separate entity.

Definitely, we can think more on it to find the more generic way to record
this information in the system.

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

On Sat, Sep 23, 2017 at 4:05 PM, Deepak Dixit  wrote:

> Hi Ratnesh,
>
> I like you idea, but instead of adding new entity can we define some
> generic way to use CommunicationEvent along with all kind of activity.
> Like  CommunicationEvent is generic DataModel, it applicable for invoice,
> workEffort, marketing campaign, contact list, order , return, etc.
>
> As per current implementation some values are exists in CommunicationEvent
> entity and some are in assoc pattern.
>
> So creating new entity for each model will be too much.  Any other opinion?
>
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Sat, Sep 23, 2017 at 3:44 PM, Ratnesh Upadhyay <
> upadhyay.ratn...@gmail.com> wrote:
>
> > Hi Devs,
> >
> > In OOTB we are having the ability to record order specific communication
> in
> > *CommunicationEventOrder* and the user can retrieve/review them from
> party
> > > communications screen but we don't have such support for return
> > communications. So It would be great to have an ability to record return
> > specific communication in the system.
> >
> > We have to implement following items to establish this feature :
> >
> > *Data Model Details:*
> > - We will have to create new entity *CommunicationEventReturn* to record
> > return communication. It should have returnId and communicationEventId
> > along with other necessary fields.
> > - We have to implement following view *CommunicationEventAndReturn* to
> > fetch return communications over screens as needed.
> >
> > *New Implementation Details:*
> > - We have to add *CRUD* services for the new entity.
> >
> > *Existing Implementation Details:*
> > - We have to extend *createCommunicationEvent* service definition with
> > retunId field and extend the existing implementation to create the record
> > in *CommunicationEventReturn* based on supplied returnId parameter.
> > - Also, we have to extend return related email services to provide
> returnId
> > in service context.
> >
> > *User Interface Details:*
> > - In the current system we have Party > Communications > Find
> Communication
> > By Order screen, in the same way, we can add another screen to find
> > communication by return.
> > - We can add return communication screenlet over Order Manager > Return >
> > Return History screen or we can add communication tab under Order >
> Return
> > screen, this is just a thought still thinking on it.
> > - We can also provide communication tab in order component as well.
> >
> > Please have a look at details and let me know your inputs. I'll log Jira
> > ticket to implement this feature soon.
> >
> > Thanks!!
> >
> > Regards,
> > Ratnesh Upadhyay
> > HotWax Systems | www.hotwaxsystems.com
> >
>

buildbot success in on ofbiz-trunk-framework-plugins

[buildbot]

The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/466

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809387
Blamelist: jleroux

Build succeeded!

Sincerely,
 -The Buildbot

Re: [Proposal] Ability to Record Return Communication

[Rishi Solanki]

+1 for the proposal, I'll be happy to discuss and finalizing the things.

Assuming that you have already consider ProductStoreEmailSetting and
EmailTemplateSetting for sending the different notification for return.

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Sat, Sep 23, 2017 at 3:44 PM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:

> Hi Devs,
>
> In OOTB we are having the ability to record order specific communication in
> *CommunicationEventOrder* and the user can retrieve/review them from party
> > communications screen but we don't have such support for return
> communications. So It would be great to have an ability to record return
> specific communication in the system.
>
> We have to implement following items to establish this feature :
>
> *Data Model Details:*
> - We will have to create new entity *CommunicationEventReturn* to record
> return communication. It should have returnId and communicationEventId
> along with other necessary fields.
> - We have to implement following view *CommunicationEventAndReturn* to
> fetch return communications over screens as needed.
>
> *New Implementation Details:*
> - We have to add *CRUD* services for the new entity.
>
> *Existing Implementation Details:*
> - We have to extend *createCommunicationEvent* service definition with
> retunId field and extend the existing implementation to create the record
> in *CommunicationEventReturn* based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId
> in service context.
>
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication
> By Order screen, in the same way, we can add another screen to find
> communication by return.
> - We can add return communication screenlet over Order Manager > Return >
> Return History screen or we can add communication tab under Order > Return
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
>
> Please have a look at details and let me know your inputs. I'll log Jira
> ticket to implement this feature soon.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>

Re: [Proposal] Ability to Record Return Communication

[Deepak Dixit]

Hi Ratnesh,

I like you idea, but instead of adding new entity can we define some
generic way to use CommunicationEvent along with all kind of activity.
Like  CommunicationEvent is generic DataModel, it applicable for invoice,
workEffort, marketing campaign, contact list, order , return, etc.

As per current implementation some values are exists in CommunicationEvent
entity and some are in assoc pattern.

So creating new entity for each model will be too much.  Any other opinion?


Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Sat, Sep 23, 2017 at 3:44 PM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:

> Hi Devs,
>
> In OOTB we are having the ability to record order specific communication in
> *CommunicationEventOrder* and the user can retrieve/review them from party
> > communications screen but we don't have such support for return
> communications. So It would be great to have an ability to record return
> specific communication in the system.
>
> We have to implement following items to establish this feature :
>
> *Data Model Details:*
> - We will have to create new entity *CommunicationEventReturn* to record
> return communication. It should have returnId and communicationEventId
> along with other necessary fields.
> - We have to implement following view *CommunicationEventAndReturn* to
> fetch return communications over screens as needed.
>
> *New Implementation Details:*
> - We have to add *CRUD* services for the new entity.
>
> *Existing Implementation Details:*
> - We have to extend *createCommunicationEvent* service definition with
> retunId field and extend the existing implementation to create the record
> in *CommunicationEventReturn* based on supplied returnId parameter.
> - Also, we have to extend return related email services to provide returnId
> in service context.
>
> *User Interface Details:*
> - In the current system we have Party > Communications > Find Communication
> By Order screen, in the same way, we can add another screen to find
> communication by return.
> - We can add return communication screenlet over Order Manager > Return >
> Return History screen or we can add communication tab under Order > Return
> screen, this is just a thought still thinking on it.
> - We can also provide communication tab in order component as well.
>
> Please have a look at details and let me know your inputs. I'll log Jira
> ticket to implement this feature soon.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>

buildbot success in on ofbiz-trunk-framework

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-trunk-framework 
while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/477

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809383
Blamelist: jleroux

Build succeeded!

Sincerely,
 -The Buildbot

[Proposal] Ability to Record Return Communication

[Ratnesh Upadhyay]

Hi Devs,

In OOTB we are having the ability to record order specific communication in
*CommunicationEventOrder* and the user can retrieve/review them from party
> communications screen but we don't have such support for return
communications. So It would be great to have an ability to record return
specific communication in the system.

We have to implement following items to establish this feature :

*Data Model Details:*
- We will have to create new entity *CommunicationEventReturn* to record
return communication. It should have returnId and communicationEventId
along with other necessary fields.
- We have to implement following view *CommunicationEventAndReturn* to
fetch return communications over screens as needed.

*New Implementation Details:*
- We have to add *CRUD* services for the new entity.

*Existing Implementation Details:*
- We have to extend *createCommunicationEvent* service definition with
retunId field and extend the existing implementation to create the record
in *CommunicationEventReturn* based on supplied returnId parameter.
- Also, we have to extend return related email services to provide returnId
in service context.

*User Interface Details:*
- In the current system we have Party > Communications > Find Communication
By Order screen, in the same way, we can add another screen to find
communication by return.
- We can add return communication screenlet over Order Manager > Return >
Return History screen or we can add communication tab under Order > Return
screen, this is just a thought still thinking on it.
- We can also provide communication tab in order component as well.

Please have a look at details and let me know your inputs. I'll log Jira
ticket to implement this feature soon.

Thanks!!

Regards,
Ratnesh Upadhyay
HotWax Systems | www.hotwaxsystems.com

buildbot success in on ofbiz-trunk-framework-plugins

[buildbot]

The Buildbot has detected a restored build on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/464

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809383
Blamelist: jleroux

Build succeeded!

Sincerely,
 -The Buildbot

Re: Common-theme next step

[Swapnil Mane]

Thanks Jacques for your timings and suggestion.
@SuppressWarnings("serial") doesn't work for me.

= Console Log start =

2017-09-23 14:38:25,610 |jsse-nio-8443-exec-8
|ServiceDispatcher |T| [[ASync service started...-
total:0.0,since last(Begin):0.0]] - 'manufacturing / executeMrp'
2017-09-23 14:38:25,630 |jsse-nio-8443-exec-8
|SequenceUtil  |I| Got bank of sequenced IDs for
[RuntimeData]; curSeqId=10600, maxSeqId=10700, bankSize=100
2017-09-23 14:38:25,649 |jsse-nio-8443-exec-8
|UtilObject|E| null
java.io.NotSerializableException: org.apache.ofbiz.widget.model.
ModelTheme$ModelTemplate
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
~[?:1.8.0_66]
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
~[?:1.8.0_66]
at java.util.HashMap.internalWriteEntries(HashMap.java:1777)
~[?:1.8.0_66]
at java.util.HashMap.writeObject(HashMap.java:1354) ~[?:1.8.0_66]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_66]
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:62) ~[?:1.8.0_66]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_66]
at java.lang.reflect.Method.invoke(Method.java:497) ~[?:1.8.0_66]
at 
java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:1028)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1496)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)
~[?:1.8.0_66]
at 
java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1432)
~[?:1.8.0_66]
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1178)
~[?:1.8.0_66]
at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
~[?:1.8.0_66]
at org.apache.ofbiz.base.util.UtilObject.getBytes(UtilObject.java:82)
[ofbiz.jar:?]
at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeCustom(XmlSerializer.java:262) [ofbiz.jar:?]
at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:257) [ofbiz.jar:?]
at org.apache.ofbiz.entity.serialize.XmlSerializer.
serializeSingle(XmlSerializer.java:252) [ofbiz.jar:?]
at org.apache.ofbiz.entity.serialize.XmlSerializer.
serialize(XmlSerializer.java:78) [ofbiz.jar:?]
at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:94) [ofbiz.jar:?]
at org.apache.ofbiz.service.engine.GenericAsyncEngine.
runAsync(GenericAsyncEngine.java:70) [ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
[ofbiz.jar:?]
at 
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
[ofbiz.jar:?]
at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:181) [ofbiz.jar:?]
at org.apache.ofbiz.service.GenericDispatcherFactory$
GenericDispatcher.runAsync(GenericDispatcherFactory.java:191) [ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.RequestHandler.
runEvent(RequestHandler.java:730) [ofbiz.jar:?]
at org.apache.ofbiz.webapp.control.RequestHandler.
doRequest(RequestHandler.java:454) [ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
at 
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
at javax.servlet.http.Http

Re: Tracking Data Model changes

[Jacques Le Roux]

Hi Aditya,

One way we could use and is already used for the Gradle and Birt Flexible documentation in wiki is to create README.md files, uses Pandoc to generate 
a HTML file from it in tools\wiki-files and import this file in wiki using the HTML import macro.


Doing  so we follow both way you suggested. So users have it in 2 places while it's only maintained in one place where it's versioned (though 
Confluence also versions pages)


Maybe an overkill in this case though. Since we have already 
https://cwiki.apache.org/confluence/display/OFBIZ/Revisions+Requiring+Data+Migration+-+upgrade+ofbiz to start from


My 2cts

Jacques


Le 23/09/2017 à 10:41, Aditya Sharma a écrit :

I see two ways to do that

1. A page maintained on Confluence where all the data model changes are
updated. Here, we can have a page maintained for the upcoming release when
the release is out we make it sub child titled with the release name.
2. A file is maintained in ofbiz-framework code base itself that goes with
the package with information about data model changes. Whenever someone
downloads the package this file will help track data model changes that
come with the package.

We can make it part of contributor's practice to update it whenever such
changes are done.

Which way should we go?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems 

On Sun, Sep 10, 2017 at 4:46 PM, Michael Brohl 
wrote:


+1 for the documentation of database changes.

We alreadyy do this for customer projects, along with (database specific)
data migration scripts.

I'm not sure if we can afford to provide sophisticated additional tool
support which is maintained continiously?


As a conclusion, I think we should setup a convention that any database
model change has to provide a proper change log and migration script for
the embedded database (if applicable).

Thanks,

Michael


Am 01.09.17 um 15:24 schrieb Taher Alkhateeb:

Groovy scripts are also great and can do the job. To comment on the

"advantage" of something like flyway or liquibase I can try to list
some:
- The scripts might get too big or complex to accommodate different
databases and platforms.
- Out of the box, these solutions are database independent
- Ability to redo / undo on schema changes
- Supporting declarative style for schema definitions based on
multiple formats (YAML, XML, JSON, etc ..)
- The DSL is easier to use (declarative and short)

So in short, both solutions are viable, and existing solutions might
be a bit easier to implement especially if you consider additional
features in those solutions.

On Fri, Sep 1, 2017 at 2:23 PM, Nicolas Malin 
wrote:


I'm in favor to tracking the different migration but at this time I
didn't
see the advantage to use flyway or other instead of manage easily by
ofbiz
throw groovy script.

I'm available to help for design or create a POC do realize it because
many
time in the past (and currently ow) I want to refactoring some code/db
schema with data migration but we haven't clean process to do that.

Nicolas


Le 31/08/2017 à 12:37, Jacques Le Roux a écrit :


Le 31/08/2017 à 12:32, Taher Alkhateeb a écrit :


I would personally prefer to not go any
earlier than 13, or preferably just 16 to trunk, which means we design
this solution for the future, not necessarily the past.


+1

Jacques

Re: svn commit: r1809375 - /ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml

[Aditya Sharma]

Hi Deepak,

Good observation. I missed on that. I will keep that in mind & update the
patch.

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems 


On Sat, Sep 23, 2017 at 2:06 PM, Deepak Dixit  wrote:

> Hi Aditya,
>
> It would be good if we use upper case for fk-name,  as its constraints and
> across the application we are using fk-name as upper case.
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Sat, Sep 23, 2017 at 1:54 PM,  wrote:
>
> > Author: jleroux
> > Date: Sat Sep 23 08:24:08 2017
> > New Revision: 1809375
> >
> > URL: http://svn.apache.org/viewvc?rev=1809375&view=rev
> > Log:
> > Implemented: Missing foreign key constraint for fields userLoginId &
> > userPrefGroupTypeId in UserPreference entity
> >
> > UserPreference.userLoginId is related to UserLogin.userLoginId.
> > UserPreference.userPrefGroupTypeId is related to
> > UserPrefGroupType.userPrefGroupTypeId.
> >
> > (OFBIZ-9678)
> >
> >
> > Thanks: Aditya
> >
> > Modified:
> > ofbiz/ofbiz-framework/trunk/framework/common/entitydef/enti
> tymodel.xml
> >
> > Modified: ofbiz/ofbiz-framework/trunk/framework/common/entitydef/
> > entitymodel.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > framework/common/entitydef/entitymodel.xml?rev=1809375&
> > r1=1809374&r2=1809375&view=diff
> > 
> > ==
> > --- ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entit
> ymodel.xml
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entit
> ymodel.xml
> > Sat Sep 23 08:24:08 2017
> > @@ -639,6 +639,12 @@ under the License.
> >The
> > java data type of this preference (empty = java.lang.String) > description>
> >
> >
> > +   > rel-entity-name="UserLogin">
> > +
> > +  
> > +   rel-entity-name="
> > UserPrefGroupType">
> > +
> > +  
> >  
> >
> >   >
> >
> >
>

Re: Tracking Data Model changes

[Aditya Sharma]

I see two ways to do that

1. A page maintained on Confluence where all the data model changes are
updated. Here, we can have a page maintained for the upcoming release when
the release is out we make it sub child titled with the release name.
2. A file is maintained in ofbiz-framework code base itself that goes with
the package with information about data model changes. Whenever someone
downloads the package this file will help track data model changes that
come with the package.

We can make it part of contributor's practice to update it whenever such
changes are done.

Which way should we go?

Thanks and Regards,

*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems 

On Sun, Sep 10, 2017 at 4:46 PM, Michael Brohl 
wrote:

> +1 for the documentation of database changes.
>
> We alreadyy do this for customer projects, along with (database specific)
> data migration scripts.
>
> I'm not sure if we can afford to provide sophisticated additional tool
> support which is maintained continiously?
>
>
> As a conclusion, I think we should setup a convention that any database
> model change has to provide a proper change log and migration script for
> the embedded database (if applicable).
>
> Thanks,
>
> Michael
>
>
> Am 01.09.17 um 15:24 schrieb Taher Alkhateeb:
>
> Groovy scripts are also great and can do the job. To comment on the
>> "advantage" of something like flyway or liquibase I can try to list
>> some:
>> - The scripts might get too big or complex to accommodate different
>> databases and platforms.
>> - Out of the box, these solutions are database independent
>> - Ability to redo / undo on schema changes
>> - Supporting declarative style for schema definitions based on
>> multiple formats (YAML, XML, JSON, etc ..)
>> - The DSL is easier to use (declarative and short)
>>
>> So in short, both solutions are viable, and existing solutions might
>> be a bit easier to implement especially if you consider additional
>> features in those solutions.
>>
>> On Fri, Sep 1, 2017 at 2:23 PM, Nicolas Malin 
>> wrote:
>>
>>> I'm in favor to tracking the different migration but at this time I
>>> didn't
>>> see the advantage to use flyway or other instead of manage easily by
>>> ofbiz
>>> throw groovy script.
>>>
>>> I'm available to help for design or create a POC do realize it because
>>> many
>>> time in the past (and currently ow) I want to refactoring some code/db
>>> schema with data migration but we haven't clean process to do that.
>>>
>>> Nicolas
>>>
>>>
>>> Le 31/08/2017 à 12:37, Jacques Le Roux a écrit :
>>>
 Le 31/08/2017 à 12:32, Taher Alkhateeb a écrit :

> I would personally prefer to not go any
> earlier than 13, or preferably just 16 to trunk, which means we design
> this solution for the future, not necessarily the past.
>
 +1

 Jacques



>
>

buildbot exception in on ofbiz-trunk-framework-plugins

[buildbot]

The Buildbot has detected a build exception on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/458

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: lares_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809375
Blamelist: jleroux

BUILD FAILED: exception shell_3 upload_1

Sincerely,
 -The Buildbot

Re: svn commit: r1809375 - /ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml

[Deepak Dixit]

Hi Aditya,

It would be good if we use upper case for fk-name,  as its constraints and
across the application we are using fk-name as upper case.

Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co

On Sat, Sep 23, 2017 at 1:54 PM,  wrote:

> Author: jleroux
> Date: Sat Sep 23 08:24:08 2017
> New Revision: 1809375
>
> URL: http://svn.apache.org/viewvc?rev=1809375&view=rev
> Log:
> Implemented: Missing foreign key constraint for fields userLoginId &
> userPrefGroupTypeId in UserPreference entity
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to
> UserPrefGroupType.userPrefGroupTypeId.
>
> (OFBIZ-9678)
>
>
> Thanks: Aditya
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/common/entitydef/
> entitymodel.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/common/entitydef/entitymodel.xml?rev=1809375&
> r1=1809374&r2=1809375&view=diff
> 
> ==
> --- ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
> (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
> Sat Sep 23 08:24:08 2017
> @@ -639,6 +639,12 @@ under the License.
>The
> java data type of this preference (empty = java.lang.String) description>
>
>
> +   rel-entity-name="UserLogin">
> +
> +  
> +  
> +
> +  
>  
>
>  
>
>

buildbot exception in on ofbiz-trunk-framework

[buildbot]

The Buildbot has detected a build exception on builder ofbiz-trunk-framework 
while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/471

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: orcus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809375
Blamelist: jleroux

BUILD FAILED: exception shell_1 upload

Sincerely,
 -The Buildbot

buildbot exception in on ofbiz-trunk-framework-plugins

[buildbot]

The Buildbot has detected a build exception on builder 
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/459

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809376
Blamelist: deepak

BUILD FAILED: exception shell_3 upload_1

Sincerely,
 -The Buildbot

buildbot exception in on ofbiz-trunk-framework

[buildbot]

The Buildbot has detected a build exception on builder ofbiz-trunk-framework 
while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/472

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 
'on-ofbiz-framework-commit' triggered this build
Build Source Stamp: [branch ofbiz/ofbiz-framework/trunk] 1809376
Blamelist: deepak

BUILD FAILED: exception shell_1 upload

Sincerely,
 -The Buildbot

Re: Common-theme next step

[Jacques Le Roux]

Hi Swapnil,

Did you try?

@SuppressWarnings("serial")
public final class VisualTheme implements Serializable {

Jacques


Le 23/09/2017 à 08:29, Swapnil Mane a écrit :

Thank you Nicolas and team for this great work.
Highly appreciated!!

I am facing some Exception related to VisualTheme while running the MRP.
https://demo-trunk.ofbiz.apache.org/manufacturing/control/RunMrp

I guess it is related to theme work we have done, please let me know, if I
am missing anything.


= Console Log start =
[[ASync service failed...- total:0.012,since last(ASync service
sta...):0.012]] - 'manufacturing / executeMrp'
2017-09-23 11:44:24,458 |jsse-nio-8443-exec-6
|ServiceDispatcher |E| Service [executeMrp] threw an unexpected
exception/error
org.apache.ofbiz.service.GenericServiceException: Problem serializing
service attributes (Cannot serialize object of class
org.apache.ofbiz.widget.renderer.VisualTheme)
 at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:124)
~[ofbiz.jar:?]
 at
org.apache.ofbiz.service.engine.GenericAsyncEngine.runAsync(GenericAsyncEngine.java:70)
~[ofbiz.jar:?]
 at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:715)
[ofbiz.jar:?]
 at
org.apache.ofbiz.service.ServiceDispatcher.runAsync(ServiceDispatcher.java:780)
[ofbiz.jar:?]
 at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:181)
[ofbiz.jar:?]
 at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runAsync(GenericDispatcherFactory.java:191)
[ofbiz.jar:?]
 at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:348)
[ofbiz.jar:?]
 at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:730)
[ofbiz.jar:?]
 at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:454)
[ofbiz.jar:?]
 at
org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:212)
[ofbiz.jar:?]
 at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:87)
[ofbiz.jar:?]
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
[javax.servlet-api-3.1.0.jar:3.1.0]
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
[javax.servlet-api-3.1.0.jar:3.1.0]
 at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
[tomcat-embed-websocket-8.0.39.jar:8.0.39]
 at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:196)
[ofbiz.jar:?]
 at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:157)
[ofbiz.jar:?]
 at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:478)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:624)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
[tomcat-catalina-8.5.16.jar:8.5.16]
 at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.jav