Re: [PROPOSITION] Extend the screen engine via plugins

[Nicolas Malin]

Hi,

On 23/08/2018 17:16, Mathieu Lirzin wrote:

Hello Nicolas,


[...]
example :








I find the “extend” term confusing in that case, because AIUI extending
is more about defining a new thing by inheriting from what is extended.
If I understand the semantics of your example correctly, it is more
about monkey patching [1]
‘component://party/widget/PartyForms.xml#ViewPartyGroup' than to create
an extended of version of it.  Is that a correct interpretation?
Not exactly how I imagine it. It's not the plugin who change the model 
but more the ModelReader who would come and take modifications wanted by 
plugins. I used 'extend model' term simply we already use a similar 
system with  element to surcharge an entity from an other 
component.
We can naming how we want, the most important part for me is record all 
modifications wanted by plugins at the start without apply them.

If my interpretation is correct, it is not clear what should happen when
multiple plugings modify/patch the same form?
As it would be the ModelReader who load wanted modifications, if one (or 
more) failed we can analyze why we can't apply it, generate information 
in log for developer and protect the model creation to ensure rendering 
all screens.


If a conflict appear between two plugins we can use different algorithm:
* FIWLC : First In Win Last Cry
* LIWFC : Last In Win First Cry
* NCNW : No Cooperation No Win

With this, we would have a plugin that can surcharge a screen, a form,
a menu without changingnothing in the framework, identify clearly what
change has been made and a failure support when the extend can't be
applied.

Currently I didn't found a solution to surcharge ftl.

If you feel that it's a good way to explore, I will start a new thread.

I guess I have started the thread :-)

Indeed !
Cheers,
Nicolas


[1] https://en.wikipedia.org/wiki/Monkey_patch

Re: [PROPOSAL] Short Messaging Service(SMS) Gateway Integration

[Nicolas Malin]

Hello Pritam,

Maybe I arrived after the war still I wish sharing my opinion :)

General term Sms seems to be too specific, I would've oriented on 
TelecomGateway


* ProductStoreTelecomGatewaySetting (too long :))
* TelecomGatewayConfig
* TelecomGatewayConfigType, and so on

For the attributes :
* configId is too generic and already use on productConfig entity. It's 
preferable to have unique name in OFBiz as primaryKey (same for settingId)
* parentSmsConfigTypeId need to rename on parentTypeId if you want to 
follow EntityType pattern.


Why set the purpose (smsTypeId) on SmsTemplateSetting instead of on 
ProductStoreSmsSetting where the template application will be done ?


What do you imagine behind the CustomMethod linked to SmsTemplateSetting ?

That's all I'll stop bothering you :)

Cheers,

Nicolas

On 02/07/2018 11:22, Pritam Kute wrote:

Hello Devs,

Sorry for such a long delay.

Thanks, Michael for your inputs. I have added design proposal for the SMS
gateway integration and can be accessed here
:
https://cwiki.apache.org/confluence/x/Zgo0BQ

Please go through the design and let me know if there are any questions,
suggestions or improvements which we can do.

Thanks to Devanshu Vyas and Aishwary Shrivastava for helping me with the
design and documentation.

Thanks and Regards
--
Pritam Kute

On Sun, Sep 10, 2017 at 4:33 PM Michael Brohl 
wrote:


+1

Looking forward to the design proposal.

You can use the wiki with a new page under

https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Requirements+and+Design+Proposals
to provide the details and support collaboration.

Thanks,

Michael

Am 26.08.17 um 13:31 schrieb Pritam Kute:

Hi Devs,

Many e-commerce businesses (especially operating in Asian countries)
nowadays use short messaging service (SMS) in mobile phones to notify and
update customers about order details, shipment statuses etc.

I would like to propose an SMS Gateway Integration in Ofbiz. I will share
proposed design details with you all soon. Till then, I would like to

know

your thoughts on this idea.

Thanks and Regards
--
Pritam Kute

Re: Old demo restarted

[Girish Vasmatkar]

I had earlier replied to this thread but looks like the email did not go
through. I had leaned towards using the tool (only just) instead of may be
having a CRON job or an alternative.

What I feel now is that may be we can use JMX here and try to use various
in build MBeans that provide CPU usage for the system and also for the JVM
process we are concerned about that is OFBiz instance. We should also be
able to get the memory usage of the JVM and if reaches a particular
threshold we can be notified.

In addition, I think we already add a shutdown hook to the JVM process... I
am not sure and have not used it much but may be we can use it to send some
notifications? Of course, it is applicable for graceful exits of JVM only
and if you just happen to kill the process it won't be of much help.

Hope it makes sense and correct me if I am wrong.

Best regards,
Girish Vasmatkar
HotWax Systems


On Thu, Aug 23, 2018 at 8:48 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Le 23/08/2018 à 14:04, Taher Alkhateeb a écrit :
> > I'm not sure why you're hanging this on me,
> Because you answered to the bait ;)
>
> > but sure I'm willing to
> > help.
> Thanks, much appreciated!
>
> > Can I get some information on how the crashes are happening and
> > how you're getting notified, and I will take it from there.
> I think after a crash it's mostly to use dumps there (we have several from
> the recent pas) but I'm not sure they will help, and it takes time to
> analyse.
>
> In the past I took the time to analyse some of them and it was
> interesting. For instance in 2010 I found a bug in a Java version we were
> using and it
> helped me in a custom project I was also doing then:
> https://markmail.org/message/byu2ivjn7wckayzz
>
> Lastly it was mostly lack of memory, despite having 8GB now. I created
> https://issues.apache.org/jira/browse/INFRA-16780 for that, but not sure
> it was
> the reason. At least we have less issues since.
>
> Before (months ago) the Infra was monitoring our demos and alerting us by
> mail (you just had to subscribe). Unfortunately we are on our own for that
> now, too much projects in the ASF...
> As as I said initially in this thread I'm currently using montastic.com
> for the email alerts.
> My idea when I started this thread was that it all depends on me, and
> that's bad. So I wanted people to be aware, you are much welcome.
>
> Jacques
> > On Thu, Aug 23, 2018 at 2:29 PM Jacques Le Roux
> >  wrote:
> >> Yes we can, will you?
> >>
> >> Jacques
> >>
> >>
> >> Le 22/08/2018 à 19:29, Taher Alkhateeb a écrit :
> >>> Well, we can ask Infra for help, we can check available solutions, we
> >>> can create a CRON script that checks things periodically, there are
> >>> multiple ways to go about this.
> >>>
> >>> My personal preference is for a simple CRON script that takes care of
> this.
> >>> On Wed, Aug 22, 2018 at 8:25 PM Jacques Le Roux
> >>>  wrote:
>  So you prefer that I'm the only one to take care of the demos and act
> on alerts?
> 
>  Jacques
> 
> 
>  Le 22/08/2018 à 18:53, Taher Alkhateeb a écrit :
> > I prefer not to include any tools without proper analysis and
> > discussion first. Less is more.
> > On Wed, Aug 22, 2018 at 5:31 PM Jacques Le Roux
> >  wrote:
> >> Hi,
> >>
> >> Should I consider no answers as a lazy consensus and should I send
> (rare) alerts to this ML?
> >>
> >> Without any answers I'll consider it a lazy consensus in 2 days.
> >>
> >> Jacques
> >>
> >>
> >> Le 17/08/2018 à 12:22, Jacques Le Roux a écrit :
> >>> Le 13/08/2018 à 18:21, Jacques Le Roux a écrit :
>  Le 12/08/2018 à 11:26, Jacques Le Roux a écrit :
> > Hi,
> >
> > This morning I noticed the old demo was down and restarted it
> after cleaning things.
> >
> > Previously (still some weeks ago) Daniel Gruno's (from Infra
> team) company was kindly providing us a mean to monitor our demos but it
> seems that
> > this mean is no longer available
> >
> > I have asked about it and will let you know about it...
> >
> > Have a good weekend
> >
> > Jadques
> >
>  Daniel confirmed it's terminated. I turned to UpTimeRobot which
> is free and seems as well good :)
> 
>  Jacques
> 
> 
> >>> This thread started on user ML but I don't want to bother everyone
> with technical details.
> >>>
> >>> I used my own @a.o email to create the monitoring. UpTimeRobot is
> certainly the best free monitoring tool, with some possibilities others
> don't give.
> >>>
> >>> But the free version has an inconvenient. You can only check every
> 5 mins and when the instances restart it takes more than 5 mins each.
> >>>
> >>> So everyday I get a down an up alerts for each. I have switched to
> montastic.com.
> >>>
> >>> I was wondering if we don't want to share that 

Re: Old demo restarted

[Jacques Le Roux]

Le 23/08/2018 à 14:04, Taher Alkhateeb a écrit :

I'm not sure why you're hanging this on me,

Because you answered to the bait ;)


but sure I'm willing to
help.

Thanks, much appreciated!


Can I get some information on how the crashes are happening and
how you're getting notified, and I will take it from there.

I think after a crash it's mostly to use dumps there (we have several from the 
recent pas) but I'm not sure they will help, and it takes time to analyse.

In the past I took the time to analyse some of them and it was interesting. For instance in 2010 I found a bug in a Java version we were using and it 
helped me in a custom project I was also doing then: https://markmail.org/message/byu2ivjn7wckayzz


Lastly it was mostly lack of memory, despite having 8GB now. I created https://issues.apache.org/jira/browse/INFRA-16780 for that, but not sure it was 
the reason. At least we have less issues since.


Before (months ago) the Infra was monitoring our demos and alerting us by mail (you just had to subscribe). Unfortunately we are on our own for that 
now, too much projects in the ASF...

As as I said initially in this thread I'm currently using montastic.com for the 
email alerts.
My idea when I started this thread was that it all depends on me, and that's 
bad. So I wanted people to be aware, you are much welcome.

Jacques

On Thu, Aug 23, 2018 at 2:29 PM Jacques Le Roux
 wrote:

Yes we can, will you?

Jacques


Le 22/08/2018 à 19:29, Taher Alkhateeb a écrit :

Well, we can ask Infra for help, we can check available solutions, we
can create a CRON script that checks things periodically, there are
multiple ways to go about this.

My personal preference is for a simple CRON script that takes care of this.
On Wed, Aug 22, 2018 at 8:25 PM Jacques Le Roux
 wrote:

So you prefer that I'm the only one to take care of the demos and act on alerts?

Jacques


Le 22/08/2018 à 18:53, Taher Alkhateeb a écrit :

I prefer not to include any tools without proper analysis and
discussion first. Less is more.
On Wed, Aug 22, 2018 at 5:31 PM Jacques Le Roux
 wrote:

Hi,

Should I consider no answers as a lazy consensus and should I send (rare) 
alerts to this ML?

Without any answers I'll consider it a lazy consensus in 2 days.

Jacques


Le 17/08/2018 à 12:22, Jacques Le Roux a écrit :

Le 13/08/2018 à 18:21, Jacques Le Roux a écrit :

Le 12/08/2018 à 11:26, Jacques Le Roux a écrit :

Hi,

This morning I noticed the old demo was down and restarted it after cleaning 
things.

Previously (still some weeks ago) Daniel Gruno's (from Infra team) company was 
kindly providing us a mean to monitor our demos but it seems that
this mean is no longer available

I have asked about it and will let you know about it...

Have a good weekend

Jadques


Daniel confirmed it's terminated. I turned to UpTimeRobot which is free and 
seems as well good :)

Jacques



This thread started on user ML but I don't want to bother everyone with 
technical details.

I used my own @a.o email to create the monitoring. UpTimeRobot is certainly the 
best free monitoring tool, with some possibilities others don't give.

But the free version has an inconvenient. You can only check every 5 mins and 
when the instances restart it takes more than 5 mins each.

So everyday I get a down an up alerts for each. I have switched to 
montastic.com.

I was wondering if we don't want to share that here.
We could then have these alerts here and any committer, using the info in 
https://svn.apache.org/repos/asf/ofbiz/tools/demo-backup could handle issues.

It seems better, isn'it?

Jacques

Re: [PROPOSITION] Extend the screen engine via plugins

[Mathieu Lirzin]

Hello Nicolas,

Nicolas Malin  writes:

> This thread about a "simple" problem highlights the difficulty for a
> plugin to extend the framework on different elements. Since many years
> I search different solution to how surcharge correctly the framework
> and it was not easy :)

This is indeed a desirable but hard problem to solve.

> Maybe I have two different solutions, based on theidea to usethemodel
> pattern toload all plugin surcharge at the ofbiz start like services
> and entities
> * The first, load all screen engine modelsin memory at start, but I
> fearthatit would be too expensive on memory (load unnecessary screens)
> * The second, create an'extend model' who permit to surcharge all
> screen engine model elements,andload it on ofbiz start and when we
> load a model, we check on extend model if the element have surcharge
> to apply just before settingit as immutable and put it in cache.
>
> example :
>  name='ViewPartyGroup'>
> 
>  target="/myplugin/control/viewprofile" target-type="inter-app"
> target-window="blank_">
> 
> 
> 
> 

I find the “extend” term confusing in that case, because AIUI extending
is more about defining a new thing by inheriting from what is extended.
If I understand the semantics of your example correctly, it is more
about monkey patching [1]
‘component://party/widget/PartyForms.xml#ViewPartyGroup' than to create
an extended of version of it.  Is that a correct interpretation?

If my interpretation is correct, it is not clear what should happen when
multiple plugings modify/patch the same form?

> With this, we would have a plugin that can surcharge a screen, a form,
> a menu without changingnothing in the framework, identify clearly what
> change has been made and a failure support when the extend can't be
> applied.
>
> Currently I didn't found a solution to surcharge ftl.
>
> If you feel that it's a good way to explore, I will start a new thread.

I guess I have started the thread :-)

[1] https://en.wikipedia.org/wiki/Monkey_patch

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37

Re: [PROPOSITION] Demos: replace old by trunk framework only

[James Yong]

Not sure why my 1st post didn't get through. So reposting again..


Hi all,

Good discussion so far. 

I am in favour of having a proper solution from start rather than a stopgap.

Propose something similar to what Nicolas mentioned but making use of a 
fragment-type plugin framework like https://pf4j.org/. 

The idea is for the fragment-type plugins to be located within framework or 
plugins, and loaded by a new OFBiz container. 
For now, this fragment-type plugin helps to extend a particular UI Menu Item.
When fetching a menu for a page, OFBiz looks into the fragment-type plugins 
that are loaded and add any new menu items as required.

Regards,
James

PS: Regarding the thread topic, I prefer trunk demo for framework.


On 2018/08/23 09:19:02, Nicolas Malin  wrote: 
> Hello
> 
> This thread about a "simple" problem highlights the difficulty for a 
> plugin to extend the framework on different elements. Since many years I 
> search different solution to how surcharge correctly the framework and 
> it was not easy :)
> 
> in line
> 
> On 22/08/2018 18:52, Taher Alkhateeb wrote:
> > Hi Julien,
> >
> > Good ideas, and this is a good start to try and tackle the problem.
> > Whatever we do, we must not keep "ghosts" or things that are waiting
> > for specific outside plugins. The framework should _never_ know
> > anything about the outside. This is a fundamental architectural
> > concept in any layered software system.
> Absolutely right, I knew a ghost history with addons that changed source 
> code base to load plugin's specificsinstead of understandingwhy we can't 
> surcharge the framework :)
> > I'm ready to help if needed, and I think there are many ways to fix
> > this problem. As you said one way is to extend webapps, another is
> > perhaps to optionally include freemarker templates that match a
> > certain pattern if they exist. In other words, you provide a generic
> > plugin-like mechanism for enhancing the system, but the direction is
> > _always_ from the outside to the inside, and not the other way around.
> > And that is what I mean with a root-cause analysis and solutions.
> 
> Maybe I have two different solutions, based on theidea to usethemodel 
> pattern toload all plugin surcharge at the ofbiz start like services and 
> entities
> * The first, load all screen engine modelsin memory at start, but I 
> fearthatit would be too expensive on memory (load unnecessary screens)
> * The second, create an'extend model' who permit to surcharge all screen 
> engine model elements,andload it on ofbiz start and when we load a 
> model, we check on extend model if the element have surcharge to apply 
> just before settingit as immutable and put it in cache.
> 
> example :
>  name='ViewPartyGroup'>
> 
>  target="/myplugin/control/viewprofile" target-type="inter-app" 
> target-window="blank_">
> 
> 
> 
> 
> 
> With this, we would have a plugin that can surcharge a screen, a form, a 
> menu without changingnothing in the framework, identify clearly what 
> change has been made and a failure support when the extend can't be applied.
> 
> Currently I didn't found a solution to surcharge ftl.
> 
> If you feel that it's a good way to explore, I will start a new thread.
> 
> Nicolas
> > So I'm all for a generic solution, but not for hard-wiring any
> > component or any link that is specific to a certain component. That is
> > definitely a code smell and beats the entire purpose of splitting the
> > repositories in the first place. [...]
> 
> 

Issue with opening a bookmarked page when the user is logged out

[Ritesh Kumar]

Hello All,

I faced an issue while trying to open a bookmarked page with OFBiz.

Suppose, the URL of this bookmarked page contains a parameter with multiple
values and the value may have space character. The query string in the URL
looks somewhat like this
"?categoryHierarchy=3%2FCompany+Catalog%2FBrowse+Root%2FCloths%2FMen%2F"=approved=created".
The "%2F" and "+" are encoded value of  "/", a separator and space
character respectively. The status id parameter appears twice and the
category hierarchy value has space character.

The user is logged out at this instance and this bookmarked page is opened.
Since the user is not logged in, the login page is rendered. I feed in the
credentials and the intended URL is hit. Here, I do not get the required
result.

When I check the URL, the parameter with multiple values just has the last
value of the list and "+" is encoded into "%2B". The URL now is
"?categoryHierarchy=3%2FCompany%2BCatalog%2FBrowse%2BRoot%2FCloths%2FMen%2F"==created."

I did some digging and found out that LoginWorker.checkLogin() comes into
action and what it does is that it creates a new session object (because
the previous session becomes invalid) and in the session object, it puts
the previous URL parameters. This previous URL parameters are fetched using
UtilHttp.getUrlOnlyParameterMap(request) which internally calls
getQueryStringOnlyParameterMap(). This method returns a map by breaking the
query string into key and value pair. A map can not have duplicate keys (in
this case removes the approved status) and the value is not decoded before
putting it into the map ('+' is not decoded). This map is then used to
create an encoded ('+' is encoded into '%2B' ) redirect target and then
callRedirect() is called on this new redirect target, ending up with
unintended URL (inside RequestHandler.doRequest()).

I could resolve this issue by decoding the already encoded value before
putting it into the Map and if the key is already present in the Map, it
must create a list of the values.

Am I missing something or is this really a bug and needs to be addressed
OOTB?
If this is a bug, is proposed solution the right one?

--
Best,
Ritesh Kumar

Re: Fwd: OFBiz Sanity Test Automation

[Gil Portenseigne]

Hello,

I tend to have the same reaction as Nicolas due to a bad personal
experience with selenium (unstable, hard to maintain...), but since it
may have evolved, Taher's remark make perfect sense.

Thanks for the proposal Sanjay !

Gil

Le jeudi 23 août 2018 à 15:24:01 (+0300), Taher Alkhateeb a écrit :
> Hi Nicolas, all
> 
> Maybe before we take a decision on this, we should first investigate a
> few things. For example:
> - How fast are the tests?
> - How stable and consistent are they?
> - How much resources does it consume (memory, etc ...)
> 
> Then, based on the above information, perhaps it would be easier to
> decide if we want to include or exclude them from testIntegration. I
> agree with you in concept, these tests are more like functional tests
> and less like integration tests. However, if we find them fast, light,
> and stable enough, then I don't see a reason why not to include them.
> 
> So my recommendation is to seek the above information, and then take
> one of following decisions:
> - Include them in testIntegration
> - Include them in a separate plugin like you suggested
> - Include a new gradle task and alter the test container to have a
> separate patch for testing functional tests
> - Something else ...
> 
> My 2 cents
> On Thu, Aug 23, 2018 at 3:08 PM Nicolas Malin  
> wrote:
> >
> > Hello,
> >
> > I appreciate the work done around the sanity test, just I have a doubt
> > about integrate them to testIntegration target.
> >
> > I'm more in favor to ensure that we have unit test on service involve by
> > these sanity test, and if you want offer the possibility to run it by an
> > automation like selenium, load it as plugin.
> >
> > Nicolas
> >
> >
> > On 23/08/2018 13:08, Sanjay Yadav wrote:
> > > Yes, Taher. It will be in Selenium.
> > >
> > > Moving this email thread to the dev mailing list. Thanks!
> > >
> > > Best Regards,
> > >
> > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > > HotWax Commerce  by HotWax Systems
> > > 
> > > 80, Scheme No. 78, Indore, M.P. 452010, India
> > > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > > 
> > >
> > >
> > >
> > > -- Forwarded message -
> > > From: Taher Alkhateeb 
> > > Date: Thu, Aug 23, 2018 at 2:39 PM
> > > Subject: Re: OFBiz Sanity Test Automation
> > > To: 
> > >
> > >
> > > Hello, is this going to be implemented in Selenium? If yes then
> > > perhaps we should move this discussion to dev@ to make sure we get
> > > this right. Functional tests might be very slow and so we might need
> > > to decide whether to include these tests by default with the
> > > "testIntegration" task for example.
> > > On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki 
> > > wrote:
> > >> +1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
> > >> stable compare to trunk,
> > >>
> > >>
> > >> --
> > >> Rishi Solanki
> > >> Sr Manager, Enterprise Software Development
> > >> HotWax Systems Pvt. Ltd.
> > >> Direct: +91-9893287847
> > >> http://www.hotwaxsystems.com
> > >> www.hotwax.co
> > >>
> > >>
> > >> On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <
> > > sanjay.ya...@hotwaxsystems.com>
> > >> wrote:
> > >>
> > >>> Yes, Michael:).Thanks.
> > >>>
> > >>> Thanks, Jacques.
> > >>>
> > >>> Best Regards,
> > >>>
> > >>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > >>> HotWax Commerce  by HotWax Systems
> > >>> 
> > >>> 80, Scheme No. 78, Indore, M.P. 452010, India
> > >>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > >>> 
> > >>>
> > >>> On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl  > >>> wrote:
> > >>>
> >  +1 Sanjay,
> > 
> >  as I mentioned in
> > 
> > 
> > > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351
> >  ;-)
> > 
> >  Regards,
> > 
> >  Michael Brohl
> >  ecomify GmbH
> >  www.ecomify.de
> > 
> > 
> >  Am 22.08.18 um 08:22 schrieb Sanjay Yadav:
> > > Hello All,
> > >
> > > I am planning to automate below sanity test script. Please feel
> > > free to
> > > share your thoughts.
> > > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test
> > >
> > > Which OFBiz version I should target?
> > > Do I need to create a JIRA ticket before starting on it?
> > >
> > > Best Regards,
> > >
> > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > > HotWax Commerce  by HotWax Systems
> > > 
> > > 80, Scheme No. 78, Indore, M.P. 452010, India
> > > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > > 
> > >
> > 
> > 
> >

Re: Fwd: OFBiz Sanity Test Automation

[Nicolas Malin]

On 23/08/2018 14:24, Taher Alkhateeb wrote:

Hi Nicolas, all

Maybe before we take a decision on this, we should first investigate a
few things. For example:
- How fast are the tests?
- How stable and consistent are they?
- How much resources does it consume (memory, etc ...

Then, based on the above information, perhaps it would be easier to
decide if we want to include or exclude them from testIntegration. I
agree with you in concept, these tests are more like functional tests
and less like integration tests. However, if we find them fast, light,
and stable enough, then I don't see a reason why not to include them.
Yes you right Taher, your approach is more logical than mine where I see 
on selenium all nightmare weeks waste without gain.


I just imagine run a testIntergration and wait two hours that all is fine.

Nicolas


So my recommendation is to seek the above information, and then take
one of following decisions:
- Include them in testIntegration
- Include them in a separate plugin like you suggested
- Include a new gradle task and alter the test container to have a
separate patch for testing functional tests
- Something else ...

My 2 cents
On Thu, Aug 23, 2018 at 3:08 PM Nicolas Malin  wrote:

Hello,

I appreciate the work done around the sanity test, just I have a doubt
about integrate them to testIntegration target.

I'm more in favor to ensure that we have unit test on service involve by
these sanity test, and if you want offer the possibility to run it by an
automation like selenium, load it as plugin.

Nicolas


On 23/08/2018 13:08, Sanjay Yadav wrote:

Yes, Taher. It will be in Selenium.

Moving this email thread to the dev mailing list. Thanks!

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav




-- Forwarded message -
From: Taher Alkhateeb 
Date: Thu, Aug 23, 2018 at 2:39 PM
Subject: Re: OFBiz Sanity Test Automation
To: 


Hello, is this going to be implemented in Selenium? If yes then
perhaps we should move this discussion to dev@ to make sure we get
this right. Functional tests might be very slow and so we might need
to decide whether to include these tests by default with the
"testIntegration" task for example.
On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki 
wrote:

+1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
stable compare to trunk,


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <

sanjay.ya...@hotwaxsystems.com>

wrote:


Yes, Michael:).Thanks.

Thanks, Jacques.

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav


On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl 
+1 Sanjay,

as I mentioned in



https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351

;-)

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 22.08.18 um 08:22 schrieb Sanjay Yadav:

Hello All,

I am planning to automate below sanity test script. Please feel

free to

share your thoughts.
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test

Which OFBiz version I should target?
Do I need to create a JIRA ticket before starting on it?

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav

Re: Fwd: OFBiz Sanity Test Automation

[Taher Alkhateeb]

Hi Nicolas, all

Maybe before we take a decision on this, we should first investigate a
few things. For example:
- How fast are the tests?
- How stable and consistent are they?
- How much resources does it consume (memory, etc ...)

Then, based on the above information, perhaps it would be easier to
decide if we want to include or exclude them from testIntegration. I
agree with you in concept, these tests are more like functional tests
and less like integration tests. However, if we find them fast, light,
and stable enough, then I don't see a reason why not to include them.

So my recommendation is to seek the above information, and then take
one of following decisions:
- Include them in testIntegration
- Include them in a separate plugin like you suggested
- Include a new gradle task and alter the test container to have a
separate patch for testing functional tests
- Something else ...

My 2 cents
On Thu, Aug 23, 2018 at 3:08 PM Nicolas Malin  wrote:
>
> Hello,
>
> I appreciate the work done around the sanity test, just I have a doubt
> about integrate them to testIntegration target.
>
> I'm more in favor to ensure that we have unit test on service involve by
> these sanity test, and if you want offer the possibility to run it by an
> automation like selenium, load it as plugin.
>
> Nicolas
>
>
> On 23/08/2018 13:08, Sanjay Yadav wrote:
> > Yes, Taher. It will be in Selenium.
> >
> > Moving this email thread to the dev mailing list. Thanks!
> >
> > Best Regards,
> >
> > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > HotWax Commerce  by HotWax Systems
> > 
> > 80, Scheme No. 78, Indore, M.P. 452010, India
> > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > 
> >
> >
> >
> > -- Forwarded message -
> > From: Taher Alkhateeb 
> > Date: Thu, Aug 23, 2018 at 2:39 PM
> > Subject: Re: OFBiz Sanity Test Automation
> > To: 
> >
> >
> > Hello, is this going to be implemented in Selenium? If yes then
> > perhaps we should move this discussion to dev@ to make sure we get
> > this right. Functional tests might be very slow and so we might need
> > to decide whether to include these tests by default with the
> > "testIntegration" task for example.
> > On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki 
> > wrote:
> >> +1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
> >> stable compare to trunk,
> >>
> >>
> >> --
> >> Rishi Solanki
> >> Sr Manager, Enterprise Software Development
> >> HotWax Systems Pvt. Ltd.
> >> Direct: +91-9893287847
> >> http://www.hotwaxsystems.com
> >> www.hotwax.co
> >>
> >>
> >> On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <
> > sanjay.ya...@hotwaxsystems.com>
> >> wrote:
> >>
> >>> Yes, Michael:).Thanks.
> >>>
> >>> Thanks, Jacques.
> >>>
> >>> Best Regards,
> >>>
> >>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> >>> HotWax Commerce  by HotWax Systems
> >>> 
> >>> 80, Scheme No. 78, Indore, M.P. 452010, India
> >>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> >>> 
> >>>
> >>> On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl  >>> wrote:
> >>>
>  +1 Sanjay,
> 
>  as I mentioned in
> 
> 
> > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351
>  ;-)
> 
>  Regards,
> 
>  Michael Brohl
>  ecomify GmbH
>  www.ecomify.de
> 
> 
>  Am 22.08.18 um 08:22 schrieb Sanjay Yadav:
> > Hello All,
> >
> > I am planning to automate below sanity test script. Please feel
> > free to
> > share your thoughts.
> > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test
> >
> > Which OFBiz version I should target?
> > Do I need to create a JIRA ticket before starting on it?
> >
> > Best Regards,
> >
> > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > HotWax Commerce  by HotWax Systems
> > 
> > 80, Scheme No. 78, Indore, M.P. 452010, India
> > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > 
> >
> 
> 
>

Re: Fwd: OFBiz Sanity Test Automation

[Jacques Le Roux]

That makes sense Nicolas,

Jacques


Le 23/08/2018 à 14:08, Nicolas Malin a écrit :

Hello,

I appreciate the work done around the sanity test, just I have a doubt about 
integrate them to testIntegration target.

I'm more in favor to ensure that we have unit test on service involve by these sanity test, and if you want offer the possibility to run it by an 
automation like selenium, load it as plugin.


Nicolas


On 23/08/2018 13:08, Sanjay Yadav wrote:

Yes, Taher. It will be in Selenium.

Moving this email thread to the dev mailing list. Thanks!

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav




-- Forwarded message -
From: Taher Alkhateeb 
Date: Thu, Aug 23, 2018 at 2:39 PM
Subject: Re: OFBiz Sanity Test Automation
To: 


Hello, is this going to be implemented in Selenium? If yes then
perhaps we should move this discussion to dev@ to make sure we get
this right. Functional tests might be very slow and so we might need
to decide whether to include these tests by default with the
"testIntegration" task for example.
On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki 
wrote:

+1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
stable compare to trunk,


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <

sanjay.ya...@hotwaxsystems.com>

wrote:


Yes, Michael:).Thanks.

Thanks, Jacques.

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav


On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl 
+1 Sanjay,

as I mentioned in



https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351

;-)

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 22.08.18 um 08:22 schrieb Sanjay Yadav:

Hello All,

I am planning to automate below sanity test script. Please feel

free to

share your thoughts.
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test

Which OFBiz version I should target?
Do I need to create a JIRA ticket before starting on it?

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav

Re: Fwd: OFBiz Sanity Test Automation

[Nicolas Malin]

Hello,

I appreciate the work done around the sanity test, just I have a doubt 
about integrate them to testIntegration target.


I'm more in favor to ensure that we have unit test on service involve by 
these sanity test, and if you want offer the possibility to run it by an 
automation like selenium, load it as plugin.


Nicolas


On 23/08/2018 13:08, Sanjay Yadav wrote:

Yes, Taher. It will be in Selenium.

Moving this email thread to the dev mailing list. Thanks!

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav




-- Forwarded message -
From: Taher Alkhateeb 
Date: Thu, Aug 23, 2018 at 2:39 PM
Subject: Re: OFBiz Sanity Test Automation
To: 


Hello, is this going to be implemented in Selenium? If yes then
perhaps we should move this discussion to dev@ to make sure we get
this right. Functional tests might be very slow and so we might need
to decide whether to include these tests by default with the
"testIntegration" task for example.
On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki 
wrote:

+1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
stable compare to trunk,


--
Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co


On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <

sanjay.ya...@hotwaxsystems.com>

wrote:


Yes, Michael:).Thanks.

Thanks, Jacques.

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav


On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl 
+1 Sanjay,

as I mentioned in



https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351

;-)

Regards,

Michael Brohl
ecomify GmbH
www.ecomify.de


Am 22.08.18 um 08:22 schrieb Sanjay Yadav:

Hello All,

I am planning to automate below sanity test script. Please feel

free to

share your thoughts.
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test

Which OFBiz version I should target?
Do I need to create a JIRA ticket before starting on it?

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav

Re: Old demo restarted

[Taher Alkhateeb]

I'm not sure why you're hanging this on me, but sure I'm willing to
help. Can I get some information on how the crashes are happening and
how you're getting notified, and I will take it from there.
On Thu, Aug 23, 2018 at 2:29 PM Jacques Le Roux
 wrote:
>
> Yes we can, will you?
>
> Jacques
>
>
> Le 22/08/2018 à 19:29, Taher Alkhateeb a écrit :
> > Well, we can ask Infra for help, we can check available solutions, we
> > can create a CRON script that checks things periodically, there are
> > multiple ways to go about this.
> >
> > My personal preference is for a simple CRON script that takes care of this.
> > On Wed, Aug 22, 2018 at 8:25 PM Jacques Le Roux
> >  wrote:
> >> So you prefer that I'm the only one to take care of the demos and act on 
> >> alerts?
> >>
> >> Jacques
> >>
> >>
> >> Le 22/08/2018 à 18:53, Taher Alkhateeb a écrit :
> >>> I prefer not to include any tools without proper analysis and
> >>> discussion first. Less is more.
> >>> On Wed, Aug 22, 2018 at 5:31 PM Jacques Le Roux
> >>>  wrote:
>  Hi,
> 
>  Should I consider no answers as a lazy consensus and should I send 
>  (rare) alerts to this ML?
> 
>  Without any answers I'll consider it a lazy consensus in 2 days.
> 
>  Jacques
> 
> 
>  Le 17/08/2018 à 12:22, Jacques Le Roux a écrit :
> > Le 13/08/2018 à 18:21, Jacques Le Roux a écrit :
> >> Le 12/08/2018 à 11:26, Jacques Le Roux a écrit :
> >>> Hi,
> >>>
> >>> This morning I noticed the old demo was down and restarted it after 
> >>> cleaning things.
> >>>
> >>> Previously (still some weeks ago) Daniel Gruno's (from Infra team) 
> >>> company was kindly providing us a mean to monitor our demos but it 
> >>> seems that
> >>> this mean is no longer available
> >>>
> >>> I have asked about it and will let you know about it...
> >>>
> >>> Have a good weekend
> >>>
> >>> Jadques
> >>>
> >> Daniel confirmed it's terminated. I turned to UpTimeRobot which is 
> >> free and seems as well good :)
> >>
> >> Jacques
> >>
> >>
> > This thread started on user ML but I don't want to bother everyone with 
> > technical details.
> >
> > I used my own @a.o email to create the monitoring. UpTimeRobot is 
> > certainly the best free monitoring tool, with some possibilities others 
> > don't give.
> >
> > But the free version has an inconvenient. You can only check every 5 
> > mins and when the instances restart it takes more than 5 mins each.
> >
> > So everyday I get a down an up alerts for each. I have switched to 
> > montastic.com.
> >
> > I was wondering if we don't want to share that here.
> > We could then have these alerts here and any committer, using the info 
> > in https://svn.apache.org/repos/asf/ofbiz/tools/demo-backup could 
> > handle issues.
> >
> > It seems better, isn'it?
> >
> > Jacques
> >
> >
>

Re: Old demo restarted

[Jacques Le Roux]

Yes we can, will you?

Jacques


Le 22/08/2018 à 19:29, Taher Alkhateeb a écrit :

Well, we can ask Infra for help, we can check available solutions, we
can create a CRON script that checks things periodically, there are
multiple ways to go about this.

My personal preference is for a simple CRON script that takes care of this.
On Wed, Aug 22, 2018 at 8:25 PM Jacques Le Roux
 wrote:

So you prefer that I'm the only one to take care of the demos and act on alerts?

Jacques


Le 22/08/2018 à 18:53, Taher Alkhateeb a écrit :

I prefer not to include any tools without proper analysis and
discussion first. Less is more.
On Wed, Aug 22, 2018 at 5:31 PM Jacques Le Roux
 wrote:

Hi,

Should I consider no answers as a lazy consensus and should I send (rare) 
alerts to this ML?

Without any answers I'll consider it a lazy consensus in 2 days.

Jacques


Le 17/08/2018 à 12:22, Jacques Le Roux a écrit :

Le 13/08/2018 à 18:21, Jacques Le Roux a écrit :

Le 12/08/2018 à 11:26, Jacques Le Roux a écrit :

Hi,

This morning I noticed the old demo was down and restarted it after cleaning 
things.

Previously (still some weeks ago) Daniel Gruno's (from Infra team) company was 
kindly providing us a mean to monitor our demos but it seems that
this mean is no longer available

I have asked about it and will let you know about it...

Have a good weekend

Jadques


Daniel confirmed it's terminated. I turned to UpTimeRobot which is free and 
seems as well good :)

Jacques



This thread started on user ML but I don't want to bother everyone with 
technical details.

I used my own @a.o email to create the monitoring. UpTimeRobot is certainly the 
best free monitoring tool, with some possibilities others don't give.

But the free version has an inconvenient. You can only check every 5 mins and 
when the instances restart it takes more than 5 mins each.

So everyday I get a down an up alerts for each. I have switched to 
montastic.com.

I was wondering if we don't want to share that here.
We could then have these alerts here and any committer, using the info in 
https://svn.apache.org/repos/asf/ofbiz/tools/demo-backup could handle issues.

It seems better, isn'it?

Jacques

Fwd: OFBiz Sanity Test Automation

[Sanjay Yadav]

Yes, Taher. It will be in Selenium.

Moving this email thread to the dev mailing list. Thanks!

Best Regards,

*Sanjay Yadav* | Manager, Enterprise Quality Assurance
HotWax Commerce  by HotWax Systems

80, Scheme No. 78, Indore, M.P. 452010, India
Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav




-- Forwarded message -
From: Taher Alkhateeb 
Date: Thu, Aug 23, 2018 at 2:39 PM
Subject: Re: OFBiz Sanity Test Automation
To: 


Hello, is this going to be implemented in Selenium? If yes then
perhaps we should move this discussion to dev@ to make sure we get
this right. Functional tests might be very slow and so we might need
to decide whether to include these tests by default with the
"testIntegration" task for example.
On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki 
wrote:
>
> +1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
> stable compare to trunk,
>
>
> --
> Rishi Solanki
> Sr Manager, Enterprise Software Development
> HotWax Systems Pvt. Ltd.
> Direct: +91-9893287847
> http://www.hotwaxsystems.com
> www.hotwax.co
>
>
> On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <
sanjay.ya...@hotwaxsystems.com>
> wrote:
>
> > Yes, Michael:).Thanks.
> >
> > Thanks, Jacques.
> >
> > Best Regards,
> >
> > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > HotWax Commerce  by HotWax Systems
> > 
> > 80, Scheme No. 78, Indore, M.P. 452010, India
> > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > 
> >
> > On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl 
> > wrote:
> >
> > > +1 Sanjay,
> > >
> > > as I mentioned in
> > >
> > >
> >
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351
> > > ;-)
> > >
> > > Regards,
> > >
> > > Michael Brohl
> > > ecomify GmbH
> > > www.ecomify.de
> > >
> > >
> > > Am 22.08.18 um 08:22 schrieb Sanjay Yadav:
> > > > Hello All,
> > > >
> > > > I am planning to automate below sanity test script. Please feel
free to
> > > > share your thoughts.
> > > > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test
> > > >
> > > > Which OFBiz version I should target?
> > > > Do I need to create a JIRA ticket before starting on it?
> > > >
> > > > Best Regards,
> > > >
> > > > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > > > HotWax Commerce  by HotWax Systems
> > > > 
> > > > 80, Scheme No. 78, Indore, M.P. 452010, India
> > > > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > > > 
> > > >
> > >
> > >
> > >
> >

Re: [PROPOSITION] Demos: replace old by trunk framework only

[Nicolas Malin]

Hello

This thread about a "simple" problem highlights the difficulty for a 
plugin to extend the framework on different elements. Since many years I 
search different solution to how surcharge correctly the framework and 
it was not easy :)


in line

On 22/08/2018 18:52, Taher Alkhateeb wrote:

Hi Julien,

Good ideas, and this is a good start to try and tackle the problem.
Whatever we do, we must not keep "ghosts" or things that are waiting
for specific outside plugins. The framework should _never_ know
anything about the outside. This is a fundamental architectural
concept in any layered software system.
Absolutely right, I knew a ghost history with addons that changed source 
code base to load plugin's specificsinstead of understandingwhy we can't 
surcharge the framework :)

I'm ready to help if needed, and I think there are many ways to fix
this problem. As you said one way is to extend webapps, another is
perhaps to optionally include freemarker templates that match a
certain pattern if they exist. In other words, you provide a generic
plugin-like mechanism for enhancing the system, but the direction is
_always_ from the outside to the inside, and not the other way around.
And that is what I mean with a root-cause analysis and solutions.


Maybe I have two different solutions, based on theidea to usethemodel 
pattern toload all plugin surcharge at the ofbiz start like services and 
entities
* The first, load all screen engine modelsin memory at start, but I 
fearthatit would be too expensive on memory (load unnecessary screens)
* The second, create an'extend model' who permit to surcharge all screen 
engine model elements,andload it on ofbiz start and when we load a 
model, we check on extend model if the element have surcharge to apply 
just before settingit as immutable and put it in cache.


example :
name='ViewPartyGroup'>


target="/myplugin/control/viewprofile" target-type="inter-app" 
target-window="blank_">






With this, we would have a plugin that can surcharge a screen, a form, a 
menu without changingnothing in the framework, identify clearly what 
change has been made and a failure support when the extend can't be applied.


Currently I didn't found a solution to surcharge ftl.

If you feel that it's a good way to explore, I will start a new thread.

Nicolas

So I'm all for a generic solution, but not for hard-wiring any
component or any link that is specific to a certain component. That is
definitely a code smell and beats the entire purpose of splitting the
repositories in the first place. [...]