[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510685#comment-14510685 ] Adrian Crum commented on OFBIZ-6291: Mini-language is a scripting language. One of the nice things about scripting languages is you can compare things like decimal values without worrying about the underlying implementation. That is what the current implementation does: 2 == 2.0 == 2.00. If we were to compare BigDecimal precision, then we lose the scripting abstraction, PLUS pretty much everything that uses Mini-language will break. If you need to compare BigDecimal precision, then you can use a scriptlet: groovy:fooBigDecimal.equals(barBigDecimal). Update code to check for types rather than throw ClassCastException --- Key: OFBIZ-6291 URL: https://issues.apache.org/jira/browse/OFBIZ-6291 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Gareth Carter Priority: Trivial Attachments: LocalizedConverters.patch, minilang_compare.patch, minilang_compare_r1675655.patch framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java framework/base/src/org/ofbiz/base/util/ObjectType.java framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java all throw ClassCastExceptions and are ignored instead of checking types This caused issues in debugging when adding a ClassCastException breakpoint -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6291) Update code to check for types rather than throw ClassCastException
[ https://issues.apache.org/jira/browse/OFBIZ-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508680#comment-14508680 ] Adrian Crum commented on OFBIZ-6291: As the code comment states, the current comparison behavior is by design. It is not a bug that needs to be fixed. Update code to check for types rather than throw ClassCastException --- Key: OFBIZ-6291 URL: https://issues.apache.org/jira/browse/OFBIZ-6291 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Gareth Carter Priority: Trivial Attachments: LocalizedConverters.patch, minilang_compare.patch framework/minilang/src/org/ofbiz/minilang/method/conditional/Compare.java framework/base/src/org/ofbiz/base/util/ObjectType.java framework/minilang/src/org/ofbiz/minilang/MiniLangUtil.java all throw ClassCastExceptions and are ignored instead of checking types This caused issues in debugging when adding a ClassCastException breakpoint -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6273) Remove from trunk the deprecated code if deprecated before December 2014
[ https://issues.apache.org/jira/browse/OFBIZ-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14506638#comment-14506638 ] Adrian Crum commented on OFBIZ-6273: I can help in 2 weeks. Remove from trunk the deprecated code if deprecated before December 2014 Key: OFBIZ-6273 URL: https://issues.apache.org/jira/browse/OFBIZ-6273 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Jacopo Cappellato The code that has been deprecated before December 2014 will be released in the releases of the 14.12 branch: in this way users will be notified about deprecated methods/code. For this reason we can proceed and remove all the deprecated code from trunk, deprecated before December 2014. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6270) base/json/JSON has been removed, with no deprecation window
[ https://issues.apache.org/jira/browse/OFBIZ-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504656#comment-14504656 ] Adrian Crum commented on OFBIZ-6270: I agree that deprecating things before they are removed is a best practice. At the same time, this particular change was easy to fix in our client code. In most cases it only took a SR to change package names, and in others the difference was obvious and easy to fix. base/json/JSON has been removed, with no deprecation window --- Key: OFBIZ-6270 URL: https://issues.apache.org/jira/browse/OFBIZ-6270 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 12.04.04 Reporter: Adam Heath Assignee: Adam Heath Priority: Critical The antlr-based json parser(at org.ofbiz.base.json.JSON.cc) was removed last October(2014-10-27). However, no backwards-compatible class was left in place, with a proper @Deprecation tag applied. The proper approach should have been to leave the class in place, adding @Deprecation, and leaving the json-lib.jar in place. Then, after one successful release, removing the actual code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504710#comment-14504710 ] Adrian Crum commented on OFBIZ-6268: Let's back up for a second. I understand the changes you made and why you made them. The problem is with your implementation - you caused the same files to be parsed twice. I am merely removing the double parsing, your other changes (and your intent) are intact. It would help if you applied the patch and actually looked at the code. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504688#comment-14504688 ] Adrian Crum commented on OFBIZ-6268: The start component has many dependencies on base - there is no way to avoid that. Keep in mind that start used to be IN base. No changes have been made to the class loader tree. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6268) Improve Start.java Component Loading
[
https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504780#comment-14504780
]
Adrian Crum commented on OFBIZ-6268:
Btw, in the current trunk, if I disable the specialpurpose folder
{code}
component-loader xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation=http://ofbiz.apache.org/dtds/component-loader.xsd;
load-components parent-directory=framework/
load-components parent-directory=themes/
load-components parent-directory=applications/
!--
load-components parent-directory=specialpurpose/
--
load-components parent-directory=hot-deploy/
/component-loader
{code}
the specialpurpose component class paths are loaded anyway.
Improve Start.java Component Loading
Key: OFBIZ-6268
URL: https://issues.apache.org/jira/browse/OFBIZ-6268
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Upcoming Branch
Reporter: Adrian Crum
Priority: Minor
Attachments: OFBIZ-6268.patch
The current code for loading components parses configuration files twice.
This issue is intended for review of code improvements.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-6268) Improve Start.java Component Loading
Adrian Crum created OFBIZ-6268: -- Summary: Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6268) Improve Start.java Component Loading
[ https://issues.apache.org/jira/browse/OFBIZ-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6268: --- Attachment: OFBIZ-6268.patch The attached patch is the basic redesign. The instrumentation is not working, so it is commented out. I will continue working on that. The existing classes have been reworked slightly to provide better separation of concerns. Synchronization code has been added to ClassPath.java in preparation for multi-threaded component loading. I will add that feature after this review. Improve Start.java Component Loading Key: OFBIZ-6268 URL: https://issues.apache.org/jira/browse/OFBIZ-6268 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor Attachments: OFBIZ-6268.patch The current code for loading components parses configuration files twice. This issue is intended for review of code improvements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6259) ofbiz looking for web.xml in wrong place
[ https://issues.apache.org/jira/browse/OFBIZ-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6259: -- Assignee: Adrian Crum ofbiz looking for web.xml in wrong place Key: OFBIZ-6259 URL: https://issues.apache.org/jira/browse/OFBIZ-6259 Project: OFBiz Issue Type: Bug Reporter: Wai Assignee: Adrian Crum Attachments: OFBIZ-6259.patch start ofbiz ...console output... 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [bizznesstime] 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [images] 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [webtools] Exception thrown while loading locationresolvers.properties: java.lang.IllegalStateException: Exception thrown while reading debug.properties: java.lang.IllegalStateException: locationresolvers.properties not found 2015-04-17 14:04:24,960 |catalina-startup-2 |CatalinaContainer |I| file:zzz/workspace/ofbiz/applications/content/webapp/content/images/WEB-INF/web.xml not found. 2015-04-17 14:04:25,351 |main |SSLImpl |I| SSLImpl loaded; using custom ServerSocketFactory 2015-04-17 14:04:25,859 |0.0.0.0-startStop-1 |ServiceDispatcher |I| Registering dispatcher: ebay 20 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6259) ofbiz looking for web.xml in wrong place
[ https://issues.apache.org/jira/browse/OFBIZ-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6259. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1674451. Thanks! ofbiz looking for web.xml in wrong place Key: OFBIZ-6259 URL: https://issues.apache.org/jira/browse/OFBIZ-6259 Project: OFBiz Issue Type: Bug Reporter: Wai Assignee: Adrian Crum Fix For: Upcoming Branch Attachments: OFBIZ-6259.patch start ofbiz ...console output... 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [bizznesstime] 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [images] 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [webtools] Exception thrown while loading locationresolvers.properties: java.lang.IllegalStateException: Exception thrown while reading debug.properties: java.lang.IllegalStateException: locationresolvers.properties not found 2015-04-17 14:04:24,960 |catalina-startup-2 |CatalinaContainer |I| file:zzz/workspace/ofbiz/applications/content/webapp/content/images/WEB-INF/web.xml not found. 2015-04-17 14:04:25,351 |main |SSLImpl |I| SSLImpl loaded; using custom ServerSocketFactory 2015-04-17 14:04:25,859 |0.0.0.0-startStop-1 |ServiceDispatcher |I| Registering dispatcher: ebay 20 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6261) locationresolvers.properties is missing
[ https://issues.apache.org/jira/browse/OFBIZ-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14501178#comment-14501178 ] Adrian Crum commented on OFBIZ-6261: Thank you for working on this, but there is a problem with your patch. The UtilProperties.createProperties() JavaDoc says: This method is intended for low-level framework classes that need to read properties files before OFBiz has been fully initialized. Your patch introduces a Debug.logWarning method call in low-level code where logging has not been initialized. I will fix this myself. Thank you for the bug report and leading me to the cause of the problem. locationresolvers.properties is missing --- Key: OFBIZ-6261 URL: https://issues.apache.org/jira/browse/OFBIZ-6261 Project: OFBiz Issue Type: Bug Reporter: Wai Attachments: OFBIZ-6261.patch during ofbiz startup ...console output... 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [bluelight] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [bizznesstime] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [images] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [webtools] Exception thrown while loading locationresolvers.properties: java.lang.IllegalStateException: Exception thrown while reading debug.properties: java.lang.IllegalStateException: locationresolvers.properties not found 2015-04-17 17:58:18,800 |main |SSLImpl |I| SSLImpl loaded; using custom ServerSocketFactory 2015-04-17 17:58:19,045 |0.0.0.0-startStop-1 |ServiceDispatcher |I| Registering dispatcher: ebay 2015-04-17 17:58:19,045 |0.0.0.0-startStop-1 |ServiceContainer |I| Created new dispatcher: ebay -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6261) locationresolvers.properties is missing
[ https://issues.apache.org/jira/browse/OFBIZ-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6261: -- Assignee: Adrian Crum locationresolvers.properties is missing --- Key: OFBIZ-6261 URL: https://issues.apache.org/jira/browse/OFBIZ-6261 Project: OFBiz Issue Type: Bug Reporter: Wai Assignee: Adrian Crum Attachments: OFBIZ-6261.patch during ofbiz startup ...console output... 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [bluelight] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [bizznesstime] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [images] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [webtools] Exception thrown while loading locationresolvers.properties: java.lang.IllegalStateException: Exception thrown while reading debug.properties: java.lang.IllegalStateException: locationresolvers.properties not found 2015-04-17 17:58:18,800 |main |SSLImpl |I| SSLImpl loaded; using custom ServerSocketFactory 2015-04-17 17:58:19,045 |0.0.0.0-startStop-1 |ServiceDispatcher |I| Registering dispatcher: ebay 2015-04-17 17:58:19,045 |0.0.0.0-startStop-1 |ServiceContainer |I| Created new dispatcher: ebay -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6261) locationresolvers.properties is missing
[ https://issues.apache.org/jira/browse/OFBIZ-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6261. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1674453. locationresolvers.properties is missing --- Key: OFBIZ-6261 URL: https://issues.apache.org/jira/browse/OFBIZ-6261 Project: OFBiz Issue Type: Bug Reporter: Wai Assignee: Adrian Crum Fix For: Upcoming Branch Attachments: OFBIZ-6261.patch during ofbiz startup ...console output... 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [bluelight] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [bizznesstime] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [images] 2015-04-17 17:58:18,166 |main |CatalinaContainer |I| Creating context [webtools] Exception thrown while loading locationresolvers.properties: java.lang.IllegalStateException: Exception thrown while reading debug.properties: java.lang.IllegalStateException: locationresolvers.properties not found 2015-04-17 17:58:18,800 |main |SSLImpl |I| SSLImpl loaded; using custom ServerSocketFactory 2015-04-17 17:58:19,045 |0.0.0.0-startStop-1 |ServiceDispatcher |I| Registering dispatcher: ebay 2015-04-17 17:58:19,045 |0.0.0.0-startStop-1 |ServiceContainer |I| Created new dispatcher: ebay -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5948) Form Widget doesn't use thead or tbody with list forms
[ https://issues.apache.org/jira/browse/OFBIZ-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-5948: -- Assignee: (was: Adrian Crum) Form Widget doesn't use thead or tbody with list forms -- Key: OFBIZ-5948 URL: https://issues.apache.org/jira/browse/OFBIZ-5948 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Chris Howe Priority: Minor Attachments: css.patch, renderTheadTbodyId.patch The form widget for type list uses tr with a class of header-row and no thead element. There are 23 instances of the thead element in ftl files. The form widget also does not use tbody element. There are 38 instances of it being used in ftl files. CSS to utilize the '.header row th' selector in addition to the '.header-row td' selector in the flat_grey theme is also added. Also, the htmlFormMacroLibrary wasn't adding the id element for the table. The attached patch creates this for the HtmlFormRenderer and the MacroFormRenderer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5608) Dates Displaying Incorrectly With Negative Offest Timezones.
[ https://issues.apache.org/jira/browse/OFBIZ-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-5608: -- Assignee: (was: Adrian Crum) Dates Displaying Incorrectly With Negative Offest Timezones. Key: OFBIZ-5608 URL: https://issues.apache.org/jira/browse/OFBIZ-5608 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Rupert Howell Priority: Minor Attachments: ObjectTypeTests.patch, dates.patch, dates_1589040.patch Dates are displaying incorrectly when negative offset (relative to UTC) are applied by the users settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6259) ofbiz looking for web.xml in wrong place. missing locationresolvers.properties
[ https://issues.apache.org/jira/browse/OFBIZ-6259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500549#comment-14500549 ] Adrian Crum commented on OFBIZ-6259: I can't reproduce the locationresolvers.properties problem. The warning about the missing web.xml file is not related to the previous message. ofbiz looking for web.xml in wrong place. missing locationresolvers.properties -- Key: OFBIZ-6259 URL: https://issues.apache.org/jira/browse/OFBIZ-6259 Project: OFBiz Issue Type: Bug Reporter: Wai start ofbiz ...console output... 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [bizznesstime] 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [images] 2015-04-17 14:04:24,323 |main |CatalinaContainer |I| Creating context [webtools] Exception thrown while loading locationresolvers.properties: java.lang.IllegalStateException: Exception thrown while reading debug.properties: java.lang.IllegalStateException: locationresolvers.properties not found 2015-04-17 14:04:24,960 |catalina-startup-2 |CatalinaContainer |I| file:zzz/workspace/ofbiz/applications/content/webapp/content/images/WEB-INF/web.xml not found. 2015-04-17 14:04:25,351 |main |SSLImpl |I| SSLImpl loaded; using custom ServerSocketFactory 2015-04-17 14:04:25,859 |0.0.0.0-startStop-1 |ServiceDispatcher |I| Registering dispatcher: ebay 20 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498033#comment-14498033 ] Adrian Crum commented on OFBIZ-6217: Second patch committed in rev 1674064. Taher, Some parts of your patch would not apply, so I skipped those files. Also, you removed a finally block from DatabaseUtil.java, so I skipped that file. Removing a finally block is not an acceptable means to fix a compiler warning. There was one change that included a tab character. Be careful to use only spaces for indentation. I replaced the tab character with spaces. fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch, warnings_patch_2.patch, warnings_patch_2.patch Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly. I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6253) Fix result-to-field doc for call-simple-method in simple-methods-v2.xsd
[ https://issues.apache.org/jira/browse/OFBIZ-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14496584#comment-14496584 ] Adrian Crum commented on OFBIZ-6253: Do you need to revert the wiki also? Fix result-to-field doc for call-simple-method in simple-methods-v2.xsd --- Key: OFBIZ-6253 URL: https://issues.apache.org/jira/browse/OFBIZ-6253 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Jacques Le Roux Assignee: Jacques Le Roux A wrong assertion in documentation: result-to-field can only be used with inline scope not function scope Fixed in trunk r1673764 R14.12 r1673765 R13.07 r1673766 R12.04 r1673767 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6218) Unit tests throw exception in DBCP
[ https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493262#comment-14493262 ] Adrian Crum commented on OFBIZ-6218: The tests pass on my computer also. Thank you for working on this! Unit tests throw exception in DBCP -- Key: OFBIZ-6218 URL: https://issues.apache.org/jira/browse/OFBIZ-6218 Project: OFBiz Issue Type: Bug Reporter: Adrian Crum Attachments: OFBIZ-6218.patch Details in comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6218) Unit tests throw exception in DBCP
[ https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491384#comment-14491384 ] Adrian Crum commented on OFBIZ-6218: Pierre, Your errors are not related to this issue. You are seeing those log entries because EntityListIterator is being used improperly in your Groovy code. Unit tests throw exception in DBCP -- Key: OFBIZ-6218 URL: https://issues.apache.org/jira/browse/OFBIZ-6218 Project: OFBiz Issue Type: Bug Reporter: Adrian Crum Details in comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens
[
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-6235:
---
Priority: Minor (was: Major)
Have FlexibleStringExpander applied to scripts in screens
-
Key: OFBIZ-6235
URL: https://issues.apache.org/jira/browse/OFBIZ-6235
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Priority: Minor
Currently the FlexibleStringExpander is applied when a ${value} is included
in various elements in screens and forms.
However it isn't possible to use a ${value} in the name or location of a
script. Having this would make screens and forms more flexible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens
[
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-6235:
---
Issue Type: Improvement (was: Bug)
Have FlexibleStringExpander applied to scripts in screens
-
Key: OFBIZ-6235
URL: https://issues.apache.org/jira/browse/OFBIZ-6235
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Currently the FlexibleStringExpander is applied when a ${value} is included
in various elements in screens and forms.
However it isn't possible to use a ${value} in the name or location of a
script. Having this would make screens and forms more flexible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14488322#comment-14488322 ] Adrian Crum commented on OFBIZ-6217: I will look at this after ApacheCon. fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch, warnings_patch_2.patch, warnings_patch_2.patch Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly. I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6235) Have FlexibleStringExpander applied to scripts in screens
[
https://issues.apache.org/jira/browse/OFBIZ-6235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14486848#comment-14486848
]
Adrian Crum commented on OFBIZ-6235:
A feature like that could be used as an attack vector.
Have FlexibleStringExpander applied to scripts in screens
-
Key: OFBIZ-6235
URL: https://issues.apache.org/jira/browse/OFBIZ-6235
Project: OFBiz
Issue Type: Improvement
Components: framework
Affects Versions: Trunk
Reporter: Pierre Smits
Priority: Minor
Currently the FlexibleStringExpander is applied when a ${value} is included
in various elements in screens and forms.
However it isn't possible to use a ${value} in the name or location of a
script. Having this would make screens and forms more flexible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6228) The role permission function fail
[ https://issues.apache.org/jira/browse/OFBIZ-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14394131#comment-14394131 ] Adrian Crum commented on OFBIZ-6228: That feature has been deprecated. Use a permission service instead. There are many examples in the project. The role permission function fail - Key: OFBIZ-6228 URL: https://issues.apache.org/jira/browse/OFBIZ-6228 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Jiancai Hao Labels: permission, role When set a service by role permission like that: service name=learningCallingServiceOneWithPermission engine=java location=org.ofbiz.learning.learning.LearningServices invoke=callingServiceOne descriptionFirst Service Called From The Controller/description required-permissions join-type=OR !-- check-permission permission=LEARN_VIEW / -- check-role-member role-type=CUSTOMER/ /required-permissions implements service=learningInterface / /service ... and then assign the partyId for example 10010 with the role of CUSTOMER. Login using this party and call the service learningCallingServiceOneWithPermission, the party don't get the permission. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6222) Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter
[ https://issues.apache.org/jira/browse/OFBIZ-6222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385174#comment-14385174 ] Adrian Crum commented on OFBIZ-6222: That is a good idea! We had a similar problem with the screens that set the user's locale and time zone. Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter Key: OFBIZ-6222 URL: https://issues.apache.org/jira/browse/OFBIZ-6222 Project: OFBiz Issue Type: Bug Components: framework Reporter: Arun Patidar Priority: Critical Fix For: Release Branch 14.12, Trunk Change the field name 'tenantId' to 'userTenantId' from login page and ContextFilter While using webtools for tenantGroup and searching with a tenantId then its interpreting it as tenantId in request and switching delegator for it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6217) fix warnings in trunk on java source code
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385222#comment-14385222
]
Adrian Crum edited comment on OFBIZ-6217 at 3/28/15 10:34 AM:
--
Taher,
Thank you for working on this! One thing has me confused: You make use of the
UtilGenerics methods in some places, but not in others - where you add a
@SuppressWarnings annotation instead. Why not always use UtilGenerics?
Example from your patch:
{code}
@SuppressWarnings(rawtypes)
public void testJSONToMap() throws Exception {
ConverterJSON, Map converter = Converters.getConverter(JSON.class,
Map.class);
MapString,String map, convertedMap;
map = new HashMapString,String();
map.put(field1, value1);
JSON json = JSON.from(map);
convertedMap = UtilGenerics.toMap(converter.convert(json));
assertEquals(JSON to Map, map, convertedMap);
}
{code}
The @SuppressWarnings annotation is not needed:
{code}
public void testJSONToMap() throws Exception {
ConverterJSON, MapString,String converter =
UtilGenerics.cast(Converters.getConverter(JSON.class, Map.class));
MapString,String map, convertedMap;
map = new HashMapString,String();
map.put(field1, value1);
JSON json = JSON.from(map);
convertedMap = UtilGenerics.toMap(converter.convert(json));
assertEquals(JSON to Map, map, convertedMap);
}
{code}
was (Author: adri...@hlmksw.com):
Taher,
Thank you for working on this! One thing has me confused: You make use of the
UtilGenerics methods in some places, but not in others - where you add a
@SuppressWarnings annotation instead. Why not always use UtilGenerics?
Example from your patch:
{code}
@SuppressWarnings(rawtypes)
public void testJSONToMap() throws Exception {
ConverterJSON, Map converter = Converters.getConverter(JSON.class,
Map.class);
MapString,String map, convertedMap;
map = new HashMapString,String();
map.put(field1, value1);
JSON json = JSON.from(map);
convertedMap = UtilGenerics.toMap(converter.convert(json));
assertEquals(JSON to Map, map, convertedMap);
}
{code}
The @Suppress annotation is not needed:
{code}
public void testJSONToMap() throws Exception {
ConverterJSON, MapString,String converter =
UtilGenerics.cast(Converters.getConverter(JSON.class, Map.class));
MapString,String map, convertedMap;
map = new HashMapString,String();
map.put(field1, value1);
JSON json = JSON.from(map);
convertedMap = UtilGenerics.toMap(converter.convert(json));
assertEquals(JSON to Map, map, convertedMap);
}
{code}
fix warnings in trunk on java source code
-
Key: OFBIZ-6217
URL: https://issues.apache.org/jira/browse/OFBIZ-6217
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Taher Alkhateeb
Assignee: Adrian Crum
Priority: Minor
Labels: java, warning
Fix For: Upcoming Branch
Attachments: remove_unused_imports.patch, warnings_patch_2.patch
Right now, we have 528 warnings on trunk out of which 238 are about raw types
and 118 never used imports. So we can already eliminate most of the warning
quite quickly.
I will issue multiple patches to resolve most of these warnings. It might be
a bit of a challenge to eliminate the raw types because the generics are not
always deducable from the code especially when relying on external APIs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385239#comment-14385239 ] Adrian Crum commented on OFBIZ-6217: Please provide an updated patch. fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch, warnings_patch_2.patch Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly. I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6217: -- Assignee: Adrian Crum fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch, warnings_patch_2.patch Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly. I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6217) fix warnings in trunk on java source code
[
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385222#comment-14385222
]
Adrian Crum commented on OFBIZ-6217:
Taher,
Thank you for working on this! One thing has me confused: You make use of the
UtilGenerics methods in some places, but not in others - where you add a
@SuppressWarnings annotation instead. Why not always use UtilGenerics?
Example from your patch:
{code}
@SuppressWarnings(rawtypes)
public void testJSONToMap() throws Exception {
ConverterJSON, Map converter = Converters.getConverter(JSON.class,
Map.class);
MapString,String map, convertedMap;
map = new HashMapString,String();
map.put(field1, value1);
JSON json = JSON.from(map);
convertedMap = UtilGenerics.toMap(converter.convert(json));
assertEquals(JSON to Map, map, convertedMap);
}
{code}
The @Suppress annotation is not needed:
{code}
public void testJSONToMap() throws Exception {
ConverterJSON, MapString,String converter =
UtilGenerics.cast(Converters.getConverter(JSON.class, Map.class));
MapString,String map, convertedMap;
map = new HashMapString,String();
map.put(field1, value1);
JSON json = JSON.from(map);
convertedMap = UtilGenerics.toMap(converter.convert(json));
assertEquals(JSON to Map, map, convertedMap);
}
{code}
fix warnings in trunk on java source code
-
Key: OFBIZ-6217
URL: https://issues.apache.org/jira/browse/OFBIZ-6217
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Taher Alkhateeb
Assignee: Adrian Crum
Priority: Minor
Labels: java, warning
Fix For: Upcoming Branch
Attachments: remove_unused_imports.patch, warnings_patch_2.patch
Right now, we have 528 warnings on trunk out of which 238 are about raw types
and 118 never used imports. So we can already eliminate most of the warning
quite quickly.
I will issue multiple patches to resolve most of these warnings. It might be
a bit of a challenge to eliminate the raw types because the generics are not
always deducable from the code especially when relying on external APIs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (OFBIZ-6218) Unit tests throw exception in DBCP
Adrian Crum created OFBIZ-6218: -- Summary: Unit tests throw exception in DBCP Key: OFBIZ-6218 URL: https://issues.apache.org/jira/browse/OFBIZ-6218 Project: OFBiz Issue Type: Bug Reporter: Adrian Crum -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6218) Unit tests throw exception in DBCP
[ https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6218: --- Description: Details in comments. Unit tests throw exception in DBCP -- Key: OFBIZ-6218 URL: https://issues.apache.org/jira/browse/OFBIZ-6218 Project: OFBiz Issue Type: Bug Reporter: Adrian Crum Details in comments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6219) NPE while rendering content uisng screen widget
[
https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-6219:
---
Attachment: OFBIZ-6219.patch
NPE while rendering content uisng screen widget
---
Key: OFBIZ-6219
URL: https://issues.apache.org/jira/browse/OFBIZ-6219
Project: OFBiz
Issue Type: Bug
Components: content, framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Deepak Dixit
Attachments: OFBIZ-6219.patch, OFBIZ-6219.patch
If we want to render an content that does't have dataResourceId then screen
widget throwing NPE
{code}
Caused by: java.lang.NullPointerException
at
org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
~[ofbiz-widget.jar:?]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6218) Unit tests throw exception in DBCP
[
https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383611#comment-14383611
]
Adrian Crum commented on OFBIZ-6218:
Test output:
{code}
testsuite errors=1 failures=0 hostname=speed-demon id=20
name=performfindtests package= skipped=0 tests=5 time=0.345
timestamp=2015-03-27T09:56:46properties/testcase
classname=org.ofbiz.common.test.PerformFindTests
name=testPerformFindConditionDistinct time=0.096error
type=java.lang.NullPointerExceptionjava.lang.NullPointerException
at
org.apache.commons.dbcp2.DelegatingConnection.closeInternal(DelegatingConnection.java:235)
at
org.apache.commons.dbcp2.DelegatingConnection.close(DelegatingConnection.java:218)
at
org.apache.commons.dbcp2.managed.ManagedConnection.close(ManagedConnection.java:166)
at org.ofbiz.entity.jdbc.SQLProcessor.close(SQLProcessor.java:235)
at
org.ofbiz.entity.util.EntityListIterator.close(EntityListIterator.java:154)
at
org.ofbiz.entity.util.EntityListIterator.next(EntityListIterator.java:329)
at
org.ofbiz.entity.util.EntityListIterator.getCompleteList(EntityListIterator.java:436)
at
org.ofbiz.common.test.PerformFindTests.getCompleteList(PerformFindTests.java:49)
at
org.ofbiz.common.test.PerformFindTests.testPerformFindConditionDistinct(PerformFindTests.java:190)
at org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:342)
at org.ofbiz.base.start.Start.start(Start.java:368)
at org.ofbiz.base.start.Start.main(Start.java:135)
/error/testcasetestcase classname=org.ofbiz.common.test.PerformFindTests
name=testPerformFindConditionFieldLike time=0.062/testcase
classname=org.ofbiz.common.test.PerformFindTests
name=testPerformFindConditionFieldEquals time=0.067/testcase
classname=org.ofbiz.common.test.PerformFindTests
name=testPerformFindFilterByDateWithDedicateDateField time=0.057/testcase
classname=org.ofbiz.common.test.PerformFindTests
name=testPerformFindFilterByDate time=0.045//testsuite
{code}
Unit tests throw exception in DBCP
--
Key: OFBIZ-6218
URL: https://issues.apache.org/jira/browse/OFBIZ-6218
Project: OFBiz
Issue Type: Bug
Reporter: Adrian Crum
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6217: --- Assignee: (was: Adrian Crum) fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly. I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reopened OFBIZ-6217: fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch Right now, we have 528 warnings on trunk out of which 238 are about raw types and 118 never used imports. So we can already eliminate most of the warning quite quickly. I will issue multiple patches to resolve most of these warnings. It might be a bit of a challenge to eliminate the raw types because the generics are not always deducable from the code especially when relying on external APIs -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6219) NPE while rendering content uisng screen widget
[
https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383688#comment-14383688
]
Adrian Crum commented on OFBIZ-6219:
It would be better to ensure the reference is not null - since the isEmpty()
call is used throughout the method.
NPE while rendering content uisng screen widget
---
Key: OFBIZ-6219
URL: https://issues.apache.org/jira/browse/OFBIZ-6219
Project: OFBiz
Issue Type: Bug
Components: content, framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Deepak Dixit
Attachments: OFBIZ-6219.patch
If we want to render an content that does't have dataResourceId then screen
widget throwing NPE
{code}
Caused by: java.lang.NullPointerException
at
org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
~[ofbiz-widget.jar:?]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6217. -- Resolution: Fixed Fix Version/s: (was: Trunk) Upcoming Branch Fixed in rev 1669537. Thanks! fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Upcoming Branch Attachments: remove_unused_imports.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6218) Unit tests throw exception in DBCP
[
https://issues.apache.org/jira/browse/OFBIZ-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383647#comment-14383647
]
Adrian Crum commented on OFBIZ-6218:
{code}
2015-03-27 10:43:12,491 |main |EntityListIterator
|W| Exception thrown while calling ResultSet.next():
java.sql.SQLException: ResultSet not open. Operation 'next' not permitted.
Verify that autocommit is off.
at
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
~[derby-10.11.1.1.jar:?]
at
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.EmbedConnection.newSQLException(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.ConnectionChild.newSQLException(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.EmbedResultSet.checkIfClosed(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.EmbedResultSet.checkExecIfClosed(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.EmbedResultSet.movePosition(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at org.apache.derby.impl.jdbc.EmbedResultSet.next(Unknown Source)
~[derby-10.11.1.1.jar:?]
at
org.apache.commons.dbcp2.DelegatingResultSet.next(DelegatingResultSet.java:191)
~[commons-dbcp2-2.1.jar:2.1]
at
org.apache.commons.dbcp2.DelegatingResultSet.next(DelegatingResultSet.java:191)
~[commons-dbcp2-2.1.jar:2.1]
at
org.ofbiz.entity.util.EntityListIterator.next(EntityListIterator.java:321)
[ofbiz-entity.jar:?]
at
org.ofbiz.entity.util.EntityListIterator.getCompleteList(EntityListIterator.java:437)
[ofbiz-entity.jar:?]
at
org.ofbiz.common.test.PerformFindTests.getCompleteList(PerformFindTests.java:49)
[ofbiz-common-test.jar:?]
at
org.ofbiz.common.test.PerformFindTests.testPerformFindFilterByDateWithDedicateDateField(PerformFindTests.java:232)
[ofbiz-common-test.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.7.0_60]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
~[?:1.7.0_60]
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.7.0_60]
at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_60]
at junit.framework.TestCase.runTest(TestCase.java:168)
[junit-dep-4.10.jar:?]
at junit.framework.TestCase.runBare(TestCase.java:134)
[junit-dep-4.10.jar:?]
at junit.framework.TestResult$1.protect(TestResult.java:110)
[junit-dep-4.10.jar:?]
at junit.framework.TestResult.runProtected(TestResult.java:128)
[junit-dep-4.10.jar:?]
at junit.framework.TestResult.run(TestResult.java:113)
[junit-dep-4.10.jar:?]
at junit.framework.TestCase.run(TestCase.java:124)
[junit-dep-4.10.jar:?]
at junit.framework.TestSuite.runTest(TestSuite.java:243)
[junit-dep-4.10.jar:?]
at junit.framework.TestSuite.run(TestSuite.java:238)
[junit-dep-4.10.jar:?]
at junit.framework.TestSuite.runTest(TestSuite.java:243)
[junit-dep-4.10.jar:?]
at junit.framework.TestSuite.run(TestSuite.java:238)
[junit-dep-4.10.jar:?]
at
org.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:146)
[ofbiz-testtools.jar:?]
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
[ofbiz-base.jar:?]
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:342)
[ofbiz.jar:?]
at org.ofbiz.base.start.Start.start(Start.java:368) [ofbiz.jar:?]
at org.ofbiz.base.start.Start.main(Start.java:135) [ofbiz.jar:?]
Caused by: org.apache.derby.iapi.error.StandardException: ResultSet not open.
Operation 'next' not permitted. Verify that autocommit is off.
at org.apache.derby.iapi.error.StandardException.newException(Unknown
Source) ~[derby-10.11.1.1.jar:?]
at
org.apache.derby.impl.jdbc.SQLExceptionFactory.wrapArgsForTransportAcrossDRDA(Unknown
Source) ~[derby-10.11.1.1.jar:?]
... 35 more
{code}
It appears the ResultSet is being closed prematurely somehow.
Unit tests throw exception in DBCP
--
Key: OFBIZ-6218
URL: https://issues.apache.org/jira/browse/OFBIZ-6218
Project: OFBiz
Issue Type: Bug
Reporter: Adrian Crum
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6217) fix warnings in trunk on java source code
[ https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6217: -- Assignee: Adrian Crum fix warnings in trunk on java source code - Key: OFBIZ-6217 URL: https://issues.apache.org/jira/browse/OFBIZ-6217 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Taher Alkhateeb Assignee: Adrian Crum Priority: Minor Labels: java, warning Fix For: Trunk Attachments: remove_unused_imports.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6219) NPE while rendering content uisng screen widget
[
https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383707#comment-14383707
]
Adrian Crum commented on OFBIZ-6219:
Your updated patch duplicates mine.
NPE while rendering content uisng screen widget
---
Key: OFBIZ-6219
URL: https://issues.apache.org/jira/browse/OFBIZ-6219
Project: OFBiz
Issue Type: Bug
Components: content, framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Deepak Dixit
Attachments: OFBIZ-6219.patch, OFBIZ-6219.patch, OFBIZ-6219.patch
If we want to render an content that does't have dataResourceId then screen
widget throwing NPE
{code}
Caused by: java.lang.NullPointerException
at
org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
~[ofbiz-widget.jar:?]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6219) NPE while rendering content uisng screen widget
[
https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383737#comment-14383737
]
Adrian Crum commented on OFBIZ-6219:
They both do the same thing. Mine uses a single if block and yours uses two
(the second if block can be included in the first).
NPE while rendering content uisng screen widget
---
Key: OFBIZ-6219
URL: https://issues.apache.org/jira/browse/OFBIZ-6219
Project: OFBiz
Issue Type: Bug
Components: content, framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Deepak Dixit
Attachments: OFBIZ-6219.patch, OFBIZ-6219.patch, OFBIZ-6219.patch
If we want to render an content that does't have dataResourceId then screen
widget throwing NPE
{code}
Caused by: java.lang.NullPointerException
at
org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
~[ofbiz-widget.jar:?]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6219) NPE while rendering content uisng screen widget
[
https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383822#comment-14383822
]
Adrian Crum commented on OFBIZ-6219:
This is beginner Java, and I can't believe we are having this discussion. I
don't understand the point you are trying to make.
My patch fixes the problem. Your patch does exactly the same thing but with
more code. Just commit the patch and close the issue. This discussion is a
waste of time.
NPE while rendering content uisng screen widget
---
Key: OFBIZ-6219
URL: https://issues.apache.org/jira/browse/OFBIZ-6219
Project: OFBiz
Issue Type: Bug
Components: content, framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Deepak Dixit
Attachments: OFBIZ-6219.patch, OFBIZ-6219.patch, OFBIZ-6219.patch
If we want to render an content that does't have dataResourceId then screen
widget throwing NPE
{code}
Caused by: java.lang.NullPointerException
at
org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
~[ofbiz-widget.jar:?]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6219) NPE while rendering content uisng screen widget
[
https://issues.apache.org/jira/browse/OFBIZ-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14383828#comment-14383828
]
Adrian Crum commented on OFBIZ-6219:
Okay, I see your concern is with the content of the error message. Okay - use
your patch. I apologize for the confusion.
NPE while rendering content uisng screen widget
---
Key: OFBIZ-6219
URL: https://issues.apache.org/jira/browse/OFBIZ-6219
Project: OFBiz
Issue Type: Bug
Components: content, framework
Affects Versions: Release Branch 14.12, Trunk
Reporter: Deepak Dixit
Attachments: OFBIZ-6219.patch, OFBIZ-6219.patch, OFBIZ-6219.patch
If we want to render an content that does't have dataResourceId then screen
widget throwing NPE
{code}
Caused by: java.lang.NullPointerException
at
org.ofbiz.widget.model.ModelScreenWidget$Content.renderWidgetString(ModelScreenWidget.java:1399)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget.renderSubWidgetsString(ModelScreenWidget.java:98)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:280)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.model.ModelScreen.renderScreenString(ModelScreen.java:164)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:136)
~[ofbiz-widget.jar:?]
at
org.ofbiz.widget.renderer.ScreenRenderer.render(ScreenRenderer.java:98)
~[ofbiz-widget.jar:?]
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-6207) Anyone can view any Request or Quote
[ https://issues.apache.org/jira/browse/OFBIZ-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379426#comment-14379426 ] Adrian Crum commented on OFBIZ-6207: It would be best to protect the screen with a permission service - preferably the same one that guards the Request/Quote services. Anyone can view any Request or Quote Key: OFBIZ-6207 URL: https://issues.apache.org/jira/browse/OFBIZ-6207 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Trunk, 13.07.01 Reporter: Forrest Rae Assignee: Deepak Dixit Priority: Critical Labels: security Attachments: OFBIZ-6207-third-attempt.patch This is a security bug in the ecommerce application. Anyone can view any quote or request in the system regardless of the associated partyId. They can do this via URL parameter manipulation. Reproduction: 1) Login to the ecommerce application as DemoCustomer. 2) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9000 to view your own request. 3) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9001 to view DemoCustAgent's request. 4) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9002 to view DemoCustomer2's request. Same goes for Quotes, although there are no quotes in the Demo data. The attach patch fixes this issue. Would like this issue back ported to release 13.07 please. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6210) Replace EntityUtilProperties with EntityClassLoader
[ https://issues.apache.org/jira/browse/OFBIZ-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379614#comment-14379614 ] Adrian Crum commented on OFBIZ-6210: There is an example usage that is commented out in ControlServletjava. If this goes live, then we will need to create an instance in the Job Scheduler as well. Replace EntityUtilProperties with EntityClassLoader --- Key: OFBIZ-6210 URL: https://issues.apache.org/jira/browse/OFBIZ-6210 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor The EntityUtilProperties implementation is very limited and requires rewriting a lot of code. Using EntityClassLoader will achieve the same result without changing any code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-6210) Replace EntityUtilProperties with EntityClassLoader
Adrian Crum created OFBIZ-6210: -- Summary: Replace EntityUtilProperties with EntityClassLoader Key: OFBIZ-6210 URL: https://issues.apache.org/jira/browse/OFBIZ-6210 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Upcoming Branch Reporter: Adrian Crum Priority: Minor The EntityUtilProperties implementation is very limited and requires rewriting a lot of code. Using EntityClassLoader will achieve the same result without changing any code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6205) Use EntityUtilProperties to get the WebSiteProperties
[ https://issues.apache.org/jira/browse/OFBIZ-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379617#comment-14379617 ] Adrian Crum commented on OFBIZ-6205: Issue has been created - OFBIZ-6210. There is no performance impact using EntityClassLoader. Others are welcome to run performance tests if they wish, but a simple review of the code will make it clear that the difference boils down to reading a file from the local file system versus reading a file from the database (that same difference exists now with the EntityUtilProperties implementation). Use EntityUtilProperties to get the WebSiteProperties - Key: OFBIZ-6205 URL: https://issues.apache.org/jira/browse/OFBIZ-6205 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Arun Patidar Priority: Critical Attachments: OFBIZ-6205.patch Use EntityUtilProperties to get the WebSiteProperties, As per current implementation its using UtilProperties and its affecting the multitenant environment. Wrong https url creation for a tenant in multi-tenant environment. Its redirecting to default instance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6211) Split configuration options in /framework/common .properties files
[ https://issues.apache.org/jira/browse/OFBIZ-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379670#comment-14379670 ] Adrian Crum commented on OFBIZ-6211: One clarification: changes in properties files do not require a restart. Instead, you can clear the properties file cache in Web Tools. Split configuration options in /framework/common .properties files -- Key: OFBIZ-6211 URL: https://issues.apache.org/jira/browse/OFBIZ-6211 Project: OFBiz Issue Type: Sub-task Components: framework Reporter: Pierre Smits Assignee: Pierre Smits Labels: common, configuration, multi-tenant The configuration file general.properties contains has configuration options that are multi-tenant configurable (e.g. mail settings) and options that are implementation specific (e.g. multitenant) and require a restart. The multi-tenant configurable options should move out of general.properties into a separate .properties file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6207) Anyone can view any Request or Quote
[ https://issues.apache.org/jira/browse/OFBIZ-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380049#comment-14380049 ] Adrian Crum commented on OFBIZ-6207: Permission services implement the permissionInterface service interface: https://localhost:8443/webtools/control/ServiceList?sel_service_name=permissionInterface A very good example is the fixedAssetPermissionCheck service. You can see it guarding Fixed Assets services in services_fixedasset.xml and it also guards screens in FixedAssetScreens.xml. Anyone can view any Request or Quote Key: OFBIZ-6207 URL: https://issues.apache.org/jira/browse/OFBIZ-6207 Project: OFBiz Issue Type: Bug Components: specialpurpose/ecommerce Affects Versions: Trunk, 13.07.01 Reporter: Forrest Rae Assignee: Deepak Dixit Priority: Critical Labels: security Attachments: OFBIZ-6207-third-attempt.patch This is a security bug in the ecommerce application. Anyone can view any quote or request in the system regardless of the associated partyId. They can do this via URL parameter manipulation. Reproduction: 1) Login to the ecommerce application as DemoCustomer. 2) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9000 to view your own request. 3) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9001 to view DemoCustAgent's request. 4) Navigate to http://demo-stable-ofbiz.apache.org/ecommerce/control/ViewRequest?custRequestId=9002 to view DemoCustomer2's request. Same goes for Quotes, although there are no quotes in the Demo data. The attach patch fixes this issue. Would like this issue back ported to release 13.07 please. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6205) Use EntityUtilProperties to get the WebSiteProperties
[ https://issues.apache.org/jira/browse/OFBIZ-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379696#comment-14379696 ] Adrian Crum commented on OFBIZ-6205: Can we continue this discussion in OFBIZ-6210 please? Use EntityUtilProperties to get the WebSiteProperties - Key: OFBIZ-6205 URL: https://issues.apache.org/jira/browse/OFBIZ-6205 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 12.04, Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Arun Patidar Priority: Critical Attachments: OFBIZ-6205.patch Use EntityUtilProperties to get the WebSiteProperties, As per current implementation its using UtilProperties and its affecting the multitenant environment. Wrong https url creation for a tenant in multi-tenant environment. Its redirecting to default instance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6206) The always log level in minilang is logged as FATAL
[ https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-6206: --- Summary: The always log level in minilang is logged as FATAL (was: The always log level in minilang is rendered as FATAL) The always log level in minilang is logged as FATAL -- Key: OFBIZ-6206 URL: https://issues.apache.org/jira/browse/OFBIZ-6206 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Release Branch 14.12, Trunk Reporter: Jacques Le Roux Priority: Minor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6205) Use EntityUtilProperties to get the WebSiteProperties
[ https://issues.apache.org/jira/browse/OFBIZ-6205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377581#comment-14377581 ] Adrian Crum commented on OFBIZ-6205: It would be nice if we stopped using that awful implementation and started using the EntityClassLoader instead. See rev 1649620. Use EntityUtilProperties to get the WebSiteProperties - Key: OFBIZ-6205 URL: https://issues.apache.org/jira/browse/OFBIZ-6205 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk Reporter: Arun Patidar Priority: Critical Use EntityUtilProperties to get the WebSiteProperties, As per current implementation its using UtilProperties and its affecting the multitenant environment. Wrong https url creation for a tenant in multi-tenant environment. Its redirecting to default instance. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14372752#comment-14372752 ] Adrian Crum commented on OFBIZ-5534: I committed a fix for the PK cache in rev 1668267. Comments are welcome. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371066#comment-14371066 ] Adrian Crum edited comment on OFBIZ-5534 at 3/20/15 10:11 AM: -- This issue is now a year old, and I would like to help get it resolved. Until Adam can produce his solution, I have my own that we can consider. I don't think we need to use XAResource. The problem is fairly easy to solve, so using XAResource will complicate things unnecessarily. 1. We need to add a bit of functionality to the existing transaction code: a. Associate org.ofbiz.entity.cache.Cache instances (one for each Delegator instance) to each UserTransaction instance. b. Add Publish/Subscribe (listener) functionality to TransactionUtil. Listeners are notified post-commit and post-rollback. 2. Add functionality to the Delegator: a. Make each instance a transaction listener. b. On post-commit notification, copy transaction cache to internal cache. c. On post-rollback notification, clear transaction cache. 3. Modify Delegator cache behavior: a. On find methods: If a transaction is in place, check transaction cache, else check internal cache. b. If a miss, execute SQL SELECT. c. If a transaction is in place, put results in transaction cache, else put results in internal cache. was (Author: adri...@hlmksw.com): This issue is now a year old, and I would like to help get it resolved. Until Adam can produce his solution, I have my own that we can consider. I don't think we need to use XAResource. The problem is fairly easy to solve, so using XAResource will complicate things unnecessarily. 1. We need to add a bit of functionality to the existing transaction code: a. Associate org.ofbiz.entity.cache.Cache instances (one for each Delegator instance) to each UserTransaction instance. b. Add Publish/Subscribe (listener) functionality to TransactionUtil. Listeners are notified post-commit and post-rollback. 2. Add functionality to the Delegator: a. Make each instance a transaction listener. b. On post-commit notification, copy transaction cache to internal cache. c. On post-rollback notification, clear transaction cache. 3. Modify Delegator cache behavior: a. On find methods, check its internal cache first. b. If a miss and transaction is in place, check transaction cache. c. If a miss, execute SQL SELECT. d. If a transaction is in place, put results in transaction cache, else put results in internal cache. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371095#comment-14371095 ] Adrian Crum commented on OFBIZ-5534: Switching to another system is fine, but in the meantime we have a serious flaw that needs to be fixed, and it appears I am the only person willing to fix it. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-4909) OFBiz contains Sun extensions and it will not run on Linux or on the IBM Z servers
[ https://issues.apache.org/jira/browse/OFBIZ-4909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-4909. -- Resolution: Not a Problem OFBiz contains Sun extensions and it will not run on Linux or on the IBM Z servers - Key: OFBIZ-4909 URL: https://issues.apache.org/jira/browse/OFBIZ-4909 Project: OFBiz Issue Type: Wish Components: ALL APPLICATIONS Affects Versions: Release 10.04 Environment: IBM Z servers Linux OS Reporter: Kirk Ritchey OFBiz contains Sun extensions and will not run on Linux or on the IBM Z servers. 1) Confirm this 2) advise how to overcome this show-stopper -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371025#comment-14371025 ] Adrian Crum commented on OFBIZ-5534: Currently, my implementation has issues if transactions are suspended and resumed. You can associate a temporary/local cache to each transaction (like I mentioned earlier). Transactions will need to support listeners. On post-commit notification: temporary/local cache is copied to global cache. On rollback notification: temporary/local cache is emptied. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371592#comment-14371592 ] Adrian Crum commented on OFBIZ-5534: Interesting... I changed the transaction timeout value to 1 second for the testServiceForDirtyReadsFromCacheT2 service, but it still takes a very long time before the transaction times out. Also, we can't use services for testing this, because even though I catch the exception thrown by the timeout, the entity engine has rolled back the transaction - which causes the service engine to throw an exception on return. So, even though the test passes functionally, it fails because of the transaction rollback. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371528#comment-14371528 ] Adrian Crum commented on OFBIZ-5534: I have this fixed on my local copy, but the unit test fails due to the Derby deadlock problem that Jacopo discovered. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5534) Dirty reads from entity cache
[ https://issues.apache.org/jira/browse/OFBIZ-5534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371066#comment-14371066 ] Adrian Crum commented on OFBIZ-5534: This issue is now a year old, and I would like to help get it resolved. Until Adam can produce his solution, I have my own that we can consider. I don't think we need to use XAResource. The problem is fairly easy to solve, so using XAResource will complicate things unnecessarily. 1. We need to add a bit of functionality to the existing transaction code: a. Associate org.ofbiz.entity.cache.Cache instances (one for each Delegator instance) to each UserTransaction instance. b. Add Publish/Subscribe (listener) functionality to TransactionUtil. Listeners are notified post-commit and post-rollback. 2. Add functionality to the Delegator: a. Make each instance a transaction listener. b. On post-commit notification, copy transaction cache to internal cache. c. On post-rollback notification, clear transaction cache. 3. Modify Delegator cache behavior: a. On find methods, check its internal cache first. b. If a miss and transaction is in place, check transaction cache. c. If a miss, execute SQL SELECT. d. If a transaction is in place, put results in transaction cache, else put results in internal cache. Dirty reads from entity cache - Key: OFBIZ-5534 URL: https://issues.apache.org/jira/browse/OFBIZ-5534 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 11.04, Release Branch 12.04, Release Branch 13.07, Trunk Reporter: Jacopo Cappellato Assignee: Adam Heath Attachments: unittest-dirtyreadsfromcache.patch Even if database transaction isolation level is set to ReadCommitted, a transaction can get uncommitted records from the entity cache, under certain circumstances. Here is a test case: 1) transaction T1 creates a record 2) T1 calls findOne to retrieve it: the read will be successful (because T1 can read data generated in T1 even if not committed) and the record will be added to the cache 3) T1 calls another service with requireNewTransaction set to true: this will run the second service in a new transaction T2 4) T2 calls findOne to retrieve the record created by T1: if useCache is set to false it should fail; if useCache is set to true it will succeed (getting the record from cache, even if the data is not committed to the db) The result in #4 is wrong because T2 should not see the uncommitted record We should never add uncommitted records to the entity cache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6165) Improve FindScreenDecorator to work with configurability of Search Find Screens per app.
[ https://issues.apache.org/jira/browse/OFBIZ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369258#comment-14369258 ] Adrian Crum commented on OFBIZ-6165: The patch is a step in the right direction, but it needs more work. The Groovy script replaces request parameters, but instead it should use them if they exist, and provide configured defaults if they don't exist. My preference would be to make these User Preferences - which would simplify the implementation (no need to use properties) and it would be customizable per user. Improve FindScreenDecorator to work with configurability of Search Find Screens per app. Key: OFBIZ-6165 URL: https://issues.apache.org/jira/browse/OFBIZ-6165 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, find, multi-tenant, search Attachments: OFBIZ-6265-FrameworkSearchfind.patch In order to enable apps specific configurations for Search Find screens, the FindScreenDecorator needs to be adjusted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6165) Improve FindScreenDecorator to work with configurability of Search Find Screens per app.
[ https://issues.apache.org/jira/browse/OFBIZ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369271#comment-14369271 ] Adrian Crum commented on OFBIZ-6165: I understand what the script does. What I pointed out is that it is wrong. Get the settings from the request parameters FIRST. If they don't exist, then get defaults from the various configuration files. Improve FindScreenDecorator to work with configurability of Search Find Screens per app. Key: OFBIZ-6165 URL: https://issues.apache.org/jira/browse/OFBIZ-6165 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, find, multi-tenant, search Attachments: OFBIZ-6265-FrameworkSearchfind.patch In order to enable apps specific configurations for Search Find screens, the FindScreenDecorator needs to be adjusted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6165) Improve FindScreenDecorator to work with configurability of Search Find Screens per app.
[ https://issues.apache.org/jira/browse/OFBIZ-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369341#comment-14369341 ] Adrian Crum commented on OFBIZ-6165: Your patch will not work after the initial display. Don't forget that Find screens are paginated. If I change the settings, then scroll forward or back, my settings will be lost because they were overwritten with defaults. Improve FindScreenDecorator to work with configurability of Search Find Screens per app. Key: OFBIZ-6165 URL: https://issues.apache.org/jira/browse/OFBIZ-6165 Project: OFBiz Issue Type: Sub-task Components: framework Affects Versions: Trunk Reporter: Pierre Smits Assignee: Pierre Smits Labels: configuration, find, multi-tenant, search Attachments: OFBIZ-6265-FrameworkSearchfind.patch In order to enable apps specific configurations for Search Find screens, the FindScreenDecorator needs to be adjusted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6172) Screenlet collapsibility is not working
[ https://issues.apache.org/jira/browse/OFBIZ-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6172: -- Assignee: Adrian Crum Screenlet collapsibility is not working --- Key: OFBIZ-6172 URL: https://issues.apache.org/jira/browse/OFBIZ-6172 Project: OFBiz Issue Type: Bug Components: framework Reporter: Thawatchai Klinkliang Assignee: Adrian Crum Priority: Minor Attachments: OFBIZ-6172_ModelScreenWidget.patch Currently, Screenlet widget which have collapsible always expand. If there is no Screenlet's preferenceKey in requestParameters, the initially-collapsed always be false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6172) Screenlet collapsibility is not working
[ https://issues.apache.org/jira/browse/OFBIZ-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6172. -- Resolution: Fixed Fix Version/s: Upcoming Branch 14.12.01 Fixed in revs 1667492 and 1667494. Thanks! Screenlet collapsibility is not working --- Key: OFBIZ-6172 URL: https://issues.apache.org/jira/browse/OFBIZ-6172 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Thawatchai Klinkliang Assignee: Adrian Crum Priority: Minor Fix For: 14.12.01, Upcoming Branch Attachments: OFBIZ-6172_ModelScreenWidget.patch Currently, Screenlet widget which have collapsible always expand. If there is no Screenlet's preferenceKey in requestParameters, the initially-collapsed always be false. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5234) Harmonize link definitions, attributes, and functions in widget-*.xsd's, etc
[ https://issues.apache.org/jira/browse/OFBIZ-5234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14363140#comment-14363140 ] Adrian Crum commented on OFBIZ-5234: Actually, I took care of that in the widget refactor. So, the patch is not needed. Thanks anyway! Harmonize link definitions, attributes, and functions in widget-*.xsd's, etc Key: OFBIZ-5234 URL: https://issues.apache.org/jira/browse/OFBIZ-5234 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Attachments: OFBIZ-5234-FRMWRK-LinkHarmonization-xsd.patch Currently in widget-screen.xsd there is the definition 'link', with it's associated attributes (and of course associated functions in MacroScreenRenderer.java and htmlScreenMacroLibrary.ftl) However, in widget-form.xsd this definition doesn't exist (and also not in the .java and .ftl files). But for linking the definitions hyperlink and sub-hyperlink exists. Which don't exist in either widget-screen.xsd and widget-menu.xsd And in widget-menu.xsd the definition of link exists, but with less attributes defined than the definition in widget-screen.xsd. It would be a great improvement if there would be only one definition that is applied everywhere and has the combined functionalities of all defintions currently existing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6150) Have 'Temporal Expression' Screen deliver the overview on opening screen
[ https://issues.apache.org/jira/browse/OFBIZ-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361687#comment-14361687 ] Adrian Crum commented on OFBIZ-6150: The argument for won't implement is that it is already implemented - just configure your local instance to produce the behavior you want. Have 'Temporal Expression' Screen deliver the overview on opening screen Key: OFBIZ-6150 URL: https://issues.apache.org/jira/browse/OFBIZ-6150 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits Priority: Minor Attachments: OFBIZ-6150-TempExprScreens-SEARCH.patch, tempExprForms.xml.0.patch Currently the Find Temporal Expressions screen doesn't show any data on opening the screen, which leads to a diminished UX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6150) Have 'Temporal Expression' Screen deliver the overview on opening screen
[ https://issues.apache.org/jira/browse/OFBIZ-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360582#comment-14360582 ] Adrian Crum commented on OFBIZ-6150: What kind of overview did you have in mind? Have 'Temporal Expression' Screen deliver the overview on opening screen Key: OFBIZ-6150 URL: https://issues.apache.org/jira/browse/OFBIZ-6150 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits Priority: Minor Currently the Find Temporal Expressions screen doesn't show any data on opening the screen, which leads to a diminished UX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6150) Have 'Temporal Expression' Screen deliver the overview on opening screen
[ https://issues.apache.org/jira/browse/OFBIZ-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360614#comment-14360614 ] Adrian Crum commented on OFBIZ-6150: That is the standard behavior of any Find screen. We do not display lists automatically when landing on a page because that would cause a heavy server load. Have 'Temporal Expression' Screen deliver the overview on opening screen Key: OFBIZ-6150 URL: https://issues.apache.org/jira/browse/OFBIZ-6150 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits Priority: Minor Currently the Find Temporal Expressions screen doesn't show any data on opening the screen, which leads to a diminished UX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6150) Have 'Temporal Expression' Screen deliver the overview on opening screen
[ https://issues.apache.org/jira/browse/OFBIZ-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360620#comment-14360620 ] Adrian Crum commented on OFBIZ-6150: Btw, if you want to change the default behavior, you can set widget.defaultNoConditionFind to Y in widget.properties. Have 'Temporal Expression' Screen deliver the overview on opening screen Key: OFBIZ-6150 URL: https://issues.apache.org/jira/browse/OFBIZ-6150 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Pierre Smits Priority: Minor Currently the Find Temporal Expressions screen doesn't show any data on opening the screen, which leads to a diminished UX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4075) multiple paypal interfaces
[ https://issues.apache.org/jira/browse/OFBIZ-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354849#comment-14354849 ] Adrian Crum commented on OFBIZ-4075: There are two PayPal integrations in the trunk: org.ofbiz.accounting.thirdparty.paypal.PayPalEvents org.ofbiz.accounting.thirdparty.paypal.PayPalServices PayPalServices is the most recent and it uses the OFBiz payment processor API. PayPalEvents is older and it does not use the OFBiz payment processor API. The PayPalServices code is getting old, but it still works. It needs to be updated to a later PayPal API version. multiple paypal interfaces -- Key: OFBIZ-4075 URL: https://issues.apache.org/jira/browse/OFBIZ-4075 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: Trunk Reporter: BJ Freeman Attachments: OFBIZ-4075paypalIPNEvents.pact Pay pal had many interfaces. Ofbiz started with IPN https://www.paypal.com/ipn Then went to Express check out but changed the IPN code. https://www.paypal.com/us/cgi-bin/webscr?cmd=_additional-payment-overview finally we have NVP API. https://cms.paypal.com/us/cgi-bin/?cmd=_render-contentcontent_ID=developer/e_howto_api_nvp_NVPAPIOverview so I am creating an IPN interface that goes back to 94 I am not familiar enough with express and NVP it they are separate or not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348945#comment-14348945 ] Adrian Crum commented on OFBIZ-4274: The files do not go anywhere. So far, this has been a high-level design discussion - there is no implementation yet. Implement a REST Servlet Key: OFBIZ-4274 URL: https://issues.apache.org/jira/browse/OFBIZ-4274 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Adrian Crum Priority: Minor Labels: REST Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, rest-conf.xml Implement a REST servlet that will map REST requests to OFBiz services. Details are in the comments. [here is the discussion which took place on the dev ML|http://markmail.org/message/ai6q2fbksowaayn4] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6115) report on quote cause exception
[ https://issues.apache.org/jira/browse/OFBIZ-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338721#comment-14338721 ] Adrian Crum commented on OFBIZ-6115: Interesting... When I click on the Report button a second time, there is no error and the report is generated. report on quote cause exception --- Key: OFBIZ-6115 URL: https://issues.apache.org/jira/browse/OFBIZ-6115 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Wai https://localhost:8443/ordermgr/control/QuoteReport?quoteId=CQ1 The Following Errors Occurred: Unable to transform FO file: org.apache.fop.apps.FOPException java.lang.NullPointerException Console output... 2015-02-25 19:47:00,608 |http-bio-8443-exec-1 |ScreenFactory |I| Got 39 screens in 0.014s from: file:/home/xx/workspace/ofbiz/applications/party/widget/partymgr/PartyScreens.xml 2015-02-25 19:47:00,663 |http-bio-8443-exec-1 |ModelScreenWidget |W| In platform-dependent could not find template for xsl-fo, using the one for html. 2015-02-25 19:47:00,790 |http-bio-8443-exec-1 |ModelScreenWidget |W| In platform-dependent could not find template for xsl-fo, using the one for html. 2015-02-25 19:47:01,152 |http-bio-8443-exec-1 |ApacheFopWorker |I| FOP FontBaseURL: file:/home/xx/workspace/ofbiz/framework/webapp/config/ 2015-02-25 19:47:01,160 |http-bio-8443-exec-1 |FOP |D| target-resolution set to: 72.0dpi (px2mm=0.3528) 2015-02-25 19:47:01,805 |http-bio-8443-exec-1 |FOUserAgent |W| The following feature isn't implemented by Apache FOP, yet: table-layout=auto (on fo:table) (See position 124:40) 2015-02-25 19:47:01,813 |http-bio-8443-exec-1 |FOUserAgent |W| The following feature isn't implemented by Apache FOP, yet: table-layout=auto (on fo:table) (See position 156:81) 2015-02-25 19:47:01,820 |http-bio-8443-exec-1 |FOUserAgent |W| The following feature isn't implemented by Apache FOP, yet: table-layout=auto (on fo:table) (See position 185:39) 2015-02-25 19:47:01,827 |http-bio-8443-exec-1 |FOUserAgent |W| fo:table-body is missing child elements. Required content model: marker* (table-row+|table-cell+) (See position 204:32) 2015-02-25 19:47:01,829 |http-bio-8443-exec-1 |ScreenFopViewHandler |E| Unable to transform FO file: org.apache.fop.apps.FOPException java.lang.NullPointerException; Screen XSL:FO text was: ?xml version=1.0 encoding=UTF-8? !-- Begin Template component://common/webcommon/includes/reportTemplate.fo.ftl -- fo:root xmlns:fo=http://www.w3.org/1999/XSL/Format; font-family=NotoSans fo:layout-master-set fo:simple-page-master master-name=main-page page-width=8.5in page-height=11in margin-top=0.4in margin-bottom=0.4in margin-left=0.6in margin-right=0.4in fo:region-body margin-top=1.5in margin-bottom=0.4in/ fo:region-before extent=1.2in/ fo:region-after extent=0.4in/ /fo:simple-page-master fo:simple-page-master master-name=main-page-landscape page-width=11in page-height=8.5in margin-top=0.4in margin-bottom=0.4in margin-left=0.6in margin-right=0.4in fo:region-body margin-top=1.2in margin-bottom=0.4in/ fo:region-before extent=1.2in/ fo:region-after extent=0.4in/ /fo:simple-page-master /fo:layout-master-set fo:page-sequence master-reference=main-page fo:static-content flow-name=xsl-region-before fo:table table-layout=fixed width=100% fo:table-column column-number=1 column-width=proportional-column-width(50)/ fo:table-column column-number=2 column-width=proportional-column-width(50)/ fo:table-body fo:table-row fo:table-cell !-- Begin Template component://order/webapp/ordermgr/order/companyHeader.fo.ftl -- fo:block text-align=left fo:external-graphic src=/images/ofbiz_logo.gif overflow=hidden height=40px content-height=scale-to-fit content-width=2.00in/ /fo:block fo:block font-size=8pt fo:blockmyco_name/fo:block !-- Begin Template component://party/webapp/partymgr/party/contactmechtemplates/PostalAddress.fo.ftl -- fo:blockmyco_addr1/fo:block fo:blockmyco_addr2/fo:block fo:blockmyco_city, NB myco_pcode/fo:block fo:block Canada /fo:block !-- End Template component://party/webapp/partymgr/party/contactmechtemplates/PostalAddress.fo.ftl -- fo:list-block provisional-distance-between-starts=.5in
[jira] [Assigned] (OFBIZ-6114) webtools entity references generates exceptions
[ https://issues.apache.org/jira/browse/OFBIZ-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6114: -- Assignee: Adrian Crum webtools entity references generates exceptions --- Key: OFBIZ-6114 URL: https://issues.apache.org/jira/browse/OFBIZ-6114 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Wai Assignee: Adrian Crum -Browse https://localhost:8443/webtools/control/entityref?forstatic=true -click on any links on the left hand pane. -ofbiz reports... org.ofbiz.webapp.control.RequestHandlerException: No definition found for view with name [entityref_main.html] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6114) webtools entity references generates exceptions
[ https://issues.apache.org/jira/browse/OFBIZ-6114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6114. -- Resolution: Fixed Fix Version/s: Upcoming Branch 13.07.02 14.12.01 Fixed in rev 1662500. Thanks! webtools entity references generates exceptions --- Key: OFBIZ-6114 URL: https://issues.apache.org/jira/browse/OFBIZ-6114 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Wai Assignee: Adrian Crum Fix For: 14.12.01, 13.07.02, Upcoming Branch -Browse https://localhost:8443/webtools/control/entityref?forstatic=true -click on any links on the left hand pane. -ofbiz reports... org.ofbiz.webapp.control.RequestHandlerException: No definition found for view with name [entityref_main.html] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6115) report on quote cause exception
[ https://issues.apache.org/jira/browse/OFBIZ-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338712#comment-14338712 ] Adrian Crum commented on OFBIZ-6115: What version are you using? I get a different error on trunk: 2015-02-26 09:11:27,647 |ttp-bio-8443-exec-12 |ScriptUtil |W| Error running script at location [component://order/webapp/ordermgr/WEB-INF/actions/quote/GetPartyAddress.groovy]: groovy.lang.MissingPropertyException: No such property: party for class: GetPartyAddress groovy.lang.MissingPropertyException: No such property: party for class: GetPartyAddress at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.unwrap(ScriptBytecodeAdapter.java:50) ~[groovy-all-2.2.1.jar:2.2.1] at org.codehaus.groovy.runtime.callsite.PogoGetPropertySite.getProperty(PogoGetPropertySite.java:49) ~[groovy-all-2.2.1.jar:2.2.1] at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callGroovyObjectGetProperty(AbstractCallSite.java:231) ~[groovy-all-2.2.1.jar:2.2.1] at GetPartyAddress.run(GetPartyAddress.groovy:23) ~[?:?] report on quote cause exception --- Key: OFBIZ-6115 URL: https://issues.apache.org/jira/browse/OFBIZ-6115 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk Reporter: Wai https://localhost:8443/ordermgr/control/QuoteReport?quoteId=CQ1 The Following Errors Occurred: Unable to transform FO file: org.apache.fop.apps.FOPException java.lang.NullPointerException Console output... 2015-02-25 19:47:00,608 |http-bio-8443-exec-1 |ScreenFactory |I| Got 39 screens in 0.014s from: file:/home/xx/workspace/ofbiz/applications/party/widget/partymgr/PartyScreens.xml 2015-02-25 19:47:00,663 |http-bio-8443-exec-1 |ModelScreenWidget |W| In platform-dependent could not find template for xsl-fo, using the one for html. 2015-02-25 19:47:00,790 |http-bio-8443-exec-1 |ModelScreenWidget |W| In platform-dependent could not find template for xsl-fo, using the one for html. 2015-02-25 19:47:01,152 |http-bio-8443-exec-1 |ApacheFopWorker |I| FOP FontBaseURL: file:/home/xx/workspace/ofbiz/framework/webapp/config/ 2015-02-25 19:47:01,160 |http-bio-8443-exec-1 |FOP |D| target-resolution set to: 72.0dpi (px2mm=0.3528) 2015-02-25 19:47:01,805 |http-bio-8443-exec-1 |FOUserAgent |W| The following feature isn't implemented by Apache FOP, yet: table-layout=auto (on fo:table) (See position 124:40) 2015-02-25 19:47:01,813 |http-bio-8443-exec-1 |FOUserAgent |W| The following feature isn't implemented by Apache FOP, yet: table-layout=auto (on fo:table) (See position 156:81) 2015-02-25 19:47:01,820 |http-bio-8443-exec-1 |FOUserAgent |W| The following feature isn't implemented by Apache FOP, yet: table-layout=auto (on fo:table) (See position 185:39) 2015-02-25 19:47:01,827 |http-bio-8443-exec-1 |FOUserAgent |W| fo:table-body is missing child elements. Required content model: marker* (table-row+|table-cell+) (See position 204:32) 2015-02-25 19:47:01,829 |http-bio-8443-exec-1 |ScreenFopViewHandler |E| Unable to transform FO file: org.apache.fop.apps.FOPException java.lang.NullPointerException; Screen XSL:FO text was: ?xml version=1.0 encoding=UTF-8? !-- Begin Template component://common/webcommon/includes/reportTemplate.fo.ftl -- fo:root xmlns:fo=http://www.w3.org/1999/XSL/Format; font-family=NotoSans fo:layout-master-set fo:simple-page-master master-name=main-page page-width=8.5in page-height=11in margin-top=0.4in margin-bottom=0.4in margin-left=0.6in margin-right=0.4in fo:region-body margin-top=1.5in margin-bottom=0.4in/ fo:region-before extent=1.2in/ fo:region-after extent=0.4in/ /fo:simple-page-master fo:simple-page-master master-name=main-page-landscape page-width=11in page-height=8.5in margin-top=0.4in margin-bottom=0.4in margin-left=0.6in margin-right=0.4in fo:region-body margin-top=1.2in margin-bottom=0.4in/ fo:region-before extent=1.2in/ fo:region-after extent=0.4in/ /fo:simple-page-master /fo:layout-master-set fo:page-sequence master-reference=main-page fo:static-content flow-name=xsl-region-before fo:table table-layout=fixed width=100% fo:table-column column-number=1 column-width=proportional-column-width(50)/ fo:table-column column-number=2 column-width=proportional-column-width(50)/ fo:table-body fo:table-row
[jira] [Commented] (OFBIZ-2976) view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false
[ https://issues.apache.org/jira/browse/OFBIZ-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14337536#comment-14337536 ] Adrian Crum commented on OFBIZ-2976: This issue is almost 5 years old, what does it have to do with me? view-entity with condition-expr joined with another view-entity as rel-optional=true is treated as rel-optional=false - Key: OFBIZ-2976 URL: https://issues.apache.org/jira/browse/OFBIZ-2976 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Environment: Java v1.5.0_19-b02-298 MacOS X 10.5.8 Reporter: Jennifer Weston Assignee: Jacques Le Roux Priority: Minor Attachments: JIRA-Issue2976.patch If a view-entity is defined with condition-exprs and used as a member-entity in a second view-entity and the view-link is rel-optional=true, the link is treated as rel-optional=false. In the following example, the view-entity PPRMinQty is a list of all PriceBreakRules that have a minimum quantity defined. The view-entity ProductPriceBreakMinQty uses PPRMinQty with ProductCategoryMember and ProductPriceCond (this time used for product categories) to create a list of productIds with their productPriceRuleIds and their minimum quantities (if any). The rel-optional=true should mean that even productPriceRuleids that don't have a minimum quantity defined should be included in the result set. view-entity entity-name=PPRMinQty package-name=com.mavericklabel title=Minimum qty for a product price rule member-entity entity-alias=PPC entity-name=ProductPriceCond/ alias name=productPriceRuleId entity-alias=PPC field=productPriceRuleId/ alias name=minQty entity-alias=PPC field=condValue/ alias name=inputParamEnumId entity-alias=PPC field=inputParamEnumId/ alias name=operatorEnumId entity-alias=PPC field=operatorEnumId/ entity-condition condition-list condition-expr entity-alias=PPC field-name=inputParamEnumId operator=equals value=PRIP_QUANTITY/ condition-expr entity-alias=PPC field-name=operatorEnumId operator=equals value=PRC_GTE/ /condition-list /entity-condition /view-entity view-entity entity-name=ProductPriceBreakMinQty package-name=com.mavericklabel title=Price breaks for each product with their minimum quantity (min qty is optional) member-entity entity-alias=PPRCAT entity-name=ProductPriceCond/ member-entity entity-alias=PCM entity-name=ProductCategoryMember/ member-entity entity-alias=MINQTY entity-name=PPRMinQty/ alias name=productId entity-alias=PCM field=productId/ alias name=productPriceRuleId entity-alias=PPRCAT field=productPriceRuleId/ alias name=minQty entity-alias=MINQTY field=minQty/ alias name=inputParamEnumId entity-alias=PPRCAT field=inputParamEnumId/ alias name=operatorEnumId entity-alias=PPRCAT field=operatorEnumId/ view-link entity-alias=PPRCAT rel-entity-alias=PCM key-map field-name=condValue rel-field-name=productCategoryId/ /view-link view-link entity-alias=PPRCAT rel-entity-alias=MINQTY rel-optional=true key-map field-name=productPriceRuleId/ /view-link entity-condition condition-list condition-expr entity-alias=PPRCAT field-name=inputParamEnumId operator=equals value=PRIP_PROD_CAT_ID/ condition-expr entity-alias=PPRCAT field-name=operatorEnumId operator=equals value=PRC_EQ/ /condition-list /entity-condition /view-entity The resulting SQL looks like this: SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT PPC.PRODUCT_PRICE_RULE_ID AS PPC_PRODUCT_PRICE_RULE_ID, PPC.COND_VALUE AS PPC_COND_VALUE, PPC.INPUT_PARAM_ENUM_ID AS PPC_INPUT_PARAM_ENUM_ID, PPC.OPERATOR_ENUM_ID AS PPC_OPERATOR_ENUM_ID FROM OFBIZ.PRODUCT_PRICE_COND PPC) MINQTY ON PPRCAT.PRODUCT_PRICE_RULE_ID = MINQTY.PPC_PRODUCT_PRICE_RULE_ID WHERE ((PPRCAT.INPUT_PARAM_ENUM_ID = 'PRIP_PROD_CAT_ID' AND PPRCAT.OPERATOR_ENUM_ID = 'PRC_EQ') AND (PPC.INPUT_PARAM_ENUM_ID = 'PRIP_QUANTITY' AND PPC.OPERATOR_ENUM_ID = 'PRC_GTE')) instead of SELECT PCM.PRODUCT_ID, PPRCAT.PRODUCT_PRICE_RULE_ID, MINQTY.PPC_COND_VALUE, PPRCAT.INPUT_PARAM_ENUM_ID, PPRCAT.OPERATOR_ENUM_ID FROM (OFBIZ.PRODUCT_PRICE_COND PPRCAT INNER JOIN OFBIZ.PRODUCT_CATEGORY_MEMBER PCM ON PPRCAT.COND_VALUE = PCM.PRODUCT_CATEGORY_ID) LEFT OUTER JOIN (SELECT
[jira] [Closed] (OFBIZ-6051) In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea)
[ https://issues.apache.org/jira/browse/OFBIZ-6051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6051. -- Resolution: Fixed Fixed in rev 1662120. Thanks! In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea) --- Key: OFBIZ-6051 URL: https://issues.apache.org/jira/browse/OFBIZ-6051 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Adrian Crum Fix For: Upcoming Branch They are still present in R14.12, so must be the widget refactoring I guess Or maybe ESAPI related in relation with OFBIZ-5986, I will check this last point -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6096) Have some Quote demo data
[ https://issues.apache.org/jira/browse/OFBIZ-6096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6096. -- Resolution: Fixed Fixed in rev 1662078. Have some Quote demo data - Key: OFBIZ-6096 URL: https://issues.apache.org/jira/browse/OFBIZ-6096 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: Trunk Reporter: Pierre Smits Assignee: Jacques Le Roux Fix For: Upcoming Branch Attachments: OFBIZ-6096-OrderQuoteDemo.patch Quote demo data is missing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14335218#comment-14335218 ] Adrian Crum commented on OFBIZ-5840: I am removing myself from this issue because I will be unavailable to work on it for the next few months. Create bootstrap theme -- Key: OFBIZ-5840 URL: https://issues.apache.org/jira/browse/OFBIZ-5840 Project: OFBiz Issue Type: Sub-task Components: framework, themes Affects Versions: Trunk Reporter: Julien NICOLAS Assignee: Adrian Crum Labels: bootstrap, theme Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, preferences.png, tab-bar.png, workeffort.PNG 1- create a sub-directory called bootstrap under the image webapp to put the resources over there (js, css and fonts) as indicated earlier by Gavin. (Julien : not sure about location) 2- check to make sure that the current version of jQuery is compatible with the installed version or upgrade it accordingly 3- Create a new theme based on one of the existing themes as suggested by Julien and Gavin 4- Test the theme by switching to it and handle major bugs / issues. 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-5840) Create bootstrap theme
[ https://issues.apache.org/jira/browse/OFBIZ-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-5840: --- Assignee: (was: Adrian Crum) Create bootstrap theme -- Key: OFBIZ-5840 URL: https://issues.apache.org/jira/browse/OFBIZ-5840 Project: OFBiz Issue Type: Sub-task Components: framework, themes Affects Versions: Trunk Reporter: Julien NICOLAS Labels: bootstrap, theme Attachments: Facility.PNG, FindAgreement..png, Footer.jpg, GlobalDecorator.patch, ImprovedFooter.patch, MacroMenuRenderer.patch, OFBIZ-5840-Menufactory.patch, OFBIZ-5840-Menufactory.patch, appbar_menu_ftl.patch, bootified.js, bootified_js_screentrans.patch, bootstrap-theme.zip, bootstrap.zip, calendar.PNG, catalog.png, htmlMenuMacroLibrary.patch, pagination_htmlFormMacroLibrary.patch, panelCollapse_htmlSreenMacroLibrary.patch, party menu tab bar.PNG, preferences.png, tab-bar.png, workeffort.PNG 1- create a sub-directory called bootstrap under the image webapp to put the resources over there (js, css and fonts) as indicated earlier by Gavin. (Julien : not sure about location) 2- check to make sure that the current version of jQuery is compatible with the installed version or upgrade it accordingly 3- Create a new theme based on one of the existing themes as suggested by Julien and Gavin 4- Test the theme by switching to it and handle major bugs / issues. 5- Start to make a few test screens utilizing Bootstrap -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5729) ofbiz hangs on installing tenant database
[ https://issues.apache.org/jira/browse/OFBIZ-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-5729. -- Resolution: Cannot Reproduce ofbiz hangs on installing tenant database -- Key: OFBIZ-5729 URL: https://issues.apache.org/jira/browse/OFBIZ-5729 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Environment: Using: Ubuntu 14.04 java version 1.7.0_67 Java(TM) SE Runtime Environment (build 1.7.0_67-b01) Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) Reporter: Wai Priority: Critical Attachments: ofbiz console output-with bug.log, ofbiz console output-with fix.log, ofbiz-5729.patch, ofbiz-5729.patch, ofbiz-5729.patch When installing data into a tenant database, ofbiz hangs. Using the following command line. $ ant load-tenant-data-readers -Ddata-readers=seed -DtenantId=DEMO1 The problem is that ofbiz uses DelegatorFactory.getDelegator() to find/create the tenant delegator, asynchronously, for the target tenant database using a single daemon thread. As part of the tenant delegator creation, it needs to find/create a base delegator. When the base delegator is intially absent, ofbiz will block trying to create one by using the same daemon thread--which is already being used. Hence, ofbiz is deadlocked. The solution is to make sure that a base delegator is always created first before a find/create tenant delegator is attempted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-5879) Sometimes, RMIDispatcher cannot be constructed
[
https://issues.apache.org/jira/browse/OFBIZ-5879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum closed OFBIZ-5879.
--
Resolution: Fixed
Fix Version/s: Upcoming Branch
Null pointer check added in rev 1662084. Thanks Scott!
Sometimes, RMIDispatcher cannot be constructed
--
Key: OFBIZ-5879
URL: https://issues.apache.org/jira/browse/OFBIZ-5879
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Trunk
Reporter: Leon
Assignee: Adrian Crum
Fix For: Upcoming Branch
sometimes, the ofbiz instance startup failed because following error:
{quote}
java.lang.NullPointerException
at javolution.util.FastMap$Entry.access$302(FastMap.java:1530)
at javolution.util.FastMap.put(FastMap.java:490)
at javolution.util.FastMap.put(FastMap.java:453)
at
org.ofbiz.service.group.ServiceGroupReader.addGroupDefinitions(ServiceGroupReader.java:79)
at
org.ofbiz.service.group.ServiceGroupReader.readConfig(ServiceGroupReader.java:62)
at
org.ofbiz.service.ServiceDispatcher.init(ServiceDispatcher.java:104)
at
org.ofbiz.service.ServiceDispatcher.init(ServiceDispatcher.java:151)
at
org.ofbiz.service.ServiceDispatcher.getInstance(ServiceDispatcher.java:183)
at
org.ofbiz.service.ServiceDispatcher.getLocalDispatcher(ServiceDispatcher.java:162)
at
org.ofbiz.service.GenericDispatcherFactory.createLocalDispatcher(GenericDispatcherFactory.java:46)
at
org.ofbiz.service.ServiceContainer.getLocalDispatcher(ServiceContainer.java:90)
at
org.ofbiz.service.rmi.RmiServiceContainer.start(RmiServiceContainer.java:133)
at
org.ofbiz.base.container.ContainerLoader.start(ContainerLoader.java:237)
at org.ofbiz.base.start.Start.startStartLoaders(Start.java:341)
at org.ofbiz.base.start.Start.start(Start.java:367)
at org.ofbiz.base.start.Start.main(Start.java:135)
20141110104822705 |Thread-0 |ContainerLoader |I|
Shutting down containers
20141110104822705 |Thread-0 |ContainerLoader |I|
Stopping container birt-container
20141110104822706 |Thread-0 |ContainerLoader |I|
Stopped container birt-container
20141110104822706 |Thread-0 |ContainerLoader |I|
Stopping container catalina-container
20141110104822706 |Thread-0 |ContainerLoader |I|
Stopped container catalina-container
20141110104822706 |Thread-0 |ContainerLoader |I|
Stopping container rmi-dispatcher
java.lang.NullPointerException
at
org.ofbiz.service.rmi.RmiServiceContainer.stop(RmiServiceContainer.java:176)
at
org.ofbiz.base.container.ContainerLoader.unload(ContainerLoader.java:264)
at org.ofbiz.base.start.Start.shutdownServer(Start.java:317)
at org.ofbiz.base.start.Start$1.run(Start.java:231)
{quote}
Since it's hard to reproduce, and I'm not familiar with the logic behind it,
I'm unable to figure out what the root cause is.
Anyone can help?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6084) Find account doesn't return accounts anymore
[ https://issues.apache.org/jira/browse/OFBIZ-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6084: -- Assignee: Adrian Crum Find account doesn't return accounts anymore Key: OFBIZ-6084 URL: https://issues.apache.org/jira/browse/OFBIZ-6084 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Trunk, 14.12.01 Reporter: Pierre Smits Assignee: Adrian Crum Priority: Blocker Labels: account, sfa Attachments: OFBIZ-6084.patch, OFBIZ-6084.patch Since after r13.07 searching for accounts in the SFA application no results are displayed anymore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5729) ofbiz hangs on installing tenant database
[ https://issues.apache.org/jira/browse/OFBIZ-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333579#comment-14333579 ] Adrian Crum commented on OFBIZ-5729: I followed all of the steps you described and I am unable to reproduce the problem. This appears to be an intermittent problem, and without a unit test to prove it exists, it is difficult to fix. ofbiz hangs on installing tenant database -- Key: OFBIZ-5729 URL: https://issues.apache.org/jira/browse/OFBIZ-5729 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Environment: Using: Ubuntu 14.04 java version 1.7.0_67 Java(TM) SE Runtime Environment (build 1.7.0_67-b01) Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) Reporter: Wai Assignee: Adrian Crum Priority: Critical Attachments: ofbiz console output-with bug.log, ofbiz console output-with fix.log, ofbiz-5729.patch, ofbiz-5729.patch, ofbiz-5729.patch When installing data into a tenant database, ofbiz hangs. Using the following command line. $ ant load-tenant-data-readers -Ddata-readers=seed -DtenantId=DEMO1 The problem is that ofbiz uses DelegatorFactory.getDelegator() to find/create the tenant delegator, asynchronously, for the target tenant database using a single daemon thread. As part of the tenant delegator creation, it needs to find/create a base delegator. When the base delegator is intially absent, ofbiz will block trying to create one by using the same daemon thread--which is already being used. Hence, ofbiz is deadlocked. The solution is to make sure that a base delegator is always created first before a find/create tenant delegator is attempted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-5729) ofbiz hangs on installing tenant database
[ https://issues.apache.org/jira/browse/OFBIZ-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-5729: -- Assignee: (was: Adrian Crum) ofbiz hangs on installing tenant database -- Key: OFBIZ-5729 URL: https://issues.apache.org/jira/browse/OFBIZ-5729 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Environment: Using: Ubuntu 14.04 java version 1.7.0_67 Java(TM) SE Runtime Environment (build 1.7.0_67-b01) Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode) Reporter: Wai Priority: Critical Attachments: ofbiz console output-with bug.log, ofbiz console output-with fix.log, ofbiz-5729.patch, ofbiz-5729.patch, ofbiz-5729.patch When installing data into a tenant database, ofbiz hangs. Using the following command line. $ ant load-tenant-data-readers -Ddata-readers=seed -DtenantId=DEMO1 The problem is that ofbiz uses DelegatorFactory.getDelegator() to find/create the tenant delegator, asynchronously, for the target tenant database using a single daemon thread. As part of the tenant delegator creation, it needs to find/create a base delegator. When the base delegator is intially absent, ofbiz will block trying to create one by using the same daemon thread--which is already being used. Hence, ofbiz is deadlocked. The solution is to make sure that a base delegator is always created first before a find/create tenant delegator is attempted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6084) Find account doesn't return accounts anymore
[ https://issues.apache.org/jira/browse/OFBIZ-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6084. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1661760. Thanks! Find account doesn't return accounts anymore Key: OFBIZ-6084 URL: https://issues.apache.org/jira/browse/OFBIZ-6084 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Trunk, 14.12.01 Reporter: Pierre Smits Assignee: Adrian Crum Priority: Blocker Labels: account, sfa Fix For: Upcoming Branch Attachments: OFBIZ-6084.patch, OFBIZ-6084.patch Since after r13.07 searching for accounts in the SFA application no results are displayed anymore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6051) In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea)
[ https://issues.apache.org/jira/browse/OFBIZ-6051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334028#comment-14334028 ] Adrian Crum commented on OFBIZ-6051: It appears to be a portal page problem caused by the widget refactor. I am working on it. In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea) --- Key: OFBIZ-6051 URL: https://issues.apache.org/jira/browse/OFBIZ-6051 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Adrian Crum Fix For: Upcoming Branch They are still present in R14.12, so must be the widget refactoring I guess Or maybe ESAPI related in relation with OFBIZ-5986, I will check this last point -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6084) Find account doesn't return accounts anymore
[ https://issues.apache.org/jira/browse/OFBIZ-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14330419#comment-14330419 ] Adrian Crum commented on OFBIZ-6084: I added the type check as a validation - so you can't extend a single form to a list form (or the other way around). It would be better to find out why the form type is empty and fix it. Find account doesn't return accounts anymore Key: OFBIZ-6084 URL: https://issues.apache.org/jira/browse/OFBIZ-6084 Project: OFBiz Issue Type: Bug Components: marketing Affects Versions: Trunk, 14.12.01 Reporter: Pierre Smits Priority: Blocker Labels: account, sfa Attachments: OFBIZ-6084.patch Since after r13.07 searching for accounts in the SFA application no results are displayed anymore. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5569) Add production run task inspection capabilities using time entry improvements
[ https://issues.apache.org/jira/browse/OFBIZ-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326219#comment-14326219 ] Adrian Crum commented on OFBIZ-5569: You can make things less granular, but it wouldn't meet the requirement of tracking the distinct unit of work and time spent by the worker. Add production run task inspection capabilities using time entry improvements - Key: OFBIZ-5569 URL: https://issues.apache.org/jira/browse/OFBIZ-5569 Project: OFBiz Issue Type: Improvement Components: manufacturing Affects Versions: Trunk Reporter: Christian Carlow Assignee: Pierre Smits There doesn't seem to be a standard method for handling production run inspections that offer any real power in terms of reporting. The system already lacks time entry functionality which will be added in OFBIZ-5532. Once time entry functionality is added to the declaration services, TimeEntryAssoc could be created to link an inspection time entries to a manufacturing work time entries to represent an inspection of manufacturing work. The goal is to be able to determine the number of bad pieces produced per manufacturing worker and who was the inspector. The functionality should also be flexible and powerful enough to distinguish who is actually at fault for the bad piece. In most cases, the manufacturing workers will be at fault, but there could be times where an inspector might accidentally drop a good or potentially good piece and the system should be able to flag them as the party actually responsible for the defect. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5569) Add production run task inspection capabilities using time entry improvements
[
https://issues.apache.org/jira/browse/OFBIZ-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326179#comment-14326179
]
Adrian Crum commented on OFBIZ-5569:
Maybe I wasn't clear, so I will draw a picture:
{code}
InventoryItemDetail
|
|__WorkEffort (Create Widget)
|
|__ WorkEffort (Assemble Widget)
| |
| |__ Party (Assembler)
|
|__ WorkEffort (Inspect Assembly)
| |
| |__ Party (Inspector)
|
|__ WorkEffort (Rework part)
| |
| |__ Party (Assembler)
|
|__ WorkEffort (Inspect Assembly)
| |
| |__ Party (Inspector)
|
.
.
.
{code}
Add production run task inspection capabilities using time entry improvements
-
Key: OFBIZ-5569
URL: https://issues.apache.org/jira/browse/OFBIZ-5569
Project: OFBiz
Issue Type: Improvement
Components: manufacturing
Affects Versions: Trunk
Reporter: Christian Carlow
Assignee: Pierre Smits
There doesn't seem to be a standard method for handling production run
inspections that offer any real power in terms of reporting. The system
already lacks time entry functionality which will be added in OFBIZ-5532.
Once time entry functionality is added to the declaration services,
TimeEntryAssoc could be created to link an inspection time entries to a
manufacturing work time entries to represent an inspection of manufacturing
work. The goal is to be able to determine the number of bad pieces produced
per manufacturing worker and who was the inspector. The functionality should
also be flexible and powerful enough to distinguish who is actually at fault
for the bad piece. In most cases, the manufacturing workers will be at
fault, but there could be times where an inspector might accidentally drop a
good or potentially good piece and the system should be able to flag them as
the party actually responsible for the defect.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-5569) Add production run task inspection capabilities using time entry improvements
[ https://issues.apache.org/jira/browse/OFBIZ-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14326090#comment-14326090 ] Adrian Crum commented on OFBIZ-5569: Don't forget that the WorkEffort entity has a recursive relationship, so InventoryItemDetail.workEffortId could point to an arbitrarily complex set of work efforts. I believe the existing data model will meet your requirements. Add production run task inspection capabilities using time entry improvements - Key: OFBIZ-5569 URL: https://issues.apache.org/jira/browse/OFBIZ-5569 Project: OFBiz Issue Type: Improvement Components: manufacturing Affects Versions: Trunk Reporter: Christian Carlow Assignee: Pierre Smits There doesn't seem to be a standard method for handling production run inspections that offer any real power in terms of reporting. The system already lacks time entry functionality which will be added in OFBIZ-5532. Once time entry functionality is added to the declaration services, TimeEntryAssoc could be created to link an inspection time entries to a manufacturing work time entries to represent an inspection of manufacturing work. The goal is to be able to determine the number of bad pieces produced per manufacturing worker and who was the inspector. The functionality should also be flexible and powerful enough to distinguish who is actually at fault for the bad piece. In most cases, the manufacturing workers will be at fault, but there could be times where an inspector might accidentally drop a good or potentially good piece and the system should be able to flag them as the party actually responsible for the defect. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6074) controller view-map type=screenxml broken
[ https://issues.apache.org/jira/browse/OFBIZ-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6074. -- Resolution: Fixed Fix Version/s: Upcoming Branch Fixed in rev 1659965. Thanks! controller view-map type=screenxml broken --- Key: OFBIZ-6074 URL: https://issues.apache.org/jira/browse/OFBIZ-6074 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: Trunk Reporter: Christian Carlow Assignee: Adrian Crum Fix For: Upcoming Branch Errors occur when exporting to xml using controller view-map type=screenxml. To reproduce: 1. Navigate to Accounting - Global GL 2. Click Export for Accounts List -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6060) We can no longer reset services definitions by clearing caches
[ https://issues.apache.org/jira/browse/OFBIZ-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6060: -- Assignee: Adrian Crum We can no longer reset services definitions by clearing caches -- Key: OFBIZ-6060 URL: https://issues.apache.org/jira/browse/OFBIZ-6060 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 14.12.01 Reporter: Jacques Le Roux Assignee: Adrian Crum Fix For: 14.12.01, Upcoming Branch Rupert Howell told me that between the middle of 2014 and the end of October we lost the possiblity to reset services definitions by clearing caches (or simply the service caches: service.ModelServiceMapByModel and service.ServiceConfig). I did some research and I found it is due to http://svn.apache.org/viewvc?view=revisionrevision=r1622256 I did not digg further. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6060) We can no longer reset services definitions by clearing caches
[ https://issues.apache.org/jira/browse/OFBIZ-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308063#comment-14308063 ] Adrian Crum edited comment on OFBIZ-6060 at 2/5/15 9:53 PM: Are you sure that revision is the cause of the regression? All I did was move the cache from one class to another. was (Author: adri...@hlmksw.com): Are you sure that revision is the cause of the regression? All I did was move the cache from one cache to another. We can no longer reset services definitions by clearing caches -- Key: OFBIZ-6060 URL: https://issues.apache.org/jira/browse/OFBIZ-6060 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 14.12.01 Reporter: Jacques Le Roux Assignee: Adrian Crum Fix For: 14.12.01, Upcoming Branch Rupert Howell told me that between the middle of 2014 and the end of October we lost the possiblity to reset services definitions by clearing caches (or simply the service caches: service.ModelServiceMapByModel and service.ServiceConfig). I did some research and I found it is due to http://svn.apache.org/viewvc?view=revisionrevision=r1622256 I did not digg further. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-6060) We can no longer reset services definitions by clearing caches
[ https://issues.apache.org/jira/browse/OFBIZ-6060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed OFBIZ-6060. -- Resolution: Fixed Fix Version/s: (was: 14.12.01) Fixed in rev 1657714. Thanks! We can no longer reset services definitions by clearing caches -- Key: OFBIZ-6060 URL: https://issues.apache.org/jira/browse/OFBIZ-6060 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, 14.12.01 Reporter: Jacques Le Roux Assignee: Adrian Crum Fix For: Upcoming Branch Rupert Howell told me that between the middle of 2014 and the end of October we lost the possiblity to reset services definitions by clearing caches (or simply the service caches: service.ModelServiceMapByModel and service.ServiceConfig). I did some research and I found it is due to http://svn.apache.org/viewvc?view=revisionrevision=r1622256 I did not digg further. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-6051) In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea)
[ https://issues.apache.org/jira/browse/OFBIZ-6051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-6051: -- Assignee: Adrian Crum In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea) --- Key: OFBIZ-6051 URL: https://issues.apache.org/jira/browse/OFBIZ-6051 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Reporter: Jacques Le Roux Assignee: Adrian Crum Fix For: Upcoming Branch They are still present in R14.12, so must be the widget refactoring I guess Or maybe ESAPI related in relation with OFBIZ-5986, I will check this last point -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6051) In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea)
[ https://issues.apache.org/jira/browse/OFBIZ-6051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14300200#comment-14300200 ] Adrian Crum commented on OFBIZ-6051: Link please. In trunk we lost the Edit and Delete buttons in Store Facilites screen (ajaxUpdateArea) --- Key: OFBIZ-6051 URL: https://issues.apache.org/jira/browse/OFBIZ-6051 Project: OFBiz Issue Type: Bug Components: product Affects Versions: Trunk Reporter: Jacques Le Roux Fix For: Upcoming Branch They are still present in R14.12, so must be the widget refactoring I guess Or maybe ESAPI related in relation with OFBIZ-5986, I will check this last point -- This message was sent by Atlassian JIRA (v6.3.4#6332)
