[jira] [Commented] (OFBIZ-7755) Geo data for Turkey
[ https://issues.apache.org/jira/browse/OFBIZ-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362264#comment-15362264 ] Bilgin Ibryam commented on OFBIZ-7755: -- thanks Tufan > Geo data for Turkey > --- > > Key: OFBIZ-7755 > URL: https://issues.apache.org/jira/browse/OFBIZ-7755 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Tufan Kaynak >Priority: Minor > Labels: address, geodata, province, regions, turkey > Attachments: ofbizGeoDataTUR02.patch > > > Please find attached the patch file for including Province data for Turkey > via GeoData_TR.xml and address format for Turkey in GeoData.xml -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-4330) Overview of invoices in AP and AR don't show invoices with status approved
[ https://issues.apache.org/jira/browse/OFBIZ-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-4330. Resolution: Fixed Assignee: Bilgin Ibryam Thanks Pierre, your patch is in trunk r1155300 Overview of invoices in AP and AR don't show invoices with status approved -- Key: OFBIZ-4330 URL: https://issues.apache.org/jira/browse/OFBIZ-4330 Project: OFBiz Issue Type: Improvement Components: accounting Affects Versions: SVN trunk Reporter: Pierre Smits Assignee: Bilgin Ibryam Labels: patch Fix For: SVN trunk Attachments: ofbiz-trunk-accounting-invoiceReport-20110706.patch Original Estimate: 2h Remaining Estimate: 2h Currently the overviews of invoices of both AP and AR don't show invoices with status 'INVOICE_READY'. Also the overviews of invoices in the future don't differentiate between AP and AR invoices. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (OFBIZ-4357) CopyQuote service return new quote id
[ https://issues.apache.org/jira/browse/OFBIZ-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-4357. Resolution: Fixed Assignee: Bilgin Ibryam Thanks Leon, I made the quoteId field INOUT so it can be used to return the new quote Id. It is in trunk r1152729 CopyQuote service return new quote id - Key: OFBIZ-4357 URL: https://issues.apache.org/jira/browse/OFBIZ-4357 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Leon Assignee: Bilgin Ibryam Priority: Trivial Attachments: CopyQuote.patch To be able to extend sales quote copy function, we modify current CopyQuote service to return the id of new created quote. It's a very very trivial update. I wonder whether it's worth of a commit. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OFBIZ-4345) voided payments are auto-applied to new order invoices
[
https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam reassigned OFBIZ-4345:
Assignee: Bilgin Ibryam
voided payments are auto-applied to new order invoices
--
Key: OFBIZ-4345
URL: https://issues.apache.org/jira/browse/OFBIZ-4345
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Martin Kreidenweis
Assignee: Bilgin Ibryam
Attachments: OFBIZ-4345-voidedAutoApply.patch
{{InvoiceServices.createInvoiceForOrder}} automatically creates
{{PaymentApplication}} records when unapplied payments exist for the order.
Unfortunately this doesn't consider the {{Payment.statusId}}.
So when a user accidentally enters a wrong payment and voids it right away,
it is still automatically applied to the invoice on invoice creation. The GUI
then provides no way to un-apply the payment, because it assumes that for
voided payments no payment applications can exist any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4345) voided payments are auto-applied to new order invoices
[
https://issues.apache.org/jira/browse/OFBIZ-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073590#comment-13073590
]
Bilgin Ibryam commented on OFBIZ-4345:
--
Martin,
your patch seems to be OK, but what about also filtering out
OrderPaymentPreference with statusId PAYMENT_CANCELLED?
Is it going to work fine in your case?
voided payments are auto-applied to new order invoices
--
Key: OFBIZ-4345
URL: https://issues.apache.org/jira/browse/OFBIZ-4345
Project: OFBiz
Issue Type: Bug
Components: accounting
Affects Versions: SVN trunk
Reporter: Martin Kreidenweis
Assignee: Bilgin Ibryam
Attachments: OFBIZ-4345-voidedAutoApply.patch
{{InvoiceServices.createInvoiceForOrder}} automatically creates
{{PaymentApplication}} records when unapplied payments exist for the order.
Unfortunately this doesn't consider the {{Payment.statusId}}.
So when a user accidentally enters a wrong payment and voids it right away,
it is still automatically applied to the invoice on invoice creation. The GUI
then provides no way to un-apply the payment, because it assumes that for
voided payments no payment applications can exist any more.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-3557) Enforced sequence does not work with concurrent access
[ https://issues.apache.org/jira/browse/OFBIZ-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13040205#comment-13040205 ] Bilgin Ibryam commented on OFBIZ-3557: -- Jacopo, your example cases seems logical to me, one question though: You said createInvoice for B assigns InvoiceId 12 and when attempts to store the invoice it gets a duplicated PK error; Why there would be duplicate PK error? the previous invoice had id 11? I think in the second case there wouldn't be any duplicated PK errors. There might be other errors preventing invoice creation and lead to invoiceId gaps? Enforced sequence does not work with concurrent access -- Key: OFBIZ-3557 URL: https://issues.apache.org/jira/browse/OFBIZ-3557 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 09.04, SVN trunk Reporter: Wickersheimer Jeremy Attachments: OFBIZ-3557-1.patch, OFBIZ-3557-2.patch There is a fundamental issue with enforced sequences (for orders, invoices, etc ..) and concurrency. For example if two users are creating an order at the same time one of them will see the creation fail with a PK error. The problem is that the getNextXXXId rely on the party accounting preference entity, but there is absolutely no guarantee that the last number in the sequence gets updated before another service can read it. This is at best very annoying when used only internally but may be unpractical for e-commerce sites. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3862) Ajax requests prevent externalLoginKey parameters from working correctly
[ https://issues.apache.org/jira/browse/OFBIZ-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12991396#comment-12991396 ] Bilgin Ibryam commented on OFBIZ-3862: -- I'm also concerned about the security, but I think it is ok Ajax requests prevent externalLoginKey parameters from working correctly Key: OFBIZ-3862 URL: https://issues.apache.org/jira/browse/OFBIZ-3862 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Scott Gray Attachments: externalKey.patch, externalKey.patch A new external login key is generated for every request so if an ajax request fires on a page then the externalLoginKey used in any links on the page is invalidated. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3842) Security Update for forgotten passwords
[ https://issues.apache.org/jira/browse/OFBIZ-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934798#action_12934798 ] Bilgin Ibryam commented on OFBIZ-3842: -- + 1 looks nice I think by default requirePasswordChange should behave the same way as in Email password feature. If it is not required to change the password after using Email password link, then it shouldn't be also after generating a random password. Still it is not a big deal, since it is configurable Security Update for forgotten passwords --- Key: OFBIZ-3842 URL: https://issues.apache.org/jira/browse/OFBIZ-3842 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Sascha Rodekamp Assignee: Erwan de FERRIERES Fix For: SVN trunk Attachments: OFBIZ-3842_security.patch, OFBIZ-3842_security.patch, OFBIZ-3842_security.patch Hi everybody, here is a patch that generated a radom Password when the require new password function is called. In the current Trunk it's a kind of hard coded password that will be send to the user. After generating a new pass the requireNewPassword flag will be set to true (configurable). Have a good day Sascha -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3862) Ajax requests prevent externalLoginKey parameters from working correctly
[ https://issues.apache.org/jira/browse/OFBIZ-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919486#action_12919486 ] Bilgin Ibryam commented on OFBIZ-3862: -- I think a soltuion would be to skip generating of new external login key for ajax requests. Ajax requests can be identified by presens of 'X-Requested-With': 'XMLHttpRequest', http header. It is set by most of the javascript libraries we use: prototype, jquery. WDYT? Bilgin Ajax requests prevent externalLoginKey parameters from working correctly Key: OFBIZ-3862 URL: https://issues.apache.org/jira/browse/OFBIZ-3862 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Scott Gray A new external login key is generated for every request so if an ajax request fires on a page then the externalLoginKey used in any links on the page is invalidated. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3211) Ajaxifying lookup fields
[ https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12863161#action_12863161 ] Bilgin Ibryam commented on OFBIZ-3211: -- Thanks Adrian. BTW in rev 940274 I moved the span and img creation to javascript, but I think it doesn't solve the empty src attribute problem. At least now it the renderer is cleaner. Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3515) Use UiLabel for required
[ https://issues.apache.org/jira/browse/OFBIZ-3515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3515. Assignee: Bilgin Ibryam Resolution: Fixed Thanks Deepak, your patch is in trunk rev 937278 Use UiLabel for required --- Key: OFBIZ-3515 URL: https://issues.apache.org/jira/browse/OFBIZ-3515 Project: OFBiz Issue Type: Improvement Components: specialpurpose/ecommerce Affects Versions: SVN trunk Reporter: Deepak Dixit Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3515.patch There are too many places where required is hard coded , need to use appropriate uiLabel for the same. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12858573#action_12858573 ] Bilgin Ibryam commented on OFBIZ-3555: -- Thanks for testing Jacques. I saw your post in OFBIZ-3442 that actually there is no error. I tested the lookup descriptions in catalog and order manager, and it is working correct in both places using FTL. If you find a specific screen, let me know and I will check it. In the mean time I did a fix in rev 935644, which was needed after changes in the generated html Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3521) Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN
[ https://issues.apache.org/jira/browse/OFBIZ-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3521. Assignee: Bilgin Ibryam Fix Version/s: SVN trunk Resolution: Fixed Added the field in rev 935387. Feel free to improve the descriptions. Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN - Key: OFBIZ-3521 URL: https://issues.apache.org/jira/browse/OFBIZ-3521 Project: OFBiz Issue Type: Improvement Components: workeffort Affects Versions: SVN trunk Reporter: chris snow Assignee: Bilgin Ibryam Priority: Trivial Fix For: SVN trunk To improve usability of the example DAYOFWEEK_0x expressions, they would be more easily understood if they use the actual day name. Looking at DAYOFWEEK_01, I wasn't sure whether this was SUN or MON without looking at the expression definition. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12855856#action_12855856 ] Bilgin Ibryam commented on OFBIZ-3541: -- Thanks Blas, fixed in rev 933108 Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Fix For: SVN trunk Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3555. Resolution: Fixed Committed to trunk in rev 933130 To see this feature in action set widget.lookup.showDescription to Y in widget.properties Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Made show/hide lookup description configurable from widget.properties Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch, lookup_description.patch, lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853924#action_12853924 ] Bilgin Ibryam commented on OFBIZ-3541: -- Jacques, I applied your patch, browsed a little bit and didn't notice anything wrong. Bilgin Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853245#action_12853245 ] Bilgin Ibryam commented on OFBIZ-3541: -- Jacques, In rev 930660 I committed my patch (I don't want it to get obsolete) and also updated yours (replaced ormrenderer.renderLookupField with htmlTemplate.lookupField) Also could you tell me why we need to replace targets in controllers? Can't we reuse existing requests? I can't see the related discussion about this change? Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: - Attachment: OFBIZ-3541 Using Widgets html form templates in FTL files.patch Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Sub-task Reporter: Bruno Busco Assignee: Bruno Busco Attachments: OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, OFBIZ-3541 Using Widgets html form templates in FTL files.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)
[
https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12853247#action_12853247
]
Bilgin Ibryam commented on OFBIZ-3623:
--
Blas,
in rev 930670 I removed double ampersands from autoCompleterTarget because it
was breaking the lookup autocompleter.
Why do we need double ampersands there in case that autoCompleterTarget is not
a real url, but part of javscript code?
Bilgin
XHTML validation errors (framework/widget)
--
Key: OFBIZ-3623
URL: https://issues.apache.org/jira/browse/OFBIZ-3623
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Blas Rodriguez Somoza
Assignee: Adrian Crum
Priority: Trivial
Fix For: SVN trunk
Attachments: OFBIZ-3623_framework_widget_xhtml.diff,
OFBIZ-3623_framework_widget_xhtml_v2.diff
XHTML validation errors
* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without
* Uppercase tags or attributes.
* Unencoded ampersands in urls.
Other errors:
htmlFormMacroLibrary.ftl
Line 452. img tag must have src and alt attributes.
span id=${id}_indicator style=display: none class=indicatorimg
//span
htmlScreenMacroLibrary.ftl
Wrong markup at Line 143. Entity without final ;
nbsp/a/li
Changes in java classes:
MacroFormRenderer.java (renderSortField)
The sort URL must use encoded ampersands.
HtmlFormRenderer.java (renderDisplayField)
The alert style must be included in the class attribute not appear as a
attribute name (which is what happens now)
HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
XHTML don't like empty UL. To avoid that, the renderMenuOpen and
renderMenuClose methods need to know how many menu items pass the condition
and so will be included.
ModelMenu.java (public int passConditionCount)
New method to get how many menu items pass the condition.
ModelMenuItem (public boolean passCondition)
New method to get if the menu item pass the condition.
Patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups
[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12851381#action_12851381 ] Bilgin Ibryam commented on OFBIZ-3442: -- Jacques, what I tried to say is that the default position (it doesn't matter for me if it is center , normal or something else) should be set only in xsd file, but not in all the forms and fields. This way, changing the default position will require only a change in xsd file instead of all the form fields. Replace popup lookups by layer lookups -- Key: OFBIZ-3442 URL: https://issues.apache.org/jira/browse/OFBIZ-3442 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups. For that please find a patch attached. In this patch I followed a simple S/R tactic: * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens * I replaced all occurences of lookup by lookup presentation=layer position=center It's as simple as this. For the moment I decided to use as default position=center because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position=center and use the default (position=normal) which does not move the layer from the point it's called and will be more aesthetic. I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far. The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in. Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them. There are issues to be fixed prior to a commit, see OFBIZ-3446. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: - Attachment: widgetMacrosInFtlImprove.patch.diff Bruno, I made some improvements to your code in order to add autocompleter support in ftl lookups. To achieve this, I introduced the initial template file you created and set there all the default values needed by htmlFormMacroLibrary.ftl. This gives more possibilities to get the default values in case they are not fixed strings (like autocompleter url) and keeps the rendering ftl cleaner. I attached the patch here, in case you (or someone else) wants to check it, before committing. Next strep would be to replace all the lookup fields (around 70) in ftl files with new lookup macro. Bilgin Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Assignee: Bruno Busco Attachments: widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reopened OFBIZ-3541: -- Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Assignee: Bruno Busco Attachments: widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtlImprove.patch.diff The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3555) Show lookup value descriptions
Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3555) Show lookup value descriptions
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12845321#action_12845321 ] Bilgin Ibryam commented on OFBIZ-3555: -- Jacques, I think we are on the same page. The final goal is to have possibility for displaying description/name instead_of OR together_with the ID. In most of other web based systems it is the way you described: the ID is stored in a hidden field, and the description is in the input box. I think this can be easily done once we have the descriptions available. But as you already know ofbiz lookup definitions don't have information about how to get the description information (there is only lookup url) so I decided to reuse the autocompleter logic and get the description the same way. Note that autocompleter and lookup descriptions are available only to form widget lookups which refer to lookup screens with autocompleter support. Once we are sure that it is covered in most of ofbiz screen we can think on hiding the IDs totally (or it can be configured) and display only the description. Show lookup value descriptions -- Key: OFBIZ-3555 URL: https://issues.apache.org/jira/browse/OFBIZ-3555 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: lookup_description.patch I did a small extention to lookup autocompleter code and now it is able to load description for the lookup field values. For example when you load a form with lookup fields, currently you see only the Id in the lookup field (which is not very descriptive). After applying the patch, you will see also a description, next to lookup button. The description value is the same one that appears in the autocompler and it is specifiued for in each lookup screen. You will see the description also when a value is returned from a lookup screen or when a value is selected from autocompleter or when you type a valid Id in the lookup field. Internally it does an ajax call to get the description for the supplied value in lookup field. I'd like to know if you want to see this feature in ofbiz and/or if you have any ideas to improve it. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3529) Derby database can truncate entity fields 8K
[ https://issues.apache.org/jira/browse/OFBIZ-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12843971#action_12843971 ] Bilgin Ibryam commented on OFBIZ-3529: -- Hi Mike, could you check if the error is gone after rev 921455 Bilgin Derby database can truncate entity fields 8K --- Key: OFBIZ-3529 URL: https://issues.apache.org/jira/browse/OFBIZ-3529 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: OS X, Derby database Reporter: Mike Voytovich I was attempting to use the UPS shipment code in OFBiz to generate shipping labels. Note that this was using the default Derby database. OFBiz is able to send the confirm/accept requests and receive the responses, but an error is returned from UPS in handleUpsShipmentAcceptResponse - The XML document is not well formed. It turns out that we're properly receiving a 20,000 byte ShipmentDigest from UPS in the handleUpsShipmentConfirmResponse method; but it looks like this is being truncated to exactly 8K when written out to the ShipmentRouteSegment entity. i.e., the ShipmentDigest data is truncated to 8K when being read back from the entity. The trackingDigest field-type is very-long with a SQL type of CLOB, so I would expect it to save ~20K without issue. I switched over to MySQL for the database, and now the data is stored correctly. Note that there are no error messages in the logs regarding this truncation, and there's nothing in the documentation indicating that entity fields are limited to 8K when using the Derby database. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3541: - Attachment: widgetMacrosInFtl.patch Bruno, I tested your patch, good work, thanks for it. Also updated the patch, so we don't need to import the macros in each template. Bilgin Using Widgets html form templates in FTL files -- Key: OFBIZ-3541 URL: https://issues.apache.org/jira/browse/OFBIZ-3541 Project: OFBiz Issue Type: Improvement Reporter: Bruno Busco Attachments: widgetMacrosInFtl.patch, widgetMacrosInFtl.patch, widgetMacrosInFtl.patch The attached patch introduces a way to let developers to use the templates defined in htmlMacroFormLibrary.ftl in the FTL files. This was discussed in the mailing list and it seems that we all agree that having this feature could be a good thing. In the patch I used the renderLookupField in the main.ftl file of the catalog application. By doing this the two lookups that are included in this ftl are now rendered similar to how they are from a form widget. This allows the Tomahawk theme to render these lookups in the supposed way (with the card icon). Doing this I changed the macro in the htmlMacroFormLibrary.ftl to have all parameters with a default value so that only the relevant ones must be specified in the FTL. A new template.ftl file has been added but this only includes the htmlMacroFormLibrary.ftl. I do not know if there is a better way to have the macro available in the FTL file. Please fill free to comment any of the choise I did so that we could then commit this and extend to other macros. I guess the next one I will address is the renderNextPrev so that all paginations will look the same in all forms/FTL screens. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3521) Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN
[ https://issues.apache.org/jira/browse/OFBIZ-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12842001#action_12842001 ] Bilgin Ibryam commented on OFBIZ-3521: -- I also think a description would be helpful, IDs are not very user friendly Rename temporal DAYOFWEEK_01 to DAYOFWEEK_SUN - Key: OFBIZ-3521 URL: https://issues.apache.org/jira/browse/OFBIZ-3521 Project: OFBiz Issue Type: Improvement Components: workeffort Affects Versions: SVN trunk Reporter: chris snow Priority: Trivial To improve usability of the example DAYOFWEEK_0x expressions, they would be more easily understood if they use the actual day name. Looking at DAYOFWEEK_01, I wasn't sure whether this was SUN or MON without looking at the expression definition. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3368) workeffort calendar bug when no demo data is installed
[ https://issues.apache.org/jira/browse/OFBIZ-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3368. Resolution: Fixed Assignee: Bilgin Ibryam Thanks Chris. A modified version is committed to trunk rev 916703 Bilgin workeffort calendar bug when no demo data is installed -- Key: OFBIZ-3368 URL: https://issues.apache.org/jira/browse/OFBIZ-3368 Project: OFBiz Issue Type: Bug Components: workeffort Affects Versions: Release Branch 9.04, SVN trunk Reporter: chris snow Assignee: Bilgin Ibryam Attachments: workeffortCalendar_Trunk.diff I have installed the extseed data, but NOT the demo data. When I go to the Calendar in webtools (logged in as admin) using the URL https://localhost:8443/workeffort/control/day, I get the following exception. org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen [component://workeffort/widget/CalendarScreens.xml#CalendarDay]: org.ofbiz.base.util.GeneralException: Error running Groovy script at location [component://workeffort/webapp/workeffort/WEB-INF/actions/calendar/Days.groovy] (Service [getWorkEffortEventsByPeriod] target threw an unexpected exception (null)) (Error running Groovy script at location [component://workeffort/webapp/workeffort/WEB-INF/actions/calendar/Days.groovy] (Service [getWorkEffortEventsByPeriod] target threw an unexpected exception (null))) I'm not sure if this is a bug, but I would have expected is to work with extseed data. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3484) Field which do not show any info or cannot be edited needs to be hidden
[ https://issues.apache.org/jira/browse/OFBIZ-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3484. Resolution: Fixed Fix Version/s: SVN trunk Assignee: Bilgin Ibryam Thanks Babu, it is fixed in trunk rev 916206 Field which do not show any info or cannot be edited needs to be hidden --- Key: OFBIZ-3484 URL: https://issues.apache.org/jira/browse/OFBIZ-3484 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk Environment: SVN Rev. 910622 Reporter: Babu Sreekanth Assignee: Bilgin Ibryam Priority: Trivial Fix For: SVN trunk Attachments: screenshot.3.png In Accounting Manager -- Agreements -- Create Agreement Item screen, Agreement Item Seq Id label is displayed without any text or input field. See the attached image. This field probably needs to be hidden. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3442) Replace popup lookups by layer lookups
[ https://issues.apache.org/jira/browse/OFBIZ-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12830737#action_12830737 ] Bilgin Ibryam commented on OFBIZ-3442: -- Hi Jacques and Sascha, this a great addition, thanks a lot for working on it. I did some quick tests. Here is what I found. Before few weeks I added autocompleter support to lookup fields. (If you didn't see it, just type one/two letters in a lookup field and you can select an entry w/o using the lookup button). It was missing in LookupLayerPopupDecorator and I added it in r907456. Now autocompleter and layered lookups work together fine :) I didn't follow all the development process of the layered lookups, but why not change the default values in the schema of presentation and position elements to layer and center respectively. Then we don't need to add these attributes in all the forms. Also I found a bug caused when user session is destroyed: Log into an application (accounting for example) and select a form - layered lookups work correct. In another tab log into another application and then log out. Then on the first tab (accounting) try to use a lookup. In the lookup screen you will get the login screen (that's OK) but once you enter your username and password you get a blank screen. Bilgin Replace popup lookups by layer lookups -- Key: OFBIZ-3442 URL: https://issues.apache.org/jira/browse/OFBIZ-3442 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Reporter: Jacques Le Roux Assignee: Jacques Le Roux Priority: Minor Attachments: OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch, OFBIZ-3442 replace popup lookups by layered lookups.patch Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups. For that please find a patch attached. In this patch I followed a simple S/R tactic: * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens * I replaced all occurences of lookup by lookup presentation=layer position=center It's as simple as this. For the moment I decided to use as default position=center because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position=center and use the default (position=normal) which does not move the layer from the point it's called and will be more aesthetic. I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far. The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in. Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3394) Axis2 SOAP implementation does not have types defined for col-* elements
[
https://issues.apache.org/jira/browse/OFBIZ-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam reassigned OFBIZ-3394:
Assignee: Bilgin Ibryam
Axis2 SOAP implementation does not have types defined for col-* elements
Key: OFBIZ-3394
URL: https://issues.apache.org/jira/browse/OFBIZ-3394
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: chris snow
Assignee: Bilgin Ibryam
Attachments: patch.txt
The wsdl generated from the Axis2 soap implementation does not define types
for col-* elements:
{code}
xsd:element name=col-ArrayList/
xsd:element name=col-LinkedList/
xsd:element name=col-Stack/
xsd:element name=col-Vector/
xsd:element name=col-TreeSet/
xsd:element name=col-HashSet/
xsd:element name=col-Collection/
{code}
I would expect to see something like:
{code}
xsd:element name=col-ArrayList type=tns:XXX/
xsd:complexType name=XXX
!-- To be defined --
/xsd:complexType
{code}
Without type defintions, tools (such as wsdl2java) are unable to generate the
appropriate classes for the col-* elements.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3394) Axis2 SOAP implementation does not have types defined for col-* elements
[
https://issues.apache.org/jira/browse/OFBIZ-3394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam closed OFBIZ-3394.
Resolution: Fixed
Fix Version/s: SVN trunk
Thanks Chris and Chatree. The patch is in trunk r897820
After reviewing the patch I decided to create a new complex type with all the
elements (the same as map-value) and then reference this element from map-value
and col-Collection instead of adding all the elements. This would help to get
rid of element repetition, but this change cause generating even more classes
for java clients. Finally I committed the patch as it is.
Chris feel free to create another issue for the flex error you receive. I'm
closing this one.
Bilgin
Axis2 SOAP implementation does not have types defined for col-* elements
Key: OFBIZ-3394
URL: https://issues.apache.org/jira/browse/OFBIZ-3394
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: chris snow
Assignee: Bilgin Ibryam
Fix For: SVN trunk
Attachments: patch.txt
The wsdl generated from the Axis2 soap implementation does not define types
for col-* elements:
{code}
xsd:element name=col-ArrayList/
xsd:element name=col-LinkedList/
xsd:element name=col-Stack/
xsd:element name=col-Vector/
xsd:element name=col-TreeSet/
xsd:element name=col-HashSet/
xsd:element name=col-Collection/
{code}
I would expect to see something like:
{code}
xsd:element name=col-ArrayList type=tns:XXX/
xsd:complexType name=XXX
!-- To be defined --
/xsd:complexType
{code}
Without type defintions, tools (such as wsdl2java) are unable to generate the
appropriate classes for the col-* elements.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3211) Ajaxifying lookup fields
[ https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12794805#action_12794805 ] Bilgin Ibryam commented on OFBIZ-3211: -- Thanks guys for your reviews and comments. I did some more changes according to your comments and committed it to trunk in #894149 Jeroen, you can show/hide the returned values(keys) from widget.properties Also each entry is in separate line and there is no text wrapping any more. Jacques, it works for me using FF3.5.5 on vista. No idea what prevented it in your case. Scott, I used setMaxRows and added possibility to hide/show the key in the list. As for the error message and using json, this will require changes in scriptaculous library. I will keep the issue open for later improvements. Here are few more things to improve: - add possibility to pass target-parameter from the lookup. - add possibility to add extra conditions to search query (for example to filter disabled parties) Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3205) We should not allow users to enter thruDate older than related fromDate
[ https://issues.apache.org/jira/browse/OFBIZ-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792464#action_12792464 ] Bilgin Ibryam commented on OFBIZ-3205: -- Hi, I also needed to validate fromDate/thruDate in few places and for that purpose I created a service and used ECAs. It works fine but the error messages generated from ecas are not very user friendly. I can commit that to the project, but I'd like to hear also other opinions, there might be better solutions than invoking a service with ECA to validate 2 fields. Any ideas? Bilgin We should not allow users to enter thruDate older than related fromDate --- Key: OFBIZ-3205 URL: https://issues.apache.org/jira/browse/OFBIZ-3205 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: Jacques Le Roux Priority: Minor Fix For: SVN trunk I can't see any reason why we authorize users to enter a thru date previous to its related from date. Should we not prevent it in any cases ? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3300) soap wsdl and action should be consistent
[ https://issues.apache.org/jira/browse/OFBIZ-3300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3300: - Priority: Minor (was: Major) soap wsdl and action should be consistent - Key: OFBIZ-3300 URL: https://issues.apache.org/jira/browse/OFBIZ-3300 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk Reporter: Si Chen Priority: Minor Fix For: Release Branch 4.0, Release Branch 9.04, SVN trunk Currently, the WSDL for a soap service is obtained by http://localhost:8080/webtools/control/SOAPService/serviceName?wsdl, but the service is called at URL http://localhost:8080/webtools/control/SOAPService/, and the service name is inferred from the soap message, rather than from the URL. It is a trivial fix for the soap event handler to get the service name from the URL as well, so that you can call the service at http://localhost:8080/webtools/control/SOAPService/serviceName Please let me know if you agree, and I will make you a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3271) Storing screenlet collapsed/expanded status as user preferences
[ https://issues.apache.org/jira/browse/OFBIZ-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12785619#action_12785619 ] Bilgin Ibryam commented on OFBIZ-3271: -- Bruno, I checked your patch and this would be a good addition to the project. 1. I don't see any security issue in storing userPreference recores with javascript. 2. Do we need to introduce a new patter for the Ids, I mean the capital letters? I think we should continue to use camelCase but using shorter names that would fit in userPrefTypeId field, or even better change the field type from id-ne to id-long-ne in UserPreference entity, where all the ids would fit w/o any change. 3. Your changes in ModelScreenWidget.java , modify the current implementation of the screenlets collapsible status. 4. I think it would be better if this feature is automatically handled by the screenlet widget, w/o requiring any change on the screen definitions. This way,the feature will be available for all the screenlets. For that purpose I added the user preference check to ModelScreenWidget and removed the initiallyCollapsedExdr as it is not needed. Please take a look at it. Bilgin Storing screenlet collapsed/expanded status as user preferences --- Key: OFBIZ-3271 URL: https://issues.apache.org/jira/browse/OFBIZ-3271 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Priority: Minor Attachments: OFBIZ-3271 persistCollapsed.patch Hi, actually the screenlet collapsed/expanded status is reset to the initial value every time the page is refreshed. in the attached patch there is a solution to have the screenlet collapsed/expanded status stored as user preferences so that they stay in the collapsed or expanded status whenever the user refresh the page or logout/loging again. I would like a review from you, before committing. Thank you, Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3271) Storing screenlet collapsed/expanded status as user preferences
[ https://issues.apache.org/jira/browse/OFBIZ-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3271: - Attachment: ModelScreenWidget.patch Storing screenlet collapsed/expanded status as user preferences --- Key: OFBIZ-3271 URL: https://issues.apache.org/jira/browse/OFBIZ-3271 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Priority: Minor Attachments: ModelScreenWidget.patch, OFBIZ-3271 persistCollapsed.patch Hi, actually the screenlet collapsed/expanded status is reset to the initial value every time the page is refreshed. in the attached patch there is a solution to have the screenlet collapsed/expanded status stored as user preferences so that they stay in the collapsed or expanded status whenever the user refresh the page or logout/loging again. I would like a review from you, before committing. Thank you, Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3254) Setting viewSize and viewIndex in screen context for List Forms do not work
[
https://issues.apache.org/jira/browse/OFBIZ-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam closed OFBIZ-3254.
Resolution: Fixed
Thnaks Mridul.
Your patch is in trunk r885724 and ofbiz9.4 r885732
Setting viewSize and viewIndex in screen context for List Forms do not work
---
Key: OFBIZ-3254
URL: https://issues.apache.org/jira/browse/OFBIZ-3254
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Mridul Pathak
Assignee: Bilgin Ibryam
Fix For: Release Branch 9.04, SVN trunk
Attachments: OFBIZ-3254.patch
With the support of multi pagination in Form Widgets, following piece of code
which has several occurrences across the framework is not functional anymore:
{code:xml}
set field=viewIndex from-field=parameters.VIEW_INDEX default-value=0
set field=viewSize from-field=parameters.VIEW_SIZE
default-value=some-value
{code}
The above can be tested at
https://demo.ofbiz.org/accounting/control/globalGLSettings, where in screen
default viewSize has been set to 50, but the list is rendered with viewSize
20.
The reason is that when fetching these values from screen context, the
paginator number is appended to paginateSizeField and
DEFAULT_PAGE_SIZE_FIELD. To set the default value in screen context, you
will need to set viewSize_${paginatorNumber} (for a screen with single list
form it would be viewSize_1).
With multiple list forms in a screen, this becomes more complex to set the
global view size multiple times, which is ok in some cases. But the support
to set viewSize and viewIndex globally with no paginator number must exist.
If the support is added back, all the occurrences of above code will be
automatically functional again.
The code should work in following fashion; check for
${paginateSizeField}_paginatorNumber or
${DEFAULT_PAGE_SIZE_FIELD}_paginatorNumber in context, if it is null check
for these fields with no paginatorNumber appended.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3254) Setting viewSize and viewIndex in screen context for List Forms do not work
[
https://issues.apache.org/jira/browse/OFBIZ-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam reassigned OFBIZ-3254:
Assignee: Bilgin Ibryam
Setting viewSize and viewIndex in screen context for List Forms do not work
---
Key: OFBIZ-3254
URL: https://issues.apache.org/jira/browse/OFBIZ-3254
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Mridul Pathak
Assignee: Bilgin Ibryam
Fix For: Release Branch 9.04, SVN trunk
Attachments: OFBIZ-3254.patch
With the support of multi pagination in Form Widgets, following piece of code
which has several occurrences across the framework is not functional anymore:
{code:xml}
set field=viewIndex from-field=parameters.VIEW_INDEX default-value=0
set field=viewSize from-field=parameters.VIEW_SIZE
default-value=some-value
{code}
The above can be tested at
https://demo.ofbiz.org/accounting/control/globalGLSettings, where in screen
default viewSize has been set to 50, but the list is rendered with viewSize
20.
The reason is that when fetching these values from screen context, the
paginator number is appended to paginateSizeField and
DEFAULT_PAGE_SIZE_FIELD. To set the default value in screen context, you
will need to set viewSize_${paginatorNumber} (for a screen with single list
form it would be viewSize_1).
With multiple list forms in a screen, this becomes more complex to set the
global view size multiple times, which is ok in some cases. But the support
to set viewSize and viewIndex globally with no paginator number must exist.
If the support is added back, all the occurrences of above code will be
automatically functional again.
The code should work in following fashion; check for
${paginateSizeField}_paginatorNumber or
${DEFAULT_PAGE_SIZE_FIELD}_paginatorNumber in context, if it is null check
for these fields with no paginatorNumber appended.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3211) Ajaxifying lookup fields
[ https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3211: - Attachment: ajaxLookup.patch - Added possibility to specify more than one fields to search for a match. - Added some defaults, so ajaxifying a lookup screen is as easy as specifying two fields:entityName and fieldNames - Show only 10 records in the autocompleter, which is configurable from widget.properties. (I was wondering would it be better to use EntityListIterator for the search ?) - Move hard coded image location from markup to css. - Added autocompleter to LookupPerson lookup. Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3211) Ajaxifying lookup fields
Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3211) Ajaxifying lookup fields
[ https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3211: - Attachment: ajax-loader.gif ajaxLookup.patch Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3211) Ajaxifying lookup fields
[ https://issues.apache.org/jira/browse/OFBIZ-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12778896#action_12778896 ] Bilgin Ibryam commented on OFBIZ-3211: -- btw you'd better use business theme while testing. I still didn't add the necessary styles to other themes. Ajaxifying lookup fields Key: OFBIZ-3211 URL: https://issues.apache.org/jira/browse/OFBIZ-3211 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ajax-loader.gif, ajaxLookup.patch To see how it works, apply the patch (optionally add ajax-loader.gif to framework\images\webapp\images\) and go to Accounting - Find Invoices (or to any other screen with form widget that uses LookupPartyName lookup ). Then type some letters to From Party ID or To Party ID fields. Bilgin -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2550) Add FTL macro for the tree widget
[ https://issues.apache.org/jira/browse/OFBIZ-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-2550. Resolution: Fixed Committed treeWidget.patch to trunk in r880683 Add FTL macro for the tree widget -- Key: OFBIZ-2550 URL: https://issues.apache.org/jira/browse/OFBIZ-2550 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: WeizhanGuo Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: treeFtlMacro_ofbiz-trunk.patch, treeWidget.patch Add FTL macro for the tree widget -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-3207) Create (mostly empty) macro implementation for the other tree renderers: fo, xml, text, csv
Create (mostly empty) macro implementation for the other tree renderers: fo, xml, text, csv --- Key: OFBIZ-3207 URL: https://issues.apache.org/jira/browse/OFBIZ-3207 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: Bilgin Ibryam Priority: Minor Fix For: SVN trunk -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2550) Add FTL macro for the tree widget
[ https://issues.apache.org/jira/browse/OFBIZ-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12778276#action_12778276 ] Bilgin Ibryam commented on OFBIZ-2550: -- Jacopo, thanks for the reminder. Done OFBIZ-3207 Add FTL macro for the tree widget -- Key: OFBIZ-2550 URL: https://issues.apache.org/jira/browse/OFBIZ-2550 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: WeizhanGuo Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: treeFtlMacro_ofbiz-trunk.patch, treeWidget.patch Add FTL macro for the tree widget -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2550) Add FTL macro for the tree widget
[ https://issues.apache.org/jira/browse/OFBIZ-2550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12778177#action_12778177 ] Bilgin Ibryam commented on OFBIZ-2550: -- I created a macro tree renderer and then found out that there is a ticket with the implementation already. Anyway, the patch I created is very similar to treeFtlMacro_ofbiz-trunk.patch but with fixed image renderer method and no tabs. Jacopo, is there a reason for not committing the macro tree renderer? If not I'd like to commit the one I attached - treeWidget.patch Bilgin Add FTL macro for the tree widget -- Key: OFBIZ-2550 URL: https://issues.apache.org/jira/browse/OFBIZ-2550 Project: OFBiz Issue Type: New Feature Components: framework Affects Versions: SVN trunk Reporter: WeizhanGuo Assignee: Jacopo Cappellato Priority: Minor Fix For: SVN trunk Attachments: treeFtlMacro_ofbiz-trunk.patch, treeWidget.patch Add FTL macro for the tree widget -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3196) Manual refund functionality is broken.
[ https://issues.apache.org/jira/browse/OFBIZ-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-3196: Assignee: Bilgin Ibryam Manual refund functionality is broken. --- Key: OFBIZ-3196 URL: https://issues.apache.org/jira/browse/OFBIZ-3196 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Divesh Dutta Assignee: Bilgin Ibryam Fix For: SVN trunk Manual refund functionality is broken. I have also reported this on developer mailing list. But creating issue so that this can be tracked well. Steps to reproduce the bug: 1) Create a sales order from Order manager application with two or more items. 2) Then approve and Quick ship the entire Order which will complete the order. 3) Then click on Create Return button on Actions Block. 4) You will land on Create new Return Page: Also attaching the screen shot. Here is the link of image: http://img156.yfrog.com/i/screenshot1jw.png/ 5) Click on select all check box and then click on Return Selected items button. 6) You will find that page is broken. Also attaching the screen shot for the same. Here is the link of image: http://img156.yfrog.com/i/screenshot2kn.png/ -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3147) Update renderNextPrev macro in fo form and xml form macro libraries
[ https://issues.apache.org/jira/browse/OFBIZ-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-3147: Assignee: Bilgin Ibryam Update renderNextPrev macro in fo form and xml form macro libraries --- Key: OFBIZ-3147 URL: https://issues.apache.org/jira/browse/OFBIZ-3147 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Mridul Pathak Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3147.patch, OFBIZ-3147.patch Three new arguments, namely ajaxSelectSizeUrl, selectSizeUrl and paginateViewSizeLabel have been introduced to renderNextPrev macro in htmlFormMacroLibrary.ftl in commit revision 831676 for OFBIZ-3083. Need to update foFormMacroLibrary.ftl and xmlFormMacroLibrary.ftl accordingly so as to avoid No Such Arguments TemplateException. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3083) Adding a page size selector in the pagination bar
[ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-3083: Assignee: Bilgin Ibryam Adding a page size selector in the pagination bar - Key: OFBIZ-3083 URL: https://issues.apache.org/jira/browse/OFBIZ-3083 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Assignee: Bilgin Ibryam Priority: Minor Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch I find usefull to let the user change, on the ui, the actual number of elements contained in a page. This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages. Having this feature, the user can select 30 as page size, and have all elements in one page. In the attached patch there is a first try I am working on. This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements. Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled. What do you think about? Thank you, Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3083) Adding a page size selector in the pagination bar
[ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3083. Resolution: Fixed Fix Version/s: SVN trunk Thanks Bruno. Your patch is committed to trunk in r831676 Adding a page size selector in the pagination bar - Key: OFBIZ-3083 URL: https://issues.apache.org/jira/browse/OFBIZ-3083 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch I find usefull to let the user change, on the ui, the actual number of elements contained in a page. This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages. Having this feature, the user can select 30 as page size, and have all elements in one page. In the attached patch there is a first try I am working on. This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements. Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled. What do you think about? Thank you, Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12771879#action_12771879 ] Bilgin Ibryam commented on OFBIZ-3061: -- Jacques, you are right, colored links would look better . The above code doesn't work in parties search result because it is ftl and use different css classes for buttons :( Now I think we should go simpler, by coloring all the links. Could you try the attached path and tell your opinion? You don't to distinguish between normal text and URL links in screens - Key: OFBIZ-3061 URL: https://issues.apache.org/jira/browse/OFBIZ-3061 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: link.patch, Payments links in a sale invoice.jpg For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reopened OFBIZ-3061: -- You don't to distinguish between normal text and URL links in screens - Key: OFBIZ-3061 URL: https://issues.apache.org/jira/browse/OFBIZ-3061 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: link.patch, Payments links in a sale invoice.jpg For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3061: - Attachment: link.patch You don't to distinguish between normal text and URL links in screens - Key: OFBIZ-3061 URL: https://issues.apache.org/jira/browse/OFBIZ-3061 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: link.patch, Payments links in a sale invoice.jpg For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3061: - Attachment: (was: link.patch) You don't to distinguish between normal text and URL links in screens - Key: OFBIZ-3061 URL: https://issues.apache.org/jira/browse/OFBIZ-3061 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: Payments links in a sale invoice.jpg For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3061: - Attachment: link.patch You don't to distinguish between normal text and URL links in screens - Key: OFBIZ-3061 URL: https://issues.apache.org/jira/browse/OFBIZ-3061 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: link.patch, Payments links in a sale invoice.jpg For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[ https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3061. Resolution: Fixed Fix Version/s: SVN trunk Assignee: Bilgin Ibryam Thanks for the reminder Jacques. Committed to trunk in r831159. You don't to distinguish between normal text and URL links in screens - Key: OFBIZ-3061 URL: https://issues.apache.org/jira/browse/OFBIZ-3061 Project: OFBiz Issue Type: Sub-task Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: Payments links in a sale invoice.jpg For instance look at the paiment links in a sales invoice, it's the same as normal text. Before the color let you find them easily and even know that there are there if you don't know much OFBiz -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3010) Bug in createInvoiceForOrderAllItems service definition
[ https://issues.apache.org/jira/browse/OFBIZ-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-3010. Resolution: Fixed Fix Version/s: Release Branch 9.04 Release Branch 4.0 Thanks Cimballi. The bug is fixed in trunk and 9.4 with r830814 and r830818 Bug in createInvoiceForOrderAllItems service definition --- Key: OFBIZ-3010 URL: https://issues.apache.org/jira/browse/OFBIZ-3010 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Release Branch 9.04 Environment: Tested on version : ofbiz-rel9.04-2009-09-25-v818777 Reporter: Cimballi Assignee: Bilgin Ibryam Fix For: Release Branch 4.0, Release Branch 9.04 There is a bug in the definition of the createInvoiceForOrderAllItems service . Here is the current definition : service name=createInvoiceForOrderAllItems engine=java location=org.ofbiz.accounting.invoice.InvoiceServices invoke=createInvoiceForOrderAllItems description Create an invoice from existing order using all order items orderId = The orderId to associate the invoice with /description attribute name=orderId type=String mode=IN optional=false/ attribute name=invoiceId type=String mode=OUT optional=true/ /service But in the service method, there is this : Map resp = ServiceUtil.returnSuccess(); resp.put(invoiceId, invoiceId); resp.put(invoiceTypeId, invoiceType); return resp; And so it generates the following error : (OUT) Required test error: org.ofbiz.service.ServiceValidationException: Unknown parameter found: [createInvoiceForOrderAllItems.invoiceTypeId] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3010) Bug in createInvoiceForOrderAllItems service definition
[ https://issues.apache.org/jira/browse/OFBIZ-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-3010: Assignee: Bilgin Ibryam Bug in createInvoiceForOrderAllItems service definition --- Key: OFBIZ-3010 URL: https://issues.apache.org/jira/browse/OFBIZ-3010 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: Release Branch 9.04 Environment: Tested on version : ofbiz-rel9.04-2009-09-25-v818777 Reporter: Cimballi Assignee: Bilgin Ibryam There is a bug in the definition of the createInvoiceForOrderAllItems service . Here is the current definition : service name=createInvoiceForOrderAllItems engine=java location=org.ofbiz.accounting.invoice.InvoiceServices invoke=createInvoiceForOrderAllItems description Create an invoice from existing order using all order items orderId = The orderId to associate the invoice with /description attribute name=orderId type=String mode=IN optional=false/ attribute name=invoiceId type=String mode=OUT optional=true/ /service But in the service method, there is this : Map resp = ServiceUtil.returnSuccess(); resp.put(invoiceId, invoiceId); resp.put(invoiceTypeId, invoiceType); return resp; And so it generates the following error : (OUT) Required test error: org.ofbiz.service.ServiceValidationException: Unknown parameter found: [createInvoiceForOrderAllItems.invoiceTypeId] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3083) Adding a page size selector in the pagination bar
[ https://issues.apache.org/jira/browse/OFBIZ-3083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770441#action_12770441 ] Bilgin Ibryam commented on OFBIZ-3083: -- Bruno, this is a great addition. Thanks! I did a quick UI test with you patch and faced these issues: 1. When logged in to application with javascript disabled, the dropdown for page number selection is not rendered because it relies on javascrip. I think Items per page dropdown should not be rendered too. 2. I did my tests in accounting-find fixed asset screen. After the seach, if your FIRST actions is changing the items per page, the selection seems not working. But after that the next selections are working fine. Then I found that this bug exists even before applying your patch, ie the first click on paginator buttons (such as next, last, changing page number) doesn;t have any effect on the UI. Bilgin Adding a page size selector in the pagination bar - Key: OFBIZ-3083 URL: https://issues.apache.org/jira/browse/OFBIZ-3083 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Bruno Busco Priority: Minor Attachments: OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch, OFBIZ-3083 viewSizeSelector.patch I find usefull to let the user change, on the ui, the actual number of elements contained in a page. This can be usefull, for example, when there are 21 elements selected in a query, the user want to print them, and the page size is 20. In this case the user must print two pages. Having this feature, the user can select 30 as page size, and have all elements in one page. In the attached patch there is a first try I am working on. This seens to work (does not support yet ajax and i18n) but I would like to have the size selector shown even if all elements fit in one page so that the user can select a page size with less elements. Actually the page size selector is rendered with the prevNext bar. A solution that I was thinking on is to render the prevNext even if it would not be necessary (one page list) with all buttons disabled. What do you think about? Thank you, Bruno -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3061) You don't to distinguish between normal text and URL links in screens
[
https://issues.apache.org/jira/browse/OFBIZ-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770686#action_12770686
]
Bilgin Ibryam commented on OFBIZ-3061:
--
You can't see the links even in second glance ;) I wonder how people use this
theme w/o being able to make a distinction between a text and a link?
I propose to underline all links belonging to .basic-table except for the
buttons in themes\bizznesstime\webapp\bizznesstime\css\style.css by adding this:
.basic-table td a {
text-decoration: underline;
}
.basic-table td a.buttontext {
text-decoration: none;
}
If there are no other proposals I will commit this soon.
Bilgin
You don't to distinguish between normal text and URL links in screens
-
Key: OFBIZ-3061
URL: https://issues.apache.org/jira/browse/OFBIZ-3061
Project: OFBiz
Issue Type: Sub-task
Reporter: Jacques Le Roux
Attachments: Payments links in a sale invoice.jpg
For instance look at the paiment links in a sales invoice, it's the same as
normal text. Before the color let you find them easily and even know that
there are there if you don't know much OFBiz
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default
[ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769944#action_12769944 ] Bilgin Ibryam commented on OFBIZ-2442: -- Jacques, In my opinion setting a longer timeout is not a solution because in this case the message will hide some of the buttons for a longer period and it is impossible to use these buttons before the message disappears. I would propose to hide the message only if the user clicks on it. (I am not sure but this may require also an indicator on the message box showing how to hide the message). WDYT? Here is the patch to hide the message when clicked. Bilgin BizznessTime Theme : error and event messages should not dissapear by default - Key: OFBIZ-2442 URL: https://issues.apache.org/jira/browse/OFBIZ-2442 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Release Branch 9.04, SVN trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Release Branch 9.04, SVN trunk Attachments: message.patch Error and event messages should not dissapear by default (if there are a bit long it's impossible to read) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default
[ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-2442: - Attachment: message.patch BizznessTime Theme : error and event messages should not dissapear by default - Key: OFBIZ-2442 URL: https://issues.apache.org/jira/browse/OFBIZ-2442 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Release Branch 9.04, SVN trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Release Branch 9.04, SVN trunk Attachments: message.patch Error and event messages should not dissapear by default (if there are a bit long it's impossible to read) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2442) BizznessTime Theme : error and event messages should not dissapear by default
[ https://issues.apache.org/jira/browse/OFBIZ-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1277#action_1277 ] Bilgin Ibryam commented on OFBIZ-2442: -- Currently I see two timers for hiding the message: - One that is automatically started and removes the message in 7 seconds. - The other one is activated on mousemove, click or keypress events and removes the message in 2-3 seconds. My patch comments out both timer and removes the message with 0.5s delay if the user clicks on the message box. BizznessTime Theme : error and event messages should not dissapear by default - Key: OFBIZ-2442 URL: https://issues.apache.org/jira/browse/OFBIZ-2442 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Release Branch 9.04, SVN trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Release Branch 9.04, SVN trunk Attachments: message.patch Error and event messages should not dissapear by default (if there are a bit long it's impossible to read) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2346) Change Copyright Year
[ https://issues.apache.org/jira/browse/OFBIZ-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12702001#action_12702001 ] Bilgin Ibryam commented on OFBIZ-2346: -- Hi Ashish, what about using javascript in footer.ftl to get the current year? This way, next year we will have less work to do :-) Bilgin Change Copyright Year -- Key: OFBIZ-2346 URL: https://issues.apache.org/jira/browse/OFBIZ-2346 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Ashish Vijaywargiya Priority: Minor Fix For: SVN trunk Attachments: Copyright_Year_Change.patch I don't know much about when this copyright year and other related info changes come into existence. But if its right time to change the copyright year then here is the patch. And if it comes into existence after the completion of year then we can safely close this issue. Thanks ! -- Ashish -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2284) Approve Order error
[ https://issues.apache.org/jira/browse/OFBIZ-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12697781#action_12697781 ] Bilgin Ibryam commented on OFBIZ-2284: -- I remember an old issue related to the same error: OFBIZ-1189 . May be it can help Approve Order error --- Key: OFBIZ-2284 URL: https://issues.apache.org/jira/browse/OFBIZ-2284 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: r763532, Windows XP Reporter: Aswath Satrasala I added a product of type 'Service' I created a sales order After this, I get screen outlining all the order details with ' 'Approve order' link I click on the Approve order. I got the following error. The Following Errors Occurred: ERROR : Could not change order status; status is not a valid change.: [ORDER_COMPLETED] - [ORDER_APPROVED] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2008) Tools to extract messages from *Labels.xml files to gettext PO files and merge translation results back
[ https://issues.apache.org/jira/browse/OFBIZ-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-2008: Assignee: Bilgin Ibryam Tools to extract messages from *Labels.xml files to gettext PO files and merge translation results back --- Key: OFBIZ-2008 URL: https://issues.apache.org/jira/browse/OFBIZ-2008 Project: OFBiz Issue Type: New Feature Affects Versions: SVN trunk Reporter: Nemanja Simonovic Assignee: Bilgin Ibryam Priority: Minor Attachments: gettext_.patch, Ofbiz2po.java, Po2ofbiz.java, PropertyTranslators.patch, src.rar Tools to extract messages from *Labels.xml files to gettext PO files and merge translation results back -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2206) Cart : same product but different configuration with the same option
[ https://issues.apache.org/jira/browse/OFBIZ-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-2206. Resolution: Fixed Fix Version/s: (was: SVN trunk) Release Branch 9.3 Assignee: Bilgin Ibryam Thanks Eric. Your patch (with some changes) is in trunk rev 747719. Cart : same product but different configuration with the same option Key: OFBIZ-2206 URL: https://issues.apache.org/jira/browse/OFBIZ-2206 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Environment: trunk 747346 Reporter: Eric DE MAULDE Assignee: Bilgin Ibryam Priority: Trivial Fix For: Release Branch 9.3 Attachments: Cart_differenciate-option.patch if a customer add twice to cart the same product but with different configuration based on the same option and this option has a virtual component. So if two items don't have the same variant component, cart manages these items like a only same item *** Example with PIZZA product if we choice one with PEPPER RED and another with PEPPER GREEN -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2146) Quote to order - manual adjustments amount not included in cart grand total
[ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-2146: Assignee: Bilgin Ibryam Quote to order - manual adjustments amount not included in cart grand total --- Key: OFBIZ-2146 URL: https://issues.apache.org/jira/browse/OFBIZ-2146 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Environment: Ubuntu 8.10, Firefox 3.0.5Quote to order - manual adjustments amount not included in cart grand total Reporter: Raj Saini Assignee: Bilgin Ibryam While creating a order from a quote with a manual adjustment of shipping charges, the adjustment amount is not included in the cart grand total. Although manual adjustments are copied to order adjustment and added to cart adjustment (ShoppingCartService.java, lines 676-781), they are filtered out while calculating the maxAmount for OrderPaymentPreference when calling the cart.getOrderOtherAdjustmentTotal() method which in turns calls the OrderReadHelper.calcOrderAdjustments(List orderHeaderAdjustments, BigDecimal subTotal, boolean includeOther, boolean includeTax, boolean includeShipping). This method filters out the SHIPPING_CHARGES order adjustment as includeShipping parameter is always true. One way to solve the problem is to use the value of includeInShipping field from OrderAdjsutment entity in OrderHelper#filterOrderAdjustments(List adjustments, boolean includeOther, boolean includeTax, boolean includeShipping, boolean forTax, boolean forShipping) method and setting this to true in QuoteAdjustment entity. (quote adjustments are copied to order adjustment by loadCartFromQuote service). However, doing so wrongly shows the shipping charges twice in the Order view and also add the shipping charges to the total tax whereas the grand total remains correct. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2138) Remove markup from labels
Remove markup from labels - Key: OFBIZ-2138 URL: https://issues.apache.org/jira/browse/OFBIZ-2138 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Using the gettext patch OFBIZ-2008, I found two labels that contains html markup. The first one is loginevents.following_error_occurred_during_login and contains b/b for French and German translation. The other label is ProductRedExplanation, and it has more html markups like b style=color: red;. If nobody is against, I will simply remove markups from these 2 labels. A quote from Adrian: Regarding the unescaped markup example: there is an even bigger problem with that translation - it uses embedded HTML in a UI label. That is a bad design and should be corrected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1953) Cleanup ship groups doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12667020#action_12667020 ] Bilgin Ibryam commented on OFBIZ-1953: -- Jacques, thanks for taking care of the issue. Just a note: I think R4 was meant for running with java 1.4 and generics may broke it. Cleanup ship groups doesn't work Key: OFBIZ-1953 URL: https://issues.apache.org/jira/browse/OFBIZ-1953 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Dimitri Unruh Assignee: Jacques Le Roux Fix For: SVN trunk, Release Branch 4.0 Attachments: ShoppingCart.patch Hi everyone, I guess the method cleanUpShipGroups in the ShoppingCart.java is buggy. If you have many CartShipInfo objects in your cart and some of them are empty (shipItemInfo.size() == 0) the method don't remove all of them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2103) Updating Webtool JobList to use PerformFind and FindScreenDecorator
[ https://issues.apache.org/jira/browse/OFBIZ-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12660708#action_12660708 ] Bilgin Ibryam commented on OFBIZ-2103: -- I think there should always be one page which is accessible for not logged in users and telling them the admin password. This is especially useful for new comers trying OFBiz for the first time. Then for production installation, it should not be a big deal to replace/hide this page. I agree that webtools main page is not the rightest place for displaying this kind of info, but before we have another page for this purpose(may be in my page or my portal or somewhere else) it is acceptable (for me). Bilgin Updating Webtool JobList to use PerformFind and FindScreenDecorator --- Key: OFBIZ-2103 URL: https://issues.apache.org/jira/browse/OFBIZ-2103 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: WebToolsTabBar.patch, WebToolsTabBar.patch, WebToolsTabBar.patch, WebToolsTabBar.patch Hi, I did some update on webtool JobList. Basically the JobList follows now a more recent pattern with usage of PerformFind, Sortable columns and Collapsible FindScreenDecorator. I tryed it in a framework-only installation but it should work in a full OFBiz also. If this is OK I think I will do a similar job on ServiceList. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2069) Extending TabBar menus from CommonTabBar
[ https://issues.apache.org/jira/browse/OFBIZ-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-2069. Resolution: Fixed Fix Version/s: SVN trunk Thanks Bruno. Your patch is in trunk rev 726655. Extending TabBar menus from CommonTabBar Key: OFBIZ-2069 URL: https://issues.apache.org/jira/browse/OFBIZ-2069 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: TabBarExtended.patch In the attached patch ALL TabBar menus are defined as extended from the CommonTabBar defined in the framework. This should give more consinstency to all applications. P.S. Doing this I noted two menus extending from themselves. They are FixedAssetTabBar and FixedAssetMaintTabBar. I think this is an error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1935) Allow multi-pagination in a page
[ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12654761#action_12654761 ] Bilgin Ibryam commented on OFBIZ-1935: -- Jacques, thanks for testing the patch. In paginate-target-anchor you have to specify a link name, but pagination links don't have names. You can use also formId, like this: paginate-target-anchor=ListCarrierAccounts and the page will be scrolled. Allow multi-pagination in a page --- Key: OFBIZ-1935 URL: https://issues.apache.org/jira/browse/OFBIZ-1935 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Attachments: 1935.diff, 1935.diff If a page has more than one paginations (fe : view profile has one in Financial Account Summary and one in Shipper Account ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1935) Allow multi-pagination in a page
[ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1935: Assignee: Bilgin Ibryam Allow multi-pagination in a page --- Key: OFBIZ-1935 URL: https://issues.apache.org/jira/browse/OFBIZ-1935 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Bilgin Ibryam If a page has more than one paginations (fe : view profile has one in Financial Account Summary and one in Shipper Account ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1935) Allow multi-pagination in a page
[ https://issues.apache.org/jira/browse/OFBIZ-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-1935: - Attachment: 1935.diff The attached patch will add paginator numbers to VIEW_SIZE and VIEW_INDEX parameters, so every form has different parameters for pagination (form one will use VIEW_SIZE_1, VIEW_INDEX_1, second form on the same page will use VIEW_SIZE_2, VIEW_INDEX_2 params). The last paginator number used on a page is stored in globalContext, so every rendered pagination can get next number to use for the parameters. Also fixed a bug, where iterator-section was not adding existing request parameters to the paginator links. Any tests and reviews would be appreciated. Bilgin Allow multi-pagination in a page --- Key: OFBIZ-1935 URL: https://issues.apache.org/jira/browse/OFBIZ-1935 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Jacques Le Roux Assignee: Bilgin Ibryam Attachments: 1935.diff If a page has more than one paginations (fe : view profile has one in Financial Account Summary and one in Shipper Account ) the pagination numbers become wrong, as both paginations use VIEW_SIZE and VIEW_INDEX parameters from the request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1953) Cleanup ship groups doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1953: Assignee: Bilgin Ibryam Cleanup ship groups doesn't work Key: OFBIZ-1953 URL: https://issues.apache.org/jira/browse/OFBIZ-1953 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Dimitri Unruh Assignee: Bilgin Ibryam Attachments: ShoppingCart.patch Hi everyone, I guess the method cleanUpShipGroups in the ShoppingCart.java is buggy. If you have many CartShipInfo objects in your cart and some of them are empty (shipItemInfo.size() == 0) the method don't remove all of them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2030) Error in Lookup Variant Product
[
https://issues.apache.org/jira/browse/OFBIZ-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam closed OFBIZ-2030.
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Bilgin Ibryam
Thanks for reporting Manuel.
It is fixed in trunk r709147.
Error in Lookup Variant Product
---
Key: OFBIZ-2030
URL: https://issues.apache.org/jira/browse/OFBIZ-2030
Project: OFBiz
Issue Type: Bug
Components: product
Environment: Test on SVN trunk 706906
Reporter: Manuel Málaga
Assignee: Bilgin Ibryam
Fix For: SVN trunk
Attachments: screenshot-1.jpg, screenshot-2.jpg
When I try to lookup for a variant product after I click on Search, I get :
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen
[component://product/widget/catalog/LookupScreens.xml#LookupVariantProduct]:
groovy.lang.MissingMethodException: No signature of method:
org.ofbiz.entity.GenericDelegator.findOne() is applicable for argument types:
(java.lang.String, java.util.LinkedHashMap) values: {ProductFeature,
[productFeatureId:10002]} (No signature of method:
org.ofbiz.entity.GenericDelegator.findOne() is applicable for argument types:
(java.lang.String, java.util.LinkedHashMap) values: {ProductFeature,
[productFeatureId:10002]})
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2022) Missing in the LookupPreferredContactMech of contactMechIdTo field in Create new Communication Event form
[ https://issues.apache.org/jira/browse/OFBIZ-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-2022: Assignee: Bilgin Ibryam Missing in the LookupPreferredContactMech of contactMechIdTo field in Create new Communication Event form - Key: OFBIZ-2022 URL: https://issues.apache.org/jira/browse/OFBIZ-2022 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: vu hong thuan Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: CommForms.ofbiz.patch In file \applications\party\webapp\partymgr\communication\CommForms.xml Missing in the LookupPreferredContactMech property of contactMechIdTo field in Create new Communication Event form. Missing between partyIdTo and partyIdFrom. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2022) Missing in the LookupPreferredContactMech of contactMechIdTo field in Create new Communication Event form
[ https://issues.apache.org/jira/browse/OFBIZ-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-2022. Thanks vu hong thuan, your patch is in trunk rev 707955 Missing in the LookupPreferredContactMech of contactMechIdTo field in Create new Communication Event form - Key: OFBIZ-2022 URL: https://issues.apache.org/jira/browse/OFBIZ-2022 Project: OFBiz Issue Type: Bug Components: party Affects Versions: SVN trunk Reporter: vu hong thuan Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: CommForms.ofbiz.patch In file \applications\party\webapp\partymgr\communication\CommForms.xml Missing in the LookupPreferredContactMech property of contactMechIdTo field in Create new Communication Event form. Missing between partyIdTo and partyIdFrom. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1209) Canceling rental product reservations (room booking)
[ https://issues.apache.org/jira/browse/OFBIZ-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1209. Resolution: Later Canceling rental product reservations (room booking) Key: OFBIZ-1209 URL: https://issues.apache.org/jira/browse/OFBIZ-1209 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: cancelRental.patch Hi all, This is an initial service for canceling rental product reservations, visible through fixed asset calendar. It is called on a seca rule while canceling order items and cancel the whole future reservation, or if the order is canceled in the middle of reservation period, only the future dates (from tomorrow till the end of reservation) will be canceled. For now i put it in OrderServices.java file, but i see that there is new directory for rental things in product, so may be that is the right place. This service is working fine for me but may be needs some changes/improvements, so i'll be happy to hear any comments. Regards, Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1979) Groovy Beanshell Service Engines do not provide DispatchContext to scripts
[ https://issues.apache.org/jira/browse/OFBIZ-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1979. Resolution: Fixed Thanks Joe, I had no change to test your path, but you said you use it already... Applied your patch manually in trunk rev 707599 Bilgin Groovy Beanshell Service Engines do not provide DispatchContext to scripts Key: OFBIZ-1979 URL: https://issues.apache.org/jira/browse/OFBIZ-1979 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Joe Eckard Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: patch.txt Groovy Beanshell Service Engines do not provide DispatchContext to scripts, which is used to get a delegator dispatcher. The attached patch addresses this, however I may have overlooked another way to get a delegator dispatcher so this patch may not be necessary. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1954) Generate alt-attribute in the image element
[ https://issues.apache.org/jira/browse/OFBIZ-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12642579#action_12642579 ] Bilgin Ibryam commented on OFBIZ-1954: -- Jacques, Dimitri I found the error in patch and committed in trunk rev 707800. Thanks both of you! Generate alt-attribute in the image element --- Key: OFBIZ-1954 URL: https://issues.apache.org/jira/browse/OFBIZ-1954 Project: OFBiz Issue Type: New Feature Components: framework Reporter: Dimitri Unruh Assignee: Jacques Le Roux Attachments: widget.patch This patch allows you to set an alt attribute for the image element. Also it removes the default border setting to 0. Border attibute for imges is not allowed in xhtml1.0 strict. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2015) Changes done in the code of createUpdateBillingAddress of OrderServices.xml as per coding conventions.
[ https://issues.apache.org/jira/browse/OFBIZ-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-2015. Resolution: Fixed Fix Version/s: SVN trunk Assignee: Bilgin Ibryam Thanks Onima. Your patch is in trunk rev 707299. Bilgin Changes done in the code of createUpdateBillingAddress of OrderServices.xml as per coding conventions. Key: OFBIZ-2015 URL: https://issues.apache.org/jira/browse/OFBIZ-2015 Project: OFBiz Issue Type: Improvement Components: order Reporter: Onima Kasliwal Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: ChangeListName.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1979) Groovy Beanshell Service Engines do not provide DispatchContext to scripts
[ https://issues.apache.org/jira/browse/OFBIZ-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1979: Assignee: Bilgin Ibryam Groovy Beanshell Service Engines do not provide DispatchContext to scripts Key: OFBIZ-1979 URL: https://issues.apache.org/jira/browse/OFBIZ-1979 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Joe Eckard Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: patch.txt Groovy Beanshell Service Engines do not provide DispatchContext to scripts, which is used to get a delegator dispatcher. The attached patch addresses this, however I may have overlooked another way to get a delegator dispatcher so this patch may not be necessary. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1950) Replacement of FTL TabBars with menus widgets in catalog application
[ https://issues.apache.org/jira/browse/OFBIZ-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1950. Resolution: Fixed Fix Version/s: SVN trunk Bruno sorry committing so late. It is in trunk r705940 Replacement of FTL TabBars with menus widgets in catalog application Key: OFBIZ-1950 URL: https://issues.apache.org/jira/browse/OFBIZ-1950 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Bruno Busco Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: catalog_tabbars.patch, catalog_tabbars.patch, catalog_tabbars.patch, maincss_tabbar.patch, product.png Hi, the attached patch replaces all *TabBar.ftl files of the catalog application with menu widgets. Using the menu widget the html is more consistent. for example the selected class is always applied to the li tag and not to the a tag of the menu. Unfortunately I am facing a problem that I have not yet solved: using menu widgets with FF3, and in some case with IE also, the catalog application pages are not displayed correctly. The content of the main area after the TabBar menu is located at the very bottom of the page, after the end of the left column content. I have seen that removing the .clear rule in the .css this is solved but then more problem come with the main menu. Any idea on how to solve this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1860) Problem with create order from quote
[ https://issues.apache.org/jira/browse/OFBIZ-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam closed OFBIZ-1860. Resolution: Fixed Fix Version/s: SVN trunk Thanks for reporting Thanakrit. Fixed in trunk rev. 703075. Problem with create order from quote Key: OFBIZ-1860 URL: https://issues.apache.org/jira/browse/OFBIZ-1860 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Thanakrit Assignee: Bilgin Ibryam Fix For: SVN trunk Attachments: QuoteItem.patch When create the order from quote the system return exception to screen like following: accommodationMapId is not a field of QuoteItem and accommodationSpotId is not a field of QuoteItem i fixed this problem by adding accommodationMapId and accommodationSpotId to QuoteItem entity and it work fine. Sorry in my English because I'm thai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1982) Artifact info logs cleanup
[ https://issues.apache.org/jira/browse/OFBIZ-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637893#action_12637893 ] Bilgin Ibryam commented on OFBIZ-1982: -- Thanks for the explanation Marco. I was not aware that there is error in artifact info logs. Actually I don't see anything wrong in adding main request to common-controller.xml. Artifact info logs cleanup -- Key: OFBIZ-1982 URL: https://issues.apache.org/jira/browse/OFBIZ-1982 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: accounting_cleanup.patch, application_components_cleanup.patch, application_components_cleanup2.patch, content_cleanup.patch, content_cleanup2.patch, framework_components_cleanup.patch, humanres_response_to_not_existing_view.patch, marketing_response_to_not_existing_view.patch, order_response_to_not_existing_view.patch, party_cleanup.patch, specialpurpose_components_cleanup.patch, workeffort_cleanup.patch Looking at the very interesting Artifact info tool I have seen that running it there are a lot of warning into the logs and so I'm trying to fixing some of that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1860) Problem with create order from quote
[ https://issues.apache.org/jira/browse/OFBIZ-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-1860: Assignee: Bilgin Ibryam Problem with create order from quote Key: OFBIZ-1860 URL: https://issues.apache.org/jira/browse/OFBIZ-1860 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Thanakrit Assignee: Bilgin Ibryam Attachments: QuoteItem.patch When create the order from quote the system return exception to screen like following: accommodationMapId is not a field of QuoteItem and accommodationSpotId is not a field of QuoteItem i fixed this problem by adding accommodationMapId and accommodationSpotId to QuoteItem entity and it work fine. Sorry in my English because I'm thai -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1982) Artifact info logs cleanup
[ https://issues.apache.org/jira/browse/OFBIZ-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637845#action_12637845 ] Bilgin Ibryam commented on OFBIZ-1982: -- Hi Marco, I see that you added main request to common-controller.xml. Are you going to clean main request from other controller files after that? Bilgin Artifact info logs cleanup -- Key: OFBIZ-1982 URL: https://issues.apache.org/jira/browse/OFBIZ-1982 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: accounting_cleanup.patch, application_components_cleanup.patch, application_components_cleanup2.patch, content_cleanup.patch, content_cleanup2.patch, framework_components_cleanup.patch, humanres_response_to_not_existing_view.patch, marketing_response_to_not_existing_view.patch, order_response_to_not_existing_view.patch, party_cleanup.patch, specialpurpose_components_cleanup.patch, workeffort_cleanup.patch Looking at the very interesting Artifact info tool I have seen that running it there are a lot of warning into the logs and so I'm trying to fixing some of that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1991) Add a new paymentReasonId on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT
[ https://issues.apache.org/jira/browse/OFBIZ-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637665#action_12637665 ] Bilgin Ibryam commented on OFBIZ-1991: -- Marco, This field makes perfect sense for POS environment. About the field name, lets add also the word EnumId to it as it is a common pattern when using Enumeration entity, something like reasonEnumId or paymentReasonEnumId. Bilgin Add a new paymentReasonId on PosTerminalInternTx entity and store payment reason id during Pos Paid IN/OUT Key: OFBIZ-1991 URL: https://issues.apache.org/jira/browse/OFBIZ-1991 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos, specialpurpose/webpos Affects Versions: SVN trunk Reporter: Marco Risaliti Assignee: Marco Risaliti Priority: Minor Fix For: SVN trunk Attachments: new_paymentReasonId_on_ PosTerminalInternTx.patch On PosTerminalInternTx entity add a new paymentReasonId field. It can be used to store the enumeration payment reason id IN/OUT during Pos Paid IN/OUT so that the pos manager can select a causal why output/input money from/to the cash drawer and in alternative can insert a comment. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1912) Configurable products with Virtual product options
[ https://issues.apache.org/jira/browse/OFBIZ-1912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637042#action_12637042 ] Bilgin Ibryam commented on OFBIZ-1912: -- It is perfect, thanks Jacques! Configurable products with Virtual product options -- Key: OFBIZ-1912 URL: https://issues.apache.org/jira/browse/OFBIZ-1912 Project: OFBiz Issue Type: New Feature Components: product Affects Versions: SVN trunk Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: SVN trunk Attachments: conf_virtual_product.patch Hi all, to implement this feature I did the following things: 1. Added a new entity ConfigOptionProductOption to store selected variant products per configuration. 2. Moved a code snippet about products with VV_FEATURETREE from ShoppingCartEvents to ProductWorker. 3. Added a demo product PIZZA to test demonstrate Configurable products with Virtual product options. After applying the patch and run-install you can find the product on ecommerce and order manager. Based on selected variant products, the price of configurable product is recalculated. Any test, review and thoughts would be greatly appreciated. Bilgin Ibryam -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1943) List/Multi form column sorting
[
https://issues.apache.org/jira/browse/OFBIZ-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam closed OFBIZ-1943.
Resolution: Fixed
Fix Version/s: SVN trunk
Added also default styles and committed in trunk rev. 702236and rev. 702238.
Bruno,
sorry for the delay, but now you can include this in October feature list ;)
List/Multi form column sorting
--
Key: OFBIZ-1943
URL: https://issues.apache.org/jira/browse/OFBIZ-1943
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Reporter: Bruno Busco
Assignee: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
Attachments: columnSort.diff, columnSort.diff, columnSort.rar,
framework_images_webapp_images.zip, sortable_form_column.jpg,
sortable_form_columns.patch
Hi,
I would like to submit, to be reviewed, what I have done to implement
sortable columns in multi and list forms.
I wonder if there is a simpler and better solution that could, for instance,
be implemented in the form widget itself requiring less code in the xml file.
To be reviewed I implemented the sortable column in the FindExample Screen.
This solution requires a little change in the framework (included in the
patch). Basically the header-link-style attribute of the field tag needs to
be parsed by FlexibleStringExpander in order to be used with a ${}.
Two little arrow-up and arrow-down icons are also attached, those are shown
close to the field name indicating which is the sorted column and the sort
order.
Thank you for reviewing,
Bruno
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1978) createShipment parameters : add a shipmentId in IN parameters
[ https://issues.apache.org/jira/browse/OFBIZ-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637205#action_12637205 ] Bilgin Ibryam commented on OFBIZ-1978: -- Jacques, you mean harmless probably ;) createShipment parameters : add a shipmentId in IN parameters - Key: OFBIZ-1978 URL: https://issues.apache.org/jira/browse/OFBIZ-1978 Project: OFBiz Issue Type: Improvement Components: product Reporter: Charles STELTZLEN Assignee: Jacques Le Roux Priority: Minor Fix For: SVN trunk Attachments: shipment.patch Original Estimate: 0.5h Remaining Estimate: 0.5h In Shipment services, the service of creation, called *createShipment*, don't accept our own *shipmentId*. It can be a problem in some business, and I think it won't be difficult to add a IN parameter shipmentId. So, I propose to change the service and use a shipmentId given by default, and if there is no shipmentId in parameters, it will get the next sequenced id (as it already done in the createShipment service). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1953) Cleanup ship groups doesn't work
[ https://issues.apache.org/jira/browse/OFBIZ-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637214#action_12637214 ] Bilgin Ibryam commented on OFBIZ-1953: -- Dimitri, can you explain, how your patch is going to fix the bug? W/o any tests, it seems to me that the result will be the same. Bilgin Cleanup ship groups doesn't work Key: OFBIZ-1953 URL: https://issues.apache.org/jira/browse/OFBIZ-1953 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Dimitri Unruh Attachments: ShoppingCart.java.patch Hi everyone, I guess the method cleanUpShipGroups in the ShoppingCart.java is buggy. If you have many CartShipInfo objects in your cart and some of them are empty (shipItemInfo.size() == 0) the method don't remove all of them. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1008) ObjectType does not recognize arrays
[ https://issues.apache.org/jira/browse/OFBIZ-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12637312#action_12637312 ] Bilgin Ibryam commented on OFBIZ-1008: -- Jacques, it is not a type, the signature L fully-qualified-class ; means the class uniquely specified by that name. ObjectType does not recognize arrays Key: OFBIZ-1008 URL: https://issues.apache.org/jira/browse/OFBIZ-1008 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Environment: SUSE Linux 10.1 MySQL 5.0.18 Reporter: Michael Imhof Assignee: Jacques Le Roux Fix For: SVN trunk Attachments: ObjectType.java, ObjectType_LoadClass.patch We're using ByteArrays (byte[]) in our services: service name=processImage engine=simple default-entity-name=Archivindex location=ch/nowhow/isgate/archiv/ArchivServices.xml invoke=processImage export=true attribute name=image type=byte[] mode=IN optional=false/attribute /service Sending a SOAP envelope (from the generated WSDL) to the server, ofbiz could not find the byte array (Remind that a ByteArray is not supported by OfBiz WSDL!!! We're using Java2WSDL to generate a WSDL) Please forget first patch file (smaller one). This smaller patch doesn't solve the whole array problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1943) List/Multi form column sorting
[
https://issues.apache.org/jira/browse/OFBIZ-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bilgin Ibryam reassigned OFBIZ-1943:
Assignee: Bilgin Ibryam
List/Multi form column sorting
--
Key: OFBIZ-1943
URL: https://issues.apache.org/jira/browse/OFBIZ-1943
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Reporter: Bruno Busco
Assignee: Bilgin Ibryam
Priority: Minor
Attachments: columnSort.diff, columnSort.diff, columnSort.rar,
framework_images_webapp_images.zip, sortable_form_column.jpg,
sortable_form_columns.patch
Hi,
I would like to submit, to be reviewed, what I have done to implement
sortable columns in multi and list forms.
I wonder if there is a simpler and better solution that could, for instance,
be implemented in the form widget itself requiring less code in the xml file.
To be reviewed I implemented the sortable column in the FindExample Screen.
This solution requires a little change in the framework (included in the
patch). Basically the header-link-style attribute of the field tag needs to
be parsed by FlexibleStringExpander in order to be used with a ${}.
Two little arrow-up and arrow-down icons are also attached, those are shown
close to the field name indicating which is the sorted column and the sort
order.
Thank you for reviewing,
Bruno
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
