[jira] [Commented] (OFBIZ-5370) OrderItemShipGrpInvRes incorrect when receiving an inventory item that relates to more than one record
[ https://issues.apache.org/jira/browse/OFBIZ-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203680#comment-14203680 ] Joe Eckard commented on OFBIZ-5370: --- Is this the right approach to fixing the underlying issue? It seems like the “reassignInventoryItems” service will cancel and re-reserve ALL reservations for a specified product - which does avoid the reported problem, but can perform lots of unnecessary work and create many unnecessary artifacts (since it is called every time you receive inventory or perform a physical inventory / variance). I ask only because I encountered this bug in an older codebase through a different set of circumstances, and trying to understand balanceInventoryItems has been a very confusing experience. I would love to see it cleaned up, removed or replaced. My initial impression is that balanceInventoryItems was intended to be called whenever some inventory was added in order to immediately relieve as many backorders as it could. If that is the case, why not look for reservations with quantityNotAvailable > 0 instead of the current logic? If that approach is sound, there is still the case where balanceInventoryItems is called as an ECA when you perform a physical inventory and record a negative variance instead of a positive variance, but I think reassignInventoryItems might be the right thing to use there. > OrderItemShipGrpInvRes incorrect when receiving an inventory item that > relates to more than one record > -- > > Key: OFBIZ-5370 > URL: https://issues.apache.org/jira/browse/OFBIZ-5370 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 12.04 >Reporter: Christian Carlow >Assignee: Anil K Patel > Attachments: OFBIZ-5370-trunk.patch > > > OrderItemShipGrpInv records that share the same inventoryItemId calculate > incorrect results when receiving inventory for the product. > To reproduce: > 1. Create an order for product "PEPPERS-G" with a quantity of 10 and click > "Finish Order" > 2. Add another ship group and click "Continue" > 3. Assign 5 of the order items to the second ship group created and then > finish the order > 4. Navigate to the Receive Inventory page of the WebStoreWarehouse facility > 5. Enter "PEPPERS-G" into the productId field and click "Receive Product" > 6. Enter a quantity of 6 into the quantityAccepted field and click "Receive" > 7. Open the OrderItemShipGrpInvRes table and notice that the > quantityNotAvailable field has been set to blank for the first record and 4 > for the second record and that they both share the same inventoryItemId > 8. Now navigate back to the Receive Items page and receive in the product > again but with a quantity of 1 > 9. Refresh the OrderItemShipGrpInvRes results and notice that the first > record has a new inventory item applied to it with a quantity of 1 and the > other record has been updated to reflect a new quantityNotAvailable value. > It seems like OrderItemShipGrpInvRes should be deleted anytime the > quantityNotAvailable field gets set to 0, blank, or null. I've noticed this > logic performed in other methods that deal the entity. > Step 9 should not add quantityNotAvailable back to the first record one it > has been fulfilled. The second item was supposed to have its > quantityNotAvailable field decremented by 1 but no change took plce for it. > I believe this problem is probably caused by an inventoryItemId being > associated with more than one record in the table. > This problem basically happens anytime the inventory received is greater than > the quantityNotAvailable field of the first OrderItemShipGrpRes table. It > happens when you have orders from two different customers and you receive > more inventory than the quantityNotAvailable for the first customer order > item. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5215) GenericDelegator rollback can fail when optimistic locking is enabled
[ https://issues.apache.org/jira/browse/OFBIZ-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788212#comment-13788212 ] Joe Eckard commented on OFBIZ-5215: --- Also, I'm not sure if the proposed fix is reasonable or even on the right track, I just wanted to report the issue. > GenericDelegator rollback can fail when optimistic locking is enabled > - > > Key: OFBIZ-5215 > URL: https://issues.apache.org/jira/browse/OFBIZ-5215 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard > > If an entity uses optimistic (timestamp) locking, then when rollback() > attempts to revert an UPDATE test operation an EntityLockedException is > thrown (because it calls store() on the original value which has old > timestamps). > Proposed fix: disable the locking with modelEntity.setDoLock(false)? I'm not > sure if we need to re-enable it afterwards of if it is ok at this point to > leave it disabled. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (OFBIZ-5215) GenericDelegator rollback can fail when optimistic locking is enabled
[ https://issues.apache.org/jira/browse/OFBIZ-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788206#comment-13788206 ] Joe Eckard commented on OFBIZ-5215: --- 1) Yes, GenericDelegator.rollback() is used to roll back test operations when running in test mode. 2) Why close an issue when there is no evidence the actual problem has been resolved? I don't recall exactly what I was suggesting with the "proposed fix: ?" - most likely it was disabling the locking only long enough to revert an UPDATE. I would have to find the old test case or create a new one from scratch to be sure. To reproduce the problem, enable locking for an entity (enable-lock="true" in the entity def.), then write a test that updates a value object - when the test operations are rolled back, you should see the problem described above. > GenericDelegator rollback can fail when optimistic locking is enabled > - > > Key: OFBIZ-5215 > URL: https://issues.apache.org/jira/browse/OFBIZ-5215 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard > > If an entity uses optimistic (timestamp) locking, then when rollback() > attempts to revert an UPDATE test operation an EntityLockedException is > thrown (because it calls store() on the original value which has old > timestamps). > Proposed fix: disable the locking with modelEntity.setDoLock(false)? I'm not > sure if we need to re-enable it afterwards of if it is ok at this point to > leave it disabled. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (OFBIZ-5331) Change EntityComparisonOperator to use compareTo()
[ https://issues.apache.org/jira/browse/OFBIZ-5331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-5331: -- Attachment: patch.txt > Change EntityComparisonOperator to use compareTo() > -- > > Key: OFBIZ-5331 > URL: https://issues.apache.org/jira/browse/OFBIZ-5331 > Project: OFBiz > Issue Type: Improvement > Components: framework >Reporter: Joe Eckard >Priority: Trivial > Attachments: patch.txt > > > The methods compareEqual() and compareNotEqual() both use equals() instead of > compareTo() which can be problematic when used to compare BigDecimal objects. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5331) Change EntityComparisonOperator to use compareTo()
Joe Eckard created OFBIZ-5331: - Summary: Change EntityComparisonOperator to use compareTo() Key: OFBIZ-5331 URL: https://issues.apache.org/jira/browse/OFBIZ-5331 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Joe Eckard Priority: Trivial The methods compareEqual() and compareNotEqual() both use equals() instead of compareTo() which can be problematic when used to compare BigDecimal objects. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OFBIZ-5215) GenericDelegator rollback can fail when optimistic locking is enabled
Joe Eckard created OFBIZ-5215: - Summary: GenericDelegator rollback can fail when optimistic locking is enabled Key: OFBIZ-5215 URL: https://issues.apache.org/jira/browse/OFBIZ-5215 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Joe Eckard If an entity uses optimistic (timestamp) locking, then when rollback() attempts to revert an UPDATE test operation an EntityLockedException is thrown (because it calls store() on the original value which has old timestamps). Proposed fix: disable the locking with modelEntity.setDoLock(false)? I'm not sure if we need to re-enable it afterwards of if it is ok at this point to leave it disabled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OFBIZ-3557) Enforced sequence does not work with concurrent access
[ https://issues.apache.org/jira/browse/OFBIZ-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-3557: -- Priority: Blocker (was: Major) > Enforced sequence does not work with concurrent access > -- > > Key: OFBIZ-3557 > URL: https://issues.apache.org/jira/browse/OFBIZ-3557 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 09.04, SVN trunk >Reporter: Wickersheimer Jeremy >Priority: Blocker > Attachments: OFBIZ-3557-1.patch, OFBIZ-3557-2.patch > > > There is a fundamental issue with enforced sequences (for orders, invoices, > etc ..) and concurrency. > For example if two users are creating an order at the same time one of them > will see the creation fail with a PK error. The problem is that the > "getNextXXXId" rely on the party accounting preference entity, but there is > absolutely no guarantee that the last number in the sequence gets updated > before another service can read it. > This is at best very annoying when used only internally but may be > unpractical for e-commerce sites. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041778#comment-13041778 ] Joe Eckard commented on OFBIZ-1116: --- Please see the comment I left on 02/Nov/08, it is still valid - i.e. the issue is still there. It has been so long I am sure there is a fix or workaround, but I haven't fully investigated it. > Problem making SSL connection to admin apps with Safari > --- > > Key: OFBIZ-1116 > URL: https://issues.apache.org/jira/browse/OFBIZ-1116 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > > I can't seem to connect to any admin apps via SSL. The error message from > Safari is: > Safari can't open the page "https://localhost:8443/webtools/control/main"; > because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-3856) quicker picklist option functionality
[
https://issues.apache.org/jira/browse/OFBIZ-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Eckard updated OFBIZ-3856:
--
Attachment: FindOrdersToPick.groovy
entitymodel.xml
> quicker picklist option functionality
> -
>
> Key: OFBIZ-3856
> URL: https://issues.apache.org/jira/browse/OFBIZ-3856
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Release 4.0, Release 09.04, SVN trunk
>Reporter: Albert Mayo
>Priority: Minor
> Attachments: entitymodel.xml, FindOrdersToPick.groovy,
> PickListServices.java, quicker picklist.diff
>
>
> I am noticing as our OFBiz database grows larger, it is taking the
> PicklistOptions longer to load. Even for a batch as small as 50 orders it can
> take up to a couple minutes to load. 300 orders can take upwards of 5-10
> minutes. My development system with much lesser hardware can get through a
> hundred orders in seconds, so I have a feeling it has to do with the
> process/code inefficiency.
> For instance, the picklistoptions function does the following (abbreviated):
> select * from OrderHeader
> for each orderHeader {
> select * from OrderItemShipGroup where orderId = orderHeader.orderId
> for each orderItemShipGroup in orderItemShipGroupList {
> select * from OrderItemShipGrpInvRes where orderId =
> orderItemShipGroup.orderId;
> for each orderItemShipGrpInvRes in orderItemShipGrpInvResList {
> etc
> }
> }
> }
> These kind of loops can create many hits to the database and greatly slow
> down the process, especially if the database tables have many records. Our
> database is now almost 8 gigs. The PicklistOptions process took ~4 minutes
> for 40 pickable orders.
> I am using OFBiz 4.0, but the trunk version has a lot of the same code. I am
> opening this ticket to start a conversation of a quicker method to create
> picklists, like with the use of views or DynamicViewEntitys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3856) quicker picklist option functionality
[
https://issues.apache.org/jira/browse/OFBIZ-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887455#action_12887455
]
Joe Eckard commented on OFBIZ-3856:
---
I'm also going to attach a slightly different version of a 'findOrdersToPick'
service. I was hesitant to create a patch without a good set of test cases,
since this version has not been extensively tested but it may be useful and
relevant to this issue. (This also returns different data than is expected from
the existing service so it is not a drop-in replacement)
> quicker picklist option functionality
> -
>
> Key: OFBIZ-3856
> URL: https://issues.apache.org/jira/browse/OFBIZ-3856
> Project: OFBiz
> Issue Type: Improvement
> Components: product
>Affects Versions: Release 4.0, Release 09.04, SVN trunk
>Reporter: Albert Mayo
>Priority: Minor
> Attachments: PickListServices.java, quicker picklist.diff
>
>
> I am noticing as our OFBiz database grows larger, it is taking the
> PicklistOptions longer to load. Even for a batch as small as 50 orders it can
> take up to a couple minutes to load. 300 orders can take upwards of 5-10
> minutes. My development system with much lesser hardware can get through a
> hundred orders in seconds, so I have a feeling it has to do with the
> process/code inefficiency.
> For instance, the picklistoptions function does the following (abbreviated):
> select * from OrderHeader
> for each orderHeader {
> select * from OrderItemShipGroup where orderId = orderHeader.orderId
> for each orderItemShipGroup in orderItemShipGroupList {
> select * from OrderItemShipGrpInvRes where orderId =
> orderItemShipGroup.orderId;
> for each orderItemShipGrpInvRes in orderItemShipGrpInvResList {
> etc
> }
> }
> }
> These kind of loops can create many hits to the database and greatly slow
> down the process, especially if the database tables have many records. Our
> database is now almost 8 gigs. The PicklistOptions process took ~4 minutes
> for 40 pickable orders.
> I am using OFBiz 4.0, but the trunk version has a lot of the same code. I am
> opening this ticket to start a conversation of a quicker method to create
> picklists, like with the use of views or DynamicViewEntitys.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3704) Store supplierProductId in OrderItems for Purchase Orders
[ https://issues.apache.org/jira/browse/OFBIZ-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard closed OFBIZ-3704. - Resolution: Fixed implemented as of r935032 > Store supplierProductId in OrderItems for Purchase Orders > - > > Key: OFBIZ-3704 > URL: https://issues.apache.org/jira/browse/OFBIZ-3704 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: supplierProductId.patch > > > Store supplierProductId as a field of OrderItem for purchase orders so that > it can be retrieved later. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-3704) Store supplierProductId in OrderItems for Purchase Orders
[ https://issues.apache.org/jira/browse/OFBIZ-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-3704: -- Attachment: supplierProductId.patch I have these changes staged in git ready for a commit, just putting a patch here for review. > Store supplierProductId in OrderItems for Purchase Orders > - > > Key: OFBIZ-3704 > URL: https://issues.apache.org/jira/browse/OFBIZ-3704 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: supplierProductId.patch > > > Store supplierProductId as a field of OrderItem for purchase orders so that > it can be retrieved later. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (OFBIZ-3704) Store supplierProductId in OrderItems for Purchase Orders
Store supplierProductId in OrderItems for Purchase Orders - Key: OFBIZ-3704 URL: https://issues.apache.org/jira/browse/OFBIZ-3704 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Joe Eckard Assignee: Joe Eckard Priority: Minor Fix For: SVN trunk Store supplierProductId as a field of OrderItem for purchase orders so that it can be retrieved later. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3100) Resolve java warnings exposed in Eclipse
[ https://issues.apache.org/jira/browse/OFBIZ-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771460#action_12771460 ] Joe Eckard commented on OFBIZ-3100: --- Very minor issue regarding import statements... these patches sort imports and remove blank lines. At some time long ago I believe the suggestion was to setup your IDE to produce something like: java.* javax.* org.ofbiz.* everything else but I can't seem to find this info posted anywhere. Looking through a random sampling of files, some follow that pattern while others do not... if there was / is a compelling reason to do things that way, then within this issue might be a good place to reformat. > Resolve java warnings exposed in Eclipse > > > Key: OFBIZ-3100 > URL: https://issues.apache.org/jira/browse/OFBIZ-3100 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Bob Morley > > There are over 9000 warnings reported when you do a build in Eclipse. Let's > clean them up! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3077) Error for productStoreId when click on productId link from showcart of purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769331#action_12769331 ] Joe Eckard commented on OFBIZ-3077: --- This error occurs because the product detail & product summary screens assume that a product store will always be present. Fixing this is not as easy as fixing the NPE, because you will need to make some larger changes to the logic and display... e.g. if no store is present, should you hide reviews or show all reviews - what about ratings / surveys, estimated ship date vs vendor lead time, etc. I started working on this but realized it will take more time than I have available right now - adding the note in case someone else is about to take a look. > Error for productStoreId when click on productId link from showcart of > purchase order > - > > Key: OFBIZ-3077 > URL: https://issues.apache.org/jira/browse/OFBIZ-3077 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Brajesh Patel > Fix For: SVN trunk > > > Steps regenerate error: > 1) Hit url: https://localhost:8443/ordermgr/control/orderentry > 2) Select purchase order with supplier > 3) Add product for order > 4) Click on the productId from showcart page > it will generate error as following > org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen > [component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail]: > java.lang.NullPointerException: Cannot get property 'productStoreId' on null > object (Cannot get property 'productStoreId' on null object) > Thanks Rishi, Mridul and Ratnesh for discussion. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2963) Error creating pdf Report
[ https://issues.apache.org/jira/browse/OFBIZ-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2963: -- Attachment: OFBIZ-2963.patch renderScreenBegin / renderScreenEnd macros were missing from foScreenMacroLibrary.ftl - copied the trunk version to create this patch. (I do not have framework commit access.) > Error creating pdf Report > - > > Key: OFBIZ-2963 > URL: https://issues.apache.org/jira/browse/OFBIZ-2963 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 9.04 >Reporter: Matarazzo Angelo > Fix For: SVN trunk > > Attachments: OFBIZ-2963.patch > > > In > https://demo.ofbiz.org/example/control/EditExample?exampleId=10001 > or > https://demo904.ofbiz.org/ordermgr/control/OrderPurchaseReportOptions > there is a bug creating pdf report. > However I have looked at class ScreenFopViewHandler.java of Branch 9.04 and > MacroFormRenderer class is used. > I test with old java file before Rev 763511 and everything works. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2963) Error creating pdf Report
[ https://issues.apache.org/jira/browse/OFBIZ-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762658#action_12762658 ] Joe Eckard commented on OFBIZ-2963: --- To recap: all PDF rendering is broken in the 9.04 branch, and this is not related to invalid XML characters, but has something to do with the macro screen rendering. > Error creating pdf Report > - > > Key: OFBIZ-2963 > URL: https://issues.apache.org/jira/browse/OFBIZ-2963 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 9.04 >Reporter: Matarazzo Angelo > Fix For: SVN trunk > > > In > https://demo.ofbiz.org/example/control/EditExample?exampleId=10001 > or > https://demo904.ofbiz.org/ordermgr/control/OrderPurchaseReportOptions > there is a bug creating pdf report. > However I have looked at class ScreenFopViewHandler.java of Branch 9.04 and > MacroFormRenderer class is used. > I test with old java file before Rev 763511 and everything works. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3003) When generating a PDF-document from order (or invoice), OFBiz gives an error message
[ https://issues.apache.org/jira/browse/OFBIZ-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard closed OFBIZ-3003. - Resolution: Duplicate This issue is a duplicate of OFBIZ-2963. > When generating a PDF-document from order (or invoice), OFBiz gives an error > message > > > Key: OFBIZ-3003 > URL: https://issues.apache.org/jira/browse/OFBIZ-3003 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 9.04 > Environment: > https://demo904.ofbiz.org/ordermgr/control/order.pdf?orderId=DEMO10090 >Reporter: Torstein Hegbom > Fix For: Release Branch 9.04 > > > When generating a PDF-document from order (or invoice), OFBiz gives the > following message: > The Following Errors Occurred: > Unable to transform FO file: javax.xml.transform.TransformerException: > org.xml.sax.SAXParseException: Content is not allowed in prolog. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2963) Error creating pdf Report
[ https://issues.apache.org/jira/browse/OFBIZ-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762279#action_12762279 ] Joe Eckard commented on OFBIZ-2963: --- The character problem is unrelated to the original issue and the error I posted. The first link in the report: [https://demo.ofbiz.org/example/control/EditExample?exampleId=10001] should actually be: [https://demo904.ofbiz.org/example/control/EditExample?exampleId=10001] since the problem is with the 9.04 branch. > Error creating pdf Report > - > > Key: OFBIZ-2963 > URL: https://issues.apache.org/jira/browse/OFBIZ-2963 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 9.04 >Reporter: Matarazzo Angelo > Fix For: SVN trunk > > > In > https://demo.ofbiz.org/example/control/EditExample?exampleId=10001 > or > https://demo904.ofbiz.org/ordermgr/control/OrderPurchaseReportOptions > there is a bug creating pdf report. > However I have looked at class ScreenFopViewHandler.java of Branch 9.04 and > MacroFormRenderer class is used. > I test with old java file before Rev 763511 and everything works. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2963) Error creating pdf Report
[
https://issues.apache.org/jira/browse/OFBIZ-2963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762231#action_12762231
]
Joe Eckard commented on OFBIZ-2963:
---
[https://demo904.ofbiz.org/catalog/control/ProductBarCode.pdf?productId=GZ-1006&productName=Open%20Gizmo]
the error is:
{noformat}
2009-10-05 11:50:39,371 (http-0.0.0.0-8443-1) [
RequestHandler.java:697:INFO ] Rendering View [ProductBarCode.pdf],
sessionId=B719108BBE94E0562113541CD504.jvm1
2009-10-05 11:50:39,880 (http-0.0.0.0-8443-1) [ Log4JLoggerFactory.java:96
:ERROR]
on line 1, column 1 in Mon Oct 05 11:50:39 EDT 2009 renderScreenBegin not found.
The problematic instruction:
--
==> user-directive renderScreenBegin [on line 1, column 1 in Mon Oct 05
11:50:39 EDT 2009]
--
Java backtrace for programmers:
--
freemarker.core.InvalidReferenceException: on line 1, column 1 in Mon Oct 05
11:50:39 EDT 2009 renderScreenBegin not found.
at freemarker.core.UnifiedCall.accept(UnifiedCall.java:134)
at freemarker.core.Environment.visit(Environment.java:209)
at freemarker.core.Environment.include(Environment.java:1482)
at
org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:95)
at
org.ofbiz.widget.screen.MacroScreenRenderer.executeMacro(MacroScreenRenderer.java:104)
at
org.ofbiz.widget.screen.MacroScreenRenderer.renderScreenBegin(MacroScreenRenderer.java:112)
{noformat}
> Error creating pdf Report
> -
>
> Key: OFBIZ-2963
> URL: https://issues.apache.org/jira/browse/OFBIZ-2963
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 9.04
>Reporter: Matarazzo Angelo
> Fix For: SVN trunk
>
>
> In
> https://demo.ofbiz.org/example/control/EditExample?exampleId=10001
> or
> https://demo904.ofbiz.org/ordermgr/control/OrderPurchaseReportOptions
> there is a bug creating pdf report.
> However I have looked at class ScreenFopViewHandler.java of Branch 9.04 and
> MacroFormRenderer class is used.
> I test with old java file before Rev 763511 and everything works.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2804) error when cancelling an order
[ https://issues.apache.org/jira/browse/OFBIZ-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744067#action_12744067 ] Joe Eckard commented on OFBIZ-2804: --- I'm not sure exactly what you mean, but yes this bug was exposed as a result of the changes in r795883. > error when cancelling an order > --- > > Key: OFBIZ-2804 > URL: https://issues.apache.org/jira/browse/OFBIZ-2804 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Erwan de FERRIERES >Assignee: Joe Eckard > Fix For: SVN trunk > > Attachments: OFBIZ-2804.diff > > > when you create a purchase order with the demo data, and then you want to > cancel it, there is an error, because no productStoreId is associated to the > order. The patch will correct the problem. > You can reproduce the error by creating a purchase order with demosupplier as > supplier, adding some products to the order and then creating it. > When you arrive on the orderview scree, first there is no productstore > associated to the order. Then if you click on "cancel order" you will have > the message saying that there is no productStore or payToPartyId for tax > calculation. > If you insert the data contained in the patch and make the same steps, you > won't have any error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2741) Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2741: -- Attachment: OFBIZ-2741.2.patch Updated patch. A side effect will be that empty ship groups are not auto-cleared when empty, you have to explicitly request this with finalizeMode=removeEmptyShipGroups during checkout. Not committing right away in case there are objections to this behavior. > Information of shipping method and sales tax are remove from cart when we > update shopping cart item quantity. > - > > Key: OFBIZ-2741 > URL: https://issues.apache.org/jira/browse/OFBIZ-2741 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 9.04, SVN trunk >Reporter: Arun Patidar >Assignee: Vikas Mayur >Priority: Minor > Attachments: OFBIZ-2741.2.patch, OFBIZ-2741.patch, OFBIZ-2741.patch, > sci-patch.txt > > > On update cart item quantity after selecting shipping method, Informations of > shipping method and sales tax removes if there is only one item in cart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742866#action_12742866 ] Joe Eckard commented on OFBIZ-2741: --- Create a PO for DemoSupplier consisting of 1 item. Finalize order, continue through selecting the shipping address, then go back to order items and change quantity and finalize again. I am working on a custom codebase that sets order info before items are added, so I can't easily provide examples for those scenarios. The applied patch only addresses the scenario where item quantities are modified for sales orders. > Information of shipping method and sales tax are remove from cart when we > update shopping cart item quantity. > - > > Key: OFBIZ-2741 > URL: https://issues.apache.org/jira/browse/OFBIZ-2741 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 9.04, SVN trunk >Reporter: Arun Patidar >Assignee: Vikas Mayur >Priority: Minor > Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt > > > On update cart item quantity after selecting shipping method, Informations of > shipping method and sales tax removes if there is only one item in cart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742566#action_12742566 ] Joe Eckard commented on OFBIZ-2741: --- This bug is still present - the line: cart.setItemShipGroupQty(item, quantity, 0); in the applied patch can be reverted - it is unnecessary because setItemShipGroupQty() is already called within item.setQuantity(), and it doesn't address the problem. The code that is clearing the shipping contact mech when an item is added (or the quantity is changed) is ShoppingCart.clearItemShipInfo() followed directly by ShoppingCart.cleanUpShipGroups(). This happens when resetShipGroups is set to true, which is the default value when calling setQuantity() on a ShoppingCartItem. Also, it only seems to do this when there is only 1 line item in the cart - when there are multiple line items, it doesn't clear the shipping contact mech. I was working on a patch but ran out of time, adding notes here so I can come back to it or someone else can take a quick look. > Information of shipping method and sales tax are remove from cart when we > update shopping cart item quantity. > - > > Key: OFBIZ-2741 > URL: https://issues.apache.org/jira/browse/OFBIZ-2741 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 9.04, SVN trunk >Reporter: Arun Patidar >Assignee: Vikas Mayur >Priority: Minor > Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt > > > On update cart item quantity after selecting shipping method, Informations of > shipping method and sales tax removes if there is only one item in cart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OFBIZ-2804) error when cancelling an order
[ https://issues.apache.org/jira/browse/OFBIZ-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard resolved OFBIZ-2804. --- Resolution: Fixed Fixed in 801770 > error when cancelling an order > --- > > Key: OFBIZ-2804 > URL: https://issues.apache.org/jira/browse/OFBIZ-2804 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Erwan de FERRIERES >Assignee: Joe Eckard > Fix For: SVN trunk > > Attachments: OFBIZ-2804.diff > > > when you create a purchase order with the demo data, and then you want to > cancel it, there is an error, because no productStoreId is associated to the > order. The patch will correct the problem. > You can reproduce the error by creating a purchase order with demosupplier as > supplier, adding some products to the order and then creating it. > When you arrive on the orderview scree, first there is no productstore > associated to the order. Then if you click on "cancel order" you will have > the message saying that there is no productStore or payToPartyId for tax > calculation. > If you insert the data contained in the patch and make the same steps, you > won't have any error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2804) error when cancelling an order
[ https://issues.apache.org/jira/browse/OFBIZ-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard reassigned OFBIZ-2804: - Assignee: Joe Eckard > error when cancelling an order > --- > > Key: OFBIZ-2804 > URL: https://issues.apache.org/jira/browse/OFBIZ-2804 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Erwan de FERRIERES >Assignee: Joe Eckard > Fix For: SVN trunk > > Attachments: OFBIZ-2804.diff > > > when you create a purchase order with the demo data, and then you want to > cancel it, there is an error, because no productStoreId is associated to the > order. The patch will correct the problem. > You can reproduce the error by creating a purchase order with demosupplier as > supplier, adding some products to the order and then creating it. > When you arrive on the orderview scree, first there is no productstore > associated to the order. Then if you click on "cancel order" you will have > the message saying that there is no productStore or payToPartyId for tax > calculation. > If you insert the data contained in the patch and make the same steps, you > won't have any error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2804) error when cancelling an order
[ https://issues.apache.org/jira/browse/OFBIZ-2804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740171#action_12740171 ] Joe Eckard commented on OFBIZ-2804: --- This seed data was removed because we don't want to require a product store for purchase orders, so we don't want to add it. > error when cancelling an order > --- > > Key: OFBIZ-2804 > URL: https://issues.apache.org/jira/browse/OFBIZ-2804 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Erwan de FERRIERES >Assignee: Joe Eckard > Fix For: SVN trunk > > Attachments: OFBIZ-2804.diff > > > when you create a purchase order with the demo data, and then you want to > cancel it, there is an error, because no productStoreId is associated to the > order. The patch will correct the problem. > You can reproduce the error by creating a purchase order with demosupplier as > supplier, adding some products to the order and then creating it. > When you arrive on the orderview scree, first there is no productstore > associated to the order. Then if you click on "cancel order" you will have > the message saying that there is no productStore or payToPartyId for tax > calculation. > If you insert the data contained in the patch and make the same steps, you > won't have any error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2800) Add methods to OrderReadHelper to retrieve attributes
[ https://issues.apache.org/jira/browse/OFBIZ-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740085#action_12740085 ] Joe Eckard commented on OFBIZ-2800: --- Yes, I just marked it as 9.04 since the patch was created from that branch. Also, would there be any objection to backporting it also? > Add methods to OrderReadHelper to retrieve attributes > - > > Key: OFBIZ-2800 > URL: https://issues.apache.org/jira/browse/OFBIZ-2800 > Project: OFBiz > Issue Type: New Feature > Components: order >Affects Versions: Release Branch 9.04 >Reporter: Joe Eckard >Priority: Trivial > Fix For: Release Branch 9.04 > > Attachments: orh.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2800) Add methods to OrderReadHelper to retrieve attributes
[ https://issues.apache.org/jira/browse/OFBIZ-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2800: -- Attachment: orh.patch > Add methods to OrderReadHelper to retrieve attributes > - > > Key: OFBIZ-2800 > URL: https://issues.apache.org/jira/browse/OFBIZ-2800 > Project: OFBiz > Issue Type: New Feature > Components: order >Affects Versions: Release Branch 9.04 >Reporter: Joe Eckard >Priority: Trivial > Fix For: Release Branch 9.04 > > Attachments: orh.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2800) Add methods to OrderReadHelper to retrieve attributes
Add methods to OrderReadHelper to retrieve attributes - Key: OFBIZ-2800 URL: https://issues.apache.org/jira/browse/OFBIZ-2800 Project: OFBiz Issue Type: New Feature Components: order Affects Versions: Release Branch 9.04 Reporter: Joe Eckard Priority: Trivial Fix For: Release Branch 9.04 Attachments: orh.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2754) Order Entry - Add / Update Order Terms Functionality Broken
[ https://issues.apache.org/jira/browse/OFBIZ-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard reassigned OFBIZ-2754: - Assignee: Joe Eckard > Order Entry - Add / Update Order Terms Functionality Broken > --- > > Key: OFBIZ-2754 > URL: https://issues.apache.org/jira/browse/OFBIZ-2754 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard > Fix For: SVN trunk > > > You can add a new term, but the termValue & termDays parameters are ignored. > I have a fix, but I would also like to refactor the ftl and groovy scripts at > the same time. Should have a patch ready within 24 hours. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OFBIZ-2754) Order Entry - Add / Update Order Terms Functionality Broken
[ https://issues.apache.org/jira/browse/OFBIZ-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard resolved OFBIZ-2754. --- Resolution: Fixed Fix Version/s: SVN trunk Fixed in rev. 797535 > Order Entry - Add / Update Order Terms Functionality Broken > --- > > Key: OFBIZ-2754 > URL: https://issues.apache.org/jira/browse/OFBIZ-2754 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard > Fix For: SVN trunk > > > You can add a new term, but the termValue & termDays parameters are ignored. > I have a fix, but I would also like to refactor the ftl and groovy scripts at > the same time. Should have a patch ready within 24 hours. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2754) Order Entry - Add / Update Order Terms Functionality Broken
Order Entry - Add / Update Order Terms Functionality Broken --- Key: OFBIZ-2754 URL: https://issues.apache.org/jira/browse/OFBIZ-2754 Project: OFBiz Issue Type: Bug Components: order Affects Versions: SVN trunk Reporter: Joe Eckard You can add a new term, but the termValue & termDays parameters are ignored. I have a fix, but I would also like to refactor the ftl and groovy scripts at the same time. Should have a patch ready within 24 hours. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OFBIZ-1172) Order Entry unclear error when no ProductStore set
[ https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard resolved OFBIZ-1172. --- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Joe Eckard ProductStore no longer required for PO entry as of rev. 795883 > Order Entry unclear error when no ProductStore set > -- > > Key: OFBIZ-1172 > URL: https://issues.apache.org/jira/browse/OFBIZ-1172 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 4.0, SVN trunk >Reporter: Wickersheimer Jeremy >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: ofbiz-1172.patch, po-no-product-store.patch > > > I ran into this issue because our staff accidentally removed the ProductStore > from the OrderEntry Website. The symptom was an java NPE display when trying > to create a Purchase Order. > Because it took me some time to debug it i wrote a patch to make this > behavior more obvious. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2741) Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2741: -- Attachment: sci-patch.txt > Information of shipping method and sales tax are remove from cart when we > update shopping cart item quantity. > - > > Key: OFBIZ-2741 > URL: https://issues.apache.org/jira/browse/OFBIZ-2741 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 9.04, SVN trunk >Reporter: Arun Patidar >Priority: Minor > Attachments: OFBIZ-2741.patch, sci-patch.txt > > > On update cart item quantity after selecting shipping method, Informations of > shipping method and sales tax removes if there is only one item in cart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733226#action_12733226 ] Joe Eckard commented on OFBIZ-2741: --- I noticed this last week also... but I have a different fix (see patch). The question is: why were we always resetting the ship info each time an item was modified, and do we need to handle that conditionally now? > Information of shipping method and sales tax are remove from cart when we > update shopping cart item quantity. > - > > Key: OFBIZ-2741 > URL: https://issues.apache.org/jira/browse/OFBIZ-2741 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 9.04, SVN trunk >Reporter: Arun Patidar >Priority: Minor > Attachments: OFBIZ-2741.patch > > > On update cart item quantity after selecting shipping method, Informations of > shipping method and sales tax removes if there is only one item in cart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1172) Order Entry unclear error when no ProductStore set
[ https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1172: -- Attachment: po-no-product-store.patch Patch to allow PO order entry without requiring a ProductStore > Order Entry unclear error when no ProductStore set > -- > > Key: OFBIZ-1172 > URL: https://issues.apache.org/jira/browse/OFBIZ-1172 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 4.0, SVN trunk >Reporter: Wickersheimer Jeremy >Priority: Minor > Attachments: ofbiz-1172.patch, po-no-product-store.patch > > > I ran into this issue because our staff accidentally removed the ProductStore > from the OrderEntry Website. The symptom was an java NPE display when trying > to create a Purchase Order. > Because it took me some time to debug it i wrote a patch to make this > behavior more obvious. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1172) Order Entry unclear error when no ProductStore set
[ https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728324#action_12728324 ] Joe Eckard commented on OFBIZ-1172: --- It looks like removing the dependency on a ProductStore for purchase order creation will be non-trivial effort, requiring changes to the shopping cart and order entry (which will also affect sales orders). Before I go any further, does anyone know why this may have been introduced? Was there a specific reason, or was this possibly just the result of assumptions made based on sales order entry? Since our requirements are very basic, I may be overlooking something important and would hate to spend time unnecessarily. > Order Entry unclear error when no ProductStore set > -- > > Key: OFBIZ-1172 > URL: https://issues.apache.org/jira/browse/OFBIZ-1172 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 4.0, SVN trunk >Reporter: Wickersheimer Jeremy >Priority: Minor > Attachments: ofbiz-1172.patch > > > I ran into this issue because our staff accidentally removed the ProductStore > from the OrderEntry Website. The symptom was an java NPE display when trying > to create a Purchase Order. > Because it took me some time to debug it i wrote a patch to make this > behavior more obvious. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2644) syntax is incorrect
[ https://issues.apache.org/jira/browse/OFBIZ-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723094#action_12723094 ] Joe Eckard commented on OFBIZ-2644: --- +1 for Scott's comment, I didn't look at the patch before I commented - the problem there is just plain malformed html. After checking the DTD, does not appear to be valid, since the div element it is not declared as EMPTY. I'm not sure why it was passed by the validator. http://www.w3.org/TR/xhtml1/#h-4.3 > syntax is incorrect > -- > > Key: OFBIZ-2644 > URL: https://issues.apache.org/jira/browse/OFBIZ-2644 > Project: OFBiz > Issue Type: Bug >Reporter: Harmeet Bedi >Priority: Trivial > Fix For: SVN trunk > > Attachments: EditCategoryFeatureCats.ftl.diff > > > use to be widespread earlier found this only in one spot in trunk. Attaching > patch. > is incorrect syntax > but > is right -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2644) syntax is incorrect
[
https://issues.apache.org/jira/browse/OFBIZ-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722678#action_12722678
]
Joe Eckard commented on OFBIZ-2644:
---
The following is considered valid XHTML according to: http://validator.w3.org/
{code:xml}
http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en">
Test
{code}
> syntax is incorrect
> --
>
> Key: OFBIZ-2644
> URL: https://issues.apache.org/jira/browse/OFBIZ-2644
> Project: OFBiz
> Issue Type: Bug
>Reporter: Harmeet Bedi
>Priority: Trivial
> Fix For: SVN trunk
>
> Attachments: EditCategoryFeatureCats.ftl.diff
>
>
> use to be widespread earlier found this only in one spot in trunk. Attaching
> patch.
> is incorrect syntax
> but
> is right
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1172) Order Entry unclear error when no ProductStore set
[
https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721405#action_12721405
]
Joe Eckard edited comment on OFBIZ-1172 at 6/18/09 11:42 AM:
-
Right now you will get a null pointer exception from
ProductStoreWorker.getStoreCurrencyUomId, which is called during cart creation.
However, if that is fixed it looks like the constructor for ShoppingCart
explicitly checks for a null productStoreId and throws an
IllegalArgumentException, so it won't make it much farther.
{code}
runtime exception report --
Problems Processing Event
Exception: java.lang.NullPointerException
Message: null
stack trace ---
java.lang.NullPointerException
org.ofbiz.product.store.ProductStoreWorker.getStoreCurrencyUomId(ProductStoreWorker.java:95)
org.ofbiz.order.shoppingcart.WebShoppingCart.(WebShoppingCart.java:44)
org.ofbiz.order.shoppingcart.ShoppingCartEvents.getCartObject(ShoppingCartEvents.java:821)
org.ofbiz.order.shoppingcart.ShoppingCartEvents.getCartObject(ShoppingCartEvents.java:840)
org.ofbiz.order.shoppingcart.ShoppingCartEvents.initializeOrderEntry(ShoppingCartEvents.java:1386)
{code}
was (Author: eckardjf):
Right now you will get a null pointer exception from
ProductStoreWorker.getStoreCurrencyUomId, which is called during cart creation.
However, if that is fixed it looks like the constructor for ShoppingCart
explicitly checks for a null productStoreId and throws an
IllegalArgumentException, so it won't make it much farther.
> Order Entry unclear error when no ProductStore set
> --
>
> Key: OFBIZ-1172
> URL: https://issues.apache.org/jira/browse/OFBIZ-1172
> Project: OFBiz
> Issue Type: Improvement
> Components: order
>Affects Versions: Release Branch 4.0, SVN trunk
>Reporter: Wickersheimer Jeremy
>Priority: Minor
> Attachments: ofbiz-1172.patch
>
>
> I ran into this issue because our staff accidentally removed the ProductStore
> from the OrderEntry Website. The symptom was an java NPE display when trying
> to create a Purchase Order.
> Because it took me some time to debug it i wrote a patch to make this
> behavior more obvious.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1172) Order Entry unclear error when no ProductStore set
[ https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721405#action_12721405 ] Joe Eckard commented on OFBIZ-1172: --- Right now you will get a null pointer exception from ProductStoreWorker.getStoreCurrencyUomId, which is called during cart creation. However, if that is fixed it looks like the constructor for ShoppingCart explicitly checks for a null productStoreId and throws an IllegalArgumentException, so it won't make it much farther. > Order Entry unclear error when no ProductStore set > -- > > Key: OFBIZ-1172 > URL: https://issues.apache.org/jira/browse/OFBIZ-1172 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 4.0, SVN trunk >Reporter: Wickersheimer Jeremy >Priority: Minor > Attachments: ofbiz-1172.patch > > > I ran into this issue because our staff accidentally removed the ProductStore > from the OrderEntry Website. The symptom was an java NPE display when trying > to create a Purchase Order. > Because it took me some time to debug it i wrote a patch to make this > behavior more obvious. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1172) Order Entry unclear error when no ProductStore set
[ https://issues.apache.org/jira/browse/OFBIZ-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721322#action_12721322 ] Joe Eckard commented on OFBIZ-1172: --- Back to the original issue... why is a ProductStore required when creating a PO? This bug is still present, and on the init screen there is no way to specify a productStoreId when creating a PO, the only way to set one is to set the productStoreId field on the "OrderEntry" WebSite entity. > Order Entry unclear error when no ProductStore set > -- > > Key: OFBIZ-1172 > URL: https://issues.apache.org/jira/browse/OFBIZ-1172 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Release Branch 4.0, SVN trunk >Reporter: Wickersheimer Jeremy >Priority: Minor > Attachments: ofbiz-1172.patch > > > I ran into this issue because our staff accidentally removed the ProductStore > from the OrderEntry Website. The symptom was an java NPE display when trying > to create a Purchase Order. > Because it took me some time to debug it i wrote a patch to make this > behavior more obvious. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2291) Clarify Non-Serialized Inventory Reservations / Add Flexibility
[ https://issues.apache.org/jira/browse/OFBIZ-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2291: -- Attachment: patch.txt > Clarify Non-Serialized Inventory Reservations / Add Flexibility > --- > > Key: OFBIZ-2291 > URL: https://issues.apache.org/jira/browse/OFBIZ-2291 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: patch.txt > > > Right now, reservations will only be made against a non-serialized inventory > item if the statusId field is null. This patch changes this behavior to check > for specific statuses that should exclude the inventory item, instead of > checking for a non-empty status. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2291) Clarify Non-Serialized Inventory Reservations / Add Flexibility
Clarify Non-Serialized Inventory Reservations / Add Flexibility --- Key: OFBIZ-2291 URL: https://issues.apache.org/jira/browse/OFBIZ-2291 Project: OFBiz Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Minor Fix For: SVN trunk Attachments: patch.txt Right now, reservations will only be made against a non-serialized inventory item if the statusId field is null. This patch changes this behavior to check for specific statuses that should exclude the inventory item, instead of checking for a non-empty status. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2237) Webtools Screen Definition Error
Webtools Screen Definition Error Key: OFBIZ-2237 URL: https://issues.apache.org/jira/browse/OFBIZ-2237 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Joe Eckard Fix For: SVN trunk Attachments: patch.txt -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2237) Webtools Screen Definition Error
[ https://issues.apache.org/jira/browse/OFBIZ-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2237: -- Attachment: patch.txt > Webtools Screen Definition Error > > > Key: OFBIZ-2237 > URL: https://issues.apache.org/jira/browse/OFBIZ-2237 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard > Fix For: SVN trunk > > Attachments: patch.txt > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644599#action_12644599 ] Joe Eckard commented on OFBIZ-1116: --- The actual issue has not been resolved, we just changed the default value to "false" so that the default config doesn't cause problems with Safari. If you change it back to "want" again, you'll see the error is still there. David's comment suggests he reopened the issue so that when a future Apple or Tomcat fix becomes available, we can resolve the issue and then close it. > Problem making SSL connection to admin apps with Safari > --- > > Key: OFBIZ-1116 > URL: https://issues.apache.org/jira/browse/OFBIZ-1116 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > > I can't seem to connect to any admin apps via SSL. The error message from > Safari is: > Safari can't open the page "https://localhost:8443/webtools/control/main"; > because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-2026) Add support for the groovyc ant task
[
https://issues.apache.org/jira/browse/OFBIZ-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644513#action_12644513
]
eckardjf edited comment on OFBIZ-2026 at 11/1/08 8:57 AM:
Oops, it was already there. So the groovyc class path & taskdef would look like:
{code:xml}
{code}
was (Author: eckardjf):
Oops, it was already there. So the groovyc class path & taskdef would look
like:
{xml}
{xml}
> Add support for the groovyc ant task
>
>
> Key: OFBIZ-2026
> URL: https://issues.apache.org/jira/browse/OFBIZ-2026
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Joe Eckard
>Priority: Minor
> Fix For: SVN trunk
>
>
> Add support for the groovyc ant task OOTB. This would allow compiling groovy
> classes that can be run using the standard JavaServiceEngine.
> example build.xml section:
> {code:xml}
> classpathref="local.class.path"/>
>
> classpathref="local.class.path"/>
>
> {code}
> OR, if you need to set additional javac options:
> {code:xml}
>
> classpathref="local.class.path">
>
>
>
> {code}
> OR
> {code:xml}
>
> classpathref="local.class.path">
>
>
>
>
>
> {code}
> all that is required for this is the addition of the commons-cli-1.0 jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2026) Add support for the groovyc ant task
[
https://issues.apache.org/jira/browse/OFBIZ-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Eckard closed OFBIZ-2026.
-
Resolution: Invalid
Oops, it was already there. So the groovyc class path & taskdef would look like:
{xml}
{xml}
> Add support for the groovyc ant task
>
>
> Key: OFBIZ-2026
> URL: https://issues.apache.org/jira/browse/OFBIZ-2026
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Joe Eckard
>Priority: Minor
> Fix For: SVN trunk
>
>
> Add support for the groovyc ant task OOTB. This would allow compiling groovy
> classes that can be run using the standard JavaServiceEngine.
> example build.xml section:
> {code:xml}
> classpathref="local.class.path"/>
>
> classpathref="local.class.path"/>
>
> {code}
> OR, if you need to set additional javac options:
> {code:xml}
>
> classpathref="local.class.path">
>
>
>
> {code}
> OR
> {code:xml}
>
> classpathref="local.class.path">
>
>
>
>
>
> {code}
> all that is required for this is the addition of the commons-cli-1.0 jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2023) Rename shipment package route segment field from trackingCode to trackingNumber
[ https://issues.apache.org/jira/browse/OFBIZ-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard closed OFBIZ-2023. - Resolution: Won't Fix > Rename shipment package route segment field from trackingCode to > trackingNumber > --- > > Key: OFBIZ-2023 > URL: https://issues.apache.org/jira/browse/OFBIZ-2023 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard > Fix For: SVN trunk > > Attachments: trackingNumberRename.patch > > > ShipmentPackageRouteSeg has a field called trackingCode which should really > be trackingNumber (see: OrderItemShipGroup & standard industry terminology). > The field name "trackingCode" is used in the marketing entities and code to > describe something completely different. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2026) Add support for the groovyc ant task
[
https://issues.apache.org/jira/browse/OFBIZ-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Eckard updated OFBIZ-2026:
--
Description:
Add support for the groovyc ant task OOTB. This would allow compiling groovy
classes that can be run using the standard JavaServiceEngine.
example build.xml section:
{code:xml}
{code}
OR, if you need to set additional javac options:
{code:xml}
{code}
OR
{code:xml}
{code}
all that is required for this is the addition of the commons-cli-1.0 jar.
was:
Add support for the groovyc ant task OOTB. This would allow compiling groovy
classes that can be run using the standard JavaServiceEngine.
example build.xml section:
OR, if you need to set additional javac options:
OR
all that is required for this is the addition of the commons-cli-1.0 jar.
added xml formatting
> Add support for the groovyc ant task
>
>
> Key: OFBIZ-2026
> URL: https://issues.apache.org/jira/browse/OFBIZ-2026
> Project: OFBiz
> Issue Type: New Feature
> Components: ALL COMPONENTS
>Affects Versions: SVN trunk
>Reporter: Joe Eckard
>Priority: Minor
> Fix For: SVN trunk
>
>
> Add support for the groovyc ant task OOTB. This would allow compiling groovy
> classes that can be run using the standard JavaServiceEngine.
> example build.xml section:
> {code:xml}
> classpathref="local.class.path"/>
>
> classpathref="local.class.path"/>
>
> {code}
> OR, if you need to set additional javac options:
> {code:xml}
>
> classpathref="local.class.path">
>
>
>
> {code}
> OR
> {code:xml}
>
> classpathref="local.class.path">
>
>
>
>
>
> {code}
> all that is required for this is the addition of the commons-cli-1.0 jar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2026) Add support for the groovyc ant task
Add support for the groovyc ant task Key: OFBIZ-2026 URL: https://issues.apache.org/jira/browse/OFBIZ-2026 Project: OFBiz Issue Type: New Feature Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Minor Fix For: SVN trunk Add support for the groovyc ant task OOTB. This would allow compiling groovy classes that can be run using the standard JavaServiceEngine. example build.xml section: OR, if you need to set additional javac options: OR all that is required for this is the addition of the commons-cli-1.0 jar. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2006) Add a signature required indicator to OrderItemShipGroup
[ https://issues.apache.org/jira/browse/OFBIZ-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642822#action_12642822 ] Joe Eckard commented on OFBIZ-2006: --- I'm not sure where this information is coming from, but UPS does indeed offer delivery confirmation (no signature), delivery confirmation (signature required), and delivery confirmation (adult signature required) to residential addresses. You can even get a verbal confirmation. USPS also does delivery confirmation and signature confirmation. Instead of a few flags, I think we need a new delivery option entity, since each option (delivery confirmation, early AM delivery, saturday delivery, etc.) changes the carrier service code (and may add an additional charge), even though it is still considered to be the original shipment method type. These could be added as shipment attributes, but we need some way to tie them to the ship group so they can be specified in the order manager. I'll submit a patch when I have it worked out. > Add a signature required indicator to OrderItemShipGroup > > > Key: OFBIZ-2006 > URL: https://issues.apache.org/jira/browse/OFBIZ-2006 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > > I propose we add an indicator "signatureRequired" to OrderItemShipGroup. For > example, this could be used for UPS shipments where Y = Signature required, A > = Adult Signature Required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2006) Add a signature required indicator to OrderItemShipGroup
[ https://issues.apache.org/jira/browse/OFBIZ-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard closed OFBIZ-2006. - Resolution: Won't Fix Assignee: Joe Eckard There is a better way to do this, testing a solution with a new entity CarrierShipmentMethodOption - will create a new issue. > Add a signature required indicator to OrderItemShipGroup > > > Key: OFBIZ-2006 > URL: https://issues.apache.org/jira/browse/OFBIZ-2006 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > > I propose we add an indicator "signatureRequired" to OrderItemShipGroup. For > example, this could be used for UPS shipments where Y = Signature required, A > = Adult Signature Required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2023) Rename shipment package route segment field from trackingCode to trackingNumber
[ https://issues.apache.org/jira/browse/OFBIZ-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard reassigned OFBIZ-2023: - Assignee: Joe Eckard > Rename shipment package route segment field from trackingCode to > trackingNumber > --- > > Key: OFBIZ-2023 > URL: https://issues.apache.org/jira/browse/OFBIZ-2023 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Joe Eckard > Fix For: SVN trunk > > Attachments: trackingNumberRename.patch > > > ShipmentPackageRouteSeg has a field called trackingCode which should really > be trackingNumber (see: OrderItemShipGroup & standard industry terminology). > The field name "trackingCode" is used in the marketing entities and code to > describe something completely different. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2023) Rename shipment package route segment field from trackingCode to trackingNumber
[ https://issues.apache.org/jira/browse/OFBIZ-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-2023: -- Attachment: trackingNumberRename.patch > Rename shipment package route segment field from trackingCode to > trackingNumber > --- > > Key: OFBIZ-2023 > URL: https://issues.apache.org/jira/browse/OFBIZ-2023 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: SVN trunk >Reporter: Joe Eckard > Fix For: SVN trunk > > Attachments: trackingNumberRename.patch > > > ShipmentPackageRouteSeg has a field called trackingCode which should really > be trackingNumber (see: OrderItemShipGroup & standard industry terminology). > The field name "trackingCode" is used in the marketing entities and code to > describe something completely different. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2023) Rename shipment package route segment field from trackingCode to trackingNumber
Rename shipment package route segment field from trackingCode to trackingNumber --- Key: OFBIZ-2023 URL: https://issues.apache.org/jira/browse/OFBIZ-2023 Project: OFBiz Issue Type: Improvement Components: ALL COMPONENTS Affects Versions: SVN trunk Reporter: Joe Eckard Fix For: SVN trunk Attachments: trackingNumberRename.patch ShipmentPackageRouteSeg has a field called trackingCode which should really be trackingNumber (see: OrderItemShipGroup & standard industry terminology). The field name "trackingCode" is used in the marketing entities and code to describe something completely different. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1979) Groovy & Beanshell Service Engines do not provide DispatchContext to scripts
[ https://issues.apache.org/jira/browse/OFBIZ-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642165#action_12642165 ] Joe Eckard commented on OFBIZ-1979: --- I do not have commit access to /framework, but I've been using this in production for a few weeks with no problems. > Groovy & Beanshell Service Engines do not provide DispatchContext to scripts > > > Key: OFBIZ-1979 > URL: https://issues.apache.org/jira/browse/OFBIZ-1979 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: patch.txt > > > Groovy & Beanshell Service Engines do not provide DispatchContext to scripts, > which is used to get a delegator & dispatcher. The attached patch addresses > this, however I may have overlooked another way to get a delegator & > dispatcher so this patch may not be necessary. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-2006) Add a signature required indicator to OrderItemShipGroup
Add a signature required indicator to OrderItemShipGroup Key: OFBIZ-2006 URL: https://issues.apache.org/jira/browse/OFBIZ-2006 Project: OFBiz Issue Type: Improvement Components: order Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Minor Fix For: SVN trunk I propose we add an indicator "signatureRequired" to OrderItemShipGroup. For example, this could be used for UPS shipments where Y = Signature required, A = Adult Signature Required. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-988) Incorrect default FOP font-base URL
[ https://issues.apache.org/jira/browse/OFBIZ-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637573#action_12637573 ] eckardjf edited comment on OFBIZ-988 at 10/7/08 11:12 AM: What issue was this patch intended to fix? On my system, this creates a bug by adding an extra "/" to the URI, making it invalid. e.g: FOP-FontBaseURL: file:Users/eckard/src/ofbiz-rr/framework/webapp/config/ (wrong) instead of FOP-FontBaseURL: file:///Users/eckard/src/ofbiz-rr/framework/webapp/config/ (correct) also, a few other questions: 1. Why are we constructing the default URI this way? If we're on a windows machine, ofbiz.home may have backslashes 2. Why are we making the default font location framework/webapp/config? Why not create a new fonts directory? 3. Why is the fop config filename hardcoded? 4. Where is the fop.properties file? There doesn't appear to be one in the project with default values & comments. (will submit patch when time permits, just wanted to re-open so it doesn't get missed) was (Author: eckardjf): What issue was this patch intended to fix? On my system, this creates a bug by adding an extra "/" to the URI, making it invalid. e.g: FOP-FontBaseURL: file:Users/eckard/src/ofbiz-rr/framework/webapp/config/ (wrong) instead of FOP-FontBaseURL: file:///Users/eckard/src/ofbiz-rr/framework/webapp/config/ (correct) also, a few other questions: 1. Why are we constructing the default URI this way? If we're on a windows machine, ofbiz.home may have backslashes 2. Why are we making the default font location framework/webapp/config? Why not create a new fonts directory? 3. Why is the fop config filename hardcoded? 4. Where is the fop.properties file? There doesn't appear to be one in the project with default values & comments. > Incorrect default FOP font-base URL > --- > > Key: OFBIZ-988 > URL: https://issues.apache.org/jira/browse/OFBIZ-988 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk, Release Branch 4.0 >Reporter: Oleg Andreyev >Assignee: Hans Bakker >Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: webapp.diff > > > Attached patch fix this problem -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-988) Incorrect default FOP font-base URL
[ https://issues.apache.org/jira/browse/OFBIZ-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard reopened OFBIZ-988: -- What issue was this patch intended to fix? On my system, this creates a bug by adding an extra "/" to the URI, making it invalid. e.g: FOP-FontBaseURL: file:Users/eckard/src/ofbiz-rr/framework/webapp/config/ (wrong) instead of FOP-FontBaseURL: file:///Users/eckard/src/ofbiz-rr/framework/webapp/config/ (correct) also, a few other questions: 1. Why are we constructing the default URI this way? If we're on a windows machine, ofbiz.home may have backslashes 2. Why are we making the default font location framework/webapp/config? Why not create a new fonts directory? 3. Why is the fop config filename hardcoded? 4. Where is the fop.properties file? There doesn't appear to be one in the project with default values & comments. > Incorrect default FOP font-base URL > --- > > Key: OFBIZ-988 > URL: https://issues.apache.org/jira/browse/OFBIZ-988 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk, Release Branch 4.0 >Reporter: Oleg Andreyev >Assignee: Hans Bakker >Priority: Minor > Fix For: SVN trunk, Release Branch 4.0 > > Attachments: webapp.diff > > > Attached patch fix this problem -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1980) CrossSubdomainSessionValve for Tomcat
[ https://issues.apache.org/jira/browse/OFBIZ-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636747#action_12636747 ] Joe Eckard commented on OFBIZ-1980: --- I see - my mistake. I use the jetty container (which has support for this) and assumed Tomcat would work the same way. > CrossSubdomainSessionValve for Tomcat > - > > Key: OFBIZ-1980 > URL: https://issues.apache.org/jira/browse/OFBIZ-1980 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Mridul Pathak > Fix For: SVN trunk > > Attachments: CrossSubdomainSessionValve.patch > > > Different session is create if user moves from one subdomain to another one > for the same host. For example if someone moves from web.localdomain to > secure.localdomain or vice versa a new seesion is created and session > attributes are different on different subdomains. The session attributes > available in previous subdomain are not available to the new subdomain. The > patch provided fix this problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1980) CrossSubdomainSessionValve for Tomcat
[ https://issues.apache.org/jira/browse/OFBIZ-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636724#action_12636724 ] Joe Eckard commented on OFBIZ-1980: --- Can't you solve this problem by setting the session cookie domain to ".somewebsite.com"? That would cover "www.somewebsite.com", "secure.somewebsite.com". etc. > CrossSubdomainSessionValve for Tomcat > - > > Key: OFBIZ-1980 > URL: https://issues.apache.org/jira/browse/OFBIZ-1980 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Mridul Pathak > Fix For: SVN trunk > > Attachments: CrossSubdomainSessionValve.patch > > > Different session is create if user moves from one subdomain to another one > for the same host. For example if someone moves from web.localdomain to > secure.localdomain or vice versa a new seesion is created and session > attributes are different on different subdomains. The session attributes > available in previous subdomain are not available to the new subdomain. The > patch provided fix this problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1979) Groovy & Beanshell Service Engines do not provide DispatchContext to scripts
Groovy & Beanshell Service Engines do not provide DispatchContext to scripts Key: OFBIZ-1979 URL: https://issues.apache.org/jira/browse/OFBIZ-1979 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Minor Fix For: SVN trunk Attachments: patch.txt Groovy & Beanshell Service Engines do not provide DispatchContext to scripts, which is used to get a delegator & dispatcher. The attached patch addresses this, however I may have overlooked another way to get a delegator & dispatcher so this patch may not be necessary. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1979) Groovy & Beanshell Service Engines do not provide DispatchContext to scripts
[ https://issues.apache.org/jira/browse/OFBIZ-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1979: -- Attachment: patch.txt > Groovy & Beanshell Service Engines do not provide DispatchContext to scripts > > > Key: OFBIZ-1979 > URL: https://issues.apache.org/jira/browse/OFBIZ-1979 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: patch.txt > > > Groovy & Beanshell Service Engines do not provide DispatchContext to scripts, > which is used to get a delegator & dispatcher. The attached patch addresses > this, however I may have overlooked another way to get a delegator & > dispatcher so this patch may not be necessary. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1791: -- Attachment: jetty20080702.patch Here is a complete patch against the latest SVN > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty-tmp.patch, jetty.patch, jetty20080702.patch, > utilj2eecompat.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606793#action_12606793 ] Joe Eckard commented on OFBIZ-1791: --- Yes, you could just switch "Jetty" to "jetty" - I was just attempting to make the code more tolerant of changing product names in the future by lowercasing everything before comparing strings. > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch, utilj2eecompat.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605627#action_12605627 ] Joe Eckard commented on OFBIZ-1791: --- 1) Correct. All of the jars are included in the jetty distribution except for slf4j-log4j12-1.3.1.jar, which you need to get from the slf4j project. (I had problem with the newest slf4j, but 1.3.1 works great) 3) The problem is that jetty now reports itself as "jetty" instead of "Jetty" - the minimum required change would be that one line and also the static strings at the beginning of the file. 4) Yes, that was in the first patch - you can disregard that. > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Assignee: Jacopo Cappellato >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch, utilj2eecompat.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-930) Nicer mini calendars
[ https://issues.apache.org/jira/browse/OFBIZ-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard closed OFBIZ-930. Resolution: Won't Fix > Nicer mini calendars > > > Key: OFBIZ-930 > URL: https://issues.apache.org/jira/browse/OFBIZ-930 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Trivial > Fix For: SVN trunk > > Attachments: calendar.patch, firefox.gif, safari.gif > > > I've been using this mini calendar for a long time now, thought I would send > it in. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1791: -- Attachment: jetty.patch New patch with "want" and "need" settings for SSL client auth. > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch, utilj2eecompat.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1791: -- Attachment: (was: jetty.patch) > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch, utilj2eecompat.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1791: -- Attachment: utilj2eecompat.patch > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch, utilj2eecompat.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596533#action_12596533 ] Joe Eckard commented on OFBIZ-1791: --- Also, the jetty identifier string in UtilJ2eeCompat will need to be changed from "Jetty" to "jetty" since it reports in lowercase now. > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596439#action_12596439 ] eckardjf edited comment on OFBIZ-1791 at 5/13/08 9:58 AM: This patch includes the new JettyContainer and configuration. It shouldn't be committed as-is, since it removes the catalina config and makes jetty the default, but it can be used to test the updated container. The newer SSL certificate handling features in the catalina container aren't supported yet, but persistent sessions are, along with new NIO listeners. was (Author: eckardjf): This patch includes the new JettyContainer and configuration. It shouldn't be committed as-is, since it removes the catalina config and makes jetty the default, but it can be used to test the updated container. The newer SSL certificate handling in the catalina container aren't supported yet, but persistent sessions are, along with new NIO listeners. > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596441#action_12596441 ] Joe Eckard commented on OFBIZ-1791: --- In addition to this patch, you will also need to replace the jars in framework/jetty/lib with the following jars included the jetty 6.1.x distribution: ant-1.6.5.jar jasper-compiler-5.5.15.jar jasper-compiler-jdt-5.5.15.jar jasper-runtime-5.5.15.jar jcl104-over-slf4j-1.3.1.jar jetty-6.1.9.jar jetty-ajp-6.1.9.jar jetty-sslengine-6.1.9.jar jetty-util-6.1.9.jar slf4j-api-1.3.1.jar xmlParserAPIs-2.6.2.jar and also the following jar which tells jetty to use log4j: slf4j-log4j12-1.3.1.jar > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1791) Update Jetty Container to use Jetty 6
[ https://issues.apache.org/jira/browse/OFBIZ-1791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1791: -- Attachment: jetty.patch This patch includes the new JettyContainer and configuration. It shouldn't be committed as-is, since it removes the catalina config and makes jetty the default, but it can be used to test the updated container. The newer SSL certificate handling in the catalina container aren't supported yet, but persistent sessions are, along with new NIO listeners. > Update Jetty Container to use Jetty 6 > - > > Key: OFBIZ-1791 > URL: https://issues.apache.org/jira/browse/OFBIZ-1791 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: jetty.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1791) Update Jetty Container to use Jetty 6
Update Jetty Container to use Jetty 6 - Key: OFBIZ-1791 URL: https://issues.apache.org/jira/browse/OFBIZ-1791 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Minor Fix For: SVN trunk -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1779) Support for Groovy Screen Widget Actions
[ https://issues.apache.org/jira/browse/OFBIZ-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1779: -- Attachment: EditProductFeatures.groovy An example of a beanshell script converted to groovy. This is a drop in replacement for: applications/product/webapp/catalog/WEB-INF/actions/product/EditProductFeatures.bsh > Support for Groovy Screen Widget Actions > > > Key: OFBIZ-1779 > URL: https://issues.apache.org/jira/browse/OFBIZ-1779 > Project: OFBiz > Issue Type: New Feature > Components: content, framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Trivial > Fix For: SVN trunk > > Attachments: EditProductFeatures.groovy, groovy.patch > > > Add support for running groovy scripts as screen widget actions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1779) Support for Groovy Screen Widget Actions
[ https://issues.apache.org/jira/browse/OFBIZ-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1779: -- Attachment: groovy.patch new feature patch > Support for Groovy Screen Widget Actions > > > Key: OFBIZ-1779 > URL: https://issues.apache.org/jira/browse/OFBIZ-1779 > Project: OFBiz > Issue Type: New Feature > Components: content, framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Trivial > Fix For: SVN trunk > > Attachments: groovy.patch > > > Add support for running groovy scripts as screen widget actions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1779) Support for Groovy Screen Widget Actions
Support for Groovy Screen Widget Actions Key: OFBIZ-1779 URL: https://issues.apache.org/jira/browse/OFBIZ-1779 Project: OFBiz Issue Type: New Feature Components: content, framework Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Trivial Fix For: SVN trunk Attachments: groovy.patch Add support for running groovy scripts as screen widget actions. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553380 ] Joe Eckard commented on OFBIZ-1116: --- I just tried adding framework/base/cert/demoCA/cacert.pem to my X509Anchors keychain, but I get the same error. (Safari can't open the page "https://localhost:8443/webtools/control/scheduleJob"; because it couldn't establish a secure connection to the server "localhost".) > Problem making SSL connection to admin apps with Safari > --- > > Key: OFBIZ-1116 > URL: https://issues.apache.org/jira/browse/OFBIZ-1116 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > > I can't seem to connect to any admin apps via SSL. The error message from > Safari is: > Safari can't open the page "https://localhost:8443/webtools/control/main"; > because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552451 ] Joe Eckard commented on OFBIZ-1116: --- Technically no, it is not an OFBiz bug, but having a default configuration that is broken in current versions of Safari seems like bad form to me. I would rather see client auth disabled by default or at least there should be a warning in the readme / setup doc / config file. > Problem making SSL connection to admin apps with Safari > --- > > Key: OFBIZ-1116 > URL: https://issues.apache.org/jira/browse/OFBIZ-1116 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > > I can't seem to connect to any admin apps via SSL. The error message from > Safari is: > Safari can't open the page "https://localhost:8443/webtools/control/main"; > because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1514) Duplicates in Search Results
[ https://issues.apache.org/jira/browse/OFBIZ-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1514: -- Attachment: keywords.xml > Duplicates in Search Results > > > Key: OFBIZ-1514 > URL: https://issues.apache.org/jira/browse/OFBIZ-1514 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Attachments: keywords.xml, patch.txt > > > If a product has multiple keywords with identical roots and different > relevancy weights and the product is within a set of search results that span > multiple pages, then it will be duplicated in the results display. This is > because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) > instead of grouping by the productId. (And the attempt at duplicate removal > only happens on a page-by-page basis.) > I'm attaching a small proof-of-concept patch to make grouping by productId > the default - it appears to work well with various combinations of search > criteria (multiple keywords, features, feature cats, categories, etc.) but I > haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) > From the comments in the ProductSearch code it looks like it was done this > way once, but it may have caused problems with Oracle. Does anyone know what > that problem was, or can anyone check this patch against oracle? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1514) Duplicates in Search Results
[ https://issues.apache.org/jira/browse/OFBIZ-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552252 ] Joe Eckard commented on OFBIZ-1514: --- I believe I used "1" - it just has to be different than the relevancy weight for the keyword "gizmo". Be sure to set your view size to 10 - this only occurs if the product is returned multiple times and on different pages, as each page of results is filtered for duplicates. I'm attaching a seed data file that adds "gizmotron" to all of the gizmos for easier testing - drop this in after a clean install and keyword generation. > Duplicates in Search Results > > > Key: OFBIZ-1514 > URL: https://issues.apache.org/jira/browse/OFBIZ-1514 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Attachments: patch.txt > > > If a product has multiple keywords with identical roots and different > relevancy weights and the product is within a set of search results that span > multiple pages, then it will be duplicated in the results display. This is > because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) > instead of grouping by the productId. (And the attempt at duplicate removal > only happens on a page-by-page basis.) > I'm attaching a small proof-of-concept patch to make grouping by productId > the default - it appears to work well with various combinations of search > criteria (multiple keywords, features, feature cats, categories, etc.) but I > haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) > From the comments in the ProductSearch code it looks like it was done this > way once, but it may have caused problems with Oracle. Does anyone know what > that problem was, or can anyone check this patch against oracle? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1514) Duplicates in Search Results
[ https://issues.apache.org/jira/browse/OFBIZ-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1514: -- Description: If a product has multiple keywords with identical roots and different relevancy weights and the product is within a set of search results that span multiple pages, then it will be duplicated in the results display. This is because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) instead of grouping by the productId. (And the attempt at duplicate removal only happens on a page-by-page basis.) I'm attaching a small proof-of-concept patch to make grouping by productId the default - it appears to work well with various combinations of search criteria (multiple keywords, features, feature cats, categories, etc.) but I haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) >From the comments in the ProductSearch code it looks like it was done this way >once, but it may have caused problems with Oracle. Does anyone know what that >problem was, or can anyone check this patch against oracle? was: If a product has multiple keywords with identical roots and different relevancy weights and the product is within a set of search results that span multiple pages, then it will be duplicated in the results display. This is because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) instead of grouping by the productId. I'm attaching a small proof-of-concept patch to make grouping by productId the default - it appears to work well with various combinations of search criteria (multiple keywords, features, feature cats, categories, etc.) but I haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) >From the comments in the ProductSearch code it looks like it was done this way >once, but it may have caused problems with Oracle. Does anyone know what that >problem was, or can anyone check this patch against oracle? > Duplicates in Search Results > > > Key: OFBIZ-1514 > URL: https://issues.apache.org/jira/browse/OFBIZ-1514 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Attachments: patch.txt > > > If a product has multiple keywords with identical roots and different > relevancy weights and the product is within a set of search results that span > multiple pages, then it will be duplicated in the results display. This is > because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) > instead of grouping by the productId. (And the attempt at duplicate removal > only happens on a page-by-page basis.) > I'm attaching a small proof-of-concept patch to make grouping by productId > the default - it appears to work well with various combinations of search > criteria (multiple keywords, features, feature cats, categories, etc.) but I > haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) > From the comments in the ProductSearch code it looks like it was done this > way once, but it may have caused problems with Oracle. Does anyone know what > that problem was, or can anyone check this patch against oracle? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1514) Duplicates in Search Results
[ https://issues.apache.org/jira/browse/OFBIZ-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-1514: -- Attachment: patch.txt > Duplicates in Search Results > > > Key: OFBIZ-1514 > URL: https://issues.apache.org/jira/browse/OFBIZ-1514 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > Attachments: patch.txt > > > If a product has multiple keywords with identical roots and different > relevancy weights and the product is within a set of search results that span > multiple pages, then it will be duplicated in the results display. This is > because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) > instead of grouping by the productId. > I'm attaching a small proof-of-concept patch to make grouping by productId > the default - it appears to work well with various combinations of search > criteria (multiple keywords, features, feature cats, categories, etc.) but I > haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) > From the comments in the ProductSearch code it looks like it was done this > way once, but it may have caused problems with Oracle. Does anyone know what > that problem was, or can anyone check this patch against oracle? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1514) Duplicates in Search Results
[ https://issues.apache.org/jira/browse/OFBIZ-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550726 ] Joe Eckard commented on OFBIZ-1514: --- To reproduce this from a clean checkout: Load demo data, create keywords for all products. In the catalog manager, do a keyword search for "gizmos" with a VIEW_SIZE parameter of 10. You should see "1-10 of 19". Then manually add the keyword "gizmotron" to Big Gizmo (GZ-8544). Do the same search again and you should see "1-10 of 20". > Duplicates in Search Results > > > Key: OFBIZ-1514 > URL: https://issues.apache.org/jira/browse/OFBIZ-1514 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Minor > > If a product has multiple keywords with identical roots and different > relevancy weights and the product is within a set of search results that span > multiple pages, then it will be duplicated in the results display. This is > because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) > instead of grouping by the productId. > I'm attaching a small proof-of-concept patch to make grouping by productId > the default - it appears to work well with various combinations of search > criteria (multiple keywords, features, feature cats, categories, etc.) but I > haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) > From the comments in the ProductSearch code it looks like it was done this > way once, but it may have caused problems with Oracle. Does anyone know what > that problem was, or can anyone check this patch against oracle? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1514) Duplicates in Search Results
Duplicates in Search Results Key: OFBIZ-1514 URL: https://issues.apache.org/jira/browse/OFBIZ-1514 Project: OFBiz Issue Type: Bug Components: product Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Minor If a product has multiple keywords with identical roots and different relevancy weights and the product is within a set of search results that span multiple pages, then it will be duplicated in the results display. This is because ProductSearch is doing a "distinct" on productId, relevancyWeight(s) instead of grouping by the productId. I'm attaching a small proof-of-concept patch to make grouping by productId the default - it appears to work well with various combinations of search criteria (multiple keywords, features, feature cats, categories, etc.) but I haven't done a tremendous amount of testing. (Only using PostgreSQL and Derby) >From the comments in the ProductSearch code it looks like it was done this way >once, but it may have caused problems with Oracle. Does anyone know what that >problem was, or can anyone check this patch against oracle? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1431) StringUtil.htmlSpecialChars: ampersand replaced with "&s;" instead of "&"
[ https://issues.apache.org/jira/browse/OFBIZ-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard reassigned OFBIZ-1431: - Assignee: (was: Joe Eckard) > StringUtil.htmlSpecialChars: ampersand replaced with "&s;" instead of > "&" > - > > Key: OFBIZ-1431 > URL: https://issues.apache.org/jira/browse/OFBIZ-1431 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: not relevant >Reporter: Michael Brohl >Priority: Minor > Fix For: SVN trunk > > Attachments: StringUtil.java.patch > > > See description in the subject. A diff follows. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1431) StringUtil.htmlSpecialChars: ampersand replaced with "&s;" instead of "&"
[ https://issues.apache.org/jira/browse/OFBIZ-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard reassigned OFBIZ-1431: - Assignee: Joe Eckard > StringUtil.htmlSpecialChars: ampersand replaced with "&s;" instead of > "&" > - > > Key: OFBIZ-1431 > URL: https://issues.apache.org/jira/browse/OFBIZ-1431 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk > Environment: not relevant >Reporter: Michael Brohl >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: StringUtil.java.patch > > > See description in the subject. A diff follows. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1293) start the listener thread earlier
[ https://issues.apache.org/jira/browse/OFBIZ-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532442 ] Joe Eckard commented on OFBIZ-1293: --- Tested in production. > start the listener thread earlier > - > > Key: OFBIZ-1293 > URL: https://issues.apache.org/jira/browse/OFBIZ-1293 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: SVN trunk >Reporter: Adam Heath >Priority: Minor > Fix For: SVN trunk > > Attachments: StartListenerThreadEarlier.patch > > > If ofbiz is started in the background, and an external program is querying > the status, to see if ofbiz has finished starting up, then the listener > thread needs to be started earlier, so that a connection refused error > doesn't occur. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1282) sending a socket command always prints a null response
[ https://issues.apache.org/jira/browse/OFBIZ-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532314 ] Joe Eckard commented on OFBIZ-1282: --- Tested in production - seems harmless. No more "Shutting down server : null" messages. > sending a socket command always prints a null response > -- > > Key: OFBIZ-1282 > URL: https://issues.apache.org/jira/browse/OFBIZ-1282 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: SVN trunk >Reporter: Adam Heath >Priority: Trivial > Fix For: SVN trunk > > Attachments: FixStartStatusNull.patch > > > After sending a socket command, the code doesn't correctly fetch a response, > and always prints null. The attached patch fixes this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1240) Small errors in HTML generation in receiveInventory.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard closed OFBIZ-1240. - > Small errors in HTML generation in receiveInventory.ftl > --- > > Key: OFBIZ-1240 > URL: https://issues.apache.org/jira/browse/OFBIZ-1240 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Christian Geisert >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: patch_ofbiz_receiveInventory.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OFBIZ-1240) Small errors in HTML generation in receiveInventory.ftl
[ https://issues.apache.org/jira/browse/OFBIZ-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard resolved OFBIZ-1240. --- Resolution: Fixed Assignee: Joe Eckard > Small errors in HTML generation in receiveInventory.ftl > --- > > Key: OFBIZ-1240 > URL: https://issues.apache.org/jira/browse/OFBIZ-1240 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: SVN trunk >Reporter: Christian Geisert >Assignee: Joe Eckard >Priority: Minor > Fix For: SVN trunk > > Attachments: patch_ofbiz_receiveInventory.diff > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510379 ] Joe Eckard commented on OFBIZ-1116: --- For what its worth, this has something to do with SSL client authentication - if you disable it completely (change clientAuth to "false" instead of "want" in the catalina https connector config) then Safari will connect with no problems. > Problem making SSL connection to admin apps with Safari > --- > > Key: OFBIZ-1116 > URL: https://issues.apache.org/jira/browse/OFBIZ-1116 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk >Reporter: Joe Eckard > > I can't seem to connect to any admin apps via SSL. The error message from > Safari is: > Safari can't open the page "https://localhost:8443/webtools/control/main"; > because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
[ https://issues.apache.org/jira/browse/OFBIZ-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509678 ] Joe Eckard commented on OFBIZ-1116: --- I noticed this some time ago also, I was just hoping it would get fixed. I'm not using the 3.0 beta, from Safari:About, I'm using Version 2.0.4 (419.3). > Problem making SSL connection to admin apps with Safari > --- > > Key: OFBIZ-1116 > URL: https://issues.apache.org/jira/browse/OFBIZ-1116 > Project: OFBiz > Issue Type: Bug >Affects Versions: SVN trunk >Reporter: Joe Eckard >Priority: Blocker > > I can't seem to connect to any admin apps via SSL. The error message from > Safari is: > Safari can't open the page "https://localhost:8443/webtools/control/main"; > because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-1116) Problem making SSL connection to admin apps with Safari
Problem making SSL connection to admin apps with Safari --- Key: OFBIZ-1116 URL: https://issues.apache.org/jira/browse/OFBIZ-1116 Project: OFBiz Issue Type: Bug Affects Versions: SVN trunk Reporter: Joe Eckard Priority: Blocker I can't seem to connect to any admin apps via SSL. The error message from Safari is: Safari can't open the page "https://localhost:8443/webtools/control/main"; because it couldn't establish a secure connection to the server "localhost". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-952) Updated processExtendSubscription* to use the new fromInventoryItem field
[ https://issues.apache.org/jira/browse/OFBIZ-952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Eckard updated OFBIZ-952: - Attachment: subscriptions.patch > Updated processExtendSubscription* to use the new fromInventoryItem field > - > > Key: OFBIZ-952 > URL: https://issues.apache.org/jira/browse/OFBIZ-952 > Project: OFBiz (The Open for Business Project) > Issue Type: Improvement > Components: product >Affects Versions: SVN trunk >Reporter: Joe Eckard > Assigned To: Andrew Zeneski >Priority: Trivial > Fix For: SVN trunk > > Attachments: subscriptions.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (OFBIZ-952) Updated processExtendSubscription* to use the new fromInventoryItem field
Updated processExtendSubscription* to use the new fromInventoryItem field - Key: OFBIZ-952 URL: https://issues.apache.org/jira/browse/OFBIZ-952 Project: OFBiz (The Open for Business Project) Issue Type: Improvement Components: product Affects Versions: SVN trunk Reporter: Joe Eckard Assigned To: Andrew Zeneski Priority: Trivial Fix For: SVN trunk -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
