Re: varchar(255) in fieldtypepostgres.xml
Hi All, d...@dlsemc.com has suggested a good solution at OFBIZ-12021. I'll apply it in a week if nobody is against. Thanks Jacques Le 10/08/2020 à 20:30, Development a écrit : In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: In postgres, using "VARCHAR(255)" saves no space in the database over using "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 slows it down with error checking. Is there any reason on the ofbiz side to not just change this to plain "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 characters of it or something? Obviously I can do this for my own installation. I'm asking here cause it feels like something that should be pushed upstream. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
Re: JIRA issue 12021 created for: RE: varchar(255) in fieldtypepostgres.xml
Thanks, We can continue the discussion there. I agree with Paul there that it's a good idea. I see no problem with that, we just have to check that all DBMS settings are OK. Jacques Le 23/09/2020 à 00:04, Development a écrit : I guess I'm supposed to annnounce here that I created the JIRA issue... I've created a JIRA issue: https://issues.apache.org/jira/browse/OFBIZ-12021 Basically the fields "comment" and "description" are limited to 255 char. (note: most tables have a short name field that is seperate from the description field). I know I do, and I would imagine people could easily go over 255 char when writing things like a comment or description about something. I put a proposed fix in the JIRA issue. From: Jacques Le Roux [jacques.le.r...@les7arts.com] Sent: Tuesday, September 22, 2020 4:09 AM To: Development Cc: dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi, Since this is more an OFBiz development (improvement) than its usage, I recommend to create a Jira issue https://issues.apache.org/jira/projects/OFBIZ/summary And to refer to it from the dev ML https://ofbiz.apache.org/mailing-lists.html (please subscribe before if not done already) We need to discuss with the community. It would be a pity to work on it and get rebuffed by the community. I start by copying your message to the dev ML... TIA Jacques Le 20/09/2020 à 22:25, Development a écrit : :) No problem. Obviously, i don't always respond to email right away either :) Since this email is long, I figured I should send it to you direct instead of sending it to the list. Anyway, this is what I was thinking: diff --git a/framework/entity/fieldtype/fieldtypeadvantage.xml b/framework/entity/fieldtype/fieldtypeadvantage.xml index 9f81c3ec42..c7fd6910fa 100644 --- a/framework/entity/fieldtype/fieldtypeadvantage.xml +++ b/framework/entity/fieldtype/fieldtypeadvantage.xml @@ -50,8 +50,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypeaxion.xml b/framework/entity/fieldtype/fieldtypeaxion.xml index 2ce5f3b13e..bc9cd405f8 100644 --- a/framework/entity/fieldtype/fieldtypeaxion.xml +++ b/framework/entity/fieldtype/fieldtypeaxion.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypedaffodil.xml b/framework/entity/fieldtype/fieldtypedaffodil.xml index 8abda563f6..5a43a1e44b 100644 --- a/framework/entity/fieldtype/fieldtypedaffodil.xml +++ b/framework/entity/fieldtype/fieldtypedaffodil.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypederby.xml b/framework/entity/fieldtype/fieldtypederby.xml index 80d2cfed14..d7aa9f7e45 100644 --- a/framework/entity/fieldtype/fieldtypederby.xml +++ b/framework/entity/fieldtype/fieldtypederby.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypefirebird.xml b/framework/entity/fieldtype/fieldtypefirebird.xml index d449c1c4a9..191ef84c22 100644 --- a/framework/entity/fieldtype/fieldtypefirebird.xml +++ b/framework/entity/fieldtype/fieldtypefirebird.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypehsql.xml b/framework/entity/fieldtype/fieldtypehsql.xml index fe96fff90a..3c72490ac9 100644 --- a/framework/entity/fieldtype/fieldtypehsql.xml +++ b/framework/entity/fieldtype/fieldtypehsql.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypemssql.xml b/framework/entity/fieldtype/fieldtypemssql.xml index 25e2d05199..88a69be1ef 100644 --- a/framework/entity/fieldtype/fieldtypemssql.xml +++ b/framework/entity/fieldtype/fieldtypemssql.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypemysql.xml b/framework/entity/fieldtype/fieldtypemysql.xml index beb9fa36d3..2f07bff189 100644 --- a/framework/entity/fieldtype/fieldtypemysql.xml +++ b/framework/entity/fieldtype/fieldtypemysql.xml @@ -46,8 +46,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypeoracle.xml b/framework/entity/fieldtype/fieldtypeoracle.xml index 03e66ab9fe..394951a0a4 100644 --- a/framework/entity/fieldtype/fieldtypeoracle.xml +++ b/framework/entity/fieldtype/fieldtypeoracle.xml @@ -60,8 +60,8 @@ under the License. - - + + diff --git a/framework/entity/fieldtype/fieldtypepostgres.xml b/framework/entity/fieldtype/fieldtypepostgres.xml index 8cb243e068..3e3555a5c1 100644 --
JIRA issue 12021 created for: RE: varchar(255) in fieldtypepostgres.xml
I guess I'm supposed to annnounce here that I created the JIRA issue... I've created a JIRA issue: https://issues.apache.org/jira/browse/OFBIZ-12021 Basically the fields "comment" and "description" are limited to 255 char. (note: most tables have a short name field that is seperate from the description field). I know I do, and I would imagine people could easily go over 255 char when writing things like a comment or description about something. I put a proposed fix in the JIRA issue. From: Jacques Le Roux [jacques.le.r...@les7arts.com] Sent: Tuesday, September 22, 2020 4:09 AM To: Development Cc: dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi, Since this is more an OFBiz development (improvement) than its usage, I recommend to create a Jira issue https://issues.apache.org/jira/projects/OFBIZ/summary And to refer to it from the dev ML https://ofbiz.apache.org/mailing-lists.html (please subscribe before if not done already) We need to discuss with the community. It would be a pity to work on it and get rebuffed by the community. I start by copying your message to the dev ML... TIA Jacques Le 20/09/2020 à 22:25, Development a écrit : > :) > > No problem. Obviously, i don't always respond to email right away either :) > > Since this email is long, I figured I should send it to you direct instead of > sending it to the list. > > Anyway, this is what I was thinking: > > > diff --git a/framework/entity/fieldtype/fieldtypeadvantage.xml > b/framework/entity/fieldtype/fieldtypeadvantage.xml > index 9f81c3ec42..c7fd6910fa 100644 > --- a/framework/entity/fieldtype/fieldtypeadvantage.xml > +++ b/framework/entity/fieldtype/fieldtypeadvantage.xml > @@ -50,8 +50,8 @@ under the License. >java-type="String"/> > > > - > - java-type="String"/> > + > + > > > > diff --git a/framework/entity/fieldtype/fieldtypeaxion.xml > b/framework/entity/fieldtype/fieldtypeaxion.xml > index 2ce5f3b13e..bc9cd405f8 100644 > --- a/framework/entity/fieldtype/fieldtypeaxion.xml > +++ b/framework/entity/fieldtype/fieldtypeaxion.xml > @@ -46,8 +46,8 @@ under the License. >java-type="String"/> > > > - java-type="String"/> > - java-type="String"/> > + > + > >java-type="String"/> > > diff --git a/framework/entity/fieldtype/fieldtypedaffodil.xml > b/framework/entity/fieldtype/fieldtypedaffodil.xml > index 8abda563f6..5a43a1e44b 100644 > --- a/framework/entity/fieldtype/fieldtypedaffodil.xml > +++ b/framework/entity/fieldtype/fieldtypedaffodil.xml > @@ -46,8 +46,8 @@ under the License. >java-type="String"/> > > > - java-type="String"/> > - java-type="String"/> > + > + >java-type="String"/> >java-type="String"/> > > diff --git a/framework/entity/fieldtype/fieldtypederby.xml > b/framework/entity/fieldtype/fieldtypederby.xml > index 80d2cfed14..d7aa9f7e45 100644 > --- a/framework/entity/fieldtype/fieldtypederby.xml > +++ b/framework/entity/fieldtype/fieldtypederby.xml > @@ -46,8 +46,8 @@ under the License. >java-type="String"/> > > > - java-type="String"/> > - java-type="String"/> > + > + > >java-type="String"/> > > diff --git a/framework/entity/fieldtype/fieldtypefirebird.xml > b/framework/entity/fieldtype/fieldtypefirebird.xml > index d449c1c4a9..191ef84c22 100644 > --- a/framework/entity/fieldtype/fieldtypefirebird.xml > +++ b/framework/entity/fieldtype/fieldtypefirebird.xml > @@ -46,8 +46,8 @@ under the License. >java-type="String"/> >java-type="String"/> > > - java-type="String"/> > - java-type="String"/> > + java-type="String"/> > + java-type="String"/> > >java-type="String"/> > > diff --git a/framework/entity/fieldtype/fieldtypehsql.xml > b/framework/entity/fieldtype/fieldtypehsql.xml > index fe96fff90a..3c72490ac9 100644 > --- a/framework/entity/fieldtype/fieldtypehsql.xml > +++ b/framework/entity/fieldtype/fieldtypehsql.xml > @@ -46,8 +46,8 @@ under the License. >java-type="String"/> > > > - java-type="String"/> > - java-type="String"/> > + > + > >java-type="String"/> > > diff --git a/framework/entity
Re: varchar(255) in fieldtypepostgres.xml
[jacques.le.r...@les7arts.com] Sent: Tuesday, September 08, 2020 4:34 AM To:dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi Development (is that a real name? :D), Sorry for the late reply, sure please do. Before: you want to change it where? In entityengine.xml I guess. If you want to put more information you might look at entity-engine.adoc Thanks Jacques Le 03/09/2020 à 18:36, Development a écrit : Thanks for the reply. The link essentially says "to make postgres consistent with the other databases". I researched it out, and found that *every single* supported database has a text type that goes over 255 char! (and gets used for type "very-long") I know I do, and I would imagine people could easily go over 255 char when writing things like a comment or description about something. Would it make sense to change description and comment field types for all databases to be whatever that database has for type "very-long"? If so, do I submit this as a JIRA issue? From: Jacques Le Roux [jacques.le.r...@les7arts.com] Sent: Tuesday, August 11, 2020 6:30 AM To:dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi, Please checkhttps://svn.apache.org/viewvc?view=revision=1697590 This is also relatedhttps://markmail.org/message/xuwhnbmum3evejwk Jacques Le 10/08/2020 à 20:30, Development a écrit : In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: In postgres, using "VARCHAR(255)" saves no space in the database over using "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 slows it down with error checking. Is there any reason on the ofbiz side to not just change this to plain "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 characters of it or something? Obviously I can do this for my own installation. I'm asking here cause it feels like something that should be pushed upstream. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
Re: varchar(255) in fieldtypepostgres.xml
Hi Development (is that a real name? :D), Sorry for the late reply, sure please do. Before: you want to change it where? In entityengine.xml I guess. If you want to put more information you might look at entity-engine.adoc Thanks Jacques Le 03/09/2020 à 18:36, Development a écrit : Thanks for the reply. The link essentially says "to make postgres consistent with the other databases". I researched it out, and found that *every single* supported database has a text type that goes over 255 char! (and gets used for type "very-long") I know I do, and I would imagine people could easily go over 255 char when writing things like a comment or description about something. Would it make sense to change description and comment field types for all databases to be whatever that database has for type "very-long"? If so, do I submit this as a JIRA issue? From: Jacques Le Roux [jacques.le.r...@les7arts.com] Sent: Tuesday, August 11, 2020 6:30 AM To: dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi, Please check https://svn.apache.org/viewvc?view=revision=1697590 This is also related https://markmail.org/message/xuwhnbmum3evejwk Jacques Le 10/08/2020 à 20:30, Development a écrit : In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: In postgres, using "VARCHAR(255)" saves no space in the database over using "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 slows it down with error checking. Is there any reason on the ofbiz side to not just change this to plain "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 characters of it or something? Obviously I can do this for my own installation. I'm asking here cause it feels like something that should be pushed upstream. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
RE: varchar(255) in fieldtypepostgres.xml
Thanks for the reply. The link essentially says "to make postgres consistent with the other databases". I researched it out, and found that *every single* supported database has a text type that goes over 255 char! (and gets used for type "very-long") I know I do, and I would imagine people could easily go over 255 char when writing things like a comment or description about something. Would it make sense to change description and comment field types for all databases to be whatever that database has for type "very-long"? If so, do I submit this as a JIRA issue? From: Jacques Le Roux [jacques.le.r...@les7arts.com] Sent: Tuesday, August 11, 2020 6:30 AM To: dev@ofbiz.apache.org Subject: Re: varchar(255) in fieldtypepostgres.xml Hi, Please check https://svn.apache.org/viewvc?view=revision=1697590 This is also related https://markmail.org/message/xuwhnbmum3evejwk Jacques Le 10/08/2020 à 20:30, Development a écrit : > In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: > > java-type="String"/> > java-type="String"/> > java-type="String"/> > > > In postgres, using "VARCHAR(255)" saves no space in the database over using > "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 > slows it down with error checking. > > Is there any reason on the ofbiz side to not just change this to plain > "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 > characters of it or something? > > Obviously I can do this for my own installation. I'm asking here cause it > feels like something that should be pushed upstream. > > > > > > > > CONFIDENTIALITY NOTICE: This message is intended only for the use of the > person or organization to which it is addressed or was intended to be > addressed, and may contain information that is privileged, confidential and > exempt from disclosure under applicable law. If the reader of this message is > not the intended recipient, or responsible for delivering the message to the > intended recipient, you are hereby notified that any dissemination, > distribution or copying of this communication is strictly prohibited. If you > have received this communication in error, please notify the sender > immediately by email and delete the original message immediately . The > sender, its subsidiaries and affiliates, do not accept liability for any > errors, omissions, corruption or virus in the contents of this message or any > attachments that arise as a result of e-mail transmission. Thank you. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
Re: varchar(255) in fieldtypepostgres.xml
Hi Roque, With this email I'm unsubscribing you from both dev and user ML. You speak about forums, if it's Nabble then you need to unsubscribe there HTH Jacques Le 11/08/2020 à 18:41, Roque Hernandez a écrit : Dear OfBiz, I have tried to unsubscribe from all of your email lists following the instructions on your website, but I am still getting many emails especially from forums. Please, help take care of this since I am trying to control the amount of emails I get to this account. Thank you in advance for your time. Sincerely, Roque Hernandez On Mon, Aug 10, 2020 at 1:31 PM Development wrote: In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: In postgres, using "VARCHAR(255)" saves no space in the database over using "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 slows it down with error checking. Is there any reason on the ofbiz side to not just change this to plain "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 characters of it or something? Obviously I can do this for my own installation. I'm asking here cause it feels like something that should be pushed upstream. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
Re: varchar(255) in fieldtypepostgres.xml
Dear OfBiz, I have tried to unsubscribe from all of your email lists following the instructions on your website, but I am still getting many emails especially from forums. Please, help take care of this since I am trying to control the amount of emails I get to this account. Thank you in advance for your time. Sincerely, Roque Hernandez On Mon, Aug 10, 2020 at 1:31 PM Development wrote: > > In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: > > java-type="String"/> > java-type="String"/> > java-type="String"/> > > > In postgres, using "VARCHAR(255)" saves no space in the database over > using "VARCHAR" (with no number) or "TEXT", the only difference is that the > 255 slows it down with error checking. > > Is there any reason on the ofbiz side to not just change this to plain > "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first > 255 characters of it or something? > > Obviously I can do this for my own installation. I'm asking here cause it > feels like something that should be pushed upstream. > > > > > > > > CONFIDENTIALITY NOTICE: This message is intended only for the use of the > person or organization to which it is addressed or was intended to be > addressed, and may contain information that is privileged, confidential and > exempt from disclosure under applicable law. If the reader of this message > is not the intended recipient, or responsible for delivering the message to > the intended recipient, you are hereby notified that any dissemination, > distribution or copying of this communication is strictly prohibited. If > you have received this communication in error, please notify the sender > immediately by email and delete the original message immediately . The > sender, its subsidiaries and affiliates, do not accept liability for any > errors, omissions, corruption or virus in the contents of this message or > any attachments that arise as a result of e-mail transmission. Thank you. >
Re: varchar(255) in fieldtypepostgres.xml
Hi, Please check https://svn.apache.org/viewvc?view=revision=1697590 This is also related https://markmail.org/message/xuwhnbmum3evejwk Jacques Le 10/08/2020 à 20:30, Development a écrit : In /framework/entity/fieldtype/fieldtypepostgres.xml I saw some lines like: In postgres, using "VARCHAR(255)" saves no space in the database over using "VARCHAR" (with no number) or "TEXT", the only difference is that the 255 slows it down with error checking. Is there any reason on the ofbiz side to not just change this to plain "VARCHAR" or "TEXT"? Like perhaps the forms would only display the first 255 characters of it or something? Obviously I can do this for my own installation. I'm asking here cause it feels like something that should be pushed upstream. CONFIDENTIALITY NOTICE: This message is intended only for the use of the person or organization to which it is addressed or was intended to be addressed, and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, or responsible for delivering the message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by email and delete the original message immediately . The sender, its subsidiaries and affiliates, do not accept liability for any errors, omissions, corruption or virus in the contents of this message or any attachments that arise as a result of e-mail transmission. Thank you.
