Review Request 26064: OODT-754 contribute ProdTypePatternMetExtractor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26064/ --- Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and Shakeh Khudikyan. Bugs: OODT-754 https://issues.apache.org/jira/browse/OODT-754 Repository: oodt Description --- This is a cleaned up version of the ProdTypePatternMetExtractor used at one point at CHLA. Wrote some unit tests (and fixed a bug!). Made sure to write some good javadocs and site docs too (they are basically the same as the wiki). Diffs - trunk/CHANGES.txt 1627442 trunk/metadata/pom.xml 1627442 trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/AbstractSAXConfigReader.java PRE-CREATION trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/ProdTypePatternMetExtractor.java PRE-CREATION trunk/metadata/src/site/xdoc/user/basic.xml 1627442 trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestAbstractSAXConfigReader.java PRE-CREATION trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestProdTypePatternMetExtractor.java PRE-CREATION trunk/metadata/src/testdata/product-type-patterns-2.xml PRE-CREATION trunk/metadata/src/testdata/product-type-patterns.xml PRE-CREATION Diff: https://reviews.apache.org/r/26064/diff/ Testing --- 2 test classes, one for the SAX reader and one for the met extractor. (1) testExtractMetadata: Sanity check, make sure it works as advertised. (2) testNewConfigFile: If a second config file is parsed, ignore the first config file. (3) testElementDeclarationOrder: The order of element declaration is independent of the order of usage in the product-type template. Thanks, Ricky Nguyen
Re: Review Request: String search and replace getMetadata(UUID with getMetadata(CAS.ProductId
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6892 --- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java https://reviews.apache.org/r/4709/#comment15336 i think paul mentioned this uuid too - Ricky On 2012-04-12 13:33:57, Thomas Bennett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ --- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary --- String search and replace getMetadata(UUID with getMetadata(CAS.ProductId This addresses bug OODT-440. https://issues.apache.org/jira/browse/OODT-440 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing --- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
Re: Review Request: String search and replace getMetadata(UUID with getMetadata(CAS.ProductId
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/#review6891 --- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java https://reviews.apache.org/r/4709/#comment15335 How about using CoreMetKeys.PRODUCT_ID ? - Ricky On 2012-04-12 13:33:57, Thomas Bennett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4709/ --- (Updated 2012-04-12 13:33:57) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Sheryl John. Summary --- String search and replace getMetadata(UUID with getMetadata(CAS.ProductId This addresses bug OODT-440. https://issues.apache.org/jira/browse/OODT-440 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/tools/SolrIndexer.java 1306745 Diff: https://reviews.apache.org/r/4709/diff Testing --- Unit test pass Works on my installed OODT ditribution Thanks, Thomas
Re: Review Request: filemgr query throws String index out of range: -1 when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4451/ --- (Updated 2012-03-22 23:47:07.464893) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Changes --- decided to write unit tests for QueryResult, instead of adding a test to TestSqlQueryCliAction Summary --- Cleaned up metadata to string methods of QueryResult. If metadata was empty, it was trying to delete a trailing comma that doesn't exist. This addresses bug OODT-427. https://issues.apache.org/jira/browse/OODT-427 Diffs (updated) - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java PRE-CREATION Diff: https://reviews.apache.org/r/4451/diff Testing --- Added unit test to check for empty metadata. Changed existing unit test to account for implementation-dependent ordering of keys. Thanks, Ricky
Review Request: filemgr query throws NPE when sorting by key with possibly empty values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/ --- Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- putting nulls last This addresses bug OODT-429. https://issues.apache.org/jira/browse/OODT-429 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION Diff: https://reviews.apache.org/r/4458/diff Testing --- wrote unit test Thanks, Ricky
Re: Review Request: filemgr query throws String index out of range: -1 when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4451/ --- (Updated 2012-03-22 22:55:46.864916) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- Cleaned up metadata to string methods of QueryResult. If metadata was empty, it was trying to delete a trailing comma that doesn't exist. This addresses bug OODT-427. https://issues.apache.org/jira/browse/OODT-427 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java 1303205 Diff: https://reviews.apache.org/r/4451/diff Testing --- Added unit test to check for empty metadata. Changed existing unit test to account for implementation-dependent ordering of keys. Thanks, Ricky
Re: Review Request: filemgr query throws String index out of range: -1 when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4451/ --- (Updated 2012-03-23 21:02:03.638390) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Changes --- 1) updated tests 2) added QueryResult.equals() (eclipse auto generated) Summary --- Cleaned up metadata to string methods of QueryResult. If metadata was empty, it was trying to delete a trailing comma that doesn't exist. This addresses bug OODT-427. https://issues.apache.org/jira/browse/OODT-427 Diffs (updated) - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResult.java PRE-CREATION Diff: https://reviews.apache.org/r/4451/diff Testing --- Added unit test to check for empty metadata. Changed existing unit test to account for implementation-dependent ordering of keys. Thanks, Ricky
Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/ --- (Updated 2012-03-23 21:19:16.059506) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Changes --- test with multiple nulls. since order of null items is indeterminate, take sublist of null items, then test size and test contains. Summary --- putting nulls last This addresses bug OODT-429. https://issues.apache.org/jira/browse/OODT-429 Diffs (updated) - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java 1303205 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/structs/query/TestQueryResultComparator.java PRE-CREATION Diff: https://reviews.apache.org/r/4458/diff Testing --- wrote unit test Thanks, Ricky
Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/#review6067 --- Ship it! LGTM! - Ricky On 2012-03-17 01:40:37, Chris Mattmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/ --- (Updated 2012-03-17 01:40:37) Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- DataSourceCatalog compatible with HypersonicSQL This addresses bug OODT-410. https://issues.apache.org/jira/browse/OODT-410 Diffs - ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java 1301321 ./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java 1301321 Diff: https://reviews.apache.org/r/4358/diff Testing --- Thanks, Chris
Review Request: OODT-424: clean build env doesn't work
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4406/ --- Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- * updated super POM to use java.net maven repo * added globus repo to FTP module * removed old xerces dep This addresses bug OODT-424. https://issues.apache.org/jira/browse/OODT-424 Diffs - trunk/core/pom.xml 1295249 trunk/curator/pom.xml 1295249 trunk/opendapps/pom.xml 1295249 trunk/profile/pom.xml 1295249 trunk/protocol/ftp/pom.xml 1295249 trunk/pushpull/pom.xml 1295249 Diff: https://reviews.apache.org/r/4406/diff Testing --- ran clean build on my machine I don't have jenkins access to run a one-off build to test these changes. Can someone do this? Thanks, Ricky
Re: Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4374/ --- (Updated 2012-03-16 03:18:23.793698) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT-413 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java 1301315 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestLuceneCatalog.java 1301315 Diff: https://reviews.apache.org/r/4374/diff Testing --- tested at CHLA with command: ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q SELECT VpsEpisodeStartTime FROM CernerEvents Thanks, Ricky
Re: Review Request: OODT-410: DataSourceCatalog compatible with HypersonicSQL
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/#review6043 --- ./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java https://reviews.apache.org/r/4358/#comment13016 I think HsqlDbFriendlyDataSourceCatalog.paginateQuery was missing an ORDER BY ... DESC clause here, whereas DataSourceCatalog (line 1960) does a descending sort. Since the primary key product_id is incremented (src/testdata/testcat.sql), and ShouldBeFirstForPage.txt is inserted LAST, DataSourceCatalog returns ShouldBeFirstForPage.txt as the first item on the FIRST page when ordered DESC. To me, it seems like DataSourceCatalog works properly and the test case needs to be modified. - Ricky On 2012-03-16 14:14:17, Chris Mattmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4358/ --- (Updated 2012-03-16 14:14:17) Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett. Summary --- DataSourceCatalog compatible with HypersonicSQL This addresses bug OODT-410. https://issues.apache.org/jira/browse/OODT-410 Diffs - ./trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java 1301321 ./trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java 1301321 Diff: https://reviews.apache.org/r/4358/diff Testing --- Thanks, Chris
Re: Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4374/ --- (Updated 2012-03-16 19:11:34.840950) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett. Changes --- I agree. reducedMet should equal fullMet for each element in the list, and replaceMetadata() guarantees that. Also, used list iterator syntactic sugar. Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT-413 Diffs (updated) - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java 1300633 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestLuceneCatalog.java 1300633 Diff: https://reviews.apache.org/r/4374/diff Testing --- tested at CHLA with command: ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q SELECT VpsEpisodeStartTime FROM CernerEvents Thanks, Ricky
Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4374/ --- Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Thomas Bennett. Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT-413 Diffs - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java 1300633 Diff: https://reviews.apache.org/r/4374/diff Testing --- tested at CHLA with command: ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q SELECT VpsEpisodeStartTime FROM CernerEvents Thanks, Ricky
Re: Review Request: OODT-413: filemgr query throws NPE when some products have undefined metadata values
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4374/ --- (Updated 2012-03-16 03:04:13.893499) Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and Thomas Bennett. Changes --- added unit test Summary --- filemgr query throws NPE when some products have undefined metadata values This addresses bug OODT-413. https://issues.apache.org/jira/browse/OODT-413 Diffs (updated) - trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/LuceneCatalog.java 1301315 trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestLuceneCatalog.java 1301315 Diff: https://reviews.apache.org/r/4374/diff Testing --- tested at CHLA with command: ./filemgr-client -u $FILEMGR_URL -op -sql -of '$VpsEpisodeStartTime' -q SELECT VpsEpisodeStartTime FROM CernerEvents Thanks, Ricky
Re: Review Request: OODT-361: Workflow test event fails with NPE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4089/ --- (Updated 2012-02-29 19:20:28.973385) Review request for oodt. Changes --- updated exception msg Summary --- When DateConvert.isoParse is given a null input, it throws NPE. Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it. This addresses bug OODT-361. https://issues.apache.org/jira/browse/OODT-361 Diffs (updated) - trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1295223 Diff: https://reviews.apache.org/r/4089/diff Testing --- Ran HelloWorld, GoodbyeWorld. Thanks, Ricky
Review Request: OODT-395: SerializableMetadata.toXml() doesn't set namespace on root element
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4088/ --- Review request for oodt. Summary --- Create metadata root element with a proper namespace and prefix. This addresses bug OODT-395. https://issues.apache.org/jira/browse/OODT-395 Diffs - trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/SerializableMetadata.java 1293402 trunk/metadata/src/test/org/apache/oodt/cas/metadata/TestSerializableMetadata.java 1293402 Diff: https://reviews.apache.org/r/4088/diff Testing --- Added unit test in TestSerializableMetadata#testNamespace() to demonstrate bug and fix. Thanks, Ricky
Review Request: OODT-361: Workflow test event fails with NPE
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4089/ --- Review request for oodt. Summary --- When DateConvert.isoParse is given a null input, it throws NPE. Solution is throw ParseException if input is null. WorkflowInstance catches ParseException and ignores it. This addresses bug OODT-361. https://issues.apache.org/jira/browse/OODT-361 Diffs - trunk/commons/src/main/java/org/apache/oodt/commons/util/DateConvert.java 1294802 Diff: https://reviews.apache.org/r/4089/diff Testing --- Ran HelloWorld, GoodbyeWorld. Thanks, Ricky
Re: Review Request: XMLPS should be able to stream large results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/#review5227 --- Ship it! After testing I believe this is good to go. trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java https://reviews.apache.org/r/3543/#comment11427 I remember receiving partial responses. Also the servlet API says to flush the output stream to commit the response. This is especially needed since we don't know the length of the response. http://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/ServletResponse.html#getOutputStream() trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java https://reviews.apache.org/r/3543/#comment11428 Quoted from servlet API here http://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/http/HttpServlet.html#doGet(javax.servlet.http.HttpServletRequest,%20javax.servlet.http.HttpServletResponse): Where possible, set the Content-Length header (with the ServletResponse.setContentLength(int) method), to allow the servlet container to use a persistent connection to return its response to the client, improving performance. The content length is automatically set if the entire response fits inside the response buffer. When using HTTP 1.1 chunked encoding (which means that the response has a Transfer-Encoding header), do not set the Content-Length header. - Thus, we don't set Content-Length and always use chunked Transfer-Encoding. Tested using cURL to watch the header values. Tomcat 5.5.35 : works Tomcat 6.0.35: works Tomcat 7.0.25: works trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java https://reviews.apache.org/r/3543/#comment11425 it is organized. OODT first, JDK second, removed unused imports. trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java https://reviews.apache.org/r/3543/#comment11426 yep organized. - Ricky On 2012-01-19 02:54:44, Ricky Nguyen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/ --- (Updated 2012-01-19 02:54:44) Review request for oodt. Summary --- See OODT-341: https://issues.apache.org/jira/browse/OODT-341 * CDEResult extends org.apache.oodt.xmlquery.Result * CDEResult mimetype is always text/plain * CDEResult size is always 0 * CDEResult inputstream is CDEResultInputStream * CDEResultInputStream has IO methods and wraps a CDEResult * CDEResult wraps a ResultSet and returns rows as Strings, applying MappingFuncs if a Mapping is provided, and appending constant fields if a List of CDEValues is provided. * ProductQueryServlet relies on servlet container to handle Content-Length (and possibly Transfer-Encoding: chunked) This addresses bug OODT-341. https://issues.apache.org/jira/browse/OODT-341 Diffs - trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java 1183564 trunk/xmlps/pom.xml 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResult.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResultInputStream.java PRE-CREATION Diff: https://reviews.apache.org/r/3543/diff Testing --- Runs in Tomcat 7. I've used it at CHLA. NOT tested in other app servers. Which other app servers should I test? NOT tested MappingFuncs. Is it necessary? Added 2 unit tests: TestCDEResult and TestCDEResultInputStream, which both pass. Thanks, Ricky
Re: Review Request: XMLPS should be able to stream large results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/ --- (Updated 2012-02-21 04:09:58.286025) Review request for oodt. Changes --- CDEResult.getSize() overridden to return -1. ProductQueryServlet only outputs Content-Length header when Result.getSize() = 0, in case other implementations of ProductHandler return Results that shouldn't be chunked. This is safer than always using chunked Transfer-Encoding (since the behavior is changed only for CDEResults). Summary --- See OODT-341: https://issues.apache.org/jira/browse/OODT-341 * CDEResult extends org.apache.oodt.xmlquery.Result * CDEResult mimetype is always text/plain * CDEResult size is always 0 * CDEResult inputstream is CDEResultInputStream * CDEResultInputStream has IO methods and wraps a CDEResult * CDEResult wraps a ResultSet and returns rows as Strings, applying MappingFuncs if a Mapping is provided, and appending constant fields if a List of CDEValues is provided. * ProductQueryServlet relies on servlet container to handle Content-Length (and possibly Transfer-Encoding: chunked) This addresses bug OODT-341. https://issues.apache.org/jira/browse/OODT-341 Diffs (updated) - trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java 1291543 trunk/xmlps/pom.xml 1291543 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java 1291543 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1291543 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1291543 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResult.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResultInputStream.java PRE-CREATION Diff: https://reviews.apache.org/r/3543/diff Testing --- Runs in Tomcat 7. I've used it at CHLA. NOT tested in other app servers. Which other app servers should I test? NOT tested MappingFuncs. Is it necessary? Added 2 unit tests: TestCDEResult and TestCDEResultInputStream, which both pass. Thanks, Ricky
Re: Review Request: XMLPS should be able to stream large results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/ --- (Updated 2012-01-19 02:54:44.310091) Review request for oodt. Summary --- See OODT-341: https://issues.apache.org/jira/browse/OODT-341 * CDEResult extends org.apache.oodt.xmlquery.Result * CDEResult mimetype is always text/plain * CDEResult size is always 0 * CDEResult inputstream is CDEResultInputStream * CDEResultInputStream has IO methods and wraps a CDEResult * CDEResult wraps a ResultSet and returns rows as Strings, applying MappingFuncs if a Mapping is provided, and appending constant fields if a List of CDEValues is provided. * ProductQueryServlet relies on servlet container to handle Content-Length (and possibly Transfer-Encoding: chunked) This addresses bug OODT-341. https://issues.apache.org/jira/browse/OODT-341 Diffs - trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java 1183564 trunk/xmlps/pom.xml 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResult.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResultInputStream.java PRE-CREATION Diff: https://reviews.apache.org/r/3543/diff Testing (updated) --- Runs in Tomcat 7. I've used it at CHLA. NOT tested in other app servers. Which other app servers should I test? NOT tested MappingFuncs. Is it necessary? Added 2 unit tests: TestCDEResult and TestCDEResultInputStream, which both pass. Thanks, Ricky
Review Request: XMLPS should be able to stream large results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/ --- Review request for oodt. Summary --- See OODT-341: https://issues.apache.org/jira/browse/OODT-341 * CDEResult extends org.apache.oodt.xmlquery.Result * CDEResult mimetype is always text/plain * CDEResult size is always 0 * CDEResult inputstream is CDEResultInputStream * CDEResultInputStream has IO methods and wraps a CDEResult * CDEResult wraps a ResultSet and returns rows as Strings, applying MappingFuncs if a Mapping is provided, and appending constant fields if a List of CDEValues is provided. * ProductQueryServlet relies on servlet container to handle Content-Length (and possibly Transfer-Encoding: chunked) This addresses bug OODT-341. https://issues.apache.org/jira/browse/OODT-341 Diffs - trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java 1183564 trunk/xmlps/pom.xml 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResult.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResultInputStream.java PRE-CREATION Diff: https://reviews.apache.org/r/3543/diff Testing --- Runs in Tomcat 7. I've used it at CHLA. NOT tested in other app servers. Added 2 unit tests: TestCDEResult and TestCDEResultInputStream, which both pass. Thanks, rickdn
Re: Review Request: XMLPS should be able to stream large results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/#review4462 --- trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java https://reviews.apache.org/r/3543/#comment10013 The MappingFuncs are applied in CDEResult#applyMappingFuncs() trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java https://reviews.apache.org/r/3543/#comment10014 Line 272 (latest) corresponds to line 250 (patched). trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java https://reviews.apache.org/r/3543/#comment10015 Appending constant values to the end of the row is now done in CDEResult#addConstValues() - Ricky On 2012-01-19 02:25:16, Ricky Nguyen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3543/ --- (Updated 2012-01-19 02:25:16) Review request for oodt. Summary --- See OODT-341: https://issues.apache.org/jira/browse/OODT-341 * CDEResult extends org.apache.oodt.xmlquery.Result * CDEResult mimetype is always text/plain * CDEResult size is always 0 * CDEResult inputstream is CDEResultInputStream * CDEResultInputStream has IO methods and wraps a CDEResult * CDEResult wraps a ResultSet and returns rows as Strings, applying MappingFuncs if a Mapping is provided, and appending constant fields if a List of CDEValues is provided. * ProductQueryServlet relies on servlet container to handle Content-Length (and possibly Transfer-Encoding: chunked) This addresses bug OODT-341. https://issues.apache.org/jira/browse/OODT-341 Diffs - trunk/grid/src/main/java/org/apache/oodt/grid/ProductQueryServlet.java 1183564 trunk/xmlps/pom.xml 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/DBMSExecutor.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1233127 trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResultInputStream.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResult.java PRE-CREATION trunk/xmlps/src/test/java/org/apache/oodt/xmlps/structs/TestCDEResultInputStream.java PRE-CREATION Diff: https://reviews.apache.org/r/3543/diff Testing --- Runs in Tomcat 7. I've used it at CHLA. NOT tested in other app servers. Added 2 unit tests: TestCDEResult and TestCDEResultInputStream, which both pass. Thanks, Ricky
