Re: [dev] changing the patch mechanism for external sources
On 01/23/09 16:10, Hans-Joachim Lankenau wrote: with the changes done in the cws ause099, each change now will reside in its own patch. for the local module makefiles, the only visible change is PATCH_FILE_NAME - PATCH_FILES. this variable now hold the list (and apply prder) of the existing patches. In some cases, logically coherent sets of modifications to some source evolve over time (e.g., more instances of #pragma GCC system_header in stlport/STLport-4.5.patch over time, as later GCC versions produce more extensive diagnostics). Is it still possible to keep those together in a single patch? -Stephan - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] changing the patch mechanism for external sources
hi! Stephan Bergmann wrote: On 01/23/09 16:10, Hans-Joachim Lankenau wrote: with the changes done in the cws ause099, each change now will reside in its own patch. for the local module makefiles, the only visible change is PATCH_FILE_NAME - PATCH_FILES. this variable now hold the list (and apply prder) of the existing patches. In some cases, logically coherent sets of modifications to some source evolve over time (e.g., more instances of #pragma GCC system_header in stlport/STLport-4.5.patch over time, as later GCC versions produce more extensive diagnostics). Is it still possible to keep those together in a single patch? sure. but strictly speaking, it's removing the old patch and appending a new one at the end of the PATCH_FILES list. with all consequences... the new dmake create_patch doesn't support modifying existing patches. tschau... ause - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
[dev] changing the patch mechanism for external sources
hi! in the current scenario, there is only one active patch per source tarball which has to contain all required changes for the build. as discussed in issue 40246, this may lead to duplication and hard to maintain patches. with the changes done in the cws ause099, each change now will reside in its own patch. for the local module makefiles, the only visible change is PATCH_FILE_NAME - PATCH_FILES. this variable now hold the list (and apply prder) of the existing patches. creating patches is almost the same as before (descibed in http://external.openoffice.org/ext_dmake.html) with the difference that each new patch requires two additional actions: - rename the new patch to the desired name - add the new patch at the end of PATCH_FILES the description will be updated once this cws is integrated. tschau... ause - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] changing the patch mechanism for external sources
On Fri, 2009-01-23 at 16:10 +0100, Hans-Joachim Lankenau wrote: hi! with the changes done in the cws ause099, each change now will reside in its own patch. for the local module makefiles, the only visible change is PATCH_FILE_NAME - PATCH_FILES. this variable now hold the list (and apply prder) of the existing patches. That's great, much appreciated. It'll really help divide up the changes made by OOo to imported external stuff into the bits done to get it built inside the OOo env, and the individual extra changes done either to simply backport some fixes from newer versions or add new features. C. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] changing the patch mechanism for external sources
Hi Ause, in the current scenario, there is only one active patch per source tarball which has to contain all required changes for the build. as discussed in issue 40246, this may lead to duplication and hard to maintain patches. with the changes done in the cws ause099, each change now will reside in its own patch. for the local module makefiles, the only visible change is PATCH_FILE_NAME - PATCH_FILES. this variable now hold the list (and apply prder) of the existing patches. That's great news indeed, it will make patch maintenance (and more importantly getting rid of patches) much easier. Thanks! Ciao Frank -- - Frank Schönheit, Software Engineer frank.schoenh...@sun.com - - Sun Microsystems http://www.sun.com/staroffice - - OpenOffice.org Base http://dba.openoffice.org - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] changing the patch mechanism for external sources
Hi, On 23.1.2009, at 16:10, Hans-Joachim Lankenau wrote: with the changes done in the cws ause099, each change now will reside in its own patch. for the local module makefiles, the only visible change is PATCH_FILE_NAME - PATCH_FILES. this variable now hold the list (and apply prder) of the existing patches. brilliant news! Thanks for it. Do we need to define some naming scheme for patches or should we keep the work of generating correct/random names to patchers? -- Pavel Janík - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
