Re: [Potlatch-dev] Git starter?

2011-08-31 Thread Steve Bennett
On Wed, Aug 31, 2011 at 5:01 AM, Andy Allan gravityst...@gmail.com wrote:
If there's any gotchas let me know.
Ok, since you asked:

First you need to get a copy of the potlatch2 repository from
somewhere. It doesn't really matter where it comes from...
...
There's many different ways to share your changes with the rest of
the world...

These are not good words to reassure the newcomer that these
instructions are simple will take him where he wants to go :)

 The github.com account is optional. When it comes to publishing your
 changes then yes, you do need to put them somewhere public, whether
 that be on github[1], another server, your own server, or where ever
 suits. When you have something published then just let one of us know
 where (e.g. by emailing the list) and we can start reviewing and
 incorporating your code.

I find this bit of using git somewhat deflating. With SVN, I was able
to commit my changes into the repository. Although the changes
weren't immediately in the production release (fortunately), other
developers would immediately see them next time they did an update.
Perhaps it's irrational, but committing to the repository is a lot
more satisfying than publishing to my own private repository and
hoping that someone comes along and takes a look.

Before:
svn commit

After:
git commit
Email list
Andy, Richard, or someone (who are the code reviewers, anyway?)
reviews changes, optionally accepts.

 If you need a hand with any of this just give me a shout, I'm more
 than happy to help.

I guess I'll have to try the github fork/clone thing again and see
what goes wrong again.

Steve

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Git starter?

2011-08-31 Thread Tom Hughes

On 31/08/11 10:46, Steve Bennett wrote:


I find this bit of using git somewhat deflating. With SVN, I was able
to commit my changes into the repository. Although the changes
weren't immediately in the production release (fortunately), other
developers would immediately see them next time they did an update.
Perhaps it's irrational, but committing to the repository is a lot
more satisfying than publishing to my own private repository and
hoping that someone comes along and takes a look.

Before:
svn commit

After:
git commit
Email list
Andy, Richard, or someone (who are the code reviewers, anyway?)
reviews changes, optionally accepts.


So basically you're complaining that your edits now have to be reviewed 
before they are merged and you can't ram them down people's throats anymore?


There's no need to hope that somebody comes along and takes a look 
though - that's why you send pull requests, whether on github or by 
email. That's you saying hey, I've got something good here I'd like you 
to consider for Potlatch and then your change can be considered for 
inclusion.


Tom

--
Tom Hughes (t...@compton.nu)
http://compton.nu/

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Git starter?

2011-08-31 Thread SomeoneElse

On 31/08/2011 10:46, Steve Bennett wrote:

On Wed, Aug 31, 2011 at 5:01 AM, Andy Allangravityst...@gmail.com  wrote:

If there's any gotchas let me know.

Ok, since you asked:

First you need to get a copy of the potlatch2 repository from
somewhere. It doesn't really matter where it comes from...
...
There's many different ways to share your changes with the rest of
the world...

These are not good words to reassure the newcomer that these
instructions are simple will take him where he wants to go :)



In case anyone hasn't seen it there's also Ed Loach's Getting a 
development copy of Potlatch 2 onto Windows 7 (64-bit)  list on 
http://wiki.openstreetmap.org/wiki/User:EdLoach .  There are probably 
others around.


Cheers,
Andy



___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] [OpenStreetMap] #3989: Wrong data entered for agricultural field

2011-08-31 Thread OpenStreetMap
#3989: Wrong data entered for agricultural field
-+--
 Reporter:  HillWithSmallFields  |   Owner:  potlatch-dev@…
 Type:  defect   |  Status:  new   
 Priority:  minor|   Milestone:
Component:  potlatch2| Version:  2.0   
 Keywords:   |  
-+--
 If you select agricultural -- field in the simple type selector, what
 actually goes into the data is landuse=meadow instead of
 landuse=field.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/3989
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Git starter?

2011-08-31 Thread Andy Allan
On Wed, Aug 31, 2011 at 4:13 PM, Steve Bennett stevag...@gmail.com wrote:

Yes, but this was causing lots of issues, as I'm sure you remember.

 Actually not - apart from my commiting changes in insufficient
 granularity. Happy to take your word for it, though.

A few other things spring instantly to mind - an ill-advised redesign
of the Undo system, a few problems with the Magic Roundabout system
(e.g. having a 50% chance of nuking a way when trying to shorten it)
and, more than anything else, lots of cases of commits generating
compiler warnings. That these commits were to trunk kept necessitating
other developers stepping up and fixing the build before they could
continue with their own work. That was getting quite disruptive.

 You're probably aware of the long-running debates about pre-commit
 review versus post-commit review. Quick summary: pre-commit review
 reduces developer activity level but improves quality.

I don't know much about the different approaches from a theoretical
viewpoint, except that the way were were doing it before caused us
lots of issues, and was making refactoring nigh on impossible.

As Richard has said, his master branch is the canonical 'this is
Potlatch2', so he's in charge

 Cool. This is the definitive statement lacking from the wiki page,
 which confused me.

I'd written that before the situation was clear. But there's also the
distinction that it's not necessarily what OSMF is deploying, and I
try to discourage anyone from getting worried about which repo to
clone from. If you clone from mine, and then want to pull changes from
someone else, it all comes out the same. Any notion of One True Repo
just causes more confusion later on!

 1) There is still a definitive repository

Make sure you realise that there's nothing that makes it the
definitive repository other than social factors. Unlike svn there's no
central repository. It's only definitive in that Richard is the
current maintainer, and the only difference he has over the rest of us
is that TomH generally doesn't disagree with him (on p2 matters at
least!). But you could also view the OSMF repo as definitive if you
care about the version that's actually deployed on osm.org

There are circumstances (we've done it two or three times already that
I can recall) where TomH pulls in bugfixes from my repo straight into
the OSMF one and deploys that, when RichardF wasn't around to update
his own repository. That's fine, git is totally decentralised like
that so it works.

Cheers,
Andy

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [OSM-dev] Osm2pgsql and failed planet import

2011-08-31 Thread Hartmut Holzgraefe
On 08/30/2011 11:50 AM, John Smith wrote:

 osm2pgsql doesn't have any code to check for memory allocation
 failures and to deal with it in a sane way, it just assumes all
 allocations are fine until it checks the nodes when going over pending
 ways etc. Anthony posted a patch a couple of months back, I didn't
 hear if the patch was added to the svn version(s).

i'm not aware of any other patch, but i changed the cache allocation
code quite recently to allocate the full configured cache size up
front instead of doing so in blocks of 8KB.

The main reason for this was that although all cache blocks get
freed once the cache is no longer needed all this memory is very
unlikely to get returned to the OS due to heap fragmentation.

Allocating everything up front has the advantage that malloc()
will use mmap() to map the cache memory into the process memory
space instead of putting it on the heap, and so it can later
be free()d without being affected by potential heap fragmentation.

As a side effect this also allows to check up front that there
is sufficient memory for the configured cache size instead of
running into out-of-memory situations only after the import had
already been going for potentially quite a while.

As the memory is really freed before the index building step now
it is possible to configure larger work_mem and maintenance_work_mem
buffers on the postgresql side without having to wait for the
unused-but-still-allocated osm2pgsql process memory gradually being
pushed out to swap over time.

Current code can be found here:

  https://github.com/hholzgra/osm2pgsql/tree/freeable_cache

-- 
hartmut

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


[OSM-dev] OSM Data to Distance Matrix

2011-08-31 Thread James Carlo Plaras
Good day,

I am working on a project related to arc routing as a part of my
undergraduate special problem. I wish to parse / convert the osm data file
to a distance matrix.

Are there existing libraries for converting osm data to distance matrix (or
something close)?

Thank you for reading the mail. Have a nice day.

-- 
*James Carlo Plaras*

BS Computer Science
University of the Philippines - Los Baños
___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


Re: [OSM-dev] java osm renderer

2011-08-31 Thread Martin Koppenhoefer
2011/8/31 BG mrharmo...@gmx.de:
 Hej.

 I want to try to make a renderer with java. But i do not know how i get the
 geometry information and interpret it.
 I think it would be easy to make sql requests about the objects to get. But
 the geometry column (which comes with postgis) confuses me, this is a bunch
 of numbers.


They are in a binary format, you can transform them to Text with ST_AsText
http://www.postgis.org/docs/ST_AsText.html

cheers,
Martin

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev


Re: [OSM-dev] java osm renderer

2011-08-31 Thread Sven Geggus
BG mrharmo...@gmx.de wrote:

 But the geometry column (which comes with postgis) confuses me, this is 
 a bunch of numbers.

It's a OGC standard Format called Well Known Binary (WKB)

Postgis provides a funktion (astext) which will transform it to WKT
(Well known text).

http://www.opengeospatial.org/standards

Regards

Sven

-- 
Ich fürchte mich nicht vor der Rückkehr der Faschisten in der Maske der
Faschisten, sondern vor der Rückkehr der Faschisten in der Maske der
Demokraten (Theodor W. Adorno)
/me is giggls@ircnet, http://sven.gegg.us/ on the Web

___
dev mailing list
dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/dev